eileen [Sat, 27 Apr 2019 06:48:09 +0000 (18:48 +1200)]
[cleanup] remove CRM_Report_Form_Extended
This file was added to core around 4.2 but for various reasons the ExtendedReport intiative
moved to an extension & it was never used. This just removes it
Eileen McNaughton [Sat, 27 Apr 2019 05:45:44 +0000 (17:45 +1200)]
Merge pull request #14142 from eileenmcnaughton/dedupe2
[REF] move gathering of location info to relevant function (towards dev/core#723)
Eileen McNaughton [Sat, 27 Apr 2019 05:31:01 +0000 (17:31 +1200)]
Merge pull request #14143 from eileenmcnaughton/dedupe3
dev/core#560 Remove a couple of instances of fatal errors in favour of throwing exceptions
Seamus Lee [Sat, 27 Apr 2019 05:23:22 +0000 (15:23 +1000)]
Merge pull request #14140 from eileenmcnaughton/dedupe
[REF] Move the qfbug handling to it's own function (towards dev/core#723)
Seamus Lee [Sat, 27 Apr 2019 04:40:00 +0000 (14:40 +1000)]
Merge pull request #14128 from agileware/CIVICRM-1143
Fixed double protocol being added in link by CKEditor.
eileen [Sat, 27 Apr 2019 04:28:33 +0000 (16:28 +1200)]
Remove a couple of instances of fatal errors in favour of throwing exceptions
https://lab.civicrm.org/dev/core/issues/560
eileen [Sat, 27 Apr 2019 04:13:00 +0000 (16:13 +1200)]
[REF] move gathering of location info to relevant function
We have a loop that parses the migrationInfo to get just location fields which we loop through, but
migrationInfo is already available in the moveLocationInfo fn so we can just handle that param in there
& improve code readability (we do a little less array looping but it's pretty cheap & the code
readabiliity is a real issue here
eileen [Sat, 27 Apr 2019 03:58:34 +0000 (15:58 +1200)]
Move the qfbug handling to it's own function
This is a really toxi function. In order to save the pain or iterating multiple times through a small array
we are dealing with an awful lot of complexity. I'm changing this to iterate through it multiple
times in order to rationalise the code - I think performance is minimal & being able to read the code....
Seamus Lee [Sat, 27 Apr 2019 02:03:37 +0000 (12:03 +1000)]
Merge pull request #14139 from agh1/upgrade-rebuild-caseact-views
dev/core#832 CiviCase: rebuild case activity views during upgrade
Andrew Hunt [Sat, 27 Apr 2019 00:10:33 +0000 (20:10 -0400)]
dev/core#832 CiviCase: rebuild case activity views during upgrade
Tim Otten [Fri, 26 Apr 2019 06:54:08 +0000 (23:54 -0700)]
Merge pull request #14131 from colemanw/resourceList
[REF] Use events for CMS resource loading
Seamus Lee [Fri, 26 Apr 2019 02:53:00 +0000 (12:53 +1000)]
Merge pull request #14133 from civicrm/5.13
5.13
Seamus Lee [Fri, 26 Apr 2019 01:03:59 +0000 (11:03 +1000)]
Merge pull request #14132 from seamuslee001/5.13
Add 5.12.4 release notes
Tim Otten [Thu, 25 Apr 2019 23:42:50 +0000 (16:42 -0700)]
Update 5.12.4.md
Tim Otten [Thu, 25 Apr 2019 23:42:03 +0000 (16:42 -0700)]
Update 5.12.4.md
Seamus Lee [Thu, 25 Apr 2019 23:31:42 +0000 (09:31 +1000)]
Update release notes
Seamus Lee [Thu, 25 Apr 2019 01:11:43 +0000 (11:11 +1000)]
Add 5.12.4 release notes
Coleman Watts [Thu, 25 Apr 2019 14:41:49 +0000 (10:41 -0400)]
Use events for CMS resource loading
Eileen McNaughton [Thu, 25 Apr 2019 22:03:34 +0000 (10:03 +1200)]
Merge pull request #14086 from agh1/caseactqueryfix
Case activity query performs poorly on large databases
Eileen McNaughton [Thu, 25 Apr 2019 21:52:30 +0000 (09:52 +1200)]
Merge pull request #14122 from colemanw/menubarHeight
[REF] Use variable for menubar height
Coleman Watts [Wed, 24 Apr 2019 17:55:08 +0000 (13:55 -0400)]
Use variable for menubar height
Monish Deb [Thu, 25 Apr 2019 11:24:25 +0000 (16:54 +0530)]
Merge pull request #13689 from eileenmcnaughton/no_record_payment
Call Payment.create from payment.cancel
Seamus Lee [Thu, 25 Apr 2019 09:38:32 +0000 (19:38 +1000)]
Merge pull request #14127 from civicrm/5.13
5.13
Seamus Lee [Thu, 25 Apr 2019 09:38:10 +0000 (19:38 +1000)]
Merge pull request #14126 from seamuslee001/dev_core_880
Fix typo in DROP table query.
Eileen McNaughton [Thu, 25 Apr 2019 07:34:45 +0000 (19:34 +1200)]
Merge pull request #14045 from totten/master-ab-winning
(REF; dev/core#873) MailingAB - Migrate "copy winner" logic from JS to PHP
mark burdett [Wed, 24 Apr 2019 18:32:32 +0000 (11:32 -0700)]
Fix typo in DROP table query.
Eileen McNaughton [Thu, 25 Apr 2019 04:34:03 +0000 (16:34 +1200)]
Merge pull request #14110 from mattwire/caseactivitylinks_partial
REF Don't pass activity object to addCaseActivityLinks
Eileen McNaughton [Thu, 25 Apr 2019 04:26:02 +0000 (16:26 +1200)]
Merge pull request #14112 from mattwire/action_filterlinks
Add function filterLinks to return an array of links for an entity that can be used by the API / form layer to generate a link
Eileen McNaughton [Thu, 25 Apr 2019 04:23:30 +0000 (16:23 +1200)]
Merge pull request #14109 from mattwire/refactor_inboundemailshared
REF Use shared function to check inbound email permissions
Eileen McNaughton [Wed, 24 Apr 2019 23:54:01 +0000 (11:54 +1200)]
Merge pull request #14121 from civicrm/revert-14063-core-553
Revert "dev/core#553: Creating new event takes value from default value not from saved template for custom fields"
Seamus Lee [Wed, 24 Apr 2019 23:47:02 +0000 (09:47 +1000)]
Merge pull request #14117 from eileenmcnaughton/import_3
[REF] Follow up tidy up on import fixes
eileen [Wed, 24 Apr 2019 03:33:56 +0000 (15:33 +1200)]
Follow up tidy up on import - use same fn for address
This is covered by testImportPrimaryAddressUpdate
Seamus Lee [Wed, 24 Apr 2019 21:30:23 +0000 (07:30 +1000)]
Merge pull request #14123 from mfb/drop-bug
dev/core#880: Fix typo in DROP table query.
Seamus Lee [Wed, 24 Apr 2019 20:09:10 +0000 (06:09 +1000)]
Merge pull request #14043 from eileenmcnaughton/import_2
Fix import primary phone, primary email, add tests
mark burdett [Wed, 24 Apr 2019 18:32:32 +0000 (11:32 -0700)]
Fix typo in DROP table query.
Yashodha Chaku [Wed, 24 Apr 2019 15:27:19 +0000 (20:57 +0530)]
Revert "dev/core#553: Creating new event takes value from default value not from saved template for custom fields"
Matthew Wire [Wed, 24 Apr 2019 09:53:13 +0000 (10:53 +0100)]
Merge pull request #13994 from eileenmcnaughton/recur_cancel
dev/core#846 Convert Recurring forms to entity forms
Yashodha Chaku [Wed, 24 Apr 2019 07:00:25 +0000 (12:30 +0530)]
Merge pull request #14063 from JMAConsulting/core-553
dev/core#553: Creating new event takes value from default value not from saved template for custom fields
eileen [Fri, 12 Apr 2019 07:51:50 +0000 (17:51 +1000)]
Fix handling of importing 'primary
' phone & email and enable test
Prior to this selecting 'Primary' as location_type_id for phone or email will result in duplicates.
This also simplifies the indexing to be by location type, as it is with addresses, as the code is kinda
confusing
Eileen McNaughton [Tue, 23 Apr 2019 23:06:49 +0000 (09:06 +1000)]
Merge pull request #14108 from mattwire/form_activity_hardcoded_ids
REF Replace hardcoded IDs with pseudoconstants in activity form
Seamus Lee [Tue, 23 Apr 2019 05:49:37 +0000 (15:49 +1000)]
Merge pull request #14115 from civicrm/5.13
5.13
Seamus Lee [Tue, 23 Apr 2019 04:17:21 +0000 (14:17 +1000)]
Merge pull request #14114 from lcdservices/5.13
dev/core#891 condition on id existenced when retrieving mailing hash
Brian Shaughnessy [Tue, 23 Apr 2019 01:43:19 +0000 (21:43 -0400)]
dev/core#891 condition on id existenced when retrieving mailing hash
Seamus Lee [Tue, 23 Apr 2019 01:51:26 +0000 (11:51 +1000)]
Merge pull request #14084 from colemanw/UFFieldBAO
(REF) Standardize UFField create function
Coleman Watts [Mon, 22 Apr 2019 12:22:13 +0000 (08:22 -0400)]
Add UFField to syntaxConformanceTest
Seamus Lee [Mon, 22 Apr 2019 20:27:38 +0000 (06:27 +1000)]
Merge pull request #14105 from eileenmcnaughton/import
[REF] calll formatLocationBlock from parent function.
Seamus Lee [Mon, 22 Apr 2019 20:27:18 +0000 (06:27 +1000)]
Merge pull request #14107 from mattwire/formbuttons_formatting
NFC Whitespace formatting for formButtons.tpl
Seamus Lee [Mon, 22 Apr 2019 20:26:53 +0000 (06:26 +1000)]
Merge pull request #14111 from mlutfy/sms-ts
Fix ts() usage in CRM_SMS_Form_Schedule
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 12:22:08 +0000 (13:22 +0100)]
Replace hardcoded IDs with pseudoconstants in activity form
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 14:08:50 +0000 (15:08 +0100)]
Add function filterLinks to return an array of links for an entity that can be used by the API / form layer to generate a link
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 12:38:00 +0000 (13:38 +0100)]
Refactor-Don't pass activity object to addCaseActivityLinks
Mathieu Lutfy [Mon, 22 Apr 2019 13:20:28 +0000 (09:20 -0400)]
Fix ts() usage in CRM_SMS_Form_Schedule
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 12:24:13 +0000 (13:24 +0100)]
Use shared function to check inbound email permissions
Coleman Watts [Thu, 18 Apr 2019 18:00:51 +0000 (14:00 -0400)]
(REF) Standardize UFField create function
Coleman Watts [Thu, 18 Apr 2019 17:52:25 +0000 (13:52 -0400)]
Fix creating Formatting fields in api and UI
Matthew Wire (MJW Consulting) [Mon, 22 Apr 2019 11:54:41 +0000 (12:54 +0100)]
Whitespace formatting for formButtons.tpl
eileen [Fri, 12 Apr 2019 07:55:15 +0000 (17:55 +1000)]
Remove now-redundant if
This is no longer called when location_type_id is empty
eileen [Fri, 12 Apr 2019 07:18:11 +0000 (17:18 +1000)]
[REF] calll formatLocationBlock from parent function.
This is about starting to unnest the spaghetti of functions here.....
Just deprecating for now in case
Eileen McNaughton [Mon, 22 Apr 2019 08:03:25 +0000 (18:03 +1000)]
Merge pull request #14099 from seamuslee001/pledge_dates_contribution_form_conversion
Convert Pledge Calander Date and Start Date for pledges to use datepic…
Seamus Lee [Sun, 21 Apr 2019 23:45:41 +0000 (09:45 +1000)]
Convert Pledge Calander Date and Start Date for pleges to use datepicker rather than jcalendar
Seamus Lee [Mon, 22 Apr 2019 02:41:41 +0000 (12:41 +1000)]
Merge pull request #14101 from civicrm/5.13
5.13
Seamus Lee [Mon, 22 Apr 2019 01:52:07 +0000 (11:52 +1000)]
Merge pull request #14100 from seamuslee001/5.13
Add release-notes/5.12.3.md
Tim Otten [Sat, 20 Apr 2019 15:44:42 +0000 (08:44 -0700)]
Add release-notes/5.12.3.md
Seamus Lee [Mon, 22 Apr 2019 00:27:38 +0000 (10:27 +1000)]
Merge pull request #13890 from aydun/joomla#6
Fix bug preventing affecting `cv --user` on Joomla
colemanw [Sun, 21 Apr 2019 17:32:18 +0000 (13:32 -0400)]
Merge pull request #14096 from colemanw/tags
Add serialize metadata to tag used_for field
Coleman Watts [Sun, 21 Apr 2019 15:08:18 +0000 (11:08 -0400)]
Remove problematic serialize handing from conformance test
Eileen McNaughton [Sun, 21 Apr 2019 01:27:35 +0000 (11:27 +1000)]
Merge pull request #14088 from MegaphoneJon/membership-9
membership#9 - show user a notification on back-office renewals
Coleman Watts [Sun, 21 Apr 2019 00:24:08 +0000 (20:24 -0400)]
Add serialize metadata to tag used_for field
The used_for field is a comma separated list.
Seamus Lee [Sat, 20 Apr 2019 20:41:11 +0000 (06:41 +1000)]
Merge pull request #13963 from eileenmcnaughton/event_report
Readability cleanup on EventIncome report (towards bringing it under testing)
colemanw [Sat, 20 Apr 2019 13:42:47 +0000 (09:42 -0400)]
Merge pull request #14094 from seamuslee001/node_dedupe_exception_test
(NFC) Add tests of retreiving notes for display on a contact record a…
eileen [Sun, 7 Apr 2019 21:50:56 +0000 (09:50 +1200)]
Convert Recurring forms to entity forms
Eileen McNaughton [Sat, 20 Apr 2019 07:35:23 +0000 (17:35 +1000)]
Merge pull request #14091 from civicrm/5.13
5.13
Seamus Lee [Sat, 20 Apr 2019 03:50:28 +0000 (13:50 +1000)]
(NFC) Add tests of retreiving notes for display on a contact record and returning DedupeExecptions for output on page
Update Unit test to check output of note browse as well
Seamus Lee [Sat, 20 Apr 2019 03:20:55 +0000 (13:20 +1000)]
Merge pull request #14073 from seamuslee001/dev_core_881_unit_test
dev/core#881 Add in unit test demonstrating issue Stoob found with is…
Seamus Lee [Sat, 20 Apr 2019 02:18:43 +0000 (12:18 +1000)]
Merge pull request #14092 from eileenmcnaughton/search_513
dev/core#887 Fix fatal error on pledge search
Eileen McNaughton [Sat, 20 Apr 2019 01:23:04 +0000 (11:23 +1000)]
Merge pull request #14083 from grischard/patch-1
Fix upgrade message db setting location
eileen [Fri, 5 Apr 2019 01:15:12 +0000 (14:15 +1300)]
Readability cleanup on EventIncome report to bring it under testing
colemanw [Sat, 20 Apr 2019 01:06:08 +0000 (21:06 -0400)]
Merge pull request #14052 from yashodha/dev-876
(dev/core#876) Allow url to set IS NULL/ NOT NULL in report for opera…
colemanw [Sat, 20 Apr 2019 01:04:25 +0000 (21:04 -0400)]
Merge pull request #14059 from Stoob/patch-2
change is_override logic
colemanw [Sat, 20 Apr 2019 01:00:42 +0000 (21:00 -0400)]
Merge pull request #14077 from pradpnayak/AutoComplete
Fixed auto populate of contact refrence field on membership signup form
colemanw [Sat, 20 Apr 2019 00:58:27 +0000 (20:58 -0400)]
Merge pull request #14050 from eileenmcnaughton/import
[REF] cleanup input parameters on extracted function
eileen [Sat, 20 Apr 2019 00:56:36 +0000 (10:56 +1000)]
dev/core#887 Fix fatal error on pledge search
Tim Otten [Fri, 19 Apr 2019 23:05:14 +0000 (16:05 -0700)]
Merge pull request #14090 from seamuslee001/5.13
Add release-notes/5.12.2.md
Tim Otten [Fri, 19 Apr 2019 22:59:22 +0000 (15:59 -0700)]
Add release-notes/5.12.2.md
Andrew Hunt [Fri, 19 Apr 2019 22:40:16 +0000 (18:40 -0400)]
CiviCase: use aliases on all items in case activity query b/c ANY_VALUE
Jon Goldberg [Fri, 19 Apr 2019 22:20:00 +0000 (18:20 -0400)]
membership#9 - show user a notification on back-office renewals
Andrew Hunt [Fri, 19 Apr 2019 20:41:01 +0000 (16:41 -0400)]
CiviCase: remove multi-nested subqueries when work now handled by views
Andrew Hunt [Fri, 19 Apr 2019 20:06:24 +0000 (16:06 -0400)]
CiviCase: test for activity query latest activity
Andrew Hunt [Fri, 19 Apr 2019 19:13:54 +0000 (15:13 -0400)]
CiviCase: recent case activity view pull one per case
Andrew Hunt [Fri, 19 Apr 2019 14:51:36 +0000 (10:51 -0400)]
CiviCase: simplify activity type, date, and id fields in case activity query
colemanw [Fri, 19 Apr 2019 13:12:18 +0000 (09:12 -0400)]
Merge pull request #14085 from totten/master-cron-doc
Cron Status Check - Better hyperlinks
Andrew Hunt [Thu, 18 Apr 2019 23:40:50 +0000 (19:40 -0400)]
CiviCase: convoluted subquery in case activity query
Andrew Hunt [Thu, 18 Apr 2019 23:19:39 +0000 (19:19 -0400)]
CiviCase: use pseudoconstants in case activity query
Matthew Wire [Thu, 18 Apr 2019 20:44:09 +0000 (21:44 +0100)]
Merge pull request #14079 from colemanw/setValues
(REF) Fix accepted params in CustomValueTable::setValues
Matthew Wire [Thu, 18 Apr 2019 20:35:03 +0000 (21:35 +0100)]
Merge pull request #14075 from colemanw/contactBAO
(REF) Fix unnecessary required param in contact BAO update
colemanw [Thu, 18 Apr 2019 17:58:18 +0000 (13:58 -0400)]
Merge pull request #14067 from colemanw/menuZindex
Menubar z-index fixes
Tim Otten [Thu, 18 Apr 2019 17:31:27 +0000 (10:31 -0700)]
Cron Status Check - Better hyperlinks
* The old link pointed to a frozen wiki page with bad styling
* The old link was buried
Tim Otten [Thu, 18 Apr 2019 17:30:35 +0000 (10:30 -0700)]
CRM_Utils_System - Allow docURL functions to support "sysadmin" and "dev" links
colemanw [Thu, 18 Apr 2019 14:21:47 +0000 (10:21 -0400)]
Merge pull request #14014 from MegaphoneJon/reporting-14
fix getAddressColumns() to respect tableAlias
Guillaume Rischard [Thu, 18 Apr 2019 13:58:19 +0000 (15:58 +0200)]
Fix upgrade message db setting location