civicrm-core.git
15 months agoadd real-world example test
demeritcowboy [Fri, 21 Jul 2023 03:34:09 +0000 (23:34 -0400)]
add real-world example test

15 months agoSet version to 5.65.beta1
CiviCRM [Thu, 3 Aug 2023 22:06:24 +0000 (22:06 +0000)]
Set version to 5.65.beta1

15 months agoMerge pull request #26303 from larssandergreen/Allow-multiple-registrations-from...
Eileen McNaughton [Thu, 3 Aug 2023 22:05:53 +0000 (10:05 +1200)]
Merge pull request #26303 from larssandergreen/Allow-multiple-registrations-from-search-actions

Allow multiple registrations from search actions

15 months agoMerge pull request #26957 from eileenmcnaughton/price_field
Seamus Lee [Thu, 3 Aug 2023 21:56:59 +0000 (17:56 -0400)]
Merge pull request #26957 from eileenmcnaughton/price_field

Notice fixes on CiviEvent Component settings form

15 months agoMerge pull request #26999 from totten/master-snapshot-b
Tim Otten [Thu, 3 Aug 2023 21:18:48 +0000 (14:18 -0700)]
Merge pull request #26999 from totten/master-snapshot-b

5.65.alpha1 - Define pre-upgrade snapshots (Option B)

15 months agoMerge pull request #26996 from colemanw/adminTitle
Eileen McNaughton [Thu, 3 Aug 2023 20:53:14 +0000 (08:53 +1200)]
Merge pull request #26996 from colemanw/adminTitle

[REF] CRM_Admin_Form - Use metadata instead of boilerplate to set page title

15 months ago5.65.alpha1.mysql.tpl - Add pre-upgrade snapshots for existing upgrade-steps
Tim Otten [Thu, 3 Aug 2023 08:34:29 +0000 (01:34 -0700)]
5.65.alpha1.mysql.tpl - Add pre-upgrade snapshots for existing upgrade-steps

15 months agoSmarty SQL - Add helper {crmUpgradeSnapshot}
Tim Otten [Thu, 3 Aug 2023 08:47:39 +0000 (01:47 -0700)]
Smarty SQL - Add helper {crmUpgradeSnapshot}

15 months agoCRM_Upgrade_Snapshot - Add helper `createSingleTask()`
Tim Otten [Thu, 3 Aug 2023 08:29:09 +0000 (01:29 -0700)]
CRM_Upgrade_Snapshot - Add helper `createSingleTask()`

This is an alternative to `createTasks()`. It's suitable for the kinds of small/mid-sized
queries that appear in `*.mysql.tpl` files.

15 months agoUpgrader - Supply $upgradeRev for Smarty TPLs
Tim Otten [Thu, 3 Aug 2023 07:38:39 +0000 (00:38 -0700)]
Upgrader - Supply $upgradeRev for Smarty TPLs

15 months agoCRM_Admin_Form - Use metadata instead of boilerplate to set page title
colemanw [Thu, 3 Aug 2023 03:35:32 +0000 (23:35 -0400)]
CRM_Admin_Form - Use metadata instead of boilerplate to set page title

15 months agoMerge pull request #26854 from colemanw/searchKitLinkPerformance
Eileen McNaughton [Wed, 2 Aug 2023 22:45:35 +0000 (10:45 +1200)]
Merge pull request #26854 from colemanw/searchKitLinkPerformance

SearchKit - Improve performance of checking link permissions

15 months agoMerge pull request #26992 from civicrm/5.64
Seamus Lee [Wed, 2 Aug 2023 22:18:51 +0000 (18:18 -0400)]
Merge pull request #26992 from civicrm/5.64

5.64

15 months agoMerge pull request #26840 from colemanw/autocompleteById
Eileen McNaughton [Wed, 2 Aug 2023 22:13:57 +0000 (10:13 +1200)]
Merge pull request #26840 from colemanw/autocompleteById

Api4 Autocomplete - Search by exact id match more effieciently

15 months agoMerge pull request #26990 from larssandergreen/Fix-price-field-url-regression
Seamus Lee [Wed, 2 Aug 2023 21:53:33 +0000 (17:53 -0400)]
Merge pull request #26990 from larssandergreen/Fix-price-field-url-regression

dev/core#4469 - Fix price set field path regression

15 months agoMerge pull request #26991 from agh1/5.64.0-releasenotes-final
Seamus Lee [Wed, 2 Aug 2023 21:51:45 +0000 (17:51 -0400)]
Merge pull request #26991 from agh1/5.64.0-releasenotes-final

5.64.0 release notes late changes

15 months agoMerge branch '5.64'
Seamus Lee [Wed, 2 Aug 2023 21:49:40 +0000 (07:49 +1000)]
Merge branch '5.64'

15 months agoUpdate 5.63.2.md
Tim Otten [Wed, 26 Jul 2023 07:21:53 +0000 (00:21 -0700)]
Update 5.63.2.md

15 months agoAdd release-notes/5.63.2.md
Tim Otten [Wed, 26 Jul 2023 06:45:42 +0000 (23:45 -0700)]
Add release-notes/5.63.2.md

15 months agoAdd release-notes/5.63.1.md
Tim Otten [Fri, 7 Jul 2023 18:45:16 +0000 (11:45 -0700)]
Add release-notes/5.63.1.md

15 months agoAdd release-notes/5.62.1.md
Tim Otten [Fri, 16 Jun 2023 05:10:13 +0000 (22:10 -0700)]
Add release-notes/5.62.1.md

15 months agoAdd release-notes/5.61.4.md
Tim Otten [Wed, 24 May 2023 06:38:56 +0000 (23:38 -0700)]
Add release-notes/5.61.4.md

15 months agoAdd release-notes/5.61.3.md
Tim Otten [Sat, 20 May 2023 00:44:11 +0000 (17:44 -0700)]
Add release-notes/5.61.3.md

15 months agoAdd release-notes/5.61.2.md
Tim Otten [Mon, 8 May 2023 23:10:10 +0000 (16:10 -0700)]
Add release-notes/5.61.2.md

15 months agoMerge pull request #26989 from demeritcowboy/regen
Seamus Lee [Wed, 2 Aug 2023 21:43:30 +0000 (17:43 -0400)]
Merge pull request #26989 from demeritcowboy/regen

civicrm_generated is out of date in 5.64

15 months agoAdd release-notes/5.61.1.md
Tim Otten [Fri, 5 May 2023 20:49:51 +0000 (13:49 -0700)]
Add release-notes/5.61.1.md

15 months agoAdd release-notes/5.59.4.md
Tim Otten [Mon, 27 Mar 2023 20:35:57 +0000 (13:35 -0700)]
Add release-notes/5.59.4.md

15 months agoAdd release-notes/5.59.3.md
Tim Otten [Thu, 16 Mar 2023 00:23:52 +0000 (17:23 -0700)]
Add release-notes/5.59.3.md

15 months agoAdd release-notes/5.59.2.md
Tim Otten [Sat, 11 Mar 2023 00:29:22 +0000 (16:29 -0800)]
Add release-notes/5.59.2.md

15 months agoAdd release-notes/5.59.1.md
Tim Otten [Sat, 4 Mar 2023 03:42:11 +0000 (19:42 -0800)]
Add release-notes/5.59.1.md

15 months agoUpdate 5.58.1.md
Tim Otten [Wed, 15 Feb 2023 23:58:14 +0000 (15:58 -0800)]
Update 5.58.1.md

15 months agoAdd release-notes/5.58.1.md
Tim Otten [Wed, 15 Feb 2023 21:54:30 +0000 (13:54 -0800)]
Add release-notes/5.58.1.md

15 months ago5.64.0 release notes: added late changes
Andie Hunt [Wed, 2 Aug 2023 21:40:02 +0000 (17:40 -0400)]
5.64.0 release notes: added late changes

15 months agoFix price set field path regression
larssandergreen [Wed, 2 Aug 2023 21:24:44 +0000 (15:24 -0600)]
Fix price set field path regression

15 months agoMerge pull request #26986 from mattwire/paymentvarsref
demeritcowboy [Wed, 2 Aug 2023 20:58:25 +0000 (16:58 -0400)]
Merge pull request #26986 from mattwire/paymentvarsref

REF: Rename variables to make it easier to understand what the code is doing

15 months agoregen
demeritcowboy [Wed, 2 Aug 2023 20:55:10 +0000 (16:55 -0400)]
regen

15 months agopopulate another frontend_title
demeritcowboy [Wed, 2 Aug 2023 20:49:32 +0000 (16:49 -0400)]
populate another frontend_title

15 months agoMerge pull request #26975 from eileenmcnaughton/re-used
demeritcowboy [Wed, 2 Aug 2023 20:29:28 +0000 (16:29 -0400)]
Merge pull request #26975 from eileenmcnaughton/re-used

E-notice fix (smarty)

15 months agoMerge pull request #26984 from colemanw/daoFixeyUppey
demeritcowboy [Wed, 2 Aug 2023 20:17:17 +0000 (16:17 -0400)]
Merge pull request #26984 from colemanw/daoFixeyUppey

DAO - Normalize null values in the writeRecord function to avoid subtle bugs

15 months agoRename variables to make it easier to understand what the code is doing
Matthew Wire [Wed, 2 Aug 2023 19:14:20 +0000 (20:14 +0100)]
Rename variables to make it easier to understand what the code is doing

15 months agoMerge pull request #26950 from eileenmcnaughton/deprecate
colemanw [Wed, 2 Aug 2023 17:01:13 +0000 (13:01 -0400)]
Merge pull request #26950 from eileenmcnaughton/deprecate

Deprecate probably never true condition

15 months agoE-notice fix (smarty)
Eileen McNaughton [Mon, 31 Jul 2023 23:10:12 +0000 (11:10 +1200)]
E-notice fix (smarty)

15 months agoFix test set up
Eileen McNaughton [Fri, 28 Jul 2023 02:22:01 +0000 (14:22 +1200)]
Fix test set up

15 months agoDeprecate probably never true condition
Eileen McNaughton [Thu, 27 Jul 2023 23:27:53 +0000 (11:27 +1200)]
Deprecate probably never true condition

If we can clarify that price set is ALWAYS set it will simplify stuff
- comments suggest that the exception has been weird test config

15 months agoDAO - Normalize null values in the writeRecord function to avoid subtle bugs
colemanw [Tue, 1 Aug 2023 23:00:16 +0000 (19:00 -0400)]
DAO - Normalize null values in the writeRecord function to avoid subtle bugs

Passing around the string 'null' was a terrible practice and can lead to bugs when you use
an operator like `empty()` on the value.

15 months agoMerge pull request #26961 from eileenmcnaughton/quick_config
Yashodha Chaku [Tue, 1 Aug 2023 06:20:32 +0000 (11:50 +0530)]
Merge pull request #26961 from eileenmcnaughton/quick_config

Use `isQuickConfig()` to determine isQuickConfig (towards php8.x fix)

15 months agoMerge pull request #26913 from eileenmcnaughton/subscribe_2
Seamus Lee [Tue, 1 Aug 2023 01:57:20 +0000 (21:57 -0400)]
Merge pull request #26913 from eileenmcnaughton/subscribe_2

Update Group Subscribe message to use frontend_title

15 months agoMerge pull request #26962 from eileenmcnaughton/test_fix_mem
Seamus Lee [Tue, 1 Aug 2023 01:55:43 +0000 (21:55 -0400)]
Merge pull request #26962 from eileenmcnaughton/test_fix_mem

[php8.x] Fix test to use full form flow

15 months agoMerge pull request #26973 from aydun/adminui_price_paths2
Eileen McNaughton [Mon, 31 Jul 2023 23:38:34 +0000 (11:38 +1200)]
Merge pull request #26973 from aydun/adminui_price_paths2

Metadata tweaks for Price Sets, Fields & Values

15 months agoFollow up to https://github.com/civicrm/civicrm-core/pull/26929
Aidan Saunders [Mon, 31 Jul 2023 19:09:27 +0000 (20:09 +0100)]
Follow up to https://github.com/civicrm/civicrm-core/pull/26929
- fix unreleased regression relating to adding new price set fields and
  values
- add Upgrader
Switch html type from Select to EntityRef for Price Fields and Values

15 months agoMerge pull request #26972 from civicrm/5.64
Yashodha Chaku [Mon, 31 Jul 2023 14:52:16 +0000 (20:22 +0530)]
Merge pull request #26972 from civicrm/5.64

5.64

15 months agoMerge pull request #25605 from kurund/radio-defaults
colemanw [Mon, 31 Jul 2023 14:25:02 +0000 (07:25 -0700)]
Merge pull request #25605 from kurund/radio-defaults

dev/core#3777 Afform: fix the setting defaults for radio and checkboxes when values are non-string

15 months agofix the setting defaults for radio and checkboxes when values are non-string
Kurund Jalmi [Fri, 17 Feb 2023 22:00:34 +0000 (22:00 +0000)]
fix the setting defaults for radio and checkboxes when values are non-string

15 months agoMerge pull request #26966 from artfulrobot/standalone-login-redirects
Rich Lott [Mon, 31 Jul 2023 10:22:22 +0000 (11:22 +0100)]
Merge pull request #26966 from artfulrobot/standalone-login-redirects

standalone: Redirect to login

15 months agostandalone: redirect to login
Rich Lott / Artful Robot [Mon, 31 Jul 2023 10:19:40 +0000 (11:19 +0100)]
standalone: redirect to login

15 months agoMerge pull request #26968 from alifrumin/5.64rn
Seamus Lee [Mon, 31 Jul 2023 03:51:47 +0000 (23:51 -0400)]
Merge pull request #26968 from alifrumin/5.64rn

[NFC] 5.64 release notes

15 months agoMerge pull request #26674 from larssandergreen/Show-bounce-history-on-contact-summary
colemanw [Sun, 30 Jul 2023 20:09:36 +0000 (13:09 -0700)]
Merge pull request #26674 from larssandergreen/Show-bounce-history-on-contact-summary

Show Email bounce history on Contact summary

15 months agoMerge pull request #26971 from colemanw/colemanw-patch-1
colemanw [Sun, 30 Jul 2023 02:47:37 +0000 (19:47 -0700)]
Merge pull request #26971 from colemanw/colemanw-patch-1

ManagedEntityTest - Simplify reconciliation

15 months agoManagedEntityTest - Simplify reconciliation
colemanw [Sun, 30 Jul 2023 02:00:21 +0000 (22:00 -0400)]
ManagedEntityTest - Simplify reconciliation

Followup to #26970 which solved the problem; this removes the workarounds that are no longer needed.

15 months agoMerge pull request #26970 from larssandergreen/Fix-Managed-Entity-test
colemanw [Sun, 30 Jul 2023 01:32:56 +0000 (18:32 -0700)]
Merge pull request #26970 from larssandergreen/Fix-Managed-Entity-test

Limit Managed Entity test reconciliation to the entities in the test

16 months agoLimit Managed Entity test reconciliation to the entities in the test
larssandergreen [Sun, 30 Jul 2023 00:20:47 +0000 (18:20 -0600)]
Limit Managed Entity test reconciliation to the entities in the test

16 months agoMerge pull request #26960 from eileenmcnaughton/billing
colemanw [Fri, 28 Jul 2023 23:47:13 +0000 (16:47 -0700)]
Merge pull request #26960 from eileenmcnaughton/billing

Check `isBackOffice` before checking `billing_profile_id` (e-notice fix)

16 months agoMerge pull request #26576 from larssandergreen/Don't-allow-also-include-schedule...
Eileen McNaughton [Fri, 28 Jul 2023 23:18:02 +0000 (11:18 +1200)]
Merge pull request #26576 from larssandergreen/Don't-allow-also-include-schedule-reminders-for-event

dev/core#4377 Disable broken Also Include for event scheduled reminders

16 months ago[NFC] 5.64 release notes
Alice Frumin [Wed, 12 Jul 2023 02:08:01 +0000 (22:08 -0400)]
[NFC] 5.64 release notes

16 months agoMerge pull request #26967 from colemanw/colemanw-patch-1
Aidan Saunders [Fri, 28 Jul 2023 18:05:56 +0000 (19:05 +0100)]
Merge pull request #26967 from colemanw/colemanw-patch-1

Add civicrm_search_ui to core-ext.txt

16 months agoAdd civicrm_search_ui to core-ext.txt
colemanw [Fri, 28 Jul 2023 17:30:48 +0000 (13:30 -0400)]
Add civicrm_search_ui to core-ext.txt

16 months agoMerge pull request #26963 from totten/master-service-tags
colemanw [Fri, 28 Jul 2023 13:09:43 +0000 (06:09 -0700)]
Merge pull request #26963 from totten/master-service-tags

AutoDefinition - Inherit service-tags from interfaces, traits, and parent classes

16 months agoAutoDefinition - Inherit service-tags from interfaces, traits, and parent classes
Tim Otten [Fri, 28 Jul 2023 09:44:07 +0000 (02:44 -0700)]
AutoDefinition - Inherit service-tags from interfaces, traits, and parent classes

16 months agoDeclare @serviceTags for HookInterface and SpecProviderInterface
Tim Otten [Fri, 28 Jul 2023 07:06:54 +0000 (00:06 -0700)]
Declare @serviceTags for HookInterface and SpecProviderInterface

16 months agoMerge pull request #26958 from eileenmcnaughton/smarty_campaign
Yashodha Chaku [Fri, 28 Jul 2023 10:11:47 +0000 (15:41 +0530)]
Merge pull request #26958 from eileenmcnaughton/smarty_campaign

Define soon as 'in 9 years'

16 months agoMerge pull request #26942 from artfulrobot/standalone-breadcrumbs-v2
Rich Lott [Fri, 28 Jul 2023 09:45:15 +0000 (10:45 +0100)]
Merge pull request #26942 from artfulrobot/standalone-breadcrumbs-v2

standalone: move breadcrumb rendering into template

16 months agostandalone: civilint
Rich Lott / Artful Robot [Fri, 28 Jul 2023 09:00:46 +0000 (10:00 +0100)]
standalone: civilint

16 months agoMerge pull request #26954 from larssandergreen/Fix-saved-search-test-where-existing...
Seamus Lee [Fri, 28 Jul 2023 05:55:16 +0000 (01:55 -0400)]
Merge pull request #26954 from larssandergreen/Fix-saved-search-test-where-existing-managed-saved-search-is-present

Fix saved search test when there is an existing managed saved search

16 months agoAutoDefinition - Remove never-true condition
colemanw [Thu, 27 Jul 2023 03:57:29 +0000 (23:57 -0400)]
AutoDefinition - Remove never-true condition

The type-hint ensures the variable is never a string.

16 months agoStop setting quickConfig for form that doesn't care
Eileen McNaughton [Fri, 28 Jul 2023 04:54:34 +0000 (16:54 +1200)]
Stop setting quickConfig for form that doesn't care

16 months agoMerge pull request #26959 from civicrm/5.64
Seamus Lee [Fri, 28 Jul 2023 04:53:06 +0000 (00:53 -0400)]
Merge pull request #26959 from civicrm/5.64

5.64

16 months agoUse isQuickConfig to determine isQuickConfig
Eileen McNaughton [Fri, 28 Jul 2023 04:49:22 +0000 (16:49 +1200)]
Use isQuickConfig to determine isQuickConfig

16 months ago[php8.x] Fix test to use full form flow
Eileen McNaughton [Fri, 28 Jul 2023 04:44:11 +0000 (16:44 +1200)]
[php8.x] Fix test to use full form flow

16 months agoCheck isBackOffice before checking billing_profile_id
Eileen McNaughton [Fri, 28 Jul 2023 04:21:00 +0000 (16:21 +1200)]
Check isBackOffice before checking billing_profile_id

It won't be set from back office forms & will e-notice...

16 months agoMerge pull request #26953 from eileenmcnaughton/cont_name
Seamus Lee [Fri, 28 Jul 2023 04:11:39 +0000 (00:11 -0400)]
Merge pull request #26953 from eileenmcnaughton/cont_name

dev/core#4453 fix clash over 'name' field on contribution page form

16 months agoDefine soon as 9 years
Eileen McNaughton [Fri, 28 Jul 2023 03:50:03 +0000 (15:50 +1200)]
Define soon as 9 years

16 months agoUse array_key_exists instead of not empty in tpl
Eileen McNaughton [Fri, 28 Jul 2023 03:18:56 +0000 (15:18 +1200)]
Use array_key_exists instead of not empty in tpl

16 months agoDisable broken Also Include for event scheduled reminders
larssandergreen [Fri, 28 Jul 2023 03:08:06 +0000 (21:08 -0600)]
Disable broken Also Include for event scheduled reminders

16 months agoSwitch from un-assigned formName to assigned entityInClassFormat
Eileen McNaughton [Fri, 28 Jul 2023 03:00:36 +0000 (15:00 +1200)]
Switch from un-assigned formName to assigned entityInClassFormat

16 months agoNotice fixes on CiviEvent Component settings form
Eileen McNaughton [Fri, 28 Jul 2023 02:56:26 +0000 (14:56 +1200)]
Notice fixes on CiviEvent Component settings form

16 months agoFix saved search test with existing managed saved search
larssandergreen [Fri, 28 Jul 2023 02:13:41 +0000 (20:13 -0600)]
Fix saved search test with existing managed saved search

16 months agodev/core#4453 fix clash over 'name' field on contribution page form
Eileen McNaughton [Fri, 28 Jul 2023 02:03:38 +0000 (14:03 +1200)]
dev/core#4453 fix clash over 'name' field on contribution page form

16 months agoShow bounce history on Contact Summary
larssandergreen [Thu, 27 Jul 2023 22:27:09 +0000 (16:27 -0600)]
Show bounce history on Contact Summary

16 months agoMerge pull request #26948 from colemanw/isInstall
colemanw [Fri, 28 Jul 2023 00:39:50 +0000 (17:39 -0700)]
Merge pull request #26948 from colemanw/isInstall

Managed - skip errors in install as well as upgrade mode

16 months agoMerge pull request #26949 from eileenmcnaughton/dummy
Eileen McNaughton [Thu, 27 Jul 2023 23:56:10 +0000 (11:56 +1200)]
Merge pull request #26949 from eileenmcnaughton/dummy

Update ContributionMainTest to use full form flow

16 months agoUpdate ContributionMainTest to use full form flow
Eileen McNaughton [Thu, 27 Jul 2023 23:14:02 +0000 (11:14 +1200)]
Update ContributionMainTest to use full form flow

This updates the test to use postProcess and to check is_recur is passed to the
preApprove function rather than proxy that check by checking if is_recur
is set in the _params property (which is not used again after the preApprove

16 months agoMerge pull request #26945 from civicrm/5.64
Seamus Lee [Thu, 27 Jul 2023 22:24:01 +0000 (18:24 -0400)]
Merge pull request #26945 from civicrm/5.64

5.64

16 months agoMerge pull request #26947 from eileenmcnaughton/report
Seamus Lee [Thu, 27 Jul 2023 22:23:48 +0000 (18:23 -0400)]
Merge pull request #26947 from eileenmcnaughton/report

[PHP8.2] Remove undeclared property

16 months agoManaged - skip errors in install as well as upgrade mode
colemanw [Thu, 27 Jul 2023 22:10:32 +0000 (18:10 -0400)]
Managed - skip errors in install as well as upgrade mode

Followup from https://github.com/civicrm/civicrm-core/pull/26891
to exclude install as well as upgrade mode.

16 months ago[PHP8.2] Remove undeclared property
Eileen McNaughton [Thu, 27 Jul 2023 21:46:19 +0000 (09:46 +1200)]
[PHP8.2] Remove undeclared property

It appears to be copy & paste cos it is set but never used

16 months agoMerge pull request #26944 from colemanw/fixSkArithmetic
Aidan Saunders [Thu, 27 Jul 2023 21:06:00 +0000 (22:06 +0100)]
Merge pull request #26944 from colemanw/fixSkArithmetic

Fix dev/core#4455 broken SK arithmetic display

16 months agoFix dev/core#4455 broken SK arithmetic display
colemanw [Thu, 27 Jul 2023 19:36:35 +0000 (15:36 -0400)]
Fix dev/core#4455 broken SK arithmetic display

16 months agostandalone: improve code efficiency
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:41:29 +0000 (16:41 +0100)]
standalone: improve code efficiency

16 months agostandalone: prevent civi adding duplicate breadcrumbs (e.g. scheduled jobs)
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:26:33 +0000 (16:26 +0100)]
standalone: prevent civi adding duplicate breadcrumbs (e.g. scheduled jobs)

16 months agostandalone: fix breadcrumb array_merge
Rich Lott / Artful Robot [Thu, 27 Jul 2023 15:20:37 +0000 (16:20 +0100)]
standalone: fix breadcrumb array_merge