Eileen McNaughton [Wed, 27 Jul 2022 11:17:30 +0000 (12:17 +0100)]
dev/core#3749 Fix process pledges to throw exception when civiPledge disabled
Per the issue - it's fine for the job to not work if disabled,
but the error should be logical.
updatePledgeStatus is only called from one place so made the return
handling flatter for success, and exception on error
Eileen McNaughton [Tue, 26 Jul 2022 19:10:22 +0000 (20:10 +0100)]
Merge pull request #24047 from kurund/export-fixes
dev/core#3751 - export error fixes for multi-select contact reference custom field
Eileen McNaughton [Tue, 26 Jul 2022 14:04:07 +0000 (15:04 +0100)]
Merge pull request #24036 from colemanw/v3Custom
API - Consistently save custom data for v3 & v4
demeritcowboy [Tue, 26 Jul 2022 13:07:31 +0000 (09:07 -0400)]
Merge pull request #24048 from yashodha/reports_improvements
remove start/end date as mandatory in Demographics report
yashodha [Tue, 26 Jul 2022 05:03:53 +0000 (10:33 +0530)]
remove start/end date as mandatory in Demographics report
Kurund Jalmi [Mon, 25 Jul 2022 16:19:17 +0000 (17:19 +0100)]
export error fixes for multi-select contact reference custom field
Eileen McNaughton [Mon, 25 Jul 2022 09:54:19 +0000 (10:54 +0100)]
Merge pull request #24010 from eileenmcnaughton/task_notice
dev/core#3737 ensure tasks are loaded (notice fix)
Eileen McNaughton [Mon, 25 Jul 2022 09:39:21 +0000 (10:39 +0100)]
Merge pull request #24046 from seamuslee001/league_csv_php81
[REF][PHP8.1] Apply patches from upstream to ensure league/csv can work on php8.1
Seamus Lee [Sun, 24 Jul 2022 22:48:37 +0000 (08:48 +1000)]
[REF][PHP8.1] Apply patches from upstream to ensure league/csv can work on php8.1
Seamus Lee [Sun, 24 Jul 2022 22:42:16 +0000 (08:42 +1000)]
Add in patch for league CSV to fix fputcsv in php8.1
demeritcowboy [Mon, 25 Jul 2022 03:10:16 +0000 (23:10 -0400)]
Merge pull request #24045 from seamuslee001/package_update_2_php81
[REF][PHP8.1] Update phpoffice/phpword and tecnickcom/tcpdf packages…
Seamus Lee [Sun, 24 Jul 2022 22:18:29 +0000 (08:18 +1000)]
[REF][PHP8.1] Update phpoffice/phpword and tecnickcom/tcpdf packages for php8.1 compatability
demeritcowboy [Sat, 23 Jul 2022 14:53:48 +0000 (10:53 -0400)]
Merge pull request #23875 from alexymik/patch-3
Set target="_blank" on external footer links
Alexy Mikhailichenko [Thu, 23 Jun 2022 23:39:30 +0000 (16:39 -0700)]
Set target="_blank" on external footer links
demeritcowboy [Fri, 22 Jul 2022 14:46:32 +0000 (10:46 -0400)]
Merge pull request #24043 from totten/master-nfc-perm
(NFC) CRM_Core_Permission - More docblocks
demeritcowboy [Fri, 22 Jul 2022 14:44:12 +0000 (10:44 -0400)]
Merge pull request #24044 from totten/master-scss
composer.json - Update scssphp and related libraries (for PHP 8.1)
Tim Otten [Fri, 22 Jul 2022 09:52:42 +0000 (02:52 -0700)]
composer.json - Update scssphp and related libraries (for PHP 8.1)
Overview
--------
Update scssphp/scssphp, civicrm/composer-compile-plugin, and civicrm/composer-compile-lib.
Before
-------
Large number of warnings are generated in scssphp / php81, leading to an overflow
```
Compiling additional files (For full details, use verbose "-v" mode.)
Compile: Generate CCL wrapper functions
Compile: Greenwich CSS (dist/bootstrap3.css)
Fatal error: Allowed memory size of
1610612736 bytes exhausted (tried to allocate 36864 bytes) in phar:///Users/totten/bknix/bin/composer/vendor/symfony/process/Pipes/UnixPipes.php on line 132
Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.Subcommand @composer compile returned with error code 255
In ComposerPassthru.php line 72:
Subcommand @composer compile returned with error code 255
install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
```
After
-----
Compilation works
Comments
--------
Generated via: `composer update civicrm/composer-compile-lib scssphp/scssphp civicrm/composer-compile-plugin`
Tim Otten [Fri, 22 Jul 2022 06:51:29 +0000 (23:51 -0700)]
(NFC) CRM_Core_Permission - More docblocks
Seamus Lee [Fri, 22 Jul 2022 04:58:39 +0000 (14:58 +1000)]
Merge pull request #24042 from seamuslee001/master
5.52
Seamus Lee [Fri, 22 Jul 2022 04:57:39 +0000 (14:57 +1000)]
Merge branch '5.52'
Tim Otten [Fri, 22 Jul 2022 03:49:03 +0000 (20:49 -0700)]
Merge pull request #24038 from seamuslee001/5.52
[REF] Upgrade DOMPDF to 2.x branch
Tim Otten [Fri, 22 Jul 2022 03:44:42 +0000 (20:44 -0700)]
Merge pull request #23896 from colemanw/afformManaged
Afform - Switch to APIv4 for managed afform_type option group
colemanw [Thu, 21 Jul 2022 23:27:40 +0000 (19:27 -0400)]
Merge pull request #24030 from totten/master-run-ext-upgrades
dev/core#3490 - Apply extension updates after core updates
colemanw [Thu, 21 Jul 2022 23:26:00 +0000 (19:26 -0400)]
Merge pull request #24016 from colemanw/afformTokens
Afform - Post-submit redirect tokens
demeritcowboy [Sun, 10 Jul 2022 15:09:46 +0000 (11:09 -0400)]
whitespace fix
Seamus Lee [Wed, 6 Jul 2022 02:28:10 +0000 (12:28 +1000)]
Fix installed-fonts cache
Seamus Lee [Tue, 5 Jul 2022 22:32:40 +0000 (08:32 +1000)]
[REF] Upgrade DOMPDF to 2.x branch
Seamus Lee [Thu, 21 Jul 2022 21:26:22 +0000 (07:26 +1000)]
Merge pull request #23970 from MegaphoneJon/false-not-zero
APIv4 - Fix mishandling of boolean custom values
Seamus Lee [Thu, 21 Jul 2022 21:23:31 +0000 (07:23 +1000)]
Merge pull request #23895 from colemanw/searchKitManaged
SearchKit - Switch to APIv4 for managed entities
Coleman Watts [Tue, 28 Jun 2022 15:59:45 +0000 (11:59 -0400)]
Afform - Switch to APIv4 for managed afform_type option group
Seamus Lee [Thu, 21 Jul 2022 21:06:11 +0000 (07:06 +1000)]
Merge pull request #24035 from colemanw/actionLogFix
Fix ActionLog BAO to not overwrite existing data
Coleman Watts [Thu, 21 Jul 2022 14:36:06 +0000 (10:36 -0400)]
APIv3 - Don't handle custom data already handled by BAO
Fixes dev/core#3747
It's confusing to handle saving custom data in the APIv3 layer,
because APIv4 expects the BAO to handle it.
Until every BAO consistently uses WriteRecord this will continue to be a pain point.
Coleman Watts [Thu, 21 Jul 2022 14:06:04 +0000 (10:06 -0400)]
Fix ActionLog BAO to not overwrite existing data
demeritcowboy [Thu, 21 Jul 2022 12:06:22 +0000 (08:06 -0400)]
Merge pull request #24027 from totten/master552-status-footer-skipsort
Status Check - Report the overall status (accurately)
demeritcowboy [Thu, 21 Jul 2022 10:58:16 +0000 (06:58 -0400)]
Merge pull request #24031 from yashodha/reports_improvements
Fix 'Pledge Made Date' display to show date and not time
Eileen McNaughton [Thu, 21 Jul 2022 07:58:39 +0000 (08:58 +0100)]
Merge pull request #24025 from demeritcowboy/batch-remove-2
dev/core#3050 - (Alternate) Fix crash removing an entry from a batch
yashodha [Thu, 21 Jul 2022 05:00:53 +0000 (10:30 +0530)]
fix 'Pledge Made Date' to show date and not time
demeritcowboy [Thu, 21 Jul 2022 00:48:31 +0000 (20:48 -0400)]
Merge pull request #24018 from seamuslee001/php8_1_null_batch_4
[REF][PHP8.1] Batch 4 of fixing issues found in unit tests where pass…
Seamus Lee [Tue, 19 Jul 2022 01:46:56 +0000 (11:46 +1000)]
[REF][PHP8.1] Batch 4 of fixing issues found in unit tests where passing NULL values triggers deprecations
Apply fixes as per Demeritcowboy
Tim Otten [Wed, 20 Jul 2022 21:34:02 +0000 (14:34 -0700)]
Merge pull request #23767 from colemanw/afformRequireAuthx
Afform - Require Authx
Tim Otten [Wed, 20 Jul 2022 21:01:19 +0000 (14:01 -0700)]
Update CRM/Utils/Check.php
Co-authored-by: demeritcowboy <demeritcowboy@hotmail.com>
Tim Otten [Wed, 1 Jun 2022 21:10:22 +0000 (14:10 -0700)]
Upgrader - Enqueue extension upgrade tasks
Tim Otten [Wed, 20 Jul 2022 08:11:22 +0000 (01:11 -0700)]
Upgrader - Re-assess dispatch policy at the start of every upgrade task
The practical effect should be this:
* All tasks before `doCoreFinish()` run with the `upgrade.main` policy
* All tasks after `doCoreFinish()` run with the `upgrade.finish` policy
Framing this change is a bit delicate because tasks can run in different
ways (eg AJAX queue runner; headless queue-runner; cv queue-runner). This
should have the same consequence in all runners.
demeritcowboy [Wed, 20 Jul 2022 19:54:20 +0000 (15:54 -0400)]
Merge pull request #24028 from yashodha/reports_improvements
remove pledge status as mandatory in Pledge report
Matthew Wire [Wed, 20 Jul 2022 14:13:29 +0000 (15:13 +0100)]
Merge pull request #24023 from colemanw/searchKitHtml
SearchKit - Allow html in columns
yashodha [Wed, 20 Jul 2022 04:57:44 +0000 (10:27 +0530)]
remove pledge status as mandatory in Pledge report
Tim Otten [Wed, 20 Jul 2022 07:32:37 +0000 (00:32 -0700)]
Upgrader - Pick initial dispatch policy based on how far we've progressed in upgrade
Tim Otten [Wed, 1 Jun 2022 21:07:15 +0000 (14:07 -0700)]
(REF) Extract method \CRM_Upgrade_DispatchPolicy::useTemporarily()
Tim Otten [Wed, 1 Jun 2022 20:51:06 +0000 (13:51 -0700)]
(REF) Extensions - Extract method to build upgrade queue
I was slightly concerned that building a queue under a different there are
two risks, although I don't think either is very big:
1. That someone references the queue by name during the building process.
However, it wouldn't make much sense from a DX POV (given how "Upgrader"
classes are generally written), and I can't any references to
`QUEUE_NAME` or `ext-upgrade` in `universe`
2. That someone generates queue tasks with `weight`s that somehow clash with
the `weight`s in core-queue. However, this also doesn't make much sense
from a DX POV (given how "upgrader" classes are generally written).
Tim Otten [Wed, 20 Jul 2022 07:57:31 +0000 (00:57 -0700)]
(REF) CiviEventDispacher - Enable getDispatchPolicy()
Tim Otten [Wed, 20 Jul 2022 07:42:36 +0000 (00:42 -0700)]
CRM_Queue_Task - Fire internal events
Tim Otten [Wed, 20 Jul 2022 03:38:10 +0000 (20:38 -0700)]
Status Check - Report the overall status (accurately)
Overview
--------
The page-footer includes a summary message about the system status (eg "System
Status: Ok" or "System Status: Error"). The footer has inaccurately summarized
the status.
Before
------
Suppose you have 5 "Error" messages and 1 "OK" message. It will summarize as "System Status: Ok".
(It emphasizes the *least severe* status-message.)
Code is more complex.
After
------
Suppose you have 5 "Error" messages and 1 "OK" message. It will summarize as "System Status: Error".
(It emphasizes the *most severe* status-message.)
Code is less complex.
Comments
--------
The overall value is determined in `CRM_Utils_Check::checkAll()`. Heretofore,
`checkAll()` sorted the messages by severity and then emphasized the *first*
visible message.
The problem is that the sort-order has flip-flopped, so "first" means different things:
* In v4.7, the messages were descending. So "first" was "most severe".
* In v5.39 (
11d593edde82e7de962ec9056cfebe87975fb499), the order was ascending.
So "first" was "least severe". (It appears accidental.)
* In v5.45 (
728c1cc31d0d323f74f7b980a1e183fb499d4e9e), the order flipped back
to descending, but *only* for the Angular (`civicrm/a/#/status`) -- not the footer.
IMHO, the flip-floppiness means that callers cannot rely on the order returned
by `checkAll()` -- they should instead do a higher-level sort (as in v5.45's
728c1cc31d0d323f74f7b980a1e183fb499d4e9e). The `uasort()` within `checkAll()`
is therefore redundant. We might as well skip it -- and simplify the logic.
colemanw [Wed, 20 Jul 2022 00:29:33 +0000 (20:29 -0400)]
Merge pull request #24024 from MegaphoneJon/print-summary-afform
Add afform blocks to print summary
demeritcowboy [Tue, 19 Jul 2022 23:36:55 +0000 (19:36 -0400)]
fix crash removing an entry from a batch
Jon Goldberg [Tue, 19 Jul 2022 21:16:30 +0000 (17:16 -0400)]
add afform blocks to print summary
Coleman Watts [Tue, 19 Jul 2022 17:21:15 +0000 (13:21 -0400)]
SearchKit - Allow html in columns
This adds a column type 'html' and defaults rich-text fields to use that column type.
Fixes dev/core#3723
demeritcowboy [Tue, 19 Jul 2022 16:51:57 +0000 (12:51 -0400)]
Merge pull request #24021 from mattwire/activitypageajaxicons
Use fontawesome icon helper for activity/Page/AJAX
Matthew Wire [Tue, 19 Jul 2022 13:48:10 +0000 (14:48 +0100)]
Use fontawesome icon helper for activity/Page/AJAX
Eileen McNaughton [Tue, 19 Jul 2022 07:24:15 +0000 (08:24 +0100)]
Merge pull request #24013 from colemanw/afformNav
Afform - provide easy way to add navigation menu from the form
Seamus Lee [Tue, 19 Jul 2022 02:38:44 +0000 (12:38 +1000)]
Merge pull request #24017 from demeritcowboy/polyfill-too-high
Lower minimum polyfill version since conflicts with drupal/core-recommended
Seamus Lee [Tue, 19 Jul 2022 02:19:06 +0000 (12:19 +1000)]
Merge pull request #24015 from demeritcowboy/composer-patches
Update cweagans/composer-patches to 1.7.2 to fix delete-and-reinstall problem
demeritcowboy [Tue, 19 Jul 2022 00:06:18 +0000 (20:06 -0400)]
lower minimum polyfill version
Coleman Watts [Mon, 18 Jul 2022 23:54:47 +0000 (19:54 -0400)]
Afform - Post-submit redirect tokens
demeritcowboy [Mon, 18 Jul 2022 23:51:20 +0000 (19:51 -0400)]
update to fix delete-and-reinstall problem
colemanw [Mon, 18 Jul 2022 20:37:23 +0000 (16:37 -0400)]
Merge pull request #24011 from demeritcowboy/composerlock
composer.lock hash out of date
demeritcowboy [Mon, 18 Jul 2022 18:17:40 +0000 (14:17 -0400)]
Merge pull request #24012 from yashodha/add_Classes
add classes to the contribution view page
Coleman Watts [Mon, 18 Jul 2022 16:17:37 +0000 (12:17 -0400)]
Afform - Insta-refresh menubar when adding a navigation item
Coleman Watts [Mon, 18 Jul 2022 15:26:47 +0000 (11:26 -0400)]
APIv4 - Flush navigation caches after writing or deleting navigation item
Historically the expectation was that this cache gets flushed manually.
I've kept that unchanged for legacy code (v3 create/delete and direct BAO::add)
but with APIv4 and onward the cache will get flushed automatically after a write operation.
Coleman Watts [Sun, 17 Jul 2022 15:56:31 +0000 (11:56 -0400)]
Afform - provide easy way to add navigation menu from the form
yashodha [Mon, 18 Jul 2022 15:20:37 +0000 (20:50 +0530)]
add classed to tpl
demeritcowboy [Mon, 18 Jul 2022 15:02:41 +0000 (11:02 -0400)]
hash out of date
Eileen McNaughton [Mon, 18 Jul 2022 09:30:16 +0000 (10:30 +0100)]
dev/core#3737 ensure tasks are loaded
Seamus Lee [Mon, 18 Jul 2022 09:36:33 +0000 (19:36 +1000)]
Merge pull request #23954 from eileenmcnaughton/poly
Poly-fill-me-up
Eileen McNaughton [Mon, 18 Jul 2022 09:18:44 +0000 (21:18 +1200)]
Merge pull request #24004 from demeritcowboy/upload-woes
dev/core#3736 - Fix uploaded file on message template form
Eileen McNaughton [Wed, 6 Jul 2022 08:28:48 +0000 (20:28 +1200)]
Poly-fill-me-up
Eileen McNaughton [Mon, 18 Jul 2022 07:05:05 +0000 (19:05 +1200)]
Merge pull request #23996 from seamuslee001/php8_1_pear_db
[REF][PHP8.1] Apply PR patch to fix issue in php8.1 where mysqli erro…
Seamus Lee [Mon, 18 Jul 2022 02:15:50 +0000 (12:15 +1000)]
Merge pull request #24007 from demeritcowboy/pdf-error
Fix test. Don't hide errors. (Followup to 23999)
demeritcowboy [Sun, 17 Jul 2022 05:04:41 +0000 (01:04 -0400)]
Fix test. Don't hide errors.
demeritcowboy [Sat, 16 Jul 2022 15:29:35 +0000 (11:29 -0400)]
fix missing upload
demeritcowboy [Sat, 16 Jul 2022 14:57:59 +0000 (10:57 -0400)]
Merge pull request #23999 from seamuslee001/null_part3_php81
[REF][PHP8.1] A third batch of fixes where passing in NULL values cau…
Eileen McNaughton [Sat, 16 Jul 2022 06:51:18 +0000 (18:51 +1200)]
Merge pull request #23995 from colemanw/custom_custom
Allow custom fields to have custom fields
Tim Otten [Sat, 16 Jul 2022 00:12:38 +0000 (17:12 -0700)]
Merge pull request #24000 from seamuslee001/property_bag_fixs
[REF][PHP8.1] Fix Return type hints and passing in NULL values causin…
Tim Otten [Fri, 15 Jul 2022 07:59:55 +0000 (00:59 -0700)]
Merge pull request #23997 from seamuslee001/php8_1_null_ext
[REF][PHP8.1] Fix issues in core extensions where passing in NULL val…
Matthew Wire [Thu, 14 Jul 2022 14:29:55 +0000 (15:29 +0100)]
Merge pull request #23974 from colemanw/filterFieldsAfform
Afform - Allow groups and tags and age to be filters
Seamus Lee [Thu, 14 Jul 2022 09:52:49 +0000 (19:52 +1000)]
Merge pull request #23993 from colemanw/searchKitJoinFix
SearchKit - Fix adding deep joins
Seamus Lee [Wed, 13 Jul 2022 23:35:42 +0000 (09:35 +1000)]
[REF][PHP8.1] Apply PR patch to fix issue in php8.1 where mysqli error reporting changed
Seamus Lee [Thu, 14 Jul 2022 02:19:27 +0000 (12:19 +1000)]
Merge pull request #23998 from MegaphoneJon/net-smtp-110
net_smtp upgrade to 1.10.0
Seamus Lee [Thu, 14 Jul 2022 00:50:51 +0000 (10:50 +1000)]
[REF][PHP8.1] Fix Return type hints and passing in NULL values causing deprecation notices in php8.1 in Property Bag
Seamus Lee [Thu, 14 Jul 2022 00:38:14 +0000 (10:38 +1000)]
[REF][PHP8.1] A third batch of fixes where passing in NULL values causes deprecation notices in php8.1
Jon Goldberg [Thu, 14 Jul 2022 00:13:14 +0000 (20:13 -0400)]
net_smtp upgrade to 1.10.0
Seamus Lee [Wed, 13 Jul 2022 23:43:15 +0000 (09:43 +1000)]
[REF][PHP8.1] Fix issues in core extensions where passing in NULL values is no longer supported
Coleman Watts [Wed, 13 Jul 2022 21:30:02 +0000 (17:30 -0400)]
Allow custom fields to have custom fields
Theoretically a custom field could have custom fields! Trippy...
Fixes dev/core#3731
Coleman Watts [Wed, 13 Jul 2022 15:54:25 +0000 (11:54 -0400)]
SearchKit - Fix adding deep joins
This fixes a UI bug that was preventing joins past a depth of 2 to be added.
Eileen McNaughton [Wed, 13 Jul 2022 04:20:59 +0000 (16:20 +1200)]
Merge pull request #23992 from civicrm/5.52
5.52
Seamus Lee [Wed, 13 Jul 2022 00:34:58 +0000 (10:34 +1000)]
Merge pull request #23991 from totten/5.52-civitest
Civi\Test - Fix leak in active module-list for headless test
Tim Otten [Tue, 12 Jul 2022 02:00:59 +0000 (19:00 -0700)]
Civi\Test - Fix leak in active module-list for headless test
Steps to reproduce
------------------
Observed on a `dmaster` build while running these steps:
* Run civix's `make-example.sh`
* Or just run some subset involving a headless test, eg
* civix generate:test --template=headless 'Civi\Civiexample\BarTest'
* cv api extension.install key=$EXMODULE
* phpunit8 ./tests/phpunit/Civi/Civiexample/BarTest.php
Before
------
Fatal error: Uncaught Error: Class 'Civi\Api4\SearchSegment' not found in
/home/totten/bknix/build/dmaster/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Service/Spec/Provider/SearchSegmentExtraFieldProvider.php
on line 52
After
-----
Test runs
Eileen McNaughton [Tue, 12 Jul 2022 03:23:07 +0000 (15:23 +1200)]
Merge pull request #23984 from seamuslee001/ref_full_package_upgrades_php8_1
[REF][PHP8.1] Upgrade oauth2-client,zetacomponents/base,htmlpurfier packages …
Seamus Lee [Tue, 12 Jul 2022 02:04:16 +0000 (12:04 +1000)]
Merge pull request #23990 from civicrm/5.52
5.52
Seamus Lee [Tue, 12 Jul 2022 02:03:04 +0000 (12:03 +1000)]
Merge pull request #23988 from seamuslee001/5_52_phpunit_deprecations
[NFC] Restore handling for deprecations in phpunit test runs
Seamus Lee [Mon, 11 Jul 2022 08:10:47 +0000 (18:10 +1000)]
[NFC] Add in convertDeprecationsToExceptions='true' to core extension's phpunit.xml.dist files