civicrm-core.git
2 years agoMerge pull request #22758 from civicrm/dependabot/npm_and_yarn/karma-6.3.14
demeritcowboy [Fri, 11 Feb 2022 14:31:18 +0000 (09:31 -0500)]
Merge pull request #22758 from civicrm/dependabot/npm_and_yarn/karma-6.3.14

Bump karma from 6.3.4 to 6.3.14

2 years agoBump karma from 6.3.4 to 6.3.14
dependabot[bot] [Fri, 11 Feb 2022 09:43:48 +0000 (09:43 +0000)]
Bump karma from 6.3.4 to 6.3.14

Bumps [karma](https://github.com/karma-runner/karma) from 6.3.4 to 6.3.14.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](https://github.com/karma-runner/karma/compare/v6.3.4...v6.3.14)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years agoMerge pull request #22761 from civicrm/dependabot/npm_and_yarn/ajv-6.12.6
Seamus Lee [Fri, 11 Feb 2022 09:42:37 +0000 (20:42 +1100)]
Merge pull request #22761 from civicrm/dependabot/npm_and_yarn/ajv-6.12.6

Bump ajv from 6.6.1 to 6.12.6

2 years agoMerge pull request #22713 from colemanw/billingBlockCleanup
Seamus Lee [Fri, 11 Feb 2022 06:58:45 +0000 (17:58 +1100)]
Merge pull request #22713 from colemanw/billingBlockCleanup

[REF] Cleanup billingBlock.js

2 years agoBump ajv from 6.6.1 to 6.12.6
dependabot[bot] [Fri, 11 Feb 2022 06:38:45 +0000 (06:38 +0000)]
Bump ajv from 6.6.1 to 6.12.6

Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.6.1 to 6.12.6.
- [Release notes](https://github.com/ajv-validator/ajv/releases)
- [Commits](https://github.com/ajv-validator/ajv/compare/v6.6.1...v6.12.6)

---
updated-dependencies:
- dependency-name: ajv
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2 years ago[REF] Fix issue where spaces in payment_processor_type.name field causes issues with...
Seamus Lee [Fri, 11 Feb 2022 05:36:02 +0000 (16:36 +1100)]
[REF] Fix issue where spaces in payment_processor_type.name field causes issues with class output on form

2 years ago[REF] Simplify Location::getValues
Eileen McNaughton [Fri, 11 Feb 2022 04:51:09 +0000 (17:51 +1300)]
[REF] Simplify Location::getValues

2 years agoMerge pull request #22728 from eileenmcnaughton/local
Yashodha Chaku [Fri, 11 Feb 2022 04:33:10 +0000 (10:03 +0530)]
Merge pull request #22728 from eileenmcnaughton/local

Format money in custom fields once, on the tpl layer

2 years agoRemove unused parameter, pass-by-ref
Eileen McNaughton [Fri, 11 Feb 2022 04:17:36 +0000 (17:17 +1300)]
Remove unused parameter, pass-by-ref

2 years agoMerge pull request #22750 from colemanw/fixProcessorPseudoconstant
Tim Otten [Fri, 11 Feb 2022 02:58:32 +0000 (18:58 -0800)]
Merge pull request #22750 from colemanw/fixProcessorPseudoconstant

Fix ContributionRecur.payment_processor_id pseudoconstant

2 years agoBAO_Mailing::create - stop passing by reference
Eileen McNaughton [Fri, 11 Feb 2022 02:31:06 +0000 (15:31 +1300)]
BAO_Mailing::create - stop passing by reference

We have been removing this pass-by-refs on an ongoing basis. CRUD calls should use
the api but I checked the core calls and none are looking for anything altered in

2 years agoFix ContributionRecur.payment_processor_id pseudoconstant
Coleman Watts [Thu, 10 Feb 2022 19:40:06 +0000 (14:40 -0500)]
Fix ContributionRecur.payment_processor_id pseudoconstant

Before: Pseudoconstant mistakenly uses 'name' instead of title
After: Name and title are treated correctly

2 years agodev/core#3063 APIv3 - Fix numeric option matching
Coleman Watts [Wed, 9 Feb 2022 16:35:53 +0000 (11:35 -0500)]
dev/core#3063 APIv3 - Fix numeric option matching

Before: Option matching was skipped for all FK fields if a numeric value was given
After: Only skipped for `campaign_id` field, if positive integer given

The optimization was overly broad and had unintended side-effects

2 years agoFix apiv4 Contribution delete & all line items
Eileen McNaughton [Thu, 10 Feb 2022 04:03:43 +0000 (17:03 +1300)]
Fix apiv4 Contribution delete & all line items

2 years agoAPIv4 - remove unnecessary field from System::check
Coleman Watts [Thu, 10 Feb 2022 03:40:49 +0000 (22:40 -0500)]
APIv4 - remove unnecessary field from System::check

Following on #22730, this removes the 'severity' field from the System::check api
because it's redundant with 'severity_id:name', and does not appear to be used anywhere.

2 years agoMerge pull request #22743 from civicrm/5.47
Eileen McNaughton [Thu, 10 Feb 2022 02:33:48 +0000 (15:33 +1300)]
Merge pull request #22743 from civicrm/5.47

5.47

2 years agoFix for #22685 financial acl aggression
Eileen McNaughton [Thu, 10 Feb 2022 02:20:50 +0000 (15:20 +1300)]
Fix for #22685 financial acl aggression

Just realised this is required to make #22685 non-changey

2 years agoFix to not show payment for templates
Eileen McNaughton [Fri, 4 Feb 2022 06:51:35 +0000 (19:51 +1300)]
Fix to not show payment for templates

2 years agoFix missing variables
Eileen McNaughton [Fri, 4 Feb 2022 06:13:03 +0000 (19:13 +1300)]
Fix missing variables

Note this updates the code such that the buttons are consistent on this form with the payment info block

2 years agoFix contribution view to use checkAccess
Eileen McNaughton [Thu, 3 Feb 2022 23:37:45 +0000 (12:37 +1300)]
Fix contribution view to use checkAccess

2 years agoGenerate button links in PHP instead of smarty for ContributionView form
Matthew Wire [Thu, 20 Jan 2022 22:17:03 +0000 (22:17 +0000)]
Generate button links in PHP instead of smarty for ContributionView form

2 years agoTidy up getContributionPaymentLinks
Eileen McNaughton [Thu, 10 Feb 2022 01:40:16 +0000 (14:40 +1300)]
Tidy up getContributionPaymentLinks

- removes an unused variable.
- fixes to not show 'record Refund' for pending contributions (is displayed
on the expand payments section of a contribution

2 years agoTidy up getContributionPaymentLinks
Eileen McNaughton [Thu, 10 Feb 2022 01:40:16 +0000 (14:40 +1300)]
Tidy up getContributionPaymentLinks

- removes an unused variable.
- fixes to not show 'record Refund' for pending contributions (is displayed
on the expand payments section of a contribution

2 years agoMerge pull request #22744 from eileenmcnaughton/grump
Eileen McNaughton [Thu, 10 Feb 2022 02:03:29 +0000 (15:03 +1300)]
Merge pull request #22744 from eileenmcnaughton/grump

Bypass grumpy mode for contribution search totals & criteria

2 years agoMerge pull request #22684 from eileenmcnaughton/contacl
colemanw [Thu, 10 Feb 2022 01:16:38 +0000 (20:16 -0500)]
Merge pull request #22684 from eileenmcnaughton/contacl

Move acl check for contributionView to the extension

2 years agoMerge pull request #22742 from eileenmcnaughton/cust
Seamus Lee [Thu, 10 Feb 2022 01:00:45 +0000 (12:00 +1100)]
Merge pull request #22742 from eileenmcnaughton/cust

Fix deprecated warnings, smary grumpy-mode issues in legacy searches

2 years agoSome more notice fixes in smarty
Eileen McNaughton [Thu, 10 Feb 2022 00:30:22 +0000 (13:30 +1300)]
Some more notice fixes in smarty

2 years agoMerge pull request #22741 from MegaphoneJon/fix-duplicate-contact-typing
Eileen McNaughton [Thu, 10 Feb 2022 00:07:57 +0000 (13:07 +1300)]
Merge pull request #22741 from MegaphoneJon/fix-duplicate-contact-typing

enforce required fields on Contact.duplicatecheck

2 years agoBypass grumpy mode for contribution totals
Eileen McNaughton [Wed, 9 Feb 2022 23:58:03 +0000 (12:58 +1300)]
Bypass grumpy mode for contribution totals

These are assigned to the template from php & have nbsp in them (for better or worse)

2 years agoFix deprecated warnings, smary grumpy-mode issues in legacy searches
Eileen McNaughton [Wed, 9 Feb 2022 23:19:13 +0000 (12:19 +1300)]
Fix deprecated warnings, smary grumpy-mode issues in legacy searches

This gets rid of some deprecated warnings and also makes the pager work in smarty grumpy mode

2 years agoMerge pull request #22714 from demeritcowboy/grant-searchbuilder
colemanw [Wed, 9 Feb 2022 23:15:10 +0000 (18:15 -0500)]
Merge pull request #22714 from demeritcowboy/grant-searchbuilder

dev/core#3056 - Crash with search builder if civigrant not enabled and have admin rights

2 years agoenforce required fields on Contact.duplicatecheck
Jon Goldberg [Wed, 9 Feb 2022 20:56:11 +0000 (15:56 -0500)]
enforce required fields on Contact.duplicatecheck

2 years agoquickfix for crash if civigrant not enabled and have admin rights
demeritcowboy [Sun, 6 Feb 2022 01:06:48 +0000 (20:06 -0500)]
quickfix for crash if civigrant not enabled and have admin rights

2 years agoOptionValues - Specify id+name+label for option callbacks that use it
Coleman Watts [Wed, 9 Feb 2022 02:53:48 +0000 (21:53 -0500)]
OptionValues - Specify id+name+label for option callbacks that use it

Previously some API calls relied on a bug which conflated name with label,
that bug has been fixed, causing some test failures. The solution is to
update the option lists with a full multidimensional array with translated labels
and untranslated names.

2 years agoMerge pull request #22738 from civicrm/5.47
Eileen McNaughton [Wed, 9 Feb 2022 10:47:11 +0000 (23:47 +1300)]
Merge pull request #22738 from civicrm/5.47

5.47

2 years agoMerge pull request #22727 from eileenmcnaughton/mod_money
Tim Otten [Wed, 9 Feb 2022 04:50:31 +0000 (20:50 -0800)]
Merge pull request #22727 from eileenmcnaughton/mod_money

dev/core#3059 Regression fix - be tolerant with smarty money

2 years agoMerge pull request #22735 from civicrm/5.47
Seamus Lee [Wed, 9 Feb 2022 03:45:36 +0000 (14:45 +1100)]
Merge pull request #22735 from civicrm/5.47

5.47

2 years agoMerge pull request #22733 from totten/5.47-dedupe-check
colemanw [Wed, 9 Feb 2022 01:22:06 +0000 (20:22 -0500)]
Merge pull request #22733 from totten/5.47-dedupe-check

(dev/core#3055) Fix dedupe check to not require elevated permissions

2 years agoPseudoConstant - Allow multi-dimensionaly arrays to be returned from option callbacks
Coleman Watts [Tue, 8 Feb 2022 23:35:33 +0000 (18:35 -0500)]
PseudoConstant - Allow multi-dimensionaly arrays to be returned from option callbacks

Before: Only flat arrays could be returned by a pseudoconstant callback fn.
After: Callbacks can return arrays with id/name/label/abbr.

2 years agoFix dedupe check to not require elevated permissions
Jon Goldberg [Fri, 4 Feb 2022 17:14:01 +0000 (12:14 -0500)]
Fix dedupe check to not require elevated permissions

2 years agoMerge pull request #22628 from colemanw/civicrm_admin_ui
Eileen McNaughton [Tue, 8 Feb 2022 22:36:48 +0000 (11:36 +1300)]
Merge pull request #22628 from colemanw/civicrm_admin_ui

Add civicrm_admin_ui extension

2 years agoPseudoconstants - Use id instead of label for name
Coleman Watts [Tue, 8 Feb 2022 16:55:32 +0000 (11:55 -0500)]
Pseudoconstants - Use id instead of label for name

Each item in a field option list contains keys like id, name, label, color, icon, description, abbr.
But some option lists only consist of simple key/value pairs. To convert those simple associative arrays
into a full option list, the name should be derived from the id, not the label, because machine names
are expected to be stable, and labels can be translated.

Before: `name` derived from `label` when converting simple associative to an option list
After: `name` derived from `id`.

2 years agoMerge pull request #22731 from colemanw/customvaluefailingtest
Matthew Wire [Tue, 8 Feb 2022 20:25:56 +0000 (20:25 +0000)]
Merge pull request #22731 from colemanw/customvaluefailingtest

APIv4 - Fix setting/getting a multi-record customfield with date+time

2 years agoAPIv4 - Fix setting/getting a multi-record custom field with date+time
Matthew Wire [Mon, 7 Feb 2022 21:25:26 +0000 (21:25 +0000)]
APIv4 - Fix setting/getting a multi-record custom field with date+time

2 years agoMerge pull request #22677 from eileenmcnaughton/aclmem
colemanw [Tue, 8 Feb 2022 17:14:14 +0000 (12:14 -0500)]
Merge pull request #22677 from eileenmcnaughton/aclmem

Move financial acls for membership to extension

2 years agoMerge pull request #22722 from colemanw/restExplorer
colemanw [Tue, 8 Feb 2022 16:20:08 +0000 (11:20 -0500)]
Merge pull request #22722 from colemanw/restExplorer

APIv4 Explorer - Add REST syntax

2 years agoMerge pull request #22380 from braders/core-483-show-customised-preferences-on-validation
colemanw [Tue, 8 Feb 2022 15:55:29 +0000 (10:55 -0500)]
Merge pull request #22380 from braders/core-483-show-customised-preferences-on-validation

Show customised fields on load, if customised option selected.

2 years agoAPIv4 Explorer - Add REST syntax
Coleman Watts [Mon, 7 Feb 2022 17:23:49 +0000 (12:23 -0500)]
APIv4 Explorer - Add REST syntax

2 years agoFormat money in custom fields once, on the tpl layer
Eileen McNaughton [Tue, 8 Feb 2022 04:35:48 +0000 (17:35 +1300)]
Format money in custom fields once, on the tpl layer

This ensures the raw value is available to the template layer and uses it
rather than the formatted value for money display.

It rather feels it would be better to separate out this view use case in case
there are others hidden in there - but I think this tpl is only
used with this assign

2 years agoRegression fix - be tolerant with smarty money
Eileen McNaughton [Tue, 8 Feb 2022 03:38:05 +0000 (16:38 +1300)]
Regression fix - be tolerant with smarty money

I've seen issues in extended reports and in core where already-formatted money from
custom fields is formatted again in the smarty layer and, with recent changes
, throwing an exception when the money is greater than 1000
(because the presence of a comma makes it invalid). This adds tolerance
that seems consistent with prior code

2 years agoMerge pull request #22715 from braders/batchentry-non-numberic-warning
Eileen McNaughton [Tue, 8 Feb 2022 02:44:57 +0000 (15:44 +1300)]
Merge pull request #22715 from braders/batchentry-non-numberic-warning

[NFC] Batch entry - Avoid warnings when performing math on empty string.

2 years agoMerge pull request #22723 from civicrm/5.47
colemanw [Mon, 7 Feb 2022 21:08:55 +0000 (16:08 -0500)]
Merge pull request #22723 from civicrm/5.47

5.47

2 years agoAvoid null column showing on groups search page
Bradley Taylor [Mon, 7 Feb 2022 20:19:10 +0000 (20:19 +0000)]
Avoid null column showing on groups search page

2 years agoCast value to int before performing math
Bradley Taylor [Sun, 6 Feb 2022 17:20:19 +0000 (17:20 +0000)]
Cast value to int before performing math

2 years agoCustomField - Fix preview link
Coleman Watts [Tue, 1 Feb 2022 19:22:27 +0000 (14:22 -0500)]
CustomField - Fix preview link

2 years agoAdd civicrm_admin_ui extension
Coleman Watts [Wed, 26 Jan 2022 19:22:59 +0000 (14:22 -0500)]
Add civicrm_admin_ui extension

So far this extension replaces 2 screns with SearchDisplay Afforms:
- Custom field groups
- Custom fields

2 years agoMerge pull request #22716 from colemanw/sortableEntityFix
demeritcowboy [Mon, 7 Feb 2022 18:22:25 +0000 (13:22 -0500)]
Merge pull request #22716 from colemanw/sortableEntityFix

APIv4 SortableEntity - Fix sorting custom fields with option groups

2 years agoMerge pull request #22721 from demeritcowboy/grantinfo
colemanw [Mon, 7 Feb 2022 15:06:37 +0000 (10:06 -0500)]
Merge pull request #22721 from demeritcowboy/grantinfo

dev/core#3057 - follow-up to fix civigrant info.xml version number in master

2 years agofix version number
demeritcowboy [Mon, 7 Feb 2022 12:53:37 +0000 (07:53 -0500)]
fix version number

2 years agoFix regression with flexible merging of contact information
John Kingsnorth [Mon, 7 Feb 2022 11:49:00 +0000 (11:49 +0000)]
Fix regression with flexible merging of contact information

2 years agoMerge pull request #22718 from civicrm/5.47
Seamus Lee [Mon, 7 Feb 2022 06:36:24 +0000 (17:36 +1100)]
Merge pull request #22718 from civicrm/5.47

5.47

2 years agoAPIv4 SortableEntity - Fix sorting custom fields with option groups
Coleman Watts [Sun, 6 Feb 2022 20:01:20 +0000 (15:01 -0500)]
APIv4 SortableEntity - Fix sorting custom fields with option groups

Before: APIv4 would guess which fields to use for grouping when sorting by weight.
this caused a bug when sorting custom fields which also had an option_group_id, which
was incorrectly guessed to be used for grouping.

After: New `@groupWeightsBy` annotation removes the guesswork.

2 years agoMerge pull request #22717 from demeritcowboy/grant-stats
demeritcowboy [Mon, 7 Feb 2022 04:07:12 +0000 (23:07 -0500)]
Merge pull request #22717 from demeritcowboy/grant-stats

dev/core#3057 - Fix missing civigrant

2 years agoMerge pull request #22699 from colemanw/searchKitImportCheck
Eileen McNaughton [Mon, 7 Feb 2022 03:45:40 +0000 (16:45 +1300)]
Merge pull request #22699 from colemanw/searchKitImportCheck

SearchKit - Improve import UI to handle update & preview the import

2 years agoMerge pull request #21097 from mattwire/extensionguzzle
demeritcowboy [Mon, 7 Feb 2022 03:29:37 +0000 (22:29 -0500)]
Merge pull request #21097 from mattwire/extensionguzzle

Switch extension downloader and extensions feed to use Guzzle HTTP library

2 years agofix missing civigrant
demeritcowboy [Mon, 7 Feb 2022 02:26:17 +0000 (21:26 -0500)]
fix missing civigrant

2 years agoapi_v3_ExtensionsTest - Switch to Guzzle-style mocking
Tim Otten [Sun, 6 Feb 2022 21:10:55 +0000 (13:10 -0800)]
api_v3_ExtensionsTest - Switch to Guzzle-style mocking

2 years agoMerge pull request #22688 from colemanw/getComponentName
colemanw [Sun, 6 Feb 2022 19:09:00 +0000 (14:09 -0500)]
Merge pull request #22688 from colemanw/getComponentName

REF - Use function to get component name from permission

2 years agoREF - Use function to get componenent name from permission
Coleman Watts [Thu, 3 Feb 2022 00:59:20 +0000 (19:59 -0500)]
REF - Use function to get componenent name from permission

2 years agoMerge pull request #22711 from braders/br-selfclosing-syntax
demeritcowboy [Sun, 6 Feb 2022 15:31:40 +0000 (10:31 -0500)]
Merge pull request #22711 from braders/br-selfclosing-syntax

Use valid syntax for self-closing br elements

2 years agoUse valid syntax for self-closing br elements
Bradley Taylor [Sat, 5 Feb 2022 14:47:17 +0000 (14:47 +0000)]
Use valid syntax for self-closing br elements

2 years agoMerge pull request #22636 from eileenmcnaughton/exampley
colemanw [Sun, 6 Feb 2022 06:48:34 +0000 (01:48 -0500)]
Merge pull request #22636 from eileenmcnaughton/exampley

Add basic contribution example base for contribution workflows

2 years agoMerge pull request #22706 from eileenmcnaughton/notice3
colemanw [Sun, 6 Feb 2022 06:44:59 +0000 (01:44 -0500)]
Merge pull request #22706 from eileenmcnaughton/notice3

Notice fixes

2 years agoMerge pull request #22707 from eileenmcnaughton/notice5
colemanw [Sun, 6 Feb 2022 06:42:40 +0000 (01:42 -0500)]
Merge pull request #22707 from eileenmcnaughton/notice5

Enotice fix

2 years agoSet version to 5.48.alpha1
CiviCRM [Sun, 6 Feb 2022 04:33:44 +0000 (04:33 +0000)]
Set version to 5.48.alpha1

2 years agoSet version to 5.47.beta1
CiviCRM [Sun, 6 Feb 2022 04:30:40 +0000 (04:30 +0000)]
Set version to 5.47.beta1

2 years agoMerge pull request #22058 from kainuk/lecacy-auth
Tim Otten [Sun, 6 Feb 2022 04:09:51 +0000 (20:09 -0800)]
Merge pull request #22058 from kainuk/lecacy-auth

authx - Add configuration screen

2 years agoMerge pull request #22687 from colemanw/cleanupComponentCheck
colemanw [Sun, 6 Feb 2022 01:59:19 +0000 (20:59 -0500)]
Merge pull request #22687 from colemanw/cleanupComponentCheck

REF - Switch to using new `CRM_Core_Component::isEnabled()`

2 years agoauthx.setting.php - Add/tweak help text so it appears on the settings page.
Tim Otten [Sat, 5 Feb 2022 21:47:19 +0000 (13:47 -0800)]
authx.setting.php - Add/tweak help text so it appears on the settings page.

2 years agoMerge pull request #22710 from braders/fulltext-template-accessibility
Seamus Lee [Sat, 5 Feb 2022 22:05:38 +0000 (09:05 +1100)]
Merge pull request #22710 from braders/fulltext-template-accessibility

Improve field accessibility in legacycustomsearches

2 years agoauthx.setting.php - Change sizes and weights to make settings more readable
Tim Otten [Sat, 5 Feb 2022 21:16:27 +0000 (13:16 -0800)]
authx.setting.php - Change sizes and weights to make settings more readable

2 years agoCivilint
Klaas Eikelboom [Fri, 12 Nov 2021 19:14:35 +0000 (20:14 +0100)]
Civilint

2 years agoThis code seems obsolote
Klaas Eikelboom [Mon, 4 Oct 2021 19:35:05 +0000 (21:35 +0200)]
This code seems obsolote

2 years agoAdd settings screen
Klaas Eikelboom [Mon, 4 Oct 2021 19:34:13 +0000 (21:34 +0200)]
Add settings screen

2 years agoCleanup billingBlock.js
Coleman Watts [Sat, 5 Feb 2022 18:04:55 +0000 (13:04 -0500)]
Cleanup billingBlock.js

2 years agoMerge pull request #22709 from braders/dedupe-limit-smarty-notice
colemanw [Sat, 5 Feb 2022 17:05:54 +0000 (12:05 -0500)]
Merge pull request #22709 from braders/dedupe-limit-smarty-notice

Don't throw PHP notice when rendering dedupefind template.

2 years agoMerge pull request #19727 from totten/master-authx-rest
colemanw [Sat, 5 Feb 2022 15:40:18 +0000 (10:40 -0500)]
Merge pull request #19727 from totten/master-authx-rest

(dev/core#2077) Make 'civicrm/ajax/rest' interoperable with 'extern/rest.php' parameters

2 years agoMerge pull request #22705 from eileenmcnaughton/notice2
demeritcowboy [Sat, 5 Feb 2022 14:41:19 +0000 (09:41 -0500)]
Merge pull request #22705 from eileenmcnaughton/notice2

Enotice fixes with datepicker

2 years agoImprove field accessibility in legacycustomsearches
Bradley Taylor [Sat, 5 Feb 2022 14:34:38 +0000 (14:34 +0000)]
Improve field accessibility in legacycustomsearches

2 years agoMerge pull request #22708 from braders/feature/priceset-notice-fix
demeritcowboy [Sat, 5 Feb 2022 14:22:00 +0000 (09:22 -0500)]
Merge pull request #22708 from braders/feature/priceset-notice-fix

Enotice fix with priceset template

2 years agoDon't throw PHP notice when rendering dedupefind template.
Bradley Taylor [Sat, 5 Feb 2022 13:25:54 +0000 (13:25 +0000)]
Don't throw PHP notice when rendering dedupefind template.

2 years agoEnotice fix with priceset template
Bradley Taylor [Sat, 5 Feb 2022 12:10:58 +0000 (12:10 +0000)]
Enotice fix with priceset template

2 years agoEnotice fix
Eileen McNaughton [Sat, 5 Feb 2022 01:43:41 +0000 (14:43 +1300)]
Enotice fix

2 years agoNotice fixes
Eileen McNaughton [Sat, 5 Feb 2022 01:32:17 +0000 (14:32 +1300)]
Notice fixes

These primarily affect 'grumpy-mode'

2 years agoEnotice fixes with datepicker
Eileen McNaughton [Sat, 5 Feb 2022 01:23:10 +0000 (14:23 +1300)]
Enotice fixes with datepicker

Datepicker requires some fields to be set to avoid enotices (at least with grumpy mode disabled).

2 years agoMerge pull request #22704 from braders/remove-invalidprofiles-template-variable
Eileen McNaughton [Sat, 5 Feb 2022 00:51:17 +0000 (13:51 +1300)]
Merge pull request #22704 from braders/remove-invalidprofiles-template-variable

Remove unused invalidProfiles variable, and simplify template.

2 years agoauthx - Extend support for legacy-auth to APIv4
Tim Otten [Sat, 5 Feb 2022 00:23:15 +0000 (16:23 -0800)]
authx - Extend support for legacy-auth to APIv4

2 years agoConvert existing `X-Requested-With:` guards to `isWebServiceRequest()`
Tim Otten [Fri, 4 Feb 2022 23:34:39 +0000 (15:34 -0800)]
Convert existing `X-Requested-With:` guards to  `isWebServiceRequest()`

_Overview_:  `civicrm/ajax/api4` and `returnJsonResponse()` inspect the
web-request to see if it comes via AJAX/REST. If so, the call is
allowed and formatted as JSON. The patch refines the test.

_Before_: `X-Requested-With:` signals that a call is AJAX/REST.

_After_: `X-Requested-With:` still signals that a call is AJAX/REST.
Additionally, if `authx` is enabled, then some requests will be treated as
AJAX/REST based on how they are authenticated (ie `xheader`/`X-Civi-Auth:`
and `param`/`?_authx=` are AJAX/REST).

2 years ago(REF) CRM_Utils_REST::isWebServiceRequest - Mark public. Expand comments.
Tim Otten [Fri, 4 Feb 2022 23:27:09 +0000 (15:27 -0800)]
(REF) CRM_Utils_REST::isWebServiceRequest - Mark public. Expand comments.

2 years agoRemove unused invalidProfiles variable, and simplify template.
Bradley Taylor [Fri, 4 Feb 2022 19:39:03 +0000 (19:39 +0000)]
Remove unused invalidProfiles variable, and simplify template.
As well as simplifying things, this avoids PHP notices.