Eileen McNaughton [Tue, 21 Mar 2023 02:12:58 +0000 (15:12 +1300)]
Merge pull request #25883 from eileenmcnaughton/mail_format
Remove preferred_mail_format from tokens
Eileen McNaughton [Tue, 21 Mar 2023 01:22:54 +0000 (14:22 +1300)]
Merge pull request #25884 from lemniscus/tagset-markup
don't create tagset markup if there's no tagset
Eileen McNaughton [Tue, 21 Mar 2023 00:01:18 +0000 (13:01 +1300)]
Remove preferred_mail_format from tokens
This also removes the handling from action schedule - there
might be a test checking it's presence to putting up
to adapt tests
Tim Otten [Tue, 21 Mar 2023 00:37:25 +0000 (17:37 -0700)]
Merge pull request #25673 from jmcclelland/transaction-lock
ensure delays from transactions don't cause cache race condition
Noah Miller [Mon, 20 Mar 2023 23:54:53 +0000 (19:54 -0400)]
don't create tagset markup if there's no tagset
Seamus Lee [Mon, 20 Mar 2023 21:49:45 +0000 (08:49 +1100)]
Merge pull request #25877 from eileenmcnaughton/submitted
Move getSubmittedValues to `CRM_Core_Form`
colemanw [Mon, 20 Mar 2023 20:49:42 +0000 (16:49 -0400)]
Merge pull request #25882 from lemniscus/tagset-tpl
Skip adding script when it won't have anything to run on
colemanw [Mon, 20 Mar 2023 19:45:49 +0000 (15:45 -0400)]
Merge pull request #25881 from colemanw/dropTable
SchemaHandler - Add IF EXISTS to dropTable function
Noah Miller [Mon, 20 Mar 2023 18:50:01 +0000 (14:50 -0400)]
skip adding script when it won't have anything to run on
Coleman Watts [Mon, 20 Mar 2023 15:57:32 +0000 (11:57 -0400)]
SchemaHandler - Add IF EXISTS to dropTable function
demeritcowboy [Mon, 20 Mar 2023 18:40:44 +0000 (14:40 -0400)]
Merge pull request #25880 from mattwire/caseactivity
Use API4 to create 'Assign Case Role' activity
Matthew Wire [Wed, 22 Feb 2023 14:49:26 +0000 (14:49 +0000)]
Use API4 to create 'Assign Case Role' activity
Matthew Wire [Mon, 20 Mar 2023 13:53:00 +0000 (13:53 +0000)]
Merge pull request #25402 from colemanw/deprecatedActions
APIv4 - Show actions as deprecated in the Explorer
colemanw [Mon, 20 Mar 2023 13:37:58 +0000 (09:37 -0400)]
Merge pull request #25461 from mattwire/dedupepermission
Afform: Fix dedupe rules for anonymous users
colemanw [Mon, 20 Mar 2023 13:23:50 +0000 (09:23 -0400)]
Merge pull request #25779 from eileenmcnaughton/unreachable
Add deprecations to unreachable code in previously shared function
colemanw [Mon, 20 Mar 2023 13:08:03 +0000 (09:08 -0400)]
Merge pull request #25878 from eileenmcnaughton/dep_individual_format
Remove do-nothing noisily deprecated formatting code
Eileen McNaughton [Mon, 20 Mar 2023 06:07:05 +0000 (19:07 +1300)]
Remove do-nothing formatting code
I've been convinced that dates are already handled long before this point
(& loading from the database) so nearly a year ago I added deprecation
notices to fire if this code ever actually did anything. No reports.
It can go:
Eileen McNaughton [Fri, 10 Mar 2023 00:22:36 +0000 (13:22 +1300)]
Add deprecations to unreachable code in previously shared function
Eileen McNaughton [Mon, 20 Mar 2023 04:17:04 +0000 (17:17 +1300)]
Move getSubmittedValues to CRM_Core_Form
Seamus Lee [Mon, 20 Mar 2023 02:58:25 +0000 (13:58 +1100)]
Merge pull request #25875 from eileenmcnaughton/php82_report
[PHP8.2] Declare outputHandler property in reports
Eileen McNaughton [Mon, 20 Mar 2023 01:29:33 +0000 (14:29 +1300)]
[PHP8.2] Declare outputHandler property
I did a universe search to check private is OK
Eileen McNaughton [Mon, 20 Mar 2023 01:13:55 +0000 (14:13 +1300)]
Merge pull request #25872 from totten/master-release-mysqlver
CiviUnitTestCase - Degrade gracefully on older DBMS
Tim Otten [Sun, 19 Mar 2023 22:52:08 +0000 (15:52 -0700)]
CiviUnitTestCase - Allow relaxed enforcement on older DBMS
colemanw [Sun, 19 Mar 2023 22:46:55 +0000 (18:46 -0400)]
Merge pull request #25862 from eileenmcnaughton/dedupe_finder2
Post split code cleanup
Eileen McNaughton [Sun, 19 Mar 2023 22:05:52 +0000 (11:05 +1300)]
Merge pull request #25869 from eileenmcnaughton/import_contact_pre
[REF] Simplify import preProcess
Eileen McNaughton [Sun, 19 Mar 2023 22:04:55 +0000 (11:04 +1300)]
Merge pull request #25868 from eileenmcnaughton/import_switch
Switch out the switch
Eileen McNaughton [Sun, 19 Mar 2023 20:54:15 +0000 (09:54 +1300)]
[REF] Simplify import preProcess
Eileen McNaughton [Sun, 19 Mar 2023 20:42:24 +0000 (09:42 +1300)]
Remove require_onces
Eileen McNaughton [Sun, 19 Mar 2023 00:46:47 +0000 (13:46 +1300)]
Switch out the switch
colemanw [Sun, 19 Mar 2023 14:39:24 +0000 (10:39 -0400)]
Merge pull request #25866 from eileenmcnaughton/import_contribution_mapfield
[REF] Minor code simplification - extract `getHighlightedFields` in Contribution import `MapField`
Seamus Lee [Sun, 19 Mar 2023 03:54:37 +0000 (14:54 +1100)]
Merge pull request #25867 from eileenmcnaughton/import_unused
[NFC] Remove some no-longer-used properties on Contribution import parser
Eileen McNaughton [Sun, 19 Mar 2023 00:35:33 +0000 (13:35 +1300)]
Remove some no-longer-used properties
Eileen McNaughton [Sat, 18 Mar 2023 23:09:57 +0000 (12:09 +1300)]
[REF] Minor code simplification - extract getHighlightedFields
Seamus Lee [Sat, 18 Mar 2023 22:42:46 +0000 (09:42 +1100)]
Merge pull request #25851 from eileenmcnaughton/pledge
dev/core#4079 Add Pledge Tokens
Eileen McNaughton [Sat, 18 Mar 2023 22:15:35 +0000 (11:15 +1300)]
Remove fake if
Eileen McNaughton [Sat, 18 Mar 2023 02:05:21 +0000 (15:05 +1300)]
Remove duplicate layer of caching
This is cached within a cache - the load of calling it is not
especially high and it is somewhat unlikely the cache will be populated
anyway so let's simplfiy...
Eileen McNaughton [Sat, 18 Mar 2023 01:58:37 +0000 (14:58 +1300)]
Remove last non-variable variables
Eileen McNaughton [Sat, 18 Mar 2023 01:57:31 +0000 (14:57 +1300)]
Hard-code cacheKey as variables are not variable
Eileen McNaughton [Sat, 18 Mar 2023 01:55:10 +0000 (14:55 +1300)]
Remove never-true if
isProfile is always false
Eileen McNaughton [Sat, 18 Mar 2023 01:54:13 +0000 (14:54 +1300)]
Stop adding field just so the calling code can strip them
The calling code will not use any field with no WHERE clause
Eileen McNaughton [Sat, 18 Mar 2023 01:47:37 +0000 (14:47 +1300)]
Remove handling for no contact type - it is ALWAYS passed in here
Eileen McNaughton [Sat, 18 Mar 2023 01:39:07 +0000 (14:39 +1300)]
Copy shared ImportableFields to private function, for unravelling
Seamus Lee [Sat, 18 Mar 2023 22:04:02 +0000 (09:04 +1100)]
Merge pull request #25854 from eileenmcnaughton/test_tidy
[NFC] Minor tidy up in `MappingTest`
Seamus Lee [Sat, 18 Mar 2023 21:03:16 +0000 (08:03 +1100)]
Merge pull request #25852 from eileenmcnaughton/php82_contacttest
[Test][Php8.2] Fix undeclared properties & other housekeeping
colemanw [Sat, 18 Mar 2023 18:49:09 +0000 (14:49 -0400)]
Merge pull request #25859 from eileenmcnaughton/dedupe_private
Make `Finder::tableQuery private`, after universe search
colemanw [Sat, 18 Mar 2023 18:48:06 +0000 (14:48 -0400)]
Merge pull request #25864 from braders/php8.2-ParticipantPaymentTes
[REF][PHP8.2] Refactor api_v3_ParticipantPaymentTest
colemanw [Sat, 18 Mar 2023 18:47:14 +0000 (14:47 -0400)]
Merge pull request #25865 from braders/php8.2-eventid-property
[REF][PHP8.2] Refactor getParticipantOrderParams to never write a dynamic property
Bradley Taylor [Sat, 18 Mar 2023 17:30:14 +0000 (17:30 +0000)]
[REF][PHP8.2] Refactor getParticipantOrderParams to never write a dynamic property
Bradley Taylor [Sat, 18 Mar 2023 15:39:54 +0000 (15:39 +0000)]
[REF][PHP8.2] Refactor api_v3_ParticipantPaymentTest
colemanw [Sat, 18 Mar 2023 15:12:16 +0000 (11:12 -0400)]
Merge pull request #25860 from eileenmcnaughton/dedupe_query
[REF] Replace use of legacy `$dao->query()` with `CRM_Core_DAO::executeQuery()`
Eileen McNaughton [Sat, 18 Mar 2023 00:41:48 +0000 (13:41 +1300)]
Replace use of legacy dao->query()
Eileen McNaughton [Sat, 18 Mar 2023 05:19:31 +0000 (18:19 +1300)]
Merge pull request #25844 from braders/dynamic-props-ProcessorFormTest
[REF][PHP8.2] Get rid of dynamic properties in CRM_Core_Payment_ProcessorFormTest
Eileen McNaughton [Sat, 18 Mar 2023 00:33:41 +0000 (13:33 +1300)]
Make Finder::tableQuery private, after universe search
Eileen McNaughton [Fri, 17 Mar 2023 23:36:22 +0000 (12:36 +1300)]
Merge pull request #25858 from totten/master-autoclean-explicit
AutoClean - Optionally allow explicit cleanup
Bradley Taylor [Thu, 16 Mar 2023 09:25:32 +0000 (09:25 +0000)]
[REF][PHP8.2] Get rid of dynamic properties in CRM_Core_Payment_ProcessorFormTest
Tim Otten [Fri, 17 Mar 2023 22:36:01 +0000 (15:36 -0700)]
AutoClean - Optionally allow explicit cleanup
Tim Otten [Fri, 17 Mar 2023 21:44:28 +0000 (14:44 -0700)]
CRM_Core_Lock - Deferred release should work same for commit or rollback
Jamie McClelland [Mon, 27 Feb 2023 18:36:26 +0000 (13:36 -0500)]
ensure we properly pass the arguments needed.
Jamie McClelland [Mon, 27 Feb 2023 16:36:04 +0000 (11:36 -0500)]
ensure delays from transactions don't cause cache race condition
https://lab.civicrm.org/dev/core/-/issues/3988
Tim Otten [Fri, 17 Mar 2023 21:40:44 +0000 (14:40 -0700)]
Merge pull request #25856 from totten/test-release-locks
CiviUnitTestCase - During teardown, ensure that we cleanup locks
colemanw [Fri, 17 Mar 2023 21:27:37 +0000 (17:27 -0400)]
Merge pull request #25801 from eileenmcnaughton/82_part_test
[PHP8.2] Clean up in `apiv3_ParticipantTest` with view to 8.2 compatibility
Eileen McNaughton [Fri, 17 Mar 2023 21:24:55 +0000 (10:24 +1300)]
Merge pull request #25799 from eileenmcnaughton/php82-invoice_id
[PHP8.2] [Test] Remove use of (often undeclared) property `_invoiceID` in tests & one instance of `paymentProcessorID2`
demeritcowboy [Fri, 17 Mar 2023 15:42:51 +0000 (11:42 -0400)]
Merge pull request #25857 from colemanw/unusedVar
Remove unused var
Coleman Watts [Fri, 17 Mar 2023 14:26:25 +0000 (10:26 -0400)]
Remove unused var
Tim Otten [Fri, 17 Mar 2023 07:22:03 +0000 (00:22 -0700)]
CiviUnitTestCase - During cleanup, ensure that we have a clean slate (wrt locking)
Eileen McNaughton [Fri, 17 Mar 2023 04:33:03 +0000 (17:33 +1300)]
Merge pull request #25853 from lemniscus/crm-core-form-php8-typeerror
Avoid type error in CRM_Core_Form on php 8
Eileen McNaughton [Thu, 16 Mar 2023 09:13:50 +0000 (22:13 +1300)]
Minor tidy up in MappingTest
Noah Miller [Fri, 17 Mar 2023 03:20:27 +0000 (23:20 -0400)]
avoid type error in CRM_Core_Form on php 8
Eileen McNaughton [Thu, 16 Mar 2023 23:11:54 +0000 (12:11 +1300)]
[Test][Php8.2] Fix undeclared properties & other housekeeping
Seamus Lee [Fri, 17 Mar 2023 00:26:39 +0000 (11:26 +1100)]
Merge pull request #25811 from eileenmcnaughton/import_access
dev/core#4184 Permit access to template user jobs (imports)
Eileen McNaughton [Thu, 16 Mar 2023 23:24:00 +0000 (12:24 +1300)]
Merge pull request #25847 from civicrm/5.60
5.60
Eileen McNaughton [Tue, 14 Mar 2023 21:15:52 +0000 (10:15 +1300)]
Permit access to template user jobs (imports)
Eileen McNaughton [Thu, 16 Mar 2023 22:41:36 +0000 (11:41 +1300)]
dev/core#4079 Add Pledge Tokens
Eileen McNaughton [Thu, 16 Mar 2023 23:20:05 +0000 (12:20 +1300)]
Merge pull request #25849 from seamuslee001/dev_core_4190
dev/core#4190 Fix issue where defaultValues needs to be an array not …
Seamus Lee [Thu, 16 Mar 2023 22:52:43 +0000 (09:52 +1100)]
Merge pull request #25850 from demeritcowboy/vardumper
PHP8 - Update symfony/var-dumper
demeritcowboy [Thu, 16 Mar 2023 22:02:48 +0000 (18:02 -0400)]
Merge pull request #25831 from eileenmcnaughton/skip_rest
[PHP8.2] Remove unused setting on undeclared properties
demeritcowboy [Thu, 16 Mar 2023 22:02:28 +0000 (18:02 -0400)]
Merge pull request #25830 from eileenmcnaughton/skip_member
[PHP8.2] Remove unused variabls from `Member_Form_Task_PDFLetter::postProcessMembers`
demeritcowboy [Thu, 16 Mar 2023 22:01:42 +0000 (18:01 -0400)]
Merge pull request #25829 from eileenmcnaughton/skip
[REF] [php8.2] Remove unused parameters from `Contribute_PDFLetter::buildContributionArray`
demeritcowboy [Thu, 16 Mar 2023 21:47:53 +0000 (17:47 -0400)]
update var-dumper for php8
Seamus Lee [Thu, 16 Mar 2023 21:40:36 +0000 (08:40 +1100)]
Merge pull request #25776 from eileenmcnaughton/rec-fix
dev/core#4000 Fix (old) regression - ensure only template contribution updates update recur
Seamus Lee [Thu, 16 Mar 2023 21:34:02 +0000 (08:34 +1100)]
dev/core#4190 Fix issue where defaultValues needs to be an array not boolean
Eileen McNaughton [Thu, 16 Mar 2023 21:23:31 +0000 (10:23 +1300)]
Merge pull request #25846 from seamuslee001/fix_invalid_soft_credit_table
dev/core#4187 Fix errors when sorting by contributor name or receive …
Seamus Lee [Thu, 16 Mar 2023 20:32:49 +0000 (07:32 +1100)]
dev/core#4187 Fix errors when sorting by contributor name or receive date in the soft credit table
colemanw [Thu, 16 Mar 2023 16:48:13 +0000 (12:48 -0400)]
Merge pull request #25827 from colemanw/afformCommaFilters
SearchKit - Handle comma-separated values passed from Afform url
colemanw [Thu, 16 Mar 2023 16:15:52 +0000 (12:15 -0400)]
Merge pull request #25842 from eileenmcnaughton/import_remove_dep
Deprecated `buildSavedMappingFields` noisily
Yashodha Chaku [Thu, 16 Mar 2023 16:13:37 +0000 (21:43 +0530)]
Merge pull request #25841 from eileenmcnaughton/import_old
Remove un-used, un-displayed button
Seamus Lee [Thu, 16 Mar 2023 08:16:16 +0000 (19:16 +1100)]
Merge pull request #25824 from colemanw/dateFields
Afform - Allow contact created/modified date fields to be used as filters
Eileen McNaughton [Thu, 16 Mar 2023 07:33:30 +0000 (20:33 +1300)]
Merge pull request #25843 from eileenmcnaughton/master
5.60 to master
Eileen McNaughton [Thu, 16 Mar 2023 07:30:26 +0000 (20:30 +1300)]
Merge branch '5.60' of github.com:civicrm/civicrm-core
Eileen McNaughton [Thu, 16 Mar 2023 04:34:16 +0000 (17:34 +1300)]
Deprecated buildSavedMappingFields noisily
This function was only being used from one place & was
only separate from that function because the Contact DataSource
form used to call it directly. That is no longer
true so I've coped the code into
the calling function & added noisy deprecation, with a view to remove
Eileen McNaughton [Thu, 16 Mar 2023 04:02:25 +0000 (17:02 +1300)]
Remove un-used, un-displayed button
Eileen McNaughton [Thu, 16 Mar 2023 03:34:52 +0000 (16:34 +1300)]
Merge pull request #25822 from colemanw/afformValidateSavedSearch
Afform - Fix validateBySavedSearch
Eileen McNaughton [Thu, 16 Mar 2023 02:06:32 +0000 (15:06 +1300)]
Merge pull request #25839 from eileenmcnaughton/master
Merge 5.60 to master
colemanw [Thu, 16 Mar 2023 01:38:59 +0000 (21:38 -0400)]
Merge pull request #25832 from colemanw/multiSelectUrl
Afform - set multi-select values from url
Coleman Watts [Wed, 15 Mar 2023 18:41:16 +0000 (14:41 -0400)]
Afform - Allow contact created/modified date fields to be used as filters
Eileen McNaughton [Thu, 16 Mar 2023 01:15:04 +0000 (14:15 +1300)]
Merge branch '5.60' of github.com:civicrm/civicrm-core
demeritcowboy [Thu, 16 Mar 2023 00:45:36 +0000 (20:45 -0400)]
Merge pull request #25835 from eileenmcnaughton/560
Remove require_dev yoast/phpunit-polyfills
Seamus Lee [Thu, 16 Mar 2023 00:19:01 +0000 (11:19 +1100)]
Merge pull request #25836 from totten/phpunit-env-var
(REF) PHPUnit - Allow env-var to specify version
Eileen McNaughton [Wed, 15 Mar 2023 23:31:33 +0000 (12:31 +1300)]
Merge pull request #25834 from braders/php8.1-dedupefind
[REF][PHP8.2] Declare property in CRM_Contact_Form_DedupeFind
Tim Otten [Wed, 15 Mar 2023 23:17:07 +0000 (16:17 -0700)]
PHPUnit - Allow env-var to specify version (for tools/scripts/phpunit)