eileen [Fri, 15 Feb 2019 20:40:54 +0000 (09:40 +1300)]
Add thousandseparator variant to test
eileen [Fri, 15 Feb 2019 20:35:50 +0000 (09:35 +1300)]
Add refund relevant fields & tests to payment.sendconfirmation
Seamus Lee [Tue, 19 Feb 2019 19:42:21 +0000 (06:42 +1100)]
Merge pull request #13620 from eileenmcnaughton/signuptype
[unused code cleanup] Remove unused 'signupType' url support
Monish Deb [Tue, 19 Feb 2019 08:45:55 +0000 (14:15 +0530)]
Merge pull request #13609 from eileenmcnaughton/payment_conf
Payment.sendconfirmation api - add further tpl variables.
Eileen McNaughton [Tue, 19 Feb 2019 06:57:28 +0000 (19:57 +1300)]
Merge pull request #13534 from yashodha/dev-696
(dev/core#696) Changes to copied event phone and email reflects in or…
Eileen McNaughton [Tue, 19 Feb 2019 06:54:27 +0000 (19:54 +1300)]
Merge pull request #13639 from civicrm/5.11
5.11
Seamus Lee [Tue, 19 Feb 2019 05:46:05 +0000 (16:46 +1100)]
Merge pull request #13636 from eileenmcnaughton/strtolower
Remove another instance of 'lower'
Seamus Lee [Tue, 19 Feb 2019 05:44:08 +0000 (16:44 +1100)]
Merge pull request #13637 from jitendrapurohit/core737
dev/core#737 - SMS not sent if 'Send Immediately' option is chosen on…
Jitendra Purohit [Tue, 19 Feb 2019 04:02:20 +0000 (09:32 +0530)]
dev/core#737 - SMS not sent if 'Send Immediately' option is chosen on the last screen
eileen [Tue, 19 Feb 2019 03:38:41 +0000 (16:38 +1300)]
Remove another instance of 'lower'
We have removed almost all of these from the code base due to the performance cost
combined with the lack of any upside. Just found another
colemanw [Tue, 19 Feb 2019 01:36:17 +0000 (20:36 -0500)]
Merge pull request #13630 from eileenmcnaughton/goodbye_mode_and_median_hello_speed
dev/core#720 Remove median & mode stats from contribution summary in order to improve performance
colemanw [Mon, 18 Feb 2019 17:40:03 +0000 (12:40 -0500)]
Merge pull request #13629 from eileenmcnaughton/mailing_job_test_use
[Test changes] Mailing job test use
colemanw [Mon, 18 Feb 2019 17:27:28 +0000 (12:27 -0500)]
Merge pull request #13543 from mlutfy/fixDefaultPDFFormat
Fix html2pdf default PDF format when multiple pdf_format are available.
Eileen McNaughton [Mon, 18 Feb 2019 07:18:43 +0000 (20:18 +1300)]
Merge pull request #13631 from colemanw/entityRefs3
EntityRef - standardize on PascalCase for entity name and fix minor bug
Eileen McNaughton [Mon, 18 Feb 2019 07:18:30 +0000 (20:18 +1300)]
Merge pull request #13632 from colemanw/CRM_Report_Form_Event
[REF] Remove useless class CRM_Report_Form_Event
eileen [Mon, 18 Feb 2019 01:17:37 +0000 (14:17 +1300)]
Remove multiple currency handling as it seems to make it format worse
eileen [Mon, 18 Feb 2019 00:36:39 +0000 (13:36 +1300)]
Deprecate computeStats off to the one place that still uses it.
We MIGHT have reports calling it so to avoid a fatal we will not remove the function just yet
eileen [Mon, 18 Feb 2019 00:31:00 +0000 (13:31 +1300)]
Remove median & mode stats from contribution summary in order to improve performance
Eileen McNaughton [Mon, 18 Feb 2019 04:31:18 +0000 (17:31 +1300)]
Merge pull request #13579 from mattwire/contributionrecur_metadata
Contribution/ContributionRecur metadata updates for EntityForm
Coleman Watts [Mon, 18 Feb 2019 04:16:36 +0000 (23:16 -0500)]
Remove useless class CRM_Report_Form_Event
Coleman Watts [Mon, 18 Feb 2019 03:55:21 +0000 (22:55 -0500)]
Use PascalCase with CRM_Core_Form::addEntityRef
Although entityRef fields accept either snake_case or CamelCase, let's be consistent.
Coleman Watts [Mon, 18 Feb 2019 03:46:27 +0000 (22:46 -0500)]
EntityRef: Fix caching filter option lists
The filters objects were getting cloned instead of passed by reference,
which prevented loadEntityRefFilterOptions() from saving the list for reuse.
Coleman Watts [Mon, 18 Feb 2019 00:56:00 +0000 (19:56 -0500)]
EntityRef - standardize on PascalCase for entity name
eileen [Mon, 18 Feb 2019 00:26:53 +0000 (13:26 +1300)]
Change the call used to generate recipients in unit tests
Passes in scheduled_date (as the 'real' api call would)
Part of this attempted deprecation #13627
colemanw [Mon, 18 Feb 2019 00:23:43 +0000 (19:23 -0500)]
Merge pull request #13607 from eileenmcnaughton/cont_summary_extract
dev/core#720 [REF] refactor out components of contributionSummary function
Eileen McNaughton [Sun, 17 Feb 2019 23:02:23 +0000 (12:02 +1300)]
Merge pull request #13628 from colemanw/entityRefs2
Standardize format for entityRef create links
eileen [Sun, 17 Feb 2019 04:16:33 +0000 (17:16 +1300)]
Move output formatting to the relevant functions
eileen [Fri, 15 Feb 2019 03:39:55 +0000 (16:39 +1300)]
Remove duplicate setting of variables
Eileen McNaughton [Sun, 17 Feb 2019 22:13:19 +0000 (11:13 +1300)]
Merge pull request #13624 from eileenmcnaughton/minor_pdf_utl_cleanup
[Code cleanup] Remove unused $stationery_path parameter
Eileen McNaughton [Sun, 17 Feb 2019 22:11:23 +0000 (11:11 +1300)]
Merge pull request #13626 from eileenmcnaughton/cont_summary_extract1
[REF] extract cancelled stats to own function
Coleman Watts [Sun, 17 Feb 2019 21:42:26 +0000 (16:42 -0500)]
Standardize format for entityRef create links
Eileen McNaughton [Sun, 17 Feb 2019 21:29:20 +0000 (10:29 +1300)]
Merge pull request #13625 from colemanw/entityRefs
[REF] Move entityRef filters into their respective BAOs
eileen [Fri, 15 Feb 2019 03:32:47 +0000 (16:32 +1300)]
[REF] extract cancelled stats to own function
eileen [Sun, 17 Feb 2019 07:57:06 +0000 (20:57 +1300)]
Remove unused parameter
Coleman Watts [Sun, 17 Feb 2019 19:20:09 +0000 (14:20 -0500)]
Move entityRef filters into their respective BAOs
colemanw [Sun, 17 Feb 2019 18:01:08 +0000 (13:01 -0500)]
Merge pull request #13622 from eileenmcnaughton/cont_summary_extract1
[REF] extract basic soft credit stats to separate function
colemanw [Sun, 17 Feb 2019 17:59:55 +0000 (12:59 -0500)]
Merge pull request #13621 from eileenmcnaughton/default_wrong_declared
[code cleanup] Default wrong declared
colemanw [Sun, 17 Feb 2019 17:58:55 +0000 (12:58 -0500)]
Merge pull request #13619 from eileenmcnaughton/unused_pending_param
[REF] Remove unused function parameter
colemanw [Sun, 17 Feb 2019 17:37:56 +0000 (12:37 -0500)]
Merge pull request #13623 from eileenmcnaughton/comment
Remove long block of commented out code from 4 years ago
Eileen McNaughton [Sun, 17 Feb 2019 07:39:47 +0000 (20:39 +1300)]
Merge pull request #13601 from alexymik/patch-1
Always load recaptcha JS over HTTPS
Eileen McNaughton [Sun, 17 Feb 2019 07:34:03 +0000 (20:34 +1300)]
Merge pull request #13499 from mattwire/profilecontact_nocontactid_subtype
If a profile is used to create a contact with a subtype the contact will not have any existing subtypes
eileen [Sun, 17 Feb 2019 05:26:21 +0000 (18:26 +1300)]
Remove long block of commented out code from 4 years ago
eileen [Fri, 15 Feb 2019 03:26:24 +0000 (16:26 +1300)]
[REF] extract basic soft credit stats to separate function
eileen [Sun, 17 Feb 2019 05:18:33 +0000 (18:18 +1300)]
As previously commented this array is never used.
I did a codebase grep on ->defaults & am pretty confident here....
colemanw [Sun, 17 Feb 2019 05:18:27 +0000 (00:18 -0500)]
Merge pull request #13618 from eileenmcnaughton/test_info
[Test support] Add extra output info when getsingle fails as this seems to be common in intermittant fails
colemanw [Sun, 17 Feb 2019 05:16:36 +0000 (00:16 -0500)]
Merge pull request #13616 from eileenmcnaughton/cont_summary_extract1
[REF] extract add median to stats
eileen [Sun, 17 Feb 2019 05:05:04 +0000 (18:05 +1300)]
Remove unused 'signupType' url support
The use of this was removed in https://github.com/civicrm/civicrm-core/pull/911
on the basis it didn't work.
This is just cleanup not done then.
(Note we shouldn't comment stuff out we should remove it as a rule)
eileen [Sun, 17 Feb 2019 04:01:19 +0000 (17:01 +1300)]
Remove unused function parameter
The function getContributionParams was created as part of a larger refactoring/
code cleanup effort. One of those goals was to get to a point
where contributions are always created with a pending status and are later
confirmed when a payment is added.
It if only called from one place and TRUE is always passed for
so we no longer need the parameter in this function, remove it
eileen [Sun, 17 Feb 2019 03:41:35 +0000 (16:41 +1300)]
Add extra output info when getsingle fails as this seems to be common in intermittant fails
Eileen McNaughton [Sun, 17 Feb 2019 03:36:03 +0000 (16:36 +1300)]
Merge pull request #13617 from eileenmcnaughton/no_dead_service_tests
Remove tests that no longer work due to dead service
eileen [Fri, 15 Feb 2019 02:03:27 +0000 (15:03 +1300)]
[REF] extract add median to stats
eileen [Sun, 17 Feb 2019 01:42:47 +0000 (14:42 +1300)]
Remove tests that no longer work due to dead service
colemanw [Sun, 17 Feb 2019 01:01:57 +0000 (20:01 -0500)]
Merge pull request #13606 from eileenmcnaughton/profile_perf
Fix (sometimes serious) performance problem on submitting profiles for specified contacts
Eileen McNaughton [Sun, 17 Feb 2019 00:53:52 +0000 (13:53 +1300)]
Merge pull request #13614 from eileenmcnaughton/cont_summary_extract1
[REF] extract calculation of mode stat
Eileen McNaughton [Sat, 16 Feb 2019 23:34:22 +0000 (12:34 +1300)]
Merge pull request #13615 from civicrm/5.11
5.11 to master
Eileen McNaughton [Sat, 16 Feb 2019 23:33:06 +0000 (12:33 +1300)]
Merge pull request #13613 from colemanw/openCampaignWidget
Auto-open campaign widget and sort by start date
colemanw [Sat, 16 Feb 2019 22:47:08 +0000 (17:47 -0500)]
Merge pull request #13373 from MegaphoneJon/core-580-2
fixes core#580 - view all groups when appropriately permissioned
Eileen McNaughton [Sat, 16 Feb 2019 22:23:22 +0000 (11:23 +1300)]
Merge pull request #13612 from colemanw/l10n.js
Move l10n.js to coreResourcesList
eileen [Fri, 15 Feb 2019 01:41:04 +0000 (14:41 +1300)]
[REF] extract calculation of mode stat
Coleman Watts [Sat, 16 Feb 2019 21:25:18 +0000 (16:25 -0500)]
Auto-open campaign widget and sort by start date
Coleman Watts [Sat, 16 Feb 2019 20:13:01 +0000 (15:13 -0500)]
Move l10n.js to coreResourcesList
This change allows core resources to be added to the list AFTER l10n variables
have been initialized. This is needed by crm.menubar.js.
Another upshot of this change is that extensions will be able to add items to the list
as fully-formed urls.
colemanw [Sat, 16 Feb 2019 19:47:37 +0000 (14:47 -0500)]
Merge pull request #13425 from mfb/utf8mb4
Add install and runtime status warnings if MySQL utf8mb4 is not supported
colemanw [Sat, 16 Feb 2019 19:21:00 +0000 (14:21 -0500)]
Merge pull request #13608 from eileenmcnaughton/cont_summary_extract1
[REF] extract calculation of basic stats
colemanw [Sat, 16 Feb 2019 19:14:48 +0000 (14:14 -0500)]
Merge pull request #13587 from eileenmcnaughton/acl_location
[REF] Move addSelectWhere-like function to be located on BAO_Contribution
Monish Deb [Sat, 16 Feb 2019 07:32:52 +0000 (13:02 +0530)]
Merge pull request #13563 from eileenmcnaughton/fn_fix_payment_by_type
[REF] Fix silly function to do less handling of non-existent scenarios
Eileen McNaughton [Sat, 16 Feb 2019 06:53:47 +0000 (19:53 +1300)]
Merge pull request #13611 from seamuslee001/exception_api
Add in Exception API to support the refactor of Dedupe Exception Page
Alok Patel [Sat, 16 Feb 2019 02:05:38 +0000 (13:05 +1100)]
Add in Exception API to support the refactor of Dedupe Exception Page
eileen [Fri, 15 Feb 2019 18:48:39 +0000 (07:48 +1300)]
Add location & relevant tests to payment.sendconfrimation
eileen [Fri, 15 Feb 2019 18:07:18 +0000 (07:07 +1300)]
Payment.sendconfirmation api - add further tpl variables.
This is a continuance of the introduction of this api
Mathieu Lu [Fri, 15 Feb 2019 16:30:39 +0000 (11:30 -0500)]
Merge pull request #13591 from mfb/683-incorrectly-encoded-state-and-country-names
fixes dev/core#683 Incorrectly encoded state and country names
eileen [Fri, 15 Feb 2019 00:57:12 +0000 (13:57 +1300)]
[REF] extract calculation of basic stats
Seamus Lee [Fri, 15 Feb 2019 06:08:27 +0000 (17:08 +1100)]
Merge pull request #13605 from eileenmcnaughton/cont_summary
dev/core#720 add unit test, remove legacy code style.
eileen [Fri, 15 Feb 2019 04:00:54 +0000 (17:00 +1300)]
Fix (sometimes serious) performance problem on submitting profiles for specified contacts.
->_id is set when the contact id is known - e.g in edit, in contactlayouteditor profile
blocks. However, current logic still retrieves duplicates and then... does nothing
with them if ->_id is set. By moving the if up higher we can save the server from
doing unnecesary queries. Note that if you submit a tag profile with no other fields in it
the query is server-destroyingly bad with this
Eileen McNaughton [Fri, 15 Feb 2019 03:51:49 +0000 (16:51 +1300)]
Merge pull request #13600 from eileenmcnaughton/profile_perf
[REF] extract chunk of code to a separate function
eileen [Thu, 14 Feb 2019 22:50:56 +0000 (11:50 +1300)]
dev/core#720 add unit test, remove legacy code style.
This PR adds tests to the summaryQuery code in preparation for changes.
The one non-test change is to remove the & from summaryContribution fn.
It is only called from one place in the code & that place does not return as reference.
```
/**
* @return mixed
*/
public function getSummary() {
return $this->_query->summaryContribution($this->_context);
}
```
Yashodha Chaku [Fri, 15 Feb 2019 02:33:52 +0000 (08:03 +0530)]
Merge pull request #13432 from francescbassas/patch-16
dev/core#657 - Add filter for country on Repeat Contributions Report
eileen [Wed, 13 Feb 2019 03:45:11 +0000 (16:45 +1300)]
Move addSelectWhere-like function to be located on BAO_Contribution using correct name.
Since the contribution api uses the BAO_Query object I think it will not call this, nor reports AFAIK
However, this should cause the v4 api to apply these.
eileen [Thu, 14 Feb 2019 20:42:00 +0000 (09:42 +1300)]
[REF] extract chunk of code to a separate function
Eileen McNaughton [Thu, 14 Feb 2019 23:29:19 +0000 (12:29 +1300)]
Merge pull request #13602 from civicrm/5.11
5.11 to master
Seamus Lee [Thu, 14 Feb 2019 22:26:45 +0000 (09:26 +1100)]
Merge pull request #13599 from seamuslee001/5.11
Add in release notes for 5.10.2
Tim Otten [Thu, 14 Feb 2019 22:14:38 +0000 (14:14 -0800)]
Update 5.10.2.md
Tim Otten [Thu, 14 Feb 2019 22:14:19 +0000 (14:14 -0800)]
Update 5.10.2.md
Minor copy-edits:
* Punctuation to match other point-release docs
* Use consistent reverse-alpha in credits
* Add some more authors+reviewers from Github
Alexy Mikhailichenko [Thu, 14 Feb 2019 22:12:19 +0000 (17:12 -0500)]
Always load recaptcha JS over HTTPS
Seamus Lee [Thu, 14 Feb 2019 21:45:19 +0000 (08:45 +1100)]
Merge pull request #13593 from eileenmcnaughton/acl_regression
dev/core#721 Fix regression on refreshing group_contact cache before checking acls
Eileen McNaughton [Thu, 14 Feb 2019 21:32:58 +0000 (10:32 +1300)]
Merge pull request #13592 from yashodha/dev-705
(dev/core#705) Disabling Alphabetical Pager is not respected for cont…
Seamus Lee [Thu, 14 Feb 2019 20:34:43 +0000 (07:34 +1100)]
Add in release notes for 5.10.2
Update release notes as per Eileen's comment
Add in notes on merge of dev/core#715 fix
eileen [Thu, 14 Feb 2019 05:37:14 +0000 (18:37 +1300)]
Fix regression on refreshing group_contact cache before checking acls
We seem to be checking if the cache needs a rebuild and IF SO doing 2 actions
1) rebuilding it
2) permitting access to contacts related to it
When really it should do only 1) above - this patch changes as such
This seems to be whackamole off https://github.com/civicrm/civicrm-core/pull/12344
going too far one way & https://github.com/civicrm/civicrm-core/pull/13448
fixing but adding this new variant
Eileen McNaughton [Thu, 14 Feb 2019 20:17:05 +0000 (09:17 +1300)]
Merge pull request #13561 from eileenmcnaughton/payment_conf
Add new Payment.sendconfirmation api
francescbassas [Thu, 14 Feb 2019 11:27:17 +0000 (12:27 +0100)]
Update Repeat.php
Add basic contact fields and filters on Repeat Contributions Report
Yashodha Chaku [Thu, 14 Feb 2019 11:10:27 +0000 (16:40 +0530)]
Merge pull request #13517 from alifrumin/contribsearchsoftcredit
Find Contributions columns/headers not aligned when "Contributions OR Soft Credits?" filter set to "Soft Credits Only"
yashodha [Thu, 14 Feb 2019 04:40:19 +0000 (10:10 +0530)]
(dev/core#705) Disabling Alphabetical Pager is not respected for contribution pages.
mark burdett [Thu, 14 Feb 2019 00:06:51 +0000 (16:06 -0800)]
fixes dev/core#683 Incorrectly encoded state and country names
eileen [Mon, 11 Feb 2019 03:39:55 +0000 (16:39 +1300)]
Add new Payment.sendconfirmation api
This adds a new api Payment.sendconfirmation intended to be an equivalent of
Contribution.sendconfirmation.
The key thing this needs to be able to do is to load up all
related information to assign to the template - this is not all covered in this
PR & until it is functionally equivalent to AdditionalPayment::sendEmail
we can't switch over but since it's new functionality we should be able to
merge & keep working on it.
Note that there is discussion on the PR this relates to (#13330) about what should
happen if 'Payment.create' api accepts 'is_email_receipt'. I think the most logical
outcome is that receipts would go out if it caused the contribution to be completed
(ie. we pass is_email_receipt into completetransaction api).
However, I don't feel like that is 'settled' yet - separating into a second api
(Payment.sendnotification) means we will have 2 generic function which can be called
from multiple places in the code rather than 2 functions tightly tied to the form layer.
I think it's OK if it is 2 not one
Eileen McNaughton [Wed, 13 Feb 2019 23:22:14 +0000 (12:22 +1300)]
Merge pull request #13571 from eileenmcnaughton/book
dev/report#7 fix trxn_date on bookkeeping report
Eileen McNaughton [Wed, 13 Feb 2019 22:39:42 +0000 (11:39 +1300)]
Merge pull request #13528 from jitendrapurohit/dev-684
dev/core#684 - Case Manager not updating correctly
Eileen McNaughton [Wed, 13 Feb 2019 22:26:12 +0000 (11:26 +1300)]
Merge pull request #13539 from eileenmcnaughton/email_task
dev/core#469 Fix Error on action 'Email - schedule/send via CiviMail' with multiple event names filter
Seamus Lee [Wed, 13 Feb 2019 20:33:42 +0000 (07:33 +1100)]
Merge pull request #13584 from eileenmcnaughton/user_dash_use_api
[REF} User api rather than selector for rendering contributions on user dashboard
Eileen McNaughton [Wed, 13 Feb 2019 20:26:45 +0000 (09:26 +1300)]
Merge pull request #13538 from eileenmcnaughton/dedupe_birth
dev/core#397 Dedupe for Individual Birth Date Results in Error
Eileen McNaughton [Wed, 13 Feb 2019 20:21:17 +0000 (09:21 +1300)]
Merge pull request #13557 from vingle/patch-5
Improves styling on Joomla! upgrade screen
Eileen McNaughton [Wed, 13 Feb 2019 19:30:06 +0000 (08:30 +1300)]
Merge pull request #13573 from pradpnayak/GroupInlineEdit
dev/core/issues/714, Inline edit should be disabled if user doesn't have edit group permission