civicrm-core.git
4 years agoMerge pull request #18899 from seamuslee001/composer_2x
Seamus Lee [Mon, 2 Nov 2020 08:41:37 +0000 (19:41 +1100)]
Merge pull request #18899 from seamuslee001/composer_2x

Update composer-download-plugin to v3.0.0 to support usage of compose…

4 years agoMerge pull request #18901 from alifrumin/5.31rn
Seamus Lee [Mon, 2 Nov 2020 07:20:35 +0000 (18:20 +1100)]
Merge pull request #18901 from alifrumin/5.31rn

[NFC] 5.31 Release Notes - First Pass

4 years agoMerge pull request #18898 from seamuslee001/dev_core_2147
Seamus Lee [Mon, 2 Nov 2020 05:40:22 +0000 (16:40 +1100)]
Merge pull request #18898 from seamuslee001/dev_core_2147

dev/core#2147 Switch the groups search field on Simple search back fr…

4 years agoUpdate composer-download-plugin to v3.0.0 to support usage of composer 2.x
Seamus Lee [Mon, 2 Nov 2020 02:07:15 +0000 (13:07 +1100)]
Update composer-download-plugin to v3.0.0 to support usage of composer 2.x

4 years ago5.31 release notes first pass
Alice Frumin [Fri, 23 Oct 2020 01:04:04 +0000 (20:04 -0500)]
5.31 release notes first pass

4 years agodev/core#2147 Switch the groups search field on Simple search back from select2 to...
Seamus Lee [Mon, 2 Nov 2020 01:31:09 +0000 (12:31 +1100)]
dev/core#2147 Switch the groups search field on Simple search back from select2 to normal select

4 years agoMerge pull request #18877 from seamuslee001/dev_core_2149
Eileen McNaughton [Sun, 1 Nov 2020 20:51:02 +0000 (09:51 +1300)]
Merge pull request #18877 from seamuslee001/dev_core_2149

dev/core#2149 Ensure that if a chained select field is required and t…

4 years agoMerge pull request #18890 from seamuslee001/dev_core_2154
Seamus Lee [Sat, 31 Oct 2020 00:53:04 +0000 (11:53 +1100)]
Merge pull request #18890 from seamuslee001/dev_core_2154

dev/core#2154 Fix the output of the full text custom search form

4 years agoMerge pull request #18889 from demeritcowboy/fulltext-attributes
colemanw [Fri, 30 Oct 2020 23:10:09 +0000 (19:10 -0400)]
Merge pull request #18889 from demeritcowboy/fulltext-attributes

dev/core#2154 - Pass correct parameters to CRM_Core_Form::add() in fulltext custom search

4 years agodev/core#2154 Fix the output of the full text custom search form
Seamus Lee [Fri, 30 Oct 2020 22:44:19 +0000 (09:44 +1100)]
dev/core#2154 Fix the output of the full text custom search form

4 years agopass correct parameters
demeritcowboy [Fri, 30 Oct 2020 21:33:03 +0000 (17:33 -0400)]
pass correct parameters

4 years agodev/core#2149 Ensure that if a chained select field is required and there are no...
Seamus Lee [Thu, 29 Oct 2020 23:08:35 +0000 (10:08 +1100)]
dev/core#2149 Ensure that if a chained select field is required and there are no valid options found ensure that jquery validation doesn't block submission

4 years agoMerge pull request #18873 from colemanw/title_plural
Eileen McNaughton [Thu, 29 Oct 2020 20:12:25 +0000 (09:12 +1300)]
Merge pull request #18873 from colemanw/title_plural

APIv4 - Fix nonstandard camelCase of title_plural field

4 years agoAPIv4 - Fix nonstandard camelCase of title_plural field
Coleman Watts [Thu, 29 Oct 2020 15:33:19 +0000 (11:33 -0400)]
APIv4 - Fix nonstandard camelCase of title_plural field

4 years agoMerge pull request #18857 from eileenmcnaughton/sort2
Seamus Lee [Mon, 26 Oct 2020 23:10:04 +0000 (10:10 +1100)]
Merge pull request #18857 from eileenmcnaughton/sort2

dev/core#2132 Fix for sort on search results

4 years agodev/core#2132 Fix for sort on search results
eileen [Mon, 26 Oct 2020 05:56:58 +0000 (18:56 +1300)]
dev/core#2132 Fix for sort on search results

Simpler fix - accept bad sql but catch it :-(

Ideally we would always be in exception mode

4 years agoMerge pull request #18799 from deb1990/CPS-332-support-new-button-markup
Eileen McNaughton [Thu, 22 Oct 2020 23:13:44 +0000 (12:13 +1300)]
Merge pull request #18799 from deb1990/CPS-332-support-new-button-markup

CPS-332: Button markup fix in PremiumBlock.tpl

4 years agoMerge pull request #18821 from eileenmcnaughton/531im
Seamus Lee [Thu, 22 Oct 2020 06:11:22 +0000 (17:11 +1100)]
Merge pull request #18821 from eileenmcnaughton/531im

dev/membership#30 switch Membership import to use the v3 api

4 years agoMerge pull request #18834 from demeritcowboy/file-add
Seamus Lee [Thu, 22 Oct 2020 01:33:59 +0000 (12:33 +1100)]
Merge pull request #18834 from demeritcowboy/file-add

Fix deprecated passing of string attributes to CRM_Core_Form::add for contact import

4 years agoMerge pull request #18831 from seamuslee001/dev_core_2136
Seamus Lee [Thu, 22 Oct 2020 00:26:08 +0000 (11:26 +1100)]
Merge pull request #18831 from seamuslee001/dev_core_2136

dev/core#2136 Fix the loading of groups on the contact Individual screen

4 years agoMerge pull request #18820 from eileenmcnaughton/531
Seamus Lee [Thu, 22 Oct 2020 00:25:42 +0000 (11:25 +1100)]
Merge pull request #18820 from eileenmcnaughton/531

More buttonrama fallout

4 years agodeprecated string
demeritcowboy [Wed, 21 Oct 2020 22:23:53 +0000 (18:23 -0400)]
deprecated string

4 years agoFix the loading of groups on the contact Individual screen
Seamus Lee [Wed, 21 Oct 2020 20:38:17 +0000 (07:38 +1100)]
Fix the loading of groups on the contact Individual screen

4 years agoMore buttonrama fallout
eileen [Wed, 21 Oct 2020 05:28:00 +0000 (18:28 +1300)]
More buttonrama fallout

4 years agodev/membership#30 switch Membership import to use the v3 api
eileen [Wed, 21 Oct 2020 05:43:15 +0000 (18:43 +1300)]
dev/membership#30 switch Membership import to use the v3 api

ITturns out the addition of a unique name at some point caused is_override not to be passed in
inn a way the BAO recognises - the api has handling for this...

4 years agoMerge pull request #18817 from seamuslee001/5-30-1-notes
Seamus Lee [Wed, 21 Oct 2020 04:59:55 +0000 (15:59 +1100)]
Merge pull request #18817 from seamuslee001/5-30-1-notes

release-notes/5.30.1.md

4 years agorelease-notes/5.30.1.md
Tim Otten [Wed, 21 Oct 2020 04:04:24 +0000 (21:04 -0700)]
release-notes/5.30.1.md

4 years agoCPS-332: Button markup fix in PremiumBlock.tpl
Debarshi Bhaumik [Tue, 6 Oct 2020 07:34:02 +0000 (08:34 +0100)]
CPS-332: Button markup fix in PremiumBlock.tpl

4 years agoMerge pull request #18800 from agh1/5.31.0-releasenotes-initial
Seamus Lee [Mon, 19 Oct 2020 21:06:57 +0000 (08:06 +1100)]
Merge pull request #18800 from agh1/5.31.0-releasenotes-initial

5.31.0 release notes initial run

4 years ago5.31.0 release notes: added boilerplate
Andrew Hunt [Mon, 19 Oct 2020 15:22:06 +0000 (11:22 -0400)]
5.31.0 release notes: added boilerplate

4 years ago5.31.0 release notes: raw from script
Andrew Hunt [Mon, 19 Oct 2020 15:18:21 +0000 (11:18 -0400)]
5.31.0 release notes: raw from script

4 years agoMerge pull request #18766 from eileenmcnaughton/basic
Tim Otten [Sat, 17 Oct 2020 01:00:12 +0000 (18:00 -0700)]
Merge pull request #18766 from eileenmcnaughton/basic

Fix unreleased regression on search tasks from basic search

4 years agoMerge pull request #18776 from seamuslee001/dev_core_2125
Eileen McNaughton [Thu, 15 Oct 2020 04:46:42 +0000 (17:46 +1300)]
Merge pull request #18776 from seamuslee001/dev_core_2125

dev/core#2125 Ensure that the id that is used in the field is the gro…

4 years agodev/core#2125 Ensure that the id that is used in the field is the group id not the...
Seamus Lee [Thu, 15 Oct 2020 00:37:47 +0000 (11:37 +1100)]
dev/core#2125 Ensure that the id that is used in the field is the group id not the id of array key as that has changed from being a keyed array to a 2D array

4 years agoMerge pull request #18765 from totten/5.31-res-alias
Eileen McNaughton [Wed, 14 Oct 2020 22:40:28 +0000 (11:40 +1300)]
Merge pull request #18765 from totten/5.31-res-alias

dev/core#2117 - Add compatibility aliases for 'scriptFile' and 'styleFile' resources

4 years agoMerge pull request #18763 from eileenmcnaughton/531
Seamus Lee [Wed, 14 Oct 2020 09:06:50 +0000 (20:06 +1100)]
Merge pull request #18763 from eileenmcnaughton/531

dev/core#2119 Fix mailing code to exclude deleted recipients

4 years agoFix unreleased regression on search tasks from basic search
eileen [Wed, 14 Oct 2020 03:41:19 +0000 (16:41 +1300)]
Fix unreleased regression on search tasks from basic search

4 years agoMerge pull request #18758 from mlutfy/event43rc
Seamus Lee [Wed, 14 Oct 2020 01:58:44 +0000 (12:58 +1100)]
Merge pull request #18758 from mlutfy/event43rc

dev/event#43 Contact Dashboard: fix Event Participations

4 years agodev/core#2119 Fix mailig code to exclude deleted recipients
eileen [Wed, 14 Oct 2020 01:51:04 +0000 (14:51 +1300)]
dev/core#2119 Fix mailig code to exclude deleted recipients

4 years agodev/core#2117 - scriptFile, styleFile - Automatically register URL aliases
Tim Otten [Wed, 14 Oct 2020 00:29:29 +0000 (17:29 -0700)]
dev/core#2117 - scriptFile, styleFile - Automatically register URL aliases

This allows backward compatibility for customizations which targetted these
resources by their URL.

4 years agodev/core#2117 - Resources - Allow each snippet to have `aliases`
Tim Otten [Wed, 14 Oct 2020 01:24:47 +0000 (18:24 -0700)]
dev/core#2117 - Resources - Allow each snippet to have `aliases`

__Before__: Every snippet/resource has a singular name. If the name ever changes,
it becomes a backward-compatibility break.

__After__: Every snippet/resource has a singular name, and it may optionally
have a list of aliases.  If the name ever changes, you can leave an alias
for backward-compatibility.

4 years agodev/event#43 Contact Dashboard: fix Event Participations
Mathieu Lutfy [Tue, 13 Oct 2020 19:51:58 +0000 (15:51 -0400)]
dev/event#43 Contact Dashboard: fix Event Participations

4 years agoMerge pull request #18753 from agh1/placeholderfix-5.31
Seamus Lee [Tue, 13 Oct 2020 20:08:28 +0000 (07:08 +1100)]
Merge pull request #18753 from agh1/placeholderfix-5.31

dev/core#2118 supply better automatic placeholders for select (5.31 intra-rc)

4 years agoMerge pull request #18751 from demeritcowboy/utf8convert-triggers
Eileen McNaughton [Tue, 13 Oct 2020 20:03:35 +0000 (09:03 +1300)]
Merge pull request #18751 from demeritcowboy/utf8convert-triggers

Rebuild triggers after utf8mb4 conversion

4 years agodev/core#2118 supply better automatic placeholders for select
Andrew Hunt [Tue, 13 Oct 2020 16:15:38 +0000 (12:15 -0400)]
dev/core#2118 supply better automatic placeholders for select

4 years agorebuild triggers after utf8mb4 conversion
demeritcowboy [Tue, 13 Oct 2020 15:14:39 +0000 (11:14 -0400)]
rebuild triggers after utf8mb4 conversion

4 years agoMerge pull request #18721 from artfulrobot/artfulrobot-relcache-utf8
colemanw [Tue, 13 Oct 2020 15:14:15 +0000 (11:14 -0400)]
Merge pull request #18721 from artfulrobot/artfulrobot-relcache-utf8

Remove explicit COLLATE utf8_bin from RelationshipCache trigger

4 years agoReplace hard-coded utf8_bin with binary in-use collation
Rich Lott / Artful Robot [Tue, 13 Oct 2020 09:39:35 +0000 (10:39 +0100)]
Replace hard-coded utf8_bin with binary in-use collation

4 years agoMerge pull request #18717 from eileenmcnaughton/static2
colemanw [Sat, 10 Oct 2020 15:39:01 +0000 (11:39 -0400)]
Merge pull request #18717 from eileenmcnaughton/static2

dev/core#2108 fix deprecation notice take 2

4 years agoMerge pull request #18713 from eileenmcnaughton/531
colemanw [Sat, 10 Oct 2020 15:33:42 +0000 (11:33 -0400)]
Merge pull request #18713 from eileenmcnaughton/531

dev/core#2102 Fix hang on event edit

4 years agoMerge pull request #18723 from colemanw/crmSearchCleanup
Seamus Lee [Fri, 9 Oct 2020 23:22:35 +0000 (10:22 +1100)]
Merge pull request #18723 from colemanw/crmSearchCleanup

Search ext: misc cleanup & fixes

4 years agoSearch ext: Ensure all entities have titlePlural to fix sort/display
Coleman Watts [Fri, 9 Oct 2020 21:12:57 +0000 (17:12 -0400)]
Search ext: Ensure all entities have titlePlural to fix sort/display

4 years agoMerge pull request #18719 from JMAConsulting/core_2105
Eileen McNaughton [Fri, 9 Oct 2020 20:56:04 +0000 (09:56 +1300)]
Merge pull request #18719 from JMAConsulting/core_2105

core#2105: Groups children now get shown with SPAN CSS error

4 years agoMerge pull request #18716 from eileenmcnaughton/static
colemanw [Fri, 9 Oct 2020 20:55:54 +0000 (16:55 -0400)]
Merge pull request #18716 from eileenmcnaughton/static

dev/core#2108 fix deprecation notice

4 years agoSearch ext: misc cleanup & fixes
Coleman Watts [Fri, 9 Oct 2020 20:44:06 +0000 (16:44 -0400)]
Search ext: misc cleanup & fixes

- Fixes white on white button text by adding btn-default class
- Fixes missing field names in the bulk-update action
- Decouples searchActions from the main search controller
- Misc cleanup

4 years agocore#2105: Groups children now get shown with SPAN CSS error
Monish Deb [Fri, 9 Oct 2020 04:23:04 +0000 (09:53 +0530)]
core#2105: Groups children now get shown with SPAN CSS error

4 years agodev/core#2108 fix deprecation notice take 2
eileen [Fri, 9 Oct 2020 03:43:34 +0000 (16:43 +1300)]
dev/core#2108 fix deprecation notice take 2

Loosens the deprecation notice - alternative to https://github.com/civicrm/civicrm-core/pull/18716 but
we should merge both IMHO

4 years agodev/core#2108 fix deprecation notice
eileen [Fri, 9 Oct 2020 03:36:39 +0000 (16:36 +1300)]
dev/core#2108 fix deprecation notice

This addresses the deprecation warning by moving the text to the tpl layer - we could ease up
on the deprecation for type = 'static' but the pattern didn't seem to make much sense or to be
consistent with how we normally do things

4 years agodev/core#2102 Fix hang on event edit
eileen [Thu, 8 Oct 2020 20:57:45 +0000 (09:57 +1300)]
dev/core#2102 Fix hang on event edit

Per https://lab.civicrm.org/dev/core/-/issues/2102

4 years agoSet version to 5.31.beta1
CiviCRM [Thu, 8 Oct 2020 09:44:07 +0000 (09:44 +0000)]
Set version to 5.31.beta1

4 years agoMerge pull request #18710 from eileenmcnaughton/locev2
Tim Otten [Thu, 8 Oct 2020 08:42:39 +0000 (01:42 -0700)]
Merge pull request #18710 from eileenmcnaughton/locev2

dev/core#2096 Fix in-master-only regression on creating new events

4 years agoMerge pull request #18708 from eileenmcnaughton/locev
Seamus Lee [Thu, 8 Oct 2020 05:18:29 +0000 (16:18 +1100)]
Merge pull request #18708 from eileenmcnaughton/locev

Add unit test that ultimately failed to hit the desired code but does add cover

4 years agoMerge pull request #18711 from seamuslee001/move_to_alpha1_stage
Seamus Lee [Thu, 8 Oct 2020 05:17:23 +0000 (16:17 +1100)]
Merge pull request #18711 from seamuslee001/move_to_alpha1_stage

Move to alpha1 stage

4 years ago[REF] Move recently added upgrade steps from 5.31.0 to 5.31.alpha1 step
Seamus Lee [Thu, 8 Oct 2020 02:20:23 +0000 (13:20 +1100)]
[REF] Move recently added upgrade steps from 5.31.0 to 5.31.alpha1 step

4 years agodev/core#2096 Fix in-master-only regression on creating new events
eileen [Thu, 8 Oct 2020 02:19:08 +0000 (15:19 +1300)]
dev/core#2096 Fix in-master-only regression on creating new events

4 years ago[NFC] Regen after #18624
Seamus Lee [Thu, 8 Oct 2020 01:49:36 +0000 (12:49 +1100)]
[NFC] Regen after #18624

4 years agoAdd unit test that ultimately failed to hit the desired code but does add cover
eileen [Thu, 8 Oct 2020 01:48:23 +0000 (14:48 +1300)]
Add unit test that ultimately failed to hit the desired code but does add cover

4 years agoMerge pull request #18624 from compucorp/CATL-1613-skip-non-case-email
Seamus Lee [Thu, 8 Oct 2020 01:47:45 +0000 (12:47 +1100)]
Merge pull request #18624 from compucorp/CATL-1613-skip-non-case-email

Add options to Mail Account settings to improve inbound mail processing

4 years agoMerge pull request #18360 from colemanw/fixMultiInProfile
Eileen McNaughton [Thu, 8 Oct 2020 01:33:38 +0000 (14:33 +1300)]
Merge pull request #18360 from colemanw/fixMultiInProfile

Fix way of identityfing custom serialized fields

4 years agoMerge pull request #18324 from mattwire/payproc_configoptional
Seamus Lee [Thu, 8 Oct 2020 01:02:44 +0000 (12:02 +1100)]
Merge pull request #18324 from mattwire/payproc_configoptional

Display url_site and url_recur based on if the form elements exist

4 years agoMerge pull request #18701 from eileenmcnaughton/leak7
Seamus Lee [Thu, 8 Oct 2020 01:00:41 +0000 (12:00 +1100)]
Merge pull request #18701 from eileenmcnaughton/leak7

dev/core#2073 Fix use of legacy leaky method in tested code

4 years agoMerge pull request #18707 from eileenmcnaughton/notice
Eileen McNaughton [Thu, 8 Oct 2020 00:58:59 +0000 (13:58 +1300)]
Merge pull request #18707 from eileenmcnaughton/notice

Enotice fix

4 years agoMerge pull request #18702 from eileenmcnaughton/leak8
Seamus Lee [Thu, 8 Oct 2020 00:27:51 +0000 (11:27 +1100)]
Merge pull request #18702 from eileenmcnaughton/leak8

dev/core#2073 Fix use of legacy leaky method in tested code

4 years agoMerge pull request #18704 from mlutfy/partListingOutput
Seamus Lee [Thu, 8 Oct 2020 00:23:25 +0000 (11:23 +1100)]
Merge pull request #18704 from mlutfy/partListingOutput

ParticipantListing Report: only display the View link for web, unhardcode others

4 years agoMerge pull request #18699 from eileenmcnaughton/leak5
Eileen McNaughton [Wed, 7 Oct 2020 23:46:52 +0000 (12:46 +1300)]
Merge pull request #18699 from eileenmcnaughton/leak5

dev/core#2073 Fix use of legacy leaky method in tested code

4 years agoMerge pull request #18493 from mlutfy/campaignReportDefaults
Eileen McNaughton [Wed, 7 Oct 2020 23:46:06 +0000 (12:46 +1300)]
Merge pull request #18493 from mlutfy/campaignReportDefaults

Fix default report permissions when creating reports from CiviCampaign

4 years agoEnotice fix
eileen [Wed, 7 Oct 2020 23:44:20 +0000 (12:44 +1300)]
Enotice fix

4 years agoMerge pull request #18706 from civicrm/5.30
Eileen McNaughton [Wed, 7 Oct 2020 23:11:03 +0000 (12:11 +1300)]
Merge pull request #18706 from civicrm/5.30

5.30

4 years agoMerge pull request #18680 from eileenmcnaughton/x
Eileen McNaughton [Wed, 7 Oct 2020 23:10:47 +0000 (12:10 +1300)]
Merge pull request #18680 from eileenmcnaughton/x

dev/financial#151 Paypal express validation fix on event

4 years agoMerge pull request #18705 from agh1/5.30.0-releasenotes-final
Seamus Lee [Wed, 7 Oct 2020 23:06:32 +0000 (10:06 +1100)]
Merge pull request #18705 from agh1/5.30.0-releasenotes-final

5.30.0 release notes: updated with late changes

4 years agoMerge pull request #18700 from eileenmcnaughton/leak6
Seamus Lee [Wed, 7 Oct 2020 22:34:16 +0000 (09:34 +1100)]
Merge pull request #18700 from eileenmcnaughton/leak6

dev/core#2073 Fix use of legacy leaky method in tested code

4 years agoMerge pull request #18698 from seamuslee001/test_dev_core_2053
Seamus Lee [Wed, 7 Oct 2020 22:21:32 +0000 (09:21 +1100)]
Merge pull request #18698 from seamuslee001/test_dev_core_2053

[NFC] dev/core#2053 Extend nextedGroup test to show that it will retu…

4 years ago5.30.0 release notes: updated with late changes
Andrew Hunt [Wed, 7 Oct 2020 22:10:04 +0000 (18:10 -0400)]
5.30.0 release notes: updated with late changes

4 years agodev/core#2073 Fix use of legacy leaky method in tested code
eileen [Wed, 7 Oct 2020 20:14:44 +0000 (09:14 +1300)]
dev/core#2073 Fix use of legacy leaky method in tested code

This is too low volume to really leak but it uses the leaky legacy method and
has test cover in

CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set basic_data
CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set save_mapping

4 years agoParticipantListing Report: only display the View link for web, unhardcode others
Mathieu Lutfy [Wed, 7 Oct 2020 21:33:09 +0000 (17:33 -0400)]
ParticipantListing Report: only display the View link for web, unhardcode others

4 years agoMerge pull request #18654 from eileenmcnaughton/token1
colemanw [Wed, 7 Oct 2020 21:26:56 +0000 (17:26 -0400)]
Merge pull request #18654 from eileenmcnaughton/token1

dev/core#2079  [REF] Fix some more calls to getTokens to make it clear only the first return value is used

4 years agoMerge pull request #18653 from eileenmcnaughton/token
colemanw [Wed, 7 Oct 2020 21:26:04 +0000 (17:26 -0400)]
Merge pull request #18653 from eileenmcnaughton/token

dev/core#2079 [Ref] Clarify calls to CRM_Utils_Token::getTokenDetails

4 years agodev/financial#151 Paypal express validation fix on event
eileen [Tue, 6 Oct 2020 21:35:31 +0000 (10:35 +1300)]
dev/financial#151 Paypal express validation fix on event

extension of https://github.com/civicrm/civicrm-core/pull/18459

4 years agodev/core#2073 Fix use of legacy leaky method in tested code
eileen [Wed, 7 Oct 2020 20:48:00 +0000 (09:48 +1300)]
dev/core#2073 Fix use of legacy leaky method in tested code

Overview
----------------------------------------
Fix use of legacy leaky method in tested code

Before
----------------------------------------

After
----------------------------------------

Technical Details
----------------------------------------
Has test cover in
CRM_Member_Form_MembershipTest.testSubmitUpdateMembershipFromPartiallyPaid
CRM_Member_Form_MembershipTest.testMembershipViewContributionOwnerDifferent

Comments
----------------------------------------

4 years agodev/core#2073 Fix use of legacy leaky method in tested code
eileen [Wed, 7 Oct 2020 20:37:26 +0000 (09:37 +1300)]
dev/core#2073 Fix use of legacy leaky method in tested code

Overview
----------------------------------------
Fix use of legacy leaky method in tested code

Before
----------------------------------------
dao->query()

After
----------------------------------------
CRM_Core_DAO::executeQuery()

Technical Details
----------------------------------------
This is too low volume to really leak but it uses the leaky legacy method and
has test cover in

CRM_Import_DataSource_CsvTest.testToCsv with data set #0
CRM_Import_DataSource_CsvTest.testToCsv with data set #1
----------------------------------------

4 years agodev/core#2073 Fix use of legacy leaky method in tested code
eileen [Wed, 7 Oct 2020 20:22:22 +0000 (09:22 +1300)]
dev/core#2073 Fix use of legacy leaky method in tested code

Overview
----------------------------------------
Fix use of legacy leaky method in tested code

Before
----------------------------------------
dao->query()

After
----------------------------------------
CRM_Core_DAO::executeQuery()

Technical Details
----------------------------------------
This is too low volume to really leak but it uses the leaky legacy method and
has test cover in

CRM_Contact_Page_View_UserDashboard_GroupContactTest.testBrowseDisplaysCorrectListOfAddedGroups
CRM_Contact_Page_View_UserDashboard_GroupContactTest.testBrowseDisplaysCorrectListOfAVailableGroups
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentEmptyContact
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributionsWithInvoicingEnabled
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributions

----------------------------------------

4 years ago[NFC] dev/core#2053 Extend nextedGroup test to show that it will return child groups...
Seamus Lee [Wed, 7 Oct 2020 19:58:03 +0000 (06:58 +1100)]
[NFC] dev/core#2053 Extend nextedGroup test to show that it will return child groups that are Mailing groups even when the parent isn't a mailing group

4 years agoMerge pull request #18667 from eileenmcnaughton/uf
colemanw [Wed, 7 Oct 2020 19:15:53 +0000 (15:15 -0400)]
Merge pull request #18667 from eileenmcnaughton/uf

dev/core#2087 Remove extraneous  CRM_Core_BAO_UFMatch::updateUFName call

4 years agoMerge pull request #18696 from colemanw/btnNoConflict
Eileen McNaughton [Wed, 7 Oct 2020 19:15:15 +0000 (08:15 +1300)]
Merge pull request #18696 from colemanw/btnNoConflict

Greenwich - fix conflict btw bootstrap & jQuery UI button

4 years agoMerge pull request #18556 from eileenmcnaughton/pcp
colemanw [Wed, 7 Oct 2020 19:09:21 +0000 (15:09 -0400)]
Merge pull request #18556 from eileenmcnaughton/pcp

dev/core#2056 Only retrieve pcp & soft_credit info when needed

4 years agoMerge pull request #18695 from colemanw/ids
Eileen McNaughton [Wed, 7 Oct 2020 18:59:18 +0000 (07:59 +1300)]
Merge pull request #18695 from colemanw/ids

Exclude api4 from IDS check

4 years agoMerge pull request #18500 from eileenmcnaughton/loc
colemanw [Wed, 7 Oct 2020 16:23:42 +0000 (12:23 -0400)]
Merge pull request #18500 from eileenmcnaughton/loc

dev/core#2047 [Ref] Remove obsolete check

4 years agoMerge pull request #18650 from eileenmcnaughton/perms
colemanw [Wed, 7 Oct 2020 16:19:42 +0000 (12:19 -0400)]
Merge pull request #18650 from eileenmcnaughton/perms

Fix complexity on cache key

4 years agoMerge pull request #18663 from eileenmcnaughton/blockdel3
colemanw [Wed, 7 Oct 2020 13:47:34 +0000 (09:47 -0400)]
Merge pull request #18663 from eileenmcnaughton/blockdel3

dev/core#2039 Remove extraneous location queries from contact.create->Location::block path

4 years agoMerge pull request #18662 from eileenmcnaughton/blockdel2
colemanw [Wed, 7 Oct 2020 13:45:14 +0000 (09:45 -0400)]
Merge pull request #18662 from eileenmcnaughton/blockdel2

dev/core#2017 Deprecate an unused function