Seamus Lee [Thu, 3 Jan 2019 15:05:04 +0000 (02:05 +1100)]
Merge pull request #13279 from aydun/list_tokens
(NFC) Add listTokens() function to return formatted list of tokens for forms
Seamus Lee [Thu, 3 Jan 2019 15:04:30 +0000 (02:04 +1100)]
Merge pull request #13278 from aydun/abstract_token_class_prop
(REF) Make activeTokens a class property of \Civi\Token\AbstractTokenSubscriber
CiviCRM [Thu, 3 Jan 2019 03:28:13 +0000 (03:28 +0000)]
Set version to 5.11.alpha1
CiviCRM [Thu, 3 Jan 2019 03:23:31 +0000 (03:23 +0000)]
Set version to 5.10.beta1
Seamus Lee [Thu, 3 Jan 2019 02:24:38 +0000 (13:24 +1100)]
Merge pull request #13389 from civicrm/5.9
5.9
Seamus Lee [Thu, 3 Jan 2019 02:24:22 +0000 (13:24 +1100)]
Merge pull request #13388 from totten/5.9-msg-tweak
Five Nine - Revise upgrade notice about Money/Int/Float fields
Tim Otten [Thu, 3 Jan 2019 00:36:39 +0000 (16:36 -0800)]
FineNine - Revise upgrade notice to be less alarming
Based on discussion at https://github.com/civicrm/civicrm-core/pull/13384/files#r244890998
Tim Otten [Thu, 3 Jan 2019 00:24:08 +0000 (16:24 -0800)]
(NFC) FiveNine.php - Whitespace
Eileen McNaughton [Thu, 3 Jan 2019 00:13:34 +0000 (13:13 +1300)]
Merge pull request #13386 from civicrm/5.9
5.9
Eileen McNaughton [Thu, 3 Jan 2019 00:12:58 +0000 (13:12 +1300)]
Merge pull request #13387 from seamuslee001/release_notes_update
Update 5.9 Release notes for final fixes
Seamus Lee [Thu, 3 Jan 2019 00:10:29 +0000 (11:10 +1100)]
Merge pull request #13385 from eileenmcnaughton/5.9
dev/core#619 fix regression on Address contact-reference fields not rendering results
Seamus Lee [Wed, 2 Jan 2019 23:27:03 +0000 (10:27 +1100)]
Update 5.9 Release notes for final fixes
Seamus Lee [Wed, 2 Jan 2019 23:19:32 +0000 (10:19 +1100)]
Merge pull request #13384 from seamuslee001/dev_core_337
dev/core#337 Add in upgrade script to set search by range to be false…
Seamus Lee [Wed, 2 Jan 2019 22:49:58 +0000 (09:49 +1100)]
Merge pull request #13189 from JMAConsulting/core-564
dev-core#564: Differentiate case relationships in Contact Summary page
eileen [Wed, 2 Jan 2019 22:05:20 +0000 (11:05 +1300)]
dev/core#619 fix regression on Address contact-reference fields not rendering results.
Fixing results not rendering on onbehalf profiles broke addresses - this
limits the handling added for onbehalf to only apply to onbehalf.
Eileen McNaughton [Wed, 2 Jan 2019 21:34:41 +0000 (10:34 +1300)]
Merge pull request #13314 from colemanw/dev/core#337
dev/core#337 - Fix search range for select/radio custom fields
Seamus Lee [Wed, 2 Jan 2019 21:30:00 +0000 (08:30 +1100)]
dev/core#337 Add in upgrade script to set search by range to be false for Fields of money, float, int with widget types radio and select which were how they were effectively implementeted originally
Eileen McNaughton [Wed, 2 Jan 2019 20:19:09 +0000 (09:19 +1300)]
Merge pull request #13381 from civicrm/5.9
5.9.0 release notes (#13244) to master
Andrew Hunt [Wed, 2 Jan 2019 20:18:04 +0000 (15:18 -0500)]
5.9.0 release notes (#13244)
Eileen McNaughton [Wed, 2 Jan 2019 20:08:50 +0000 (09:08 +1300)]
Merge pull request #13380 from yashodha/campaign_report_clean
(dev/core#491) campaign cleanup for member summary report and show di…
Eileen McNaughton [Wed, 2 Jan 2019 19:47:10 +0000 (08:47 +1300)]
Merge pull request #13338 from eileenmcnaughton/export
Export merge to household - fix DB error relating to fields too long for table.
yashodha [Wed, 2 Jan 2019 11:39:36 +0000 (17:09 +0530)]
(dev/core#491) campaign cleanup for member summary report and show disabled campaigns as well.
Seamus Lee [Wed, 2 Jan 2019 07:17:00 +0000 (18:17 +1100)]
Merge pull request #13358 from yashodha/campaign_reports
(dev/core#491) campaign cleanup for 'pledged but not paid' report and…
Seamus Lee [Wed, 2 Jan 2019 05:39:13 +0000 (16:39 +1100)]
Merge pull request #13379 from yashodha/campaign_report_clean
(dev/core#491) campaign cleanup for member detail report and show dis…
Monish Deb [Fri, 30 Nov 2018 12:16:49 +0000 (17:46 +0530)]
dev-core#564: Differentiate case relationships in Contact Summary page
yashodha [Wed, 2 Jan 2019 04:08:17 +0000 (09:38 +0530)]
(dev/core#491) campaign cleanup for member detail report and show disabled campaigns as well.
Seamus Lee [Wed, 2 Jan 2019 02:11:00 +0000 (13:11 +1100)]
Merge pull request #13378 from eileenmcnaughton/activity_notice
Fix notice on first loading activity search form
eileen [Wed, 2 Jan 2019 00:44:02 +0000 (13:44 +1300)]
Fix notice on first loading activity search form
Seamus Lee [Tue, 1 Jan 2019 23:01:46 +0000 (10:01 +1100)]
Merge pull request #13372 from eileenmcnaughton/activity_extract
Simplify handling for case checking.
Seamus Lee [Tue, 1 Jan 2019 21:09:31 +0000 (08:09 +1100)]
Merge pull request #13376 from yashodha/campaign_report_clean
(dev/core#491) campaign cleanup for participant listing report and sh…
Seamus Lee [Tue, 1 Jan 2019 20:27:30 +0000 (07:27 +1100)]
Merge pull request #13375 from yashodha/dev_622
(dev/core#622) User Dashboard doesn't show Edit Contact Information link
yashodha [Tue, 1 Jan 2019 16:25:28 +0000 (21:55 +0530)]
(dev/core#491) campaign cleanup for participant listing report and show disabled campaigns as well.
yashodha [Tue, 1 Jan 2019 13:08:10 +0000 (18:38 +0530)]
(dev/core#622) User Dashboard doesn't show Edit Contact Information link
Seamus Lee [Tue, 1 Jan 2019 06:26:47 +0000 (17:26 +1100)]
Merge pull request #13344 from seamuslee001/unit_test_13343
Add in unit test to support changes in UF API in PR 13343
Seamus Lee [Tue, 1 Jan 2019 01:09:05 +0000 (12:09 +1100)]
Merge pull request #13343 from GinkgoFJG/case-issues-w-ufgroup-api
Improved support for case variability in UF* API calls.
eileen [Fri, 21 Dec 2018 03:35:57 +0000 (16:35 +1300)]
Export merge to household - fix DB error relating to fields too long for table.
The key fix here is that the fields for merging to household are no longer added to the temporary table.
They are fully loaded in php anyway so there is no performance gain using a temp table.
Instead we iterate them in php as we process each row
yashodha [Mon, 31 Dec 2018 05:23:24 +0000 (10:53 +0530)]
remove unneccessary code
Seamus Lee [Mon, 31 Dec 2018 03:39:57 +0000 (14:39 +1100)]
Merge pull request #13370 from eileenmcnaughton/payment
[REF] extract internals of Payment.create into function on BAO class.
eileen [Wed, 24 Oct 2018 02:36:51 +0000 (15:36 +1300)]
Simplify handling for case checking.
We already check if the contact has generic case permissions in the component checking section.
We can remove that check from the case check & also early return from there since a NO
at that point can't be overriden
eileen [Sun, 30 Dec 2018 21:45:47 +0000 (10:45 +1300)]
[REF] extract internals of Payment.create into function on BAO class.
This is a partial of https://github.com/civicrm/civicrm-core/pull/13330 - trying
to separate out the main code move from the changes. My only change was to change the name to
addPayment since that is what we are doing but here are some additionaly thoughts.
1) I'm inclined to put the class onto a new pseudo-bao CRM_Finanial_BAO_Payment. We already have this
pseudo-entity on the api level & it gives us a way to build up a place for the functions we are migrating
towards.
2) I think we should consider changing the input parameters to this function to be
- contributionID, total_amount & line_items or in some way limiting the parameters tha
t get passed through. We have historically gotten ourselves in trouble by
having people hacking in another parameter to go through whereas the strength of the api
is clear inputs & outputs. I note the api will need to support
'is_email_receipt' as will this fn & the CRM_Contribute_Form_AdditionalPayment::emailReceipt
should be moved off the form layer - possibly to our new BAO
3) I think the exceptions need to be CRM_Core_Exceptions if thrown in the BAO although this is kinda cosmetic
Change-Id: Ib5caf0d878e9c5cc735cb1a20c640f61da2dbfc6
Seamus Lee [Mon, 31 Dec 2018 00:15:58 +0000 (11:15 +1100)]
Merge pull request #13371 from eileenmcnaughton/activity_extract
[REF] simplify CRM_Activity_BAO_Activity function by using early returns
eileen [Sun, 30 Dec 2018 22:33:12 +0000 (11:33 +1300)]
[REF] simplify CRM_Activity_BAO_Activity function by using early returns.
This function returns a bool. In the process it sets the variable, however, once set to false in two places
it can never be set to true, so I am simply replacing a big if block with an early return to simplify the code.
This is a further block that can go but it is a slightly different patter & would remove 2 levels of 'if'
so it feels like an easier review if I leave that out of scope
Seamus Lee [Sat, 29 Dec 2018 22:34:23 +0000 (09:34 +1100)]
Merge pull request #13367 from mattwire/nfc_commentscustomfield
NFC tidy up comments, remove unused variables in customfield classes
Seamus Lee [Sat, 29 Dec 2018 22:33:56 +0000 (09:33 +1100)]
Merge pull request #13368 from mattwire/case_cachecount
Cache case count when getting list of cases so query is executed once instead of three times
Seamus Lee [Sat, 29 Dec 2018 21:16:46 +0000 (08:16 +1100)]
Merge pull request #13359 from chamilwijesooriya/issue-625
(dev/core#625) DB error on Case Summary report
Seamus Lee [Sat, 29 Dec 2018 20:32:03 +0000 (07:32 +1100)]
Merge pull request #13328 from eileenmcnaughton/phone_handle
[REF] genericise function to add pseudoconstant data to fields to process
Seamus Lee [Sat, 29 Dec 2018 20:29:05 +0000 (07:29 +1100)]
Merge pull request #13360 from ray-wright/patch-2
Revert to showing overdue activities on a case first
Matthew Wire (MJW Consulting) [Sat, 29 Dec 2018 12:15:17 +0000 (12:15 +0000)]
Cache case count when getting list of cases so query is executed once instead of three times
Matthew Wire (MJW Consulting) [Sat, 29 Dec 2018 11:13:57 +0000 (11:13 +0000)]
NFC tidy up comments, remove unused variables in customfield classes
Seamus Lee [Sat, 29 Dec 2018 04:44:15 +0000 (15:44 +1100)]
Merge pull request #13366 from seamuslee001/refinement_623
dev/core#623 Refine the upgrade statement to only those of the old st…
Seamus Lee [Sat, 29 Dec 2018 03:16:08 +0000 (14:16 +1100)]
dev/core#623 Refine the upgrade statement to only those of the old standard value
Chamil Wijesooriya [Thu, 27 Dec 2018 12:23:17 +0000 (12:23 +0000)]
GitLab issue 625 DB error on Case Summary report
Seamus Lee [Fri, 28 Dec 2018 10:21:01 +0000 (21:21 +1100)]
Merge pull request #13299 from colemanw/activityDate
Activity date fields -> datepicker
Seamus Lee [Fri, 28 Dec 2018 09:27:53 +0000 (20:27 +1100)]
Merge pull request #13336 from mattwire/missingcaseaddaction
Don't crash with missing class if action is not defined when opening new case
Seamus Lee [Fri, 28 Dec 2018 08:51:37 +0000 (19:51 +1100)]
Merge pull request #13363 from civicrm/5.9
5.9
Seamus Lee [Fri, 28 Dec 2018 08:27:19 +0000 (19:27 +1100)]
Merge pull request #13361 from seamuslee001/lab_core_594
(dev/core#594) Fix key-value mappings for WYSIWYG setting (editor_id). Accept keyColumn option.
Eileen McNaughton [Fri, 28 Dec 2018 08:19:57 +0000 (21:19 +1300)]
Merge pull request #13362 from seamuslee001/lab_core_623
dev/core#623 add in upgrade step to update Away type hold threshold t…
Tim Otten [Fri, 28 Dec 2018 06:59:41 +0000 (22:59 -0800)]
FiveNine.php - Copy-edit post-upgrade message
Seamus Lee [Thu, 27 Dec 2018 21:37:52 +0000 (08:37 +1100)]
dev/core#594 Fix issue where editor_id is expected to be keyed on name not on value
Add in a post upgrade message encourging people to check their editor setting
Seamus Lee [Fri, 28 Dec 2018 02:46:23 +0000 (13:46 +1100)]
dev/core#623 add in upgrade step to update Away type hold threshold to be 30 as agreed to in CRM-6405 version 3.2. It appears there may have been no upgrade made at the type so catching up now
Seamus Lee [Thu, 27 Dec 2018 21:08:55 +0000 (08:08 +1100)]
Merge pull request #13215 from mattwire/recur_invoice_selfservice_links
Display self-service links in email receipts based on payment processor capabilities
Coleman Watts [Mon, 17 Dec 2018 18:36:46 +0000 (13:36 -0500)]
dev/core#561 - case_start_date field -> datepicker
Coleman Watts [Thu, 6 Dec 2018 18:50:39 +0000 (13:50 -0500)]
activity_duration field -> number
Coleman Watts [Thu, 6 Dec 2018 18:48:39 +0000 (13:48 -0500)]
dev/core#561 - activity_date_time field -> datepicker
ray-wright [Thu, 27 Dec 2018 18:56:52 +0000 (13:56 -0500)]
To revert to showing overdue activities first
Based on this issue, I'd like to remove the data-order, as the BAO Case file already sorts.
https://lab.civicrm.org/dev/core/issues/626
Matthew Wire (MJW Consulting) [Thu, 27 Dec 2018 18:54:59 +0000 (18:54 +0000)]
Don't crash with missing class if action is not defined when opening new case
Matthew Wire (MJW Consulting) [Mon, 3 Dec 2018 15:35:31 +0000 (15:35 +0000)]
Display self-service links in email receipts based on payment processor capabilities
Yashodha Chaku [Thu, 27 Dec 2018 11:06:30 +0000 (16:36 +0530)]
Merge pull request #13350 from francescbassas/patch-16
#620 - Unable to show custom fields on Repeat Contributions Report
yashodha [Thu, 27 Dec 2018 09:12:16 +0000 (14:42 +0530)]
(dev/core#491) campaign cleanup for 'pledged but not paid' report and show disabled campaigns as well
Yashodha Chaku [Thu, 27 Dec 2018 08:58:25 +0000 (14:28 +0530)]
Merge pull request #13354 from seamuslee001/lab_core_35
dev/mail#35 Ensure that Public View link is visible in Scheduled and …
Seamus Lee [Thu, 27 Dec 2018 08:03:21 +0000 (19:03 +1100)]
Merge pull request #13356 from yashodha/campaign_reports
(dev/core#491) campaign cleanup for pledge detail report and show dis…
Yashodha Chaku [Thu, 27 Dec 2018 07:42:25 +0000 (13:12 +0530)]
Merge pull request #13355 from seamuslee001/lab_core_621
dev/core#621 Ensure that only 2 decimal places are dispalyed for opti…
Seamus Lee [Thu, 27 Dec 2018 05:55:13 +0000 (16:55 +1100)]
Merge pull request #13316 from alifrumin/amountlink
On the Contribution Detail Report link the Amount field to the contribution
yashodha [Thu, 27 Dec 2018 05:14:30 +0000 (10:44 +0530)]
(dev/core#491) campaign cleanup for pledge detail report and show disabled campaigns as well
Seamus Lee [Wed, 26 Dec 2018 20:59:36 +0000 (07:59 +1100)]
dev/core#621 Ensure that only 2 decimal places are dispalyed for option amount and also ensure that non deductable amount is cleaned before saving to db
Seamus Lee [Wed, 26 Dec 2018 19:59:57 +0000 (06:59 +1100)]
Merge pull request #13351 from yashodha/campaign_reports
(dev/core#491) campaign cleanup for soft credit report and show disab…
Seamus Lee [Wed, 26 Dec 2018 19:44:50 +0000 (06:44 +1100)]
Merge pull request #13352 from yashodha/fix-verbiage
fix verbiage for Edit Contact Information title
Seamus Lee [Wed, 26 Dec 2018 19:42:12 +0000 (06:42 +1100)]
dev/mail#35 Ensure that Public View link is visible in Scheduled and Sent Screens
colemanw [Wed, 26 Dec 2018 18:04:56 +0000 (13:04 -0500)]
Merge pull request #13339 from yashodha/dev-610
(dev/core#610) Page title displays twice on Activity form
Seamus Lee [Wed, 26 Dec 2018 08:35:43 +0000 (19:35 +1100)]
Merge pull request #13347 from mfb/ellipsify-optimize
optimize CRM_Utils_String::ellipsify() method
yashodha [Wed, 26 Dec 2018 05:43:53 +0000 (11:13 +0530)]
fix verbiage for Edit Contact Information title
Yashodha Chaku [Wed, 26 Dec 2018 05:36:52 +0000 (11:06 +0530)]
Merge pull request #13349 from yashodha/fix-verbiage
fix verbiage for Dashboard title
yashodha [Wed, 26 Dec 2018 05:11:45 +0000 (10:41 +0530)]
(dev/core#491) campaign cleanup for soft credit report and show disabled campaigns as well
Seamus Lee [Tue, 25 Dec 2018 20:12:30 +0000 (07:12 +1100)]
Merge pull request #13348 from yashodha/campaign_reports
(dev/core#491) campaign cleanup for contribution (org) report and sho…
francescbassas [Mon, 24 Dec 2018 10:18:50 +0000 (11:18 +0100)]
Update Repeat.php
francescbassas [Mon, 24 Dec 2018 10:16:15 +0000 (11:16 +0100)]
#620 - Unable to show custom fields on Repeat Contributions Report
https://lab.civicrm.org/dev/core/issues/620
yashodha [Mon, 24 Dec 2018 08:40:37 +0000 (14:10 +0530)]
fix verbiage for Dashboard title
yashodha [Mon, 24 Dec 2018 05:44:01 +0000 (11:14 +0530)]
(dev/core#491) campaign cleanup for contribution (org) report and show disabled campaigns as well
mark burdett [Mon, 24 Dec 2018 04:47:06 +0000 (20:47 -0800)]
optimize CRM_Utils_String::ellipsify() method
Seamus Lee [Fri, 21 Dec 2018 21:59:16 +0000 (08:59 +1100)]
Merge pull request #13341 from yashodha/campaign_reports
add suport for order by clause for campaign and clean up
Seamus Lee [Fri, 21 Dec 2018 21:54:11 +0000 (08:54 +1100)]
Add in unit test to support changes in UF API in PR 13343
Frank J. Gómez [Fri, 21 Dec 2018 20:03:48 +0000 (15:03 -0500)]
Improved support for case variability in UF* API calls.
colemanw [Fri, 21 Dec 2018 15:58:32 +0000 (10:58 -0500)]
Merge pull request #13291 from eileenmcnaughton/process_default_active
Add default of TRUE for is_active on PaymentProcessor.create api.
colemanw [Fri, 21 Dec 2018 15:56:50 +0000 (10:56 -0500)]
Merge pull request #13329 from eileenmcnaughton/activity_extract
[REF] Add caching to function to determine if activity type is permitted.
Monish Deb [Fri, 21 Dec 2018 13:47:34 +0000 (19:17 +0530)]
Merge pull request #13250 from francescbassas/patch-16
#469 - Error on action "Email - schedule/send via CiviMail" with mult…
yashodha [Fri, 21 Dec 2018 12:40:39 +0000 (18:10 +0530)]
add suport for order by clause for campaign and clean up
Monish Deb [Fri, 21 Dec 2018 10:18:07 +0000 (15:48 +0530)]
Merge pull request #13241 from seamuslee001/561_schedule_reminders
dev/core#561 Convert Scheduled Reminders Form to use datepicker and e…
Seamus Lee [Fri, 21 Dec 2018 06:45:40 +0000 (17:45 +1100)]
Merge pull request #13281 from yashodha/campaign
campaign cleanup for household summary
yashodha [Fri, 21 Dec 2018 06:19:40 +0000 (11:49 +0530)]
(dev/core#610) Page title displays twice on Activity form
colemanw [Fri, 21 Dec 2018 04:33:51 +0000 (23:33 -0500)]
Merge pull request #13311 from mattwire/entityform_customsubtype
Support customdata subtype on entityform (for activity/relationship types)