Eileen McNaughton [Tue, 2 Nov 2021 05:31:50 +0000 (18:31 +1300)]
Merge pull request #21929 from colemanw/searchKitDefaultDisplays
SearchKit - default displays and ACL-aware links
Seamus Lee [Tue, 2 Nov 2021 03:32:40 +0000 (14:32 +1100)]
Merge pull request #21959 from civicrm/5.43
5.43
Seamus Lee [Tue, 2 Nov 2021 03:26:11 +0000 (14:26 +1100)]
Merge pull request #21958 from seamuslee001/fix_token_rendering_campaign_legacy_php8
[REF] Fix pseduoconstant token rendering for contributions via legacy…
Coleman Watts [Tue, 2 Nov 2021 00:28:35 +0000 (20:28 -0400)]
SearchKit - Fix action checkboxes to work with any key
Lifts the assumption that every entity has a key column named "id"
Coleman Watts [Tue, 2 Nov 2021 00:43:01 +0000 (20:43 -0400)]
SearchKit - Default label when adding a display
Seamus Lee [Tue, 2 Nov 2021 00:41:15 +0000 (00:41 +0000)]
[REF] Fix pseduoconstant token rendering for contributions via legacy way on php8 and include campaign_id pseudoconsntants as well
demeritcowboy [Mon, 1 Nov 2021 23:20:28 +0000 (19:20 -0400)]
Merge pull request #21934 from eileenmcnaughton/empty
Ensure no_licence is assigned for drop.tpl
colemanw [Mon, 1 Nov 2021 23:15:18 +0000 (19:15 -0400)]
Merge pull request #21952 from eileenmcnaughton/im
Handling for intermittent Im->getfields error
Eileen McNaughton [Fri, 29 Oct 2021 01:06:39 +0000 (14:06 +1300)]
Use empty not isset in drop.tpl
On experimenting a little with smarty escaping it turns out that isset is gonna be
a lot more painful than empty - we should avoid where we can. In this case it
is passed in as TRUE or not at all (from schema.tpl) so an empty check is just fine
demeritcowboy [Mon, 1 Nov 2021 16:03:41 +0000 (12:03 -0400)]
Merge pull request #21948 from braders/hardcoded-error-text
Avoid hardcoded text in error strings; make translatable
demeritcowboy [Mon, 1 Nov 2021 15:53:43 +0000 (11:53 -0400)]
Merge pull request #21954 from braders/avoid-hardcoded-period-type-labels
Don't hardcode Period Type in Manage Premiums template.
Bradley Taylor [Mon, 1 Nov 2021 13:41:38 +0000 (13:41 +0000)]
Don't hardcode Period Type in Manage Premiums template.
Seamus Lee [Mon, 1 Nov 2021 01:26:09 +0000 (12:26 +1100)]
Merge pull request #21949 from braders/harcoded-setstatus-text
Avoid harcoded text in setStatus calls; make translatable
Eileen McNaughton [Mon, 1 Nov 2021 01:14:03 +0000 (14:14 +1300)]
Merge pull request #21951 from eileenmcnaughton/messages
Ensure communityMessages is assigned to the template.
Eileen McNaughton [Sun, 31 Oct 2021 21:38:57 +0000 (10:38 +1300)]
Ensure communityMessages is assigned to the template.
This is a minor code simplification & ensures the parameter is set rather than
handling it not being set at the template level
Eileen McNaughton [Sun, 31 Oct 2021 22:09:24 +0000 (11:09 +1300)]
Handling for intermittent Im->getfields error
I'm not quite sure when this started but I've been seeing Im->getfields not found errors of late - this helps
Eileen McNaughton [Sun, 31 Oct 2021 20:28:29 +0000 (09:28 +1300)]
Merge pull request #21950 from braders/misc-hardcoded-strings
Make miscellaneous strings translatable
Eileen McNaughton [Sun, 31 Oct 2021 19:57:54 +0000 (08:57 +1300)]
Merge pull request #21946 from braders/dedupe-find-label-associations
Accessibility: Fix label associations for DepupeFind template.
Bradley Taylor [Sun, 31 Oct 2021 18:03:35 +0000 (18:03 +0000)]
Avoid hardcoded text in setStatus calls; make translatable
Coleman Watts [Thu, 28 Oct 2021 13:52:25 +0000 (09:52 -0400)]
SearchKit - Expose default display to the UI
Adds a 'view' link to the searchKit admin listing, which links to the default display
Adds a 'view' dropdown to the compose search screen, with links to the default + all other displays
Updates Afform to work with default search displays
Bradley Taylor [Sun, 31 Oct 2021 18:05:24 +0000 (18:05 +0000)]
Make miscellaneous translatable
Bradley Taylor [Sun, 31 Oct 2021 17:55:54 +0000 (17:55 +0000)]
Avoid hardcoded text in error strings; make translatable
Coleman Watts [Thu, 28 Oct 2021 13:50:36 +0000 (09:50 -0400)]
SearchKit - Only show tags filter if tags exist
Remove clutter if an org does not use tags.
Also removes an unused copy-pasted function.
Coleman Watts [Wed, 27 Oct 2021 18:38:18 +0000 (14:38 -0400)]
SearchKit - Set links in admin UI using entity+action+join instead of path
Now that SearchDisplay.Run understands this new link syntax, the admin UI
can use it too. The old links set in existing search displays will still work,
but in order for ACLs to be checked they need to use the new syntax.
Coleman Watts [Wed, 27 Oct 2021 14:44:29 +0000 (10:44 -0400)]
SearchKit - Check ACLs before displaying links or in-place edit
Coleman Watts [Wed, 27 Oct 2021 05:22:23 +0000 (01:22 -0400)]
SearchKit - Autogenerate default display table for saved searches; calculate links by entity+action
This adds a SearchDisplay.getDefault APIv4 action, which autogenerates the default table display
which is used on the admin screen.
It also refactors links so they can be calculated based on a given entity+action which does not
require paths to be stored in the search display.
Bradley Taylor [Sun, 31 Oct 2021 14:08:50 +0000 (14:08 +0000)]
Accessibility: Fix label associations for DepupeFind template.
This ensures that the labels have an accessible name for assistive technologies.
demeritcowboy [Fri, 29 Oct 2021 23:48:34 +0000 (19:48 -0400)]
Merge pull request #21931 from eileenmcnaughton/ple
Convert more tests to use full form flow
Eileen McNaughton [Thu, 28 Oct 2021 22:56:52 +0000 (11:56 +1300)]
Do not pass test-blocked parameter to function that doesn't use it
Seamus Lee [Fri, 29 Oct 2021 20:07:34 +0000 (07:07 +1100)]
Merge pull request #21938 from mattwire/groupcontactcacheunused
Remove unused function from GroupContactCache
Eileen McNaughton [Thu, 28 Oct 2021 22:55:34 +0000 (11:55 +1300)]
Convert more tests to use full form flow
Matthew Wire [Fri, 29 Oct 2021 18:04:11 +0000 (19:04 +0100)]
Remove unused function
Monish Deb [Fri, 29 Oct 2021 05:05:54 +0000 (10:35 +0530)]
Merge pull request #21855 from eileenmcnaughton/part
Add test for selvsvctransfer, remove use of `$contact` from template
Eileen McNaughton [Fri, 29 Oct 2021 04:51:12 +0000 (17:51 +1300)]
Merge pull request #21930 from colemanw/removeCxn
Remove "Connections" from navigation menu
Eileen McNaughton [Fri, 29 Oct 2021 02:17:56 +0000 (15:17 +1300)]
Merge pull request #21932 from eileenmcnaughton/quotes
[NFC] [Tests] remove code smell - unnecessary double quotes
Coleman Watts [Thu, 28 Oct 2021 22:22:01 +0000 (18:22 -0400)]
Fixes dev/core#2910 - Remove "Connections" from navigation menu
This obscure feature is currently unused, so there's no reason to show it in the menu.
Fixes https://lab.civicrm.org/dev/core/-/issues/2910
Eileen McNaughton [Thu, 28 Oct 2021 23:04:46 +0000 (12:04 +1300)]
[NFC] [Tests] remove code smell - unnecessary double quotes
This is an IDE cleanup. It touches a few files but
1) only test files and
2) only that specific change, made via an IDE is in here
So I think it should be possible to merge based on test outcome
colemanw [Thu, 28 Oct 2021 21:39:02 +0000 (17:39 -0400)]
Merge pull request #21790 from eileenmcnaughton/greetings_earthling
Switch replaceGreetingTokens over
Eileen McNaughton [Thu, 28 Oct 2021 21:29:21 +0000 (10:29 +1300)]
Merge pull request #21922 from jitendrapurohit/taskmenu
dev/joomla#36 - Fix fatal error in joomla with civicrm task query param
Eileen McNaughton [Mon, 25 Oct 2021 02:20:42 +0000 (15:20 +1300)]
Regenerate sql
Eileen McNaughton [Mon, 18 Oct 2021 20:41:59 +0000 (09:41 +1300)]
Replace call to getTokenDetails with simple contact.get
Eileen McNaughton [Mon, 18 Oct 2021 20:14:09 +0000 (09:14 +1300)]
Add test for selvsvctransfer, remove from template
Coleman Watts [Thu, 28 Oct 2021 19:06:46 +0000 (15:06 -0400)]
APIv4 - Cache SchemaMap in Civi::cache('metadata')
When adding/removing custom groups, the schema map changes.
Civi already flushes the metadata cache when this happens,
but the APIv4 SchemaMap was being cached in memory (in a container service).
This changes it to be stored in the metadata cache like everything else.
demeritcowboy [Thu, 28 Oct 2021 18:55:24 +0000 (14:55 -0400)]
Merge pull request #21926 from colemanw/fixCrmCoreMenu
[REF] CRM_Core_Menu - Fix syntax, undefined variables, unused code, pass-by-ref
Coleman Watts [Wed, 27 Oct 2021 16:58:03 +0000 (12:58 -0400)]
CRM_Core_Menu - Fix syntax, undefined variables, unused code, pass-by-ref
Monish Deb [Thu, 28 Oct 2021 15:03:00 +0000 (20:33 +0530)]
Merge pull request #21820 from colemanw/searchKitServerSideRender
SearchKit server-side rendering
Monish Deb [Thu, 28 Oct 2021 11:44:47 +0000 (17:14 +0530)]
Merge pull request #21925 from eileenmcnaughton/dom_from
Simplify usage of getting domain from email
Eileen McNaughton [Wed, 27 Oct 2021 23:13:13 +0000 (12:13 +1300)]
Merge pull request #21917 from braders/feature/translate-set-title-calls
Make hardcoded labels passed to setTitle translatable
demeritcowboy [Wed, 27 Oct 2021 22:21:40 +0000 (18:21 -0400)]
Merge pull request #21928 from eileenmcnaughton/usused
Remove unused function
Eileen McNaughton [Wed, 27 Oct 2021 19:59:11 +0000 (08:59 +1300)]
Remove unused function
Note we don't slow the removal down by adding deprecation notices for internal financial functions as they have
never been stable / supported for external use
demeritcowboy [Wed, 27 Oct 2021 15:12:14 +0000 (11:12 -0400)]
Merge pull request #21914 from eileenmcnaughton/trxn
[REF] Move another function to the FinancialProcessor
Coleman Watts [Sat, 23 Oct 2021 22:02:44 +0000 (18:02 -0400)]
SearchKit - Use server-side preprocessing for editable fields
Coleman Watts [Wed, 13 Oct 2021 02:19:45 +0000 (22:19 -0400)]
SearchKit - server-side rendering
Moves logic for resolving field values from the client to the server-side,
which gives more control over formatting, links, and greater consistency
of spreadsheet output.
Eileen McNaughton [Tue, 26 Oct 2021 19:13:22 +0000 (08:13 +1300)]
Simplify usage of getting domain from email
This adds a function that 'just gets the string' - rather than overloading
another function and (worse) getting the string back as an array that needs to be
'currented'. It also switches
the participant function to use it - as we will soon not be passing
domainValues into this function
Eileen McNaughton [Tue, 26 Oct 2021 18:27:56 +0000 (07:27 +1300)]
Merge pull request #21924 from civicrm/5.43
5.43 to master
Seamus Lee [Tue, 26 Oct 2021 05:12:46 +0000 (16:12 +1100)]
Merge pull request #21921 from eileenmcnaughton/gc
[NFC] [REF] Test class cleanup
demeritcowboy [Tue, 26 Oct 2021 03:56:05 +0000 (23:56 -0400)]
Merge pull request #21913 from eileenmcnaughton/worddoc
dev/core#2864 fix for rc breakage in pdf-letter-to-word
Eileen McNaughton [Sat, 23 Oct 2021 04:08:32 +0000 (17:08 +1300)]
dev/core#2864 fix for rc breakage in pdf-letter-to-word
Eileen McNaughton [Mon, 25 Oct 2021 19:37:41 +0000 (08:37 +1300)]
Merge pull request #21853 from colemanw/allCoreTables
AllCoreTables - Allow virtual entities to share a DAO class
demeritcowboy [Mon, 25 Oct 2021 13:53:02 +0000 (09:53 -0400)]
Merge pull request #21907 from eileenmcnaughton/tests
Fix a few more tests to use a more realistic flow
demeritcowboy [Mon, 25 Oct 2021 13:50:05 +0000 (09:50 -0400)]
Merge pull request #21906 from eileenmcnaughton/cont_test
Fix more tests to use the full form flow
Coleman Watts [Mon, 18 Oct 2021 14:54:03 +0000 (10:54 -0400)]
AllCoreTables - Allow virtual entities to share a DAO class
Indexes entities by brief name instead of class name,
which allows one class to be shared by multiple entities.
jitendrapurohit [Mon, 25 Oct 2021 06:31:41 +0000 (12:01 +0530)]
Fix fatal error in joomla with civicrm task query param
Eileen McNaughton [Sun, 24 Oct 2021 23:27:26 +0000 (12:27 +1300)]
[NFC] [REF] Test class cleanup
The driver for this was to remove uses of the DAO->createTestObject methods which were creating
individuals with data invalid for them. However, this is a full 'margin cleanup' and
standardises the test.
I think the whole createTestObject approach is best viewed as an early attempt to get
lots of entities testable quickly but it's overwraught for creating contacts
(and generally a bit flakey)
Eileen McNaughton [Sun, 24 Oct 2021 21:25:20 +0000 (10:25 +1300)]
Merge pull request #21920 from colemanw/getInfoItemCache
APIv4 - Fix performance drag caused by getInfoItem calling the API
Eileen McNaughton [Sun, 24 Oct 2021 02:56:38 +0000 (15:56 +1300)]
Merge pull request #21918 from braders/feature/spelling-fixes
Miscellaneous spelling fixes
Coleman Watts [Sat, 23 Oct 2021 23:27:21 +0000 (19:27 -0400)]
APIv4 - Fix performance drag caused by getInfoItem calling the API
This function is sometimes called thousands of times per request, e.g. for every cell
in a searchKit display table. Going through the API wrapper that many times is a
considerable (+10 sec) drag on performance.
Instead of calling Entity.get, we can just read directly from the cache where it stores its data.
Bradley Taylor [Sat, 23 Oct 2021 11:09:44 +0000 (12:09 +0100)]
Miscellaneous spelling fixes
colemanw [Sat, 23 Oct 2021 19:14:48 +0000 (15:14 -0400)]
Merge pull request #21915 from eileenmcnaughton/protext
[Ref] Make functions private to protect them
demeritcowboy [Sat, 23 Oct 2021 13:46:43 +0000 (09:46 -0400)]
Merge pull request #21847 from eileenmcnaughton/pledge2
Standardise our 2 pledge templates to use tokens, add tests
Bradley Taylor [Sat, 23 Oct 2021 10:52:00 +0000 (11:52 +0100)]
Translate hardcoded labels passed to setTitle
Eileen McNaughton [Sat, 23 Oct 2021 04:40:19 +0000 (17:40 +1300)]
[REF] Move another function to the FinancialProcessor
At this stage just moving all the financial processing functions to the same class
Eileen McNaughton [Sat, 23 Oct 2021 04:43:59 +0000 (17:43 +1300)]
[Ref] Make functions private to protect them
As we move functions to this class making them private once they are unused outside the class
makes it easier to clean them up
Eileen McNaughton [Sat, 16 Oct 2021 23:23:19 +0000 (12:23 +1300)]
Switch pledge_reminder over to use tokens
Eileen McNaughton [Sat, 16 Oct 2021 22:37:47 +0000 (11:37 +1300)]
Update pledge acknowledgement to use token processor only
Eileen McNaughton [Mon, 11 Oct 2021 05:23:27 +0000 (18:23 +1300)]
Add test for domain, contact tokens in pledge
Eileen McNaughton [Sat, 23 Oct 2021 04:28:43 +0000 (17:28 +1300)]
Merge pull request #21910 from eileenmcnaughton/new_validate
Fix cleanup on test, also NFC cleanup
Eileen McNaughton [Sat, 23 Oct 2021 02:36:30 +0000 (15:36 +1300)]
Merge pull request #21692 from demeritcowboy/dbssl
Fix unreplaced template vars in civicrm.settings.php when using legacy installer
Eileen McNaughton [Sat, 23 Oct 2021 01:24:22 +0000 (14:24 +1300)]
Fix cleanup on test, also NFC cleanup
This test was not cleaning itself up very well in the tearDown - causing the post test validate to fail
Eileen McNaughton [Sat, 23 Oct 2021 00:23:38 +0000 (13:23 +1300)]
Fix test to manage statics within the test
Tim Otten [Tue, 19 Oct 2021 02:06:43 +0000 (19:06 -0700)]
CiviTest - Define `CRM_Fake_DAO_*` classes
The tests are being a being a brittle because someone wants to load these non-existent classes:
* CRM_Fake_DAO_FakeFile
* CRM_Fake_DAO_Widget
* CRM_Fake_DAO_Forbidden
* CRM_Fake_DAO_Sprocket
Tim Otten [Fri, 15 Oct 2021 07:42:28 +0000 (00:42 -0700)]
replaceGreetingTokens - Be more forgiving about $contactDetails
This should fix a failure in `TokenConsistencyTest`. Setting a breakpoint and monitoring
`$contactDetails`, it appears that the data would come in multiple formats. (Sometimes as
a nested array; sometimes as a flatter array.) This makes it work with both cases.
Eileen McNaughton [Thu, 14 Oct 2021 20:10:25 +0000 (09:10 +1300)]
Fix token metadata to be clearable outside tests
Eileen McNaughton [Mon, 11 Oct 2021 06:56:11 +0000 (19:56 +1300)]
Switch replaceGreetingTokens over
Eileen McNaughton [Fri, 22 Oct 2021 23:53:54 +0000 (12:53 +1300)]
Merge pull request #21904 from braders/feature/remove-from-tag-translatable-errors
Make error message translatable - remove tag tasks.
Eileen McNaughton [Fri, 22 Oct 2021 23:53:18 +0000 (12:53 +1300)]
Merge pull request #21905 from braders/feature/add-to-group-translatable-errors
Make error messages translatable.
Eileen McNaughton [Fri, 22 Oct 2021 21:54:17 +0000 (10:54 +1300)]
Fix a few more tests to use a more realistic flow
Eileen McNaughton [Fri, 22 Oct 2021 21:28:31 +0000 (10:28 +1300)]
Fix more tests to use the full form flow
Bradley Taylor [Fri, 22 Oct 2021 20:33:11 +0000 (21:33 +0100)]
Make error messages translatable.
Eileen McNaughton [Fri, 22 Oct 2021 20:29:07 +0000 (09:29 +1300)]
Merge pull request #21892 from artfulrobot/artfulrobot-order-membership
Improve tests around the Order.create API and membership
demeritcowboy [Fri, 22 Oct 2021 20:25:59 +0000 (16:25 -0400)]
fix unreplaced template vars when using legacy installer
Bradley Taylor [Fri, 22 Oct 2021 20:25:18 +0000 (21:25 +0100)]
Make error message translatable.
Also fix typo (space between 'at least')
demeritcowboy [Fri, 22 Oct 2021 15:50:52 +0000 (11:50 -0400)]
Merge pull request #21848 from eileenmcnaughton/valid
Add financial validation check (to the extent we can)
demeritcowboy [Fri, 22 Oct 2021 15:04:24 +0000 (11:04 -0400)]
Merge pull request #21863 from mariav0/patch-6
Update contribution_recurring_billing_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:04:04 +0000 (11:04 -0400)]
Merge pull request #21850 from mariav0/patch-1
Update contribution_online_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:03:37 +0000 (11:03 -0400)]
Merge pull request #21888 from mariav0/patch-26
Update test_preview_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:03:20 +0000 (11:03 -0400)]
Merge pull request #21890 from mariav0/patch-28
Update contribution_invoice_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:03:07 +0000 (11:03 -0400)]
Merge pull request #21889 from mariav0/patch-27
Update uf_notify_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:02:52 +0000 (11:02 -0400)]
Merge pull request #21887 from mariav0/patch-25
Update pledge_reminder_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:02:40 +0000 (11:02 -0400)]
Merge pull request #21886 from mariav0/patch-24
Update pledge_acknowledge_html.tpl