Eileen McNaughton [Thu, 9 Nov 2023 20:51:57 +0000 (09:51 +1300)]
Merge pull request #28079 from chriscant/civi-api-kernel-error2
Ensure api/v3/utils.php required before civicrm_api3_create_error 5.68
Chris Cant [Thu, 9 Nov 2023 14:37:50 +0000 (14:37 +0000)]
Ensure api/v3/utils.php required before civicrm_api3_create_error 5.68
Seamus Lee [Thu, 9 Nov 2023 01:23:56 +0000 (12:23 +1100)]
Merge pull request #28073 from totten/master568-http-log
(NFC) MenuXmlTest - Improve debug output. Use richer helpers.
Tim Otten [Wed, 8 Nov 2023 23:37:36 +0000 (15:37 -0800)]
MenuXmlTest - Improve debug output. Use richer helpers.
In automated test-runs, the e2e test for `mixin/menu-xml@1` (`MenuXmlTest`) has been failing sporadically.
The failure always involves one of the HTTP sub-requests, but it's never clear what actually happened
in the HTTP sub-request. This patch improves debug info.
Before
-------
Send HTTP sub-request with simple primitives (`cv` + `file_get_contents`). No detailed information about the failed request.
After
-----
Send HTTP sub-request with `HttpTestTrait` (`guzzle`). Use rich assertions that log more detailed information.
Tim Otten [Wed, 8 Nov 2023 23:37:03 +0000 (15:37 -0800)]
HttpTestTrait - Add more assertion helpers
demeritcowboy [Wed, 8 Nov 2023 15:20:42 +0000 (10:20 -0500)]
Merge pull request #28051 from eileenmcnaughton/import_568
dev/core#4554 Delete related Queue when user job deleted
Eileen McNaughton [Wed, 8 Nov 2023 01:37:44 +0000 (14:37 +1300)]
dev/core#4554 Delete related Queue when user job deleted
Seamus Lee [Tue, 7 Nov 2023 21:17:29 +0000 (08:17 +1100)]
Merge pull request #28040 from colemanw/angularDepNotice
[NFC] More descriptive deprecation notice for Angular settings
colemanw [Tue, 7 Nov 2023 19:49:30 +0000 (14:49 -0500)]
More descriptive deprecation notice for Angular settings
colemanw [Tue, 7 Nov 2023 18:41:30 +0000 (13:41 -0500)]
Merge pull request #28036 from demeritcowboy/case-edit
dev/core#4755 - typo causes activity type to go missing on case activity edit
demeritcowboy [Tue, 7 Nov 2023 14:51:54 +0000 (09:51 -0500)]
typo
demeritcowboy [Tue, 7 Nov 2023 13:59:25 +0000 (08:59 -0500)]
Merge pull request #28018 from colemanw/searchFunctionZeroBugFix
SearchKit - Fix field transformation UI to handle number 0
Eileen McNaughton [Mon, 6 Nov 2023 22:48:38 +0000 (11:48 +1300)]
Merge pull request #28029 from MegaphoneJon/deprecated-part-token
Add check for deprecated token in event online receipt
Jon Goldberg [Mon, 6 Nov 2023 20:28:45 +0000 (15:28 -0500)]
Add check for deprecated token in event online receipt
colemanw [Sat, 4 Nov 2023 02:29:15 +0000 (22:29 -0400)]
SearchKit - Fix field transformation UI to handle number 0
This is the old number 0 is falsey bug.
To reproduce, add a field transformation such as if/else,
clear the field values and select numbers.
The number zero will be treated as empty and not work.
colemanw [Fri, 3 Nov 2023 11:36:17 +0000 (07:36 -0400)]
Merge pull request #28010 from eileenmcnaughton/notice_568
Fix unreleased regression - notice on undefined variable
Eileen McNaughton [Fri, 3 Nov 2023 02:50:38 +0000 (15:50 +1300)]
Fix unreleased regression - notice on undefined variable
This notice is in recently extracted code
Seamus Lee [Fri, 3 Nov 2023 03:29:43 +0000 (14:29 +1100)]
Merge pull request #28002 from eileenmcnaughton/568
Smarty3 - fix space breaking syntax
colemanw [Fri, 3 Nov 2023 02:07:54 +0000 (22:07 -0400)]
Merge pull request #28004 from eileenmcnaughton/568_price
Fix 5.68 unreleased regression - repeattransaction fails if CiviMember not installed
Eileen McNaughton [Fri, 3 Nov 2023 00:01:18 +0000 (13:01 +1300)]
Fix 5.68 unreleased regression - repeattransaction fails if CiviMember not installed
Eileen McNaughton [Thu, 2 Nov 2023 22:51:26 +0000 (11:51 +1300)]
Smarty3 - fix space breaking syntax
Seamus Lee [Thu, 2 Nov 2023 21:26:25 +0000 (08:26 +1100)]
Merge pull request #27992 from artfulrobot/artfulrobot-issue-4746-php73
standaloneusers: remove property type declarations to make php7.3 compat
Seamus Lee [Thu, 2 Nov 2023 21:26:11 +0000 (08:26 +1100)]
Merge pull request #27990 from seamuslee001/regex_test_failure
[REF] dev/core#4747 Fix Binary Regex by casting field to Binary
Tim Otten [Thu, 2 Nov 2023 20:59:36 +0000 (13:59 -0700)]
Merge pull request #27922 from colemanw/setVersionStableOnly
Releaser - Only update core extensions for stable versions
Seamus Lee [Thu, 2 Nov 2023 20:54:59 +0000 (07:54 +1100)]
Merge pull request #27993 from colemanw/fillEntityDefaults
APIv4 - Ensure 'search_fields' defaults to 'label_field' for Entity.get
Seamus Lee [Thu, 2 Nov 2023 20:53:59 +0000 (07:53 +1100)]
Merge pull request #27996 from mlutfy/flagsTypeError
PHP 8.x: fix TypeError in config hook
Mathieu Lu [Thu, 2 Nov 2023 19:50:41 +0000 (15:50 -0400)]
PHP 8.x: fix TypeError in config hook
Rich Lott / Artful Robot [Thu, 2 Nov 2023 11:24:36 +0000 (11:24 +0000)]
standaloneusers: remove property type declarations to make php7.3 compatible dev/core/4746
CiviCRM [Thu, 2 Nov 2023 01:06:03 +0000 (01:06 +0000)]
Set version to 5.68.beta1
colemanw [Thu, 2 Nov 2023 00:59:35 +0000 (20:59 -0400)]
APIv4 - Ensure 'search_fields' defaults to 'label_field' for Entity.get
This default is set in the AbstractEntity class, but not every entity inherits from that class,
e.g. ECK does not.
So it needs to be filled in by the Entity.get action
Tim Otten [Thu, 2 Nov 2023 00:53:06 +0000 (17:53 -0700)]
set-version - Yes increment for 5.68.x=>5.69.alpha. But OK to skip alpha2, beta2, beta3, etc
Seamus Lee [Wed, 1 Nov 2023 23:20:11 +0000 (10:20 +1100)]
[REF] dev/core#4747 Fix Binary Regex by casting field to Binary
Eileen McNaughton [Wed, 1 Nov 2023 23:31:37 +0000 (12:31 +1300)]
Merge pull request #27982 from eileenmcnaughton/price_field
Fix master-only-over-aggressive escaping
demeritcowboy [Wed, 1 Nov 2023 23:20:26 +0000 (19:20 -0400)]
Merge pull request #27984 from eileenmcnaughton/options_m
Notice fixes on price field options
Eileen McNaughton [Wed, 1 Nov 2023 22:55:30 +0000 (11:55 +1300)]
Merge pull request #27912 from ranjit-git/master
Improve template handling in report
Eileen McNaughton [Wed, 1 Nov 2023 22:54:34 +0000 (11:54 +1300)]
Merge pull request #27977 from JMAConsulting/improve-geocoding-for-address
Improve Geocoding for addresses
Eileen McNaughton [Wed, 1 Nov 2023 22:53:34 +0000 (11:53 +1300)]
Merge pull request #27979 from colemanw/unconfirmed
Add label & color to CiviPetition 'Unconfirmed' tag
Eileen McNaughton [Wed, 1 Nov 2023 22:51:19 +0000 (11:51 +1300)]
Merge pull request #27943 from colemanw/fixDownload
dev/core#4731 - Fix column index error in SearchKit download
Eileen McNaughton [Wed, 1 Nov 2023 22:50:21 +0000 (11:50 +1300)]
Merge pull request #27924 from demeritcowboy/tag-name
dev/core#4727 - Tags displaying name instead of label in various places
Eileen McNaughton [Wed, 1 Nov 2023 22:46:16 +0000 (11:46 +1300)]
Merge pull request #27613 from eileenmcnaughton/part_trait
Move participant-form-specific defaults back to participant form
Seamus Lee [Wed, 1 Nov 2023 22:44:34 +0000 (09:44 +1100)]
Merge pull request #27987 from seamuslee001/master
5.67
Seamus Lee [Wed, 1 Nov 2023 22:42:58 +0000 (09:42 +1100)]
Merge branch '5.67'
Eileen McNaughton [Wed, 1 Nov 2023 22:39:06 +0000 (11:39 +1300)]
Merge pull request #27983 from eileenmcnaughton/options
Add a few more weights - price field options page
demeritcowboy [Wed, 1 Nov 2023 22:16:45 +0000 (18:16 -0400)]
Merge pull request #27965 from eileenmcnaughton/567
rc only regression - price set validation on participant form
Tim Otten [Wed, 1 Nov 2023 22:15:58 +0000 (15:15 -0700)]
Merge pull request #27981 from totten/5.67-log-locale
Logging - If valid, then set a locale
Eileen McNaughton [Wed, 1 Nov 2023 21:06:48 +0000 (10:06 +1300)]
Notice fixes on price field options
Fixes smarty notices on
https://dmaster.localhost:32353/civicrm/admin/price/field/option?action=browse&reset=1&sid=3&fid=2
Eileen McNaughton [Wed, 1 Nov 2023 20:57:50 +0000 (09:57 +1300)]
Add a few more weights - price field page
Eileen McNaughton [Wed, 1 Nov 2023 20:48:26 +0000 (09:48 +1300)]
Fix master-only-over-aggressive escaping
Tim Otten [Wed, 1 Nov 2023 20:40:19 +0000 (13:40 -0700)]
composer.json - Lock in a snapshot of the patch file
Eileen McNaughton [Fri, 27 Oct 2023 21:32:29 +0000 (10:32 +1300)]
rc only regression - price set validation on participant form
Tim Otten [Wed, 1 Nov 2023 19:57:52 +0000 (12:57 -0700)]
Logging - If valid, then set a locale
This is an updated variation of Seamus's 27974, with two key differences:
1. It calls `setLocale()` one time -- from within `createDebugLogger()`.
(This becomes an internal detail of how `createDebugLogger()` works.)
2. It calls `setLocale()` conditionally -- if the method actually exists.
It's not certain whether the method will ultimately be part of the
official `pear/log` releases. (*And once upstream changes, it may
immediately affect D9/D10-style builds.*) This change means that
civicrm-core should with `pear/log` in either contingency.
Tim Otten [Wed, 1 Nov 2023 19:53:25 +0000 (12:53 -0700)]
Merge pull request #27980 from agh1/5.67.0-releasenotes-final
5.67.0 release notes - added late changes and recent point releases
Andie Hunt [Wed, 1 Nov 2023 19:45:20 +0000 (15:45 -0400)]
5.67.0 release notes: added late changes
colemanw [Wed, 1 Nov 2023 19:21:25 +0000 (15:21 -0400)]
Merge pull request #27978 from reflexive-communications/confirm-signature-api
CRM_Campaign_BAO_Petition::confirmSignature: call pre/post hooks
Tim Otten [Mon, 30 Oct 2023 00:46:42 +0000 (17:46 -0700)]
Add release-notes/5.66.2.md
Tim Otten [Wed, 25 Oct 2023 03:45:17 +0000 (20:45 -0700)]
release-notes/5.66.1.md - Fix Markdown rendering of wordwrap
Tim Otten [Wed, 25 Oct 2023 03:08:26 +0000 (20:08 -0700)]
Add release-notes/5.66.1.md
Tim Otten [Tue, 19 Sep 2023 22:28:31 +0000 (15:28 -0700)]
Add release-notes/5.65.2.md
Tim Otten [Fri, 8 Sep 2023 06:05:52 +0000 (23:05 -0700)]
Update 5.65.1.md
Tim Otten [Fri, 8 Sep 2023 03:05:18 +0000 (20:05 -0700)]
Add release-notes/5.65.1.md
Tim Otten [Wed, 6 Sep 2023 05:08:53 +0000 (22:08 -0700)]
Add release-notes/5.64.4.md
Tim Otten [Fri, 1 Sep 2023 05:49:59 +0000 (22:49 -0700)]
Add release-notes/5.64.3.md
Tim Otten [Fri, 25 Aug 2023 02:44:29 +0000 (19:44 -0700)]
Add release-notes/5.64.2.md
Tim Otten [Fri, 18 Aug 2023 07:37:08 +0000 (00:37 -0700)]
Add release-notes/5.64.1.md
Tim Otten [Thu, 3 Aug 2023 01:55:52 +0000 (18:55 -0700)]
Update release-notes/5.63.3.md
Tim Otten [Thu, 3 Aug 2023 01:49:34 +0000 (18:49 -0700)]
Add release-notes/5.63.3.md
colemanw [Wed, 1 Nov 2023 16:02:54 +0000 (12:02 -0400)]
Merge pull request #27754 from colemanw/quickAdd
Afform - Quick add links for Autocomplete fields
pipeline [Mon, 25 Sep 2023 17:05:29 +0000 (11:05 -0600)]
Modified functions in BatchUpdate.php file
colemanw [Tue, 26 Sep 2023 23:56:35 +0000 (19:56 -0400)]
Afform - Quick add links for Autocomplete fields
colemanw [Wed, 1 Nov 2023 14:33:08 +0000 (10:33 -0400)]
Add label & color to CiviPetition 'Unconfirmed' tag
Sandor Semsey [Wed, 1 Nov 2023 00:15:30 +0000 (01:15 +0100)]
CRM_Campaign_BAO_Petition::confirmSignature: use APIv4
Matthew Wire [Wed, 1 Nov 2023 10:40:13 +0000 (10:40 +0000)]
Merge pull request #27976 from eileenmcnaughton/dep
Standardise deprecations
Eileen McNaughton [Wed, 1 Nov 2023 03:09:07 +0000 (16:09 +1300)]
Standardise deprecations
Sandor Semsey [Wed, 1 Nov 2023 01:57:32 +0000 (02:57 +0100)]
CRM_Campaign_BAO_Petition::createSignature: remove pass by reference
colemanw [Tue, 31 Oct 2023 18:13:10 +0000 (14:13 -0400)]
Merge pull request #27962 from colemanw/mailLinks
CiviMail - Update path metadata
Yashodha Chaku [Tue, 31 Oct 2023 15:26:02 +0000 (20:56 +0530)]
Merge pull request #27916 from colemanw/isMultiple
CustomGroup - Allow increasing max_multiple
Matthew Wire [Mon, 30 Oct 2023 10:05:28 +0000 (10:05 +0000)]
Merge pull request #27952 from eileenmcnaughton/money
Fix offline contribution page handling of money fields
Matthew Wire [Mon, 30 Oct 2023 10:03:57 +0000 (10:03 +0000)]
Merge pull request #27954 from eileenmcnaughton/pay_now
Suppress pay now on user dashboard if none configured
Matthew Wire [Mon, 30 Oct 2023 10:02:51 +0000 (10:02 +0000)]
Merge pull request #27970 from eileenmcnaughton/money_format
Move the locale default getting from the money() function to the getFormatter function
Eileen McNaughton [Mon, 30 Oct 2023 07:36:58 +0000 (20:36 +1300)]
Merge pull request #27963 from eileenmcnaughton/smarty_pledge
Fix Smarty3 support & Smarty-any notices in pledge search/dashboard
Eileen McNaughton [Fri, 27 Oct 2023 20:49:12 +0000 (09:49 +1300)]
Fix Smarty3 support & Smarty-any notices in pledge search/dashboard
demeritcowboy [Mon, 30 Oct 2023 02:59:05 +0000 (22:59 -0400)]
Merge pull request #27972 from civicrm/5.67
5.67
demeritcowboy [Mon, 30 Oct 2023 02:54:43 +0000 (22:54 -0400)]
Merge pull request #27896 from MegaphoneJon/missing-stage-on-behalf
fixes core#4724 - on behalf of addresses crash with missing state/province
Seamus Lee [Mon, 30 Oct 2023 01:58:36 +0000 (12:58 +1100)]
Merge pull request #27967 from alifrumin/rn5.67
[NFC] First pass at release notes for 5.67
colemanw [Mon, 30 Oct 2023 00:14:34 +0000 (20:14 -0400)]
Merge pull request #27968 from demeritcowboy/case-tag-label
dev/core#4730 - Case tagsets showing name instead of label
Eileen McNaughton [Sun, 29 Oct 2023 22:54:55 +0000 (11:54 +1300)]
Merge pull request #27969 from demeritcowboy/file-notice
E_WARNING for "file" on civicontribute component settings
Eileen McNaughton [Sun, 29 Oct 2023 21:46:43 +0000 (10:46 +1300)]
Move the locale default getting from the money() funciton to the
getFormatter function
demeritcowboy [Sun, 29 Oct 2023 21:12:22 +0000 (17:12 -0400)]
e-notice
Eileen McNaughton [Fri, 27 Oct 2023 02:21:38 +0000 (15:21 +1300)]
Fix offline contribution page handling of money fields
Fixes Offline contribution page so this fix
https://github.com/civicrm/civicrm-core/pull/27917
works for it too.
Note the 2 changes on total_amount are just tidy ups to remove redundancy - but
double cleaning can also cause breakage...
I prefer to use getSubmittedValue() whereever possible
because it makes it clear we are using the user-submitted
value not some value wrangled into an array along the way
Eileen McNaughton [Sun, 29 Oct 2023 20:37:27 +0000 (09:37 +1300)]
Merge pull request #27961 from demeritcowboy/test-ext
Update the list of required extensions to install during test db populate
demeritcowboy [Sun, 29 Oct 2023 20:13:57 +0000 (16:13 -0400)]
name label
Alice Frumin [Fri, 20 Oct 2023 18:36:30 +0000 (14:36 -0400)]
[NFC] 5.67 Release Notes
demeritcowboy [Sat, 28 Oct 2023 01:35:51 +0000 (21:35 -0400)]
can't check files that aren't real
demeritcowboy [Fri, 27 Oct 2023 21:03:19 +0000 (17:03 -0400)]
can skip afform in api3 conformance
demeritcowboy [Fri, 27 Oct 2023 20:53:30 +0000 (16:53 -0400)]
remove older nonconformant settings
demeritcowboy [Fri, 27 Oct 2023 20:02:03 +0000 (16:02 -0400)]
install required exts during test db populate
demeritcowboy [Sat, 28 Oct 2023 02:22:18 +0000 (22:22 -0400)]
Merge pull request #27948 from eileenmcnaughton/page_trait_2
Further fixes to ContributionPageTest
demeritcowboy [Sat, 28 Oct 2023 01:40:59 +0000 (21:40 -0400)]
Merge pull request #27966 from colemanw/tagCrash
Fix dev/core#4737 - APIv4 getFields crashes with no tags
colemanw [Sat, 28 Oct 2023 00:11:20 +0000 (20:11 -0400)]
Fix dev/core#4737 - APIv4 getFields crashes with no tags
Eileen McNaughton [Fri, 27 Oct 2023 21:09:36 +0000 (10:09 +1300)]
Merge pull request #27960 from demeritcowboy/showcms
dev/core#4736 - fix on-the-fly popup