civicrm-core.git
2 years agoMerge pull request #28408 from totten/master-sa-locdat
Rich Lott [Sat, 2 Dec 2023 17:35:17 +0000 (17:35 +0000)]
Merge pull request #28408 from totten/master-sa-locdat

LocalizedDataTest - Fix for standalone

2 years agoMerge pull request #28416 from braders/php8-activity-page-tab
demeritcowboy [Sat, 2 Dec 2023 17:31:54 +0000 (12:31 -0500)]
Merge pull request #28416 from braders/php8-activity-page-tab

[REF][PHP8.2] Declare properties in CRM_Activity_Page_Tab

2 years agoMerge pull request #28417 from braders/unused-job-property
demeritcowboy [Sat, 2 Dec 2023 17:12:48 +0000 (12:12 -0500)]
Merge pull request #28417 from braders/unused-job-property

[REF][PHP8.2] Remove unused dynamic property

2 years agoMerge pull request #28415 from vingle/a11y-accordions
colemanw [Sat, 2 Dec 2023 16:53:08 +0000 (16:53 +0000)]
Merge pull request #28415 from vingle/a11y-accordions

Adds an accessible accordion, applies to news-feed dashlet

2 years agoMerge pull request #28393 from eileenmcnaughton/suffix
colemanw [Sat, 2 Dec 2023 16:49:34 +0000 (16:49 +0000)]
Merge pull request #28393 from eileenmcnaughton/suffix

Add suffix to sort name

2 years agoMerge pull request #28413 from jaapjansma/staff_role_and_permissions
Mathieu Lu [Sat, 2 Dec 2023 16:21:18 +0000 (11:21 -0500)]
Merge pull request #28413 from jaapjansma/staff_role_and_permissions

dev/core#4466: added Standalone role and permissions for staff

2 years agoMerge pull request #28407 from greenpeace-cee/fix-standalone-jwt-cookie-test
Mathieu Lu [Sat, 2 Dec 2023 15:34:27 +0000 (10:34 -0500)]
Merge pull request #28407 from greenpeace-cee/fix-standalone-jwt-cookie-test

dev/core#2998 - Fix JWT cookie test in standalone

2 years agoMerge branch 'civicrm:master' into a11y-accordions
Nicol [Sat, 2 Dec 2023 15:33:05 +0000 (15:33 +0000)]
Merge branch 'civicrm:master' into a11y-accordions

2 years agoMerge pull request #28411 from artfulrobot/artfulrobot-standalone-extern-test
Tim Otten [Sat, 2 Dec 2023 15:29:09 +0000 (15:29 +0000)]
Merge pull request #28411 from artfulrobot/artfulrobot-standalone-extern-test

"Fix" test fail E2E_Extern_WidgetTest::testWidget by skipping it

2 years agodev/core#4466: added role and permissions for staff
Jaap Jansma [Sat, 2 Dec 2023 15:10:21 +0000 (16:10 +0100)]
dev/core#4466: added role and permissions for staff

2 years ago[REF][PHP8.2] Remove unused dynamic property
Bradley Taylor [Sat, 2 Dec 2023 14:33:25 +0000 (14:33 +0000)]
[REF][PHP8.2] Remove unused dynamic property

2 years ago[REF][PHP8.2] Declare properties in CRM_Activity_Page_Tab
Bradley Taylor [Sat, 2 Dec 2023 14:25:16 +0000 (14:25 +0000)]
[REF][PHP8.2] Declare properties in CRM_Activity_Page_Tab

2 years agoUpdate Blog.tpl
Nicol [Sat, 2 Dec 2023 13:58:20 +0000 (13:58 +0000)]
Update Blog.tpl

Removed unnecessary conditional/open

2 years agoMerge pull request #28412 from wmortada/standalone-roles
Rich Lott [Sat, 2 Dec 2023 13:08:57 +0000 (13:08 +0000)]
Merge pull request #28412 from wmortada/standalone-roles

Standalone - Add button to add user role

Merging as it works and is a good improvement! Thanks @wmortada

2 years agoUpdate Common.js
Nicol [Sat, 2 Dec 2023 13:05:02 +0000 (13:05 +0000)]
Update Common.js

Stop the accordion js from targetting <details><summary>

2 years agoStandalone - Add button to add user role
William Mortada [Sat, 2 Dec 2023 12:44:42 +0000 (12:44 +0000)]
Standalone - Add button to add user role

2 years ago"Fix" test fail E2E_Extern_WidgetTest::testWidget by skipping it
Rich Lott / Artful Robot [Sat, 2 Dec 2023 12:47:10 +0000 (12:47 +0000)]
"Fix" test fail E2E_Extern_WidgetTest::testWidget by skipping it

Drupal8+ does not support the extern widgets, so we do the same for standalone.

As agreed with @totten

2 years agoUpdate civicrm.css
Nicol [Sat, 2 Dec 2023 12:38:22 +0000 (12:38 +0000)]
Update civicrm.css

Updates CSS to remove expand/collapse icons from accordions using <details><summary> to avoid duplicated expand icon issue.

2 years agoLocalizedDataTest - Fix for standalone
Tim Otten [Sat, 2 Dec 2023 12:35:59 +0000 (12:35 +0000)]
LocalizedDataTest - Fix for standalone

2 years agoUpdate Blog.tpl
Nicol [Sat, 2 Dec 2023 12:34:39 +0000 (12:34 +0000)]
Update Blog.tpl

Uses <details><summary> to make accordions accessible.

2 years agoUpdate Blog.tpl
Nicol [Sat, 2 Dec 2023 12:32:05 +0000 (12:32 +0000)]
Update Blog.tpl

2 years agoMerge pull request #27292 from artfulrobot/artfulrobot-standalone-lcMessages
Mathieu Lu [Sat, 2 Dec 2023 12:20:50 +0000 (07:20 -0500)]
Merge pull request #27292 from artfulrobot/artfulrobot-standalone-lcMessages

dev/core#4425 Standalone: fix lcMessages not sticking; slightly lazy sessions

2 years agodev/core#2998 - Fix JWT cookie test in standalone
Patrick Figel [Sat, 2 Dec 2023 11:54:28 +0000 (11:54 +0000)]
dev/core#2998 - Fix JWT cookie test in standalone

This fixes a test failure in JwtCredsTest with standalone due to session
cookies being sent.

2 years agoMerge pull request #28402 from eileenmcnaughton/part_id
Eileen McNaughton [Sat, 2 Dec 2023 03:08:41 +0000 (16:08 +1300)]
Merge pull request #28402 from eileenmcnaughton/part_id

Add getParticipantID() to register

2 years agoAdd getParticipantID() to register
Eileen McNaughton [Sat, 2 Dec 2023 03:06:26 +0000 (16:06 +1300)]
Add getParticipantID() to register

2 years agoMerge pull request #28394 from eileenmcnaughton/member_template
demeritcowboy [Fri, 1 Dec 2023 23:57:47 +0000 (18:57 -0500)]
Merge pull request #28394 from eileenmcnaughton/member_template

Fix online membership receipt to be form-independent

2 years agoFix online membership receipt to be form-independent
Eileen McNaughton [Fri, 1 Dec 2023 06:11:49 +0000 (19:11 +1300)]
Fix online membership receipt to be form-independent

2 years agoMerge pull request #28400 from eileenmcnaughton/exist
Eileen McNaughton [Fri, 1 Dec 2023 23:15:01 +0000 (12:15 +1300)]
Merge pull request #28400 from eileenmcnaughton/exist

Fix type error (new in master)

2 years agoFix type error (new in master
Eileen McNaughton [Fri, 1 Dec 2023 22:20:53 +0000 (11:20 +1300)]
Fix type error (new in master

2 years agoMerge pull request #28392 from eileenmcnaughton/freeze
demeritcowboy [Fri, 1 Dec 2023 21:39:50 +0000 (16:39 -0500)]
Merge pull request #28392 from eileenmcnaughton/freeze

Fix for intermittent test fail on checksum time

2 years agoAdd suffix to sort name
Eileen McNaughton [Fri, 1 Dec 2023 03:37:12 +0000 (16:37 +1300)]
Add suffix to sort name

Revives https://github.com/civicrm/civicrm-core/pull/27114

2 years agoMerge pull request #28397 from braders/filegetcontents-properties
Eileen McNaughton [Fri, 1 Dec 2023 20:11:52 +0000 (09:11 +1300)]
Merge pull request #28397 from braders/filegetcontents-properties

[NFC] Pass correct param types to file_get_contents

2 years ago[NFC] Pass correct param types to file_get_contents
Bradley Taylor [Fri, 1 Dec 2023 18:56:15 +0000 (18:56 +0000)]
[NFC] Pass correct param types to file_get_contents

2 years agoMerge pull request #27777 from eileenmcnaughton/section_totals
demeritcowboy [Fri, 1 Dec 2023 14:30:12 +0000 (09:30 -0500)]
Merge pull request #27777 from eileenmcnaughton/section_totals

Smarty3 Mark sectionTotals smarty function deprecated

2 years agoMerge pull request #24699 from colemanw/afformConditional
colemanw [Fri, 1 Dec 2023 09:26:45 +0000 (09:26 +0000)]
Merge pull request #24699 from colemanw/afformConditional

Afform: Support conditional logic

2 years agoMerge pull request #28389 from eileenmcnaughton/membership_type_form
colemanw [Fri, 1 Dec 2023 09:14:15 +0000 (09:14 +0000)]
Merge pull request #28389 from eileenmcnaughton/membership_type_form

Use getSubmittedValues() rather than ad-hoc money 'cleaning' on membershipType form

2 years agoMerge pull request #28391 from eileenmcnaughton/sort_fix
Seamus Lee [Fri, 1 Dec 2023 06:23:22 +0000 (17:23 +1100)]
Merge pull request #28391 from eileenmcnaughton/sort_fix

[REF] Use Token Processor to generate sort name and display name for individuals

2 years ago[REF] Use Token Processor to generate sort name and display name for individuals
Seamus Lee [Thu, 2 Feb 2023 00:42:21 +0000 (11:42 +1100)]
[REF] Use Token Processor to generate sort name and display name for individuals

Fix handling for when certain things should only show if there tokens filled out

Handle for when the nameFormat is null (import tests)

2 years agoMerge pull request #27934 from MegaphoneJon/uncached-ext-dir-issue
Eileen McNaughton [Fri, 1 Dec 2023 03:30:43 +0000 (16:30 +1300)]
Merge pull request #27934 from MegaphoneJon/uncached-ext-dir-issue

set extension browser timeout to minimum of 10 seconds.

2 years agoMerge pull request #28390 from sebalis/contributors_civiservice
Eileen McNaughton [Fri, 1 Dec 2023 02:43:01 +0000 (15:43 +1300)]
Merge pull request #28390 from sebalis/contributors_civiservice

contributor_key.yml: add civiservice.de to four users, remove one duplicate

2 years agoFix for intermittent test fail on checksum time
Eileen McNaughton [Fri, 1 Dec 2023 02:39:15 +0000 (15:39 +1300)]
Fix for intermittent test fail on checksum time

2 years agoadd civiservice.de to four users, remove one duplicate
sebalis [Fri, 1 Dec 2023 01:16:06 +0000 (02:16 +0100)]
add civiservice.de to four users, remove one duplicate

2 years agoset extension browser timeout to minimum of 10 seconds.
Jon Goldberg [Wed, 25 Oct 2023 18:09:14 +0000 (14:09 -0400)]
set extension browser timeout to minimum of 10 seconds.

2 years agoUse getSubmittedValues() rather than ad-hoc money 'cleaning'
Eileen McNaughton [Fri, 1 Dec 2023 00:31:08 +0000 (13:31 +1300)]
Use getSubmittedValues() rather than ad-hoc money 'cleaning'

2 years agoMerge pull request #28384 from eileenmcnaughton/activity_type
Eileen McNaughton [Fri, 1 Dec 2023 00:19:11 +0000 (13:19 +1300)]
Merge pull request #28384 from eileenmcnaughton/activity_type

Remove some calls to deprecated function

2 years agoMerge pull request #28385 from eileenmcnaughton/member_required
Seamus Lee [Thu, 30 Nov 2023 22:38:07 +0000 (09:38 +1100)]
Merge pull request #28385 from eileenmcnaughton/member_required

Superficial cleanup

2 years agoRemove some calls to deprecated function
Eileen McNaughton [Thu, 30 Nov 2023 20:34:01 +0000 (09:34 +1300)]
Remove some calls to deprecated function

https://github.com/civicrm/civicrm-core/pull/23880 is
thoroughly stale so I'm closing it - but just thought I'd rescue a couple of changes

These are in the barely maintained legacycustomsearches so of marginal risk &
marginal benefit but since I looked maybe no-one else has to ever again...

2 years agoMerge pull request #28356 from eileenmcnaughton/membership_renew_notice
colemanw [Thu, 30 Nov 2023 21:41:17 +0000 (16:41 -0500)]
Merge pull request #28356 from eileenmcnaughton/membership_renew_notice

Fix notice, caching, master-only-regression- showing inactive fields on membership config

2 years agoMerge pull request #28364 from eileenmcnaughton/confirm_notice
colemanw [Thu, 30 Nov 2023 21:40:59 +0000 (16:40 -0500)]
Merge pull request #28364 from eileenmcnaughton/confirm_notice

Fix a whole lot of conditional assignments on confirm & thank you pages

2 years agoMerge pull request #28370 from eileenmcnaughton/payment_fields
colemanw [Thu, 30 Nov 2023 21:40:04 +0000 (16:40 -0500)]
Merge pull request #28370 from eileenmcnaughton/payment_fields

Fix notices on credit_card & bank number on Confirm & ThankYou

2 years agoSuperficial cleanup
Eileen McNaughton [Thu, 30 Nov 2023 21:18:25 +0000 (10:18 +1300)]
Superficial cleanup

Removes some unused variables & other minor cleanups

2 years agoMerge pull request #28383 from MegaphoneJon/activity-filter-case-speedup
Eileen McNaughton [Thu, 30 Nov 2023 20:08:06 +0000 (09:08 +1300)]
Merge pull request #28383 from MegaphoneJon/activity-filter-case-speedup

Activity case filter speedup

2 years agoMerge pull request #28382 from demeritcowboy/strstart
Eileen McNaughton [Thu, 30 Nov 2023 20:06:20 +0000 (09:06 +1300)]
Merge pull request #28382 from demeritcowboy/strstart

fix error on confirm page when using on-behalf-of

2 years agoActivity case filter speedup
Jon Goldberg [Thu, 30 Nov 2023 18:09:26 +0000 (13:09 -0500)]
Activity case filter speedup

2 years agoMerge pull request #28366 from eileenmcnaughton/membership
colemanw [Thu, 30 Nov 2023 17:28:40 +0000 (12:28 -0500)]
Merge pull request #28366 from eileenmcnaughton/membership

Unconditionally assign membership variables to fix notices on thankYou page

2 years agoMerge pull request #28381 from civicrm/5.68
demeritcowboy [Thu, 30 Nov 2023 15:14:40 +0000 (10:14 -0500)]
Merge pull request #28381 from civicrm/5.68

5.68

2 years agofix
demeritcowboy [Thu, 30 Nov 2023 15:12:32 +0000 (10:12 -0500)]
fix

2 years agoMerge pull request #28367 from eileenmcnaughton/behalf
demeritcowboy [Thu, 30 Nov 2023 15:09:31 +0000 (10:09 -0500)]
Merge pull request #28367 from eileenmcnaughton/behalf

Ensure onBehalfProfile assigned

2 years agoMerge pull request #28378 from eileenmcnaughton/contact
Yashodha Chaku [Thu, 30 Nov 2023 13:43:41 +0000 (19:13 +0530)]
Merge pull request #28378 from eileenmcnaughton/contact

dev/core#4820 fix contact id search

2 years agoMerge pull request #28354 from eileenmcnaughton/568_verp
Tim Otten [Thu, 30 Nov 2023 13:08:20 +0000 (13:08 +0000)]
Merge pull request #28354 from eileenmcnaughton/568_verp

Fix incoming bounce processing

2 years agoMerge pull request #28363 from reflexive-communications/codegen-drop-tpl
demeritcowboy [Thu, 30 Nov 2023 03:54:13 +0000 (22:54 -0500)]
Merge pull request #28363 from reflexive-communications/codegen-drop-tpl

CRM_Core_CodeGen_Schema: fix generated comments and whitespace

2 years agoMerge pull request #28320 from eileenmcnaughton/prem_3
colemanw [Thu, 30 Nov 2023 03:23:06 +0000 (22:23 -0500)]
Merge pull request #28320 from eileenmcnaughton/prem_3

Fix notices on premiums across all 3 pages

2 years agoMerge pull request #28377 from eileenmcnaughton/adv_search
demeritcowboy [Thu, 30 Nov 2023 03:21:02 +0000 (22:21 -0500)]
Merge pull request #28377 from eileenmcnaughton/adv_search

Fix notice, minor code cleanup with searching for a free text tag (advanced search)

2 years agoFix to still record empty amount levels for secondary contributions
Eileen McNaughton [Thu, 30 Nov 2023 02:12:03 +0000 (15:12 +1300)]
Fix to still record empty amount levels for secondary contributions

2 years agoMerge pull request #28368 from colemanw/booleanCleanup
Eileen McNaughton [Thu, 30 Nov 2023 00:29:32 +0000 (13:29 +1300)]
Merge pull request #28368 from colemanw/booleanCleanup

REF - Cleanup overly-verbose conditionals

2 years agoREF - Cleanup overly-verbose conditionals
colemanw [Wed, 29 Nov 2023 16:56:28 +0000 (11:56 -0500)]
REF - Cleanup overly-verbose conditionals

2 years agoFix a whole lot of conditional assignments on confirm & thank you pages
Eileen McNaughton [Wed, 29 Nov 2023 11:49:45 +0000 (00:49 +1300)]
Fix a whole lot of conditional assignments on confirm & thank you pages

2 years agodev/core#4820 fix contact id search
Eileen McNaughton [Wed, 29 Nov 2023 23:32:12 +0000 (12:32 +1300)]
dev/core#4820 fix contact id search

2 years agoUse single quotes where double not required
Eileen McNaughton [Wed, 29 Nov 2023 23:19:44 +0000 (12:19 +1300)]
Use single quotes where double not required

2 years agoSuppress notice
Eileen McNaughton [Wed, 29 Nov 2023 23:14:34 +0000 (12:14 +1300)]
Suppress notice

2 years agoMerge pull request #28376 from civicrm/5.68
Eileen McNaughton [Wed, 29 Nov 2023 23:10:35 +0000 (12:10 +1300)]
Merge pull request #28376 from civicrm/5.68

5.68 to master

2 years agoRemove unnecessary pass-by-ref
Eileen McNaughton [Wed, 29 Nov 2023 23:09:19 +0000 (12:09 +1300)]
Remove unnecessary pass-by-ref

2 years agoMerge pull request #28375 from demeritcowboy/relimp
Eileen McNaughton [Wed, 29 Nov 2023 22:57:12 +0000 (11:57 +1300)]
Merge pull request #28375 from demeritcowboy/relimp

dev/core#4563 - fix related contact mapping fields on import

2 years agoMerge pull request #28374 from eileenmcnaughton/cont_page
Eileen McNaughton [Wed, 29 Nov 2023 22:33:37 +0000 (11:33 +1300)]
Merge pull request #28374 from eileenmcnaughton/cont_page

Fix quotes causing function call to be in quotes (master only regression)

2 years agoMerge pull request #28361 from eileenmcnaughton/current_member
Eileen McNaughton [Wed, 29 Nov 2023 22:21:56 +0000 (11:21 +1300)]
Merge pull request #28361 from eileenmcnaughton/current_member

Fix master-only regression on Membership page, option not selected

2 years agoMerge pull request #28373 from eileenmcnaughton/bool
Eileen McNaughton [Wed, 29 Nov 2023 22:12:41 +0000 (11:12 +1300)]
Merge pull request #28373 from eileenmcnaughton/bool

REF - Cleanup overly-verbose conditionals

2 years agoMerge pull request #28348 from Damilare1/master
Eileen McNaughton [Wed, 29 Nov 2023 22:12:24 +0000 (11:12 +1300)]
Merge pull request #28348 from Damilare1/master

Coworker create Searchkit over view of queue status

2 years agoApi - Fix premium & product permissions for anonymous users
colemanw [Wed, 29 Nov 2023 22:02:41 +0000 (17:02 -0500)]
Api - Fix premium & product permissions for anonymous users

2 years agofix related contact mapping fields
demeritcowboy [Wed, 29 Nov 2023 21:48:37 +0000 (16:48 -0500)]
fix related contact mapping fields

2 years agoFix quotes causing function call to be in quotes
Eileen McNaughton [Wed, 29 Nov 2023 21:40:08 +0000 (10:40 +1300)]
Fix quotes causing function call to be in quotes

2 years agoFix failure to set membership default to existing membership (master regression)
Eileen McNaughton [Wed, 29 Nov 2023 11:08:05 +0000 (00:08 +1300)]
Fix failure to set membership default to existing membership (master regression)

2 years agoREF - Cleanup overly-verbose conditionals
Eileen McNaughton [Wed, 29 Nov 2023 21:26:43 +0000 (10:26 +1300)]
REF - Cleanup overly-verbose conditionals

2 years agoMerge pull request #28372 from civicrm/5.68
Eileen McNaughton [Wed, 29 Nov 2023 21:17:31 +0000 (10:17 +1300)]
Merge pull request #28372 from civicrm/5.68

5.68 to master

2 years agoMerge pull request #28371 from mlutfy/568fixNumericCaseCustom
Eileen McNaughton [Wed, 29 Nov 2023 21:16:42 +0000 (10:16 +1300)]
Merge pull request #28371 from mlutfy/568fixNumericCaseCustom

Case Custom Data: fix non-US numeric decimals - 5.68

2 years agoFix notices on premiums across all 3 pages
Eileen McNaughton [Sun, 26 Nov 2023 19:56:28 +0000 (08:56 +1300)]
Fix notices on premiums across all 3 pages

This includes switching to apiv4 & adding escape to the templates
to reflect that change

2 years agoMerge pull request #28339 from colemanw/inlineArray
Eileen McNaughton [Wed, 29 Nov 2023 20:16:09 +0000 (09:16 +1300)]
Merge pull request #28339 from colemanw/inlineArray

[NFC] Array formatting cleanup

2 years agoMerge pull request #28316 from eileenmcnaughton/prem_2
colemanw [Wed, 29 Nov 2023 20:10:23 +0000 (15:10 -0500)]
Merge pull request #28316 from eileenmcnaughton/prem_2

Check financial acls for product in extension

2 years agoCase Custom Data: fix non-US numeric decimals
Mathieu Lu [Wed, 29 Nov 2023 19:39:39 +0000 (14:39 -0500)]
Case Custom Data: fix non-US numeric decimals

2 years agoFix notices on credit_card & bank number on Confirm & ThankYou
Eileen McNaughton [Wed, 29 Nov 2023 19:43:19 +0000 (08:43 +1300)]
Fix notices on credit_card & bank number on Confirm & ThankYou

2 years agoUpdate ext/civicrm_admin_ui/ang/afsearchCiviCRMQueues.aff.php
Adedoyin Damilare [Wed, 29 Nov 2023 19:40:22 +0000 (19:40 +0000)]
Update ext/civicrm_admin_ui/ang/afsearchCiviCRMQueues.aff.php

Co-authored-by: colemanw <coleman@civicrm.org>
2 years agoMerge pull request #28332 from eileenmcnaughton/import_ug
colemanw [Wed, 29 Nov 2023 18:13:12 +0000 (13:13 -0500)]
Merge pull request #28332 from eileenmcnaughton/import_ug

dev/core#4726 Set field to do-not-import if not configured

2 years agoArray formatting cleanup
colemanw [Tue, 28 Nov 2023 15:27:22 +0000 (10:27 -0500)]
Array formatting cleanup

Multiline arrays aren't always the most readable.
These were all done by an autoformatting tool which got a little too zealous
about breaking every array into multiple lines. They are especially silly within if() statements.

2 years agoMerge pull request #28336 from eileenmcnaughton/part_form
colemanw [Wed, 29 Nov 2023 15:21:42 +0000 (10:21 -0500)]
Merge pull request #28336 from eileenmcnaughton/part_form

Remove handling from previously shared code

2 years agoMerge pull request #28365 from eileenmcnaughton/confirm_notices
colemanw [Wed, 29 Nov 2023 15:20:25 +0000 (10:20 -0500)]
Merge pull request #28365 from eileenmcnaughton/confirm_notices

Ensure onBehalfEmail always assigned to prevent notices

2 years agoCoworker create Searchkit over view of queue status
Damilare Adedoyin [Tue, 28 Nov 2023 16:26:48 +0000 (16:26 +0000)]
Coworker create Searchkit over view of queue status

2 years agoMerge pull request #28360 from eileenmcnaughton/code
colemanw [Wed, 29 Nov 2023 14:21:13 +0000 (09:21 -0500)]
Merge pull request #28360 from eileenmcnaughton/code

Remove unreachable code

2 years agoFix style
Rich Lott / Artful Robot [Wed, 29 Nov 2023 13:23:11 +0000 (13:23 +0000)]
Fix style

2 years agoEnsure onBehalfProfile assigned
Eileen McNaughton [Wed, 29 Nov 2023 12:54:20 +0000 (01:54 +1300)]
Ensure onBehalfProfile assigned

2 years agodev/core#4425 standalone: fix lcMessages not sticking; lazy sessions
Rich Lott / Artful Robot [Wed, 29 Nov 2023 12:51:32 +0000 (12:51 +0000)]
dev/core#4425 standalone: fix lcMessages not sticking; lazy sessions

2 years agoUnconditionally assign membership variables to fix notices on thankYou page
Eileen McNaughton [Wed, 29 Nov 2023 12:48:15 +0000 (01:48 +1300)]
Unconditionally assign membership variables to fix notices on thankYou page