Eileen McNaughton [Fri, 17 Jun 2022 00:11:12 +0000 (12:11 +1200)]
dev/core#3663 fix output regression on csv output
This fixes a very-recent rc regression whereby the file error output was
not correctly referring to the fields to be exported.
Note that in order to make it testable I had to
- remove header-setting that duplicates work done by the csv package
- remove extraneous echos in the GenCode
Tim Otten [Thu, 16 Jun 2022 01:03:59 +0000 (18:03 -0700)]
Merge pull request #23801 from eileenmcnaughton/cont_work
Fix breakage in message preview on workflow contributions
Monish Deb [Wed, 15 Jun 2022 14:43:43 +0000 (20:13 +0530)]
Merge pull request #23805 from mattwire/devfinancial197alt
dev/financial#197 Revert freezing on total_amount field on recurring form (alt to #23796)
Matthew Wire [Wed, 15 Jun 2022 11:21:39 +0000 (12:21 +0100)]
Revert freezing on total_amount field on recurring form
Monish Deb [Wed, 15 Jun 2022 11:19:47 +0000 (16:49 +0530)]
Merge pull request #23798 from seamuslee001/fix_auto_renew_membership
Fix Automatic renewal membership from front end contribution forms
Eileen McNaughton [Wed, 15 Jun 2022 03:44:52 +0000 (15:44 +1200)]
Fix breakage in message preview on workflow contributions
Seamus Lee [Tue, 14 Jun 2022 23:49:26 +0000 (09:49 +1000)]
[REF] Fix Automatic renewal membership from front end contribution forms
Properly fix regression and update unit tests to match what the form does
Tim Otten [Tue, 14 Jun 2022 21:11:43 +0000 (14:11 -0700)]
Merge pull request #23785 from totten/5.51-hook-log
dev/core#3502 - CiviEventDispatcher - Softer errors for not-ready. More comments.
colemanw [Tue, 14 Jun 2022 20:13:04 +0000 (16:13 -0400)]
Merge pull request #23753 from eileenmcnaughton/import_validate_int
Add integer validation to import
colemanw [Tue, 14 Jun 2022 20:12:21 +0000 (16:12 -0400)]
Merge pull request #23763 from eileenmcnaughton/act_test
Fix target contact label back to include target
colemanw [Tue, 14 Jun 2022 20:11:37 +0000 (16:11 -0400)]
Merge pull request #23764 from eileenmcnaughton/activity_update_mutli
dev/core#2706 dev/core#2308 fix activity import to update multi-select fields
Eileen McNaughton [Tue, 14 Jun 2022 20:08:40 +0000 (08:08 +1200)]
Merge pull request #23788 from ufundo/5.51
only check batch currency match when adding a financial_trxn
demeritcowboy [Tue, 14 Jun 2022 17:12:47 +0000 (13:12 -0400)]
Merge pull request #23786 from mattwire/devfinancial199
dev/financial#199 Fix additional details on edit template contribution
Matthew Wire [Tue, 14 Jun 2022 14:45:13 +0000 (15:45 +0100)]
Fix additional details on edit template contribution
ufundo [Thu, 9 Jun 2022 16:29:32 +0000 (16:29 +0000)]
only check batch currency match when adding a financial_trxn
Tim Otten [Thu, 9 Jun 2022 04:17:51 +0000 (21:17 -0700)]
dev/core#3502 - CiviEventDispatcher - Tune down the warning
Tim Otten [Thu, 9 Jun 2022 02:14:04 +0000 (19:14 -0700)]
dev/core#3502 - CiviEventDispatcher - Tweak error message. Add explanation.
Eileen McNaughton [Tue, 14 Jun 2022 03:58:59 +0000 (15:58 +1200)]
Merge pull request #23783 from totten/5.51-snapshots
FiveFiftyOne - Enable snapshots for data modified data
Tim Otten [Tue, 14 Jun 2022 02:06:05 +0000 (19:06 -0700)]
FiveFiftyOne - Enable snapshots for data modified data
Before
------
The 5.51.alpha upgrade modifies a some data-structures (`civicrm_mapping_*`, `civicrm_queue`),
but it doesn't take any snapshots.
After
-----
It does snapshots.
Comments
--------
Both tables should generally be quite small.
Strictly, the `civicrm_mapping_*` updates are more in-place modifications,
so that's more important. The `civicrm_queue` changes are only adding new
columns. But the table is so small - it doesn't hurt.
I suppose one could argue that these particular fields aren't likely to have
problems - but it's important to get in the habit of enabling snapshots so
that we have them when they do matter.
Eileen McNaughton [Tue, 14 Jun 2022 00:00:29 +0000 (12:00 +1200)]
Merge pull request #23771 from eileenmcnaughton/cont_update
dev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces in names
Eileen McNaughton [Mon, 13 Jun 2022 22:19:02 +0000 (10:19 +1200)]
Merge pull request #23780 from totten/5.51-hush
(dev/core#3653) CRM_Queue_Runner - Fix upgrade warnings. Extract disableBackgroundExecution().
Tim Otten [Mon, 13 Jun 2022 20:34:06 +0000 (13:34 -0700)]
Merge pull request #23766 from eileenmcnaughton/cont_up
dev/core#3513 Remove 'done' from sumary/import monitoring page
Tim Otten [Mon, 13 Jun 2022 19:55:51 +0000 (12:55 -0700)]
CRM_Queue_Runner - Fix upgrade warnings. Extract disableBackgroundExecution().
This is a revision to #23775. As before, it prevents a hard error when
upgrading to 5.51. However, the try-catch produces confusing error messages
in the `CiviCRM.log.*` (ie they indicate a SQL error, but the situation is
actually a normal/expected during upgrade). This avoids the error messages.
Tested (`r-run`) with `civicrm/upgrade`, `drush civicrm-upgrade-db`, and `cv
upgrade:db` -- for both 5.45=>5.51 and 5.45=>5.49=>5.51.
Eileen McNaughton [Mon, 13 Jun 2022 06:01:48 +0000 (18:01 +1200)]
Merge pull request #23777 from darrick/fix_import_disableUSPS
fix disableUSPS since import running in separate context of Queue.
Darrick Servis [Sat, 11 Jun 2022 22:53:56 +0000 (15:53 -0700)]
fix disableUSPS since import running in separate context of Queue.
demeritcowboy [Mon, 13 Jun 2022 00:54:20 +0000 (20:54 -0400)]
Merge pull request #23775 from eileenmcnaughton/5.51
dev/core#3653 Fix on queue runner not working in upgrade
Eileen McNaughton [Sun, 12 Jun 2022 22:13:07 +0000 (10:13 +1200)]
dev/core#3653 Fix on queue runner not working in upgrade
Eileen McNaughton [Sun, 12 Jun 2022 06:03:38 +0000 (18:03 +1200)]
Merge pull request #23772 from eileenmcnaughton/cont_contact_fields
Fix import regression - contribution import borks on do_not_import
Eileen McNaughton [Sun, 12 Jun 2022 00:29:37 +0000 (12:29 +1200)]
Merge pull request #23757 from colemanw/dupeFixAgain
Deduepe - Fix form buttons (again)
Eileen McNaughton [Sat, 11 Jun 2022 23:36:09 +0000 (11:36 +1200)]
dev/core#3651 dev/core#1337 Fix failure to show last column data in output, spaces in names
Eileen McNaughton [Sun, 12 Jun 2022 00:21:18 +0000 (12:21 +1200)]
Fix import regression - contribution import borks on do_not_import
Eileen McNaughton [Sat, 11 Jun 2022 02:59:20 +0000 (14:59 +1200)]
dev/core#3513 Remove 'done' from sumary/import monitoring page
See dev/core#3513 for why it's confusing
demeritcowboy [Sat, 11 Jun 2022 19:38:42 +0000 (15:38 -0400)]
Merge pull request #23759 from colemanw/fixTotalCount
[REGRESSION] SearchKit - Fix angular console error when totalCount is not given
demeritcowboy [Sat, 11 Jun 2022 19:19:38 +0000 (15:19 -0400)]
Merge pull request #23754 from eileenmcnaughton/act_date
dev/core#2325 import second-handling fix
colemanw [Sat, 11 Jun 2022 15:41:21 +0000 (11:41 -0400)]
Merge pull request #23765 from eileenmcnaughton/guzzle_it
Catch & convert Guzzle exception
demeritcowboy [Sat, 11 Jun 2022 15:37:01 +0000 (11:37 -0400)]
Merge pull request #23758 from colemanw/noCiviGrant
Setup - Remove CiviGrant from available components
colemanw [Sat, 11 Jun 2022 14:11:06 +0000 (10:11 -0400)]
Merge pull request #23760 from eileenmcnaughton/validate_fields
dev/core#3511 Improve handling of invalid saved mapping fields
colemanw [Sat, 11 Jun 2022 13:56:47 +0000 (09:56 -0400)]
Merge pull request #23761 from eileenmcnaughton/invalid_state_with_country
dev/core#3512 fix rc fatal error when state is invalid
Coleman Watts [Fri, 10 Jun 2022 16:25:32 +0000 (12:25 -0400)]
Setup - Remove CiviGrant from available components
Fixes dev/core#3485
Coleman Watts [Fri, 10 Jun 2022 16:37:56 +0000 (12:37 -0400)]
SearchKit - Fix angular console error when totalCount is not given
Before: Error: [$compile:nonassign] Expression 'undefined' in attribute 'totalCount' used with directive 'crmSearchDisplayTable' is non-assignable!
After: Fixed, and totalCount still functions correctly for its indended purpose with SearchSegments.
Coleman Watts [Fri, 10 Jun 2022 16:08:52 +0000 (12:08 -0400)]
Deduepe - Fix form buttons (again)
Fixes dev/core#3421
Also see dev/core#3135
And the original cause:
a6f2a80
Eileen McNaughton [Sat, 11 Jun 2022 01:25:36 +0000 (13:25 +1200)]
Catch & convert Guzzle exception
Eileen McNaughton [Fri, 10 Jun 2022 23:57:49 +0000 (11:57 +1200)]
dev/core#2706 fix activity import to update multi-select fields
Eileen McNaughton [Fri, 10 Jun 2022 23:27:53 +0000 (11:27 +1200)]
Fix target contact label back to include target
Eileen McNaughton [Fri, 10 Jun 2022 06:50:53 +0000 (18:50 +1200)]
dev/core#2325 import second-handling fix
Eileen McNaughton [Fri, 10 Jun 2022 23:09:20 +0000 (11:09 +1200)]
dev/core#3512 fix rc fatal error when state is invalid
Eileen McNaughton [Fri, 10 Jun 2022 22:27:34 +0000 (10:27 +1200)]
dev/core#3511 Improve handling of invalid saved mapping fields
Tim Otten [Fri, 10 Jun 2022 22:27:59 +0000 (15:27 -0700)]
Merge pull request #23756 from eileenmcnaughton/import_to_group
dev/core#3160 fix inability to import 'just contactid' and add to group
Tim Otten [Fri, 10 Jun 2022 21:58:48 +0000 (14:58 -0700)]
Merge pull request #23755 from eileenmcnaughton/import_ivory_coast
dev/core#3505, dev/core#3506 dev/core#3052 Import fixes for unicode url, Côte d’Ivoire
Eileen McNaughton [Fri, 10 Jun 2022 09:59:25 +0000 (21:59 +1200)]
dev/core#3160 fix inability to import 'just contactid' and add to group
Eileen McNaughton [Fri, 10 Jun 2022 08:32:46 +0000 (20:32 +1200)]
dev/core#3505, dev/core#3506 Import fixes for unicode url, Côte d’Ivoire
CiviCRM [Fri, 10 Jun 2022 07:34:02 +0000 (07:34 +0000)]
Set version to 5.51.beta1
Tim Otten [Fri, 10 Jun 2022 07:29:23 +0000 (00:29 -0700)]
Merge pull request #23747 from eileenmcnaughton/import_contribution
Remove some more unused code
Eileen McNaughton [Fri, 10 Jun 2022 07:09:23 +0000 (19:09 +1200)]
Add integer validation to import
Seamus Lee [Fri, 10 Jun 2022 06:41:36 +0000 (16:41 +1000)]
Merge pull request #23750 from eileenmcnaughton/test_cruft
Reduce test output spam
Seamus Lee [Fri, 10 Jun 2022 06:41:18 +0000 (16:41 +1000)]
Merge pull request #23748 from eileenmcnaughton/guzzle
Update guzzle to 6.5.7
Eileen McNaughton [Fri, 10 Jun 2022 01:05:36 +0000 (13:05 +1200)]
Remove some more unused code
Eileen McNaughton [Fri, 10 Jun 2022 04:51:53 +0000 (16:51 +1200)]
Merge pull request #23751 from eileenmcnaughton/test_member
Fix for failing test in master
Eileen McNaughton [Fri, 10 Jun 2022 03:31:58 +0000 (15:31 +1200)]
Merge pull request #23746 from totten/master-queue-flag
CRM_Queue_Runner - Add basic/skeletal support for `runAllInteractively()`
Eileen McNaughton [Fri, 10 Jun 2022 03:00:25 +0000 (15:00 +1200)]
Merge pull request #23679 from totten/master-queue-tpl-inclusive
Civi::queue() - Add support for 'template' queues
Eileen McNaughton [Fri, 10 Jun 2022 02:59:43 +0000 (14:59 +1200)]
Merge pull request #23744 from eileenmcnaughton/import_csv
Fix unrelease regression - malformed MapField without skipColumnHeaders
Eileen McNaughton [Fri, 10 Jun 2022 02:06:46 +0000 (14:06 +1200)]
Fix for failing test in master
Eileen McNaughton [Fri, 10 Jun 2022 01:40:38 +0000 (13:40 +1200)]
Merge pull request #23745 from eileenmcnaughton/obsolete_activity
Remove obsolete/unused code, fix notices - activity import
Eileen McNaughton [Fri, 10 Jun 2022 01:39:57 +0000 (13:39 +1200)]
Merge pull request #23743 from totten/master-queue-runas
CRM_Queue_Task - Track an optional `$runAs` property
Eileen McNaughton [Fri, 10 Jun 2022 01:25:21 +0000 (13:25 +1200)]
Reduce test output spam
Eileen McNaughton [Fri, 10 Jun 2022 01:08:19 +0000 (13:08 +1200)]
Update guzzle to 6.5.7
Eileen McNaughton [Thu, 9 Jun 2022 23:01:33 +0000 (11:01 +1200)]
Fix unrelease regression - malformed MapField without skipColumnHeaders
Eileen McNaughton [Thu, 9 Jun 2022 23:17:29 +0000 (11:17 +1200)]
Remove obsolete/unused code - activity import
Eileen McNaughton [Thu, 9 Jun 2022 23:57:05 +0000 (11:57 +1200)]
Merge pull request #23742 from eileenmcnaughton/import_remove
Remove more obsolete import code
Tim Otten [Tue, 7 Jun 2022 10:32:31 +0000 (03:32 -0700)]
demoqueue - Switch from `runAllViaWeb()` to `runAllInteractive()`
Tim Otten [Tue, 7 Jun 2022 06:12:47 +0000 (23:12 -0700)]
Implement runAllInteractive and assertRequirements*
Tim Otten [Tue, 7 Jun 2022 02:36:12 +0000 (19:36 -0700)]
CRM_Queue_Runner - runAllViaWeb should run exclusively via web
This is a preventative measure.
Tim Otten [Sat, 4 Jun 2022 08:09:42 +0000 (01:09 -0700)]
civicrm/queue/monitor - Add skeletal page for monitoring status
Tim Otten [Tue, 7 Jun 2022 00:31:57 +0000 (17:31 -0700)]
crmQueueMonitor - Skeletal module
Tim Otten [Sat, 4 Jun 2022 04:44:35 +0000 (21:44 -0700)]
Add experimental setting `enableBackgroundQueue`
Tim Otten [Tue, 7 Jun 2022 01:36:09 +0000 (18:36 -0700)]
CRM_Queue_Runner - Conditionally inherit the queue's error-policy
Eileen McNaughton [Thu, 9 Jun 2022 23:40:20 +0000 (11:40 +1200)]
Fix test fatal
Eileen McNaughton [Thu, 9 Jun 2022 22:32:23 +0000 (10:32 +1200)]
Remove more obsolete import code
Tim Otten [Thu, 9 Jun 2022 23:32:45 +0000 (16:32 -0700)]
UserJob - Add property `is_template`
Eileen requested, and it's easiest to add now, and it seems safe+consistent.
Tim Otten [Fri, 3 Jun 2022 01:14:41 +0000 (18:14 -0700)]
Civi::queue() - Add support for 'template' queues
Overview
--------
Suppose you are in the habit of making separate queue-instances for
different batches of work. However, you want to allow the sysadmin to
configure options like `type`, `batch_limit`, and `retry_interval`.
Solution: Make a template
After
-----
```php
// Use the API to register a template, eg
\Civi\Api4\Queue::create()->setValues([
'name' => 'template-name',
'is_template' => TRUE,
...
])->execute();
// Later, create a queue from the template
$q = Civi::queue('new-queue', ['template' => 'template-name']);
```
Tim Otten [Thu, 9 Jun 2022 23:09:43 +0000 (16:09 -0700)]
Queue - Add column `is_template`
Tim Otten [Wed, 27 Oct 2021 07:12:50 +0000 (00:12 -0700)]
CRM_Queue_Task - Track an optional `$runAs` property
Seamus Lee [Thu, 9 Jun 2022 22:46:40 +0000 (08:46 +1000)]
Merge pull request #23740 from eileenmcnaughton/import_unused
Remove unused functions
colemanw [Thu, 9 Jun 2022 21:20:08 +0000 (17:20 -0400)]
Merge pull request #23737 from eileenmcnaughton/import_up_multi
Add upgrade for label to name conversion in `civicrm_mapping_field` for multiple custom imports
colemanw [Thu, 9 Jun 2022 21:17:31 +0000 (17:17 -0400)]
Merge pull request #23712 from eileenmcnaughton/import_queue
Enable QueueRunner for all imports
Eileen McNaughton [Thu, 9 Jun 2022 08:45:25 +0000 (20:45 +1200)]
Merge pull request #23736 from eileenmcnaughton/import_multi
dev/core#3498 Fix mishandled option values
Eileen McNaughton [Thu, 9 Jun 2022 07:13:03 +0000 (19:13 +1200)]
Add missing test file
Eileen McNaughton [Thu, 9 Jun 2022 06:29:50 +0000 (18:29 +1200)]
Remove unused functions
These used to be called from run - which is gone itself now
Eileen McNaughton [Tue, 7 Jun 2022 22:58:22 +0000 (10:58 +1200)]
Update test for runner
Eileen McNaughton [Tue, 7 Jun 2022 11:39:53 +0000 (23:39 +1200)]
Enable QueueRunner for membership import
Eileen McNaughton [Thu, 9 Jun 2022 03:49:03 +0000 (15:49 +1200)]
Add upgrade for label to name conversion
It wouldn't be that much more to go further & use the group.fieldname format - ....
Add upgrade script to convert saved field mappings to use names
Eileen McNaughton [Thu, 9 Jun 2022 03:32:11 +0000 (15:32 +1200)]
Extra fix to headerPatterns so fields 'guess' better
Eileen McNaughton [Thu, 9 Jun 2022 03:18:48 +0000 (15:18 +1200)]
dev/core#3498 Fix mishandled option values
Eileen McNaughton [Thu, 9 Jun 2022 04:20:32 +0000 (16:20 +1200)]
Merge pull request #23734 from eileenmcnaughton/import_custom
Fix test to validate forms & remove some unused code
Eileen McNaughton [Thu, 9 Jun 2022 02:05:35 +0000 (14:05 +1200)]
Merge pull request #23735 from colemanw/afformTriggerSuccess
Afform - Trigger 'crmFormSuccess' event after submission
Eileen McNaughton [Thu, 9 Jun 2022 01:35:56 +0000 (13:35 +1200)]
Merge pull request #23656 from colemanw/afformOptions
Afform - allow ids to be passed directly into the directive
Eileen McNaughton [Thu, 9 Jun 2022 01:32:40 +0000 (13:32 +1200)]
Merge pull request #23655 from colemanw/searchKitFixJoinAgain
SearchKit - Remove confusing extra joins between Contact & Related Contacts
Eileen McNaughton [Thu, 9 Jun 2022 00:43:48 +0000 (12:43 +1200)]
Fix some a couple of places where form variables were passed, remove a couple more things
Eileen McNaughton [Thu, 9 Jun 2022 00:27:04 +0000 (12:27 +1200)]
Fix test to validate forms & remove some unused code
Eileen McNaughton [Thu, 9 Jun 2022 00:54:38 +0000 (12:54 +1200)]
Merge pull request #23733 from eileenmcnaughton/import_part
Participant import fix - broken uniqueName fields, mapping saving, ev…