Monish Deb [Mon, 24 May 2021 06:44:01 +0000 (12:14 +0530)]
Merge pull request #20391 from eileenmcnaughton/tax_valid
Add call to validateAllContributions & fix getTotalAmount
Eileen McNaughton [Mon, 24 May 2021 02:29:04 +0000 (14:29 +1200)]
Add call to validateAllContributions & fix getTotalAmount
I've updated 2 tests for readability and extended one to call
validateAllContributions. The call failed and it turned out to
be the check was wrong. Fixing that caused a test to fail.
I have fixed the test by fixing getTotalAmount on the internal
helper BAO_Order class to include the tax_amount for each line
in the total.
I think this would most affect tests - but it might affect the
Membership_Form due to changes made recently to that
form so I'm on the fence about going for the rc with this
one
Monish Deb [Mon, 24 May 2021 04:24:10 +0000 (09:54 +0530)]
Merge pull request #20358 from eileenmcnaughton/partial
Remove legacy references to partial_amount_to_pay
Seamus Lee [Mon, 24 May 2021 03:27:52 +0000 (13:27 +1000)]
Merge pull request #20389 from eileenmcnaughton/tax
[NFC] {test} code cleanup in test class
Eileen McNaughton [Sun, 23 May 2021 23:54:39 +0000 (11:54 +1200)]
[NFC] {test} minor cleanup
Eileen McNaughton [Mon, 24 May 2021 01:27:44 +0000 (13:27 +1200)]
Merge pull request #20387 from eileenmcnaughton/tax
[NFC] Minor cleanup
Eileen McNaughton [Mon, 24 May 2021 00:37:14 +0000 (12:37 +1200)]
Merge pull request #20386 from eileenmcnaughton/cont_f
[NFC] Minor code cleanup
Seamus Lee [Sun, 23 May 2021 23:46:14 +0000 (09:46 +1000)]
Merge pull request #20370 from seamuslee001/phpunit8
Use PHPUnit8 in main test suites
Eileen McNaughton [Sun, 23 May 2021 23:18:44 +0000 (11:18 +1200)]
[NFC] Minor cleanup
Eileen McNaughton [Sun, 23 May 2021 23:08:06 +0000 (11:08 +1200)]
[NFC] Minor code cleanup
Eileen McNaughton [Sun, 23 May 2021 21:59:57 +0000 (09:59 +1200)]
Merge pull request #20384 from mattwire/deprecateddopayment
If paymentprocessor still uses doTransferCheckout/doDirectPayment trigger deprecated function warning
Matthew Wire [Sun, 23 May 2021 10:26:13 +0000 (11:26 +0100)]
If paymentprocessor still uses doTransferCheckout/doDirectPayment trigger deprecated function warning
Seamus Lee [Thu, 20 May 2021 23:50:52 +0000 (09:50 +1000)]
Use PHPUnit8 for main runs
Eileen McNaughton [Sun, 23 May 2021 07:30:47 +0000 (19:30 +1200)]
Merge pull request #20380 from seamuslee001/api_v3_civi_phpunit8_warnings
[NFC] Fix PHPUnit8 Deprecation Warnings in api_v3 and Civi Test Suites
Seamus Lee [Sat, 22 May 2021 04:20:56 +0000 (14:20 +1000)]
[NFC] Fix PHPUnit8 Deprecation Warnings in api_v3 and Civi Test Suites
Seamus Lee [Sat, 22 May 2021 21:33:29 +0000 (07:33 +1000)]
Merge pull request #20373 from eileenmcnaughton/gc
[REF] extract function to get locks
Seamus Lee [Sat, 22 May 2021 07:12:56 +0000 (17:12 +1000)]
Merge pull request #20374 from eileenmcnaughton/gc4
[NFC] [Test] Big cleanup in test class
Seamus Lee [Sat, 22 May 2021 06:35:11 +0000 (16:35 +1000)]
Merge pull request #20381 from seamuslee001/api_v4_phpunit8_warnings
[NFC] Fix PHPUnit8 Deprecation warnings in the api_v4 Test Suite
Seamus Lee [Sat, 22 May 2021 05:56:15 +0000 (15:56 +1000)]
Merge pull request #20379 from seamuslee001/e2e_phpunit8_warnings
[NFC] Fix PHPUnit8 Warning notices in E2E And in some API unit tests
Eileen McNaughton [Fri, 21 May 2021 07:07:14 +0000 (19:07 +1200)]
[NFC] [Test] Big cleanup in test class
Eileen McNaughton [Sat, 22 May 2021 05:28:28 +0000 (17:28 +1200)]
Merge pull request #20378 from eileenmcnaughton/entry
[REF] Remove unused variable
Seamus Lee [Sat, 22 May 2021 04:48:08 +0000 (14:48 +1000)]
[NFC] Fix PHPUnit8 Deprecation warnings in the api_v4 Test Suite
Seamus Lee [Sat, 22 May 2021 02:44:06 +0000 (12:44 +1000)]
Further fixes
Seamus Lee [Sat, 22 May 2021 00:28:04 +0000 (10:28 +1000)]
Fix PHPUnit8 Warning notices in E2E And in some API unit tests
Seamus Lee [Sat, 22 May 2021 01:57:11 +0000 (11:57 +1000)]
Merge pull request #20377 from seamuslee001/crm_phpunit8_warnings
[NFC] Fix PHPUnit8 deprecation warnings in the CRM_AllTests suite
Seamus Lee [Fri, 21 May 2021 22:33:18 +0000 (08:33 +1000)]
[NFC] Fix PHPUnit8 deprecation warnings in the CRM_AllTests suite
Eileen McNaughton [Fri, 21 May 2021 23:03:11 +0000 (11:03 +1200)]
[REF] Remove unused field parameters
Eileen McNaughton [Fri, 21 May 2021 05:52:38 +0000 (17:52 +1200)]
[REF] extract function to get locks
This is part of trying to make the logic more re-usable and make the
way of dealing with a single group more aligned with dealing with
multiple groups in this class
colemanw [Fri, 21 May 2021 18:19:44 +0000 (14:19 -0400)]
Merge pull request #20305 from seamuslee001/afformEntityRefSubmit
Afform Entity Reference Submit
Coleman Watts [Fri, 21 May 2021 00:10:37 +0000 (20:10 -0400)]
Afform - Simplify postprocess event, cleanup api code & improve test coverage
- Simplifies getEntityWeights function using topological sorting library
- Consolodates postprocess event listners to just processGenericEntity
- Adds missing getters/setters to api classes
- Improves the AfformSubmitEvent interface to make it easeier to use
- Adds to tests
Seamus Lee [Fri, 21 May 2021 05:55:15 +0000 (15:55 +1000)]
Merge pull request #20372 from eileenmcnaughton/tax
[NFC] Further cleanup in test class
Eileen McNaughton [Fri, 21 May 2021 01:17:28 +0000 (13:17 +1200)]
[NFC] Further cleanup in test class
Seamus Lee [Fri, 21 May 2021 01:45:36 +0000 (11:45 +1000)]
Merge pull request #20369 from seamuslee001/more_voids
[NFC] Add in more voids to unit tests to support PHPUnit8
Eileen McNaughton [Fri, 21 May 2021 01:19:20 +0000 (13:19 +1200)]
Merge pull request #20371 from eileenmcnaughton/tax
[NFC] [Test] Preliminary cleanup in test class
Tim Otten [Fri, 21 May 2021 01:12:40 +0000 (18:12 -0700)]
Merge pull request #20353 from seamuslee001/fix_distmaker_sync_core_ext
Fix Distmaker building by ensuring we are rsyncing from the right folder
Seamus Lee [Fri, 21 May 2021 01:06:27 +0000 (11:06 +1000)]
Merge pull request #20217 from eileenmcnaughton/contop
[Test] Add test cover for contribution tokens in pdf letter
Seamus Lee [Fri, 21 May 2021 00:13:50 +0000 (10:13 +1000)]
Merge pull request #20368 from eileenmcnaughton/cc
[REF] Slightly more logical order of code
Eileen McNaughton [Thu, 20 May 2021 23:41:47 +0000 (11:41 +1200)]
[NFC] [Test] Preliminary cleanup in test class
Seamus Lee [Thu, 20 May 2021 23:49:10 +0000 (09:49 +1000)]
[NFC] Add in more voids to unit tests to support PHPUnit8
Seamus Lee [Thu, 20 May 2021 23:45:05 +0000 (09:45 +1000)]
Merge pull request #20367 from colemanw/deprecateBulkSave
Deprecate function CRM_Core_BAO_CustomField::bulkSave
Eileen McNaughton [Thu, 20 May 2021 22:34:09 +0000 (10:34 +1200)]
[REF] Slightly more logical order of code
Just moves the lock check to the same area
Coleman Watts [Thu, 20 May 2021 21:48:08 +0000 (17:48 -0400)]
Deprecate function CRM_Core_BAO_CustomField::bulkSave
Seamus Lee [Thu, 20 May 2021 21:24:19 +0000 (07:24 +1000)]
Merge pull request #20366 from demeritcowboy/more-oo
[REF] Useradd contact task - Use OO instead of hardcoding "if Wordpress"
Seamus Lee [Thu, 20 May 2021 21:23:27 +0000 (07:23 +1000)]
Merge pull request #20359 from eileenmcnaughton/in
Superficial tidy up in test class
Seamus Lee [Thu, 20 May 2021 21:22:52 +0000 (07:22 +1000)]
Merge pull request #20363 from eileenmcnaughton/group
Cleanup - declare return types, remove unused var
Seamus Lee [Thu, 20 May 2021 21:20:46 +0000 (07:20 +1000)]
Merge pull request #20196 from eileenmcnaughton/import
[REF] Cleanup on import rows error
colemanw [Thu, 20 May 2021 21:19:21 +0000 (17:19 -0400)]
Merge pull request #20362 from eileenmcnaughton/save
Update bulkSave test to use the api
Eileen McNaughton [Thu, 20 May 2021 21:17:32 +0000 (09:17 +1200)]
Merge pull request #20349 from colemanw/searchKitFixMenuPerm
SearchKit - Fix menu permission
Seamus Lee [Thu, 20 May 2021 21:17:04 +0000 (07:17 +1000)]
Merge pull request #20365 from seamuslee001/voidtearDownAfterClass
[NFC] Add in voids to various setUpBeforeClass and tearDownAfterClass…
Seamus Lee [Thu, 20 May 2021 21:05:46 +0000 (07:05 +1000)]
Merge pull request #20348 from colemanw/searchKitTweaks
SearchKit and Afform UI improvements
Coleman Watts [Thu, 20 May 2021 15:25:29 +0000 (11:25 -0400)]
Afform Gui - Set height on dropdowns so CMS theme doesn't interfere
demeritcowboy [Thu, 20 May 2021 12:34:21 +0000 (08:34 -0400)]
make more oo-ey
Coleman Watts [Wed, 19 May 2021 16:51:19 +0000 (12:51 -0400)]
SearchKit & Afform - Style click-sort column headers
Coleman Watts [Wed, 19 May 2021 15:05:16 +0000 (11:05 -0400)]
SearchKit - Prevent overwriting SavedSearch.modified_date
When saving a search, the modified_date was being overwritten with the old value.
Coleman Watts [Wed, 19 May 2021 14:41:39 +0000 (10:41 -0400)]
SearchKit - Click-sort column headers on list page
Coleman Watts [Wed, 19 May 2021 13:18:03 +0000 (09:18 -0400)]
Afform - Standardize labels with Title Case and no colon
Coleman Watts [Tue, 18 May 2021 23:22:34 +0000 (19:22 -0400)]
Afform - Click-sort column headers on list page
Coleman Watts [Tue, 18 May 2021 17:37:43 +0000 (13:37 -0400)]
Afform - Add 'Placement' colum to admin screen
Coleman Watts [Tue, 18 May 2021 14:55:46 +0000 (10:55 -0400)]
SearchKit - Standardize labels with Title Case and no colon
The trailing colon is a pain for translators.
Coleman Watts [Tue, 18 May 2021 14:04:40 +0000 (10:04 -0400)]
SearchKit - When editing a display, show a checkbox to toggle limit
Previously, limit was a number input which could be disabled by entering the number '0'.
That's less intuitive than a checkbox.
Coleman Watts [Wed, 19 May 2021 20:03:48 +0000 (16:03 -0400)]
SearchKit - Sync menu & navigation permissions to use 'administer CiviCRM data'
Fixes dev/core#2619
https://lab.civicrm.org/dev/core/-/issues/2619
Seamus Lee [Thu, 20 May 2021 08:25:18 +0000 (18:25 +1000)]
[NFC] Add in voids to various setUpBeforeClass and tearDownAfterClass functions
Eileen McNaughton [Thu, 20 May 2021 07:19:53 +0000 (19:19 +1200)]
Cleanup - declare return types, remove unused var
Seamus Lee [Thu, 20 May 2021 06:05:17 +0000 (16:05 +1000)]
Merge pull request #20361 from eileenmcnaughton/zero
Unit test for #20342
Seamus Lee [Thu, 20 May 2021 05:49:06 +0000 (15:49 +1000)]
Merge pull request #20297 from eileenmcnaughton/roup
[REF] Extract function to build temporary table of members of group from Report_Form
Eileen McNaughton [Fri, 14 May 2021 07:14:40 +0000 (19:14 +1200)]
Save test
Eileen McNaughton [Thu, 20 May 2021 04:14:42 +0000 (16:14 +1200)]
Unit test for #20342
Eileen McNaughton [Thu, 20 May 2021 04:13:52 +0000 (16:13 +1200)]
Merge pull request #20342 from bugfolder/mandatory_keys_check
Fix mandatory keys check fail for value of float 0.0 in a required key in an entity
Eileen McNaughton [Thu, 20 May 2021 03:36:42 +0000 (15:36 +1200)]
Superficial tidy up in test class
Eileen McNaughton [Thu, 20 May 2021 03:32:32 +0000 (15:32 +1200)]
Merge pull request #20355 from eileenmcnaughton/ppp2
[REF] Extract getContributionObject
Eileen McNaughton [Thu, 20 May 2021 03:22:57 +0000 (15:22 +1200)]
Remove legacy references to partial_amount_to_pay
This was an early concept of how to do partial payments that we eliminated a while back
in favour of Payment.create
It is not set anywhere in core - only checked so time to remove the checks
Seamus Lee [Thu, 20 May 2021 03:18:53 +0000 (13:18 +1000)]
Merge pull request #20356 from seamuslee001/phpunit8_config
[NFC] Update PHPUnit config to not cache results in phpunit8 and add …
Seamus Lee [Thu, 20 May 2021 03:18:41 +0000 (13:18 +1000)]
Merge pull request #20354 from eileenmcnaughton/ppp
[REF] Remove now-unused parameter
Seamus Lee [Thu, 20 May 2021 03:00:54 +0000 (13:00 +1000)]
Merge pull request #20241 from eileenmcnaughton/haystack
Add test for mixed Order data
Eileen McNaughton [Fri, 14 May 2021 02:37:16 +0000 (14:37 +1200)]
[REF] Extract function to build temporary table of members of group from Report_Form
Seamus Lee [Thu, 20 May 2021 01:52:48 +0000 (11:52 +1000)]
[NFC] Update PHPUnit config to not cache results in phpunit8 and add more voids into PayflowProTest
Eileen McNaughton [Thu, 20 May 2021 01:48:18 +0000 (13:48 +1200)]
Extract getContributionObject
Eileen McNaughton [Thu, 20 May 2021 01:37:01 +0000 (13:37 +1200)]
[REF] Remove now-unused parameter
Eileen McNaughton [Thu, 20 May 2021 01:17:34 +0000 (13:17 +1200)]
Fix tearDown & setup to work under default test db state & leave it closer to default test db state
Seamus Lee [Thu, 20 May 2021 01:33:26 +0000 (11:33 +1000)]
Merge pull request #20318 from eileenmcnaughton/ppp
[REF] Add getter for contributionID
eileen [Thu, 29 Apr 2021 05:40:32 +0000 (17:40 +1200)]
[Test] Add test cover for contribution tokens in pdf letter
Seamus Lee [Thu, 20 May 2021 00:56:06 +0000 (10:56 +1000)]
Merge pull request #20345 from eileenmcnaughton/mem_move
[REF] Make previous unshared function protected & Remove hard-coded params
Seamus Lee [Thu, 20 May 2021 00:54:02 +0000 (10:54 +1000)]
Merge pull request #20330 from mattwire/fixpaymentformstest
Fix form params for testEventPaymentForms
Seamus Lee [Thu, 20 May 2021 00:34:37 +0000 (10:34 +1000)]
Merge pull request #20352 from seamuslee001/test_credit_card_validation
[NFC] Add in unit tests of credit card validation rules
Seamus Lee [Thu, 20 May 2021 00:09:05 +0000 (10:09 +1000)]
Merge pull request #20351 from seamuslee001/update_pear_finance_creditcard
[REF] Update Pear Validate Finance CreditCard to use latest tagged re…
Seamus Lee [Wed, 19 May 2021 23:48:46 +0000 (09:48 +1000)]
Fix Distmaker building by ensuring we are rsyncing from the right folder
Seamus Lee [Wed, 19 May 2021 23:07:50 +0000 (09:07 +1000)]
Merge pull request #20340 from eileenmcnaughton/schema2
Fix extraneous white space in generated sql
Seamus Lee [Wed, 19 May 2021 23:01:56 +0000 (09:01 +1000)]
Merge pull request #20278 from aydun/name_custom_css
Give the custom css file a 'name' to make it easier to manipulate in hook_civicrm_alterBundle()
Seamus Lee [Wed, 19 May 2021 22:55:33 +0000 (08:55 +1000)]
Merge pull request #20346 from eileenmcnaughton/confirm
[REF] Make previously unshared function protected
Seamus Lee [Wed, 19 May 2021 22:52:17 +0000 (08:52 +1000)]
[NFC] Add in unit tests of credit card validation rules
Seamus Lee [Wed, 19 May 2021 22:27:41 +0000 (08:27 +1000)]
[REF] Update Pear Validate Finance CreditCard to use latest tagged release that now includes the improved mastercard 2bin regex
Seamus Lee [Wed, 19 May 2021 21:43:33 +0000 (07:43 +1000)]
Merge pull request #20319 from eileenmcnaughton/pp
Remove extraneous debug
Seamus Lee [Wed, 19 May 2021 21:40:19 +0000 (07:40 +1000)]
Merge pull request #20347 from demeritcowboy/pass-compare
dev/core#2613 - Replace deprecated function in useradd task
Eileen McNaughton [Wed, 19 May 2021 09:28:51 +0000 (21:28 +1200)]
[REF] Make previously unshared function protected
This clarifies that it is not used outside core - which we
know as it was only just moved here
5187a13c4d0e4278bb9b18f9fb327b2407766dff
demeritcowboy [Wed, 19 May 2021 13:11:06 +0000 (09:11 -0400)]
switch from deprecated function
Seamus Lee [Wed, 19 May 2021 09:25:40 +0000 (19:25 +1000)]
Ensure that we only replace entity reference fields and add unit test
Seamus Lee [Mon, 17 May 2021 02:45:14 +0000 (12:45 +1000)]
Add in unit test of the submit action and re-work as per feedback from coleman
Seamus Lee [Mon, 10 May 2021 09:26:39 +0000 (19:26 +1000)]
Rework the listeners so that they are called on the basis of each entitiy rather than just once. Also extract weight function out and make improvements following Coleman's review and add tests
Seamus Lee [Thu, 6 May 2021 08:34:03 +0000 (18:34 +1000)]
WIP Entity Reference Submission fields
Eileen McNaughton [Wed, 19 May 2021 09:21:22 +0000 (21:21 +1200)]
[REF] Remove hard-coded params