Christian Wach [Thu, 15 Nov 2018 12:05:54 +0000 (12:05 +0000)]
Retrieve tab key from form attributes even when action is urlencoded
Monish Deb [Thu, 15 Nov 2018 07:26:36 +0000 (12:56 +0530)]
Merge pull request #13084 from colemanw/menuCleanup
dev/core#487 Menu cleanup in preparation for switch to SmartMenus library
Coleman Watts [Wed, 14 Nov 2018 04:28:47 +0000 (23:28 -0500)]
Add unit test for CRM_Core_BAO_Navigation::checkPermission()
Coleman Watts [Tue, 13 Nov 2018 16:20:41 +0000 (11:20 -0500)]
Menu code cleanup in preparation for switch to SmartMenus library
- Add a couple client side variables
- Fix access to functions that were private for no reason
- Extract permissions check into its own function
- Fire crmLoad event when menu loads
Seamus Lee [Sat, 10 Nov 2018 05:12:08 +0000 (16:12 +1100)]
Merge pull request #13075 from colemanw/help
Fix typo in smarty help
Coleman Watts [Fri, 9 Nov 2018 15:29:23 +0000 (10:29 -0500)]
Fix missing quotation marks in help file
Coleman Watts [Fri, 9 Nov 2018 15:22:10 +0000 (10:22 -0500)]
Fix typo in smarty help
Eileen McNaughton [Thu, 8 Nov 2018 09:02:21 +0000 (22:02 +1300)]
Merge pull request #13070 from seamuslee001/5.8
5.7 Release notes for 5.8
Andrew Hunt [Wed, 7 Nov 2018 04:22:23 +0000 (23:22 -0500)]
5.7.0 release notes: added late changes and contributors
Andrew Hunt [Tue, 6 Nov 2018 23:20:44 +0000 (18:20 -0500)]
5.7.0 release notes: edits and organization
Still need to handle contributors and add late changes
Alice Frumin [Tue, 23 Oct 2018 21:21:45 +0000 (17:21 -0400)]
first stab at 5.7.0 releasenotes (#11)
* adding links to gitlab
* moving obvious misc changes
* adding notes
* more noes
* wrapping
* first stab at release notes
Andrew Hunt [Tue, 16 Oct 2018 17:04:37 +0000 (13:04 -0400)]
5.7.0 release notes: added boilerplate
Andrew Hunt [Tue, 16 Oct 2018 16:59:41 +0000 (12:59 -0400)]
5.7.0 release notes: raw from script
CiviCRM [Thu, 8 Nov 2018 03:38:33 +0000 (03:38 +0000)]
Set version to 5.8.beta1
Eileen McNaughton [Thu, 8 Nov 2018 02:13:13 +0000 (15:13 +1300)]
Merge pull request #12682 from eileenmcnaughton/date_extension
Genericise 'ending' date filter and add tests
Eileen McNaughton [Tue, 6 Nov 2018 04:23:28 +0000 (17:23 +1300)]
Merge pull request #13054 from eileenmcnaughton/settings_generic
dev/core/495 Introduce generic settings form (fully metadata driven)
Eileen McNaughton [Tue, 6 Nov 2018 04:19:25 +0000 (17:19 +1300)]
Merge pull request #12921 from colemanw/ajaxMode
Fix isAjaxMode to also recognize angular ajax
Seamus Lee [Tue, 6 Nov 2018 01:50:32 +0000 (12:50 +1100)]
Merge pull request #13063 from seamuslee001/lab_core_119
dev/core#119 Fix undefined variable notice when going to pages like …
Seamus Lee [Tue, 6 Nov 2018 01:50:10 +0000 (12:50 +1100)]
Merge pull request #13064 from ejegg/master
Fix misplaced hyphens in regex
Eileen McNaughton [Mon, 5 Nov 2018 20:15:30 +0000 (09:15 +1300)]
Merge pull request #13044 from giovannidalmas1967/giovannidalmas1967-patch-1
Problem with Custom Field in Contact Reports
Elliott Eggleston [Mon, 5 Nov 2018 19:54:55 +0000 (14:54 -0500)]
Fix misplaced hyphens in regex
Inside a character range surrounded by [], the hyphen is interpreted
as defining a range, unless it's the first character. Move the
hyphens to the first character in the square brackets where it's
supposed to be interpreted as a hyphen.
Under PHP 7.3, the previous code failed with error message
preg_match(): Compilation failed: invalid range in character class at offset 7
Seamus Lee [Mon, 5 Nov 2018 19:49:09 +0000 (06:49 +1100)]
dev/core#119 Fix underfined variable notice when going to pages like civicrm/contact/map/event?eid=3&reset=1
eileen [Thu, 1 Nov 2018 21:55:17 +0000 (10:55 +1300)]
Replace event form with a generic replacement form
colemanw [Mon, 5 Nov 2018 12:22:01 +0000 (07:22 -0500)]
Merge pull request #13062 from eileenmcnaughton/settings_help_text
Fix handling of advmutltiselect (on localization form). Handle casing issues
Seamus Lee [Mon, 5 Nov 2018 00:53:51 +0000 (11:53 +1100)]
Merge pull request #12494 from eileenmcnaughton/strtolower
Fix international strings test / mishandling of international strings
eileen [Mon, 5 Nov 2018 00:45:48 +0000 (13:45 +1300)]
Fix handling of advmutltiselect (on localization form) Add deprecation notice rather than hard-fail for incorrect case for html type.
We have clarified the correct syntax (it was haphazard) an updated the docs.
This ALSO fixes fails on localisation form
Seamus Lee [Sun, 4 Nov 2018 23:28:27 +0000 (10:28 +1100)]
Merge pull request #13053 from eileenmcnaughton/settings_help
Fix help for financial acls.
eileen [Thu, 1 Nov 2018 21:05:48 +0000 (10:05 +1300)]
Fix help for financial acls.
I've done this by using the field template that is used by entity forms & adding
help to the spec (which I'll document).
I noted in this that entityTrait used a different field key for the
documentation link - literally documentation_link whereas I had used field_link
so I fixed settings to match
Seamus Lee [Sun, 4 Nov 2018 01:43:35 +0000 (12:43 +1100)]
Merge pull request #13061 from seamuslee001/crm-287
Fix unit tests following merge of PR #12797
Eileen McNaughton [Sat, 3 Nov 2018 23:55:46 +0000 (12:55 +1300)]
Merge pull request #13060 from seamuslee001/lab_core_6
dev/core#6 Add in help text about the is public setting for custom gr…
Seamus Lee [Sat, 3 Nov 2018 23:00:04 +0000 (10:00 +1100)]
Fix unit tests following merge of PR #12797
Seamus Lee [Sat, 3 Nov 2018 22:13:53 +0000 (09:13 +1100)]
dev/core#6 Add in help text about the is public setting for custom groups
Eileen McNaughton [Fri, 2 Nov 2018 21:29:39 +0000 (10:29 +1300)]
Merge pull request #12797 from madhavimalgaonkar/CRM-287
CRM-287 Disable child groups if all parents are disabled
giovannidalmas1967 [Fri, 2 Nov 2018 13:36:57 +0000 (14:36 +0100)]
Update Form.php
Eileen McNaughton [Fri, 2 Nov 2018 10:10:34 +0000 (23:10 +1300)]
Merge pull request #13056 from eileenmcnaughton/qs_follow_up
Remove limit when choosing fields for quick search
eileen [Tue, 23 Oct 2018 19:54:54 +0000 (08:54 +1300)]
Remove use of LOWER from city & street searches and fix international strings test.
Adding LOWER to mysql queries makes them slower. lowercasing php strings
breaks under some character sets with some server configs.
In trying to review PR 12364 I dug into the strotolower behaviour. I found that
in the path altered in this PR we are setting the value to lower case but not the
mysql clause. I ran through ContactTest without these lines & found it
only hit this strtolower in one test - testInternationalStrings which searches
by organization name. I found the this test actually failed for me
when I ran it locally - but it passed when I removed the strotlower lines.
Wonder in jenkins finds the same
eileen [Fri, 2 Nov 2018 07:37:50 +0000 (20:37 +1300)]
Remove when choosing fields for quick search
Eileen McNaughton [Fri, 2 Nov 2018 02:05:07 +0000 (15:05 +1300)]
Merge pull request #13039 from colemanw/quicksearchSetting
Configurable quicksearch settings
Eileen McNaughton [Fri, 2 Nov 2018 01:25:34 +0000 (14:25 +1300)]
Merge pull request #13055 from mfb/cleanup-query-logic
cleanup query logic - followup on GH-12991
Seamus Lee [Fri, 2 Nov 2018 01:05:33 +0000 (12:05 +1100)]
Merge pull request #12818 from mattwire/contributionsearch_byrecurtrxnprocessor
Allow contribution search by recurring payment processor ID / Transaction ID
colemanw [Fri, 2 Nov 2018 00:36:54 +0000 (20:36 -0400)]
Merge pull request #13014 from eileenmcnaughton/strlen
Prevent hard error when a string is too long for a field.
Seamus Lee [Fri, 2 Nov 2018 00:28:52 +0000 (11:28 +1100)]
Merge pull request #13035 from eileenmcnaughton/strtolower_name
Strtolower fix 'name'
Seamus Lee [Fri, 2 Nov 2018 00:26:45 +0000 (11:26 +1100)]
Merge pull request #13034 from eileenmcnaughton/strtolower_rels
Remove lowercasing in relationship query
mark burdett [Thu, 1 Nov 2018 23:49:29 +0000 (16:49 -0700)]
cleanup query logic - followup on GH-12991
Eileen McNaughton [Thu, 1 Nov 2018 20:13:40 +0000 (09:13 +1300)]
Merge pull request #13047 from eileenmcnaughton/settings_contribution_prefs
Finish unsharing hacks for contribution preferences form
colemanw [Thu, 1 Nov 2018 17:21:48 +0000 (13:21 -0400)]
Merge pull request #13049 from JKingsnorth/event-start-required
Mark event start date as required and refactoring
Coleman Watts [Wed, 31 Oct 2018 19:48:02 +0000 (15:48 -0400)]
Support custom fields with option lists in quicksearch
JKingsnorth [Thu, 1 Nov 2018 12:00:48 +0000 (12:00 +0000)]
Mark event start date as required and refactor formRule
eileen [Thu, 1 Nov 2018 02:02:39 +0000 (15:02 +1300)]
Finish fixing contribute preferences & preferences form to isolate hacks into one form
Eileen McNaughton [Thu, 1 Nov 2018 11:04:46 +0000 (00:04 +1300)]
Merge pull request #13046 from eileenmcnaughton/settings_address
[NFC] Preferences form template cleanup
Eileen McNaughton [Thu, 1 Nov 2018 10:57:53 +0000 (23:57 +1300)]
Merge pull request #13048 from eileenmcnaughton/resource-urls
Update casing on setting metadata for html_type = text
eileen [Thu, 1 Nov 2018 07:26:18 +0000 (20:26 +1300)]
Update casing on setting metadata for html_type = text
We have conventionally 'preferred' quick_form_type but we we not 'prefer' the more generic html_type.
We are fixing the places where the casing is inconsistent to support this
eileen [Thu, 1 Nov 2018 02:02:39 +0000 (15:02 +1300)]
post if-clause removal whitespace
eileen [Thu, 1 Nov 2018 02:02:15 +0000 (15:02 +1300)]
Remove if clauses that no longer apply
eileen [Thu, 1 Nov 2018 02:00:22 +0000 (15:00 +1300)]
Remove Contribute.tpl specific code from basicForm.tpl
Contribute.tpl no longer shares this form
eileen [Thu, 1 Nov 2018 01:59:08 +0000 (14:59 +1300)]
Move basicForm.tpl in it's entirity into Contribute.tpl.
Contribute.tpl no longer relies on basicForm.tpl so we can clean that up now
eileen [Thu, 1 Nov 2018 01:57:37 +0000 (14:57 +1300)]
Extract sharable portion of basicForm to basicFormFields.
This is part of disentangling the invoicing mess out of the shared code
Seamus Lee [Thu, 1 Nov 2018 00:28:02 +0000 (11:28 +1100)]
Merge pull request #13043 from christianwach/issue-wp-12
Pass path through rawurlencode when not using CIVICRM_CLEANURL
Seamus Lee [Wed, 31 Oct 2018 22:05:40 +0000 (09:05 +1100)]
Merge pull request #12969 from christianwach/issue-460
Fix malformed redirect URLs
Eileen McNaughton [Wed, 31 Oct 2018 20:52:52 +0000 (09:52 +1300)]
Merge pull request #13040 from eileenmcnaughton/setting_display
Convert final settings on the Display form
Christian Wach [Wed, 31 Oct 2018 14:51:34 +0000 (14:51 +0000)]
Pass path through rawurlencode when not using CIVICRM_CLEANURL
Coleman Watts [Tue, 30 Oct 2018 21:24:27 +0000 (17:24 -0400)]
Update db for new setting
Coleman Watts [Tue, 30 Oct 2018 18:52:07 +0000 (14:52 -0400)]
Confiurable quicksearch settings
Eileen McNaughton [Wed, 31 Oct 2018 01:50:02 +0000 (14:50 +1300)]
Merge pull request #13036 from yashodha/dev-491
(dev/core#491) Report results don't show inactive campaigns
Eileen McNaughton [Wed, 31 Oct 2018 01:45:45 +0000 (14:45 +1300)]
Merge pull request #13031 from compucorp/fix-custom-home-url-parsing
Fix custom Home URL parsing
eileen [Wed, 31 Oct 2018 00:13:04 +0000 (13:13 +1300)]
Convert final settings on the Display form
Eileen McNaughton [Tue, 30 Oct 2018 23:44:27 +0000 (12:44 +1300)]
Merge pull request #13004 from eileenmcnaughton/setting_address
Fix e-notices on Address settings page, convert YesNo field
eileen [Wed, 24 Oct 2018 20:56:10 +0000 (09:56 +1300)]
Fix e-notices on Address settings page, convert YesNo field
This fixes enotices & also does our first preferences conversion of a YesNo / Radio field
Seamus Lee [Tue, 30 Oct 2018 21:10:49 +0000 (08:10 +1100)]
Merge pull request #13027 from eileenmcnaughton/settings_event
Fix notices on event settings form
Seamus Lee [Tue, 30 Oct 2018 20:32:59 +0000 (07:32 +1100)]
Merge pull request #12769 from mattwire/civievent_permissions
Fix caching issues with Event permissions
Eileen McNaughton [Tue, 30 Oct 2018 19:44:59 +0000 (08:44 +1300)]
Merge pull request #13001 from JKingsnorth/core-456
dev/core#456 Improve UX of scheduling mass SMS
Eileen McNaughton [Tue, 30 Oct 2018 19:42:20 +0000 (08:42 +1300)]
Merge pull request #13018 from colemanw/iconTabs
Add icons to contact summary tabs
Davi Alexandre [Tue, 30 Oct 2018 14:53:04 +0000 (11:53 -0300)]
Extract duplicated URL processing code
Coleman Watts [Tue, 30 Oct 2018 16:30:22 +0000 (12:30 -0400)]
Also update markup in TabHeader.tpl for consistency
Coleman Watts [Tue, 30 Oct 2018 15:00:03 +0000 (11:00 -0400)]
Add span around tab titles
yashodha [Tue, 30 Oct 2018 09:06:57 +0000 (14:36 +0530)]
(dev/core#491) Report results don't show inactive campaigns
Madhavi [Tue, 30 Oct 2018 07:55:56 +0000 (13:25 +0530)]
CRM-20236 Added participant note column (#13029)
* CRM-20236 Added participant note column in Event Participant Listing report
* fix code style warnings and switch to $this->isTableSelected
Seamus Lee [Tue, 30 Oct 2018 05:59:01 +0000 (16:59 +1100)]
Merge pull request #12986 from seamuslee001/lab_core_463
dev/core#463 Add in ability for Extensions to use their Extension Utils class to s…
Seamus Lee [Tue, 30 Oct 2018 04:29:28 +0000 (15:29 +1100)]
Merge pull request #13033 from seamuslee001/icon_style_guide_5_8
Duplicate upgrade step for 5.7.beta1 in 5.8.alpha1 to capture anyone …
Seamus Lee [Tue, 23 Oct 2018 00:08:30 +0000 (11:08 +1100)]
dev/core#463 Add in ability for Extensions to use their Extension Utils class to supply ts Functions in DAOs
Update DAO generation using ts function name as per conversation with Tim
eileen [Mon, 29 Oct 2018 07:37:04 +0000 (20:37 +1300)]
Fix event preferences form
eileen [Mon, 29 Oct 2018 23:09:11 +0000 (12:09 +1300)]
Strtolower fix 'name'
eileen [Mon, 29 Oct 2018 23:02:40 +0000 (12:02 +1300)]
Remove lowercasing in relationship query
Seamus Lee [Mon, 29 Oct 2018 22:39:18 +0000 (09:39 +1100)]
Duplicate upgrade step for 5.7.beta1 in 5.8.alpha1 to capture anyone who has already upgrade to RC
Eileen McNaughton [Mon, 29 Oct 2018 22:28:14 +0000 (11:28 +1300)]
Merge pull request #13032 from civicrm/5.7
5.7 to master
Eileen McNaughton [Mon, 29 Oct 2018 22:27:47 +0000 (11:27 +1300)]
Merge pull request #13015 from colemanw/memberIcon
Update menu icons to follow style guide
Eileen McNaughton [Mon, 29 Oct 2018 22:27:29 +0000 (11:27 +1300)]
Merge pull request #13026 from eileenmcnaughton/campaign_prefs
Fix notices on Campaign preferences form
Matthew Wire (MJW Consulting) [Mon, 29 Oct 2018 21:21:58 +0000 (21:21 +0000)]
Add more unit tests for Event permissions
Eileen McNaughton [Mon, 29 Oct 2018 21:48:28 +0000 (10:48 +1300)]
Merge pull request #12978 from mattwire/datepicker_manageevent_search
Convert event search to datepicker and cleanup template
Matthew Wire (MJW Consulting) [Mon, 29 Oct 2018 21:34:10 +0000 (21:34 +0000)]
Further tweaks to contribution search recurring fields (@kirk-jackson)
Matthew Wire (MJW Consulting) [Thu, 16 Aug 2018 16:51:03 +0000 (17:51 +0100)]
Refactor Event::checkPermissions to resolve issues with caching
Seamus Lee [Mon, 29 Oct 2018 20:48:29 +0000 (07:48 +1100)]
Merge pull request #13030 from MegaphoneJon/core-477
Closes core#477 - display employer/title/group info in print summary
Coleman Watts [Fri, 26 Oct 2018 14:08:20 +0000 (10:08 -0400)]
Add icons to contact summary tabs
Coleman Watts [Fri, 26 Oct 2018 03:29:29 +0000 (23:29 -0400)]
Update menu icons to follow style guide
Eileen McNaughton [Mon, 29 Oct 2018 19:48:30 +0000 (08:48 +1300)]
Merge pull request #13019 from seamuslee001/lab_core_481
dev/core#481 Ensure that Bulk Mailings is a checkbox rather than radi…
eileen [Mon, 29 Oct 2018 06:23:10 +0000 (19:23 +1300)]
Fix campaign preferences form
Seamus Lee [Mon, 29 Oct 2018 19:42:10 +0000 (06:42 +1100)]
Merge pull request #13025 from eileenmcnaughton/multisite_settings
Fix notices on Multisite settings form
Eileen McNaughton [Mon, 29 Oct 2018 19:37:36 +0000 (08:37 +1300)]
Merge pull request #13028 from yashodha/report-fixes
CRM-21677 - more report clean up
Davi Alexandre [Mon, 29 Oct 2018 18:54:27 +0000 (15:54 -0300)]
Support URL fragments in custom Home URLs
Davi Alexandre [Mon, 29 Oct 2018 18:46:27 +0000 (15:46 -0300)]
Avoid E_NOTICE when Home URL does not contain a query string
The list assignment will result in an E_NOTICE when the Home URL does
not contain a query string, because the array returned by the explode()
call will contain only one item.