Eileen McNaughton [Fri, 11 Nov 2022 01:47:18 +0000 (14:47 +1300)]
Merge pull request #24944 from colemanw/upgradeExt
Core extensions - Upgrade to civix 22.10.0
demeritcowboy [Thu, 10 Nov 2022 22:18:47 +0000 (17:18 -0500)]
Merge pull request #24948 from colemanw/basename
Simplify removing file extension when using basename function
Coleman Watts [Thu, 10 Nov 2022 18:13:46 +0000 (13:13 -0500)]
Simplify removing file extension when using basename function
The basename function has a native way of removing file extensions, so the use of str_replace or preg_replace
is usually unnecessary.
colemanw [Thu, 10 Nov 2022 17:38:54 +0000 (12:38 -0500)]
Merge pull request #24933 from eileenmcnaughton/dep_token_cont
Add noisy deprecation to unused functions `replaceContactTokens`, `replaceCaseTokens`
colemanw [Thu, 10 Nov 2022 17:24:23 +0000 (12:24 -0500)]
Merge pull request #24941 from colemanw/addSearchRunTest
SearchKit - Add unit test for multivalued custom fields
colemanw [Thu, 10 Nov 2022 16:45:53 +0000 (11:45 -0500)]
Merge pull request #24946 from eileenmcnaughton/dao
Regenerate Country DAO
Coleman Watts [Thu, 10 Nov 2022 02:57:37 +0000 (21:57 -0500)]
Core extensions - Upgrade to civix 22.10.0
colemanw [Thu, 10 Nov 2022 14:45:45 +0000 (09:45 -0500)]
Merge pull request #24945 from eileenmcnaughton/ex_zero
dev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id
Eileen McNaughton [Thu, 10 Nov 2022 08:44:23 +0000 (21:44 +1300)]
Regenerate Country DAO
Eileen McNaughton [Thu, 10 Nov 2022 08:43:51 +0000 (21:43 +1300)]
Test updates for example change
Eileen McNaughton [Thu, 10 Nov 2022 07:02:19 +0000 (20:02 +1300)]
dev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id
Overview
==================================================
dev/core#3981 Fix Examples to use 0 rather than a possibly-real contact_id
https://lab.civicrm.org/dev/core/-/issues/3981
Before
==============================================
When using the Message Admin UI and trying out tokens those that are not
explicitly defined in the sample data are fetched from the database from
the contact whose id has been arbitrarily used.
After
=======================================================================
The contact_id is set to 0. As a result nothing is retrievable from the databse.
Technical Details
=======================================================================
I suspect this was not possible when the example was first written (the
token code has matured a bit) & a stand in number seemed intuitive - but
I think that is arguable even when there are no negative side
effects (for example if a url were in the letter then linking to
a random contact from it is kinda confusing) - but really loses it's potency
as an argument when there ARE negative side effects
Comments
============================================================================
I'm pretty sure there are some tests I need to adjust for this....
Yashodha Chaku [Thu, 10 Nov 2022 05:42:26 +0000 (11:12 +0530)]
Merge pull request #24898 from larssandergreen/don't-allow-selecting-deleted-contacts-to-email
Don't allow selection of deleted contacts as email recipients
Yashodha Chaku [Thu, 10 Nov 2022 05:39:32 +0000 (11:09 +0530)]
Merge pull request #24932 from eileenmcnaughton/remove_unused
Remove unused private function `removeNullContactTokens`
Coleman Watts [Thu, 10 Nov 2022 02:49:57 +0000 (21:49 -0500)]
Afform - Upgrade ext to civix 22.10.0
colemanw [Thu, 10 Nov 2022 02:31:22 +0000 (21:31 -0500)]
Merge pull request #24938 from eileenmcnaughton/opt_val
Fix api handling of OptionValue defaults
Coleman Watts [Wed, 9 Nov 2022 23:32:55 +0000 (18:32 -0500)]
SearchKit - Add test for multivalued custom fields
Eileen McNaughton [Tue, 8 Nov 2022 23:41:34 +0000 (12:41 +1300)]
Fix api handling of OptionValue defaults
Overview
----------------------------------------
Fix api handling of OptionValue defaults
Before
----------------------------------------
Some option values (greetings, from_email_address) have
more than one default. For from_email_address it is per domain
and for the others it is per 'filter' (aka contact_type).
The special handling for greetings relies on the form layer - updating
a greeting for 'Individual' and passing 'is_default' will
unset 'is_default' for Household greetings.
For from_email_address the form layer magic-param is set but ultimately
has no bearing as there is duplicate handling in the bao layer
After
----------------------------------------
The default handling is done in the BAO layer & removed from the
form layer
Technical Details
----------------------------------------
I moved the handling to after-update because values are more guarantee there. I
did this by excluding the id from the update query (also prevents flappy updates).
I didn't move all the way to the post hook because I wasn't sure about the interaction
with cache flushing etc (that already happen after save in create) but that could be considered.
Eileen McNaughton [Wed, 9 Nov 2022 23:04:00 +0000 (12:04 +1300)]
Merge pull request #24939 from eileenmcnaughton/examples
Add new Organization Example contact (The Daily Bugle)
colemanw [Wed, 9 Nov 2022 22:00:17 +0000 (17:00 -0500)]
Merge pull request #24919 from eileenmcnaughton/import_county
Add tests for importing county (includes adding v4 County api)
Eileen McNaughton [Wed, 9 Nov 2022 21:22:34 +0000 (10:22 +1300)]
Add new Organization Example contact (The Daily Bugle)
colemanw [Wed, 9 Nov 2022 13:49:50 +0000 (08:49 -0500)]
Merge pull request #24931 from mlutfy/replaceState
TabHeader: remove redundant history.replaceState
Eileen McNaughton [Tue, 8 Nov 2022 20:19:28 +0000 (09:19 +1300)]
Add noisy deprecation to unused functions
Eileen McNaughton [Tue, 8 Nov 2022 20:15:58 +0000 (09:15 +1300)]
Remove unused private function
Mathieu Lutfy [Tue, 8 Nov 2022 20:04:17 +0000 (15:04 -0500)]
TabHeader: remove redundant history.replaceState
demeritcowboy [Tue, 8 Nov 2022 14:47:53 +0000 (09:47 -0500)]
Merge pull request #24922 from eileenmcnaughton/test_3
[NFC] Clean up in test class
demeritcowboy [Tue, 8 Nov 2022 14:47:24 +0000 (09:47 -0500)]
Merge pull request #24921 from eileenmcnaughton/test_two
[NFC] Minor cleanup in test
demeritcowboy [Tue, 8 Nov 2022 14:46:35 +0000 (09:46 -0500)]
Merge pull request #24920 from eileenmcnaughton/token_format
[NFC] Test class cleanup (JobTest)
demeritcowboy [Tue, 8 Nov 2022 14:44:32 +0000 (09:44 -0500)]
Merge pull request #24918 from civicrm/5.56
5.56
Tim Otten [Tue, 8 Nov 2022 05:54:43 +0000 (21:54 -0800)]
Merge pull request #24897 from eileenmcnaughton/billing56
(dev/core#3918) Revert "Add missing country=>billingCountry to PropertyBag mapping"
Eileen McNaughton [Tue, 8 Nov 2022 04:24:42 +0000 (17:24 +1300)]
[NFC] Clean up in test class
Eileen McNaughton [Tue, 8 Nov 2022 04:21:17 +0000 (17:21 +1300)]
[NFC] Minor cleanup in test
Eileen McNaughton [Tue, 8 Nov 2022 04:13:54 +0000 (17:13 +1300)]
[NFC] Test class cleanup (JobTest)
Eileen McNaughton [Mon, 7 Nov 2022 23:44:49 +0000 (12:44 +1300)]
Add County api & fix test to use it
The previous test was failing due to cached values
not being cleared by the sql insert
Jamie McClelland [Mon, 7 Nov 2022 19:49:30 +0000 (14:49 -0500)]
add test for detecting failed county import by name.
fix typo in county name in test.
Seamus Lee [Mon, 7 Nov 2022 23:24:52 +0000 (10:24 +1100)]
Merge pull request #24915 from MegaphoneJon/event-map-php8
PHP8 fix - always define locations in event info template
Tim Otten [Mon, 7 Nov 2022 23:11:48 +0000 (15:11 -0800)]
Merge pull request #24895 from eileenmcnaughton/key
dev/core#3960 Remove legacy ar key
Jon Goldberg [Mon, 7 Nov 2022 17:58:12 +0000 (12:58 -0500)]
PHP8 fix - always define locations in event info template
Eileen McNaughton [Mon, 7 Nov 2022 06:34:14 +0000 (19:34 +1300)]
Merge pull request #24914 from sebalis/contributor-sebalis
added contributor Sebastian Lisken
Seamus Lee [Mon, 7 Nov 2022 03:17:46 +0000 (14:17 +1100)]
Merge pull request #24913 from seamuslee001/fix_error_test_wordpress_clean
[REF] Fix E2E_Core_ErrorTest on wordpress-clean builds
sebalis [Mon, 7 Nov 2022 01:06:13 +0000 (02:06 +0100)]
added contributor Sebastian Lisken
Seamus Lee [Mon, 7 Nov 2022 00:38:13 +0000 (11:38 +1100)]
[REF] Fix E2E_Core_ErrorTest on wordpress-clean builds
demeritcowboy [Sun, 6 Nov 2022 17:21:19 +0000 (12:21 -0500)]
Merge pull request #24910 from civicrm/5.56
5.56
demeritcowboy [Sun, 6 Nov 2022 15:39:34 +0000 (10:39 -0500)]
Merge pull request #24909 from totten/5.56-cacert
composer.json - Update cacerts fallback
demeritcowboy [Sun, 6 Nov 2022 15:39:23 +0000 (10:39 -0500)]
Merge pull request #24906 from braders/contributionview-fix
Don't crash ContributionView when participant fields are null
Bradley Taylor [Sat, 5 Nov 2022 17:56:46 +0000 (17:56 +0000)]
Don't crash ContributionView when participant fields are null
demeritcowboy [Sun, 6 Nov 2022 03:57:12 +0000 (23:57 -0400)]
Merge pull request #24908 from civicrm/5.56
5.56
Tim Otten [Sun, 6 Nov 2022 02:44:49 +0000 (19:44 -0700)]
composer.json - Update cacerts fallback
demeritcowboy [Sat, 5 Nov 2022 22:48:59 +0000 (18:48 -0400)]
Merge pull request #24904 from sebalis/patch-1
avoid fatal error in PHP 8 in BAO/Navigation.php
demeritcowboy [Sat, 5 Nov 2022 22:43:08 +0000 (18:43 -0400)]
Merge pull request #24905 from larssandergreen/only-show-cases-added-alert-for-10s
Only show File Activity on Case success alert for 10s
larssandergreen [Sat, 5 Nov 2022 16:47:34 +0000 (10:47 -0600)]
only show case added alert for 10s
sebalis [Fri, 4 Nov 2022 23:54:14 +0000 (00:54 +0100)]
avoid fatal error in PHP 8 in BAO/Navigation.php
See https://lab.civicrm.org/dev/core/-/issues/3968 for details.
Seamus Lee [Sat, 5 Nov 2022 04:24:39 +0000 (15:24 +1100)]
Merge pull request #24901 from demeritcowboy/lack-of-class
[REF] Unused vars in the State Machine
Matthew Wire [Fri, 4 Nov 2022 12:58:28 +0000 (12:58 +0000)]
Merge pull request #24899 from colemanw/searchKitClone
SearchKit - Add clone button for search displays
Coleman Watts [Fri, 4 Nov 2022 01:07:58 +0000 (21:07 -0400)]
SearchKit - Add clone button for search displays
demeritcowboy [Fri, 4 Nov 2022 02:51:53 +0000 (22:51 -0400)]
unused vars
larssandergreen [Thu, 3 Nov 2022 23:39:34 +0000 (17:39 -0600)]
No more deleted contacts as email recipients
Eileen McNaughton [Thu, 3 Nov 2022 22:39:49 +0000 (11:39 +1300)]
Revert "Add missing country=>billingCountry to PropertyBag mapping"
This reverts commit
99d7dc7bd17b81e7041c7d85d72b0e70210201d8.
Eileen McNaughton [Thu, 3 Nov 2022 22:56:33 +0000 (11:56 +1300)]
dev/core#3960 Remove legacy ar key
Seamus Lee [Thu, 3 Nov 2022 22:30:49 +0000 (09:30 +1100)]
Merge pull request #24727 from eileenmcnaughton/getlist
dev/core#3735 Fix for getlist retrieve with id
Seamus Lee [Thu, 3 Nov 2022 19:57:41 +0000 (06:57 +1100)]
Merge pull request #24893 from yashodha/dev_3136
(dev/core#3136) Incorporate the domain id in the log file nomenclatur…
demeritcowboy [Thu, 3 Nov 2022 14:27:50 +0000 (10:27 -0400)]
Merge pull request #24892 from totten/master-pst
PriceSetTest - Fix test-run on case-insensitive filesystem
yashodha [Thu, 3 Nov 2022 13:04:26 +0000 (18:34 +0530)]
(dev/core#3136) Incorporate the domain id in the log file nomenclature to help locate the file easily
Tim Otten [Thu, 3 Nov 2022 08:20:29 +0000 (01:20 -0700)]
PriceSetTest - Fix test-run on case-insensitive filesystem
CiviCRM [Thu, 3 Nov 2022 02:58:20 +0000 (02:58 +0000)]
Set version to 5.57.alpha1
CiviCRM [Thu, 3 Nov 2022 02:39:58 +0000 (02:39 +0000)]
Set version to 5.56.beta1
Tim Otten [Thu, 3 Nov 2022 01:41:42 +0000 (18:41 -0700)]
Merge pull request #24873 from colemanw/searchKitIcons
SearchKit - Improve icon handling
Seamus Lee [Thu, 3 Nov 2022 01:19:40 +0000 (12:19 +1100)]
Merge pull request #24887 from civicrm/5.55
5.55
Tim Otten [Fri, 28 Oct 2022 03:00:40 +0000 (20:00 -0700)]
Add release-notes/5.54.1.md
Seamus Lee [Thu, 3 Nov 2022 01:14:10 +0000 (12:14 +1100)]
Merge pull request #24886 from agh1/5.55.0-releasenotes-final
5.55.0 release notes: added late changes
Andie Hunt [Thu, 3 Nov 2022 01:07:57 +0000 (21:07 -0400)]
5.55.0 release notes: added late changes
Seamus Lee [Wed, 2 Nov 2022 22:34:46 +0000 (09:34 +1100)]
Merge pull request #24885 from seamuslee001/master
5.55
Seamus Lee [Wed, 2 Nov 2022 22:33:59 +0000 (09:33 +1100)]
Merge branch '5.55'
Seamus Lee [Wed, 2 Nov 2022 22:30:35 +0000 (09:30 +1100)]
Merge pull request #24872 from seamuslee001/dev_core_3952
dev/core#3952 Add in Upgrade script to fix up print labels where " wa…
Tim Otten [Wed, 2 Nov 2022 20:53:23 +0000 (13:53 -0700)]
Target 5.55.beta2
Tim Otten [Wed, 2 Nov 2022 20:52:38 +0000 (13:52 -0700)]
Set version to 5.55.beta2
Tim Otten [Wed, 2 Nov 2022 20:40:29 +0000 (13:40 -0700)]
Target 5.55.beta
Seamus Lee [Wed, 2 Nov 2022 20:36:33 +0000 (07:36 +1100)]
Merge pull request #24858 from eileenmcnaughton/import_soft
dev/core#3879 Fix failure to accept soft credit contact id
Eileen McNaughton [Wed, 2 Nov 2022 20:35:56 +0000 (09:35 +1300)]
Merge pull request #24882 from colemanw/fixDefaultSearchDisplayLink
Fix missing links in SearchKit results
Coleman Watts [Wed, 2 Nov 2022 14:39:45 +0000 (10:39 -0400)]
Fix missing links in SearchKit results
Regression:
Go to SearchKit and click "New Search" (for contacts). The display name column is no longer a clickable link.
Yashodha Chaku [Wed, 2 Nov 2022 07:42:54 +0000 (13:12 +0530)]
Merge pull request #24876 from larssandergreen/add-help-text-for-scheduled-reminders-for-events
Add help text for event scheduled reminders relative and absolute dates
Seamus Lee [Wed, 2 Nov 2022 00:12:59 +0000 (11:12 +1100)]
Merge pull request #24875 from mattwire/searchkitdatediff
Add DATEDIFF to calculate days between two dates
demeritcowboy [Wed, 2 Nov 2022 00:10:08 +0000 (20:10 -0400)]
Merge pull request #24879 from seamuslee001/php82_dynamic_properties_2
[REF][PHP8.2] Fix some instances of properties not being declared on …
Seamus Lee [Tue, 1 Nov 2022 22:31:31 +0000 (09:31 +1100)]
Merge pull request #24807 from eileenmcnaughton/spec55
dev/core#3941 Fix import spec class loader issue
Seamus Lee [Tue, 1 Nov 2022 22:24:03 +0000 (09:24 +1100)]
Merge pull request #24880 from civicrm/5.55
5.55
Seamus Lee [Tue, 1 Nov 2022 22:23:51 +0000 (09:23 +1100)]
Merge pull request #24877 from colemanw/backwardsTest
Test - Fix backwards params to assertEquals
colemanw [Tue, 1 Nov 2022 22:16:41 +0000 (18:16 -0400)]
Merge pull request #24860 from colemanw/formbuilder-recaptcha2
Afform - Add support for ReCaptcha v2
colemanw [Tue, 1 Nov 2022 21:44:24 +0000 (17:44 -0400)]
Merge pull request #24810 from colemanw/searchSegmentFilter
SearchKit - Expose SearchSegment fields as filters
Seamus Lee [Tue, 1 Nov 2022 21:04:19 +0000 (08:04 +1100)]
Merge pull request #24874 from totten/5.55-enable-specprov
SpecScanner - Fix installation error ("Class XyzSpecProvider does not exist")
Seamus Lee [Tue, 1 Nov 2022 21:03:00 +0000 (08:03 +1100)]
Merge pull request #24871 from eileenmcnaughton/import_save_dots
Import regression, fix loading of saved mapping with soft-credit email mapped
Seamus Lee [Tue, 1 Nov 2022 21:01:43 +0000 (08:01 +1100)]
Merge remote-tracking branch 'Toby-fz/master'
Seamus Lee [Fri, 28 Oct 2022 23:09:19 +0000 (23:09 +0000)]
[REF][PHP8.2] Fix some instances of properties not being declared on classes
Coleman Watts [Tue, 1 Nov 2022 20:14:55 +0000 (16:14 -0400)]
Test - Fix backwards params to assertEquals
Kurund Jalmi [Fri, 7 Oct 2022 19:09:57 +0000 (20:09 +0100)]
Afform - Add support for ReCaptcha v2
Fixes dev/core#3173
Co-authored-by: Coleman Watts <coleman@civicrm.org>
Coleman Watts [Tue, 1 Nov 2022 19:08:30 +0000 (15:08 -0400)]
APIv4 - Add tests for SQL DATE functions
Matthew Wire [Tue, 1 Nov 2022 14:04:02 +0000 (14:04 +0000)]
APIv4 - Add DATEDIFF to calculate days between two dates
Co-authored-by: colemanw <coleman@civicrm.org>
larssandergreen [Tue, 1 Nov 2022 17:42:58 +0000 (11:42 -0600)]
Add help text for event scheduled reminders relative and absolute dates
demeritcowboy [Tue, 1 Nov 2022 17:12:46 +0000 (13:12 -0400)]
Merge pull request #24857 from seamuslee001/db_patches_php82
[REF][PHP8.2] Add patches to pear upstream packages to fix issues with PHP8.2
Yashodha Chaku [Tue, 1 Nov 2022 14:29:20 +0000 (19:59 +0530)]
Merge pull request #24863 from mattwire/eventtemplatecaching
Fix event template cache not updating. Replace some deprecated functions with API4
Coleman Watts [Tue, 1 Nov 2022 02:10:33 +0000 (22:10 -0400)]
SearchKit - Improve icon handling
Gives the ability to have "fallback" icons, e.g. choosing the
icon for contact_sub_type with a fallback to contact_type.
Tim Otten [Tue, 1 Nov 2022 09:16:25 +0000 (02:16 -0700)]
search_kit_civicrm_config - Remove redundant registration
The `SearchKitSubscriber` is now registered as an auto-service. This behaves better when dealing with
various enable/disable flows.