civicrm-core.git
3 years agofixes core#2974, overrides break membership update status when removed
Jon Goldberg [Tue, 30 Nov 2021 20:57:55 +0000 (15:57 -0500)]
fixes core#2974, overrides break membership update status when removed

3 years agoMerge pull request #22085 from seamuslee001/5.44
Seamus Lee [Mon, 15 Nov 2021 23:16:18 +0000 (10:16 +1100)]
Merge pull request #22085 from seamuslee001/5.44

Add in 5.43.1 and 5.43.2 Release Notes

3 years agoAdd release-notes/5.43.2.md
Tim Otten [Mon, 15 Nov 2021 20:27:23 +0000 (12:27 -0800)]
Add release-notes/5.43.2.md

3 years agorelease-notes/5.43.1.md - Add recent patch
Tim Otten [Fri, 12 Nov 2021 20:18:25 +0000 (12:18 -0800)]
release-notes/5.43.1.md - Add recent patch

3 years agoAdd release-notes/5.43.1.md
Tim Otten [Fri, 12 Nov 2021 04:59:35 +0000 (20:59 -0800)]
Add release-notes/5.43.1.md

3 years agoMerge pull request #22071 from demeritcowboy/drupal92-session
Seamus Lee [Mon, 15 Nov 2021 00:13:23 +0000 (11:13 +1100)]
Merge pull request #22071 from demeritcowboy/drupal92-session

dev/drupal#169 - Fix for session_id() change in Drupal 9.2

3 years agofix session change in drupal 9.2
demeritcowboy [Fri, 12 Nov 2021 21:53:57 +0000 (16:53 -0500)]
fix session change in drupal 9.2

3 years agoMerge pull request #22051 from eileenmcnaughton/544
colemanw [Fri, 12 Nov 2021 13:50:23 +0000 (08:50 -0500)]
Merge pull request #22051 from eileenmcnaughton/544

APIv4 - Add backticks around fields in join criteria

3 years agoMerge pull request #22046 from totten/5.44-eventid
Seamus Lee [Fri, 12 Nov 2021 08:26:26 +0000 (19:26 +1100)]
Merge pull request #22046 from totten/5.44-eventid

(dev/core#2947) Tokens - Auto-enable `{event.*}` if `participantId` is present

3 years agoMerge pull request #22043 from seamuslee001/5.44
Seamus Lee [Fri, 12 Nov 2021 05:54:49 +0000 (16:54 +1100)]
Merge pull request #22043 from seamuslee001/5.44

[REF] Skip testCutesyTokenData on php8 for the moment

3 years agoAPIv4 - Add backticks around fields in join criteria
Coleman Watts [Fri, 12 Nov 2021 02:42:36 +0000 (21:42 -0500)]
APIv4 - Add backticks around fields in join criteria

Fixes dev/mail#103

3 years agoRefine alignment of old/new token lists
Tim Otten [Fri, 12 Nov 2021 04:08:16 +0000 (20:08 -0800)]
Refine alignment of old/new token lists

The prior commit means that `$context['participantId']` will activate `{event.*}` tokens - in contexts
that use `TokenProcessor`. And the `TokenProcessor` is *somewhat* matched to the older functions.

This twiddles the match-up:

* Provide continuity for the deprecated `CRM_Core_SelectValues::participantTokens()` - so it still
  only returns `{participant.*}` tokens. Borrow the technique which excludes `{domain.*}` tokens.
  This should ensure better continuity for any callers that actually use `CRM_Utils_Token`.

* Update the assertions for the `TokenProcessor` to show that the `{event.*}` tokens are presented in
  participant-related contexts.

3 years agodev/core#2947 - Auto-enable `{event.*}` if `participantId` is present
Tim Otten [Fri, 12 Nov 2021 00:41:30 +0000 (16:41 -0800)]
dev/core#2947 - Auto-enable `{event.*}` if `participantId` is present

3 years ago[REF] Fix Pledge Test failing on php8 by ensuring all payments have a status assigned...
Seamus Lee [Thu, 11 Nov 2021 04:26:00 +0000 (04:26 +0000)]
[REF] Fix Pledge Test failing on php8 by ensuring all payments have a status assigned and that customGroup is always assigned to the template and updating test to pass in some additional form values

3 years ago[REF] Skip testCutesyTokenData on php8 for the moment
Seamus Lee [Thu, 11 Nov 2021 23:58:01 +0000 (10:58 +1100)]
[REF] Skip testCutesyTokenData on php8 for the moment

3 years agoMerge pull request #21997 from colemanw/fixUpgradeErrors
Seamus Lee [Sun, 7 Nov 2021 23:56:18 +0000 (10:56 +1100)]
Merge pull request #21997 from colemanw/fixUpgradeErrors

dev/core#2550 Fix possible upgrade failures

3 years agoFix possible upgrade failures when writing to db fields which may not yet exist
Coleman Watts [Sat, 6 Nov 2021 21:47:43 +0000 (17:47 -0400)]
Fix possible upgrade failures when writing to db fields which may not yet exist

Fixes dev/core#2550

3 years agoMerge pull request #21985 from colemanw/searchImageFix
Eileen McNaughton [Fri, 5 Nov 2021 22:13:17 +0000 (11:13 +1300)]
Merge pull request #21985 from colemanw/searchImageFix

[Unreleased regression] SearchKit - Fix display of image fields

3 years agoSearchKit - Fix display of image fields
Coleman Watts [Fri, 5 Nov 2021 18:39:05 +0000 (14:39 -0400)]
SearchKit - Fix display of image fields

3 years agoMerge pull request #21980 from eileenmcnaughton/544
Seamus Lee [Fri, 5 Nov 2021 04:56:50 +0000 (15:56 +1100)]
Merge pull request #21980 from eileenmcnaughton/544

dev/core#2942 regression fix

3 years agoMerge pull request #21977 from colemanw/fixSearchKitPermissions
Seamus Lee [Fri, 5 Nov 2021 03:17:37 +0000 (14:17 +1100)]
Merge pull request #21977 from colemanw/fixSearchKitPermissions

SearchKit - Fix permission to access default display and download spreadsheets

3 years agodev/core#2942 regression fix
Eileen McNaughton [Fri, 5 Nov 2021 02:41:13 +0000 (15:41 +1300)]
dev/core#2942 regression fix

3 years agoSearchKit - Fix permission to access default display and download spreadsheets
Coleman Watts [Thu, 4 Nov 2021 19:42:31 +0000 (15:42 -0400)]
SearchKit - Fix permission to access default display and download spreadsheets

Intentionally setting these gatekeeper permissions fairly open as all of these actions
perform stricter permission checks internally.

3 years agoMerge pull request #21974 from christianwach/lab-core-2909-2
demeritcowboy [Thu, 4 Nov 2021 17:39:07 +0000 (13:39 -0400)]
Merge pull request #21974 from christianwach/lab-core-2909-2

dev/core#2909 - Repair the option value label for nb_NO language

3 years agoRepair the option value label for nb_NO language
Christian Wach [Thu, 4 Nov 2021 15:20:13 +0000 (15:20 +0000)]
Repair the option value label for nb_NO language

3 years agoSet version to 5.44.beta1
CiviCRM [Thu, 4 Nov 2021 07:47:04 +0000 (07:47 +0000)]
Set version to 5.44.beta1

3 years agoMerge pull request #21972 from eileenmcnaughton/gettok
Seamus Lee [Thu, 4 Nov 2021 05:16:52 +0000 (16:16 +1100)]
Merge pull request #21972 from eileenmcnaughton/gettok

Remove call to getTokenDetails

3 years agoMerge pull request #21967 from colemanw/searchRunFix
Eileen McNaughton [Thu, 4 Nov 2021 03:39:13 +0000 (16:39 +1300)]
Merge pull request #21967 from colemanw/searchRunFix

SearchKit - Fix incorrect pager count when using filters

3 years agoMerge pull request #21947 from colemanw/cssRules
Eileen McNaughton [Thu, 4 Nov 2021 03:35:46 +0000 (16:35 +1300)]
Merge pull request #21947 from colemanw/cssRules

SearchKit - Conditional style rules for rows/cells

3 years agoMerge pull request #21957 from eileenmcnaughton/lang
Eileen McNaughton [Thu, 4 Nov 2021 03:32:32 +0000 (16:32 +1300)]
Merge pull request #21957 from eileenmcnaughton/lang

Use null variables rather than isset in Core_Block

3 years agotransitionParticipants() - Improve $contactDetails cache maintenance
Tim Otten [Thu, 4 Nov 2021 03:26:27 +0000 (20:26 -0700)]
transitionParticipants() - Improve $contactDetails cache maintenance

This revises a very recent commit that touches `static $contactDetails` cache.

Imagine you have two calls to `transitionParticipants()` which involve different-but-overlapping sets:

* First invocation involves Alice and Bob
* Second invocation involves Bob and Carol

The first invocation loads Alice and Bob into `$contactDetails`.  The second
invocation identifies Carol as missing. We need to load Carol. Here's the change:

* Before: Carol overwrites Bob in `$contactDetails`. Bob goes missing.
* After: Alice, Bob, and Carol all exist in `$contactDetails`.

3 years agoMerge pull request #21942 from mattwire/gccachedrop
Eileen McNaughton [Thu, 4 Nov 2021 02:50:57 +0000 (15:50 +1300)]
Merge pull request #21942 from mattwire/gccachedrop

GroupContactCache: Drop temp table *after* releasing lock

3 years agoRemove call to getTokenDetails
Eileen McNaughton [Wed, 3 Nov 2021 21:27:16 +0000 (10:27 +1300)]
Remove call to getTokenDetails

This is tested vi CRM_Event_Form_Task_BatchTest::testSubmitCancel

3 years agoMerge pull request #21971 from civicrm/5.43
Seamus Lee [Thu, 4 Nov 2021 01:09:20 +0000 (12:09 +1100)]
Merge pull request #21971 from civicrm/5.43

5.43

3 years agoMerge pull request #21953 from agileware/CIVICRM-1881
Seamus Lee [Thu, 4 Nov 2021 00:05:46 +0000 (11:05 +1100)]
Merge pull request #21953 from agileware/CIVICRM-1881

User experience improvement - CiviCRM Manage Events page, expand the Find Events criteria by default

3 years agoMerge pull request #21970 from seamuslee001/regen
Seamus Lee [Thu, 4 Nov 2021 00:01:10 +0000 (11:01 +1100)]
Merge pull request #21970 from seamuslee001/regen

[REF] Regenerate generated civicrm file after recent template updates

3 years agoMerge pull request #21964 from eileenmcnaughton/dom_tok
Seamus Lee [Wed, 3 Nov 2021 23:07:49 +0000 (10:07 +1100)]
Merge pull request #21964 from eileenmcnaughton/dom_tok

Remove calls to CRM_Utils_Token::getDomainTokenReplacement

3 years agoMerge pull request #21969 from agh1/5.43.0-releasenotes-final
Seamus Lee [Wed, 3 Nov 2021 22:18:20 +0000 (09:18 +1100)]
Merge pull request #21969 from agh1/5.43.0-releasenotes-final

5.43.0 release notes: final updates

3 years ago[REF] Regenerate generated civicrm file after recent template updates
Seamus Lee [Wed, 3 Nov 2021 22:16:32 +0000 (09:16 +1100)]
[REF] Regenerate generated civicrm file after recent template updates

3 years ago5.43.0 release notes: final updates
Andie Hunt [Wed, 3 Nov 2021 22:15:25 +0000 (18:15 -0400)]
5.43.0 release notes: final updates

3 years agoRemove calls to CRM_Utils_Token::getDomainTokenReplacement
Eileen McNaughton [Wed, 3 Nov 2021 03:23:18 +0000 (16:23 +1300)]
Remove calls to CRM_Utils_Token::getDomainTokenReplacement

These values are no longer used ....

3 years agoMerge pull request #21963 from eileenmcnaughton/part_template
Eileen McNaughton [Wed, 3 Nov 2021 21:25:12 +0000 (10:25 +1300)]
Merge pull request #21963 from eileenmcnaughton/part_template

Remove remaining usages of contact & domain values in participant templates

3 years agoSearchKit - Improve pseudoconstant support & tests for SearchDisplay::getDefault
Coleman Watts [Wed, 3 Nov 2021 19:55:59 +0000 (15:55 -0400)]
SearchKit - Improve pseudoconstant support & tests for SearchDisplay::getDefault

3 years agoSearchKit - Fix incorrect pager count when using filters
Coleman Watts [Wed, 3 Nov 2021 18:34:08 +0000 (14:34 -0400)]
SearchKit - Fix incorrect pager count when using filters

Fixes a bug where filters were not being applied correctly when fetching rowCount

3 years agoMerge pull request #21965 from civicrm/5.43
demeritcowboy [Wed, 3 Nov 2021 15:32:35 +0000 (11:32 -0400)]
Merge pull request #21965 from civicrm/5.43

5.43

3 years agoMerge pull request #21962 from seamuslee001/fix_translation_tests
demeritcowboy [Wed, 3 Nov 2021 12:42:46 +0000 (08:42 -0400)]
Merge pull request #21962 from seamuslee001/fix_translation_tests

[NFC] Update Tests to match case in the latest l10n files

3 years ago[NFC] Update Tests to match case in the latest l10n files
Seamus Lee [Wed, 3 Nov 2021 03:00:22 +0000 (14:00 +1100)]
[NFC] Update Tests to match case in the latest l10n files

3 years agoMerge pull request #21961 from seamuslee001/fix_participant_cancelled_html
Seamus Lee [Wed, 3 Nov 2021 03:48:33 +0000 (14:48 +1100)]
Merge pull request #21961 from seamuslee001/fix_participant_cancelled_html

[REF] Update date formatting in the html template to match the text t…

3 years agoRemove remaining usages of contact & domain values in participant templates
Eileen McNaughton [Wed, 3 Nov 2021 03:11:49 +0000 (16:11 +1300)]
Remove remaining usages of contact & domain values in participant templates

3 years ago[REF] Update date formatting in the html template to match the text template and...
Seamus Lee [Wed, 3 Nov 2021 02:01:45 +0000 (13:01 +1100)]
[REF] Update date formatting in the html template to match the text template and regenerate civicrm_generated file

3 years agoMerge pull request #21937 from eileenmcnaughton/upit
Seamus Lee [Wed, 3 Nov 2021 01:57:04 +0000 (12:57 +1100)]
Merge pull request #21937 from eileenmcnaughton/upit

Add test for selvSvcUpdate, switch to using tokens

3 years agoAdd test for selvSvcUpdate, switch to using tokens
Eileen McNaughton [Fri, 29 Oct 2021 09:09:48 +0000 (22:09 +1300)]
Add test for selvSvcUpdate, switch to using tokens

3 years agoMerge pull request #21955 from colemanw/managedEntity
Seamus Lee [Tue, 2 Nov 2021 22:42:46 +0000 (09:42 +1100)]
Merge pull request #21955 from colemanw/managedEntity

APIv4 - Add managed entity functionality

3 years agoAPIv4 - Provide pseudo-fields and Revert action for managed entities
Coleman Watts [Mon, 1 Nov 2021 13:43:56 +0000 (09:43 -0400)]
APIv4 - Provide pseudo-fields and Revert action for managed entities

This new "ManagedEntity" trait provides 2 extra fields and a Revert action
to facilitate UIs which show the managed state and a revert button,
similar to the AfformAdmin UI.

3 years agoSearchKit - Conditional style rules per-row & per-field
Coleman Watts [Sun, 31 Oct 2021 16:29:00 +0000 (12:29 -0400)]
SearchKit - Conditional style rules per-row & per-field

3 years agoMerge pull request #21929 from colemanw/searchKitDefaultDisplays
Eileen McNaughton [Tue, 2 Nov 2021 05:31:50 +0000 (18:31 +1300)]
Merge pull request #21929 from colemanw/searchKitDefaultDisplays

SearchKit - default displays and ACL-aware links

3 years agoMerge pull request #21959 from civicrm/5.43
Seamus Lee [Tue, 2 Nov 2021 03:32:40 +0000 (14:32 +1100)]
Merge pull request #21959 from civicrm/5.43

5.43

3 years agoMerge pull request #21958 from seamuslee001/fix_token_rendering_campaign_legacy_php8
Seamus Lee [Tue, 2 Nov 2021 03:26:11 +0000 (14:26 +1100)]
Merge pull request #21958 from seamuslee001/fix_token_rendering_campaign_legacy_php8

[REF] Fix pseduoconstant token rendering for contributions via legacy…

3 years agoSearchKit - Fix action checkboxes to work with any key
Coleman Watts [Tue, 2 Nov 2021 00:28:35 +0000 (20:28 -0400)]
SearchKit - Fix action checkboxes to work with any key

Lifts the assumption that every entity has a key column named "id"

3 years agoSearchKit - Default label when adding a display
Coleman Watts [Tue, 2 Nov 2021 00:43:01 +0000 (20:43 -0400)]
SearchKit - Default label when adding a display

3 years ago[REF] Fix pseduoconstant token rendering for contributions via legacy way on php8...
Seamus Lee [Tue, 2 Nov 2021 00:41:15 +0000 (00:41 +0000)]
[REF] Fix pseduoconstant token rendering for contributions via legacy way on php8 and include campaign_id pseudoconsntants as well

3 years agoMerge pull request #21934 from eileenmcnaughton/empty
demeritcowboy [Mon, 1 Nov 2021 23:20:28 +0000 (19:20 -0400)]
Merge pull request #21934 from eileenmcnaughton/empty

Ensure no_licence is assigned for drop.tpl

3 years agoMerge pull request #21952 from eileenmcnaughton/im
colemanw [Mon, 1 Nov 2021 23:15:18 +0000 (19:15 -0400)]
Merge pull request #21952 from eileenmcnaughton/im

Handling for intermittent Im->getfields error

3 years agoUse null variables rather than isset in Core_Block
Eileen McNaughton [Mon, 1 Nov 2021 21:23:03 +0000 (10:23 +1300)]
Use null variables rather than isset in Core_Block

This removes an isset from LangSwitch and some enotices that we see if escape on output is enabled.

'langSwitch' is normally always assigned by the smarty initialize but for some reason not via this path

3 years agoUse empty not isset in drop.tpl
Eileen McNaughton [Fri, 29 Oct 2021 01:06:39 +0000 (14:06 +1300)]
Use empty not isset in drop.tpl

On experimenting a little with smarty escaping it turns out that isset is gonna be
a lot more painful than empty - we should avoid where we can. In this case it
is passed in as TRUE or not at all (from schema.tpl) so an empty check is just fine

3 years agoMerge pull request #21948 from braders/hardcoded-error-text
demeritcowboy [Mon, 1 Nov 2021 16:03:41 +0000 (12:03 -0400)]
Merge pull request #21948 from braders/hardcoded-error-text

Avoid hardcoded text in error strings; make translatable

3 years agoMerge pull request #21954 from braders/avoid-hardcoded-period-type-labels
demeritcowboy [Mon, 1 Nov 2021 15:53:43 +0000 (11:53 -0400)]
Merge pull request #21954 from braders/avoid-hardcoded-period-type-labels

Don't hardcode Period Type in Manage Premiums template.

3 years agoDon't hardcode Period Type in Manage Premiums template.
Bradley Taylor [Mon, 1 Nov 2021 13:41:38 +0000 (13:41 +0000)]
Don't hardcode Period Type in Manage Premiums template.

3 years agoCIVICRM-1881 CiviCRM Manage Events page, Find Events criteria is hidden by default...
Justin Freeman [Mon, 1 Nov 2021 05:51:28 +0000 (16:51 +1100)]
CIVICRM-1881 CiviCRM Manage Events page, Find Events criteria is hidden by default because the section is collapsed. End users cannot see any of the search options, by default and this causes confusion

3 years agoMerge pull request #21949 from braders/harcoded-setstatus-text
Seamus Lee [Mon, 1 Nov 2021 01:26:09 +0000 (12:26 +1100)]
Merge pull request #21949 from braders/harcoded-setstatus-text

Avoid harcoded text in setStatus calls; make translatable

3 years agoMerge pull request #21951 from eileenmcnaughton/messages
Eileen McNaughton [Mon, 1 Nov 2021 01:14:03 +0000 (14:14 +1300)]
Merge pull request #21951 from eileenmcnaughton/messages

Ensure communityMessages is assigned to the template.

3 years agoEnsure communityMessages is assigned to the template.
Eileen McNaughton [Sun, 31 Oct 2021 21:38:57 +0000 (10:38 +1300)]
Ensure communityMessages is assigned to the template.

This is a minor code simplification & ensures the parameter is set rather than
handling it not being set at the template level

3 years agoHandling for intermittent Im->getfields error
Eileen McNaughton [Sun, 31 Oct 2021 22:09:24 +0000 (11:09 +1300)]
Handling for intermittent Im->getfields error

I'm not quite sure when this started but I've been seeing Im->getfields not found errors of late - this helps

3 years agoMerge pull request #21950 from braders/misc-hardcoded-strings
Eileen McNaughton [Sun, 31 Oct 2021 20:28:29 +0000 (09:28 +1300)]
Merge pull request #21950 from braders/misc-hardcoded-strings

Make miscellaneous strings translatable

3 years agoMerge pull request #21946 from braders/dedupe-find-label-associations
Eileen McNaughton [Sun, 31 Oct 2021 19:57:54 +0000 (08:57 +1300)]
Merge pull request #21946 from braders/dedupe-find-label-associations

Accessibility: Fix label associations for DepupeFind template.

3 years agoAvoid hardcoded text in setStatus calls; make translatable
Bradley Taylor [Sun, 31 Oct 2021 18:03:35 +0000 (18:03 +0000)]
Avoid hardcoded text in setStatus calls; make translatable

3 years agoSearchKit - Expose default display to the UI
Coleman Watts [Thu, 28 Oct 2021 13:52:25 +0000 (09:52 -0400)]
SearchKit - Expose default display to the UI

Adds a 'view' link to the searchKit admin listing, which links to the default display
Adds a 'view' dropdown to the compose search screen, with links to the default + all other displays
Updates Afform to work with default search displays

3 years agoMake miscellaneous translatable
Bradley Taylor [Sun, 31 Oct 2021 18:05:24 +0000 (18:05 +0000)]
Make miscellaneous translatable

3 years agoAvoid hardcoded text in error strings; make translatable
Bradley Taylor [Sun, 31 Oct 2021 17:55:54 +0000 (17:55 +0000)]
Avoid hardcoded text in error strings; make translatable

3 years agoSearchKit - Only show tags filter if tags exist
Coleman Watts [Thu, 28 Oct 2021 13:50:36 +0000 (09:50 -0400)]
SearchKit - Only show tags filter if tags exist

Remove clutter if an org does not use tags.
Also removes an unused copy-pasted function.

3 years agoSearchKit - Set links in admin UI using entity+action+join instead of path
Coleman Watts [Wed, 27 Oct 2021 18:38:18 +0000 (14:38 -0400)]
SearchKit - Set links in admin UI using entity+action+join instead of path

Now that SearchDisplay.Run understands this new link syntax, the admin UI
can use it too. The old links set in existing search displays will still work,
but in order for ACLs to be checked they need to use the new syntax.

3 years agoSearchKit - Check ACLs before displaying links or in-place edit
Coleman Watts [Wed, 27 Oct 2021 14:44:29 +0000 (10:44 -0400)]
SearchKit - Check ACLs before displaying links or in-place edit

3 years agoSearchKit - Autogenerate default display table for saved searches; calculate links...
Coleman Watts [Wed, 27 Oct 2021 05:22:23 +0000 (01:22 -0400)]
SearchKit - Autogenerate default display table for saved searches; calculate links by entity+action

This adds a SearchDisplay.getDefault APIv4 action, which autogenerates the default table display
which is used on the admin screen.

It also refactors links so they can be calculated based on a given entity+action which does not
require paths to be stored in the search display.

3 years agoAccessibility: Fix label associations for DepupeFind template.
Bradley Taylor [Sun, 31 Oct 2021 14:08:50 +0000 (14:08 +0000)]
Accessibility: Fix label associations for DepupeFind template.

This ensures that the labels have an accessible name for assistive technologies.

3 years agoGroupContactCache: Drop temp table after releasing lock
Matthew Wire [Sat, 30 Oct 2021 16:32:51 +0000 (17:32 +0100)]
GroupContactCache: Drop temp table after releasing lock

3 years agoMerge pull request #21931 from eileenmcnaughton/ple
demeritcowboy [Fri, 29 Oct 2021 23:48:34 +0000 (19:48 -0400)]
Merge pull request #21931 from eileenmcnaughton/ple

Convert more tests to use full form flow

3 years agoDo not pass test-blocked parameter to function that doesn't use it
Eileen McNaughton [Thu, 28 Oct 2021 22:56:52 +0000 (11:56 +1300)]
Do not pass test-blocked parameter to function that doesn't use it

3 years agoMerge pull request #21938 from mattwire/groupcontactcacheunused
Seamus Lee [Fri, 29 Oct 2021 20:07:34 +0000 (07:07 +1100)]
Merge pull request #21938 from mattwire/groupcontactcacheunused

Remove unused function from GroupContactCache

3 years agoConvert more tests to use full form flow
Eileen McNaughton [Thu, 28 Oct 2021 22:55:34 +0000 (11:55 +1300)]
Convert more tests to use full form flow

3 years agoRemove unused function
Matthew Wire [Fri, 29 Oct 2021 18:04:11 +0000 (19:04 +0100)]
Remove unused function

3 years agoMerge pull request #21855 from eileenmcnaughton/part
Monish Deb [Fri, 29 Oct 2021 05:05:54 +0000 (10:35 +0530)]
Merge pull request #21855 from eileenmcnaughton/part

Add test for selvsvctransfer, remove use of `$contact` from template

3 years agoMerge pull request #21930 from colemanw/removeCxn
Eileen McNaughton [Fri, 29 Oct 2021 04:51:12 +0000 (17:51 +1300)]
Merge pull request #21930 from colemanw/removeCxn

Remove "Connections" from navigation menu

3 years agoMerge pull request #21932 from eileenmcnaughton/quotes
Eileen McNaughton [Fri, 29 Oct 2021 02:17:56 +0000 (15:17 +1300)]
Merge pull request #21932 from eileenmcnaughton/quotes

[NFC] [Tests] remove code smell - unnecessary double quotes

3 years agoFixes dev/core#2910 - Remove "Connections" from navigation menu
Coleman Watts [Thu, 28 Oct 2021 22:22:01 +0000 (18:22 -0400)]
Fixes dev/core#2910 - Remove "Connections" from navigation menu

This obscure feature is currently unused, so there's no reason to show it in the menu.
Fixes https://lab.civicrm.org/dev/core/-/issues/2910

3 years ago[NFC] [Tests] remove code smell - unnecessary double quotes
Eileen McNaughton [Thu, 28 Oct 2021 23:04:46 +0000 (12:04 +1300)]
[NFC] [Tests] remove code smell - unnecessary double quotes

This is an IDE cleanup. It touches a few files but
1) only test files and
2) only that specific change, made via an IDE is in here

So I think it should be possible to merge based on test outcome

3 years agoMerge pull request #21790 from eileenmcnaughton/greetings_earthling
colemanw [Thu, 28 Oct 2021 21:39:02 +0000 (17:39 -0400)]
Merge pull request #21790 from eileenmcnaughton/greetings_earthling

Switch replaceGreetingTokens over

3 years agoMerge pull request #21922 from jitendrapurohit/taskmenu
Eileen McNaughton [Thu, 28 Oct 2021 21:29:21 +0000 (10:29 +1300)]
Merge pull request #21922 from jitendrapurohit/taskmenu

dev/joomla#36 - Fix fatal error in joomla with civicrm task query param

3 years agoRegenerate sql
Eileen McNaughton [Mon, 25 Oct 2021 02:20:42 +0000 (15:20 +1300)]
Regenerate sql

3 years agoReplace call to getTokenDetails with simple contact.get
Eileen McNaughton [Mon, 18 Oct 2021 20:41:59 +0000 (09:41 +1300)]
Replace call to getTokenDetails with simple contact.get

3 years agoAdd test for selvsvctransfer, remove from template
Eileen McNaughton [Mon, 18 Oct 2021 20:14:09 +0000 (09:14 +1300)]
Add test for selvsvctransfer, remove from template