Coleman Watts [Wed, 27 Oct 2021 18:38:18 +0000 (14:38 -0400)]
SearchKit - Set links in admin UI using entity+action+join instead of path
Now that SearchDisplay.Run understands this new link syntax, the admin UI
can use it too. The old links set in existing search displays will still work,
but in order for ACLs to be checked they need to use the new syntax.
Coleman Watts [Wed, 27 Oct 2021 14:44:29 +0000 (10:44 -0400)]
SearchKit - Check ACLs before displaying links or in-place edit
Coleman Watts [Wed, 27 Oct 2021 05:22:23 +0000 (01:22 -0400)]
SearchKit - Autogenerate default display table for saved searches; calculate links by entity+action
This adds a SearchDisplay.getDefault APIv4 action, which autogenerates the default table display
which is used on the admin screen.
It also refactors links so they can be calculated based on a given entity+action which does not
require paths to be stored in the search display.
Monish Deb [Thu, 28 Oct 2021 15:03:00 +0000 (20:33 +0530)]
Merge pull request #21820 from colemanw/searchKitServerSideRender
SearchKit server-side rendering
Monish Deb [Thu, 28 Oct 2021 11:44:47 +0000 (17:14 +0530)]
Merge pull request #21925 from eileenmcnaughton/dom_from
Simplify usage of getting domain from email
Eileen McNaughton [Wed, 27 Oct 2021 23:13:13 +0000 (12:13 +1300)]
Merge pull request #21917 from braders/feature/translate-set-title-calls
Make hardcoded labels passed to setTitle translatable
demeritcowboy [Wed, 27 Oct 2021 22:21:40 +0000 (18:21 -0400)]
Merge pull request #21928 from eileenmcnaughton/usused
Remove unused function
Eileen McNaughton [Wed, 27 Oct 2021 19:59:11 +0000 (08:59 +1300)]
Remove unused function
Note we don't slow the removal down by adding deprecation notices for internal financial functions as they have
never been stable / supported for external use
demeritcowboy [Wed, 27 Oct 2021 15:12:14 +0000 (11:12 -0400)]
Merge pull request #21914 from eileenmcnaughton/trxn
[REF] Move another function to the FinancialProcessor
Coleman Watts [Sat, 23 Oct 2021 22:02:44 +0000 (18:02 -0400)]
SearchKit - Use server-side preprocessing for editable fields
Coleman Watts [Wed, 13 Oct 2021 02:19:45 +0000 (22:19 -0400)]
SearchKit - server-side rendering
Moves logic for resolving field values from the client to the server-side,
which gives more control over formatting, links, and greater consistency
of spreadsheet output.
Eileen McNaughton [Tue, 26 Oct 2021 19:13:22 +0000 (08:13 +1300)]
Simplify usage of getting domain from email
This adds a function that 'just gets the string' - rather than overloading
another function and (worse) getting the string back as an array that needs to be
'currented'. It also switches
the participant function to use it - as we will soon not be passing
domainValues into this function
Eileen McNaughton [Tue, 26 Oct 2021 18:27:56 +0000 (07:27 +1300)]
Merge pull request #21924 from civicrm/5.43
5.43 to master
Seamus Lee [Tue, 26 Oct 2021 05:12:46 +0000 (16:12 +1100)]
Merge pull request #21921 from eileenmcnaughton/gc
[NFC] [REF] Test class cleanup
demeritcowboy [Tue, 26 Oct 2021 03:56:05 +0000 (23:56 -0400)]
Merge pull request #21913 from eileenmcnaughton/worddoc
dev/core#2864 fix for rc breakage in pdf-letter-to-word
Eileen McNaughton [Sat, 23 Oct 2021 04:08:32 +0000 (17:08 +1300)]
dev/core#2864 fix for rc breakage in pdf-letter-to-word
Eileen McNaughton [Mon, 25 Oct 2021 19:37:41 +0000 (08:37 +1300)]
Merge pull request #21853 from colemanw/allCoreTables
AllCoreTables - Allow virtual entities to share a DAO class
demeritcowboy [Mon, 25 Oct 2021 13:53:02 +0000 (09:53 -0400)]
Merge pull request #21907 from eileenmcnaughton/tests
Fix a few more tests to use a more realistic flow
demeritcowboy [Mon, 25 Oct 2021 13:50:05 +0000 (09:50 -0400)]
Merge pull request #21906 from eileenmcnaughton/cont_test
Fix more tests to use the full form flow
Coleman Watts [Mon, 18 Oct 2021 14:54:03 +0000 (10:54 -0400)]
AllCoreTables - Allow virtual entities to share a DAO class
Indexes entities by brief name instead of class name,
which allows one class to be shared by multiple entities.
Eileen McNaughton [Sun, 24 Oct 2021 23:27:26 +0000 (12:27 +1300)]
[NFC] [REF] Test class cleanup
The driver for this was to remove uses of the DAO->createTestObject methods which were creating
individuals with data invalid for them. However, this is a full 'margin cleanup' and
standardises the test.
I think the whole createTestObject approach is best viewed as an early attempt to get
lots of entities testable quickly but it's overwraught for creating contacts
(and generally a bit flakey)
Eileen McNaughton [Sun, 24 Oct 2021 21:25:20 +0000 (10:25 +1300)]
Merge pull request #21920 from colemanw/getInfoItemCache
APIv4 - Fix performance drag caused by getInfoItem calling the API
Eileen McNaughton [Sun, 24 Oct 2021 02:56:38 +0000 (15:56 +1300)]
Merge pull request #21918 from braders/feature/spelling-fixes
Miscellaneous spelling fixes
Coleman Watts [Sat, 23 Oct 2021 23:27:21 +0000 (19:27 -0400)]
APIv4 - Fix performance drag caused by getInfoItem calling the API
This function is sometimes called thousands of times per request, e.g. for every cell
in a searchKit display table. Going through the API wrapper that many times is a
considerable (+10 sec) drag on performance.
Instead of calling Entity.get, we can just read directly from the cache where it stores its data.
Bradley Taylor [Sat, 23 Oct 2021 11:09:44 +0000 (12:09 +0100)]
Miscellaneous spelling fixes
colemanw [Sat, 23 Oct 2021 19:14:48 +0000 (15:14 -0400)]
Merge pull request #21915 from eileenmcnaughton/protext
[Ref] Make functions private to protect them
demeritcowboy [Sat, 23 Oct 2021 13:46:43 +0000 (09:46 -0400)]
Merge pull request #21847 from eileenmcnaughton/pledge2
Standardise our 2 pledge templates to use tokens, add tests
Bradley Taylor [Sat, 23 Oct 2021 10:52:00 +0000 (11:52 +0100)]
Translate hardcoded labels passed to setTitle
Eileen McNaughton [Sat, 23 Oct 2021 04:40:19 +0000 (17:40 +1300)]
[REF] Move another function to the FinancialProcessor
At this stage just moving all the financial processing functions to the same class
Eileen McNaughton [Sat, 23 Oct 2021 04:43:59 +0000 (17:43 +1300)]
[Ref] Make functions private to protect them
As we move functions to this class making them private once they are unused outside the class
makes it easier to clean them up
Eileen McNaughton [Sat, 16 Oct 2021 23:23:19 +0000 (12:23 +1300)]
Switch pledge_reminder over to use tokens
Eileen McNaughton [Sat, 16 Oct 2021 22:37:47 +0000 (11:37 +1300)]
Update pledge acknowledgement to use token processor only
Eileen McNaughton [Mon, 11 Oct 2021 05:23:27 +0000 (18:23 +1300)]
Add test for domain, contact tokens in pledge
Eileen McNaughton [Sat, 23 Oct 2021 04:28:43 +0000 (17:28 +1300)]
Merge pull request #21910 from eileenmcnaughton/new_validate
Fix cleanup on test, also NFC cleanup
Eileen McNaughton [Sat, 23 Oct 2021 02:36:30 +0000 (15:36 +1300)]
Merge pull request #21692 from demeritcowboy/dbssl
Fix unreplaced template vars in civicrm.settings.php when using legacy installer
Eileen McNaughton [Sat, 23 Oct 2021 01:24:22 +0000 (14:24 +1300)]
Fix cleanup on test, also NFC cleanup
This test was not cleaning itself up very well in the tearDown - causing the post test validate to fail
Eileen McNaughton [Fri, 22 Oct 2021 23:53:54 +0000 (12:53 +1300)]
Merge pull request #21904 from braders/feature/remove-from-tag-translatable-errors
Make error message translatable - remove tag tasks.
Eileen McNaughton [Fri, 22 Oct 2021 23:53:18 +0000 (12:53 +1300)]
Merge pull request #21905 from braders/feature/add-to-group-translatable-errors
Make error messages translatable.
Eileen McNaughton [Fri, 22 Oct 2021 21:54:17 +0000 (10:54 +1300)]
Fix a few more tests to use a more realistic flow
Eileen McNaughton [Fri, 22 Oct 2021 21:28:31 +0000 (10:28 +1300)]
Fix more tests to use the full form flow
Bradley Taylor [Fri, 22 Oct 2021 20:33:11 +0000 (21:33 +0100)]
Make error messages translatable.
Eileen McNaughton [Fri, 22 Oct 2021 20:29:07 +0000 (09:29 +1300)]
Merge pull request #21892 from artfulrobot/artfulrobot-order-membership
Improve tests around the Order.create API and membership
demeritcowboy [Fri, 22 Oct 2021 20:25:59 +0000 (16:25 -0400)]
fix unreplaced template vars when using legacy installer
Bradley Taylor [Fri, 22 Oct 2021 20:25:18 +0000 (21:25 +0100)]
Make error message translatable.
Also fix typo (space between 'at least')
demeritcowboy [Fri, 22 Oct 2021 15:50:52 +0000 (11:50 -0400)]
Merge pull request #21848 from eileenmcnaughton/valid
Add financial validation check (to the extent we can)
demeritcowboy [Fri, 22 Oct 2021 15:04:24 +0000 (11:04 -0400)]
Merge pull request #21863 from mariav0/patch-6
Update contribution_recurring_billing_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:04:04 +0000 (11:04 -0400)]
Merge pull request #21850 from mariav0/patch-1
Update contribution_online_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:03:37 +0000 (11:03 -0400)]
Merge pull request #21888 from mariav0/patch-26
Update test_preview_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:03:20 +0000 (11:03 -0400)]
Merge pull request #21890 from mariav0/patch-28
Update contribution_invoice_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:03:07 +0000 (11:03 -0400)]
Merge pull request #21889 from mariav0/patch-27
Update uf_notify_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:02:52 +0000 (11:02 -0400)]
Merge pull request #21887 from mariav0/patch-25
Update pledge_reminder_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:02:40 +0000 (11:02 -0400)]
Merge pull request #21886 from mariav0/patch-24
Update pledge_acknowledge_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:02:27 +0000 (11:02 -0400)]
Merge pull request #21885 from mariav0/patch-23
Update pcp_supporter_notify_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:01:50 +0000 (11:01 -0400)]
Merge pull request #21884 from mariav0/patch-22
Update pcp_status_change_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:01:38 +0000 (11:01 -0400)]
Merge pull request #21883 from mariav0/patch-21
Update pcp_notify_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:01:24 +0000 (11:01 -0400)]
Merge pull request #21882 from mariav0/patch-20
Update payment_or_refund_notification_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:01:10 +0000 (11:01 -0400)]
Merge pull request #21881 from mariav0/patch-19
Update participant_transferred_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:00:53 +0000 (11:00 -0400)]
Merge pull request #21880 from mariav0/patch-18
Update participant_expired_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:00:36 +0000 (11:00 -0400)]
Merge pull request #21879 from mariav0/patch-17
Update participant_confirm_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:00:23 +0000 (11:00 -0400)]
Merge pull request #21878 from mariav0/patch-16
Update participant_cancelled_html.tpl
demeritcowboy [Fri, 22 Oct 2021 15:00:10 +0000 (11:00 -0400)]
Merge pull request #21877 from mariav0/patch-15
Update membership_online_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:59:55 +0000 (10:59 -0400)]
Merge pull request #21876 from mariav0/patch-14
Update membership_offline_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:59:43 +0000 (10:59 -0400)]
Merge pull request #21875 from mariav0/patch-13
Update membership_autorenew_cancelled_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:59:26 +0000 (10:59 -0400)]
Merge pull request #21874 from mariav0/patch-12
Update membership_autorenew_billing_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:59:08 +0000 (10:59 -0400)]
Merge pull request #21873 from mariav0/patch-11
Update friend_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:58:52 +0000 (10:58 -0400)]
Merge pull request #21872 from mariav0/patch-10
Update event_online_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:58:32 +0000 (10:58 -0400)]
Merge pull request #21871 from mariav0/patch-9
Update event_offline_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:58:15 +0000 (10:58 -0400)]
Merge pull request #21870 from mariav0/patch-8
Update contribution_recurring_edit_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:58:00 +0000 (10:58 -0400)]
Merge pull request #21869 from mariav0/patch-7
Update contribution_recurring_cancelled_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:57:42 +0000 (10:57 -0400)]
Merge pull request #21862 from mariav0/patch-5
Update contribution_offline_receipt_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:57:24 +0000 (10:57 -0400)]
Merge pull request #21861 from mariav0/patch-4
Update contribution_dupalert_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:57:11 +0000 (10:57 -0400)]
Merge pull request #21860 from mariav0/patch-3
Update case_activity_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:56:47 +0000 (10:56 -0400)]
Merge pull request #21859 from mariav0/patch-2
Update contribution_recurring_notify_html.tpl
demeritcowboy [Fri, 22 Oct 2021 14:55:20 +0000 (10:55 -0400)]
Merge pull request #21176 from mattwire/unsubscribesmartgroups
Handle checking smartgroups when generating list of groups to unsubscribe
demeritcowboy [Fri, 22 Oct 2021 12:48:23 +0000 (08:48 -0400)]
Merge pull request #21857 from colemanw/saveMatch
APIv4 - Add 'match' param to save action
demeritcowboy [Fri, 22 Oct 2021 12:47:25 +0000 (08:47 -0400)]
Merge pull request #21903 from eileenmcnaughton/ref
Remove unnecessary pass-by-reference
Rich Lott / Artful Robot [Fri, 22 Oct 2021 11:36:53 +0000 (12:36 +0100)]
Add tests to Order create re memberships
Monish Deb [Fri, 22 Oct 2021 07:27:19 +0000 (12:57 +0530)]
Merge pull request #21391 from eileenmcnaughton/fp
dev/core#2715 remove the mystery self::_trxns property
Eileen McNaughton [Fri, 22 Oct 2021 03:59:52 +0000 (16:59 +1300)]
Merge pull request #21644 from sunilpawar/processed_token
show processed token in greeting dropdown
Eileen McNaughton [Fri, 22 Oct 2021 03:32:36 +0000 (16:32 +1300)]
Merge pull request #21697 from agileware/CIVICRM-1858
CiviCRM APIv3, Improve API Exception error message when trying to subscribe to a non-Public Mailing Group
Eileen McNaughton [Fri, 22 Oct 2021 03:27:40 +0000 (16:27 +1300)]
Remove unnecessary pass-by-reference
Eileen McNaughton [Fri, 22 Oct 2021 03:02:48 +0000 (16:02 +1300)]
Merge pull request #21813 from christianwach/lab-core-2909
Repair "Norwegian Bokmål" string
Coleman Watts [Tue, 19 Oct 2021 00:09:52 +0000 (20:09 -0400)]
APIv4 - Add 'match' param to save action
This works similarly to the 'match' param in v3 `create`,
it checks for records matching the given fields, and will update instead of create
if an existing record is found.
Seamus Lee [Thu, 21 Oct 2021 23:47:11 +0000 (10:47 +1100)]
Merge pull request #21902 from eileenmcnaughton/tok
Add help tip to comment block
Eileen McNaughton [Thu, 21 Oct 2021 23:04:18 +0000 (12:04 +1300)]
Merge pull request #21351 from colemanw/spreadsheetFormats
SearchKit - Support download formats xlsx, ods, pdf
Eileen McNaughton [Thu, 21 Oct 2021 21:42:27 +0000 (10:42 +1300)]
Merge pull request #21573 from demeritcowboy/null-null
Change DAO's that have `'default' => 'NULL'` into `'default' => NULL`, i.e. true NULL
Eileen McNaughton [Thu, 21 Oct 2021 21:00:04 +0000 (10:00 +1300)]
Add help tip
Eileen McNaughton [Thu, 21 Oct 2021 20:41:05 +0000 (09:41 +1300)]
Merge pull request #21893 from MegaphoneJon/minute-as-recurring-unit
add 'minute' as recurring unit
Eileen McNaughton [Thu, 21 Oct 2021 20:39:20 +0000 (09:39 +1300)]
Merge pull request #21901 from civicrm/5.43
5.43 to master
Eileen McNaughton [Thu, 21 Oct 2021 20:29:36 +0000 (09:29 +1300)]
Merge pull request #21894 from colemanw/sortable
[Unreleased Regression] SearchKit - Fix console errors when adding non-field columns
Eileen McNaughton [Thu, 21 Oct 2021 19:59:46 +0000 (08:59 +1300)]
Merge pull request #21900 from herbdool/backdrop-2
Correct CMS name on profile UF group types
Herb v/d Dool [Thu, 21 Oct 2021 17:10:24 +0000 (13:10 -0400)]
Show correct CMS name for profile uf group types
demeritcowboy [Thu, 21 Oct 2021 13:47:32 +0000 (09:47 -0400)]
Merge pull request #21897 from mattwire/alterpaymenthookparams
Update docblock for alterPaymentProcessorParams because rawParams might be a payment propertyBag
colemanw [Thu, 21 Oct 2021 13:46:14 +0000 (09:46 -0400)]
Merge pull request #21898 from jensschuppe/afformUndefinedIndexNotice
Prevent Undefined Index PHP notices with Afform entity metadata without an icon
Jens Schuppe [Thu, 21 Oct 2021 10:18:26 +0000 (12:18 +0200)]
Prevent Undefined Index PHP notices with Afform entity metadata without an icon
Matthew Wire [Thu, 21 Oct 2021 08:54:49 +0000 (09:54 +0100)]
Update docblock for alterPaymentProcessorParams because rawParams might be a payment propertyBag
Coleman Watts [Wed, 20 Oct 2021 18:50:51 +0000 (14:50 -0400)]
SearchKit - Fix console errors when adding non-field columns
Eileen McNaughton [Wed, 20 Oct 2021 20:31:03 +0000 (09:31 +1300)]
Merge pull request #21891 from colemanw/initHideBoxes
Export - Fix undefined tpl var
Jon Goldberg [Wed, 20 Oct 2021 17:13:03 +0000 (13:13 -0400)]
add 'minute' as recurring unit
Rich Lott / Artful Robot [Wed, 20 Oct 2021 15:59:45 +0000 (16:59 +0100)]
Fix test assertions that were the wrong way around (expected, actual)