Eileen McNaughton [Mon, 15 Aug 2022 22:29:04 +0000 (10:29 +1200)]
Finish removing refs to unused activeFields
Eileen McNaughton [Mon, 15 Aug 2022 22:25:28 +0000 (10:25 +1200)]
Remove setActiveField
Eileen McNaughton [Mon, 15 Aug 2022 22:24:04 +0000 (10:24 +1200)]
Remove another no-longer-used function
colemanw [Mon, 15 Aug 2022 20:04:31 +0000 (16:04 -0400)]
Merge pull request #24217 from eileenmcnaughton/map
[Import] [Ref] Extract shared form rule code
demeritcowboy [Mon, 15 Aug 2022 18:06:31 +0000 (14:06 -0400)]
Merge pull request #24262 from demeritcowboy/file-on-case
[NFC] Add test for editing activity subject to file on case
demeritcowboy [Mon, 15 Aug 2022 13:54:40 +0000 (09:54 -0400)]
add test for editing activity subject to file on case
Eileen McNaughton [Mon, 15 Aug 2022 10:43:43 +0000 (22:43 +1200)]
Merge pull request #24253 from bjendres/patch-1
Add hint to create membership "You do not have all the permissions needed for this page" message
Seamus Lee [Mon, 15 Aug 2022 02:52:31 +0000 (12:52 +1000)]
Merge pull request #24257 from civicrm/5.53
5.53
Seamus Lee [Mon, 15 Aug 2022 02:02:26 +0000 (12:02 +1000)]
Merge pull request #24250 from demeritcowboy/set-alias
dev/core#3802 - Compatibility with symfony 6 for drupal 10 for listeners added via getSubscribedEvents
Seamus Lee [Mon, 15 Aug 2022 01:05:14 +0000 (11:05 +1000)]
Merge pull request #24256 from seamuslee001/5.53
[NFC] Convert Payment Processor ID field to payment processor in even…
demeritcowboy [Sun, 14 Aug 2022 01:08:28 +0000 (21:08 -0400)]
symfony 6 compatiblity
demeritcowboy [Sun, 14 Aug 2022 23:31:47 +0000 (19:31 -0400)]
Merge pull request #24249 from colemanw/goodbyeRevisions
dev/core#1532 - Remove civicaseActivityRevisions setting & related code
Seamus Lee [Sun, 14 Aug 2022 23:02:52 +0000 (09:02 +1000)]
[NFC] Convert Payment Processor ID field to payment processor in event create in tests
colemanw [Sun, 14 Aug 2022 15:32:10 +0000 (11:32 -0400)]
Merge pull request #24252 from demeritcowboy/impossible
Remove unused impossible function in upgrade page
Coleman Watts [Sat, 13 Aug 2022 22:51:25 +0000 (18:51 -0400)]
CiviCase - Remove the civicaseActivityRevisions setting and related code
This setting has been deprecated for years, and core CiviCase doesn't respect it
anyway. Only the API was really paying attention to it. Time to get rid of that stuff
as a preamble to ripping out all of the case activity revisioning.
Björn Endres [Sun, 14 Aug 2022 14:55:04 +0000 (16:55 +0200)]
Add error hint
This exception is *also* raised, when no membership types have been configured yet, which can be very confusing. It cost me a two hours to figure out the real reason, and I have the nagging suspicion that this had happened to me before. I'm not too happy about the phrasing, but it would be good to have a reference to a potentially incomplete configuration. Thanks.
demeritcowboy [Sun, 14 Aug 2022 11:52:07 +0000 (07:52 -0400)]
unused impossible function
demeritcowboy [Sun, 14 Aug 2022 11:13:08 +0000 (07:13 -0400)]
Merge pull request #24251 from colemanw/activityCaseCleanupDoc
Fix processCaseActivity docblock
demeritcowboy [Sun, 14 Aug 2022 11:11:51 +0000 (07:11 -0400)]
Merge pull request #24247 from colemanw/activityCaseCleanup
[REF] Activity BAO - Decouple CiviCase logic from create function
Coleman Watts [Sun, 14 Aug 2022 03:40:50 +0000 (23:40 -0400)]
Fix processCaseActivity docblock
Coleman Watts [Sat, 13 Aug 2022 18:56:06 +0000 (14:56 -0400)]
Activity BAO - Decouple CiviCase logic from create function
A big chunk of civicase code was jammed into the Activity create function.
This moves it to the Case BAO.
colemanw [Sat, 13 Aug 2022 22:34:50 +0000 (18:34 -0400)]
Merge pull request #24248 from colemanw/deprecatedDaoProp
NFC - Make it possible to mark a dao field @deprecated
Coleman Watts [Sat, 13 Aug 2022 20:15:18 +0000 (16:15 -0400)]
NFC - Make it possible to mark a dao field @deprecated
colemanw [Sat, 13 Aug 2022 18:25:01 +0000 (14:25 -0400)]
Merge pull request #24246 from demeritcowboy/bool-again
Resolve existential crisis for customfield.is_active
demeritcowboy [Sat, 13 Aug 2022 12:48:39 +0000 (08:48 -0400)]
resolve existential crisis
demeritcowboy [Sat, 13 Aug 2022 12:17:08 +0000 (08:17 -0400)]
Merge pull request #24240 from civicrm/5.53
5.53
Tim Otten [Sat, 13 Aug 2022 01:16:50 +0000 (18:16 -0700)]
Merge pull request #24239 from colemanw/joinComments
APIv4 - Add comments and fix data type for contact location joins
Tim Otten [Fri, 12 Aug 2022 22:40:16 +0000 (15:40 -0700)]
Merge pull request #24238 from demeritcowboy/boo
dev/core#3799 - Fix incorrectly changed default for contact_dashboard.is_active
Tim Otten [Fri, 12 Aug 2022 22:33:49 +0000 (15:33 -0700)]
Merge pull request #24233 from demeritcowboy/zetapatookens
zetacomponents/mail - Ensure latest mail patches are included
Coleman Watts [Fri, 12 Aug 2022 21:27:09 +0000 (17:27 -0400)]
APIv4 - Add comments and fix data type for contact location joins
colemanw [Fri, 12 Aug 2022 19:46:18 +0000 (15:46 -0400)]
Merge pull request #24205 from eileenmcnaughton/obsolete
[Import-code-cleanup] Remove now-unused summary forms
colemanw [Fri, 12 Aug 2022 19:44:27 +0000 (15:44 -0400)]
Merge pull request #24226 from eileenmcnaughton/import_pledge_payment
Remove unreachable legacy code
demeritcowboy [Fri, 12 Aug 2022 17:02:57 +0000 (13:02 -0400)]
fix incorrectly changed default
demeritcowboy [Fri, 12 Aug 2022 13:25:35 +0000 (09:25 -0400)]
ensure latest mail patches are included
Seamus Lee [Thu, 11 Aug 2022 21:35:43 +0000 (07:35 +1000)]
Merge pull request #24231 from demeritcowboy/msgtpl-47
[REF] Remove unused message template upgrade code
colemanw [Thu, 11 Aug 2022 19:54:21 +0000 (15:54 -0400)]
Merge pull request #24225 from eileenmcnaughton/importable
Deprecate `BAO_Contribution::importableFields`
Eileen McNaughton [Thu, 11 Aug 2022 19:40:36 +0000 (07:40 +1200)]
Merge pull request #24191 from colemanw/civiGrantPerms
[REF] Decouple CiviGrant from core permission function
Eileen McNaughton [Thu, 11 Aug 2022 19:33:25 +0000 (07:33 +1200)]
Merge pull request #24229 from civicrm/5.53
5.53
Eileen McNaughton [Thu, 11 Aug 2022 19:28:25 +0000 (07:28 +1200)]
Merge pull request #24227 from eileenmcnaughton/mapping
Move non-shared function to private function on using class
demeritcowboy [Thu, 11 Aug 2022 14:27:13 +0000 (10:27 -0400)]
remove unused code
Eileen McNaughton [Thu, 11 Aug 2022 00:30:47 +0000 (12:30 +1200)]
Move non-shared function to private function on using class
demeritcowboy [Thu, 11 Aug 2022 12:37:09 +0000 (08:37 -0400)]
Merge pull request #24210 from eileenmcnaughton/goner
[Import-code-cleanup] Remove unused function
demeritcowboy [Thu, 11 Aug 2022 12:33:50 +0000 (08:33 -0400)]
Merge pull request #24214 from eileenmcnaughton/tpl
[Import-code-cleanup] Remove now-unused tpl
Matthew Wire [Thu, 11 Aug 2022 09:12:37 +0000 (10:12 +0100)]
Merge pull request #24194 from yashodha/dev-3141
(dev/core#3141) Membership should be listed chronologically by end da…
Seamus Lee [Thu, 11 Aug 2022 05:32:30 +0000 (15:32 +1000)]
Merge pull request #24224 from colemanw/fixSelect2AndNgOptions
CrmUi - Fix crmSelect2 to work with ngOptions
Seamus Lee [Thu, 11 Aug 2022 01:26:08 +0000 (11:26 +1000)]
Merge pull request #24165 from colemanw/afformExisting
Afform - add "Existing entity" selector
demeritcowboy [Thu, 11 Aug 2022 00:58:02 +0000 (20:58 -0400)]
Merge pull request #24223 from civicrm/5.53
5.53
demeritcowboy [Thu, 11 Aug 2022 00:51:33 +0000 (20:51 -0400)]
Merge pull request #24222 from herbdool/core-3796
dev/core#3796 include subtypes where filter > 0
colemanw [Thu, 11 Aug 2022 00:08:29 +0000 (20:08 -0400)]
Merge pull request #24216 from eileenmcnaughton/ds
Consolidate error handling on Custom data import tpl
Eileen McNaughton [Wed, 10 Aug 2022 22:03:14 +0000 (10:03 +1200)]
Remove always-the-same parameter
Seamus Lee [Wed, 10 Aug 2022 22:14:25 +0000 (08:14 +1000)]
Merge pull request #24220 from colemanw/customGroupFix
Fix regression causing custom groups to reset to 'Contact' when updated
Eileen McNaughton [Wed, 10 Aug 2022 22:07:42 +0000 (10:07 +1200)]
Remove unreachable legacy code
Eileen McNaughton [Wed, 10 Aug 2022 21:53:50 +0000 (09:53 +1200)]
Deprecated BAO_Contribution::importableFields
demeritcowboy [Wed, 10 Aug 2022 21:48:49 +0000 (17:48 -0400)]
Merge pull request #24199 from colemanw/searchKitNew
SearchKit - Use combo button+dropdown for creating new search or segment
Eileen McNaughton [Wed, 10 Aug 2022 21:39:34 +0000 (09:39 +1200)]
Stop calling BAO function in test
Eileen McNaughton [Wed, 10 Aug 2022 07:04:44 +0000 (19:04 +1200)]
[Import] [Ref] Extract shared form rule code
colemanw [Wed, 10 Aug 2022 21:11:48 +0000 (17:11 -0400)]
Merge pull request #24218 from eileenmcnaughton/shared_import
Move unshared code to unshared function
Seamus Lee [Wed, 10 Aug 2022 20:59:33 +0000 (06:59 +1000)]
Merge pull request #24198 from demeritcowboy/zetacompootens
Update zetacomponents/mail to 1.9.3 so can remove patches
Coleman Watts [Wed, 10 Aug 2022 20:53:54 +0000 (16:53 -0400)]
CrmUi - Fix crmSelect2 to work with ngOptions
As part of https://github.com/civicrm/civicrm-core/pull/23749 select elements using
ui-jq were switched to crm-ui-select, which should have been a drop-in replacement,
but it turns out it broke for widgets using ngOptions. This fixes it.
Fixes dev/core#3797
colemanw [Wed, 10 Aug 2022 19:30:36 +0000 (15:30 -0400)]
Merge pull request #24212 from eileenmcnaughton/data
dev/core#3664 Remove dataColumnGuessing
Coleman Watts [Wed, 10 Aug 2022 14:58:36 +0000 (10:58 -0400)]
Fix regression causing custom groups to reset to 'Contact' when updated
Fixes dev/core#3794
Herb [Wed, 10 Aug 2022 19:27:13 +0000 (15:27 -0400)]
dev/core#3796 include subtypes where filter > 0
Matthew Wire [Wed, 10 Aug 2022 16:46:41 +0000 (17:46 +0100)]
Merge pull request #24190 from eileenmcnaughton/load_related
Move a little code from legacy function `loadRelatedObjects` to the calling functions
Coleman Watts [Wed, 10 Aug 2022 01:18:38 +0000 (21:18 -0400)]
APIv4 Autocomplete - Fix anonymous access and add tests
colemanw [Wed, 10 Aug 2022 12:24:30 +0000 (08:24 -0400)]
Merge pull request #24211 from eileenmcnaughton/goneier
[Import-code-cleanup] Remove another now-unused class `CRM_Contact_Import_ImportJob`
demeritcowboy [Wed, 10 Aug 2022 11:38:53 +0000 (07:38 -0400)]
update zeta/mail to 1.9.3
Eileen McNaughton [Wed, 10 Aug 2022 09:14:29 +0000 (21:14 +1200)]
Merge pull request #24215 from eileenmcnaughton/map_type
NFC IDE code format to get rid of array()
Eileen McNaughton [Wed, 10 Aug 2022 07:18:46 +0000 (19:18 +1200)]
Move unshared code to unshared function
Eileen McNaughton [Wed, 10 Aug 2022 06:03:07 +0000 (18:03 +1200)]
Consolidate error handling on Custom data import tpl
Eileen McNaughton [Thu, 7 Jul 2022 02:11:32 +0000 (14:11 +1200)]
NFC IDE code format to get rid of array()
Eileen McNaughton [Wed, 6 Jul 2022 06:34:40 +0000 (18:34 +1200)]
Remove now-unused tpl
Eileen McNaughton [Wed, 10 Aug 2022 04:54:55 +0000 (16:54 +1200)]
Merge pull request #24213 from civicrm/5.53
5.53 to master
Eileen McNaughton [Wed, 10 Aug 2022 04:54:23 +0000 (16:54 +1200)]
Merge pull request #24204 from totten/5.53-tabsetoptions
CrmUi - Fix tabSetOptions variable
Eileen McNaughton [Wed, 10 Aug 2022 04:53:27 +0000 (16:53 +1200)]
Merge pull request #24208 from eileenmcnaughton/deprecated
Finally remove apiv2 DeprecatedUtils
Eileen McNaughton [Wed, 10 Aug 2022 04:26:58 +0000 (16:26 +1200)]
dev/core#3664 Remove dataColumnGuessing
Eileen McNaughton [Wed, 10 Aug 2022 03:44:54 +0000 (15:44 +1200)]
Merge pull request #24206 from eileenmcnaughton/rc
removed import contacts access argument for summary path
Eileen McNaughton [Wed, 10 Aug 2022 02:50:29 +0000 (14:50 +1200)]
Remove another now-unused class
Eileen McNaughton [Wed, 10 Aug 2022 02:40:22 +0000 (14:40 +1200)]
Remove unused function
Coleman Watts [Mon, 8 Aug 2022 21:57:30 +0000 (17:57 -0400)]
APIv4 - Prevent fatal error when looking up pseudoconstant for field with no options
Coleman Watts [Sun, 7 Aug 2022 01:32:14 +0000 (21:32 -0400)]
Afform - Fix compatability of existing contact widget and 'current user' default
Coleman Watts [Sat, 6 Aug 2022 21:50:40 +0000 (17:50 -0400)]
Afform - Apply "type" values to autocomplete filters
This ensures that if e.g. a Contact or Activity has its type specified on the form
it will also be limited to that type in autocomplete results when selecting an existing entity.
Coleman Watts [Sat, 6 Aug 2022 19:33:02 +0000 (15:33 -0400)]
APIv4 Autocomplete - Add metadata and tests
Coleman Watts [Fri, 5 Aug 2022 22:02:19 +0000 (18:02 -0400)]
Afform - fill entity based on existing entity selection
Coleman Watts [Fri, 5 Aug 2022 18:10:51 +0000 (14:10 -0400)]
Afform - configure existing entity widget
Coleman Watts [Fri, 5 Aug 2022 14:53:39 +0000 (10:53 -0400)]
APIv4 autocomplete - Support filters
Coleman Watts [Wed, 3 Aug 2022 18:32:54 +0000 (14:32 -0400)]
Afform - Add autocomplete field
Coleman Watts [Tue, 2 Aug 2022 21:12:29 +0000 (17:12 -0400)]
APIv4 Autocomplete - Select icon based on metadata
Coleman Watts [Sat, 30 Jul 2022 22:04:57 +0000 (18:04 -0400)]
Add APIv4-based autocomplete widget
Coleman Watts [Wed, 27 Jul 2022 22:56:44 +0000 (18:56 -0400)]
APIv4 - Add autocomplete action
APIv4 action to supply data to the new autocomplete widget.
colemanw [Wed, 10 Aug 2022 02:28:31 +0000 (22:28 -0400)]
Merge pull request #24209 from civicrm/5.53
Merge 5.53 to master
Eileen McNaughton [Wed, 10 Aug 2022 01:58:43 +0000 (13:58 +1200)]
Merge pull request #24203 from colemanw/fixTagFilter553
APIv4 - Fix resolving pseudoconstants for less-permissioned users
Eileen McNaughton [Wed, 10 Aug 2022 00:35:43 +0000 (12:35 +1200)]
Remove now-unused summary forms
Eileen McNaughton [Wed, 10 Aug 2022 01:36:07 +0000 (13:36 +1200)]
Merge pull request #24202 from totten/5.53-composer-api
composer.json - Declare requirement for `composer-runtime-api`
Eileen McNaughton [Wed, 10 Aug 2022 01:32:21 +0000 (13:32 +1200)]
Merge pull request #24075 from colemanw/removeDeprecatedJoins
APIv4 - Drop support for deprecated join syntax
Eileen McNaughton [Wed, 10 Aug 2022 01:07:37 +0000 (13:07 +1200)]
Finally remove apiv2 DeprecatedUtils
colemanw [Wed, 10 Aug 2022 01:02:55 +0000 (21:02 -0400)]
Merge pull request #24188 from eileenmcnaughton/import
[Import-code-cleanup] Fold call to deprecated function back into calling function
colemanw [Wed, 10 Aug 2022 00:50:41 +0000 (20:50 -0400)]
Merge pull request #24001 from eileenmcnaughton/import_fill
dev/core#3733 [Import] Test & fix for source updating when it should …
Brienne Kordis [Tue, 9 Aug 2022 18:21:32 +0000 (14:21 -0400)]
removed import contacts access argument for summary path
colemanw [Wed, 10 Aug 2022 00:45:21 +0000 (20:45 -0400)]
Merge pull request #24185 from eileenmcnaughton/int
[Import-code-cleanup] Mark a few functions deprecated for clarity & mark parser class internal
colemanw [Wed, 10 Aug 2022 00:44:41 +0000 (20:44 -0400)]
Merge pull request #24189 from eileenmcnaughton/import_two
[Import-code-cleanup] Fold call to weird deprecated function back into calling code