Eileen McNaughton [Mon, 18 Jun 2018 00:28:07 +0000 (12:28 +1200)]
Merge pull request #12329 from eileenmcnaughton/master
[NFC] Stop passing no-longer-part-of-signature variable
eileen [Sun, 17 Jun 2018 21:51:52 +0000 (09:51 +1200)]
Stop passing no-longer-part-of-signature variable
Eileen McNaughton [Sun, 17 Jun 2018 21:34:14 +0000 (09:34 +1200)]
Merge pull request #12313 from mattwire/CRM-21682_api_v3_membership_cleanup
Cleanup of api_v3_membership_create towards #11556
Eileen McNaughton [Sun, 17 Jun 2018 21:23:38 +0000 (09:23 +1200)]
Merge pull request #12322 from totten/master-unused-modulepaths
(dev/core#174) Remove reference to unused `modulePaths`
Eileen McNaughton [Sun, 17 Jun 2018 21:08:46 +0000 (09:08 +1200)]
Merge pull request #12311 from totten/master-tmpnam
(dev/core#183) Temporary tables should follow consistent naming convention
Eileen McNaughton [Sun, 17 Jun 2018 19:44:04 +0000 (07:44 +1200)]
Merge pull request #12160 from aydun/core_124_event_approval_fixes
dev/core#124 Enhancements for events requiring approval
Eileen McNaughton [Sun, 17 Jun 2018 05:43:10 +0000 (17:43 +1200)]
Merge pull request #12323 from totten/master-flush-sig
(NFC) dev/core#174 - CRM_Utils_System::flushCache - Remove dead code
Eileen McNaughton [Sat, 16 Jun 2018 22:23:23 +0000 (10:23 +1200)]
Merge pull request #12328 from civicrm/5.3
5.3 to master
Eileen McNaughton [Sat, 16 Jun 2018 22:22:36 +0000 (10:22 +1200)]
Merge pull request #12326 from pradpnayak/185
dev/core/issues/185 “Print selected rows” option missing in Event Participant listing dropdown actions
Tim Otten [Sat, 16 Jun 2018 18:51:13 +0000 (11:51 -0700)]
Merge pull request #12324 from colemanw/ApiExporerFix
Fix typo in api explorer sample code
Pradeep Nayak [Thu, 14 Jun 2018 21:55:27 +0000 (03:25 +0530)]
Wrong key assigned to task action
Coleman Watts [Sat, 16 Jun 2018 03:09:19 +0000 (23:09 -0400)]
Fix typo in api explorer sample code
Tim Otten [Sat, 16 Jun 2018 02:01:35 +0000 (19:01 -0700)]
(NFC) dev/core#174 - CRM_Utils_System::flushCache - Remove dead code
Before
------
* The signature of `CRM_Utils_System::flushCache` does not accept arguments.
* Random forms call it with arguments.
After
-----
* The signature of `CRM_Utils_System::flushCache` does not accept arguments.
* Random forms call it without arguments.
Tim Otten [Sat, 16 Jun 2018 00:40:39 +0000 (17:40 -0700)]
CRM_Utils_SQL_TempTable - Improve docblock
Seamus Lee [Sat, 16 Jun 2018 00:10:14 +0000 (10:10 +1000)]
Merge pull request #12321 from totten/master-unused-setitem
(dev/core#174) api_v3_SettingTest - Remove dead code
Tim Otten [Fri, 15 Jun 2018 23:30:41 +0000 (16:30 -0700)]
(dev/core#174) Remove reference to unused `modulePaths`
The cache-clear operation removes this setting, but the setting does not
really exist today. (Simply grep universe for `modulePaths` to see this.)
If you dig up the JIRA reference, it talks about the internals of v4.2.
There's been a lot of change in how this stuff works since v4.2.
Eileen McNaughton [Fri, 15 Jun 2018 22:44:21 +0000 (10:44 +1200)]
Merge pull request #12314 from mattwire/CRM-21682_cleanup_recordAdditionalPayment
Cleanup recordAdditionalPayment towards #11556
Eileen McNaughton [Fri, 15 Jun 2018 22:36:33 +0000 (10:36 +1200)]
Merge pull request #12318 from mattwire/inherit_core_form_task
Make all form tasks inherit from Core_Form_Task
Tim Otten [Fri, 15 Jun 2018 21:48:57 +0000 (14:48 -0700)]
(dev/core#174) api_v3_SettingTest - Remove unused cache reference
This unit is clearing out a non-existent cache item. To see that it is non-existent, I grepped (case-insensitive) for
the expressions:
* `CiviCRM setting Spec`
* `CiviCRM setting `
* `setting spec`
This feels like left-overs from 4.6. In 4.7, the setting cache was reworked. Note that
`SettingTest` does clear newer cache (`Civi::cache('settings')->flush();`).
Eileen McNaughton [Fri, 15 Jun 2018 19:01:20 +0000 (07:01 +1200)]
Merge pull request #12218 from mattwire/getcustomfieldid
dev/core#144 getCustomFieldID switch to API, add caching, add full string return option
Monish Deb [Fri, 15 Jun 2018 13:19:34 +0000 (18:49 +0530)]
Merge pull request #11578 from jitendrapurohit/CRM-20697
CRM-20697 - Online pay now anomalies (contribution transfer to new contact)
Matthew Wire [Sun, 27 May 2018 16:10:02 +0000 (17:10 +0100)]
getCustomFieldID switch to API, add caching, add full string return option.
Matthew Wire [Fri, 1 Jun 2018 15:34:28 +0000 (16:34 +0100)]
Make all form task inherit from Core_Form_Task otherwise export can fail when accessed from advanced search because properties are inaccessible
Matthew Wire [Fri, 15 Jun 2018 07:57:53 +0000 (08:57 +0100)]
NFC: Cleanup recordAdditionalPayment
Matthew Wire [Fri, 15 Jun 2018 07:42:42 +0000 (08:42 +0100)]
Cleanup of api_v3_membership_create towards #11556
Tim Otten [Fri, 15 Jun 2018 04:31:50 +0000 (21:31 -0700)]
(dev/core#183) Change temp table naming for CRM/Contact/Form/Search/Custom/DateAdded.php
Re:`r-run` -- Verified that these lines are executed by the search form -- and
that the outcomes of a few basic searches are the same with the patch.
Tim Otten [Fri, 15 Jun 2018 03:52:56 +0000 (20:52 -0700)]
(dev/core#183) Change temp table naming for CRM/Contact/Form/Search/Custom/ContribSYBNT.php
Re:`r-run` -- Verified that these lines are executed by the search form -- and
that the outcomes of a few basic searches are the same with the patch.
Tim Otten [Fri, 15 Jun 2018 03:35:05 +0000 (20:35 -0700)]
(dev/core#183) Change temp table naming for CRM_Activity_BAO_Activity
Note: Verified that changes to this line are reflected as passes/failures in
CRM_Activity_BAO_ActivityTest.
Monish Deb [Fri, 15 Jun 2018 03:09:38 +0000 (08:39 +0530)]
Merge pull request #11495 from yashodha/CRM-21637
CRM-21637 - Search Criteria for Card Type ID and Card Number not resp…
Tim Otten [Fri, 15 Jun 2018 00:03:54 +0000 (17:03 -0700)]
(dev/core#183) Change temp table naming for reports
Testing notes - This is a pretty formulaic change. The main concern is some kind of typo or bad table name causing a
hard-fail. To control that risk, we just run the code in a facile way:
* Navigate to "Reports => Contributions => Lybunt"
* Add a "Filter" by "Group"
We do this procedure under a few circumstances:
* With the original code
* With a purposefully bad edit (provoking an expected error)
* With the new code
In this commit, we changed two lines, so we do the above once for each line.
Tim Otten [Thu, 14 Jun 2018 23:27:37 +0000 (16:27 -0700)]
(dev/core#183) Change temp table naming for exports
Testing notes - This is a pretty formulaic change. The main concern is some kind of typo or bad table name causing a
hard-fail. To control that risk, we just run the code in a facile way:
* Perform a contact search
* Pick some contacts
* Export them
* Run the export
We do this procedure under a few circumstances:
* With the original code
* With a purposefully bad edit (provoking an expected error)
* With the new code
Tim Otten [Thu, 14 Jun 2018 23:18:16 +0000 (16:18 -0700)]
(dev/core#183) Change temp table naming for search-tasks
Testing notes - This is a pretty formulaic change. The main concern is some kind of typo or bad table name causing a
hard-fail. To control that risk, we just run the code in a facile way:
* Perform a contact search
* Pick some contacts
* Export them
We do this procedure under a few circumstances:
* With the original code
* With a purposefully bad edit (provoking an expected error)
* With the new code
Tim Otten [Thu, 14 Jun 2018 23:48:33 +0000 (16:48 -0700)]
(dev/core#183) Deprecate CRM_Core_DAO::createTempTableName()
We're changing the naming formula, but some use-cases may rely on the old
naming formula. Anything based on the old formula needs to be examined.
Tim Otten [Thu, 14 Jun 2018 22:51:25 +0000 (15:51 -0700)]
(dev/core#183) Add more robust TempTable generator
Monish Deb [Thu, 14 Jun 2018 17:41:15 +0000 (23:11 +0530)]
Merge pull request #11907 from mattwire/contribution_financialtype_fix
dev/core#88 Make sure financial_type_id is set when contribution is created
colemanw [Thu, 14 Jun 2018 16:46:33 +0000 (12:46 -0400)]
Merge pull request #12303 from totten/master-redis-errmsg
(dev/core#178) Redis - Report error messages
Eileen McNaughton [Thu, 14 Jun 2018 07:54:27 +0000 (19:54 +1200)]
Merge pull request #11881 from yashodha/CRM-21854
CRM-21854 - Contribution start date and end dates are not respected
Tim Otten [Thu, 14 Jun 2018 07:53:59 +0000 (00:53 -0700)]
(dev/core#178) Redis - Be a little more conservative about sharing error info
colemanw [Wed, 13 Jun 2018 20:16:10 +0000 (16:16 -0400)]
Merge pull request #12309 from jaapjansma/issue_180_deleting_custom_values
Fix for #180: passing the entity ID to the custom hook when deleting a custom value
Eileen McNaughton [Wed, 13 Jun 2018 19:06:44 +0000 (07:06 +1200)]
Merge pull request #11733 from eileenmcnaughton/sched
Fix access to scheduled reminders for admins without event access
Jaap Jansma [Wed, 13 Jun 2018 09:19:11 +0000 (11:19 +0200)]
Fix for #180: passing the entity ID to the custom hook when deleting a custom value record.
Eileen McNaughton [Wed, 13 Jun 2018 07:44:31 +0000 (19:44 +1200)]
Merge pull request #12308 from eileenmcnaughton/getty
Only treat a request as a get request (and hence use GET) if it starts with get
colemanw [Wed, 13 Jun 2018 03:43:05 +0000 (23:43 -0400)]
Merge pull request #12304 from totten/master-redis-anon
(dev/core#179) Redis - Only send AUTH if there's a password
eileen [Wed, 13 Jun 2018 02:07:21 +0000 (14:07 +1200)]
Only treat a request as a get request (and hence use GET) if it starts with get
Current code looks for the word 'get' anywhere in the action so the action 'forget' is also picked up.
Further down we explicitly look for 0 so we should here too.
colemanw [Wed, 13 Jun 2018 01:40:52 +0000 (21:40 -0400)]
Merge pull request #11830 from mattwire/devcore24_case_api_contact_fix
dev/core#24 Passing an array for contact_id/client_id to Case.Create API when updating an existing case causes case to be "reassigned"
Eileen McNaughton [Tue, 12 Jun 2018 22:42:13 +0000 (10:42 +1200)]
Merge pull request #11481 from jitendrapurohit/CRM-21622
CRM-21622: Allow multiple parents to be created from 'New Group' form.
colemanw [Tue, 12 Jun 2018 12:44:41 +0000 (08:44 -0400)]
Merge pull request #12276 from eileenmcnaughton/memory_more
CRM-19798 fix memory leak on EntityTag.get & other calls in the DB (generic fix)
Eileen McNaughton [Tue, 12 Jun 2018 05:15:18 +0000 (17:15 +1200)]
Merge pull request #12302 from totten/master-redis-null
(dev/core#177) Redis::get() should return NULL for undefined cache keys
eileen [Wed, 28 Feb 2018 02:15:31 +0000 (15:15 +1300)]
This is a combination of 2 commits.
Fix access to scheduled reminders form.
The current logic is that if the context is not event (empty) and the user does not
have administer CiviCRM they get bounced. if they pass that check they are then
passed into the check that should only be applied when the context IS event. This results
in a bounce for a user without any manage event access.
eileen [Wed, 28 Feb 2018 02:11:29 +0000 (15:11 +1300)]
Remove code duplication
eileen [Wed, 28 Feb 2018 02:09:53 +0000 (15:09 +1300)]
Declare as a class property & get rid of e-notice handling for it.
There is no functional change here but the code change looks a little large due to the removal of a pointless if
Tim Otten [Fri, 30 Mar 2018 00:10:39 +0000 (17:10 -0700)]
(dev/core#179) Redis - Only send AUTH if there's a password
Tim Otten [Fri, 30 Mar 2018 00:11:29 +0000 (17:11 -0700)]
(dev/core#178) Redis - Report error messages
Tim Otten [Fri, 30 Mar 2018 01:14:48 +0000 (18:14 -0700)]
(dev/core#177) Redis::get() should return NULL for undefined cache keys
The docs for `CRM_Utils_Cache_Interface::get()` specify that the return value should be NULL
if the key does not exist.
However, `CRM_Utils_Cache_Redis::get()` was returning FALSE in that circumstance
(because `unserialize(FALSE)===FALSE`). This fixes it comply.
Seamus Lee [Mon, 11 Jun 2018 21:24:23 +0000 (07:24 +1000)]
Merge pull request #12301 from jitendrapurohit/core-175
dev/core#175 - Smart group involving relationship type filter display…
Seamus Lee [Mon, 11 Jun 2018 21:12:21 +0000 (07:12 +1000)]
Merge pull request #12281 from eileenmcnaughton/cont_detail_report
Add testing to contribution detail report, covering dev/core/issues#170
Eileen McNaughton [Mon, 11 Jun 2018 20:00:02 +0000 (08:00 +1200)]
Merge pull request #11883 from jitendrapurohit/core-32
core-32 - Add option to disable cancel button on a profile form
colemanw [Mon, 11 Jun 2018 16:21:16 +0000 (12:21 -0400)]
Merge pull request #11736 from jitendrapurohit/CRM-21815
CRM-21815 - re-opening a civicase - Case Coordinator (and other roles…
colemanw [Mon, 11 Jun 2018 15:44:08 +0000 (11:44 -0400)]
Merge pull request #12298 from eileenmcnaughton/notice
Fix e-notice, remove legacy code pattern
colemanw [Mon, 11 Jun 2018 13:54:16 +0000 (09:54 -0400)]
Merge pull request #12299 from eileenmcnaughton/cancel_recur
Remove unused code variable
Jitendra Purohit [Mon, 11 Jun 2018 11:31:49 +0000 (17:01 +0530)]
Move upgrade function to 5.4
Jitendra Purohit [Tue, 27 Mar 2018 06:11:56 +0000 (11:41 +0530)]
core-32 - Add option to disable cancel button on a profile form
Jitendra Purohit [Mon, 11 Jun 2018 10:14:40 +0000 (15:44 +0530)]
add unit test
Jitendra Purohit [Mon, 11 Jun 2018 09:50:58 +0000 (15:20 +0530)]
dev/core#175 - Smart group involving relationship type filter display incorrect results
Seamus Lee [Mon, 11 Jun 2018 05:50:14 +0000 (15:50 +1000)]
Merge pull request #11964 from scardinius/core-56
(dev/core/56) Cancel Recurring Contribution activity should has a source record id
Eileen McNaughton [Mon, 11 Jun 2018 04:32:27 +0000 (16:32 +1200)]
Merge pull request #12300 from civicrm/5.3
5.3
Seamus Lee [Mon, 11 Jun 2018 03:39:56 +0000 (13:39 +1000)]
Merge pull request #12277 from seamuslee001/dev_core_163
dev/core#163 Improve inclusion of disabled groups when getting all ma…
eileen [Mon, 11 Jun 2018 01:13:30 +0000 (13:13 +1200)]
Remove unused code variable
Seamus Lee [Thu, 7 Jun 2018 03:25:55 +0000 (13:25 +1000)]
dev/core#163 Improve way of getting all groups for use in getting all mailing accessable by a user by removing is_active filter alltogether
eileen [Mon, 11 Jun 2018 00:16:49 +0000 (12:16 +1200)]
Fix e-notice, remove legacy code pattern
Seamus Lee [Mon, 11 Jun 2018 00:13:50 +0000 (10:13 +1000)]
Merge pull request #12295 from eileenmcnaughton/mailing
Confirm & lock in group.get handling of is_active
Eileen McNaughton [Mon, 11 Jun 2018 00:13:12 +0000 (12:13 +1200)]
Merge pull request #12297 from civicrm/5.3
5.3
Seamus Lee [Sun, 10 Jun 2018 23:39:06 +0000 (09:39 +1000)]
Merge pull request #12294 from seamuslee001/remove_payflow_recur
Remove unused function getRecuringTransactionStatus from PayflowPro c…
Seamus Lee [Sun, 10 Jun 2018 23:17:33 +0000 (09:17 +1000)]
Merge pull request #12293 from colemanw/arrayUtil
Improve CRM_Utils_Array::recursiveBuild to work with existing arrays.
Seamus Lee [Sun, 10 Jun 2018 22:06:58 +0000 (08:06 +1000)]
Merge pull request #12224 from eileenmcnaughton/templates
Add upgrade function for message templates that does not involve copying the whole template
eileen [Sun, 10 Jun 2018 22:03:03 +0000 (10:03 +1200)]
Confirm & lock in group.get handling of is_active
Seamus Lee [Sun, 10 Jun 2018 21:37:17 +0000 (07:37 +1000)]
Remove unused function getRecuringTransactionStatus from PayflowPro class
Coleman Watts [Sun, 10 Jun 2018 19:41:42 +0000 (15:41 -0400)]
Improve CRM_Utils_Array::recursiveBuild to work with existing arrays.
eileen [Fri, 8 Jun 2018 01:32:37 +0000 (13:32 +1200)]
dev/core#170 fix regression on soft_credits with unit test
colemanw [Sat, 9 Jun 2018 21:15:02 +0000 (17:15 -0400)]
Merge pull request #12288 from eileenmcnaughton/export
Function extraction BAO_Export class
eileen [Sat, 9 Jun 2018 07:27:32 +0000 (19:27 +1200)]
Extract build buildRelatedContactArray function
eileen [Sat, 9 Jun 2018 07:24:31 +0000 (19:24 +1200)]
Further minor function extraction on Export class
Eileen McNaughton [Sat, 9 Jun 2018 07:09:09 +0000 (19:09 +1200)]
Merge pull request #12289 from eileenmcnaughton/frank
Partial code cleanup & testability improvement towards CRM-21177
Frank J. Gómez [Thu, 28 Sep 2017 15:37:11 +0000 (11:37 -0400)]
Cleaned up code style. No expected functional change.
Eileen McNaughton [Sat, 9 Jun 2018 02:17:13 +0000 (14:17 +1200)]
Merge pull request #11726 from scardinius/crm-21808
CRM-21808 Install custom group for Contribution or ContributioRecur s…
Eileen McNaughton [Sat, 9 Jun 2018 01:32:52 +0000 (13:32 +1200)]
Merge pull request #12107 from eileenmcnaughton/save_report
CRM-20430 - Permission 'save Report Criteria'.
Eileen McNaughton [Sat, 9 Jun 2018 01:22:02 +0000 (13:22 +1200)]
Merge pull request #11337 from WeMoveEU/CRM-21460
CRM-21460 Add job execution hooks
Frank J. Gómez [Wed, 27 Sep 2017 23:00:02 +0000 (19:00 -0400)]
CRM-21177: Added unit test to lock in behavior of properly looking up
membership term from the line item.
Eileen McNaughton [Fri, 8 Jun 2018 23:57:22 +0000 (11:57 +1200)]
Merge pull request #11945 from mattwire/devcore47_clone_scheduled_jobs
dev/core#47 Add clone scheduled job functionality
Johan Vervloet [Fri, 14 Apr 2017 12:16:50 +0000 (14:16 +0200)]
CRM-20430 - Permission 'save Report Criteria'.
If you don't have the permission, the 'save report' actions aren't shown
on the form of the report instance.
CRM-20430 - Check 'save Report Criteria' permission before saving a report instance.
Coding style issues.
Added a pre-commit message about the new permission.
Eileen McNaughton [Fri, 8 Jun 2018 23:27:21 +0000 (11:27 +1200)]
Merge pull request #12067 from michaelmcandrew/CRM-21576-sms-permission-extra
Make Send SMS permission independent of Edit Contact permission
Eileen McNaughton [Fri, 8 Jun 2018 23:08:49 +0000 (11:08 +1200)]
Merge pull request #11956 from MiyaNoctem/CRM-50-sub-tabs-for-contributions
(dev/core/50) Add Separate Sub-tabs for Contributions and Recurring Contributions
Eileen McNaughton [Fri, 8 Jun 2018 23:00:34 +0000 (11:00 +1200)]
Merge pull request #12078 from compucorp/101-conditionals-in-search-form
dev/core/#101: Allow further customization of search form in hooks
eileen [Fri, 8 Jun 2018 11:21:05 +0000 (23:21 +1200)]
@eileenmcnaughton
Add contact greeting to membership online receipt text message template
eileen [Tue, 29 May 2018 08:36:47 +0000 (20:36 +1200)]
Add upgrade function for message templates that does not involve copying the whole template
Eileen McNaughton [Fri, 8 Jun 2018 22:17:02 +0000 (10:17 +1200)]
Merge pull request #11840 from mfb/smtp-reconnect
CiviMail: If SMTP connection error is detected, disconnect so we can reconnect and retry
colemanw [Fri, 8 Jun 2018 20:14:37 +0000 (16:14 -0400)]
Merge pull request #12287 from eileenmcnaughton/5.3
core/#170 minimal fix for fatal on soft_credit field
colemanw [Fri, 8 Jun 2018 20:13:08 +0000 (16:13 -0400)]
Merge pull request #11724 from lemacarl/CRM-21779
CRM-21779 - ang\crmMailing - Fix adding empty mailing to recipients field
Michael Devery [Thu, 3 May 2018 15:32:13 +0000 (16:32 +0100)]
dev/core#101 Implement field spec pattern for advanced search form.
By implementing the field spec pattern as detailed in dev/core#115 extension developers have more control over
what is displayed in this template without needing to resort to
overriding it
Eileen McNaughton [Fri, 8 Jun 2018 11:11:10 +0000 (23:11 +1200)]
Merge pull request #12284 from jitendrapurohit/mail-1-message
dev/mail#1 - Modify message text for pause mailing