civicrm-core.git
2 years agoCode cleanup on greeting procssing
Eileen McNaughton [Tue, 2 Aug 2022 23:56:12 +0000 (11:56 +1200)]
Code cleanup on greeting procssing

2 years agoMerge pull request #24286 from eileenmcnaughton/rem
demeritcowboy [Thu, 18 Aug 2022 00:27:41 +0000 (20:27 -0400)]
Merge pull request #24286 from eileenmcnaughton/rem

[REF] [Upgrade] Remove the entry point that called the unused entry point

2 years agoMerge pull request #24102 from eileenmcnaughton/emp_token
demeritcowboy [Thu, 18 Aug 2022 00:20:06 +0000 (20:20 -0400)]
Merge pull request #24102 from eileenmcnaughton/emp_token

dev/core#3681 Add token for CiviCRM empowered by image

2 years agoMerge pull request #24288 from eileenmcnaughton/get_mem_fields
colemanw [Thu, 18 Aug 2022 00:05:01 +0000 (20:05 -0400)]
Merge pull request #24288 from eileenmcnaughton/get_mem_fields

Remove now-unused addField from Membership import

2 years agoMerge pull request #24156 from eileenmcnaughton/cache_miss
colemanw [Wed, 17 Aug 2022 22:14:46 +0000 (18:14 -0400)]
Merge pull request #24156 from eileenmcnaughton/cache_miss

Fix array-cache-bypass - in FastArrays on `has()`

2 years agoMerge pull request #22504 from eileenmcnaughton/jon
colemanw [Wed, 17 Aug 2022 21:56:05 +0000 (17:56 -0400)]
Merge pull request #22504 from eileenmcnaughton/jon

financial#121: Support modifying Soft Credit permissions via hook

2 years agoMerge pull request #24122 from eileenmcnaughton/inv_lines
demeritcowboy [Wed, 17 Aug 2022 19:53:01 +0000 (15:53 -0400)]
Merge pull request #24122 from eileenmcnaughton/inv_lines

Update invoice template to be (mostly) previewable

2 years agoMerge pull request #24291 from totten/master-ml-test
demeritcowboy [Wed, 17 Aug 2022 12:53:40 +0000 (08:53 -0400)]
Merge pull request #24291 from totten/master-ml-test

(REF) Extract LocaleTestTrait. Tighten up multilingual testing.

2 years agoMerge pull request #23862 from eileenmcnaughton/nav
Eileen McNaughton [Wed, 17 Aug 2022 09:39:37 +0000 (21:39 +1200)]
Merge pull request #23862 from eileenmcnaughton/nav

Move creating of nav & menu items to legacycustomsearches extension

2 years agoTest fix up & add stuff to diagnose the cleanup issue
Eileen McNaughton [Thu, 4 Aug 2022 06:54:23 +0000 (18:54 +1200)]
Test fix up & add stuff to diagnose the cleanup issue

2 years agoMailingTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:19:02 +0000 (00:19 -0700)]
MailingTest - Update multilingual helper calls

2 years agoLoggingTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:18:50 +0000 (00:18 -0700)]
LoggingTest - Update multilingual helper calls

2 years agoFinancialTypeTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:18:30 +0000 (00:18 -0700)]
FinancialTypeTest - Update multilingual helper calls

2 years agoSchemaTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:08:45 +0000 (00:08 -0700)]
SchemaTest - Update multilingual helper calls

2 years agoContributionPageTranslationTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:08:26 +0000 (00:08 -0700)]
ContributionPageTranslationTest - Update multilingual helper calls

2 years agoMailingSystemTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:08:07 +0000 (00:08 -0700)]
MailingSystemTest - Update multilingual helper calls

2 years agoMultilingualTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:07:42 +0000 (00:07 -0700)]
MultilingualTest - Update multilingual helper calls

2 years agoCopyTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:07:23 +0000 (00:07 -0700)]
CopyTest - Update multilingual helper calls

2 years agoLocaleTest - Update multilingual helper calls
Tim Otten [Wed, 17 Aug 2022 07:06:45 +0000 (00:06 -0700)]
LocaleTest - Update multilingual helper calls

2 years agoExtract LocaleTestTrait from CiviUnitTestCase. Add more helpers.
Tim Otten [Wed, 17 Aug 2022 07:05:28 +0000 (00:05 -0700)]
Extract LocaleTestTrait from CiviUnitTestCase. Add more helpers.

2 years agoNFC code tidy up
Eileen McNaughton [Tue, 9 Aug 2022 01:13:44 +0000 (13:13 +1200)]
NFC code tidy up

2 years agoFix test to cope with there actually being an extension with managed entities enabled
Eileen McNaughton [Wed, 3 Aug 2022 23:17:05 +0000 (11:17 +1200)]
Fix test to cope with there actually being an extension with managed entities enabled

2 years agoMove creating of nav & menu items to legacycustomsearches extension
Eileen McNaughton [Tue, 21 Jun 2022 23:39:42 +0000 (11:39 +1200)]
Move creating of nav & menu items to legacycustomsearches extension

2 years agoMerge pull request #24290 from colemanw/daoIdFix
Seamus Lee [Wed, 17 Aug 2022 05:43:12 +0000 (15:43 +1000)]
Merge pull request #24290 from colemanw/daoIdFix

APIv4 - Fix some hard-coded references to 'id' in DAO action classes

2 years agoMerge pull request #24258 from seamuslee001/authx_debug_test
Tim Otten [Wed, 17 Aug 2022 03:53:25 +0000 (20:53 -0700)]
Merge pull request #24258 from seamuslee001/authx_debug_test

[NFC] Add in Further debugging to authx test to try and debug issue o…

2 years agoAPIv4 - Fix some hard-coded references to 'id' in DAO action classes
Coleman Watts [Wed, 17 Aug 2022 02:44:00 +0000 (22:44 -0400)]
APIv4 - Fix some hard-coded references to 'id' in DAO action classes

2 years agoMerge pull request #24284 from totten/master-nfc-locale
Eileen McNaughton [Wed, 17 Aug 2022 03:03:27 +0000 (15:03 +1200)]
Merge pull request #24284 from totten/master-nfc-locale

(NFC) Mark various tests with `@group locale`

2 years agoMerge pull request #24285 from eileenmcnaughton/import_dec
Eileen McNaughton [Wed, 17 Aug 2022 03:00:41 +0000 (15:00 +1200)]
Merge pull request #24285 from eileenmcnaughton/import_dec

Add 'Entity' to the information import parser classes provide

2 years agoMerge pull request #24054 from eileenmcnaughton/msg_workflow
colemanw [Wed, 17 Aug 2022 02:52:51 +0000 (22:52 -0400)]
Merge pull request #24054 from eileenmcnaughton/msg_workflow

Update references to 'workflow' (from old 'valueName' parameter)

2 years agoMerge pull request #24283 from totten/master-api4-passes
colemanw [Wed, 17 Aug 2022 02:11:31 +0000 (22:11 -0400)]
Merge pull request #24283 from totten/master-api4-passes

(REF) Extract compiler passes from CRM_Api4_Services

2 years agoRemove now-unused addField from Membership import
Eileen McNaughton [Wed, 17 Aug 2022 02:11:22 +0000 (14:11 +1200)]
Remove now-unused addField from Membership import

2 years agoMerge pull request #24279 from eileenmcnaughton/get_part_fields
colemanw [Wed, 17 Aug 2022 02:02:10 +0000 (22:02 -0400)]
Merge pull request #24279 from eileenmcnaughton/get_part_fields

Remove now-unused addField from Participant import

2 years agoAdd token for CiviCRM empowered by image
Eileen McNaughton [Sun, 31 Jul 2022 20:57:19 +0000 (06:57 +1000)]
Add token for CiviCRM empowered by image

2 years agoMerge pull request #24275 from eileenmcnaughton/dao_prim
colemanw [Wed, 17 Aug 2022 01:52:03 +0000 (21:52 -0400)]
Merge pull request #24275 from eileenmcnaughton/dao_prim

Update DAO to use declared primary field, do not assume...

2 years agoMerge pull request #24254 from colemanw/mailingTask
colemanw [Wed, 17 Aug 2022 01:49:34 +0000 (21:49 -0400)]
Merge pull request #24254 from colemanw/mailingTask

SearchKit - Add contacts to mailing group in batches

2 years agoMerge pull request #24186 from colemanw/groupContactPerm
colemanw [Wed, 17 Aug 2022 01:48:40 +0000 (21:48 -0400)]
Merge pull request #24186 from colemanw/groupContactPerm

APIv4 - Fix GroupContact permission to use standard ACLs

2 years ago[REF] [Upgrade] Remove the entry point that called the unused entry point
Eileen McNaughton [Wed, 17 Aug 2022 01:19:05 +0000 (13:19 +1200)]
[REF] [Upgrade] Remove the entry point that called the unused entry point

2 years agoMerge pull request #24280 from eileenmcnaughton/cust_err
Eileen McNaughton [Wed, 17 Aug 2022 00:53:40 +0000 (12:53 +1200)]
Merge pull request #24280 from eileenmcnaughton/cust_err

Importer - Remove unused functions (`isErrorInCustomData`, `getSubtypes`, `validateCustomField`)

2 years agoMerge pull request #24281 from eileenmcnaughton/tim
Eileen McNaughton [Wed, 17 Aug 2022 00:52:53 +0000 (12:52 +1200)]
Merge pull request #24281 from eileenmcnaughton/tim

(REF) I18nSubscriber - Rename parameter to be more evocative

2 years agoMerge pull request #24274 from eileenmcnaughton/flush
Tim Otten [Tue, 16 Aug 2022 23:39:09 +0000 (16:39 -0700)]
Merge pull request #24274 from eileenmcnaughton/flush

AllCoreTables - Dismbiguate `init `and `flush`

2 years ago[NFC] Add in Further debugging to authx test to try and debug issue on php8.1
Seamus Lee [Mon, 15 Aug 2022 08:16:38 +0000 (08:16 +0000)]
[NFC] Add in Further debugging to authx test to try and debug issue on php8.1

2 years agoAdd 'Entity' to the information import classes provide
Eileen McNaughton [Tue, 16 Aug 2022 23:34:52 +0000 (11:34 +1200)]
Add 'Entity' to the information import classes provide

2 years ago(REF) Define SpecProviderPass (extracted from CRM_Api4_Services)
Tim Otten [Mon, 15 Aug 2022 23:51:00 +0000 (16:51 -0700)]
(REF) Define SpecProviderPass (extracted from CRM_Api4_Services)

The `CRM_Api4_Services` implementation has a secret behavior that applies
to all services - it detects the tag 'spec_provider' and registers
with the spec-gatherer.

This kind of behavior is often implemented as "compiler pass" and given its
own documentation.

2 years ago(REF) Define EventScannerPass (extracted from CRM_Api4_Services)
Tim Otten [Mon, 15 Aug 2022 23:32:04 +0000 (16:32 -0700)]
(REF) Define EventScannerPass (extracted from CRM_Api4_Services)

The `CRM_Api4_Services` implementation has a secret behavior that applies
to all services - it detects the tag 'event_subscriber' and registers with
the dispatcher.

This kind of behavior is often implemented as "compiler pass" and given its
own documentation.

2 years ago(REF) I18nSubscriber - Rename parameter to be more evocative
Tim Otten [Wed, 3 Aug 2022 05:00:23 +0000 (22:00 -0700)]
(REF) I18nSubscriber - Rename parameter to be more evocative

2 years agoRemove getSubTypes
Eileen McNaughton [Tue, 16 Aug 2022 20:40:16 +0000 (08:40 +1200)]
Remove getSubTypes

2 years agoRemove further unused function
Eileen McNaughton [Tue, 16 Aug 2022 20:36:50 +0000 (08:36 +1200)]
Remove further unused function

2 years agoRemove function only called from unittest
Eileen McNaughton [Tue, 16 Aug 2022 20:34:18 +0000 (08:34 +1200)]
Remove function only called from unittest

2 years agoRemove now-unused addField from Participant import
Eileen McNaughton [Tue, 16 Aug 2022 20:23:31 +0000 (08:23 +1200)]
Remove now-unused addField from Participant import

2 years ago(NFC) Mark various tests with `@group locale`
Tim Otten [Mon, 8 Aug 2022 09:24:33 +0000 (02:24 -0700)]
(NFC) Mark various tests with `@group locale`

Note: There seems to be some weirdness when running the full-group. But breaking down by a couple folders may help:

```
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/api/ --debug --group locale --stop-on-failure
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/CRM/ --debug --group locale --stop-on-failure
civibuild restore dmaster --no-cms ; CIVICRM_UF=UnitTests phpunit8 tests/phpunit/Civi/ --debug --group locale --stop-on-failure
```

2 years agoMerge pull request #24269 from eileenmcnaughton/msg
demeritcowboy [Tue, 16 Aug 2022 15:14:27 +0000 (11:14 -0400)]
Merge pull request #24269 from eileenmcnaughton/msg

Unhide message_admin extension

2 years agoMerge pull request #24273 from eileenmcnaughton/imp_has_loc
colemanw [Tue, 16 Aug 2022 13:31:09 +0000 (09:31 -0400)]
Merge pull request #24273 from eileenmcnaughton/imp_has_loc

Remove last usage of `_fields` from `Import_Parser`

2 years agoUpdate RuleGroupTest to flush sanely
Eileen McNaughton [Tue, 16 Aug 2022 11:51:52 +0000 (23:51 +1200)]
Update RuleGroupTest to flush sanely

2 years agoUpdate DynamicAuthorizationTest to flush sanely
Eileen McNaughton [Tue, 16 Aug 2022 08:55:50 +0000 (20:55 +1200)]
Update DynamicAuthorizationTest to flush sanely

2 years agoAlso merge in reinitializeCache
Eileen McNaughton [Tue, 16 Aug 2022 01:32:08 +0000 (13:32 +1200)]
Also merge in reinitializeCache

2 years agoDismbiguate init and flush
Eileen McNaughton [Tue, 16 Aug 2022 01:18:56 +0000 (13:18 +1200)]
Dismbiguate init and flush

2 years agoUpdate DAO to use declared primary field, do not assume...
Eileen McNaughton [Tue, 16 Aug 2022 07:34:26 +0000 (19:34 +1200)]
Update DAO to use declared primary field, do not assume...

2 years agoRename function
Eileen McNaughton [Mon, 15 Aug 2022 22:40:48 +0000 (10:40 +1200)]
Rename function

2 years agoMake property private
Eileen McNaughton [Mon, 15 Aug 2022 22:38:54 +0000 (10:38 +1200)]
Make property private

2 years agoRemove last usage of _fields
Eileen McNaughton [Mon, 15 Aug 2022 22:36:56 +0000 (10:36 +1200)]
Remove last usage of _fields

2 years agoMerge pull request #24266 from demeritcowboy/case-revision-warning
Seamus Lee [Tue, 16 Aug 2022 04:13:36 +0000 (14:13 +1000)]
Merge pull request #24266 from demeritcowboy/case-revision-warning

dev/core#1532 - Add upgrade message about civicase activity revisions

2 years agoMerge pull request #24244 from colemanw/case_id
Seamus Lee [Tue, 16 Aug 2022 04:13:22 +0000 (14:13 +1000)]
Merge pull request #24244 from colemanw/case_id

APIv4 - Add `case_id` field to Activity entity

2 years agoMerge pull request #24272 from eileenmcnaughton/leg_act
colemanw [Tue, 16 Aug 2022 02:52:39 +0000 (22:52 -0400)]
Merge pull request #24272 from eileenmcnaughton/leg_act

Remove another three no-longer-used functions

2 years agoMerge pull request #24270 from eileenmcnaughton/pseudos
colemanw [Tue, 16 Aug 2022 02:50:39 +0000 (22:50 -0400)]
Merge pull request #24270 from eileenmcnaughton/pseudos

Fix use of legacy pseudoConstant methods

2 years agoMerge pull request #24271 from eileenmcnaughton/leg_select
colemanw [Tue, 16 Aug 2022 02:48:20 +0000 (22:48 -0400)]
Merge pull request #24271 from eileenmcnaughton/leg_select

Remove no-longer-used function

2 years agoMerge pull request #24134 from mattwire/customgroupcasesensitive
demeritcowboy [Tue, 16 Aug 2022 01:29:33 +0000 (21:29 -0400)]
Merge pull request #24134 from mattwire/customgroupcasesensitive

Case-insensitive match on subtypes when validating subtype by entity for custom groups

2 years agoadd upgrade message
demeritcowboy [Mon, 15 Aug 2022 20:13:06 +0000 (16:13 -0400)]
add upgrade message

2 years agoMerge pull request #24154 from totten/master-setting-validate
colemanw [Mon, 15 Aug 2022 23:58:38 +0000 (19:58 -0400)]
Merge pull request #24154 from totten/master-setting-validate

SettingsStyleTest - Stop the madness

2 years agoAdd test for case_id token
Coleman Watts [Mon, 15 Aug 2022 23:20:57 +0000 (19:20 -0400)]
Add test for case_id token

2 years agoFinish removing refs to unused activeFields
Eileen McNaughton [Mon, 15 Aug 2022 22:29:04 +0000 (10:29 +1200)]
Finish removing refs to unused activeFields

2 years agoRemove setActiveField
Eileen McNaughton [Mon, 15 Aug 2022 22:25:28 +0000 (10:25 +1200)]
Remove setActiveField

2 years agoRemove another no-longer-used function
Eileen McNaughton [Mon, 15 Aug 2022 22:24:04 +0000 (10:24 +1200)]
Remove another no-longer-used function

2 years agoRemove no-longer-used function
Eileen McNaughton [Mon, 15 Aug 2022 22:18:11 +0000 (10:18 +1200)]
Remove no-longer-used function

2 years agoFix use of legacy pseudoConstant methods
Eileen McNaughton [Mon, 15 Aug 2022 22:09:29 +0000 (10:09 +1200)]
Fix use of legacy pseudoConstant methods

2 years agoUnhide message_admin extension
Eileen McNaughton [Mon, 15 Aug 2022 21:50:54 +0000 (09:50 +1200)]
Unhide message_admin extension

2 years agoMerge pull request #24217 from eileenmcnaughton/map
colemanw [Mon, 15 Aug 2022 20:04:31 +0000 (16:04 -0400)]
Merge pull request #24217 from eileenmcnaughton/map

[Import] [Ref] Extract shared form rule code

2 years agoRemove token case_id handling
Eileen McNaughton [Mon, 15 Aug 2022 19:42:23 +0000 (07:42 +1200)]
Remove token case_id handling

2 years agoMerge pull request #24262 from demeritcowboy/file-on-case
demeritcowboy [Mon, 15 Aug 2022 18:06:31 +0000 (14:06 -0400)]
Merge pull request #24262 from demeritcowboy/file-on-case

[NFC] Add test for editing activity subject to file on case

2 years agoadd test for editing activity subject to file on case
demeritcowboy [Mon, 15 Aug 2022 13:54:40 +0000 (09:54 -0400)]
add test for editing activity subject to file on case

2 years agoAPIv4 - Support case_id param for Activity.create, add test
Coleman Watts [Sat, 13 Aug 2022 18:37:22 +0000 (14:37 -0400)]
APIv4 - Support case_id param for Activity.create, add test

This moves processCaseActivity call out of APIv3 and into the BAO where it can be re-used by APIv4.

2 years agoAPIv4 - Add `case_id` field to Activity entity
Coleman Watts [Sat, 13 Aug 2022 01:30:40 +0000 (21:30 -0400)]
APIv4 - Add `case_id` field to Activity entity

This virtual field allows an activity to be easily filed on a case,
and for cases to be looked up in SearchKit activity searches.

2 years agoMerge pull request #24253 from bjendres/patch-1
Eileen McNaughton [Mon, 15 Aug 2022 10:43:43 +0000 (22:43 +1200)]
Merge pull request #24253 from bjendres/patch-1

Add hint to create membership "You do not have all the permissions needed for this page" message

2 years agoMerge pull request #24257 from civicrm/5.53
Seamus Lee [Mon, 15 Aug 2022 02:52:31 +0000 (12:52 +1000)]
Merge pull request #24257 from civicrm/5.53

5.53

2 years agoMerge pull request #24250 from demeritcowboy/set-alias
Seamus Lee [Mon, 15 Aug 2022 02:02:26 +0000 (12:02 +1000)]
Merge pull request #24250 from demeritcowboy/set-alias

dev/core#3802 - Compatibility with symfony 6 for drupal 10 for listeners added via getSubscribedEvents

2 years agoMerge pull request #24256 from seamuslee001/5.53
Seamus Lee [Mon, 15 Aug 2022 01:05:14 +0000 (11:05 +1000)]
Merge pull request #24256 from seamuslee001/5.53

[NFC] Convert Payment Processor ID field to payment processor in even…

2 years agosymfony 6 compatiblity
demeritcowboy [Sun, 14 Aug 2022 01:08:28 +0000 (21:08 -0400)]
symfony 6 compatiblity

2 years agoMerge pull request #24249 from colemanw/goodbyeRevisions
demeritcowboy [Sun, 14 Aug 2022 23:31:47 +0000 (19:31 -0400)]
Merge pull request #24249 from colemanw/goodbyeRevisions

dev/core#1532 - Remove civicaseActivityRevisions setting & related code

2 years ago[NFC] Convert Payment Processor ID field to payment processor in event create in...
Seamus Lee [Sun, 14 Aug 2022 23:02:52 +0000 (09:02 +1000)]
[NFC] Convert Payment Processor ID field to payment processor in event create in tests

2 years agoSearchKit - Add contacts to mailing group in batches
Coleman Watts [Sun, 14 Aug 2022 16:35:11 +0000 (12:35 -0400)]
SearchKit - Add contacts to mailing group in batches

For the "Email - schedule/send via CiviMail" action, this switches to
using the batch runner for adding contacts to the mailing group instead of
doing it all at once via chaining.
This prevents timeouts when creating very large mailings > 500 contacts.

2 years agoMerge pull request #24252 from demeritcowboy/impossible
colemanw [Sun, 14 Aug 2022 15:32:10 +0000 (11:32 -0400)]
Merge pull request #24252 from demeritcowboy/impossible

Remove unused impossible function in upgrade page

2 years agoCiviCase - Remove the civicaseActivityRevisions setting and related code
Coleman Watts [Sat, 13 Aug 2022 22:51:25 +0000 (18:51 -0400)]
CiviCase - Remove the civicaseActivityRevisions setting and related code

This setting has been deprecated for years, and core CiviCase doesn't respect it
anyway. Only the API was really paying attention to it. Time to get rid of that stuff
as a preamble to ripping out all of the case activity revisioning.

2 years agoAdd error hint
Björn Endres [Sun, 14 Aug 2022 14:55:04 +0000 (16:55 +0200)]
Add error hint

This exception is *also* raised, when no membership types have been configured yet, which can be very confusing. It cost me a two hours to figure out the real reason, and I have the nagging suspicion that this had happened to me before. I'm not too happy about the phrasing, but it would be good to have a reference to a potentially incomplete configuration. Thanks.

2 years agounused impossible function
demeritcowboy [Sun, 14 Aug 2022 11:52:07 +0000 (07:52 -0400)]
unused impossible function

2 years agoMerge pull request #24251 from colemanw/activityCaseCleanupDoc
demeritcowboy [Sun, 14 Aug 2022 11:13:08 +0000 (07:13 -0400)]
Merge pull request #24251 from colemanw/activityCaseCleanupDoc

Fix processCaseActivity docblock

2 years agoMerge pull request #24247 from colemanw/activityCaseCleanup
demeritcowboy [Sun, 14 Aug 2022 11:11:51 +0000 (07:11 -0400)]
Merge pull request #24247 from colemanw/activityCaseCleanup

[REF] Activity BAO - Decouple CiviCase logic from create function

2 years agoFix processCaseActivity docblock
Coleman Watts [Sun, 14 Aug 2022 03:40:50 +0000 (23:40 -0400)]
Fix processCaseActivity docblock

2 years agoActivity BAO - Decouple CiviCase logic from create function
Coleman Watts [Sat, 13 Aug 2022 18:56:06 +0000 (14:56 -0400)]
Activity BAO - Decouple CiviCase logic from create function

A big chunk of civicase code was jammed into the Activity create function.
This moves it to the Case BAO.

2 years agoMerge pull request #24248 from colemanw/deprecatedDaoProp
colemanw [Sat, 13 Aug 2022 22:34:50 +0000 (18:34 -0400)]
Merge pull request #24248 from colemanw/deprecatedDaoProp

NFC - Make it possible to mark a dao field @deprecated

2 years agoNFC - Make it possible to mark a dao field @deprecated
Coleman Watts [Sat, 13 Aug 2022 20:15:18 +0000 (16:15 -0400)]
NFC - Make it possible to mark a dao field @deprecated

2 years agoMerge pull request #24246 from demeritcowboy/bool-again
colemanw [Sat, 13 Aug 2022 18:25:01 +0000 (14:25 -0400)]
Merge pull request #24246 from demeritcowboy/bool-again

Resolve existential crisis for customfield.is_active