Eileen McNaughton [Fri, 27 May 2022 03:40:32 +0000 (15:40 +1200)]
e-notice fix
Eileen McNaughton [Fri, 27 May 2022 02:17:41 +0000 (14:17 +1200)]
Remove sneaky files
Eileen McNaughton [Sun, 22 May 2022 02:14:24 +0000 (14:14 +1200)]
Fix import to work with phone_ext, test
This fixes a couple of bugs I found writing tests & adds
test cover for website & phone imports + cleanup
Notably - creating a phone with a phone_ext or an email
with signature_text doesn't work prior to this
Eileen McNaughton [Tue, 24 May 2022 02:37:55 +0000 (14:37 +1200)]
Country validation
m
Eileen McNaughton [Tue, 24 May 2022 00:58:09 +0000 (12:58 +1200)]
Improve comparison for options
Eileen McNaughton [Tue, 24 May 2022 00:12:24 +0000 (12:12 +1200)]
Cleanup array explosion
Eileen McNaughton [Tue, 24 May 2022 00:13:58 +0000 (12:13 +1200)]
Use metadata to get the relevant entity
Eileen McNaughton [Thu, 26 May 2022 14:59:25 +0000 (02:59 +1200)]
Add as-yet-unused functions to reduce PR conflicts
Eileen McNaughton [Fri, 27 May 2022 06:43:11 +0000 (18:43 +1200)]
Merge pull request #23601 from colemanw/authxBeta
Authx - Mark extension as beta
Eileen McNaughton [Fri, 27 May 2022 04:45:23 +0000 (16:45 +1200)]
Merge pull request #23468 from mattwire/contributionpagedeprecatecompletetransaction
REF Deprecate method completeTransaction on contribution pages
Eileen McNaughton [Fri, 27 May 2022 03:43:01 +0000 (15:43 +1200)]
Update ext/authx/info.xml
Co-authored-by: Tim Otten <totten@civicrm.org>
Seamus Lee [Fri, 27 May 2022 02:51:26 +0000 (12:51 +1000)]
Merge pull request #23592 from eileenmcnaughton/import_parent
[Import] [ref] Move function to parent for use by siblings
colemanw [Fri, 27 May 2022 00:28:29 +0000 (20:28 -0400)]
Merge pull request #23565 from eileenmcnaughton/preffered_mail
Remove deprecated preferred_mail_format from more places...
colemanw [Fri, 27 May 2022 00:23:56 +0000 (20:23 -0400)]
Merge pull request #23605 from eileenmcnaughton/import_indie
Remove some never used fields - copy & paste begone
Eileen McNaughton [Thu, 26 May 2022 22:16:18 +0000 (10:16 +1200)]
Remove some never used fields - copy & paste begone
Eileen McNaughton [Thu, 26 May 2022 21:54:15 +0000 (09:54 +1200)]
Merge pull request #23562 from eileenmcnaughton/import_cc
Additional test
Matthew Wire [Mon, 16 May 2022 12:44:48 +0000 (13:44 +0100)]
Simplify parameters for completetransaction for zero value payment
Matthew Wire [Mon, 16 May 2022 12:31:54 +0000 (13:31 +0100)]
Deprecate method completeTransaction on contribution pages
Coleman Watts [Thu, 26 May 2022 18:27:42 +0000 (14:27 -0400)]
Authx - Mark extension as beta
demeritcowboy [Thu, 26 May 2022 18:06:23 +0000 (14:06 -0400)]
Merge pull request #23583 from colemanw/apiDisabledFields
APIv4 - Exclude disabled custom fields
Eileen McNaughton [Thu, 26 May 2022 07:25:32 +0000 (19:25 +1200)]
Use 'getParser' rathe than name the parser
Eileen McNaughton [Thu, 26 May 2022 07:21:11 +0000 (19:21 +1200)]
[Import] [ref] Move function to parent for use by siblings
Yashodha Chaku [Thu, 26 May 2022 14:06:06 +0000 (19:36 +0530)]
Merge pull request #23456 from eileenmcnaughton/import_more
[Import] Consolidate DataSource.tpl - template for first file on activity import
colemanw [Thu, 26 May 2022 12:16:50 +0000 (08:16 -0400)]
Merge pull request #23590 from eileenmcnaughton/import_member_labels
[Import] Add some not-yet-used `getParser` functions that are prone to conflict
Eileen McNaughton [Thu, 26 May 2022 11:02:17 +0000 (23:02 +1200)]
Merge pull request #23596 from civicrm/5.50
5.50 to master
Eileen McNaughton [Thu, 26 May 2022 11:01:52 +0000 (23:01 +1200)]
Merge pull request #23594 from totten/5.50-upgrade
Upgrader - Fix error on Snapshot::cleanupTask
Tim Otten [Thu, 26 May 2022 07:36:15 +0000 (00:36 -0700)]
Upgrader - Fix error on Snapshot::cleanupTask
This is a follow-up to #23522.
Before
------
Upgrade works on `cv upgrade:db` but fails on `drush civicrm-upgrade-db`
After
-----
Upgrades on both `cv upgrade:db` and `drush civicrm-upgrade-db`
Eileen McNaughton [Thu, 26 May 2022 07:09:36 +0000 (19:09 +1200)]
[Import] Add some not-yet-used functions that are prone to conflict
Eileen McNaughton [Thu, 26 May 2022 06:52:44 +0000 (18:52 +1200)]
Merge pull request #23589 from demeritcowboy/null
php8.1 - Check null first before sending to strlen
Monish Deb [Thu, 26 May 2022 06:11:28 +0000 (11:41 +0530)]
Merge pull request #23559 from eileenmcnaughton/import_yay
Another always-true-if
Eileen McNaughton [Thu, 26 May 2022 06:07:29 +0000 (18:07 +1200)]
Merge pull request #23570 from ufundo/mailing-group-token-frontend-title
dev/core#3463 - CiviMail - prefer frontend_title from group for mailiā¦
Monish Deb [Thu, 26 May 2022 05:42:21 +0000 (11:12 +0530)]
Merge pull request #23561 from eileenmcnaughton/import_catcher_
Test fix
Monish Deb [Thu, 26 May 2022 05:31:34 +0000 (11:01 +0530)]
Merge pull request #23576 from eileenmcnaughton/cust_it
Import - Relax "is_required" check for custom fields
demeritcowboy [Thu, 26 May 2022 04:51:31 +0000 (00:51 -0400)]
check null first
demeritcowboy [Thu, 26 May 2022 04:48:07 +0000 (00:48 -0400)]
Merge pull request #23516 from eileenmcnaughton/sms
dev/core#3177 Switch sms to use flexmailer token rendering
demeritcowboy [Thu, 26 May 2022 04:47:30 +0000 (00:47 -0400)]
Merge pull request #23318 from seamuslee001/php81_preg_replace
[REF] Fix handling of NULL values in count_characters smarty modifierā¦
Eileen McNaughton [Thu, 26 May 2022 01:36:24 +0000 (13:36 +1200)]
Merge pull request #23577 from demeritcowboy/deleted-tests
[NFC] Bring back deleted activity email tests
Eileen McNaughton [Thu, 26 May 2022 01:34:15 +0000 (13:34 +1200)]
Merge pull request #23579 from colemanw/searchKitFixCount
SearchKit - Fix pager & tab count after creating a new record in a popup
Coleman Watts [Wed, 25 May 2022 19:02:29 +0000 (15:02 -0400)]
APIv4 - Exclude disabled custom fields
colemanw [Thu, 26 May 2022 01:05:59 +0000 (21:05 -0400)]
Merge pull request #23578 from colemanw/managedSearchSegment
SearchKit - Allow SearchSegments to be packaged as .mgd.php
Eileen McNaughton [Wed, 25 May 2022 23:38:25 +0000 (11:38 +1200)]
Merge pull request #23587 from civicrm/5.50
5.50 to master
Eileen McNaughton [Wed, 25 May 2022 23:37:59 +0000 (11:37 +1200)]
Merge pull request #23584 from civicrm/5_50_guzzle
[REF] Upgrade Guzzle to 6.5.6
Eileen McNaughton [Wed, 25 May 2022 22:52:47 +0000 (10:52 +1200)]
Merge pull request #23581 from colemanw/removeUnused
ProximityQuery - Remove unused code
ufundo [Tue, 24 May 2022 19:20:37 +0000 (19:20 +0000)]
dev/core#3463 - CiviMail - prefer frontend_title from group for mailing.group token
Seamus Lee [Wed, 25 May 2022 21:27:47 +0000 (07:27 +1000)]
[REF] Upgrade Guzzle to 6.5.6
Eileen McNaughton [Wed, 25 May 2022 19:59:05 +0000 (07:59 +1200)]
Merge pull request #23573 from colemanw/searchKitBetterDefaults
SearchKit - Fix default aggregate function for grand total rows
demeritcowboy [Wed, 25 May 2022 18:50:51 +0000 (14:50 -0400)]
Merge pull request #23580 from colemanw/removeDeprecatedClass
Remove unused class
Coleman Watts [Wed, 25 May 2022 16:34:55 +0000 (12:34 -0400)]
ProximityQuery - Remove unused code
Coleman Watts [Wed, 25 May 2022 15:17:57 +0000 (11:17 -0400)]
Remove unused class
Class has been deprecated with a noisy warning for over 4 years
Coleman Watts [Wed, 25 May 2022 14:25:44 +0000 (10:25 -0400)]
SearchKit - Fix pager & tab count after creating a new record in a popup
Coleman Watts [Wed, 25 May 2022 14:09:40 +0000 (10:09 -0400)]
Allow SearchSegments to be packaged as .mgd.php
Coleman Watts [Tue, 24 May 2022 23:15:30 +0000 (19:15 -0400)]
SearchKit - Fix default aggregate function for grand total rows
demeritcowboy [Wed, 25 May 2022 13:22:54 +0000 (09:22 -0400)]
bring back deleted tests
colemanw [Wed, 25 May 2022 12:56:54 +0000 (08:56 -0400)]
Merge pull request #23519 from eileenmcnaughton/cont_parser
[Import] Fix Contribution Import mapping fields to use labels
Eileen McNaughton [Wed, 25 May 2022 09:33:20 +0000 (21:33 +1200)]
Merge pull request #23549 from JMAConsulting/issue_39
[Joomla 4.0] Fatal error on submitting Profile with CMS username/password
Eileen McNaughton [Fri, 20 May 2022 05:47:47 +0000 (17:47 +1200)]
[Import] Fix Contribution Import mapping fields to use labels
Eileen McNaughton [Fri, 13 May 2022 20:29:54 +0000 (08:29 +1200)]
Consolidate DataSource.tpl
I took a look at the activity DataSource.tpl and aside from minor
markup the only difference between it and the shared markup is
the absense of 'contactType' on the Activity form - so
I added an 'if'
Eileen McNaughton [Tue, 24 May 2022 22:07:28 +0000 (10:07 +1200)]
Remove preferred_mail_format handling from legacy mailing
Eileen McNaughton [Tue, 24 May 2022 08:35:05 +0000 (20:35 +1200)]
Remove deprecated preferred_mail_format from import
m
Eileen McNaughton [Wed, 25 May 2022 01:32:00 +0000 (13:32 +1200)]
Remove required field check on import
colemanw [Wed, 25 May 2022 01:28:07 +0000 (21:28 -0400)]
Merge pull request #23564 from eileenmcnaughton/validate
Move validate field function to the parent class [Straight move]
Eileen McNaughton [Wed, 25 May 2022 00:47:53 +0000 (12:47 +1200)]
Merge pull request #23575 from civicrm/5.50
5.50 to master
Eileen McNaughton [Wed, 25 May 2022 00:47:26 +0000 (12:47 +1200)]
Merge pull request #23572 from colemanw/resultLength
SearchKit - Fix 'undefined var' error after import
Tim Otten [Tue, 24 May 2022 23:59:30 +0000 (16:59 -0700)]
Merge pull request #23522 from totten/5.50-snapshot
Upgrader - Add support for automatic snapshots
Eileen McNaughton [Tue, 24 May 2022 23:08:44 +0000 (11:08 +1200)]
Merge pull request #23454 from colemanw/searchKitGrandTotals
Search kit grand totals
Coleman Watts [Tue, 24 May 2022 22:51:13 +0000 (18:51 -0400)]
SearchKit - Fix 'undefined var' error after import
colemanw [Tue, 24 May 2022 22:21:44 +0000 (18:21 -0400)]
Merge pull request #23571 from eileenmcnaughton/no_send
Add noisy deprecation to unused, deprecated, functions
Eileen McNaughton [Tue, 24 May 2022 19:49:17 +0000 (07:49 +1200)]
Add noisy deprecation to unused, deprecated, functions
These are only being accessed by tests so I removed those
Eileen McNaughton [Tue, 24 May 2022 19:16:42 +0000 (07:16 +1200)]
Merge pull request #23568 from civicrm/5.50
5.50 to master
Eileen McNaughton [Tue, 24 May 2022 19:13:35 +0000 (07:13 +1200)]
Merge pull request #23566 from eileenmcnaughton/550
Calculate unit_price based on qty
colemanw [Tue, 24 May 2022 14:23:18 +0000 (10:23 -0400)]
Merge pull request #23556 from eileenmcnaughton/import_depot
Remove do-nothing deprecated line
demeritcowboy [Tue, 24 May 2022 14:05:25 +0000 (10:05 -0400)]
Merge pull request #23548 from colemanw/post2
SearchKit - Use POST to send contact ids to action forms
Eileen McNaughton [Tue, 24 May 2022 10:06:00 +0000 (22:06 +1200)]
Merge pull request #23555 from civicrm/5.50
5.50
David Reedy Jr [Tue, 17 May 2022 13:15:21 +0000 (08:15 -0500)]
Calculate unit_price based on qty
Eileen McNaughton [Tue, 24 May 2022 07:55:21 +0000 (19:55 +1200)]
Move validate field function to the parent class
I am happy with the signature now so time for it to move to it's forever home
(Actually that's a bit of a euphemism - I'm kinda sending it to the farm
as I think it will get whittled away to nothing but that a conversation for another day
Monish Deb [Tue, 24 May 2022 07:01:00 +0000 (12:31 +0530)]
Merge pull request #23551 from eileenmcnaughton/import_no_go
Remove unreachable code
Eileen McNaughton [Tue, 24 May 2022 05:27:38 +0000 (17:27 +1200)]
Additional test
Monish Deb [Tue, 24 May 2022 06:05:46 +0000 (11:35 +0530)]
Merge pull request #23535 from eileenmcnaughton/import_prefix
Extend import option handling to prefix, suffix, language, communication_style
Eileen McNaughton [Tue, 24 May 2022 05:19:27 +0000 (17:19 +1200)]
Test fix
Tim Otten [Tue, 24 May 2022 05:10:39 +0000 (22:10 -0700)]
Define experimental option CIVICRM_UPGRADE_SNAPSHOT
Tim Otten [Tue, 24 May 2022 01:55:44 +0000 (18:55 -0700)]
CRM/Upgrade - Add notice about snap_* and MySQL configuration
Tim Otten [Tue, 24 May 2022 00:20:11 +0000 (17:20 -0700)]
CRM/Upgrade - Snapshots should have name `snap_{OWNER}_{VERSION}_{NAME}`
1. Prevents the trigger-based logging system from hitting the snapshots.
2. Makes the de-facto table names shorter (less likely to hit 64 char limit)
3. In practice, it should be easier to skim
4. Use the same pseudo-extension name that we use elsewhere (`civicrm`)
Tim Otten [Mon, 23 May 2022 21:58:18 +0000 (14:58 -0700)]
CRM/Upgrade - Snapshots should have name `civicrm_snap_{OWNER}_{VERSION}_{NAME}`
Tim Otten [Mon, 23 May 2022 21:45:54 +0000 (14:45 -0700)]
CRM/Upgrade - Store snapshots with compression. More comments.
Tim Otten [Fri, 20 May 2022 22:04:55 +0000 (15:04 -0700)]
(REF) SnapshotTest - Split big test in two. Cleanup comments.
Tim Otten [Fri, 20 May 2022 05:21:05 +0000 (22:21 -0700)]
CRM/Upgrade - Enable snapshots for 5.50.alpha1
Note: This is being committed during 5.50.beta1. If anyone previously
executed the upgrade for the RC/beta/alpha, then may not get snapshots. But
those upgrades are already done; and they're not guaranteed anyway; and the
snapshots aren't mandatory anyway.
Tim Otten [Fri, 20 May 2022 05:20:18 +0000 (22:20 -0700)]
CRM/Upgrade - Add basic support for snapshots to the upgrade framework
Tim Otten [Fri, 20 May 2022 05:05:20 +0000 (22:05 -0700)]
CRM/Upgrade - Define "Snapshot" helper (with unit-tests)
Eileen McNaughton [Tue, 24 May 2022 04:01:02 +0000 (16:01 +1200)]
Another always-true-if
Monish Deb [Mon, 23 May 2022 20:45:21 +0000 (02:15 +0530)]
[Joomla 4.0] Fatal error on submitting Profile with CMS username/password
Eileen McNaughton [Tue, 24 May 2022 02:39:59 +0000 (14:39 +1200)]
Remove do-nothing deprecated line
Eileen McNaughton [Mon, 23 May 2022 23:21:19 +0000 (11:21 +1200)]
Remove unreachable code
Seamus Lee [Tue, 24 May 2022 02:23:01 +0000 (12:23 +1000)]
Merge pull request #23528 from eileenmcnaughton/raw_money
Fix empty money handling
Seamus Lee [Tue, 24 May 2022 02:20:48 +0000 (12:20 +1000)]
Merge pull request #23550 from eileenmcnaughton/import_cust
Clean up function signature
Coleman Watts [Sat, 30 Apr 2022 20:59:19 +0000 (22:59 +0200)]
SearchKit - Use POST to send contact ids to action forms
Fixes dev/core#2736
colemanw [Mon, 23 May 2022 23:16:23 +0000 (19:16 -0400)]
Merge pull request #23532 from eileenmcnaughton/import_depo
Remove extraneous deprecated check
Eileen McNaughton [Sat, 21 May 2022 04:08:52 +0000 (16:08 +1200)]
Extend import option handling to prefix, suffix, language, communication_style
This extends a pattern thoroughly tested for gender to
other single-option-value fields & removes duplicate handling.
Test cover in
`CRM_Contact_Import_Parser_ContactTest::testPrefixLabel`
`CRM_Contact_Import_Parser_ContactTest::testPreferredLanguageImport`
Eileen McNaughton [Mon, 23 May 2022 21:03:08 +0000 (09:03 +1200)]
Clean up function signature
colemanw [Mon, 23 May 2022 20:50:06 +0000 (16:50 -0400)]
Merge pull request #23533 from eileenmcnaughton/import_if
Remove always true if conditions (whitespace in next commit)
colemanw [Mon, 23 May 2022 20:49:38 +0000 (16:49 -0400)]
Merge pull request #23515 from eileenmcnaughton/no_prof
[REF] Simplify contact.create