Eileen McNaughton [Sun, 2 Apr 2023 07:18:24 +0000 (19:18 +1200)]
Fix error when importing a soft credit AND a note when currency not provided
Eileen McNaughton [Fri, 31 Mar 2023 01:39:08 +0000 (14:39 +1300)]
Merge pull request #25963 from seamuslee001/dev_core_4029
dev/core#4029 Ensure that Pan Truncation and card type id is recorded…
Seamus Lee [Thu, 30 Mar 2023 22:07:23 +0000 (09:07 +1100)]
dev/core#4029 Ensure that Pan Truncation and card type id is recorded when processing front end contributions
Eileen McNaughton [Wed, 29 Mar 2023 01:21:03 +0000 (14:21 +1300)]
Merge pull request #25950 from demeritcowboy/upgrade-fk
Make 5.60 upgrade rerunnable
demeritcowboy [Wed, 29 Mar 2023 00:27:54 +0000 (20:27 -0400)]
make upgrade rerunnable
colemanw [Tue, 28 Mar 2023 15:10:31 +0000 (11:10 -0400)]
Merge pull request #25927 from colemanw/entityRefFix
SearchKit - Fix handling of new Custom EntityReference fields
Tim Otten [Tue, 28 Mar 2023 06:52:09 +0000 (23:52 -0700)]
Merge pull request #25942 from totten/5.60-cache-test
Simplify steps of loading SimpleCacheTest from cache/integration-tests
Tim Otten [Tue, 28 Mar 2023 05:53:30 +0000 (22:53 -0700)]
(NFC) SimpleCacheTest - Adapt license
The copied declaration references a file that doesn't exist. Just inline it.
demeritcowboy [Sun, 12 Mar 2023 20:48:48 +0000 (16:48 -0400)]
remove dependence on cache/integration-tests
Tim Otten [Tue, 28 Mar 2023 05:38:14 +0000 (22:38 -0700)]
Undeclare cache/integration-tests
Eileen McNaughton [Mon, 27 Mar 2023 21:00:45 +0000 (10:00 +1300)]
Merge pull request #25932 from ufundo/api-event-create-from-template
Fix for creating new events from template with api
benjamin [Mon, 27 Mar 2023 13:52:52 +0000 (13:52 +0000)]
fix creating new event from template
benjamin [Mon, 27 Mar 2023 14:16:25 +0000 (15:16 +0100)]
make test for creating event from template a bit more difficult
Matthew Wire [Mon, 27 Mar 2023 11:08:12 +0000 (12:08 +0100)]
Merge pull request #25912 from eileenmcnaughton/560
dev/core#4197 Ensure parameters are correct type
Coleman Watts [Sun, 26 Mar 2023 23:35:29 +0000 (19:35 -0400)]
APIv4 - Prevent errors during upgrade when loading custom field metadata
Coleman Watts [Sun, 26 Mar 2023 20:46:08 +0000 (16:46 -0400)]
SearchKit - Fix handing of new EntityReference custom fields
Fixes the metadata for the new EntityReference custom fields to correctly display.
Removes redundant function SpecFormatter::customFieldHasOptions which was completely
identical to CRM_Core_BAO_CustomField::hasOptions except for one line which was incorrect.
Jon Goldberg [Fri, 24 Mar 2023 20:22:38 +0000 (16:22 -0400)]
EntityRef fields don't get returned and can't be joined in API4
Mathieu Lu [Sat, 25 Mar 2023 00:28:33 +0000 (20:28 -0400)]
Merge pull request #25910 from eileenmcnaughton/regression_dd
dev/core#4189 Fix indiscriminate display of direct debit agreement
Eileen McNaughton [Fri, 24 Mar 2023 03:43:06 +0000 (16:43 +1300)]
dev/core#4197 Ensure parameters are correct type
colemanw [Fri, 24 Mar 2023 01:40:10 +0000 (21:40 -0400)]
Merge pull request #25897 from eileenmcnaughton/import_contact_id
Fix for issue when optional contact_id is blank importing contributions
Eileen McNaughton [Thu, 23 Mar 2023 23:33:14 +0000 (12:33 +1300)]
dev/core#4189 Fix indiscriminate display of direct debit agreement
Tim Otten [Thu, 23 Mar 2023 23:21:30 +0000 (16:21 -0700)]
Merge pull request #25909 from totten/5.60-vertest
(NFC) Version Check Test - Fix multi-user and concurrent execution
Tim Otten [Thu, 23 Mar 2023 22:22:10 +0000 (15:22 -0700)]
(NFC) Version Check Test - Fix multi-user and concurrent execution
This is a small change to the way the tests run. It doesn't change the meaning of the test.
Before
------
* Writes example file to `/tmp/versionCheckTestFile.json`.
* File left behind at end of test.
* If two users runs the same test at different times, they could interfere with each other.
* If two processes run the same test at the same time, they could interfere with each other.
After
-----
* Writes example file to `/tmp/VersionCheck-NNNNNNN/versionCheckTestFile.json`
* Temp folder cleaned up at end
* If two users or two processes run the test, they use separate folders
Eileen McNaughton [Wed, 22 Mar 2023 09:22:37 +0000 (22:22 +1300)]
Fix for issue when optional contact_id is blank
Eileen McNaughton [Thu, 16 Mar 2023 23:20:05 +0000 (12:20 +1300)]
Merge pull request #25849 from seamuslee001/dev_core_4190
dev/core#4190 Fix issue where defaultValues needs to be an array not …
Seamus Lee [Thu, 16 Mar 2023 21:34:02 +0000 (08:34 +1100)]
dev/core#4190 Fix issue where defaultValues needs to be an array not boolean
Eileen McNaughton [Thu, 16 Mar 2023 21:23:31 +0000 (10:23 +1300)]
Merge pull request #25846 from seamuslee001/fix_invalid_soft_credit_table
dev/core#4187 Fix errors when sorting by contributor name or receive …
Seamus Lee [Thu, 16 Mar 2023 20:32:49 +0000 (07:32 +1100)]
dev/core#4187 Fix errors when sorting by contributor name or receive date in the soft credit table
Eileen McNaughton [Thu, 16 Mar 2023 03:34:52 +0000 (16:34 +1300)]
Merge pull request #25822 from colemanw/afformValidateSavedSearch
Afform - Fix validateBySavedSearch
demeritcowboy [Thu, 16 Mar 2023 00:45:36 +0000 (20:45 -0400)]
Merge pull request #25835 from eileenmcnaughton/560
Remove require_dev yoast/phpunit-polyfills
Eileen McNaughton [Wed, 15 Mar 2023 23:04:04 +0000 (12:04 +1300)]
Remove require_dev yoast/phpunit-polyfills
Eileen McNaughton [Wed, 15 Mar 2023 19:15:05 +0000 (08:15 +1300)]
Merge pull request #25806 from mlutfy/core4166rc
dev/core#4166 Fix Contribute Import Parser fatal when soft-credit is empty
Mathieu Lutfy [Tue, 14 Mar 2023 00:59:29 +0000 (20:59 -0400)]
dev/core#4166 Fix Contribute Import Parser fatal when soft-credit is empty
Coleman Watts [Wed, 15 Mar 2023 13:31:49 +0000 (09:31 -0400)]
Afform - Fix validateBySavedSearch
Eileen McNaughton [Wed, 15 Mar 2023 01:29:16 +0000 (14:29 +1300)]
Merge pull request #25810 from eileenmcnaughton/import_subscriber
dev/core#4184 Fix Import over-authorization
Eileen McNaughton [Tue, 14 Mar 2023 20:08:27 +0000 (09:08 +1300)]
dev/core#4184 Fix Import over-authorization
Eileen McNaughton [Tue, 14 Mar 2023 23:06:34 +0000 (12:06 +1300)]
Merge pull request #25813 from samuelsov/5.60
dev/core#4186 regression for Contact Reference Autocomplete
Samuel Vanhove [Tue, 14 Mar 2023 21:27:24 +0000 (17:27 -0400)]
dev/core#4186 regression for Contact Reference Autocomplete
colemanw [Mon, 13 Mar 2023 14:23:56 +0000 (10:23 -0400)]
Merge pull request #25742 from colemanw/searchContainer
Afform - Fix editing search filters nested within multiple containers
Tim Otten [Fri, 10 Mar 2023 08:32:26 +0000 (00:32 -0800)]
Merge pull request #25778 from eileenmcnaughton/560
dev/core#4156 Fix failure to update organization_name on employees during merge
Eileen McNaughton [Fri, 10 Mar 2023 00:13:01 +0000 (13:13 +1300)]
dev/core#4156 Fix failure to update organization_name on employees during merge
Tim Otten [Thu, 9 Mar 2023 23:30:32 +0000 (15:30 -0800)]
Merge pull request #25775 from eileenmcnaughton/payapl
dev/core#4158 Fix for recurring double ups
Eileen McNaughton [Thu, 9 Mar 2023 22:22:50 +0000 (11:22 +1300)]
dev/core#4158 Fix for recurring double ups
Eileen McNaughton [Thu, 9 Mar 2023 03:41:59 +0000 (16:41 +1300)]
Merge pull request #25769 from agh1/5.60.0-releasenotes-initial
5.60.0 release notes initial run
Andie Hunt [Thu, 9 Mar 2023 01:12:28 +0000 (20:12 -0500)]
5.60.0 release notes: added boilerplate
Andie Hunt [Thu, 9 Mar 2023 01:08:43 +0000 (20:08 -0500)]
5.60.0 release notes: raw from script
Eileen McNaughton [Wed, 8 Mar 2023 03:38:41 +0000 (16:38 +1300)]
Merge pull request #25758 from eileenmcnaughton/560
Load submitted `fieldSeparator` on back on `Import Datasource` screen
Eileen McNaughton [Wed, 8 Mar 2023 02:15:39 +0000 (15:15 +1300)]
Load submitted fieldSeparator on back on Import Datasource screen
Eileen McNaughton [Tue, 7 Mar 2023 22:21:55 +0000 (11:21 +1300)]
Merge pull request #25753 from MegaphoneJon/two-field-separators-3
Remove the correct extraneous field separator field
Jon Goldberg [Mon, 6 Mar 2023 19:47:38 +0000 (14:47 -0500)]
Remove the correct extraneous field separator field
Tim Otten [Tue, 7 Mar 2023 04:18:39 +0000 (20:18 -0800)]
Merge pull request #25724 from eileenmcnaughton/crazy_complete
PayPal Prp IPN - Fix incorrect option_group update
Coleman Watts [Mon, 6 Mar 2023 21:13:20 +0000 (16:13 -0500)]
Afform - Fix editing search filters nested within multiple containers
Eileen McNaughton [Fri, 3 Mar 2023 05:41:32 +0000 (18:41 +1300)]
dev/core#4158 Fix incorrect option_group update in paypal recurring
This line was pointed out as being problematic in the issue
https://lab.civicrm.org/dev/core/-/issues/4158 and in a test
I was able to verify it causes issues if the value for Completed
in the contribution status option group is not the same as the
contribution recur option group. However, it appears to
be more of a theoretical / test creatable regression than a real
world one & is not a credible fix for the bug.
I think an rc merge without a stable back port is OK
Tim Otten [Sat, 4 Mar 2023 03:31:04 +0000 (19:31 -0800)]
Merge pull request #25733 from totten/5.60-upg-ml
Fix for 5.59 upgrade on multilingual
Jon Goldberg [Thu, 2 Mar 2023 15:37:09 +0000 (10:37 -0500)]
Fix for 5.59 upgrade on multilingual
Seamus Lee [Fri, 3 Mar 2023 21:02:53 +0000 (08:02 +1100)]
Merge pull request #25729 from MegaphoneJon/membership-lookup-fix
Contribution pages crash for logged-in users when CiviMember is disabled
Jon Goldberg [Fri, 3 Mar 2023 19:37:50 +0000 (14:37 -0500)]
Fix regression on contribution pages when CiviMember is not enabled
Tim Otten [Thu, 2 Mar 2023 22:45:41 +0000 (14:45 -0800)]
Merge pull request #25704 from totten/5.59-token-mismatch
(dev/core#4147) Add test and fix for various flaky tokens
Tim Otten [Thu, 2 Mar 2023 08:22:40 +0000 (00:22 -0800)]
Api4 - Rename Worldregion to WorldRegion
Tim Otten [Thu, 2 Mar 2023 05:53:53 +0000 (21:53 -0800)]
Worldregion - For API-entity-naming, prefer "WorldRegion"
CiviCRM [Thu, 2 Mar 2023 01:32:11 +0000 (01:32 +0000)]
Set version to 5.60.beta1
Eileen McNaughton [Wed, 1 Mar 2023 22:56:05 +0000 (11:56 +1300)]
Style
Eileen McNaughton [Wed, 1 Mar 2023 22:46:58 +0000 (11:46 +1300)]
Merge pull request #25706 from eileenmcnaughton/strict
Stricter typing in Apiv4
Eileen McNaughton [Wed, 1 Mar 2023 22:21:37 +0000 (11:21 +1300)]
Sigh, and they have colons:
Eileen McNaughton [Wed, 1 Mar 2023 22:20:16 +0000 (11:20 +1300)]
Fix key mismatch
Eileen McNaughton [Wed, 1 Mar 2023 22:19:02 +0000 (11:19 +1300)]
Fix preferred_communication method
Also fix over-aggressive test assertion
Eileen McNaughton [Wed, 1 Mar 2023 21:56:43 +0000 (10:56 +1300)]
Fix region token
Eileen McNaughton [Wed, 1 Mar 2023 21:49:40 +0000 (10:49 +1300)]
Stricter typing in Apiv4
Eileen McNaughton [Wed, 1 Mar 2023 21:47:44 +0000 (10:47 +1300)]
Add Worldregion api for join
Eileen McNaughton [Wed, 1 Mar 2023 21:47:26 +0000 (10:47 +1300)]
Fix for unresolved state_province
colemanw [Wed, 1 Mar 2023 21:03:00 +0000 (16:03 -0500)]
Merge pull request #25705 from eileenmcnaughton/dep
Remove deprecated function calls to Event::del, Membership functions del, OptionValue
Eileen McNaughton [Wed, 1 Mar 2023 20:09:49 +0000 (09:09 +1300)]
Rename variable - I figured out what it meant
Eileen McNaughton [Wed, 1 Mar 2023 20:08:31 +0000 (09:08 +1300)]
Adhere to comment block code standard
Standard is short one liner first:
Eileen McNaughton [Wed, 1 Mar 2023 20:07:37 +0000 (09:07 +1300)]
Superficial test cleanup, protect variable
Eileen McNaughton [Wed, 1 Mar 2023 20:05:46 +0000 (09:05 +1300)]
Add phpdoc to prevent restoreTime being removed
These unused variables cause quite a few bugs - keeping them 'matters' but
they look like they can go and people doing that happens moderately often,
causing bugs (this has been the cause of more than one 'locks don't work bug'
Eileen McNaughton [Wed, 1 Mar 2023 19:51:53 +0000 (08:51 +1300)]
Remove some calls to OptionValue deleteRecord
Eileen McNaughton [Wed, 1 Mar 2023 19:48:57 +0000 (08:48 +1300)]
Deprecations in Event, Membership
Per https://github.com/civicrm/civicrm-core/pull/25677
Eileen McNaughton [Wed, 1 Mar 2023 19:44:34 +0000 (08:44 +1300)]
Stop calling deprectated del function
Tim Otten [Wed, 1 Mar 2023 09:12:49 +0000 (01:12 -0800)]
(dev/core#4147) Add scenario testTokensIndividually
Tim Otten [Wed, 1 Mar 2023 09:10:40 +0000 (01:10 -0800)]
(REF) MessageTemplateTest - Extract method useFrozenTime()
Eileen McNaughton [Wed, 1 Mar 2023 06:34:22 +0000 (19:34 +1300)]
Merge pull request #25702 from civicrm/5.59
5.59
Yashodha Chaku [Wed, 1 Mar 2023 04:42:43 +0000 (10:12 +0530)]
Merge pull request #25698 from colemanw/removeIds
Remove deprecated use of $ids
Yashodha Chaku [Wed, 1 Mar 2023 04:40:51 +0000 (10:10 +0530)]
Merge pull request #25701 from alifrumin/5.59rn
[NFC] 5.59 release notes sorting and annotating
Alice Frumin [Wed, 1 Mar 2023 03:56:11 +0000 (22:56 -0500)]
[NFC] 5.59 release notes sorting and annotating
Eileen McNaughton [Wed, 1 Mar 2023 02:51:57 +0000 (15:51 +1300)]
Merge pull request #25699 from civicrm/5.59
5.59 to master
Eileen McNaughton [Wed, 1 Mar 2023 02:51:34 +0000 (15:51 +1300)]
Merge pull request #25697 from agh1/5.59.0-releasenotes-initial
5.59.0 releasenotes initial run
Tim Otten [Wed, 1 Mar 2023 01:44:30 +0000 (17:44 -0800)]
Merge pull request #25639 from eileenmcnaughton/import_validate
dev/core#4132 Fix import for multi-custom boxes
Coleman Watts [Wed, 1 Mar 2023 01:32:09 +0000 (20:32 -0500)]
Remove deprecated use of $ids
Andie Hunt [Wed, 1 Mar 2023 01:26:08 +0000 (20:26 -0500)]
5.59.0 release notes: added boilerplate
Andie Hunt [Wed, 1 Mar 2023 01:21:59 +0000 (20:21 -0500)]
5.59.0 release notes: raw from script
colemanw [Wed, 1 Mar 2023 00:57:11 +0000 (19:57 -0500)]
Merge pull request #25696 from colemanw/delDep
Delete long-deprecated functions
colemanw [Wed, 1 Mar 2023 00:22:38 +0000 (19:22 -0500)]
Merge pull request #25695 from eileenmcnaughton/CRM/Block
Pull over a few more deprecations + blockDelete deprecation
Coleman Watts [Wed, 1 Mar 2023 00:04:36 +0000 (19:04 -0500)]
Delete long-deprecated functions
Eileen McNaughton [Tue, 28 Feb 2023 23:48:27 +0000 (12:48 +1300)]
Pull over a few more deprecations + blockDelete deprecation
Eileen McNaughton [Tue, 28 Feb 2023 23:45:38 +0000 (12:45 +1300)]
Merge pull request #25693 from eileenmcnaughton/CRM/Block
Address portions of deprecated code replacement
Eileen McNaughton [Tue, 28 Feb 2023 22:31:22 +0000 (11:31 +1300)]
Address portions of deprecated code replacement
colemanw [Tue, 28 Feb 2023 22:07:48 +0000 (17:07 -0500)]
Merge pull request #25691 from eileenmcnaughton/dep_mailing
Deprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 21:49:55 +0000 (10:49 +1300)]
Merge pull request #25690 from eileenmcnaughton/dep_test
Deprecations for delete on ACL entities
Eileen McNaughton [Tue, 28 Feb 2023 21:01:23 +0000 (10:01 +1300)]
Deprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 20:51:03 +0000 (09:51 +1300)]
Deprecations for delete on ACL entities