civicrm-core.git
9 years agoINFRA-132 - js/view/crm.designer.js - Cleanup empty checks to satisfy jshint
Tim Otten [Mon, 5 Jan 2015 21:45:11 +0000 (13:45 -0800)]
INFRA-132 - js/view/crm.designer.js - Cleanup empty checks to satisfy jshint

9 years agoINFRA-132 - js/model/crm.uf.js - Cleanup empty checks to satisfy jshint
Tim Otten [Mon, 5 Jan 2015 21:45:11 +0000 (13:45 -0800)]
INFRA-132 - js/model/crm.uf.js - Cleanup empty checks to satisfy jshint

9 years agoINFRA-132 - js/crm.backbone.js - Cleanup empty checks to satisfy jshint
Tim Otten [Mon, 5 Jan 2015 21:45:11 +0000 (13:45 -0800)]
INFRA-132 - js/crm.backbone.js - Cleanup empty checks to satisfy jshint

9 years agoINFRA-132 - Fix jshint warnings in js/*.js
Tim Otten [Sat, 3 Jan 2015 22:59:12 +0000 (14:59 -0800)]
INFRA-132 - Fix jshint warnings in js/*.js

9 years agoINFRA-132 - Fix jshint warnings in js/jquery/*.js
Tim Otten [Sat, 3 Jan 2015 22:58:48 +0000 (14:58 -0800)]
INFRA-132 - Fix jshint warnings in js/jquery/*.js

9 years agoINFRA-132 - Fix jshint warnings in Backbone-based code
Tim Otten [Sat, 3 Jan 2015 22:58:25 +0000 (14:58 -0800)]
INFRA-132 - Fix jshint warnings in Backbone-based code

9 years agoINFRA-132 - Fix jshint warnings in js/angular*.js
Tim Otten [Sat, 3 Jan 2015 22:57:44 +0000 (14:57 -0800)]
INFRA-132 - Fix jshint warnings in js/angular*.js

9 years agoMerge pull request #4845 from colemanw/CRM-15409
colemanw [Mon, 5 Jan 2015 20:18:20 +0000 (15:18 -0500)]
Merge pull request #4845 from colemanw/CRM-15409

CRM-15409 - Fix handling of traditional links in popups

9 years agoCRM-15409 - Fix handling of traditional links in popups
Coleman Watts [Mon, 5 Jan 2015 18:40:25 +0000 (13:40 -0500)]
CRM-15409 - Fix handling of traditional links in popups

9 years agoMerge remote-tracking branch 'upstream/4.5' into 4.5-master-2015-01-05-23-28-33
kurund [Mon, 5 Jan 2015 17:58:47 +0000 (23:28 +0530)]
Merge remote-tracking branch 'upstream/4.5' into 4.5-master-2015-01-05-23-28-33

9 years agoMerge pull request #4836 from colemanw/edit
colemanw [Mon, 5 Jan 2015 17:49:03 +0000 (12:49 -0500)]
Merge pull request #4836 from colemanw/edit

Support editable multi-value custom data

9 years agoMerge pull request #4839 from rohankatkar/Webtests-4.6
Kurund Jalmi [Mon, 5 Jan 2015 17:35:49 +0000 (23:05 +0530)]
Merge pull request #4839 from rohankatkar/Webtests-4.6

Webtests and CRM test fix

9 years agoMerge pull request #4830 from PalanteJon/CRM-15774
Yashodha Chaku [Mon, 5 Jan 2015 11:04:22 +0000 (16:34 +0530)]
Merge pull request #4830 from PalanteJon/CRM-15774

CRM-15774 - Core - Call BAO not DAO on contact create via profile

9 years agoMerge pull request #4837 from eileenmcnaughton/CRM-15779
Yashodha Chaku [Mon, 5 Jan 2015 09:37:20 +0000 (15:07 +0530)]
Merge pull request #4837 from eileenmcnaughton/CRM-15779

CRM-15779 remove duplicate code block

9 years agoMerge pull request #4841 from civicrm/CRM-14461
Yashodha Chaku [Mon, 5 Jan 2015 08:54:55 +0000 (14:24 +0530)]
Merge pull request #4841 from civicrm/CRM-14461

CRM-14461: note fields not handled properly for components during export

9 years agoMerge pull request #4840 from eileenmcnaughton/tidy-ups
Yashodha Chaku [Mon, 5 Jan 2015 08:53:51 +0000 (14:23 +0530)]
Merge pull request #4840 from eileenmcnaughton/tidy-ups

minor tidyups

9 years agoMerge pull request #4832 from williamtheaker/CRM-14749
Yashodha Chaku [Mon, 5 Jan 2015 07:13:52 +0000 (12:43 +0530)]
Merge pull request #4832 from williamtheaker/CRM-14749

CRM-14749 Add insert token to Address Display Format

9 years agoCRM-14461: note fields not handled properly for components during export
yashodha [Mon, 5 Jan 2015 06:25:02 +0000 (11:55 +0530)]
CRM-14461: note fields not handled properly for components during export

----------------------------------------
* CRM-14461: Participant notes incomplete when exporting participants
  https://issues.civicrm.org/jira/browse/CRM-14461

9 years agominor tidyups
Eileen McNaughton [Mon, 5 Jan 2015 06:07:25 +0000 (19:07 +1300)]
minor tidyups

9 years agoWebtests and CRM test fix
Rohan Katkar [Mon, 5 Jan 2015 06:04:28 +0000 (11:34 +0530)]
Webtests and CRM test fix

9 years agoCRM-15779 remove duplicate code block
Eileen McNaughton [Mon, 5 Jan 2015 03:23:02 +0000 (16:23 +1300)]
CRM-15779 remove duplicate code block

9 years agoCRM-15759 - Improve crmEditable api validation and error handling
Coleman Watts [Mon, 5 Jan 2015 03:05:40 +0000 (22:05 -0500)]
CRM-15759 - Improve crmEditable api validation and error handling

9 years agoCRM-15759 - Support editable multi-value custom data
Coleman Watts [Mon, 5 Jan 2015 03:04:09 +0000 (22:04 -0500)]
CRM-15759 - Support editable multi-value custom data

9 years agoFix button markup
Coleman Watts [Mon, 5 Jan 2015 03:00:17 +0000 (22:00 -0500)]
Fix button markup

9 years agoMerge pull request #4834 from eileenmcnaughton/tidy-up
Eileen McNaughton [Mon, 5 Jan 2015 02:07:21 +0000 (15:07 +1300)]
Merge pull request #4834 from eileenmcnaughton/tidy-up

remove a  bunch of unused variable assignments

9 years agoa couple of comment block fixes
Eileen McNaughton [Mon, 5 Jan 2015 01:52:45 +0000 (14:52 +1300)]
a couple of comment block fixes

9 years agoremove a bunch of unused variable assignments
Eileen McNaughton [Mon, 5 Jan 2015 01:14:27 +0000 (14:14 +1300)]
remove a  bunch of unused variable assignments

9 years agoMerge pull request #3857 from totten/master-donquixote
Tim Otten [Sat, 3 Jan 2015 23:03:01 +0000 (15:03 -0800)]
Merge pull request #3857 from totten/master-donquixote

Docblocks and misc cleanup

9 years agoCRM_Contribute_Page_ContributionPage - Campaign IDs
Tim Otten [Sat, 16 Aug 2014 00:21:19 +0000 (17:21 -0700)]
CRM_Contribute_Page_ContributionPage - Campaign IDs

Fix for case where count()==1. Simplify.

9 years agoCRM_Contribute_Page_ContributionPage: Robust handling of campaign ids.
Andreas Hennings [Tue, 11 Feb 2014 22:35:28 +0000 (23:35 +0100)]
CRM_Contribute_Page_ContributionPage: Robust handling of campaign ids.

9 years agoRemove unused.
Andreas Hennings [Tue, 11 Feb 2014 19:41:22 +0000 (20:41 +0100)]
Remove unused.

9 years agoExplicit checks for external symbols.
Andreas Hennings [Tue, 11 Feb 2014 19:35:41 +0000 (20:35 +0100)]
Explicit checks for external symbols.

9 years agoExplicit return NULL.
Andreas Hennings [Tue, 11 Feb 2014 19:35:23 +0000 (20:35 +0100)]
Explicit return NULL.

9 years agoIndentation, whitespace and wrapping.
Andreas Hennings [Tue, 11 Feb 2014 19:35:08 +0000 (20:35 +0100)]
Indentation, whitespace and wrapping.

9 years agoMore @todo
Andreas Hennings [Tue, 11 Feb 2014 19:30:54 +0000 (20:30 +0100)]
More @todo

9 years agoDocblock improvements
Andreas Hennings [Tue, 11 Feb 2014 19:30:20 +0000 (20:30 +0100)]
Docblock improvements

9 years agoAdd type conversion to constants, because IDE cannot know for sure they are integer...
Andreas Hennings [Tue, 11 Feb 2014 18:21:19 +0000 (19:21 +0100)]
Add type conversion to constants, because IDE cannot know for sure they are integer. This might be controversial.

9 years agoMore @todo items, possible bugs.
Andreas Hennings [Tue, 11 Feb 2014 18:20:33 +0000 (19:20 +0100)]
More @todo items, possible bugs.

9 years agoMore docblock stuff.
Andreas Hennings [Tue, 11 Feb 2014 18:19:57 +0000 (19:19 +0100)]
More docblock stuff.

9 years agoAdd @todo tags in CRM_Utils_Request and CRM_Utils_Type.
Andreas Hennings [Tue, 11 Feb 2014 17:02:01 +0000 (18:02 +0100)]
Add @todo tags in CRM_Utils_Request and CRM_Utils_Type.

9 years agoMore docblock improvements.
Andreas Hennings [Tue, 11 Feb 2014 16:58:22 +0000 (17:58 +0100)]
More docblock improvements.

9 years agoMerge branch 'giant-rabbit-angular-tests'
Tim Otten [Sat, 3 Jan 2015 17:53:03 +0000 (09:53 -0800)]
Merge branch 'giant-rabbit-angular-tests'

9 years agocrmApp, crmUtil - Tighten scope of crmApp. Move services to crmUtil. Avoid cyclic...
Tim Otten [Sat, 3 Jan 2015 17:46:00 +0000 (09:46 -0800)]
crmApp, crmUtil - Tighten scope of crmApp. Move services to crmUtil. Avoid cyclic dependencies.

All services, routes, controllers, and directives should live in specific
Angular modules.  When it comes time to display a complete web page, these
modules are aggregated to form crmApp.  crmApp is a thin piece of glue whose
sole purpose is aggregation.

9 years agocrmUtil - Alphabetize services
Tim Otten [Sat, 3 Jan 2015 17:41:04 +0000 (09:41 -0800)]
crmUtil - Alphabetize services

9 years agoCRM_Core_Page_Angular - Fix badly merged list of modules.
Tim Otten [Sat, 3 Jan 2015 17:25:25 +0000 (09:25 -0800)]
CRM_Core_Page_Angular - Fix badly merged list of modules.

Also: Alphabetize list so that future issues with modules are easier to recognize.

9 years agoMerge branch 'angular-tests' of https://github.com/giant-rabbit/civicrm-core into...
Tim Otten [Sat, 3 Jan 2015 17:23:58 +0000 (09:23 -0800)]
Merge branch 'angular-tests' of https://github.com/giant-rabbit/civicrm-core into giant-rabbit-angular-tests

9 years agoCRM-14749 Add insert token to Address Display Format
williamtheaker [Sat, 3 Jan 2015 06:29:50 +0000 (22:29 -0800)]
CRM-14749 Add insert token to Address Display Format

9 years agoMerge pull request #4827 from colemanw/CRM-15759
colemanw [Sat, 3 Jan 2015 04:15:04 +0000 (23:15 -0500)]
Merge pull request #4827 from colemanw/CRM-15759

CRM-15759 - Extend in-place editing to more places

9 years agoCRM-15759 - Fix crmEditable textarea handling
Coleman Watts [Sat, 3 Jan 2015 02:28:12 +0000 (21:28 -0500)]
CRM-15759 - Fix crmEditable textarea handling

9 years agoCRM-15759 - Apply crmEditable behavior based on events instead of a template
Coleman Watts [Sat, 3 Jan 2015 02:14:42 +0000 (21:14 -0500)]
CRM-15759 - Apply crmEditable behavior based on events instead of a template

9 years agoCRM-15774 - Core - Call BAO not DAO on contact create via profile
Jon goldberg [Fri, 2 Jan 2015 22:31:59 +0000 (17:31 -0500)]
CRM-15774 - Core - Call BAO not DAO on contact create via profile

9 years agocrmEditable code cleanup
Coleman Watts [Fri, 2 Jan 2015 18:46:57 +0000 (13:46 -0500)]
crmEditable code cleanup

9 years agoCRM-15759 - Extend in-place editing to more places
Coleman Watts [Fri, 2 Jan 2015 15:26:08 +0000 (10:26 -0500)]
CRM-15759 - Extend in-place editing to more places

9 years agoCRM-15759 - support empty select option in crmEditable
Coleman Watts [Fri, 2 Jan 2015 15:25:02 +0000 (10:25 -0500)]
CRM-15759 - support empty select option in crmEditable

9 years agoRemove unused code
Coleman Watts [Fri, 2 Jan 2015 15:22:47 +0000 (10:22 -0500)]
Remove unused code

9 years agoFix membershipType options lookup and display
Coleman Watts [Fri, 2 Jan 2015 01:34:08 +0000 (20:34 -0500)]
Fix membershipType options lookup and display

9 years agoCRM-15759 - Improve support for crmEditable select options
Coleman Watts [Thu, 1 Jan 2015 18:28:32 +0000 (13:28 -0500)]
CRM-15759 - Improve support for crmEditable select options

9 years agoFix incorrect participantStatusClass options lookup
Coleman Watts [Thu, 1 Jan 2015 18:26:20 +0000 (13:26 -0500)]
Fix incorrect participantStatusClass options lookup

9 years agoMerge pull request #4828 from colemanw/CRM-15773
colemanw [Fri, 2 Jan 2015 21:01:25 +0000 (16:01 -0500)]
Merge pull request #4828 from colemanw/CRM-15773

CRM-15773 - Use the term Order instead of Weight consistently

9 years agoCRM-15773 - Use the term Order instead of Weight consistently
Coleman Watts [Fri, 2 Jan 2015 19:29:26 +0000 (14:29 -0500)]
CRM-15773 - Use the term Order instead of Weight consistently

9 years agoWarn of deprecated fn $.crmAccordions
Coleman Watts [Fri, 2 Jan 2015 18:42:46 +0000 (13:42 -0500)]
Warn of deprecated fn $.crmAccordions

This function has been deprecated and will be removed in the future.

9 years agoMerge pull request #4826 from monishdeb/CRM-15740
Yashodha Chaku [Fri, 2 Jan 2015 15:28:06 +0000 (20:58 +0530)]
Merge pull request #4826 from monishdeb/CRM-15740

CRM-15740 QA fix

9 years agoCRM-15740 QA fix
monishdeb [Fri, 2 Jan 2015 14:17:04 +0000 (19:47 +0530)]
CRM-15740 QA fix

----------------------------------------
* CRM-15740: Really long URLs cause SQL issue in a trackable mass mail
  https://issues.civicrm.org/jira/browse/CRM-15740

9 years agoMerge pull request #4823 from jitendrapurohit/webtestfixes
Monish Deb [Fri, 2 Jan 2015 13:50:43 +0000 (19:20 +0530)]
Merge pull request #4823 from jitendrapurohit/webtestfixes

webtest fixes 4.6

9 years agowebtest fixes 4.6
jitendrapurohit [Fri, 2 Jan 2015 12:34:12 +0000 (18:04 +0530)]
webtest fixes 4.6

9 years agoMerge pull request #4822 from kurund/indentation-fixes
Kurund Jalmi [Fri, 2 Jan 2015 12:27:58 +0000 (17:57 +0530)]
Merge pull request #4822 from kurund/indentation-fixes

indentation fixes

9 years agoindentation fixes
kurund [Fri, 2 Jan 2015 11:36:54 +0000 (17:06 +0530)]
indentation fixes

9 years agoMerge pull request #4817 from williamtheaker/patch-2
Yashodha Chaku [Fri, 2 Jan 2015 10:45:12 +0000 (16:15 +0530)]
Merge pull request #4817 from williamtheaker/patch-2

Replace wizard-bar radical with heavy checkmark

9 years agoMerge pull request #4820 from kurund/CRM-15705
Kurund Jalmi [Fri, 2 Jan 2015 10:38:21 +0000 (16:08 +0530)]
Merge pull request #4820 from kurund/CRM-15705

CRM-15705

9 years agoMerge pull request #4821 from jitendrapurohit/webtestcorebugfix
Yashodha Chaku [Fri, 2 Jan 2015 10:18:44 +0000 (15:48 +0530)]
Merge pull request #4821 from jitendrapurohit/webtestcorebugfix

Notification for Updation not shown after Save button is clicked on Mana...

9 years agoNotification for Updation not shown after Save button is clicked on Manage Event...
jitendrapurohit [Fri, 2 Jan 2015 09:00:30 +0000 (14:30 +0530)]
Notification for Updation not shown after Save button is clicked on Manage Event Tab for PCP

9 years agoMerge pull request #4818 from pratikshad/CRM-15770
Yashodha Chaku [Fri, 2 Jan 2015 05:35:06 +0000 (11:05 +0530)]
Merge pull request #4818 from pratikshad/CRM-15770

CRM-15770 fixes issue of empty date processing into membership page for ...

9 years agoCRM-15770 fixes issue of empty date processing into membership page for offline
pratikshad [Fri, 2 Jan 2015 04:27:35 +0000 (09:57 +0530)]
CRM-15770 fixes issue of empty date processing into membership page for offline

----------------------------------------
* CRM-15770: if $dateString is 'null' make no attempt to format it
  https://issues.civicrm.org/jira/browse/CRM-15770

9 years agoReplace wizard-bar radical with checkmark
William Theaker [Fri, 2 Jan 2015 03:42:57 +0000 (19:42 -0800)]
Replace wizard-bar radical with checkmark

9 years agoMerge pull request #4684 from eileenmcnaughton/CRM-15683-masger
Tim Otten [Thu, 1 Jan 2015 22:22:22 +0000 (14:22 -0800)]
Merge pull request #4684 from eileenmcnaughton/CRM-15683-masger

CRM-15678 hookable invalid page handling

9 years agoCRM-15683 - CRM_Core_Error::handleUnhandledException - Log double exceptions
Tim Otten [Thu, 1 Jan 2015 18:24:57 +0000 (10:24 -0800)]
CRM-15683 - CRM_Core_Error::handleUnhandledException - Log double exceptions

9 years agoCRM-15683 - CRM_Core_Invoke - Cleanup comments. Remove duplicate code.
Tim Otten [Thu, 1 Jan 2015 18:21:43 +0000 (10:21 -0800)]
CRM-15683 - CRM_Core_Invoke - Cleanup comments. Remove duplicate code.

The catch{} block in _invoke() duplicates the code now in LegacyErrorHandler.

9 years agoCRM-15683 - Add UnhandledExceptionEvent. Fixup LegacyErrorHandler.
Tim Otten [Thu, 11 Dec 2014 00:10:00 +0000 (16:10 -0800)]
CRM-15683 - Add UnhandledExceptionEvent. Fixup LegacyErrorHandler.

9 years agoCRM-15683 Tim's proposed changes
Eileen McNaughton [Tue, 9 Dec 2014 00:25:07 +0000 (13:25 +1300)]
CRM-15683 Tim's proposed changes

9 years agoremove handling for legacy status bounce as not found anywhere in code
Eileen McNaughton [Mon, 8 Dec 2014 23:59:13 +0000 (12:59 +1300)]
remove handling for legacy status bounce as not found anywhere in code

9 years agoCRM-15678 hookable invalid page handling
Eileen McNaughton [Sun, 7 Dec 2014 22:20:33 +0000 (11:20 +1300)]
CRM-15678 hookable invalid page handling

Conflicts:
CRM/Contribute/Form/ContributionBase.php

9 years agoMerge pull request #4815 from rohankatkar/Webtests
Monish Deb [Thu, 1 Jan 2015 17:53:20 +0000 (23:23 +0530)]
Merge pull request #4815 from rohankatkar/Webtests

Webtests Fixes

9 years agoMerge pull request #4812 from colemanw/CRM-15495
colemanw [Thu, 1 Jan 2015 15:44:44 +0000 (10:44 -0500)]
Merge pull request #4812 from colemanw/CRM-15495

CRM-15495 - Improve entityRef contact_type filter

9 years agoWebtests Fixes
Rohan Katkar [Thu, 1 Jan 2015 13:27:30 +0000 (18:57 +0530)]
Webtests Fixes

9 years agoMerge pull request #4813 from rohankatkar/CRM_15764
Monish Deb [Thu, 1 Jan 2015 12:43:51 +0000 (18:13 +0530)]
Merge pull request #4813 from rohankatkar/CRM_15764

CRM- 15764

9 years agoCRM-15764. Remove bogus opendir() call.
Chris Burgess [Mon, 29 Dec 2014 20:44:18 +0000 (09:44 +1300)]
CRM-15764. Remove bogus opendir() call.

opendir($cmsIncludePath) appears to have been used as is_dir(), not required since we check file_exists("$cmsIncludePath/file.xxx") and that indicates that the directory exists.

9 years agoMerge fix - CRM-15764
Chris Burgess [Sun, 28 Dec 2014 18:33:42 +0000 (07:33 +1300)]
Merge fix - CRM-15764

9 years agoImprove api.getoptions to return nested groups/tags
Coleman Watts [Thu, 1 Jan 2015 03:54:43 +0000 (22:54 -0500)]
Improve api.getoptions to return nested groups/tags

9 years agoCRM-15495 - Improve entityRef contact_type filter
Coleman Watts [Wed, 31 Dec 2014 21:45:33 +0000 (16:45 -0500)]
CRM-15495 - Improve entityRef contact_type filter

9 years agoMerge pull request #4809 from totten/master-cs2
Tim Otten [Wed, 31 Dec 2014 17:53:14 +0000 (09:53 -0800)]
Merge pull request #4809 from totten/master-cs2

Cleanup visibility, final newlines, and CONST

9 years agoMerge pull request #4804 from atif-shaikh/CRM-15767
Yashodha Chaku [Wed, 31 Dec 2014 13:19:12 +0000 (18:49 +0530)]
Merge pull request #4804 from atif-shaikh/CRM-15767

CRM-15767 - Back Office "Submit Credit Card Contribution" are not being ...

9 years agoMerge pull request #4811 from jitendrapurohit/CRM-15733
Monish Deb [Wed, 31 Dec 2014 09:22:17 +0000 (14:52 +0530)]
Merge pull request #4811 from jitendrapurohit/CRM-15733

CRM-15733 fix Contining a saved mailing doesn't load included or exclude...

9 years agoCRM-15733 fix Contining a saved mailing doesn't load included or excluded previous...
jitendrapurohit [Wed, 31 Dec 2014 07:30:46 +0000 (13:00 +0530)]
CRM-15733 fix Contining a saved mailing doesn't load included or excluded previous mailing recipients

9 years agoMerge pull request #4780 from williamtheaker/patch-1
Kurund Jalmi [Wed, 31 Dec 2014 04:56:31 +0000 (10:26 +0530)]
Merge pull request #4780 from williamtheaker/patch-1

Themed wizard-bar

9 years agoFixed drush and node_modules/*.info file conflict
Peter Haight [Wed, 31 Dec 2014 02:04:16 +0000 (18:04 -0800)]
Fixed drush and node_modules/*.info file conflict

Tim noticed that drush doesn't work when node_modules directory exists.
People say that it's because of the *.info files that some things have
in node_modules and suggested adding a line to the npm postinstall
script to remove  any *.info files from there because they aren't really
needed to run stuff. Because we are already doing brower install in the
postinstall script, I broke the postinstall stuff into a separate
script and put both things in there.

9 years agophpcs - Fix error, "Expected 1 newline at end of file; XXX found".
Tim Otten [Wed, 31 Dec 2014 01:23:33 +0000 (17:23 -0800)]
phpcs - Fix error, "Expected 1 newline at end of file; XXX found".

9 years agoNot used anymore.
Peter Haight [Wed, 31 Dec 2014 01:22:48 +0000 (17:22 -0800)]
Not used anymore.

I don't think this is used anymore. People just use setup.sh.

9 years agoInstall npm and bower modules in setup.
Peter Haight [Wed, 31 Dec 2014 01:18:10 +0000 (17:18 -0800)]
Install npm and bower modules in setup.

For the test and demo setups to work with the new npm and bower stuff,
npm install needs to get run. Civi buildkit calls setup.sh, so we'll put
it here for now.

9 years agoStyle - Remove @access
Tim Otten [Wed, 31 Dec 2014 01:00:26 +0000 (17:00 -0800)]
Style - Remove @access

1. These annotations are useful in PHP4-style code.
2. These annotations are useless in PHP5-style code. Either they're redundant with the code, or they contradict the code.
3. In cases where there are contradictions, I don't think there's anyway for us to generally resolve the contradiction except to say, "The code is right."
4. As a developer reading .php files, I look at the code and *never* look at @access.

9 years agoStyle - Remove @public, @private, @protected
Tim Otten [Tue, 30 Dec 2014 22:15:56 +0000 (14:15 -0800)]
Style - Remove @public, @private, @protected

1. These annotations are not valid in phpdoc. The actual annotation is "@access (public|private|protected)".
2. These annotations are useful in PHP4-style code.
3. These annotations are useless in PHP5-style code. Either they're redundant with the code, or they contradict the code.