Seamus Lee [Sat, 11 Mar 2023 23:21:58 +0000 (10:21 +1100)]
Merge pull request #25788 from braders/errortest-php82
[REF][PHP8.2] Declare property on CRM_Core_ErrorTest
Seamus Lee [Sat, 11 Mar 2023 23:21:47 +0000 (10:21 +1100)]
Merge pull request #25789 from braders/participantTest-dynamic-property
[REF][PHP8.2] Declare property on CRM_Event_Import_Parser_ParticipantTest
Bradley Taylor [Sat, 11 Mar 2023 11:20:44 +0000 (11:20 +0000)]
[REF][PHP8.2] Declare property on CRM_Event_Import_Parser_ParticipantTest
Bradley Taylor [Sat, 11 Mar 2023 11:17:10 +0000 (11:17 +0000)]
[REF][PHP8.2] Declare property on CRM_Core_ErrorTest
Eileen McNaughton [Sat, 11 Mar 2023 03:31:11 +0000 (16:31 +1300)]
Merge pull request #25657 from eileenmcnaughton/dynamic
dev/core#4144 Fix smarty notice on isDuplicate
Eileen McNaughton [Sat, 11 Mar 2023 02:11:02 +0000 (15:11 +1300)]
Merge pull request #16 from lemniscus/smarty-notices-profile-dynamic
fix notice in non-dialog mode too, make var name clearer, fix another notice
Noah Miller [Sat, 11 Mar 2023 00:59:23 +0000 (19:59 -0500)]
eliminate notice in non-dialog mode too, make var name clearer, fix another couple notices
Eileen McNaughton [Fri, 10 Mar 2023 22:38:15 +0000 (11:38 +1300)]
Merge pull request #25781 from colemanw/deprecateConstants
APIv4 - Deprecate unnecessary constants
Eileen McNaughton [Fri, 10 Mar 2023 22:01:47 +0000 (11:01 +1300)]
Merge pull request #25783 from seamuslee001/php82_mailing_contact
[NFC] Fix PHP8.2 issues in the Mailing Contact Test
Seamus Lee [Fri, 10 Mar 2023 20:55:20 +0000 (07:55 +1100)]
[NFC] Fix PHP8.2 issues in the Mailing Contact Test
Coleman Watts [Fri, 10 Mar 2023 20:25:46 +0000 (15:25 -0500)]
APIv4 - Deprecate unnecessary constants
Eileen McNaughton [Fri, 10 Mar 2023 04:06:06 +0000 (17:06 +1300)]
Merge pull request #25774 from eileenmcnaughton/import_cache
Fix cache clearing when import table is changed
Eileen McNaughton [Thu, 9 Mar 2023 04:31:35 +0000 (17:31 +1300)]
Fix cache clearing when import table is changed
Eileen McNaughton [Fri, 10 Mar 2023 01:07:46 +0000 (14:07 +1300)]
Merge pull request #25527 from eileenmcnaughton/finder_build
Fix dedupe finder performance issue on looking up table size
Eileen McNaughton [Fri, 10 Mar 2023 01:07:31 +0000 (14:07 +1300)]
Merge pull request #25712 from eileenmcnaughton/import_link
Import link - fix search Import SearchDisplays to link to the created contact
colemanw [Fri, 10 Mar 2023 00:27:30 +0000 (19:27 -0500)]
Merge pull request #25474 from eileenmcnaughton/civi-import
Hyphenate Civi-Import in the title/label
Coleman Watts [Thu, 9 Mar 2023 23:46:41 +0000 (18:46 -0500)]
Civi-Import Add fk joinable to api spec
Eileen McNaughton [Thu, 9 Mar 2023 22:53:48 +0000 (11:53 +1300)]
Merge pull request #25187 from totten/master-civiunit-more
CiviUnitTestCase - More aggressive simplifications
Eileen McNaughton [Thu, 9 Mar 2023 22:45:57 +0000 (11:45 +1300)]
Merge pull request #25677 from colemanw/noisyDeprecate
BAO - Noisily deprecate and stop using deprecated functions
Tim Otten [Thu, 9 Mar 2023 22:31:28 +0000 (14:31 -0800)]
Merge pull request #25749 from eileenmcnaughton/retreive
[REF] Improve function signature for `retrieve()` in `PaypalProIPN` , add test for when trxn_id is present
Coleman Watts [Mon, 27 Feb 2023 22:13:33 +0000 (17:13 -0500)]
BAO - Noisily deprecate and stop using deprecated functions
Eileen McNaughton [Thu, 9 Mar 2023 20:30:40 +0000 (09:30 +1300)]
Merge pull request #25770 from colemanw/replaceWithMatch
APIv4 - Support `match` in replaceAction
Eileen McNaughton [Thu, 9 Mar 2023 20:26:55 +0000 (09:26 +1300)]
Merge pull request #25768 from eileenmcnaughton/dep2
Remove function deprecated noisly in 2020
colemanw [Thu, 9 Mar 2023 17:18:45 +0000 (12:18 -0500)]
Merge pull request #25028 from MegaphoneJon/bad-pseudoconstants-api4
Don't crash API4 if pseudoconstant lookups return nothing
colemanw [Thu, 9 Mar 2023 16:14:52 +0000 (11:14 -0500)]
Merge pull request #25773 from colemanw/allYourBase
All your base are deleted
Coleman Watts [Thu, 9 Mar 2023 14:08:10 +0000 (09:08 -0500)]
All your base are deleted
colemanw [Thu, 9 Mar 2023 13:35:01 +0000 (08:35 -0500)]
Merge pull request #25767 from eileenmcnaughton/dep
More deprecations of `del`
Yashodha Chaku [Thu, 9 Mar 2023 06:36:33 +0000 (12:06 +0530)]
Merge pull request #25771 from eileenmcnaughton/datasource
Consolidate `DataSource.tpl`
Eileen McNaughton [Thu, 9 Mar 2023 06:26:00 +0000 (19:26 +1300)]
Merge pull request #25772 from lemniscus/smarty-notice-merge
Smarty notice fix on Merge
Noah Miller [Thu, 9 Mar 2023 03:43:09 +0000 (22:43 -0500)]
Smarty notice fix on Merge
Eileen McNaughton [Thu, 9 Mar 2023 03:22:20 +0000 (16:22 +1300)]
Consolidate DataSource.tpl
Coleman Watts [Thu, 9 Mar 2023 02:39:20 +0000 (21:39 -0500)]
APIv4 - Support `match` in replaceAction
This allows the replaceAction to support non-id matching, the same way as the saveAction does.
Fixes dev/core#4168
colemanw [Thu, 9 Mar 2023 02:10:27 +0000 (21:10 -0500)]
Merge pull request #25763 from eileenmcnaughton/coleman
Deprecate pledge_payment::del
colemanw [Thu, 9 Mar 2023 02:08:45 +0000 (21:08 -0500)]
Merge pull request #25766 from eileenmcnaughton/coleman2
Remove deprecated calls from contribute, financial, remove ManagePremiums deprecated BAO
Eileen McNaughton [Thu, 9 Mar 2023 00:23:19 +0000 (13:23 +1300)]
Remove function deprecated noisly in 2020
Eileen McNaughton [Thu, 9 Mar 2023 00:20:41 +0000 (13:20 +1300)]
More deprecations
Eileen McNaughton [Wed, 8 Mar 2023 23:01:34 +0000 (12:01 +1300)]
Remove deprecated calls from contribute, financial, remove ManagePremiums deprecated BAO
Eileen McNaughton [Wed, 8 Mar 2023 20:45:09 +0000 (09:45 +1300)]
Deprecate pledge_payment::del
colemanw [Wed, 8 Mar 2023 22:05:04 +0000 (17:05 -0500)]
Merge pull request #25764 from eileenmcnaughton/coleman2
Deprecations on del functions
colemanw [Wed, 8 Mar 2023 22:04:46 +0000 (17:04 -0500)]
Merge pull request #25765 from eileenmcnaughton/coleman_rel
Deprecate relationship::del
Eileen McNaughton [Wed, 8 Mar 2023 20:58:17 +0000 (09:58 +1300)]
Deprecate relationship::del
Eileen McNaughton [Wed, 8 Mar 2023 20:53:57 +0000 (09:53 +1300)]
Deprecations on del functions
Eileen McNaughton [Wed, 8 Mar 2023 19:48:57 +0000 (08:48 +1300)]
Merge pull request #25762 from colemanw/noisyDep
Noisily deprecate unused function
colemanw [Wed, 8 Mar 2023 16:26:46 +0000 (11:26 -0500)]
Merge pull request #25666 from kurund/file-validations-formbuilder
dev/core#4121 Afform: add validation for file fields in formbuilder
Coleman Watts [Wed, 8 Mar 2023 15:57:19 +0000 (10:57 -0500)]
Noisily deprecate unused function
Matthew Wire [Wed, 8 Mar 2023 15:53:30 +0000 (15:53 +0000)]
Merge pull request #25674 from colemanw/apiUpdateTest
APIv4 - Add 'Update' to conformanceTest
colemanw [Wed, 8 Mar 2023 15:45:13 +0000 (10:45 -0500)]
Merge pull request #25752 from eileenmcnaughton/cust_it
Remove remaining non-variable variables
demeritcowboy [Wed, 8 Mar 2023 15:24:26 +0000 (10:24 -0500)]
Merge pull request #25761 from seamuslee001/regen_561
Regen after civicrm-core#24735
Seamus Lee [Wed, 8 Mar 2023 06:52:43 +0000 (17:52 +1100)]
Regen after civicrm-core#24735
Eileen McNaughton [Wed, 8 Mar 2023 06:19:50 +0000 (19:19 +1300)]
Merge pull request #24735 from agileware/CIVICRM-2052
🪥 Fix inconsistent terminology used when referring to Member Since, Membership Start Date and Membership Expiration Date
Eileen McNaughton [Wed, 8 Mar 2023 03:39:10 +0000 (16:39 +1300)]
Merge pull request #25760 from civicrm/5.60
5.60 to master
Eileen McNaughton [Wed, 8 Mar 2023 03:38:41 +0000 (16:38 +1300)]
Merge pull request #25758 from eileenmcnaughton/560
Load submitted `fieldSeparator` on back on `Import Datasource` screen
demeritcowboy [Wed, 8 Mar 2023 02:58:58 +0000 (21:58 -0500)]
Merge pull request #25681 from agileware/CIVICRM-2103
dev/core/-/issues/4149 Change CKEditor 4 default to not encode HTML entities by default which breaks Smarty syntax and prevents use of crmDate function
demeritcowboy [Wed, 8 Mar 2023 02:51:19 +0000 (21:51 -0500)]
Merge pull request #25757 from eileenmcnaughton/import_table
Code cleanup: Use `parent::buildForm` in contact import dataSource screen
Eileen McNaughton [Wed, 8 Mar 2023 02:15:39 +0000 (15:15 +1300)]
Load submitted fieldSeparator on back on Import Datasource screen
colemanw [Wed, 8 Mar 2023 02:11:11 +0000 (21:11 -0500)]
Merge pull request #25751 from MegaphoneJon/relationship-cache-check
Relationship Cache check
Eileen McNaughton [Wed, 8 Mar 2023 01:04:48 +0000 (14:04 +1300)]
Use parent::buildForm in contact import dataSource screen
colemanw [Wed, 8 Mar 2023 00:45:47 +0000 (19:45 -0500)]
Merge pull request #25700 from eileenmcnaughton/address
Change title of is_primary fields consistent with Email
Eileen McNaughton [Wed, 8 Mar 2023 00:36:14 +0000 (13:36 +1300)]
Merge pull request #25750 from colemanw/ParticipantStatusType
APIv4 - Add ParticipantStatusType entity
Eileen McNaughton [Tue, 31 Jan 2023 04:43:32 +0000 (17:43 +1300)]
Hyphenate Civi-Import in the name
Eileen McNaughton [Thu, 23 Feb 2023 23:59:30 +0000 (12:59 +1300)]
dev/core#4144 Fix smarty notice on isDuplicate
Eileen McNaughton [Wed, 8 Feb 2023 04:56:22 +0000 (17:56 +1300)]
Fix performance on deciding which tables to query
Eileen McNaughton [Wed, 8 Mar 2023 00:11:09 +0000 (13:11 +1300)]
Merge pull request #25294 from colemanw/afformFileReupload
Afform - Show file field values for existing entities
demeritcowboy [Tue, 7 Mar 2023 23:53:17 +0000 (18:53 -0500)]
Merge pull request #25756 from demeritcowboy/separator
revert 25735
Eileen McNaughton [Tue, 7 Mar 2023 23:06:03 +0000 (12:06 +1300)]
Merge pull request #25755 from civicrm/5.60
5.60
demeritcowboy [Tue, 7 Mar 2023 22:37:36 +0000 (17:37 -0500)]
revert 25735
Eileen McNaughton [Tue, 7 Mar 2023 22:21:55 +0000 (11:21 +1300)]
Merge pull request #25753 from MegaphoneJon/two-field-separators-3
Remove the correct extraneous field separator field
colemanw [Tue, 7 Mar 2023 20:11:39 +0000 (15:11 -0500)]
Merge pull request #25719 from eileenmcnaughton/quick_config
Unconditionally assign `quickConfig`, add helper for `getPriceSetID`
Jon Goldberg [Mon, 6 Mar 2023 19:47:38 +0000 (14:47 -0500)]
Remove the correct extraneous field separator field
Jon Goldberg [Tue, 7 Mar 2023 19:22:05 +0000 (14:22 -0500)]
Relationship Cache check
Eileen McNaughton [Tue, 7 Mar 2023 19:43:28 +0000 (08:43 +1300)]
Remove remaining non-variable variables
Coleman Watts [Tue, 7 Mar 2023 18:46:31 +0000 (13:46 -0500)]
APIv4 - Add ParticipantStatusType entity
colemanw [Tue, 7 Mar 2023 18:34:35 +0000 (13:34 -0500)]
Merge pull request #25747 from eileenmcnaughton/c2
Stop using deprecated methods, `ufField::del`
colemanw [Tue, 7 Mar 2023 18:33:27 +0000 (13:33 -0500)]
Merge pull request #25746 from eileenmcnaughton/colemanw
Remove some deprecated del calls
colemanw [Tue, 7 Mar 2023 18:32:37 +0000 (13:32 -0500)]
Merge pull request #25745 from eileenmcnaughton/cust_it
Remove unvariable variables `toReturn` & `subName` from `Merger`
Tim Otten [Fri, 16 Dec 2022 08:00:46 +0000 (00:00 -0800)]
CiviUnitTestCase - Remove redundant reset
In CiviUnitTestCase, there are methods `setUpBeforeClass()` and `setUp()`.
Both methods reset the database unconditionally.
The general flow is like this:
1: setUpBeforeClass();
2: setUp(); testApple(); tearDown();
3: setUp(); testBanana(); tearDown();
4: setUp(); testCherry(); tearDown();
5: tearDownAfterClass();
You might say: "Aha! You need the call in `setUp`, because it runs more
frequently!" But not really - because `setUp()` has an extra guard
(`static::$dbInit`). In effect, you perform DB-reset at step 1 -- and then
immediately again on step 2 -- and then never again (steps 3+4+5).
It is conceivable that a subclass might override these methods and inject
additional initialization steps -- in which case, this patch may affect
their behavior. We'll just have to run the test-suite to find out.
Final thought - If `static::$dbInit` were manipulated by other code, then
`setUp()` would be much more interesting. But it's counterfactual -- grep
finds nothing that manipulates `dbInit`.
Tim Otten [Fri, 16 Dec 2022 07:59:33 +0000 (23:59 -0800)]
CiviUnitTestCase - Remove inert property `$DBResetRequired`
This property is assigned by ~30 tests, but it is never used.
Tim Otten [Fri, 16 Dec 2022 07:52:27 +0000 (23:52 -0800)]
CiviUnitTestCase - Display more accurate debug note
If you skimmed, you might say: It prints a console message when it resets
the DB. That seems like useful information for someone who wants to
understand the overall behavior, so good.
The reality is different. `setUpBeforeClass()` and `setUp()` both reset the
DB. `setUpBeforeClass()` does it for every test-class, but it never says so.
`setUp()` does it for the first test-method (and then no others).
So when it showed the message "Installing database", it should have really said:
> I just installed the database a minute ago without telling you.
> Now I'm installing it a second time, and you should know that.
> In the future, I will install twenty more times, but you don't need to know that.
That's a silly thing to say. Better to say when it's happening for realz.
Eileen McNaughton [Tue, 7 Mar 2023 06:31:14 +0000 (19:31 +1300)]
Fix retrieve function, add test for when trxn_id is present
Eileen McNaughton [Tue, 7 Mar 2023 05:56:08 +0000 (18:56 +1300)]
Merge pull request #25748 from civicrm/5.60
5.60 to master
Eileen McNaughton [Tue, 7 Mar 2023 05:25:37 +0000 (18:25 +1300)]
Merge pull request #25739 from colemanw/monthOptions
SearchKit - Add select options for MONTH date filter
Eileen McNaughton [Tue, 7 Mar 2023 05:25:19 +0000 (18:25 +1300)]
Merge pull request #25743 from colemanw/fixFkEntity
APIv4 - Don't link to non-existent API entities
Tim Otten [Tue, 7 Mar 2023 04:18:39 +0000 (20:18 -0800)]
Merge pull request #25724 from eileenmcnaughton/crazy_complete
PayPal Prp IPN - Fix incorrect option_group update
Eileen McNaughton [Tue, 7 Mar 2023 03:01:21 +0000 (16:01 +1300)]
Stop using deprecated methods, ufField
Eileen McNaughton [Tue, 7 Mar 2023 02:51:55 +0000 (15:51 +1300)]
Remove some deprecated del calls
Eileen McNaughton [Tue, 7 Mar 2023 02:42:23 +0000 (15:42 +1300)]
Remove unvariable variables toReturn & subName
These were established as unchanging here
https://github.com/civicrm/civicrm-core/pull/25676
colemanw [Tue, 7 Mar 2023 01:38:48 +0000 (20:38 -0500)]
Merge pull request #25676 from eileenmcnaughton/cust_it
Stop passing invariable variables to private function
Coleman Watts [Mon, 6 Mar 2023 18:43:31 +0000 (13:43 -0500)]
SearchKit - Add select options for MONTH date filter
Coleman Watts [Mon, 6 Mar 2023 22:31:57 +0000 (17:31 -0500)]
APIv4 - Don't link to non-existent API entities
Eileen McNaughton [Mon, 6 Mar 2023 20:52:37 +0000 (09:52 +1300)]
Merge pull request #25740 from colemanw/nextBirthday
SearchKit - Add next_birthday calc field
colemanw [Mon, 6 Mar 2023 20:33:30 +0000 (15:33 -0500)]
Merge pull request #25711 from eileenmcnaughton/import_expires
Filter 'My imports' to only show non-expired
Eileen McNaughton [Mon, 6 Mar 2023 20:27:34 +0000 (09:27 +1300)]
Fix url generation
Eileen McNaughton [Thu, 1 Dec 2022 02:37:08 +0000 (15:37 +1300)]
Fix label for _entity_id to be the correct entity
Coleman Watts [Mon, 6 Mar 2023 19:18:12 +0000 (14:18 -0500)]
SearchKit - Add next_birthday calc field
demeritcowboy [Mon, 6 Mar 2023 17:19:12 +0000 (12:19 -0500)]
Merge pull request #25735 from MegaphoneJon/two-field-separators
remove extra field separator field
Jon Goldberg [Mon, 6 Mar 2023 16:22:53 +0000 (11:22 -0500)]
remove extra field separator field
Eileen McNaughton [Fri, 3 Mar 2023 05:41:32 +0000 (18:41 +1300)]
dev/core#4158 Fix incorrect option_group update in paypal recurring
This line was pointed out as being problematic in the issue
https://lab.civicrm.org/dev/core/-/issues/4158 and in a test
I was able to verify it causes issues if the value for Completed
in the contribution status option group is not the same as the
contribution recur option group. However, it appears to
be more of a theoretical / test creatable regression than a real
world one & is not a credible fix for the bug.
I think an rc merge without a stable back port is OK
Seamus Lee [Sat, 4 Mar 2023 22:38:14 +0000 (09:38 +1100)]
Merge pull request #25725 from eileenmcnaughton/import_ex
Update Import fix to leverage the new exception
Tim Otten [Sat, 4 Mar 2023 03:31:04 +0000 (19:31 -0800)]
Merge pull request #25733 from totten/5.60-upg-ml
Fix for 5.59 upgrade on multilingual
Tim Otten [Sat, 4 Mar 2023 00:44:20 +0000 (16:44 -0800)]
Merge pull request #25730 from eileenmcnaughton/std
Fix typing, comments in new StandardFilters class