civicrm-core.git
9 years agoCoding standards cleanup sprint.
Chris Burgess [Tue, 20 Jan 2015 00:42:53 +0000 (13:42 +1300)]
Coding standards cleanup sprint.

See https://pad.riseup.net/p/QOOHQpetSXXo

This is batch 12.

9 years agoMerge pull request #4939 from colemanw/CRM-15789
colemanw [Wed, 14 Jan 2015 22:13:26 +0000 (17:13 -0500)]
Merge pull request #4939 from colemanw/CRM-15789

CRM-15789 - Fix dashboard close icon

9 years agoMerge pull request #4936 from monishdeb/INFRA-32
Kurund Jalmi [Wed, 14 Jan 2015 18:24:27 +0000 (23:54 +0530)]
Merge pull request #4936 from monishdeb/INFRA-32

INFRA-132 - Batch #7

9 years agoINFRA-132 - Batch #7
monishdeb [Sun, 1 Feb 2015 15:25:14 +0000 (20:55 +0530)]
INFRA-132 - Batch #7

9 years agoCRM-15789 - Fix dashboard close icon
Coleman Watts [Wed, 14 Jan 2015 17:06:32 +0000 (12:06 -0500)]
CRM-15789 - Fix dashboard close icon

----------------------------------------
* CRM-15789: Add icons to submit buttons
  https://issues.civicrm.org/jira/browse/CRM-15789

9 years agoMerge pull request #4920 from pratikshad/Fixed-webtests
Kurund Jalmi [Wed, 14 Jan 2015 16:11:21 +0000 (21:41 +0530)]
Merge pull request #4920 from pratikshad/Fixed-webtests

Fixed webtest of Contibution

9 years agoMerge pull request #4932 from totten/master-batch0-g
Kurund Jalmi [Wed, 14 Jan 2015 16:10:47 +0000 (21:40 +0530)]
Merge pull request #4932 from totten/master-batch0-g

INFRA-132 - Batch 0 (set g)

9 years agoMerge pull request #4934 from kurund/cleanup
Kurund Jalmi [Wed, 14 Jan 2015 16:10:22 +0000 (21:40 +0530)]
Merge pull request #4934 from kurund/cleanup

code cleanup

9 years agocode cleanup
kurund [Wed, 14 Jan 2015 13:45:55 +0000 (19:15 +0530)]
code cleanup

9 years agoUpdate version to 4.6.alpha3
CiviCRM [Wed, 14 Jan 2015 13:30:28 +0000 (05:30 -0800)]
Update version to 4.6.alpha3

9 years agoMerge pull request #4933 from civicrm/typo-corrections
Yashodha Chaku [Wed, 14 Jan 2015 08:39:36 +0000 (14:09 +0530)]
Merge pull request #4933 from civicrm/typo-corrections

typo fixes

9 years agotypo fixes
yashodha [Wed, 14 Jan 2015 08:36:59 +0000 (14:06 +0530)]
typo fixes

9 years agoINFRA-132 - Batch 0 (set g)
Tim Otten [Wed, 14 Jan 2015 04:53:48 +0000 (20:53 -0800)]
INFRA-132 - Batch 0 (set g)

9 years agoMerge pull request #4931 from davecivicrm/INFRA-132
Tim Otten [Wed, 14 Jan 2015 03:21:30 +0000 (19:21 -0800)]
Merge pull request #4931 from davecivicrm/INFRA-132

INFRA-132 - Batch #6

9 years agoMerge branch '4.5' into master
Coleman Watts [Wed, 14 Jan 2015 02:51:08 +0000 (21:51 -0500)]
Merge branch '4.5' into master

Conflicts:
CRM/Core/Payment/BaseIPN.php
tests/phpunit/WebTest/Campaign/CampaignDescriptionTest.php
tests/phpunit/WebTest/Event/AddPricesetTest.php
tests/phpunit/WebTest/Member/OfflineMembershipRenewTest.php

9 years agoMerge pull request #4930 from colemanw/CRM-15817
colemanw [Wed, 14 Jan 2015 02:28:27 +0000 (21:28 -0500)]
Merge pull request #4930 from colemanw/CRM-15817

CRM-15817 - Fix merge error

9 years agoINFRA-132 - Batch #6
Dave Greenberg [Wed, 14 Jan 2015 02:11:34 +0000 (18:11 -0800)]
INFRA-132 - Batch #6

9 years agoCRM-15817 - Fix merge error
Coleman Watts [Wed, 14 Jan 2015 01:25:45 +0000 (20:25 -0500)]
CRM-15817 - Fix merge error

9 years agoMerge pull request #4928 from totten/master-batch0
Tim Otten [Wed, 14 Jan 2015 01:23:43 +0000 (17:23 -0800)]
Merge pull request #4928 from totten/master-batch0

INFRA-132 - Batch 0

9 years agoMerge pull request #4927 from totten/master-setupsh-data
Tim Otten [Wed, 14 Jan 2015 00:28:17 +0000 (16:28 -0800)]
Merge pull request #4927 from totten/master-setupsh-data

bin/setup.sh - Distinguish the plain (civicrm_data.mysql) and example (civicrm_generated.mysql) options

9 years agoINFRA-132 - Batch 0
Tim Otten [Wed, 14 Jan 2015 00:26:35 +0000 (16:26 -0800)]
INFRA-132 - Batch 0

9 years agobin/setup.sh - Distinguish the plain (civicrm_data.mysql) and example (civicrm_genera...
Tim Otten [Tue, 13 Jan 2015 23:23:47 +0000 (15:23 -0800)]
bin/setup.sh - Distinguish the plain (civicrm_data.mysql) and example (civicrm_generated.mysql) options

9 years agoMerge pull request #4926 from colemanw/INFRA-132
colemanw [Tue, 13 Jan 2015 21:24:14 +0000 (16:24 -0500)]
Merge pull request #4926 from colemanw/INFRA-132

INFRA-132 - Batch #1

9 years agoINFRA-132 - Batch #1
Coleman Watts [Tue, 13 Jan 2015 19:12:40 +0000 (14:12 -0500)]
INFRA-132 - Batch #1

9 years agoMerge pull request #4919 from rohankatkar/webtests-4.5
Monish Deb [Tue, 13 Jan 2015 18:45:24 +0000 (00:15 +0530)]
Merge pull request #4919 from rohankatkar/webtests-4.5

Webtests fix-4.5

9 years agoMerge pull request #4924 from colemanw/CRM-15742
colemanw [Tue, 13 Jan 2015 18:17:02 +0000 (13:17 -0500)]
Merge pull request #4924 from colemanw/CRM-15742

CRM-15742 - Prevent dialog from returning to an invalid state

9 years agoParticipant view button cleanup
Coleman Watts [Tue, 13 Jan 2015 18:15:55 +0000 (13:15 -0500)]
Participant view button cleanup

9 years agoCRM-15742 - Prevent dialog from returning to an invalid state
Coleman Watts [Tue, 13 Jan 2015 18:01:42 +0000 (13:01 -0500)]
CRM-15742 - Prevent dialog from returning to an invalid state

9 years agoMerge pull request #4923 from colemanw/invoice_id
colemanw [Tue, 13 Jan 2015 17:49:51 +0000 (12:49 -0500)]
Merge pull request #4923 from colemanw/invoice_id

Add invoice_id as default param to api.contribution.transact

9 years agoMerge pull request #4922 from sunilpawar/CRM-15809
colemanw [Tue, 13 Jan 2015 17:46:39 +0000 (12:46 -0500)]
Merge pull request #4922 from sunilpawar/CRM-15809

CRM-15809 fixed location type check

9 years agoAdd invoice_id as default param to api.contribution.transact
Coleman Watts [Tue, 13 Jan 2015 17:31:53 +0000 (12:31 -0500)]
Add invoice_id as default param to api.contribution.transact

https://www.drupal.org/node/2402251

9 years agoCRM-15809 fixed location type check
sunil [Tue, 13 Jan 2015 16:42:17 +0000 (22:12 +0530)]
CRM-15809 fixed location type check

9 years agoFixed webtest of Contibution
pratikshad [Tue, 13 Jan 2015 14:01:05 +0000 (19:31 +0530)]
Fixed webtest of Contibution

9 years agoWebtests fix-4.5
Web Access [Tue, 13 Jan 2015 11:14:49 +0000 (16:44 +0530)]
Webtests fix-4.5

9 years agoMerge pull request #4917 from eileenmcnaughton/minor-tidies
Tim Otten [Tue, 13 Jan 2015 03:44:30 +0000 (19:44 -0800)]
Merge pull request #4917 from eileenmcnaughton/minor-tidies

Minor tidies

9 years agoMerge pull request #4916 from totten/master-casetypetest-cleanup
Tim Otten [Tue, 13 Jan 2015 02:23:14 +0000 (18:23 -0800)]
Merge pull request #4916 from totten/master-casetypetest-cleanup

INFRA-132 - Fix the longest stretches of contiguous spacing errors

9 years agoMerge pull request #4918 from colemanw/INFRA-132
colemanw [Tue, 13 Jan 2015 02:18:30 +0000 (21:18 -0500)]
Merge pull request #4918 from colemanw/INFRA-132

INFRA-132 - Fix docblocks

9 years agoINFRA-132 - Cleanup stray comments
Coleman Watts [Tue, 13 Jan 2015 02:13:48 +0000 (21:13 -0500)]
INFRA-132 - Cleanup stray comments

9 years agofix a few more comments
Eileen McNaughton [Tue, 13 Jan 2015 01:33:40 +0000 (14:33 +1300)]
fix a few more comments

9 years agoadd a few more arguments
Eileen McNaughton [Tue, 13 Jan 2015 01:30:42 +0000 (14:30 +1300)]
add a few more arguments

9 years agoa few mre comment block fixes
Eileen McNaughton [Tue, 13 Jan 2015 01:28:30 +0000 (14:28 +1300)]
a few mre comment block fixes

9 years agoremove some unused variables
Eileen McNaughton [Tue, 13 Jan 2015 01:21:42 +0000 (14:21 +1300)]
remove some unused variables

9 years agoTidy file to 'clean margin' standard
Eileen McNaughton [Tue, 13 Jan 2015 01:15:11 +0000 (14:15 +1300)]
Tidy file to 'clean margin' standard

9 years agofix syntax error I introduced last commit
Eileen McNaughton [Tue, 13 Jan 2015 01:02:34 +0000 (14:02 +1300)]
fix syntax error I introduced last commit

9 years agoa few more comment fixes
Eileen McNaughton [Tue, 13 Jan 2015 00:58:14 +0000 (13:58 +1300)]
a few more comment fixes

9 years agominor variable & doc fixes
Eileen McNaughton [Tue, 13 Jan 2015 00:52:23 +0000 (13:52 +1300)]
minor variable & doc fixes

9 years agoremove unused parameter
Eileen McNaughton [Tue, 13 Jan 2015 00:44:42 +0000 (13:44 +1300)]
remove unused parameter

9 years agominor comment corrections
Eileen McNaughton [Tue, 13 Jan 2015 00:44:19 +0000 (13:44 +1300)]
minor comment corrections

9 years agoINFRA-132 - Cleanup generated dao docblocks
Coleman Watts [Tue, 13 Jan 2015 00:29:15 +0000 (19:29 -0500)]
INFRA-132 - Cleanup generated dao docblocks

9 years agoINFRA-132 - CRM_Utils_JSTest - Spacing errors
Tim Otten [Tue, 13 Jan 2015 00:30:59 +0000 (16:30 -0800)]
INFRA-132 - CRM_Utils_JSTest - Spacing errors

9 years agoINFRA-132 - CRM_Utils_HtmlToTextTest - Spacing errors
Tim Otten [Tue, 13 Jan 2015 00:22:31 +0000 (16:22 -0800)]
INFRA-132 - CRM_Utils_HtmlToTextTest - Spacing errors

9 years agoINFRA-132 - Civi\Core\Container - Spacing errors
Tim Otten [Mon, 12 Jan 2015 23:48:32 +0000 (15:48 -0800)]
INFRA-132 - Civi\Core\Container - Spacing errors

9 years agoINFRA-132 - CaseTypeTest - Spacing errors
Tim Otten [Mon, 12 Jan 2015 23:48:15 +0000 (15:48 -0800)]
INFRA-132 - CaseTypeTest - Spacing errors

9 years agoremove piece of code that does nothing
Eileen McNaughton [Tue, 13 Jan 2015 00:31:47 +0000 (13:31 +1300)]
remove piece of code that does nothing

9 years agoremove unused var
Eileen McNaughton [Tue, 13 Jan 2015 00:29:01 +0000 (13:29 +1300)]
remove unused var

9 years agoremove unused var
Eileen McNaughton [Tue, 13 Jan 2015 00:28:23 +0000 (13:28 +1300)]
remove unused var

9 years agoremove unusable circular function
Eileen McNaughton [Tue, 13 Jan 2015 00:28:00 +0000 (13:28 +1300)]
remove unusable circular function

9 years agotidy up some unused params
Eileen McNaughton [Tue, 13 Jan 2015 00:27:34 +0000 (13:27 +1300)]
tidy up some unused params

9 years agoMerge pull request #4915 from eileenmcnaughton/minor-tidies
Eileen McNaughton [Tue, 13 Jan 2015 00:19:31 +0000 (13:19 +1300)]
Merge pull request #4915 from eileenmcnaughton/minor-tidies

Minor tidies - phpdoc

9 years agocleanup old tools for sanities sake
Eileen McNaughton [Tue, 13 Jan 2015 00:18:35 +0000 (13:18 +1300)]
cleanup old tools for sanities sake

9 years agofix comment blocks
Eileen McNaughton [Tue, 13 Jan 2015 00:00:25 +0000 (13:00 +1300)]
fix comment blocks

9 years agoremove some @access from phpdoc
Eileen McNaughton [Mon, 12 Jan 2015 23:26:04 +0000 (12:26 +1300)]
remove some @access from phpdoc

9 years agoMerge pull request #4913 from colemanw/INFRA-132
colemanw [Mon, 12 Jan 2015 23:02:17 +0000 (18:02 -0500)]
Merge pull request #4913 from colemanw/INFRA-132

INFRA-132 - Remove @static annotation

9 years agoMerge pull request #4914 from eileenmcnaughton/minor-tidies
Eileen McNaughton [Mon, 12 Jan 2015 23:00:59 +0000 (12:00 +1300)]
Merge pull request #4914 from eileenmcnaughton/minor-tidies

Minor tidies

9 years agoINFRA-132 - Remove @static annotation
Coleman Watts [Mon, 12 Jan 2015 22:48:58 +0000 (17:48 -0500)]
INFRA-132 - Remove @static annotation

9 years agophpdoc - re-fix country
Eileen McNaughton [Mon, 12 Jan 2015 22:53:40 +0000 (11:53 +1300)]
phpdoc - re-fix country

9 years agophpdoc params is always an array in api
Eileen McNaughton [Mon, 12 Jan 2015 22:52:44 +0000 (11:52 +1300)]
phpdoc params is always an array in api

9 years agofix re-use of variable
Eileen McNaughton [Mon, 12 Jan 2015 22:49:46 +0000 (11:49 +1300)]
fix re-use of variable

9 years agoa few random comment fixes
Eileen McNaughton [Mon, 12 Jan 2015 22:49:22 +0000 (11:49 +1300)]
a few random comment fixes

9 years agoINFRA-132 - Minor spacing fixes
Coleman Watts [Mon, 12 Jan 2015 22:47:27 +0000 (17:47 -0500)]
INFRA-132 - Minor spacing fixes

9 years agoMerge pull request #4912 from eileenmcnaughton/minor-tidies
colemanw [Mon, 12 Jan 2015 22:39:19 +0000 (17:39 -0500)]
Merge pull request #4912 from eileenmcnaughton/minor-tidies

phpdoc fixes

9 years agophpdoc fixes
Eileen McNaughton [Mon, 12 Jan 2015 22:34:57 +0000 (11:34 +1300)]
phpdoc fixes

9 years agoMerge pull request #4906 from eileenmcnaughton/minor-tidies
Tim Otten [Mon, 12 Jan 2015 21:21:08 +0000 (13:21 -0800)]
Merge pull request #4906 from eileenmcnaughton/minor-tidies

Minor tidies

9 years agoMerge pull request #4910 from colemanw/INFRA-132
colemanw [Mon, 12 Jan 2015 17:39:42 +0000 (12:39 -0500)]
Merge pull request #4910 from colemanw/INFRA-132

INFRA-132 - Docblock formatting fixes

9 years agoMerge pull request #4911 from colemanw/CRM-15802
colemanw [Mon, 12 Jan 2015 16:46:01 +0000 (11:46 -0500)]
Merge pull request #4911 from colemanw/CRM-15802

CRM-15802 - Bump up limit on soft credits

9 years agoCRM-15802 - Bump up limit on soft credits
Coleman Watts [Mon, 12 Jan 2015 16:45:41 +0000 (11:45 -0500)]
CRM-15802 - Bump up limit on soft credits

9 years agoINFRA-132 - Docblock formatting fixes
Coleman Watts [Mon, 12 Jan 2015 15:54:21 +0000 (10:54 -0500)]
INFRA-132 - Docblock formatting fixes

9 years agoINFRA-132 - Remove unused fn params
Coleman Watts [Mon, 12 Jan 2015 15:42:02 +0000 (10:42 -0500)]
INFRA-132 - Remove unused fn params

9 years agoINFRA-132 - Docblock fixes
Coleman Watts [Mon, 12 Jan 2015 15:39:21 +0000 (10:39 -0500)]
INFRA-132 - Docblock fixes

9 years agoINFRA-132 - Fix @static docblock tag
Coleman Watts [Mon, 12 Jan 2015 15:18:17 +0000 (10:18 -0500)]
INFRA-132 - Fix @static docblock tag

9 years agoMerge pull request #4907 from monishdeb/CRM-15695
Kurund Jalmi [Mon, 12 Jan 2015 15:08:51 +0000 (20:38 +0530)]
Merge pull request #4907 from monishdeb/CRM-15695

CRM-15695 fix - Showing Custom data options in report criteria problem

9 years agoCRM-15695 fix - Showing Custom data options in report criteria problem
monishdeb [Fri, 30 Jan 2015 12:36:29 +0000 (18:06 +0530)]
CRM-15695 fix - Showing Custom data options in report criteria problem

https://issues.civicrm.org/jira/browse/CRM-15695

9 years agoMerge pull request #4909 from pratikshad/broken-webtest
Kurund Jalmi [Mon, 12 Jan 2015 15:01:00 +0000 (20:31 +0530)]
Merge pull request #4909 from pratikshad/broken-webtest

Fixed Broken webtest of Event and Contact

9 years agoMerge pull request #4908 from rohankatkar/webtest4.6
Yashodha Chaku [Mon, 12 Jan 2015 14:17:57 +0000 (19:47 +0530)]
Merge pull request #4908 from rohankatkar/webtest4.6

Webtest Fixes

9 years agoFixed Broken webtest of Event and Contact
pratikshad [Mon, 12 Jan 2015 14:05:58 +0000 (19:35 +0530)]
Fixed Broken webtest of Event and Contact

9 years agoWebtest Fixes
Web Access [Mon, 12 Jan 2015 13:07:40 +0000 (18:37 +0530)]
Webtest Fixes

9 years agoMerge remote-tracking branch 'upstream/4.5' into 4.5-master-2015-01-12-16-09-32
kurund [Mon, 12 Jan 2015 10:51:26 +0000 (16:21 +0530)]
Merge remote-tracking branch 'upstream/4.5' into 4.5-master-2015-01-12-16-09-32

Conflicts:
CRM/Contact/Page/AJAX.php
CRM/Contribute/Form/ContributionPage/Settings.php

9 years agoa few random comment fixes in the test suite
Eileen McNaughton [Mon, 12 Jan 2015 07:44:34 +0000 (20:44 +1300)]
a few random comment fixes in the test suite

9 years agouse better spelling
Eileen McNaughton [Mon, 12 Jan 2015 07:23:59 +0000 (20:23 +1300)]
use better spelling

9 years agotidy-up - remove duplicate array keys
Eileen McNaughton [Mon, 12 Jan 2015 07:18:42 +0000 (20:18 +1300)]
tidy-up - remove duplicate array keys

9 years agoMerge pull request #4905 from monishdeb/CRM-15619-fix
Monish Deb [Mon, 12 Jan 2015 06:54:25 +0000 (12:24 +0530)]
Merge pull request #4905 from monishdeb/CRM-15619-fix

CRM-15619, whitespace removal typo fix

9 years agoCRM-15728, whitespace removal typo fix
monishdeb [Fri, 30 Jan 2015 06:49:48 +0000 (12:19 +0530)]
CRM-15728, whitespace removal typo fix

----------------------------------------
* CRM-15728: Improve Scheduled Reminders for membership renewals
  https://issues.civicrm.org/jira/browse/CRM-15728

9 years agoMerge pull request #4904 from eileenmcnaughton/mailing-contact
Kurund Jalmi [Mon, 12 Jan 2015 06:37:47 +0000 (12:07 +0530)]
Merge pull request #4904 from eileenmcnaughton/mailing-contact

api cleanup remove unused params

9 years agoMerge pull request #4898 from monishdeb/CRM-15619-fix
Kurund Jalmi [Mon, 12 Jan 2015 06:30:51 +0000 (12:00 +0530)]
Merge pull request #4898 from monishdeb/CRM-15619-fix

Crm 15619 fix

9 years agotest failure fix2
monishdeb [Thu, 29 Jan 2015 11:55:36 +0000 (17:25 +0530)]
test failure fix2

9 years agotest failure fix
monishdeb [Thu, 29 Jan 2015 10:38:26 +0000 (16:08 +0530)]
test failure fix

9 years agooptimization and QA changes
monishdeb [Wed, 28 Jan 2015 14:45:30 +0000 (20:15 +0530)]
optimization and QA changes

9 years agotypo mistake
monishdeb [Wed, 7 Jan 2015 02:38:01 +0000 (08:08 +0530)]
typo mistake

9 years agotest break fixes
monishdeb [Tue, 6 Jan 2015 17:43:48 +0000 (23:13 +0530)]
test break fixes

9 years agoApi test failures fix round4
monishdeb [Tue, 6 Jan 2015 14:55:32 +0000 (20:25 +0530)]
Api test failures fix round4