civicrm-core.git
3 years agoTemplate notice cleanup - make sane
Eileen McNaughton [Fri, 26 Nov 2021 01:40:03 +0000 (14:40 +1300)]
Template notice cleanup - make sane

The CRM/Custom/Form/CustomData.tpl is called with formEdit set from
1 place - CRM/Contact/Form/Edit/CustomData.tpl - when this is the
case only 1 line of code is shared with the code path if
formEdit is not true/ passed in. This is silly & can be avoided

3 years agoMerge pull request #22140 from eileenmcnaughton/cust_case
colemanw [Sat, 27 Nov 2021 20:33:42 +0000 (15:33 -0500)]
Merge pull request #22140 from eileenmcnaughton/cust_case

Assign cgCount in Case custom data form

3 years agoMerge pull request #22125 from colemanw/searchKitEditing
demeritcowboy [Sat, 27 Nov 2021 13:44:02 +0000 (08:44 -0500)]
Merge pull request #22125 from colemanw/searchKitEditing

SearchKit - Improve UX for refresh after editing

3 years agoMerge pull request #21919 from braders/deprecated-jquery-xhr-usage
colemanw [Sat, 27 Nov 2021 06:39:18 +0000 (01:39 -0500)]
Merge pull request #21919 from braders/deprecated-jquery-xhr-usage

[REF] Remove usage of deprecated jqXHR.error in jQuery code

3 years agoMerge pull request #22014 from colemanw/apiExport
colemanw [Sat, 27 Nov 2021 06:34:13 +0000 (01:34 -0500)]
Merge pull request #22014 from colemanw/apiExport

APIv4 - Add export action for managed entities

3 years agoMerge pull request #22139 from eileenmcnaughton/cust_opt
colemanw [Sat, 27 Nov 2021 06:21:14 +0000 (01:21 -0500)]
Merge pull request #22139 from eileenmcnaughton/cust_opt

Ensure custom fields properties are assigned to the template

3 years agoMerge pull request #22145 from civicrm/5.44
Seamus Lee [Sat, 27 Nov 2021 05:11:01 +0000 (16:11 +1100)]
Merge pull request #22145 from civicrm/5.44

5.44

3 years agoMerge pull request #22141 from eileenmcnaughton/contexty
colemanw [Sat, 27 Nov 2021 02:44:19 +0000 (21:44 -0500)]
Merge pull request #22141 from eileenmcnaughton/contexty

Ensure context is always assigned

3 years agoAPIv4 - Add export action to managed entities
Coleman Watts [Tue, 9 Nov 2021 13:57:28 +0000 (08:57 -0500)]
APIv4 - Add export action to managed entities

This action generates an exportable array suitable for use in a .mgd.php file.

3 years agoMerge pull request #22144 from alifrumin/rn5.44
Seamus Lee [Fri, 26 Nov 2021 22:04:50 +0000 (09:04 +1100)]
Merge pull request #22144 from alifrumin/rn5.44

NFC first stab at 5.44 release notes

3 years agoNFC release notes 5.44
Alice Frumin [Mon, 22 Nov 2021 18:17:31 +0000 (13:17 -0500)]
NFC release notes 5.44

3 years agoEnsure context is always assigned
Eileen McNaughton [Fri, 26 Nov 2021 03:12:51 +0000 (16:12 +1300)]
Ensure context is always assigned

3 years agoMerge pull request #22127 from colemanw/afformUiTweaks
Seamus Lee [Fri, 26 Nov 2021 02:59:35 +0000 (13:59 +1100)]
Merge pull request #22127 from colemanw/afformUiTweaks

FormBuilder - Hide configuration options that do not apply to certain form types

3 years agoAssign cgCount in Case custom data form
Eileen McNaughton [Fri, 26 Nov 2021 02:51:21 +0000 (15:51 +1300)]
Assign cgCount in Case custom data form

3 years agoEnsure custom fields properties are assigned to the template
Eileen McNaughton [Fri, 26 Nov 2021 02:46:38 +0000 (15:46 +1300)]
Ensure custom fields properties are assigned to the template

3 years agoMerge pull request #22114 from colemanw/searchKitRevertButton
Seamus Lee [Fri, 26 Nov 2021 00:24:35 +0000 (11:24 +1100)]
Merge pull request #22114 from colemanw/searchKitRevertButton

SearchKit - Improve search listing UI

3 years agoMerge pull request #22134 from eileenmcnaughton/url
Seamus Lee [Thu, 25 Nov 2021 23:32:40 +0000 (10:32 +1100)]
Merge pull request #22134 from eileenmcnaughton/url

Ensure CMSPrint variables are assigned to the template

3 years agoMerge pull request #22135 from eileenmcnaughton/pay_test
Seamus Lee [Thu, 25 Nov 2021 23:32:22 +0000 (10:32 +1100)]
Merge pull request #22135 from eileenmcnaughton/pay_test

Ensure tab headers are assigned, fix widget form test

3 years agoMerge pull request #22136 from mlutfy/fixEventPrepositionTs
Seamus Lee [Thu, 25 Nov 2021 23:31:26 +0000 (10:31 +1100)]
Merge pull request #22136 from mlutfy/fixEventPrepositionTs

CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition

3 years agoCRM/Event/BAO/Event: Fix ts usage on selfservice_preposition
Mathieu Lutfy [Thu, 25 Nov 2021 21:13:44 +0000 (16:13 -0500)]
CRM/Event/BAO/Event: Fix ts usage on selfservice_preposition

3 years agoEnsure tab headers are assigned, fix widget form test
Eileen McNaughton [Thu, 25 Nov 2021 08:01:47 +0000 (21:01 +1300)]
Ensure tab headers are assigned, fix widget form test

This could regress notices elsewhere but I given the difficulty of getting a combo
of fixes that pass tests I think we should only worry if there are actual test fails
since most people won't see smarty notices anyway

3 years agoEnsure CMSPrint variables are assigned to the template
Eileen McNaughton [Thu, 25 Nov 2021 07:41:45 +0000 (20:41 +1300)]
Ensure CMSPrint variables are assigned to the template

3 years agoMerge pull request #22128 from eileenmcnaughton/cus
Seamus Lee [Wed, 24 Nov 2021 22:19:40 +0000 (09:19 +1100)]
Merge pull request #22128 from eileenmcnaughton/cus

Ensure buildForm is called to assign values

3 years agoMerge pull request #22131 from civicrm/5.44
Seamus Lee [Wed, 24 Nov 2021 21:10:27 +0000 (08:10 +1100)]
Merge pull request #22131 from civicrm/5.44

5.44

3 years agoMerge pull request #22130 from colemanw/fixSearchKitHaving
colemanw [Wed, 24 Nov 2021 19:30:00 +0000 (14:30 -0500)]
Merge pull request #22130 from colemanw/fixSearchKitHaving

SearchKit - Fix selecting HAVING operator

3 years agoMerge pull request #22129 from kurund/patch-4
colemanw [Wed, 24 Nov 2021 17:47:27 +0000 (12:47 -0500)]
Merge pull request #22129 from kurund/patch-4

Update Fields.tpl

3 years agoSearchKit - Fix selecting HAVING operator
Coleman Watts [Wed, 24 Nov 2021 16:59:22 +0000 (11:59 -0500)]
SearchKit - Fix selecting HAVING operator

Fixes dev/core#2954 by gracefully handling field values when no field exists

3 years agoUpdate Fields.tpl
Kurund Jalmi [Wed, 24 Nov 2021 16:00:14 +0000 (16:00 +0000)]
Update Fields.tpl

3 years agoMerge pull request #22122 from agileware/CIVICRM-1894
Yashodha Chaku [Wed, 24 Nov 2021 15:56:21 +0000 (21:26 +0530)]
Merge pull request #22122 from agileware/CIVICRM-1894

CiviCRM Event, remove the superfluous "Are you sure you want to delete this Event?" confirmation for the Event delete action

3 years agoEnsure buildForm is called to assign values
Eileen McNaughton [Wed, 24 Nov 2021 06:31:04 +0000 (19:31 +1300)]
Ensure buildForm is called to assign values

3 years agoMerge pull request #22126 from colemanw/deleteAfformHtmlExt
Seamus Lee [Wed, 24 Nov 2021 06:00:09 +0000 (17:00 +1100)]
Merge pull request #22126 from colemanw/deleteAfformHtmlExt

Update Afform & search kit info

3 years agoMerge pull request #22007 from joapta/feature/add-missing-colombia-state
colemanw [Wed, 24 Nov 2021 05:06:27 +0000 (00:06 -0500)]
Merge pull request #22007 from joapta/feature/add-missing-colombia-state

Add Colombia missing state

3 years agoMerge pull request #22123 from eileenmcnaughton/act
colemanw [Wed, 24 Nov 2021 05:05:35 +0000 (00:05 -0500)]
Merge pull request #22123 from eileenmcnaughton/act

Test fix - use more 'real' rendering function

3 years agoMerge pull request #22116 from jensschuppe/virtualEntities/getEntityNameForTable
colemanw [Wed, 24 Nov 2021 05:02:22 +0000 (00:02 -0500)]
Merge pull request #22116 from jensschuppe/virtualEntities/getEntityNameForTable

Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results

3 years agoFormBuilder - Hide configuration options that do not apply to certain form types
Coleman Watts [Wed, 24 Nov 2021 03:39:10 +0000 (22:39 -0500)]
FormBuilder - Hide configuration options that do not apply to certain form types

3 years agoMerge pull request #21589 from agileware/CIVICRM-1804
Seamus Lee [Wed, 24 Nov 2021 03:35:00 +0000 (14:35 +1100)]
Merge pull request #21589 from agileware/CIVICRM-1804

Suppresses error logging on every page load when open_basedir restriction in effect: File(/CRM/Core/Smarty/plugins/) is not within the allowed path(s)

3 years agoUpdate afform & search kit info
Coleman Watts [Wed, 24 Nov 2021 03:20:38 +0000 (22:20 -0500)]
Update afform & search kit info

3 years agoAdd Colombia missing state
jptaszynska [Mon, 8 Nov 2021 10:14:02 +0000 (11:14 +0100)]
Add Colombia missing state

3 years agoMerge pull request #22087 from agileware/CIVICRM-1887
colemanw [Wed, 24 Nov 2021 02:36:27 +0000 (21:36 -0500)]
Merge pull request #22087 from agileware/CIVICRM-1887

SearchKit with Form Builder when viewed on the front-end displays a CiviCRM breadcrumb trail which can duplicate the existing website breadcrumb trail

3 years agoAllCoreTables - Fix getClassForTable in multilingual databases
Coleman Watts [Wed, 24 Nov 2021 02:25:58 +0000 (21:25 -0500)]
AllCoreTables - Fix getClassForTable in multilingual databases

3 years agoSearchKit - Improve UX for refresh after editing
Coleman Watts [Wed, 24 Nov 2021 01:57:24 +0000 (20:57 -0500)]
SearchKit - Improve UX for refresh after editing

After bulk-editing or in-place-editing, ensures the pager count is correctly updated.
Does the update and refresh for in-place-edit in a single ajax request, without the loading placeholders.

3 years agoTest fix - use more 'real' rendering function
Eileen McNaughton [Wed, 24 Nov 2021 01:28:53 +0000 (14:28 +1300)]
Test fix - use more 'real' rendering function

3 years agoCIVICRM-1894 CiviCRM Event, remove the superfluous "Are you sure you want to delete...
Justin Freeman [Wed, 24 Nov 2021 01:20:25 +0000 (12:20 +1100)]
CIVICRM-1894 CiviCRM Event, remove the superfluous "Are you sure you want to delete this Event?" confirmation for the Event delete action

3 years agoMerge pull request #22119 from eileenmcnaughton/frontpage
Eileen McNaughton [Wed, 24 Nov 2021 01:10:44 +0000 (14:10 +1300)]
Merge pull request #22119 from eileenmcnaughton/frontpage

Bypass any default escaping for blog, getting started

3 years agoMerge pull request #22120 from eileenmcnaughton/address
Eileen McNaughton [Wed, 24 Nov 2021 01:09:46 +0000 (14:09 +1300)]
Merge pull request #22120 from eileenmcnaughton/address

Do not use default escaping on address display

3 years agoCIVICRM-1804 Suppresses error logging on every page load when open_basedir restrictio...
Justin Freeman [Fri, 24 Sep 2021 04:12:36 +0000 (14:12 +1000)]
CIVICRM-1804 Suppresses error logging on every page load when open_basedir restriction in effect: File(/CRM/Core/Smarty/plugins/) is not within the allowed path(s)

3 years agoDo not use default escaping on address display
Eileen McNaughton [Tue, 23 Nov 2021 22:53:21 +0000 (11:53 +1300)]
Do not use default escaping on address display

This has vcard html in it and so breaks if default escaping is enabled

3 years agoBypass any default escaping for blog, getting started
Eileen McNaughton [Tue, 23 Nov 2021 22:34:10 +0000 (11:34 +1300)]
Bypass any default escaping for blog, getting started

This specifies that default escaping should not apply to the blog, getting started.

I added purify to the data coming from the blog - this is our blog so should be
safe but it is techically 3rd part data

3 years agoMerge pull request #22079 from eileenmcnaughton/options
demeritcowboy [Tue, 23 Nov 2021 22:32:33 +0000 (17:32 -0500)]
Merge pull request #22079 from eileenmcnaughton/options

Remove issets from Options.tpl

3 years agoMerge pull request #22070 from eileenmcnaughton/test_id
colemanw [Tue, 23 Nov 2021 20:56:01 +0000 (15:56 -0500)]
Merge pull request #22070 from eileenmcnaughton/test_id

Throw spaghetti

3 years agoMerge pull request #21944 from masetto/unit_plural
demeritcowboy [Tue, 23 Nov 2021 15:02:16 +0000 (10:02 -0500)]
Merge pull request #21944 from masetto/unit_plural

fix unit plural in contribution page

3 years agoUse getEntityNameForTable() instead of getClassForTable(), as this might yield ambigu...
Jens Schuppe [Tue, 23 Nov 2021 12:12:16 +0000 (13:12 +0100)]
Use getEntityNameForTable() instead of getClassForTable(), as this might yield ambiguous results

3 years agofix unit plural in contribution page
Samuele Masetto [Sat, 30 Oct 2021 17:14:53 +0000 (19:14 +0200)]
fix unit plural in contribution page

style fixes for compiling check

fix a typo

fix `recur_frequency_unit` hidden field value when there is only one unit option

3 years agoMerge pull request #22112 from Detsieber/master
Eileen McNaughton [Mon, 22 Nov 2021 19:59:37 +0000 (08:59 +1300)]
Merge pull request #22112 from Detsieber/master

Update PayPalImpl.php - action on style test failure

3 years agoRemove a bunch of isset from options.tpl
Eileen McNaughton [Mon, 22 Nov 2021 06:08:33 +0000 (19:08 +1300)]
Remove a bunch of isset from options.tpl

3 years agoMerge pull request #22111 from eileenmcnaughton/opt
demeritcowboy [Mon, 22 Nov 2021 19:14:20 +0000 (14:14 -0500)]
Merge pull request #22111 from eileenmcnaughton/opt

Remove a bunch of isset from options.tpl

3 years agoSearchKit - Include default clauses in routbinding params
Coleman Watts [Mon, 22 Nov 2021 19:12:01 +0000 (14:12 -0500)]
SearchKit - Include default clauses in routbinding params

3 years agoMerge pull request #22110 from agileware/CIVICRM-1889
demeritcowboy [Mon, 22 Nov 2021 19:05:56 +0000 (14:05 -0500)]
Merge pull request #22110 from agileware/CIVICRM-1889

CiviCRM Message Template, HTML Format and Text Format fields are listed in a different order on the Default Message Template

3 years agoMerge pull request #22113 from mattwire/eventtitle
demeritcowboy [Mon, 22 Nov 2021 18:53:37 +0000 (13:53 -0500)]
Merge pull request #22113 from mattwire/eventtitle

Remove broken dynamic title from event template

3 years agoRemove broken dynamic title from event template
Matthew Wire [Mon, 22 Nov 2021 12:14:12 +0000 (12:14 +0000)]
Remove broken dynamic title from event template

3 years agoUpdate PayPalImpl.php
Detlev Sieber [Mon, 22 Nov 2021 07:07:48 +0000 (08:07 +0100)]
Update PayPalImpl.php

3 years agoRemove a bunch of isset from options.tpl
Eileen McNaughton [Mon, 22 Nov 2021 06:08:33 +0000 (19:08 +1300)]
Remove a bunch of isset from options.tpl

3 years agoEnotice fix
Eileen McNaughton [Mon, 15 Nov 2021 01:50:33 +0000 (14:50 +1300)]
Enotice fix

3 years agoSearchKit - Improve custom/packaged tab UI to be more responsive
Coleman Watts [Sun, 21 Nov 2021 16:26:40 +0000 (11:26 -0500)]
SearchKit - Improve custom/packaged tab UI to be more responsive

Instead of using one searchDisplay with a hidden filter, which causes ajax reload when switching tabs,
this creates 2 search displays which are always present but shown/hidden by the tabs.

3 years agoSearchKit - Show local_modified_date for packaged searches
Coleman Watts [Sat, 20 Nov 2021 15:01:18 +0000 (10:01 -0500)]
SearchKit - Show local_modified_date for packaged searches

3 years agoMerge pull request #22109 from civicrm/5.44
colemanw [Mon, 22 Nov 2021 02:26:57 +0000 (21:26 -0500)]
Merge pull request #22109 from civicrm/5.44

5.44

3 years agoCIVICRM-1889 CiviCRM Message Template, HTML Format and Text Format fields are listed...
Justin Freeman [Mon, 22 Nov 2021 00:17:45 +0000 (11:17 +1100)]
CIVICRM-1889 CiviCRM Message Template, HTML Format and Text Format fields are listed in a different order and make it harder to directly compare and copy/paste changes from a Default Message Template to a Message Template

3 years agoMerge pull request #22090 from colemanw/apiGetEntityName
Seamus Lee [Mon, 22 Nov 2021 00:07:26 +0000 (11:07 +1100)]
Merge pull request #22090 from colemanw/apiGetEntityName

APIv4 - Fix checkAccess for CiviCase or other entities with nonstandard class names

3 years agoMerge pull request #22108 from colemanw/searchDisplayFix
Seamus Lee [Sun, 21 Nov 2021 23:00:23 +0000 (10:00 +1100)]
Merge pull request #22108 from colemanw/searchDisplayFix

SearchKit - Fix default displays in Afforms and multiple displays per page

3 years agoMerge pull request #22106 from braders/translatable-download-chart-text
Seamus Lee [Sun, 21 Nov 2021 22:58:55 +0000 (09:58 +1100)]
Merge pull request #22106 from braders/translatable-download-chart-text

Allow "Download chart" text to be translated.

3 years agoSearchKit - fix multiple displays on the same page
Coleman Watts [Sun, 21 Nov 2021 17:34:29 +0000 (12:34 -0500)]
SearchKit - fix multiple displays on the same page

3 years agoSearchKit - fix rendering default display embedded in an afform
Coleman Watts [Sun, 21 Nov 2021 17:33:06 +0000 (12:33 -0500)]
SearchKit - fix rendering default display embedded in an afform

3 years agoAllow "Download chart" text to be translated.
Bradley Taylor [Sun, 21 Nov 2021 12:16:10 +0000 (12:16 +0000)]
Allow "Download chart" text to be translated.

This affects the charts on the dashboard, and contribution dashboard.

3 years agoMerge pull request #1 from Detsieber/Detsieber-lab.civicrm.org/dev/core/-/issues...
Detlev Sieber [Sat, 20 Nov 2021 14:00:49 +0000 (15:00 +0100)]
Merge pull request #1 from Detsieber/Detsieber-lab.civicrm.org/dev/core/-/issues/1215

https://lab.civicrm.org/dev/core/-/issues/1215

3 years agoUpdate PayPalImpl.php
Detlev Sieber [Sat, 20 Nov 2021 13:52:45 +0000 (14:52 +0100)]
Update PayPalImpl.php

Repair support for PayPal Express by linking to PayPal Pro

3 years agoThrow spaghetti
Eileen McNaughton [Sat, 13 Nov 2021 03:11:30 +0000 (16:11 +1300)]
Throw spaghetti

3 years agoMerge pull request #22104 from civicrm/5.44
Seamus Lee [Sat, 20 Nov 2021 01:38:51 +0000 (12:38 +1100)]
Merge pull request #22104 from civicrm/5.44

5.44

3 years agoMerge pull request #22103 from agh1/5.44.0-releasenotes-initial
Seamus Lee [Fri, 19 Nov 2021 23:53:24 +0000 (10:53 +1100)]
Merge pull request #22103 from agh1/5.44.0-releasenotes-initial

5.44.0 release notes initial run

3 years agoMerge pull request #22102 from eileenmcnaughton/vis
Seamus Lee [Fri, 19 Nov 2021 23:53:15 +0000 (10:53 +1100)]
Merge pull request #22102 from eileenmcnaughton/vis

Remove obsolete showVisibility

3 years ago5.44.0 release notes: added boilerplate
Andie Hunt [Fri, 19 Nov 2021 22:26:49 +0000 (17:26 -0500)]
5.44.0 release notes: added boilerplate

3 years agoRemove obsolete showVisibility
Eileen McNaughton [Fri, 19 Nov 2021 21:45:28 +0000 (10:45 +1300)]
Remove obsolete showVisibility

Per https://github.com/civicrm/civicrm-core/pull/22079#issuecomment-974267801

3 years ago5.44.0 release notes: raw from script
Andie Hunt [Fri, 19 Nov 2021 21:27:59 +0000 (16:27 -0500)]
5.44.0 release notes: raw from script

3 years agoMerge pull request #22009 from colemanw/afformSubmissionTable
Seamus Lee [Fri, 19 Nov 2021 06:34:25 +0000 (17:34 +1100)]
Merge pull request #22009 from colemanw/afformSubmissionTable

Afform - Add table of submission results

3 years agoMerge pull request #21908 from eileenmcnaughton/statuses
Seamus Lee [Fri, 19 Nov 2021 06:33:32 +0000 (17:33 +1100)]
Merge pull request #21908 from eileenmcnaughton/statuses

[REF] Remove support for not-passed 'pledge' value

3 years agoMerge pull request #22035 from eileenmcnaughton/campaign
Seamus Lee [Fri, 19 Nov 2021 01:24:59 +0000 (12:24 +1100)]
Merge pull request #22035 from eileenmcnaughton/campaign

Escape-on-output: Cleanup addCampaignToSearch, remove isset

3 years agoMerge pull request #22099 from civicrm/5.44
Seamus Lee [Fri, 19 Nov 2021 00:26:27 +0000 (11:26 +1100)]
Merge pull request #22099 from civicrm/5.44

5.44

3 years agoMerge pull request #22084 from eileenmcnaughton/search
colemanw [Thu, 18 Nov 2021 22:21:16 +0000 (17:21 -0500)]
Merge pull request #22084 from eileenmcnaughton/search

Remove smarty isset in favour of always set

3 years agoMerge pull request #22092 from seamuslee001/ckeditor_upgrade_4_17
Seamus Lee [Thu, 18 Nov 2021 22:15:19 +0000 (09:15 +1100)]
Merge pull request #22092 from seamuslee001/ckeditor_upgrade_4_17

[REF] Upgrade CKEditor to 4.17

3 years agoMerge pull request #22094 from civicrm/5.44
Eileen McNaughton [Thu, 18 Nov 2021 21:28:51 +0000 (10:28 +1300)]
Merge pull request #22094 from civicrm/5.44

5.44

3 years agoMerge pull request #22098 from twomice/2959_fix_pdf_default_format
Eileen McNaughton [Thu, 18 Nov 2021 21:28:22 +0000 (10:28 +1300)]
Merge pull request #22098 from twomice/2959_fix_pdf_default_format

Fix dev/core#2959: some PDFs hard-code format to "a3 landscape", overriding default PDF format

3 years agoMerge pull request #22095 from colemanw/fixDomainOptionGroup
demeritcowboy [Thu, 18 Nov 2021 19:49:34 +0000 (14:49 -0500)]
Merge pull request #22095 from colemanw/fixDomainOptionGroup

OptionValue - Fix checking if domain is set

3 years agoMerge pull request #22097 from mlutfy/fixStrings2021
Eileen McNaughton [Thu, 18 Nov 2021 19:27:35 +0000 (08:27 +1300)]
Merge pull request #22097 from mlutfy/fixStrings2021

Fix two English strings

3 years agoFix dev/core#2959: some PDFs hard-code format to "a3 landscape", overriding default...
Allen Shaw [Thu, 18 Nov 2021 18:10:33 +0000 (12:10 -0600)]
Fix dev/core#2959: some PDFs hard-code format to "a3 landscape", overriding default PDF format

3 years agoFix two English strings
Mathieu Lutfy [Thu, 18 Nov 2021 16:26:28 +0000 (11:26 -0500)]
Fix two English strings

3 years agoOptionValue - Fix checking if domain is set
Coleman Watts [Thu, 18 Nov 2021 02:56:24 +0000 (21:56 -0500)]
OptionValue - Fix checking if domain is set

Fixes a bug introduced in #19970

3 years agoMerge pull request #22093 from totten/5.44-civix-test
Seamus Lee [Thu, 18 Nov 2021 02:43:05 +0000 (13:43 +1100)]
Merge pull request #22093 from totten/5.44-civix-test

EventChecker - Fix recent regression

3 years agoEventChecker - Fix recent regression
Tim Otten [Thu, 18 Nov 2021 00:20:55 +0000 (16:20 -0800)]
EventChecker - Fix recent regression

Overview
--------

v5.43 introduced `Civi/Test/EventChecker.php` as part of the execution of all unit-tests.

`civix` generates unit-tests from various templates. As part of the `civix` update-testing, it makes sundry tests with sundry phpunit.

Before
------

In 5.43.0, when running `civix`'s` `tests/make-example.sh`, it fails on one of the tests when using an older version of phpunit.

After
-----

When running `civix`'s` `tests/make-example.sh`, it passes with all tests.

Comment
-------

The type-hint is too strong -- the actual type-name depends on the version of phpunit. It is, of course, good
to have type-hints, and this preserves the softer `@param` hint.

3 years agoRemove smarty isset in favour of always set
Eileen McNaughton [Mon, 15 Nov 2021 20:33:56 +0000 (09:33 +1300)]
Remove smarty isset in favour of always set

3 years ago[REF] Upgrade CKEditor to 4.17.1
Seamus Lee [Wed, 17 Nov 2021 22:31:41 +0000 (09:31 +1100)]
[REF] Upgrade CKEditor to 4.17.1

3 years agoMerge pull request #22091 from demeritcowboy/translate-js
Eileen McNaughton [Wed, 17 Nov 2021 22:17:26 +0000 (11:17 +1300)]
Merge pull request #22091 from demeritcowboy/translate-js

Contribution amounts configuration page is borked when translation contains apostrophe