civicrm-core.git
2 years agoMerge pull request #23229 from pradpnayak/limitcontacts
Eileen McNaughton [Sat, 16 Apr 2022 03:30:53 +0000 (15:30 +1200)]
Merge pull request #23229 from pradpnayak/limitcontacts

Limit issue fix

2 years agoMerge pull request #23220 from totten/master-defn
Eileen McNaughton [Fri, 15 Apr 2022 22:54:31 +0000 (10:54 +1200)]
Merge pull request #23220 from totten/master-defn

(REF) CryptoRegistry - Fix type declaration

2 years agoMerge pull request #23184 from totten/master-bd-drush
Seamus Lee [Fri, 15 Apr 2022 22:45:54 +0000 (08:45 +1000)]
Merge pull request #23184 from totten/master-bd-drush

(NFC) Skip CliRunnerTest on php80+drush+Backdrop

2 years agoLimit issue fix
Pradeep Nayak [Fri, 15 Apr 2022 22:45:00 +0000 (23:45 +0100)]
Limit issue fix

2 years agoMerge pull request #23080 from eileenmcnaughton/isset
Seamus Lee [Fri, 15 Apr 2022 22:43:59 +0000 (08:43 +1000)]
Merge pull request #23080 from eileenmcnaughton/isset

Always assign pay_later_receipt

2 years agoMerge pull request #23199 from eileenmcnaughton/imp
Tim Otten [Fri, 15 Apr 2022 22:41:09 +0000 (15:41 -0700)]
Merge pull request #23199 from eileenmcnaughton/imp

dev/core#1307 Add civicrm_user_job table

2 years agoMerge pull request #22664 from braders/membershipview-default-values
Eileen McNaughton [Fri, 15 Apr 2022 22:04:17 +0000 (10:04 +1200)]
Merge pull request #22664 from braders/membershipview-default-values

Set default values on MembershipView to stop PHP notices

2 years agoMerge pull request #23207 from braders/row-action-nodefaults
Eileen McNaughton [Fri, 15 Apr 2022 21:45:53 +0000 (09:45 +1200)]
Merge pull request #23207 from braders/row-action-nodefaults

Apply nodefaults to row actions

2 years agoMerge pull request #23208 from braders/access-wp-nodefaults
Eileen McNaughton [Fri, 15 Apr 2022 21:25:12 +0000 (09:25 +1200)]
Merge pull request #23208 from braders/access-wp-nodefaults

Add nodefaults to access.tpl

2 years agoMerge pull request #23225 from braders/edit-group-nodefaults
Eileen McNaughton [Fri, 15 Apr 2022 21:24:40 +0000 (09:24 +1200)]
Merge pull request #23225 from braders/edit-group-nodefaults

Add nodefaults to group edit form

2 years agoAdd nodefaults to group edit form
Bradley Taylor [Fri, 15 Apr 2022 08:59:19 +0000 (09:59 +0100)]
Add nodefaults to group edit form

2 years ago(REF) CryptoRegistry - Tighten type declaration
Tim Otten [Fri, 15 Apr 2022 03:53:43 +0000 (20:53 -0700)]
(REF) CryptoRegistry - Tighten type declaration

2 years agoMerge pull request #23186 from eileenmcnaughton/import_more
colemanw [Fri, 15 Apr 2022 02:48:00 +0000 (22:48 -0400)]
Merge pull request #23186 from eileenmcnaughton/import_more

Standardize DataSource file for Contribution & Membership

2 years agodev/core#1307 Add civicrm_import_job table
Eileen McNaughton [Thu, 14 Apr 2022 04:04:39 +0000 (16:04 +1200)]
dev/core#1307 Add civicrm_import_job table

2 years agoMerge pull request #23209 from civicrm/5.49
Eileen McNaughton [Fri, 15 Apr 2022 01:40:46 +0000 (13:40 +1200)]
Merge pull request #23209 from civicrm/5.49

5.49

2 years agoMerge pull request #23212 from colemanw/noMoreDrupal6
Eileen McNaughton [Fri, 15 Apr 2022 01:25:26 +0000 (13:25 +1200)]
Merge pull request #23212 from colemanw/noMoreDrupal6

Remove code only needed by Drupal6

2 years agoRemove code only needed by Drupal6
Coleman Watts [Thu, 14 Apr 2022 23:33:03 +0000 (19:33 -0400)]
Remove code only needed by Drupal6

Followup from https://github.com/civicrm/civicrm-core/pull/22960

2 years agoMerge pull request #23206 from braders/feature/pledge-payment-nodefaults
Eileen McNaughton [Thu, 14 Apr 2022 23:20:21 +0000 (11:20 +1200)]
Merge pull request #23206 from braders/feature/pledge-payment-nodefaults

Don't overescape links in pledge tab

2 years agoMerge pull request #23160 from eileenmcnaughton/ev
Tim Otten [Thu, 14 Apr 2022 23:13:07 +0000 (16:13 -0700)]
Merge pull request #23160 from eileenmcnaughton/ev

(REF) Fix test to use full flow

2 years agoMerge pull request #23205 from braders/tablink-nodefaults
Eileen McNaughton [Thu, 14 Apr 2022 22:46:47 +0000 (10:46 +1200)]
Merge pull request #23205 from braders/tablink-nodefaults

Don't overescape tab links

2 years agoMerge pull request #23198 from eileenmcnaughton/549
demeritcowboy [Thu, 14 Apr 2022 22:35:41 +0000 (18:35 -0400)]
Merge pull request #23198 from eileenmcnaughton/549

Move 5.49 update to beta

2 years agoAdd nodefaults to access.tpl
Bradley Taylor [Thu, 14 Apr 2022 22:03:16 +0000 (23:03 +0100)]
Add nodefaults to access.tpl

2 years agoMerge pull request #23204 from totten/master-ext-msg
Eileen McNaughton [Thu, 14 Apr 2022 21:50:25 +0000 (09:50 +1200)]
Merge pull request #23204 from totten/master-ext-msg

(dev/core#3171) "Manage Extensions" - Tweak messaging for "Install" screen

2 years agoApply nodefaults to row actions
Bradley Taylor [Thu, 14 Apr 2022 21:36:17 +0000 (22:36 +0100)]
Apply nodefaults to row actions

2 years agoDon't overescape links in pledge tab
Bradley Taylor [Thu, 14 Apr 2022 21:03:01 +0000 (22:03 +0100)]
Don't overescape links in pledge tab

2 years agoDon't overescape tab links
Bradley Taylor [Thu, 14 Apr 2022 20:50:57 +0000 (21:50 +0100)]
Don't overescape tab links

2 years ago"Manage Extensions" - Fix title display
Tim Otten [Thu, 14 Apr 2022 19:56:49 +0000 (12:56 -0700)]
"Manage Extensions" - Fix title display

1. Extensions sometimes display the `key` rather than the `<name>`.
   This happens because it only reads titles from the remote/download feed.
2. When the key is used, put some styling on it.
3. Escape from Los Smartalous

2 years agodev/core#3171 - Tune-down the pre-"Install" message
Tim Otten [Thu, 14 Apr 2022 19:55:31 +0000 (12:55 -0700)]
dev/core#3171 - Tune-down the pre-"Install" message

2 years agoStandardize DataSource file for Contribution & Membership
Eileen McNaughton [Wed, 13 Apr 2022 03:22:45 +0000 (15:22 +1200)]
Standardize DataSource file for Contribution & Membership

2 years agoMerge pull request #23194 from eileenmcnaughton/ds2
demeritcowboy [Thu, 14 Apr 2022 12:33:32 +0000 (08:33 -0400)]
Merge pull request #23194 from eileenmcnaughton/ds2

Remove unused parameter from private function

2 years agoMerge pull request #23200 from eileenmcnaughton/unused
demeritcowboy [Thu, 14 Apr 2022 12:30:48 +0000 (08:30 -0400)]
Merge pull request #23200 from eileenmcnaughton/unused

Remove unused function

2 years agoMerge pull request #23157 from eileenmcnaughton/anet
Monish Deb [Thu, 14 Apr 2022 08:20:50 +0000 (13:50 +0530)]
Merge pull request #23157 from eileenmcnaughton/anet

Minor readability improvement

2 years agoMerge pull request #23203 from civicrm/5.49
Eileen McNaughton [Thu, 14 Apr 2022 06:42:43 +0000 (18:42 +1200)]
Merge pull request #23203 from civicrm/5.49

5.49 to master

2 years agoMerge pull request #23177 from JMAConsulting/booleanFields_1
Eileen McNaughton [Thu, 14 Apr 2022 06:41:46 +0000 (18:41 +1200)]
Merge pull request #23177 from JMAConsulting/booleanFields_1

(REF) Schema - Correct boolean fields in various tables

2 years agoMerge pull request #23201 from civicrm/5.49
Seamus Lee [Thu, 14 Apr 2022 06:22:02 +0000 (16:22 +1000)]
Merge pull request #23201 from civicrm/5.49

5.49

2 years agoMerge pull request #23197 from seamuslee001/5.49
Eileen McNaughton [Thu, 14 Apr 2022 05:12:50 +0000 (17:12 +1200)]
Merge pull request #23197 from seamuslee001/5.49

[REF] Regenerate civicrm_generated data

2 years agoRemove unused function
Eileen McNaughton [Thu, 14 Apr 2022 05:10:14 +0000 (17:10 +1200)]
Remove unused function

2 years agorevert Menu.is_public requiredness
Monish Deb [Sat, 9 Apr 2022 02:05:54 +0000 (07:35 +0530)]
revert Menu.is_public requiredness

2 years agoMerge pull request #23158 from eileenmcnaughton/fail
Monish Deb [Thu, 14 Apr 2022 04:20:53 +0000 (09:50 +0530)]
Merge pull request #23158 from eileenmcnaughton/fail

[REF] Extract getContributionRecurID

2 years agoMerge pull request #22571 from eileenmcnaughton/trxn
Monish Deb [Thu, 14 Apr 2022 04:10:13 +0000 (09:40 +0530)]
Merge pull request #22571 from eileenmcnaughton/trxn

Improve financial trxn spec to require required fields

2 years agoMerge pull request #23196 from civicrm/5.49
Eileen McNaughton [Thu, 14 Apr 2022 04:03:44 +0000 (16:03 +1200)]
Merge pull request #23196 from civicrm/5.49

5.49 to master

2 years agoMove 5.49 update to beta
Eileen McNaughton [Thu, 14 Apr 2022 03:46:02 +0000 (15:46 +1200)]
Move 5.49 update to beta

2 years ago[REF] Regenerate civicrm_generated data
Seamus Lee [Thu, 14 Apr 2022 03:31:33 +0000 (13:31 +1000)]
[REF] Regenerate civicrm_generated data

2 years agoMerge pull request #23192 from eileenmcnaughton/549
Seamus Lee [Thu, 14 Apr 2022 03:24:39 +0000 (13:24 +1000)]
Merge pull request #23192 from eileenmcnaughton/549

Fix FiveFortyNine is_public to default to 0

2 years agoMerge pull request #23189 from alifrumin/rn5.49
Eileen McNaughton [Thu, 14 Apr 2022 02:30:23 +0000 (14:30 +1200)]
Merge pull request #23189 from alifrumin/rn5.49

[NFC] First Pass at Release notes for 5.49

2 years agoRemove unused parameter from private function
Eileen McNaughton [Thu, 14 Apr 2022 01:41:44 +0000 (13:41 +1200)]
Remove unused parameter from private function

2 years agoMerge pull request #23191 from twomice/3164_report_show_filter_criteria_zero
Eileen McNaughton [Thu, 14 Apr 2022 01:24:22 +0000 (13:24 +1200)]
Merge pull request #23191 from twomice/3164_report_show_filter_criteria_zero

dev/core#3164 : Report Filter Statistics don't show filters with vaue of "0"

2 years agoImprove financial trxn spec to require required fields
Eileen McNaughton [Wed, 19 Jan 2022 04:20:39 +0000 (17:20 +1300)]
Improve financial trxn spec to require required fields

It turns out the apiv4 conformance test only passes because it
is bypassing the BAO create method - which requires more parameters

Not this will fail :-( because it messes with the test expectations
- I don't know how to create complex valid test data for it though....

I guess we could create a contribution & pass it as entity_id

2 years ago[NFC] 5.49 release notes first pass
Alice Frumin [Wed, 13 Apr 2022 01:16:15 +0000 (21:16 -0400)]
[NFC] 5.49 release notes first pass

2 years agoFix FiveFortyNine is_public to default to 0
Eileen McNaughton [Wed, 13 Apr 2022 23:50:53 +0000 (11:50 +1200)]
Fix FiveFortyNine is_public to default to 0

2 years agodev/core#3164 : Report Filter Statistics don't show filters with value of "0"
Allen Shaw [Wed, 13 Apr 2022 23:24:21 +0000 (18:24 -0500)]
dev/core#3164 : Report Filter Statistics don't show filters with value of "0"

2 years agoMerge pull request #23139 from kurund/group-subscription-confirmation-email
Eileen McNaughton [Wed, 13 Apr 2022 21:10:09 +0000 (09:10 +1200)]
Merge pull request #23139 from kurund/group-subscription-confirmation-email

send group subscription welcome email only if template is enabled

2 years agoMerge pull request #23188 from colemanw/jsFix
demeritcowboy [Wed, 13 Apr 2022 18:09:31 +0000 (14:09 -0400)]
Merge pull request #23188 from colemanw/jsFix

Cleanup crmMailing/Templates.js

2 years agoCleanup crmMailing/Templates.js
Coleman Watts [Wed, 13 Apr 2022 16:01:59 +0000 (12:01 -0400)]
Cleanup crmMailing/Templates.js

2 years agoMerge pull request #23180 from eileenmcnaughton/csv
colemanw [Wed, 13 Apr 2022 02:27:42 +0000 (22:27 -0400)]
Merge pull request #23180 from eileenmcnaughton/csv

dev/core#3172 Update phpleague/csv from 9.2 to 9.6 (supports php 8)

2 years agoBackdrop - Stop running CliRunnerTest on php80+drush
Tim Otten [Wed, 13 Apr 2022 00:21:03 +0000 (17:21 -0700)]
Backdrop - Stop running CliRunnerTest on php80+drush

There seems to be a problem in using `drush ev` with our current versions of Drush / Backdrop / PHP 8.0

```
[bknix-edge:~/bknix/build/bcmaster/web/modules/civicrm] drush ev 'echo 123;'
PDOException: SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens: SELECT name FROM {system} WHERE type=&#039;module&#039; AND status=1; Array
(
    [:type] => module
    [:status] => 1
)
 in drush_db_select() (line 131 of phar:///Users/totten/bknix/extern/drush8.phar/includes/dbtng.inc).
Drush command terminated abnormally due to an unrecoverable error.
```

The problem is not specific to the functionality `civicrm-core.git` -- it
affects anything going through `drush-backdrop` and seems to be blocked on
upstream fixes.  But it's been generating a bunch of red-dot noise for the
past few months, and there's no point in that.

Note that `CliRunnerTest` still provides coverage for several adjacent combinations, so I'm not
too concerned about substantive change affecting civicrm-core. Those adjacent combinations are:

* PHP80 + D7 + Drush (differ only by CMS)
* PHP80 + Backdrop + Cv (differ only by CLI-runner)
* PHP7x + Bacdkrop + Drush (differ only by PHP-version)

2 years agoMerge pull request #23172 from eileenmcnaughton/import_most
colemanw [Wed, 13 Apr 2022 00:24:37 +0000 (20:24 -0400)]
Merge pull request #23172 from eileenmcnaughton/import_most

Further simplify variable retrieval

2 years agoMerge pull request #23181 from civicrm/5.49
Eileen McNaughton [Tue, 12 Apr 2022 23:50:31 +0000 (11:50 +1200)]
Merge pull request #23181 from civicrm/5.49

5.49 to master

2 years agoMerge pull request #23179 from totten/5.49-grant-entities
Eileen McNaughton [Tue, 12 Apr 2022 23:50:08 +0000 (11:50 +1200)]
Merge pull request #23179 from totten/5.49-grant-entities

(dev/core#3161) CiviGrant - Cleanup managed entities (5.49-rc)

2 years agodev/core#3172 Update phpleague/csv from 9.2 to 9.6 (supports php 8)
Eileen McNaughton [Tue, 12 Apr 2022 23:35:45 +0000 (11:35 +1200)]
dev/core#3172 Update phpleague/csv from 9.2 to 9.6 (supports php 8)

2 years agoMerge pull request #23082 from agileware/CIVICRM-1958
Eileen McNaughton [Tue, 12 Apr 2022 23:24:30 +0000 (11:24 +1200)]
Merge pull request #23082 from agileware/CIVICRM-1958

🪲 🪳 Bug Fix: The option "Enable multiple bulk email address for a contact" does not apply when editing a Contact, only works for inline edit of email addresses

2 years agoCiviGrant - Remove unused managed entities during upgrade
Coleman Watts [Tue, 12 Apr 2022 15:31:02 +0000 (11:31 -0400)]
CiviGrant - Remove unused managed entities during upgrade

Removes managed entities which may have been added during the 5.47 upgrade,
to prevent the managed system from automatically deleting them.

2 years agoCiviGrant - Cleanup managed entities - fixes dev/core#3161
Coleman Watts [Fri, 8 Apr 2022 13:47:51 +0000 (09:47 -0400)]
CiviGrant - Cleanup managed entities - fixes dev/core#3161

- Ensure labels are translated
- Set stricter cleanup policy for entities that should be removed on uninstall
- Make grant_status options unmanaged. They will not be updated by the system ever,
  but they will be deleted on uninstall because the option group is a managed entity.

2 years agoMerge pull request #23174 from braders/nodefaults-contrib-links
Eileen McNaughton [Tue, 12 Apr 2022 19:12:29 +0000 (07:12 +1200)]
Merge pull request #23174 from braders/nodefaults-contrib-links

Contribution dashboard links work in escape-on-output mode

2 years agoMerge pull request #23178 from civicrm/5.49
Eileen McNaughton [Tue, 12 Apr 2022 19:11:12 +0000 (07:11 +1200)]
Merge pull request #23178 from civicrm/5.49

5.49 to master

2 years agoMerge pull request #23176 from agh1/5.49.0-releasenotes-initial
Eileen McNaughton [Tue, 12 Apr 2022 19:09:58 +0000 (07:09 +1200)]
Merge pull request #23176 from agh1/5.49.0-releasenotes-initial

5.49.0 release notes initial run

2 years agoMerge pull request #23175 from pradpnayak/limitcontacts
Eileen McNaughton [Tue, 12 Apr 2022 19:00:55 +0000 (07:00 +1200)]
Merge pull request #23175 from pradpnayak/limitcontacts

Limit issue when printing pdf from contribution search

2 years ago5.49.0 release notes: added boilerplate
Andie Hunt [Tue, 12 Apr 2022 17:00:31 +0000 (13:00 -0400)]
5.49.0 release notes: added boilerplate

2 years ago5.49.0 release notes: raw from script
Andie Hunt [Tue, 12 Apr 2022 16:23:20 +0000 (12:23 -0400)]
5.49.0 release notes: raw from script

2 years agoMerge pull request #23173 from braders/escape-on-output-event-links
colemanw [Tue, 12 Apr 2022 15:07:30 +0000 (11:07 -0400)]
Merge pull request #23173 from braders/escape-on-output-event-links

Add smarty:nodefaults to ManageEvent page.

2 years agoFix limit issue
Pradeep Nayak [Tue, 12 Apr 2022 13:13:45 +0000 (14:13 +0100)]
Fix limit issue

2 years agoContrib dashboard links work in escape-on-output mode
Bradley Taylor [Tue, 12 Apr 2022 06:51:12 +0000 (07:51 +0100)]
Contrib dashboard links work in escape-on-output mode

2 years agoAdd smarty:nodefaults to ManageEvent page.
Bradley Taylor [Tue, 12 Apr 2022 06:41:42 +0000 (07:41 +0100)]
Add smarty:nodefaults to ManageEvent page.
This ensures that the links render correctly in escape-on-output mode.

2 years agoSimplify more variables
Eileen McNaughton [Tue, 12 Apr 2022 02:49:22 +0000 (14:49 +1200)]
Simplify more variables

2 years agoSimplify value retrieval
Eileen McNaughton [Mon, 11 Apr 2022 23:42:04 +0000 (11:42 +1200)]
Simplify value retrieval

2 years agoMerge pull request #23171 from eileenmcnaughton/saved_map
Eileen McNaughton [Tue, 12 Apr 2022 02:33:07 +0000 (14:33 +1200)]
Merge pull request #23171 from eileenmcnaughton/saved_map

Remove some copy & paste

2 years agoMerge pull request #23169 from totten/master-authx-info
Tim Otten [Tue, 12 Apr 2022 00:48:00 +0000 (17:48 -0700)]
Merge pull request #23169 from totten/master-authx-info

(NFC) authx - Update descriptions and links in `info.xml`

2 years agoRemove some copy & paste
Eileen McNaughton [Tue, 12 Apr 2022 00:45:28 +0000 (12:45 +1200)]
Remove some copy & paste

2 years agoMerge pull request #23135 from eileenmcnaughton/memm
colemanw [Mon, 11 Apr 2022 23:35:48 +0000 (19:35 -0400)]
Merge pull request #23135 from eileenmcnaughton/memm

Centralise skipColumnHeader to one function (fixes notices, cleans code)

2 years agoMerge pull request #23168 from totten/master-ver-compat
colemanw [Mon, 11 Apr 2022 23:28:24 +0000 (19:28 -0400)]
Merge pull request #23168 from totten/master-ver-compat

(Re-)Set version to 5.50.alpha1

2 years agoMerge pull request #23166 from pradpnayak/limitcontacts
Eileen McNaughton [Mon, 11 Apr 2022 23:28:22 +0000 (11:28 +1200)]
Merge pull request #23166 from pradpnayak/limitcontacts

Set limit to 0 when processing send sms task

2 years agoMerge pull request #23165 from eileenmcnaughton/ref
colemanw [Mon, 11 Apr 2022 23:24:38 +0000 (19:24 -0400)]
Merge pull request #23165 from eileenmcnaughton/ref

Reduce use of reference

2 years ago(NFC) authx - Update descriptions and links in `info.xml`
Tim Otten [Mon, 11 Apr 2022 22:47:52 +0000 (15:47 -0700)]
(NFC) authx - Update descriptions and links in `info.xml`

2 years agoSet limit to 0 when processing send sms task
Pradeep Nayak [Mon, 11 Apr 2022 20:56:30 +0000 (21:56 +0100)]
Set limit to 0 when processing send sms task

2 years agoSet version to 5.50.alpha1
Tim Otten [Mon, 11 Apr 2022 21:42:11 +0000 (14:42 -0700)]
Set version to 5.50.alpha1

2 years agoMerge pull request #23143 from colemanw/extVersion
Tim Otten [Mon, 11 Apr 2022 21:44:34 +0000 (14:44 -0700)]
Merge pull request #23143 from colemanw/extVersion

Release - Set version compatibility for core extensions when updating core

2 years agoCentralise skipColumnHeader to one function
Eileen McNaughton [Fri, 8 Apr 2022 00:40:07 +0000 (12:40 +1200)]
Centralise skipColumnHeader to one function

2 years agoReduce use of reference
Eileen McNaughton [Mon, 11 Apr 2022 19:53:08 +0000 (07:53 +1200)]
Reduce use of reference

Reference does not make sense for objects. assign_by_ref does not make
sense when not used again in the function or returned in a reffy kinda way

2 years agoMerge pull request #23101 from MegaphoneJon/core-1836-js
Eileen McNaughton [Mon, 11 Apr 2022 19:34:44 +0000 (07:34 +1200)]
Merge pull request #23101 from MegaphoneJon/core-1836-js

core#1836 - restrict scheduled reminder 'Also Include' to non-events

2 years agoMerge pull request #23163 from mlutfy/fixTsEventSv
Eileen McNaughton [Mon, 11 Apr 2022 19:31:46 +0000 (07:31 +1200)]
Merge pull request #23163 from mlutfy/fixTsEventSv

getSelfServiceEligibility: fix string translation

2 years agoMerge pull request #23155 from eileenmcnaughton/ret2
demeritcowboy [Mon, 11 Apr 2022 18:37:58 +0000 (14:37 -0400)]
Merge pull request #23155 from eileenmcnaughton/ret2

Remove-single-value-loop

2 years agoMerge pull request #23162 from agileware/additional-not-additonal
demeritcowboy [Mon, 11 Apr 2022 18:30:05 +0000 (14:30 -0400)]
Merge pull request #23162 from agileware/additional-not-additonal

✍🏼 Fix spelling of "additional". Numerous uses of "additonal"

2 years agogetSelfServiceEligibility: fix string translation
Mathieu Lutfy [Mon, 11 Apr 2022 17:58:26 +0000 (13:58 -0400)]
getSelfServiceEligibility: fix string translation

2 years agoFix spelling of additional
Justin Freeman [Mon, 11 Apr 2022 03:51:25 +0000 (13:51 +1000)]
Fix spelling of additional

2 years agoFix test to use full flow
Eileen McNaughton [Mon, 11 Apr 2022 02:16:32 +0000 (14:16 +1200)]
Fix test to use full flow

2 years ago[REF] Extract getContributionRecurID
Eileen McNaughton [Mon, 11 Apr 2022 01:33:26 +0000 (13:33 +1200)]
[REF] Extract getContributionRecurID

2 years agoMinor readability improvement
Eileen McNaughton [Mon, 11 Apr 2022 01:16:11 +0000 (13:16 +1200)]
Minor readability improvement

This just adds isSuccess as a function to avoid having to understand what
response code is.

I grepped & didn't find 'response_code' outside the class/test

I also confirmed that the retrieve function casts to an int (via
validate) so the triple = is correct

2 years agoRemove last pay_later_text isset
Eileen McNaughton [Fri, 1 Apr 2022 03:27:23 +0000 (16:27 +1300)]
Remove last pay_later_text isset

2 years agoMerge pull request #23141 from totten/master-mailing-verify
Eileen McNaughton [Sun, 10 Apr 2022 23:26:31 +0000 (11:26 +1200)]
Merge pull request #23141 from totten/master-mailing-verify

(dev/mail#107) CiviMail - Fix validation error (5.49)

2 years agoMerge pull request #22159 from colemanw/isCurrentDomain
Eileen McNaughton [Sun, 10 Apr 2022 23:21:51 +0000 (11:21 +1200)]
Merge pull request #22159 from colemanw/isCurrentDomain

APIv4 - Add `is_active` extra field to Domain entity