civicrm-core.git
4 years agoMinor simplification on additional_participants checks
eileen [Mon, 29 Jul 2019 03:52:19 +0000 (15:52 +1200)]
Minor simplification on additional_participants checks

4 years agoMerge pull request #16054 from seamuslee001/sort_contact
Eileen McNaughton [Mon, 9 Dec 2019 06:04:28 +0000 (19:04 +1300)]
Merge pull request #16054 from seamuslee001/sort_contact

[REF] Refactor Contact Search form to use standardised getSortID func…

4 years agoMerge pull request #16053 from seamuslee001/activity_sort
Eileen McNaughton [Mon, 9 Dec 2019 05:20:55 +0000 (18:20 +1300)]
Merge pull request #16053 from seamuslee001/activity_sort

[REF] Refactor Activity Search to use parent getSortID function

4 years agoMerge pull request #16055 from seamuslee001/campaign_sort
Eileen McNaughton [Mon, 9 Dec 2019 05:20:40 +0000 (18:20 +1300)]
Merge pull request #16055 from seamuslee001/campaign_sort

[REF] Refactor Campaign Search form to use standardised getSortID fun…

4 years ago[REF] Refactor Campaign Search form to use standardised getSortID function
Seamus Lee [Mon, 9 Dec 2019 03:55:23 +0000 (14:55 +1100)]
[REF] Refactor Campaign Search form to use standardised getSortID function

4 years ago[REF] Refactor Contact Search form to use standardised getSortID function
Seamus Lee [Mon, 9 Dec 2019 03:55:17 +0000 (14:55 +1100)]
[REF] Refactor Contact Search form to use standardised getSortID function

4 years agoMerge pull request #16050 from eileenmcnaughton/qf
Seamus Lee [Mon, 9 Dec 2019 03:48:15 +0000 (14:48 +1100)]
Merge pull request #16050 from eileenmcnaughton/qf

[NFC] code cleanup

4 years ago[REF] Refactor Activity Search to use parent getSortID function
Seamus Lee [Mon, 9 Dec 2019 03:47:55 +0000 (14:47 +1100)]
[REF] Refactor Activity Search to use parent getSortID function

4 years agoMerge pull request #15942 from seamuslee001/contact_fields_metadata
Seamus Lee [Mon, 9 Dec 2019 03:34:38 +0000 (14:34 +1100)]
Merge pull request #15942 from seamuslee001/contact_fields_metadata

Add in searchFieldMetadata for contact_tags, contact_type, group and …

4 years agoMerge pull request #16051 from civicrm/5.21
Eileen McNaughton [Mon, 9 Dec 2019 02:36:45 +0000 (15:36 +1300)]
Merge pull request #16051 from civicrm/5.21

5.21

4 years agoMerge pull request #15927 from eileenmcnaughton/event_form
Seamus Lee [Mon, 9 Dec 2019 02:31:38 +0000 (13:31 +1100)]
Merge pull request #15927 from eileenmcnaughton/event_form

[REF] Move wrangling of Front end form contribution param for autoRenew back to form

4 years agoOnly add in the additional metadata if we are also adding them to the form
Seamus Lee [Tue, 26 Nov 2019 19:57:43 +0000 (06:57 +1100)]
Only add in the additional metadata if we are also adding them to the form

4 years agoAdd in searchFieldMetadata for contact_tags, contact_type, group and deleted_contacts...
Seamus Lee [Sun, 24 Nov 2019 03:20:24 +0000 (14:20 +1100)]
Add in searchFieldMetadata for contact_tags, contact_type, group and deleted_contacts fields for contribute, pledge searches

4 years agoMerge pull request #16047 from eileenmcnaughton/521
Seamus Lee [Mon, 9 Dec 2019 02:25:50 +0000 (13:25 +1100)]
Merge pull request #16047 from eileenmcnaughton/521

dev/membership#21 Fix regression causing transfer of membership to another contact if they paid

4 years ago[NFC] code cleanup
eileen [Mon, 9 Dec 2019 02:11:04 +0000 (15:11 +1300)]
[NFC] code cleanup

Add some throws statements, fix some double quotes to single, fix some comparisons to strict

4 years agoMerge pull request #16049 from civicrm/5.21
Eileen McNaughton [Mon, 9 Dec 2019 01:42:58 +0000 (14:42 +1300)]
Merge pull request #16049 from civicrm/5.21

5.21

4 years agoMerge pull request #16038 from seamuslee001/proper_event_badge_fix
Eileen McNaughton [Mon, 9 Dec 2019 01:42:20 +0000 (14:42 +1300)]
Merge pull request #16038 from seamuslee001/proper_event_badge_fix

Proper Fix for dev/core#1422

4 years agoMerge pull request #16034 from seamuslee001/dev_core_1449
Seamus Lee [Sun, 8 Dec 2019 23:22:51 +0000 (10:22 +1100)]
Merge pull request #16034 from seamuslee001/dev_core_1449

dev/core#1449 Do not dispatch pre/post hooks during upgrade

4 years agoMerge pull request #16045 from seamuslee001/nfc_settings_array
Eileen McNaughton [Sun, 8 Dec 2019 22:57:59 +0000 (11:57 +1300)]
Merge pull request #16045 from seamuslee001/nfc_settings_array

[NFC] Add in a unit test of passing an array into the Civi::settings …

4 years agodev/membership#21 Fix regression on transferring member to another contact if they...
eileen [Sun, 8 Dec 2019 22:13:49 +0000 (11:13 +1300)]
dev/membership#21 Fix regression on transferring member to another contact if they paid

4 years agodev/core#1449 Do not dispatch pre and post hooks whilst we are in an upgrade process
Seamus Lee [Fri, 6 Dec 2019 01:34:27 +0000 (12:34 +1100)]
dev/core#1449 Do not dispatch pre and post hooks whilst we are in an upgrade process

Add in code comments to point to new gitlab and reasoning for the change

4 years agoMerge pull request #16044 from seamuslee001/remove_deprecated_function
Seamus Lee [Sun, 8 Dec 2019 21:38:44 +0000 (08:38 +1100)]
Merge pull request #16044 from seamuslee001/remove_deprecated_function

[REF] Replace Deprecated function CRM_Core_BAO_Setting::setItem with …

4 years ago[NFC] Add in a unit test of passing an array into the Civi::settings set facade and...
Seamus Lee [Sun, 8 Dec 2019 20:42:30 +0000 (07:42 +1100)]
[NFC] Add in a unit test of passing an array into the Civi::settings set facade and getting it back

4 years agoMerge pull request #16042 from agileware/CIVICRM-1392
Seamus Lee [Sun, 8 Dec 2019 20:30:28 +0000 (07:30 +1100)]
Merge pull request #16042 from agileware/CIVICRM-1392

Update Smart Group form uses different labels for Group Title and Group Description

4 years agoMerge pull request #16043 from agileware/CIVICRM-1391
Seamus Lee [Sun, 8 Dec 2019 20:29:37 +0000 (07:29 +1100)]
Merge pull request #16043 from agileware/CIVICRM-1391

Update Smart Group form unsets the existing Group Types

4 years ago[REF] Replace Deprecated function CRM_Core_BAO_Setting::setItem with the relevant...
Seamus Lee [Sun, 8 Dec 2019 19:46:24 +0000 (06:46 +1100)]
[REF] Replace Deprecated function CRM_Core_BAO_Setting::setItem with the relevant Civi::contactSettings function

4 years agoCIVICRM-1391 Update Smart Group form unsets the existing Group Types for the Group
Justin Freeman [Sun, 8 Dec 2019 05:28:36 +0000 (16:28 +1100)]
CIVICRM-1391 Update Smart Group form unsets the existing Group Types for the Group

4 years agoCIVICRM-1392 - Group, Update Smart Group uses different labels for Group Title and...
Justin Freeman [Sun, 8 Dec 2019 04:45:52 +0000 (15:45 +1100)]
CIVICRM-1392 - Group, Update Smart Group uses different labels for Group Title and Group Description

4 years agoMerge pull request #16040 from civicrm/5.21
Seamus Lee [Sat, 7 Dec 2019 22:05:29 +0000 (09:05 +1100)]
Merge pull request #16040 from civicrm/5.21

5.21

4 years agoMerge pull request #16033 from seamuslee001/dev_core_1447
Mathieu Lu [Sat, 7 Dec 2019 17:47:09 +0000 (12:47 -0500)]
Merge pull request #16033 from seamuslee001/dev_core_1447

dev/core#1447 Fix hard fail on upgrade due to duplicate names in the …

4 years agoAdd in unit test locking in the fix
Seamus Lee [Fri, 6 Dec 2019 22:25:34 +0000 (09:25 +1100)]
Add in unit test locking in the fix

4 years agoProper Fix for dev/core#1422
Seamus Lee [Fri, 6 Dec 2019 21:58:32 +0000 (08:58 +1100)]
Proper Fix for dev/core#1422

4 years agoMerge pull request #15975 from eileenmcnaughton/setting
Seamus Lee [Fri, 6 Dec 2019 20:40:33 +0000 (07:40 +1100)]
Merge pull request #15975 from eileenmcnaughton/setting

dev/core#1425 More aggressively deprecate old setItem & setOptionValue functions on BAO_Setting

4 years agoMerge pull request #16037 from civicrm/5.21
Seamus Lee [Fri, 6 Dec 2019 20:26:04 +0000 (07:26 +1100)]
Merge pull request #16037 from civicrm/5.21

5.21

4 years agoMerge pull request #16036 from agh1/5.21.0-releasenotes
Seamus Lee [Fri, 6 Dec 2019 20:16:08 +0000 (07:16 +1100)]
Merge pull request #16036 from agh1/5.21.0-releasenotes

5.21.0 release notes: initial run

4 years ago5.20.0 release notes: added boilerplate
Andrew Hunt [Fri, 6 Dec 2019 19:33:24 +0000 (14:33 -0500)]
5.20.0 release notes: added boilerplate

4 years ago5.20.0 release notes: raw from script
Andrew Hunt [Fri, 6 Dec 2019 19:30:35 +0000 (14:30 -0500)]
5.20.0 release notes: raw from script

4 years agodev/core#1447 Fix hard fail on upgrade due to duplicate names in the database when...
Seamus Lee [Thu, 5 Dec 2019 22:14:56 +0000 (09:14 +1100)]
dev/core#1447 Fix hard fail on upgrade due to duplicate names in the database when trying to fix the option group name

4 years agoMerge pull request #16031 from agileware/CIVICRM-1389
Matthew Wire [Thu, 5 Dec 2019 12:05:09 +0000 (12:05 +0000)]
Merge pull request #16031 from agileware/CIVICRM-1389

Fix typo, Mailign should be Mailing

4 years agoCIVICRM-1389 Fix typo, Mailign should be Mailing
Justin Freeman [Thu, 5 Dec 2019 10:14:08 +0000 (21:14 +1100)]
CIVICRM-1389 Fix typo, Mailign should be Mailing

4 years agoMerge pull request #16006 from demeritcowboy/case-role-manager-api
colemanw [Wed, 4 Dec 2019 23:38:52 +0000 (18:38 -0500)]
Merge pull request #16006 from demeritcowboy/case-role-manager-api

dev/core#1426 Return correct manager role info during Case api get

4 years agoSet version to 5.22.alpha1
CiviCRM [Wed, 4 Dec 2019 22:52:56 +0000 (22:52 +0000)]
Set version to 5.22.alpha1

4 years agoSet version to 5.21.beta1
CiviCRM [Wed, 4 Dec 2019 22:46:40 +0000 (22:46 +0000)]
Set version to 5.21.beta1

4 years agorelease-notes.md - Fix 5.19.4 TOC
Tim Otten [Wed, 4 Dec 2019 20:38:51 +0000 (12:38 -0800)]
release-notes.md - Fix 5.19.4 TOC

4 years agorelease-notes/5.20.0
Tim Otten [Wed, 4 Dec 2019 20:08:07 +0000 (12:08 -0800)]
release-notes/5.20.0

4 years agoUpdate 5.19.4.md
totten [Wed, 4 Dec 2019 17:21:28 +0000 (17:21 +0000)]
Update 5.19.4.md

4 years agoUpdate 5.19.4.md
totten [Wed, 4 Dec 2019 17:04:52 +0000 (17:04 +0000)]
Update 5.19.4.md

4 years agoUpdate release notes for latest PR backported
Seamus Lee [Tue, 3 Dec 2019 19:39:14 +0000 (06:39 +1100)]
Update release notes for latest PR backported

4 years agoAdd in release notes for 5.19.4 drop
Seamus Lee [Sun, 1 Dec 2019 23:09:30 +0000 (10:09 +1100)]
Add in release notes for 5.19.4 drop

4 years agoAlso update composer.lock
Seamus Lee [Mon, 2 Dec 2019 19:30:58 +0000 (06:30 +1100)]
Also update composer.lock

4 years agoUpgrade CKEditor to v4.13.0
Coleman Watts [Mon, 2 Dec 2019 18:47:40 +0000 (13:47 -0500)]
Upgrade CKEditor to v4.13.0

4 years agoRemove the check statement as not relevant to apiv4
Seamus Lee [Sat, 30 Nov 2019 22:42:41 +0000 (09:42 +1100)]
Remove the check statement as not relevant to apiv4

4 years agoAlso ensure that updates etc cannot be done via get only via post as per APIv3
Seamus Lee [Fri, 29 Nov 2019 07:46:51 +0000 (18:46 +1100)]
Also ensure that updates etc cannot be done via get only via post as per APIv3

4 years agoEnsure that API Explorer passes through necessary header
Seamus Lee [Thu, 28 Nov 2019 23:03:00 +0000 (10:03 +1100)]
Ensure that API Explorer passes through necessary header

4 years agosecurity/core#71 Prevent CSRF by ensuring that AJAX endpoint of the API Explorer...
Seamus Lee [Thu, 28 Nov 2019 21:33:44 +0000 (08:33 +1100)]
security/core#71 Prevent CSRF by ensuring that AJAX endpoint of the API Explorer can only be hit by javascript clinets

4 years agoMerge pull request #16028 from civicrm/5.20
Seamus Lee [Wed, 4 Dec 2019 19:58:53 +0000 (06:58 +1100)]
Merge pull request #16028 from civicrm/5.20

5.20

4 years agoMerge pull request #16026 from eileenmcnaughton/payment_update
Seamus Lee [Wed, 4 Dec 2019 19:46:07 +0000 (06:46 +1100)]
Merge pull request #16026 from eileenmcnaughton/payment_update

[NFC] code cleanup in test class.

4 years agoMerge pull request #16027 from agh1/5.20.0-releasenotes-final
Tim Otten [Wed, 4 Dec 2019 18:51:38 +0000 (10:51 -0800)]
Merge pull request #16027 from agh1/5.20.0-releasenotes-final

5.20.0 release notes: final edits

4 years ago5.20.0 release notes: final edits
Andrew Hunt [Wed, 4 Dec 2019 18:34:00 +0000 (13:34 -0500)]
5.20.0 release notes: final edits

4 years ago5.20.0 release notes: add late changes
Andrew Hunt [Wed, 4 Dec 2019 17:28:24 +0000 (12:28 -0500)]
5.20.0 release notes: add late changes

4 years ago[NFC] code cleanup in test class.
eileen [Wed, 4 Dec 2019 06:20:07 +0000 (19:20 +1300)]
[NFC] code cleanup in test class.

Declare exceptions, use single quotes, call static functions statically

4 years agoMerge pull request #15697 from artfulrobot/payment-property-bag
Eileen McNaughton [Wed, 4 Dec 2019 05:32:02 +0000 (18:32 +1300)]
Merge pull request #15697 from artfulrobot/payment-property-bag

Add Payment PropertyBag for payment processor method arguments

4 years agoMerge pull request #16021 from mattwire/paymentinfo_amountpaid
Eileen McNaughton [Wed, 4 Dec 2019 05:20:06 +0000 (18:20 +1300)]
Merge pull request #16021 from mattwire/paymentinfo_amountpaid

Always display amount paid even if it is 0.00. Blank looks like it's missing data rather than nothing paid

4 years agoMerge pull request #16024 from jmcclelland/pcp-contribution-status
Eileen McNaughton [Wed, 4 Dec 2019 04:56:28 +0000 (17:56 +1300)]
Merge pull request #16024 from jmcclelland/pcp-contribution-status

allow PCP report to filter on contribution status

4 years agoMerge pull request #16023 from seamuslee001/1435_nfc
Eileen McNaughton [Wed, 4 Dec 2019 04:33:27 +0000 (17:33 +1300)]
Merge pull request #16023 from seamuslee001/1435_nfc

[NFC] Fix camelCase variable name following fix for dev/core#1435

4 years ago[NFC] Fix camelCase variable name following fix for dev/core#1435
Seamus Lee [Tue, 3 Dec 2019 19:19:47 +0000 (06:19 +1100)]
[NFC] Fix camelCase variable name following fix for dev/core#1435

4 years agoMerge pull request #16019 from mattwire/contributionview_removecancelled
Seamus Lee [Tue, 3 Dec 2019 19:49:48 +0000 (06:49 +1100)]
Merge pull request #16019 from mattwire/contributionview_removecancelled

Remove unused cancelledStatus assign on contributionView

4 years agoallow PCP report to filter on contribution status
Jamie McClelland [Tue, 3 Dec 2019 19:38:10 +0000 (14:38 -0500)]
allow PCP report to filter on contribution status

Without this filter, incomplete contributions are included in the report
which really throws off the total.

4 years agoAlways display amount paid even if it is 0.00. Blank looks like it's missing data...
Matthew Wire (MJW Consulting) [Wed, 6 Nov 2019 16:22:16 +0000 (16:22 +0000)]
Always display amount paid even if it is 0.00. Blank looks like it's missing data rather than nothing paid

4 years agoRemove unused cancelledStatus assign
Matthew Wire (MJW Consulting) [Wed, 6 Nov 2019 15:17:57 +0000 (15:17 +0000)]
Remove unused cancelledStatus assign

4 years agoMerge pull request #16016 from seamuslee001/master
Seamus Lee [Tue, 3 Dec 2019 08:28:24 +0000 (19:28 +1100)]
Merge pull request #16016 from seamuslee001/master

5.20

4 years agoMerge in 5.20
Seamus Lee [Tue, 3 Dec 2019 08:26:58 +0000 (19:26 +1100)]
Merge in 5.20

4 years agoMerge pull request #16013 from eileenmcnaughton/reg
Seamus Lee [Tue, 3 Dec 2019 08:13:00 +0000 (19:13 +1100)]
Merge pull request #16013 from eileenmcnaughton/reg

dev/core#1435 Fix lack of filtering in Contribution tab on Membership or Participant View

4 years agoMerge pull request #15989 from seamuslee001/dev_core_523
Eileen McNaughton [Tue, 3 Dec 2019 06:47:04 +0000 (19:47 +1300)]
Merge pull request #15989 from seamuslee001/dev_core_523

dev/core#523 get the Lybunt charts working again

4 years agodev/core#1435 Fix lack of filtering in Contribution tab on Membership or Participant...
eileen [Tue, 3 Dec 2019 05:46:21 +0000 (18:46 +1300)]
dev/core#1435 Fix lack of filtering in Contribution tab on Membership or Participant View

4 years agoMerge pull request #16010 from demeritcowboy/remove-recordactivityviaemail
Seamus Lee [Tue, 3 Dec 2019 02:59:42 +0000 (13:59 +1100)]
Merge pull request #16010 from demeritcowboy/remove-recordactivityviaemail

[NFC] Remove dinosaur function

4 years agoremove unused function
demeritcowboy [Tue, 3 Dec 2019 01:33:38 +0000 (20:33 -0500)]
remove unused function

4 years agoMerge pull request #15523 from jamie-tillman/patch-1
Mathieu Lu [Mon, 2 Dec 2019 22:14:39 +0000 (17:14 -0500)]
Merge pull request #15523 from jamie-tillman/patch-1

PayPalImpl: Add SOLUTIONTYPE parameter that triggers allowing to pay without having to create a paypal account.

4 years agoMerge pull request #15971 from aydun/report#23
Mathieu Lu [Mon, 2 Dec 2019 21:38:18 +0000 (16:38 -0500)]
Merge pull request #15971 from aydun/report#23

dev/report#23 - Fix contact sub-type 'is not one of' filtering

4 years agoMerge pull request #15946 from seamuslee001/status_check_improve
Mathieu Lu [Mon, 2 Dec 2019 21:33:49 +0000 (16:33 -0500)]
Merge pull request #15946 from seamuslee001/status_check_improve

Make utf8mb4 status check language more for the general consumer

4 years agoMerge pull request #15974 from eileenmcnaughton/ex_clean
Seamus Lee [Mon, 2 Dec 2019 21:29:54 +0000 (08:29 +1100)]
Merge pull request #15974 from eileenmcnaughton/ex_clean

Make else statement more legible

4 years agoMerge pull request #15908 from eileenmcnaughton/anet_setup
Mathieu Lu [Mon, 2 Dec 2019 21:25:54 +0000 (16:25 -0500)]
Merge pull request #15908 from eileenmcnaughton/anet_setup

[Test] fix test setup on ANet tests

4 years agoRemove test on function we are deprecating to remove.
eileen [Mon, 2 Dec 2019 21:02:13 +0000 (10:02 +1300)]
Remove test on function we are deprecating to remove.

Tests fail on this now due to deprecation. Looking to remove the whole fn in future

4 years agoMerge pull request #15997 from seamuslee001/dev_core_1166
Mathieu Lu [Mon, 2 Dec 2019 20:22:33 +0000 (15:22 -0500)]
Merge pull request #15997 from seamuslee001/dev_core_1166

dev/core#1166 Update the name of Macedonia, Republic of to North Macedonia

4 years agoMerge pull request #16008 from civicrm/5.20
Seamus Lee [Mon, 2 Dec 2019 19:56:06 +0000 (06:56 +1100)]
Merge pull request #16008 from civicrm/5.20

5.20

4 years agoMerge pull request #16007 from seamuslee001/5.20
Seamus Lee [Mon, 2 Dec 2019 19:55:06 +0000 (06:55 +1100)]
Merge pull request #16007 from seamuslee001/5.20

Add release-notes/5.19.3.md

4 years agoAdd release-notes/5.19.3.md
Tim Otten [Mon, 25 Nov 2019 22:31:20 +0000 (14:31 -0800)]
Add release-notes/5.19.3.md

4 years agoreturn manager info during api call
demeritcowboy [Mon, 2 Dec 2019 18:15:49 +0000 (13:15 -0500)]
return manager info during api call

4 years agoMerge pull request #15970 from eileenmcnaughton/ex_easy
Monish Deb [Mon, 2 Dec 2019 12:32:40 +0000 (18:02 +0530)]
Merge pull request #15970 from eileenmcnaughton/ex_easy

[REF] clean up merge array.

4 years agoMerge pull request #16001 from agileware/CIVICRM-1383
Seamus Lee [Mon, 2 Dec 2019 06:48:47 +0000 (17:48 +1100)]
Merge pull request #16001 from agileware/CIVICRM-1383

Code style, remove typo, double ;; from code where it makes sense to do so

4 years agoMerge pull request #15937 from seamuslee001/dev_core_1405
Seamus Lee [Mon, 2 Dec 2019 05:49:26 +0000 (16:49 +1100)]
Merge pull request #15937 from seamuslee001/dev_core_1405

dev/core#1405 Strip any spaces from Option Group name parameter and r…

4 years agoCIVICRM-1383 Remove typo, double ;; from CiviCRM code
Justin Freeman [Sun, 1 Dec 2019 22:51:43 +0000 (09:51 +1100)]
CIVICRM-1383 Remove typo, double ;; from CiviCRM code

4 years agoMerge pull request #16004 from civicrm/5.20
Seamus Lee [Mon, 2 Dec 2019 04:46:48 +0000 (15:46 +1100)]
Merge pull request #16004 from civicrm/5.20

5.20

4 years agoMerge pull request #16000 from seamuslee001/dev_core_1434
Yashodha Chaku [Mon, 2 Dec 2019 04:27:49 +0000 (09:57 +0530)]
Merge pull request #16000 from seamuslee001/dev_core_1434

dev/core#1434 Fix table alias used in select when ouputting as a chart

4 years agoMerge pull request #16002 from seamuslee001/handle_custom_field_deleted
Seamus Lee [Mon, 2 Dec 2019 01:47:35 +0000 (12:47 +1100)]
Merge pull request #16002 from seamuslee001/handle_custom_field_deleted

Fix regression from fixing relative key handling where custom field no longer exists in the database

4 years agoCatch CiviCRM APIv3 Error if custom field no longer exists in the database
Seamus Lee [Mon, 2 Dec 2019 00:10:14 +0000 (11:10 +1100)]
Catch CiviCRM APIv3 Error if custom field no longer exists in the database

4 years agoAdd in unit test demonstrating the regression where smart group fails to load if...
Seamus Lee [Sun, 1 Dec 2019 23:52:46 +0000 (10:52 +1100)]
Add in unit test demonstrating the regression where smart group fails to load if a custom field has been deleted which was stored in the form values array

4 years agodev/core#1434 Fix table alias used in select when ouputting as a chart
Seamus Lee [Sun, 1 Dec 2019 20:17:09 +0000 (07:17 +1100)]
dev/core#1434 Fix table alias used in select when ouputting as a chart

4 years agoMerge pull request #15996 from eileenmcnaughton/act_test_priority
Seamus Lee [Sun, 1 Dec 2019 07:22:45 +0000 (18:22 +1100)]
Merge pull request #15996 from eileenmcnaughton/act_test_priority

Add testing for various params that pass through Contact_BAO_Query::optionValueQuery

4 years ago[REF] minor code simplification. Test where handling for gender_id etc
eileen [Sat, 30 Nov 2019 00:16:19 +0000 (13:16 +1300)]
[REF] minor code simplification. Test where handling for gender_id etc

Add test & reduce special handling for gender_id, suffix_id, prefix_id, communication_style_id