colemanw [Thu, 9 Nov 2023 19:58:11 +0000 (14:58 -0500)]
Afform - Fix error handling even when response incorrectly indicates success
This is a weird bug, where some WP sites will force status code 200 into the response of ajax requests,
regardless of what the response code was supposed to be.
Also see https://lab.civicrm.org/extensions/stripe/-/merge_requests/232
colemanw [Sat, 4 Nov 2023 22:47:40 +0000 (18:47 -0400)]
Afform - display prefill error messages directly from server
Thanks to
ddc3de8 we can now pass error messages directly to the client.
This takes advantage of that new feature and switches from guessing what the message should be,
to directly using the message that comes back from the server.
Eileen McNaughton [Thu, 9 Nov 2023 03:15:37 +0000 (16:15 +1300)]
Merge pull request #28074 from eileenmcnaughton/csv
Follow up fixes on `maxFileSize`
Eileen McNaughton [Thu, 9 Nov 2023 03:15:24 +0000 (16:15 +1300)]
Merge pull request #28075 from civicrm/5.68
5.68
Seamus Lee [Thu, 9 Nov 2023 01:23:56 +0000 (12:23 +1100)]
Merge pull request #28073 from totten/master568-http-log
(NFC) MenuXmlTest - Improve debug output. Use richer helpers.
Seamus Lee [Thu, 9 Nov 2023 00:57:19 +0000 (11:57 +1100)]
Merge pull request #28055 from seamuslee001/update_firebase_jwt
Update Firebase JWT to version 6.x
Eileen McNaughton [Thu, 9 Nov 2023 00:55:12 +0000 (13:55 +1300)]
Merge pull request #28071 from mattwire/confirmcleanup
REF: Cleanup to Event Registration Confirm form
Eileen McNaughton [Thu, 9 Nov 2023 00:48:36 +0000 (13:48 +1300)]
Follow up fixes on maxFileSize
This addresses an incorrect mixing of the size in bytes & megabytes that was just merged and extracts
the getting of the maxFileSize to a generic file location
Tim Otten [Wed, 8 Nov 2023 23:37:36 +0000 (15:37 -0800)]
MenuXmlTest - Improve debug output. Use richer helpers.
In automated test-runs, the e2e test for `mixin/menu-xml@1` (`MenuXmlTest`) has been failing sporadically.
The failure always involves one of the HTTP sub-requests, but it's never clear what actually happened
in the HTTP sub-request. This patch improves debug info.
Before
-------
Send HTTP sub-request with simple primitives (`cv` + `file_get_contents`). No detailed information about the failed request.
After
-----
Send HTTP sub-request with `HttpTestTrait` (`guzzle`). Use rich assertions that log more detailed information.
Tim Otten [Wed, 8 Nov 2023 23:37:03 +0000 (15:37 -0800)]
HttpTestTrait - Add more assertion helpers
Eileen McNaughton [Thu, 9 Nov 2023 00:15:34 +0000 (13:15 +1300)]
Merge pull request #28066 from eileenmcnaughton/member_renew
Declare _groupTree on MembershipRenewal form
Matthew Wire [Wed, 8 Nov 2023 23:39:48 +0000 (23:39 +0000)]
Rename loop variables for clarity
Matthew Wire [Wed, 8 Nov 2023 23:37:32 +0000 (23:37 +0000)]
Cleanup to event confirm form
Eileen McNaughton [Wed, 8 Nov 2023 23:34:35 +0000 (12:34 +1300)]
Merge pull request #28067 from braders/topdonor-php8
[REF][PHP8.2] Properties in TopDonor report
Eileen McNaughton [Wed, 8 Nov 2023 21:56:12 +0000 (10:56 +1300)]
Declare _groupTree on MembershipRenewal form
colemanw [Wed, 8 Nov 2023 23:19:56 +0000 (18:19 -0500)]
Merge pull request #28056 from seamuslee001/remove_phantomjs_launcher
Remove karama-phantomjs-launcher as we now use chrome browser for kar…
Seamus Lee [Wed, 8 Nov 2023 06:45:13 +0000 (17:45 +1100)]
[REF] Update Firebase JWT to be version 6.x
Add in Deprecation notice for versions less than 6 and add in compatability layer
demeritcowboy [Wed, 8 Nov 2023 22:53:51 +0000 (17:53 -0500)]
Merge pull request #28063 from eileenmcnaughton/reg
Remove registered_by_id as not set in this flow
Bradley Taylor [Wed, 8 Nov 2023 22:01:50 +0000 (22:01 +0000)]
[REF][PHP8.2] Properties in TopDonor report
Eileen McNaughton [Wed, 8 Nov 2023 21:51:02 +0000 (10:51 +1300)]
Merge pull request #28064 from braders/label-generator-properties
[REF][PHP8.2] Declare properties in CRM_Utils_PDF_Label
Eileen McNaughton [Wed, 8 Nov 2023 21:32:50 +0000 (10:32 +1300)]
Merge pull request #28062 from braders/feature/processor-form-test-remove-line
[REF][PHP8.2] Remove unused id property
Eileen McNaughton [Wed, 8 Nov 2023 21:05:07 +0000 (10:05 +1300)]
Merge pull request #27768 from aydun/no_cal
Add option to control display of calendar links.
Bradley Taylor [Wed, 8 Nov 2023 20:43:16 +0000 (20:43 +0000)]
[REF][PHP8.2] Declare properties in CRM_Utils_PDF_Label
Eileen McNaughton [Mon, 6 Nov 2023 22:26:03 +0000 (11:26 +1300)]
Remove registered_by_id as not set in this flow
Eileen McNaughton [Wed, 8 Nov 2023 20:19:26 +0000 (09:19 +1300)]
Merge pull request #28059 from mattwire/deprec
Switch to non deprecated functions for dompdf
Bradley Taylor [Wed, 8 Nov 2023 20:15:52 +0000 (20:15 +0000)]
[REF][PHP8.2] Remove unused id property
Aidan Saunders [Tue, 10 Oct 2023 17:28:40 +0000 (18:28 +0100)]
Add option to control display of calendar links
Matthew Wire [Wed, 8 Nov 2023 17:06:08 +0000 (17:06 +0000)]
Switch to non deprecated functions
demeritcowboy [Wed, 8 Nov 2023 16:23:00 +0000 (11:23 -0500)]
Merge pull request #28058 from civicrm/5.68
5.68
demeritcowboy [Wed, 8 Nov 2023 16:22:45 +0000 (11:22 -0500)]
Merge pull request #28057 from colemanw/angularExpunge
Angular - Expunge expired angularEx extension
demeritcowboy [Wed, 8 Nov 2023 15:20:42 +0000 (10:20 -0500)]
Merge pull request #28051 from eileenmcnaughton/import_568
dev/core#4554 Delete related Queue when user job deleted
Aidan Saunders [Tue, 10 Oct 2023 12:17:23 +0000 (13:17 +0100)]
NFC: remove old pattern
colemanw [Wed, 8 Nov 2023 14:23:15 +0000 (09:23 -0500)]
Angular - Expunge expired angularEx extension
Fixes dev/core#4758
Matthew Wire [Wed, 8 Nov 2023 12:05:37 +0000 (12:05 +0000)]
Merge pull request #27955 from eileenmcnaughton/invoic_settings
Remove more traces of the old 'contribution_invoice_settings'
Matthew Wire [Wed, 8 Nov 2023 12:01:56 +0000 (12:01 +0000)]
Merge pull request #28045 from eileenmcnaughton/cont_mode
Replace use of contributeMode with alternatives
Matthew Wire [Wed, 8 Nov 2023 11:58:13 +0000 (11:58 +0000)]
Merge pull request #28047 from eileenmcnaughton/participant_source
Consolidate source text determination
colemanw [Wed, 8 Nov 2023 11:52:34 +0000 (06:52 -0500)]
Merge pull request #28054 from eileenmcnaughton/number
Update 'Some kind of numbery-looky-printy thing.' - ie `CRM_Utils_Number::formatUnitSize`
Seamus Lee [Wed, 8 Nov 2023 07:11:05 +0000 (18:11 +1100)]
Remove karama-phantomjs-launcher as we now use chrome browser for karma tests
Eileen McNaughton [Wed, 8 Nov 2023 05:15:08 +0000 (18:15 +1300)]
Simplify CRM_Utils_Number::formatUnitSize, move check to form
Mathieu Lu [Wed, 8 Nov 2023 03:28:10 +0000 (22:28 -0500)]
Merge pull request #28046 from eileenmcnaughton/register
Simplify use of word 'Register'
Eileen McNaughton [Wed, 8 Nov 2023 02:24:27 +0000 (15:24 +1300)]
Merge pull request #28050 from eileenmcnaughton/php8
Php 8.x fix on variable
Eileen McNaughton [Wed, 8 Nov 2023 01:37:44 +0000 (14:37 +1300)]
dev/core#4554 Delete related Queue when user job deleted
Eileen McNaughton [Wed, 8 Nov 2023 01:28:58 +0000 (14:28 +1300)]
Merge pull request #28049 from eileenmcnaughton/current_mem
Remove unused property from previously shared code
Eileen McNaughton [Wed, 8 Nov 2023 01:05:52 +0000 (14:05 +1300)]
Update CRM/Profile/Selector/Listings.php
Co-authored-by: colemanw <coleman@civicrm.org>
demeritcowboy [Wed, 8 Nov 2023 00:48:59 +0000 (19:48 -0500)]
Merge pull request #28037 from ufundo/drupal8-container-ip-address
dev/core#4756 check Drupal container available to check ip address
Seamus Lee [Wed, 8 Nov 2023 00:48:02 +0000 (11:48 +1100)]
Merge pull request #28048 from eileenmcnaughton/event_ref
Remove references to not-set form _values array property 'event' from previously shared code
Eileen McNaughton [Wed, 8 Nov 2023 00:44:06 +0000 (13:44 +1300)]
Php 8.x fix on variable
Eileen McNaughton [Tue, 7 Nov 2023 23:03:20 +0000 (12:03 +1300)]
Replace use of contributeMode with alternatives
This addresses 2 places contributeMode is used
1) CRM_Contribute_BAO_Contribution::createAddress does not require this check - it
works by checking if there are appropriate params from the billing profile - which
will have been displayed on the form or not as required by the processor
2) Replaces a specific check for paypal express with a check specific to that
class name. In the process functions are added for getPaymentProcessorValue()
in keeping with recently added getEventValue() getParticipantValue() etc
Eileen McNaughton [Wed, 8 Nov 2023 00:19:59 +0000 (13:19 +1300)]
Remove unused property from previously shared code
Eileen McNaughton [Tue, 7 Nov 2023 23:43:41 +0000 (12:43 +1300)]
Remove references to not-set form _values array property 'event' from previously shared code
Eileen McNaughton [Mon, 6 Nov 2023 22:22:30 +0000 (11:22 +1300)]
Consolidate source text determination
Eileen McNaughton [Tue, 7 Nov 2023 23:19:38 +0000 (12:19 +1300)]
Merge pull request #28044 from seamuslee001/82_dynamic_property_batch
dev/core#4072 Fix Dynamic Property Errors on Batch Export
Eileen McNaughton [Tue, 7 Nov 2023 23:17:36 +0000 (12:17 +1300)]
Merge pull request #28043 from seamuslee001/test_dynamic_property
dev/core#4072 Fix Dynamic property in CiviTestListener
Eileen McNaughton [Tue, 7 Nov 2023 23:14:43 +0000 (12:14 +1300)]
Simplify use of word Register
Seamus Lee [Tue, 7 Nov 2023 22:27:01 +0000 (09:27 +1100)]
Merge pull request #28035 from civicrm/5.68
5.68
Seamus Lee [Tue, 7 Nov 2023 22:22:54 +0000 (09:22 +1100)]
Fix Dynamic Property Errors on Batch Export
Seamus Lee [Tue, 7 Nov 2023 22:14:24 +0000 (09:14 +1100)]
dev/core#4072 Fix Dynamic property in CiviTestListener
Seamus Lee [Tue, 7 Nov 2023 21:17:29 +0000 (08:17 +1100)]
Merge pull request #28040 from colemanw/angularDepNotice
[NFC] More descriptive deprecation notice for Angular settings
colemanw [Tue, 7 Nov 2023 19:49:30 +0000 (14:49 -0500)]
More descriptive deprecation notice for Angular settings
colemanw [Tue, 7 Nov 2023 18:41:30 +0000 (13:41 -0500)]
Merge pull request #28036 from demeritcowboy/case-edit
dev/core#4755 - typo causes activity type to go missing on case activity edit
colemanw [Tue, 7 Nov 2023 18:37:28 +0000 (13:37 -0500)]
Merge pull request #28024 from dontub/add-afform-field-Url
Add Afform field for input type `Url`
BW [Tue, 7 Nov 2023 15:17:02 +0000 (15:17 +0000)]
dev/core#4756 check Drupal container available to check ip address
demeritcowboy [Tue, 7 Nov 2023 14:51:54 +0000 (09:51 -0500)]
typo
demeritcowboy [Tue, 7 Nov 2023 13:59:25 +0000 (08:59 -0500)]
Merge pull request #28018 from colemanw/searchFunctionZeroBugFix
SearchKit - Fix field transformation UI to handle number 0
Matthew Wire [Tue, 7 Nov 2023 12:19:02 +0000 (12:19 +0000)]
Merge pull request #28011 from eileenmcnaughton/payment_object
PHp8.x notice fix - remove use of legacy paymentObject
Yashodha Chaku [Tue, 7 Nov 2023 12:15:40 +0000 (17:45 +0530)]
Merge pull request #28030 from eileenmcnaughton/participant_deduct
Further cleanup on previously shared participant form code
Dominic Tubach [Tue, 7 Nov 2023 08:35:44 +0000 (09:35 +0100)]
BasicGetFieldsAction: Add `Url` as option for `input_type`
Eileen McNaughton [Tue, 7 Nov 2023 07:14:00 +0000 (20:14 +1300)]
Merge pull request #28034 from eileenmcnaughton/error_verbose
Include separator text in details send to log
Eileen McNaughton [Tue, 7 Nov 2023 03:19:58 +0000 (16:19 +1300)]
Include exception, separator text in details send to log
Eileen McNaughton [Tue, 7 Nov 2023 01:29:31 +0000 (14:29 +1300)]
Merge pull request #28032 from colemanw/revertMailingIsDraft
Revert "APIv4 - Add is_draft field for mailings"
colemanw [Tue, 7 Nov 2023 00:38:59 +0000 (19:38 -0500)]
Merge pull request #28014 from kurund/afform-prefill-date
Afform - ability to set fixed or now date defaults
colemanw [Tue, 7 Nov 2023 00:12:19 +0000 (19:12 -0500)]
Revert "APIv4 - Add is_draft field for mailings"
This partially reverts commit
6565e243f275bd5f9ceea50bc58c44582d9349e9.
Eileen McNaughton [Mon, 6 Nov 2023 23:22:33 +0000 (12:22 +1300)]
Merge pull request #28031 from civicrm/5.68
5.68 to master
Eileen McNaughton [Mon, 6 Nov 2023 22:48:38 +0000 (11:48 +1300)]
Merge pull request #28029 from MegaphoneJon/deprecated-part-token
Add check for deprecated token in event online receipt
Eileen McNaughton [Mon, 6 Nov 2023 22:48:26 +0000 (11:48 +1300)]
Merge pull request #28027 from braders/php8-activity-view
[REF][PHP8.2] Update CRM_Activity_Form_ActivityView for PHP8.2 support
colemanw [Mon, 6 Nov 2023 22:32:57 +0000 (17:32 -0500)]
Merge pull request #27783 from colemanw/afformPerformance
Afform - improve loading performance
Eileen McNaughton [Mon, 6 Nov 2023 21:49:25 +0000 (10:49 +1300)]
Further cleanup on previously shared participant form
This addresses some variables that were being set in one place
& used in another. In the past this was done because the
form prepared variables for use in a shared function.
However, the previously shared code is only used by
this form now & hence can access the submitted values in
a more consisent way (not having to deal with
the values being possibly presented in a range of ways
Eileen McNaughton [Mon, 6 Nov 2023 20:48:11 +0000 (09:48 +1300)]
Merge pull request #28028 from braders/php8-case-detail-report
[REF][PHP8.2] Tidy up CRM_Report_Form_Case_Detail
Jon Goldberg [Mon, 6 Nov 2023 20:28:45 +0000 (15:28 -0500)]
Add check for deprecated token in event online receipt
colemanw [Thu, 19 Oct 2023 13:32:01 +0000 (09:32 -0400)]
Afform - Add modified_date
colemanw [Wed, 11 Oct 2023 15:37:57 +0000 (11:37 -0400)]
Afform - Improve loading performance
Before: Angular modules were not cached, afform loading was slow
After: Cache previously used for afform dependencies now used for all Angular modules
Bradley Taylor [Mon, 6 Nov 2023 19:35:49 +0000 (19:35 +0000)]
[REF][PHP8.2] Update CRM_Activity_Form_ActivityView for PHP8.2 support
Bradley Taylor [Mon, 6 Nov 2023 19:47:44 +0000 (19:47 +0000)]
[REF][PHP8.2] Tidy up CRM_Report_Form_Case_Detail
demeritcowboy [Mon, 6 Nov 2023 19:12:11 +0000 (14:12 -0500)]
Merge pull request #28023 from braders/sms-page-provider-php8.2
[REF][PHP8.2] Update CRM_SMS_Page_Provider
colemanw [Mon, 6 Nov 2023 18:16:20 +0000 (13:16 -0500)]
Merge pull request #28025 from mlutfy/zambiaProvinces
Add missing Zambia provinces
Mathieu Lu [Mon, 6 Nov 2023 15:34:33 +0000 (10:34 -0500)]
Add missing Zambia provinces
Yashodha Chaku [Mon, 6 Nov 2023 15:28:00 +0000 (20:58 +0530)]
Merge pull request #27459 from jitendrapurohit/joomla_usergrp
Add Joomla user to group when created from civi profile
Matthew Wire [Mon, 6 Nov 2023 12:43:29 +0000 (12:43 +0000)]
Merge pull request #28007 from eileenmcnaughton/part_offline_2
Follow up cleanup on multiple participant form edit
Matthew Wire [Mon, 6 Nov 2023 12:42:44 +0000 (12:42 +0000)]
Merge pull request #28020 from demeritcowboy/group-php8
[php8]] Replace undeclared class var with local var
Dominic Tubach [Mon, 6 Nov 2023 10:21:12 +0000 (11:21 +0100)]
Add Afform field for input type `Url`
Mathieu Lu [Sun, 5 Nov 2023 18:30:47 +0000 (13:30 -0500)]
Merge pull request #28019 from colemanw/mailingIsDraftField
APIv4 - Add is_draft field for mailings, fix test
Bradley Taylor [Sun, 5 Nov 2023 16:23:07 +0000 (16:23 +0000)]
[REF][PHP8.2] Update CRM_SMS_Page_Provider
colemanw [Sat, 4 Nov 2023 03:28:55 +0000 (23:28 -0400)]
APIv4 - Add is_draft field for mailings, fix test
Figuring out if a mailing is a draft or not can be tricky.
This encapsulates the tricky-ness in a reusable calculated field.
demeritcowboy [Sun, 5 Nov 2023 15:09:11 +0000 (10:09 -0500)]
Merge pull request #28022 from braders/unused-amt-props
[REF][PHP8.2] Remove unused dynamic props
Bradley Taylor [Sun, 5 Nov 2023 11:14:52 +0000 (11:14 +0000)]
[REF][PHP8.2] Remove unused dynamic props
demeritcowboy [Sat, 4 Nov 2023 14:57:29 +0000 (10:57 -0400)]
replace undeclared class var with local var
demeritcowboy [Sat, 4 Nov 2023 14:32:44 +0000 (10:32 -0400)]
Merge pull request #28016 from seamuslee001/case_form_82
[REF][PHP8.2] Fix Case_Form_TaskTest test fails on php8.2
Mathieu Lu [Sat, 4 Nov 2023 07:29:04 +0000 (03:29 -0400)]
Merge pull request #28017 from colemanw/mailingMeta
Schema - Add CiviMail field metadata
colemanw [Sat, 4 Nov 2023 02:29:15 +0000 (22:29 -0400)]
SearchKit - Fix field transformation UI to handle number 0
This is the old number 0 is falsey bug.
To reproduce, add a field transformation such as if/else,
clear the field values and select numbers.
The number zero will be treated as empty and not work.
colemanw [Sat, 4 Nov 2023 00:32:21 +0000 (20:32 -0400)]
Schema - Add CiviMail field metadata