civicrm-core.git
8 years agoMerge pull request #7376 from colemanw/contributionTable
colemanw [Thu, 3 Dec 2015 20:24:41 +0000 (15:24 -0500)]
Merge pull request #7376 from colemanw/contributionTable

CRM-17620 - Improve contribution results table layout

8 years agoFix broken table in languages other than English
Coleman Watts [Thu, 3 Dec 2015 19:41:37 +0000 (14:41 -0500)]
Fix broken table in languages other than English

Table layout was broken because code was relying on english label "Soft Credit For".
There may well be a better way to do this, but at least it's not as broken as before.

8 years agoFormat and whitespace fixes
Coleman Watts [Thu, 3 Dec 2015 19:33:42 +0000 (14:33 -0500)]
Format and whitespace fixes

8 years agoFix icons in popup buttons
Coleman Watts [Thu, 3 Dec 2015 19:26:27 +0000 (14:26 -0500)]
Fix icons in popup buttons

8 years agoCRM-17620 - Improve contribution results table layout
Coleman Watts [Thu, 3 Dec 2015 18:52:33 +0000 (13:52 -0500)]
CRM-17620 - Improve contribution results table layout

8 years agoMerge pull request #7365 from eileenmcnaughton/CRM-17653-master
colemanw [Thu, 3 Dec 2015 14:29:38 +0000 (09:29 -0500)]
Merge pull request #7365 from eileenmcnaughton/CRM-17653-master

CRM-17653 fix membership renewal to record contribution_recur_id on c…

8 years agoMerge pull request #7363 from colemanw/CRM-17620
colemanw [Thu, 3 Dec 2015 13:49:28 +0000 (08:49 -0500)]
Merge pull request #7363 from colemanw/CRM-17620

CRM-17620 - Cleanup and abstract expandRow js

8 years agoMerge pull request #7372 from yashodha/upgrade4.6.beta2
Yashodha Chaku [Thu, 3 Dec 2015 12:22:03 +0000 (17:52 +0530)]
Merge pull request #7372 from yashodha/upgrade4.6.beta2

Update version to 4.6beta2

8 years agoUpdate version to 4.6beta2
yashodha [Thu, 3 Dec 2015 12:20:28 +0000 (17:50 +0530)]
Update version to 4.6beta2

8 years agoMerge pull request #7370 from eileenmcnaughton/comments
Eileen McNaughton [Thu, 3 Dec 2015 10:38:20 +0000 (23:38 +1300)]
Merge pull request #7370 from eileenmcnaughton/comments

some comment fixes

8 years agoMerge pull request #7369 from jitendrapurohit/CRM-16597-generatedsql
Yashodha Chaku [Thu, 3 Dec 2015 10:22:13 +0000 (15:52 +0530)]
Merge pull request #7369 from jitendrapurohit/CRM-16597-generatedsql

Generated sql changes - CRM-16597

8 years agoCRM-17653 fix membership renewal to record contribution_recur_id on contribution
eileenmcnaugton [Thu, 3 Dec 2015 03:19:25 +0000 (16:19 +1300)]
CRM-17653 fix membership renewal to record contribution_recur_id on contribution

8 years agosome somment fixes
eileenmcnaughton [Thu, 3 Dec 2015 09:37:06 +0000 (09:37 +0000)]
some somment fixes

8 years agoGenerated sql changes - CRM-16597
jitendrapurohit [Thu, 3 Dec 2015 09:34:30 +0000 (15:04 +0530)]
Generated sql changes - CRM-16597

8 years agoMerge pull request #7358 from yashodha/CRM-16597
Monish Deb [Thu, 3 Dec 2015 08:24:44 +0000 (13:54 +0530)]
Merge pull request #7358 from yashodha/CRM-16597

CRM-16597: Current naming of pledge reports is very confusing and nee…

8 years agoupgrade fix
yashodha [Thu, 3 Dec 2015 07:34:54 +0000 (13:04 +0530)]
upgrade fix

8 years agofix upgrade bug
yashodha [Thu, 3 Dec 2015 06:04:42 +0000 (11:34 +0530)]
fix upgrade bug

8 years agoCRM-17620 - Convert cases to use expandRow.js
Coleman Watts [Thu, 3 Dec 2015 05:05:18 +0000 (00:05 -0500)]
CRM-17620 - Convert cases to use expandRow.js

8 years agoCleanup paperclip icon
Coleman Watts [Thu, 3 Dec 2015 04:04:44 +0000 (23:04 -0500)]
Cleanup paperclip icon

8 years agoMenu css cleanup
Coleman Watts [Thu, 3 Dec 2015 03:47:27 +0000 (22:47 -0500)]
Menu css cleanup

8 years agoCRM-17620 - Convert pledges to use expandRow.js
Coleman Watts [Thu, 3 Dec 2015 03:43:00 +0000 (22:43 -0500)]
CRM-17620 - Convert pledges to use expandRow.js

8 years agoCRM-17620 - expandRow add margin and smooth scrolling
Coleman Watts [Thu, 3 Dec 2015 03:04:10 +0000 (22:04 -0500)]
CRM-17620 - expandRow add margin and smooth scrolling

8 years agoCleanup smarty_function_crmScript
Coleman Watts [Thu, 3 Dec 2015 01:37:40 +0000 (20:37 -0500)]
Cleanup smarty_function_crmScript

8 years agoCRM-17620 - Cleanup and abstract expandRow js
Coleman Watts [Thu, 3 Dec 2015 01:34:21 +0000 (20:34 -0500)]
CRM-17620 - Cleanup and abstract expandRow js

8 years agoMerge pull request #7336 from eileenmcnaughton/CRM-17636
Dave Greenberg [Thu, 3 Dec 2015 00:49:58 +0000 (16:49 -0800)]
Merge pull request #7336 from eileenmcnaughton/CRM-17636

CRM-17636 fix for items not being recorded correctly (modified_date, … …

8 years agoMerge pull request #7356 from davecivicrm/CRM-16761
Dave Greenberg [Thu, 3 Dec 2015 00:48:02 +0000 (16:48 -0800)]
Merge pull request #7356 from davecivicrm/CRM-16761

CRM-16761 - Form / UI fixes.

8 years agoMerge pull request #7220 from ucam-dar/CRM-17556
Dave Greenberg [Thu, 3 Dec 2015 00:26:20 +0000 (16:26 -0800)]
Merge pull request #7220 from ucam-dar/CRM-17556

CRM-17556 Dedupe improvements

8 years agoMerge pull request #7362 from davecivicrm/CRM-16259
Dave Greenberg [Wed, 2 Dec 2015 23:55:11 +0000 (15:55 -0800)]
Merge pull request #7362 from davecivicrm/CRM-16259

CRM-16259 - Schema change for financial_trxn table only - add is_paym…

8 years agoCRM-16259 - Schema change for financial_trxn table only - add is_payment column.
Dave Greenberg [Wed, 2 Dec 2015 23:53:16 +0000 (15:53 -0800)]
CRM-16259 - Schema change for financial_trxn table only - add is_payment column.

----------------------------------------
* CRM-16259: Create Payment API
  https://issues.civicrm.org/jira/browse/CRM-16259

8 years agoMerge pull request #7286 from eileenmcnaughton/CRM-16929-salvage
Dave Greenberg [Wed, 2 Dec 2015 20:12:44 +0000 (12:12 -0800)]
Merge pull request #7286 from eileenmcnaughton/CRM-16929-salvage

CRM-16929 fix hiding on zero dollar contribution pages & events

8 years agoMerge pull request #7360 from monishdeb/CRM-16901
Dave Greenberg [Wed, 2 Dec 2015 18:28:18 +0000 (10:28 -0800)]
Merge pull request #7360 from monishdeb/CRM-16901

CRM-16901 fix - Offline Recurring Payments

8 years agoCRM-16761 - style fixes.
Dave Greenberg [Wed, 2 Dec 2015 18:15:47 +0000 (10:15 -0800)]
CRM-16761 - style fixes.

----------------------------------------
* CRM-16761: Self service view, update and cancel for CiviEvent
  https://issues.civicrm.org/jira/browse/CRM-16761

8 years agoCRM-16901 fix - Offline Recurring Payments
monishdeb [Wed, 2 Dec 2015 14:49:57 +0000 (20:19 +0530)]
CRM-16901 fix - Offline Recurring Payments

https://issues.civicrm.org/jira/browse/CRM-16901

8 years agoMerge pull request #7359 from JKingsnorth/mailing-bao-mailing-comments
colemanw [Wed, 2 Dec 2015 14:30:00 +0000 (09:30 -0500)]
Merge pull request #7359 from JKingsnorth/mailing-bao-mailing-comments

Mailing BAO comment improvements

8 years agoMailing BAO comment improvements
JKingsnorth [Wed, 2 Dec 2015 13:34:06 +0000 (13:34 +0000)]
Mailing BAO comment improvements

8 years agoCRM-16597: Current naming of pledge reports is very confusing and needs to be changed
yashodha [Wed, 2 Dec 2015 10:22:17 +0000 (15:52 +0530)]
CRM-16597: Current naming of pledge reports is very confusing and needs to be changed

----------------------------------------
* CRM-16597: Current naming of pledge reports is very confusing and needs to be changed.
  https://issues.civicrm.org/jira/browse/CRM-16597

8 years agoMerge pull request #7335 from eileenmcnaughton/CRM-17635
Eileen McNaughton [Wed, 2 Dec 2015 07:08:35 +0000 (20:08 +1300)]
Merge pull request #7335 from eileenmcnaughton/CRM-17635

CRM-17635 show option to email for autorenew memberships

8 years agoCRM-16929 fix hiding on zero dollar contribution pages & events
eileen [Tue, 24 Nov 2015 04:48:09 +0000 (17:48 +1300)]
CRM-16929 fix hiding on zero dollar contribution pages & events

Change-Id: I204b087279a8d5170057b1e2b06d57ed1508127f

8 years agoMerge pull request #7345 from rohankatkar/MASTER_WEBTESTS
Kurund Jalmi [Wed, 2 Dec 2015 05:13:53 +0000 (10:43 +0530)]
Merge pull request #7345 from rohankatkar/MASTER_WEBTESTS

Webtests fixes- master

8 years agoMerge pull request #7348 from eileenmcnaughton/CRM-17644
Eileen McNaughton [Wed, 2 Dec 2015 05:00:19 +0000 (18:00 +1300)]
Merge pull request #7348 from eileenmcnaughton/CRM-17644

CRM-17644 fix caching on tax rates to still cache if none set

8 years agoCRM-16761 - Form / UI fixes.
Dave Greenberg [Wed, 2 Dec 2015 04:46:13 +0000 (20:46 -0800)]
CRM-16761 - Form / UI fixes.

----------------------------------------
* CRM-16761: Self service view, update and cancel for CiviEvent
  https://issues.civicrm.org/jira/browse/CRM-16761

8 years agoMerge pull request #7353 from eileenmcnaughton/master
Eileen McNaughton [Wed, 2 Dec 2015 04:26:56 +0000 (17:26 +1300)]
Merge pull request #7353 from eileenmcnaughton/master

fix missing param in comment

8 years agoCRM-17644 fix caching on tax rates to still cache if none set
eileen [Tue, 1 Dec 2015 17:38:37 +0000 (06:38 +1300)]
CRM-17644 fix caching on tax rates to still cache if none set

Change-Id: I9cbfc19a50e5848fc7ec0a6448929558b3f46fe4

8 years agofix missing param in comment
eileen [Wed, 2 Dec 2015 02:11:47 +0000 (15:11 +1300)]
fix missing param in comment

8 years agocrm-public fix select2 height
Coleman Watts [Wed, 2 Dec 2015 01:34:45 +0000 (20:34 -0500)]
crm-public fix select2 height

8 years agoMerge pull request #7346 from eileenmcnaughton/CRM-17640
colemanw [Tue, 1 Dec 2015 19:06:18 +0000 (14:06 -0500)]
Merge pull request #7346 from eileenmcnaughton/CRM-17640

CRM-17640 Update contribution api to do a sensible query when doing getcount

8 years agoMerge pull request #7349 from guanhuan/master
colemanw [Tue, 1 Dec 2015 18:59:26 +0000 (13:59 -0500)]
Merge pull request #7349 from guanhuan/master

Add crm-public-form-item class to contribution page and add possibility to style profiles consistently

8 years agoMerge pull request #7344 from monishdeb/CRM-16901
Dave Greenberg [Tue, 1 Dec 2015 18:53:46 +0000 (10:53 -0800)]
Merge pull request #7344 from monishdeb/CRM-16901

CRM-16901 fix - Offline Recurring Payments

8 years agoAdd crm-public-form-item class to contribution page and add possibility to style...
Guanhuan Chen [Tue, 1 Dec 2015 18:11:13 +0000 (18:11 +0000)]
Add crm-public-form-item class to contribution page and add possibility to style profiles consistently

8 years agoMerge pull request #7343 from rohankatkar/CRM_16761_Webtest
colemanw [Tue, 1 Dec 2015 16:54:08 +0000 (11:54 -0500)]
Merge pull request #7343 from rohankatkar/CRM_16761_Webtest

Webtest - CRM-16761

8 years agoMerge pull request #7296 from eileenmcnaughton/CRM-17620
colemanw [Tue, 1 Dec 2015 16:52:21 +0000 (11:52 -0500)]
Merge pull request #7296 from eileenmcnaughton/CRM-17620

CRM-17620 expose payment data for contributions in the UI

8 years agoa couple more comments
eileen [Tue, 1 Dec 2015 16:35:52 +0000 (05:35 +1300)]
a couple more comments

8 years agoCRM-17640 add follow up comments to discourage random brutal attacks on site performance
eileen [Tue, 1 Dec 2015 16:05:53 +0000 (05:05 +1300)]
CRM-17640 add follow up comments to discourage random brutal attacks on site performance

8 years agoCRM-17640 re-use contact apiQuery for contribution
eileen [Tue, 1 Dec 2015 15:32:10 +0000 (04:32 +1300)]
CRM-17640 re-use contact apiQuery for contribution

8 years agoCRM-17640 Update contribution api to do a sensible query when getcount is being invoked
eileen [Tue, 1 Dec 2015 13:56:20 +0000 (02:56 +1300)]
CRM-17640 Update contribution api to do a sensible query when getcount is being invoked

Without this patch contribution.getcount api does a full query with the full set of select fields and
the nasty joins those entail and only after doing that does it filter for count.

This patch re-uses the code in use for contact api query for contribution getcount

8 years agoWebtests fixes- master
Web Access [Tue, 1 Dec 2015 13:10:50 +0000 (18:40 +0530)]
Webtests fixes- master

8 years agoMerge pull request #7342 from eileenmcnaughton/CRM-17611
Monish Deb [Tue, 1 Dec 2015 11:56:47 +0000 (17:26 +0530)]
Merge pull request #7342 from eileenmcnaughton/CRM-17611

CRM-17611 do not set dummy trxn_id on declines and do not attempt to …

8 years agoupgrade fix
monishdeb [Tue, 1 Dec 2015 10:52:34 +0000 (16:22 +0530)]
upgrade fix

8 years agoMerge pull request #7341 from jitendrapurohit/CRM-17642
Monish Deb [Tue, 1 Dec 2015 10:26:16 +0000 (15:56 +0530)]
Merge pull request #7341 from jitendrapurohit/CRM-17642

CRM-17642 -- Accounting Batch Transactions page seems to be missing s…

8 years agoMinor changes to test
Web Access [Tue, 1 Dec 2015 10:25:21 +0000 (15:55 +0530)]
Minor changes to test

8 years agoWebtest - CRM-16761
Web Access [Tue, 1 Dec 2015 10:04:31 +0000 (15:34 +0530)]
Webtest - CRM-16761

8 years agoCRM-16901 fix - Offline Recurring Payments
monishdeb [Tue, 1 Dec 2015 10:04:08 +0000 (15:34 +0530)]
CRM-16901 fix - Offline Recurring Payments

https://issues.civicrm.org/jira/browse/CRM-16901

8 years agoCRM-17611 do not set dummy trxn_id on declines and do not attempt to validate non...
eileenmcnaugton [Sun, 22 Nov 2015 23:56:46 +0000 (12:56 +1300)]
CRM-17611 do not set dummy trxn_id on declines and do not attempt to validate non-existent trxn_id

Conflicts:
CRM/Core/Payment/AuthorizeNetIPN.php

8 years agoMerge pull request #7339 from civicrm/eileenmcnaughton-patch-1
Eileen McNaughton [Tue, 1 Dec 2015 07:20:01 +0000 (20:20 +1300)]
Merge pull request #7339 from civicrm/eileenmcnaughton-patch-1

Remove odd language construct

8 years agoMerge pull request #7098 from seamuslee001/CRM-17471
Eileen McNaughton [Tue, 1 Dec 2015 06:59:07 +0000 (19:59 +1300)]
Merge pull request #7098 from seamuslee001/CRM-17471

CRM-17471 Add test to prove the bug

8 years agoCRM-17642 -- Accounting Batch Transactions page seems to be missing some info
jitendrapurohit [Tue, 1 Dec 2015 06:31:36 +0000 (12:01 +0530)]
CRM-17642 -- Accounting Batch Transactions page seems to be missing some info

8 years agoCRM-17620 expose payment data for contributions in the UI
eileen [Wed, 25 Nov 2015 00:02:15 +0000 (13:02 +1300)]
CRM-17620 expose payment data for contributions in the UI

8 years agoMerge pull request #7332 from colemanw/CRM-14272
colemanw [Tue, 1 Dec 2015 01:01:30 +0000 (20:01 -0500)]
Merge pull request #7332 from colemanw/CRM-14272

CRM-14272 - Fix inherited membership relationship date handling

8 years agoMerge pull request #7326 from monishdeb/CRM-16901
Dave Greenberg [Mon, 30 Nov 2015 22:11:20 +0000 (14:11 -0800)]
Merge pull request #7326 from monishdeb/CRM-16901

CRM-16901 Offline Recurring Payments

8 years agoMerge pull request #7334 from colemanw/D8
colemanw [Mon, 30 Nov 2015 19:49:20 +0000 (14:49 -0500)]
Merge pull request #7334 from colemanw/D8

D8 - Fix url function

8 years agoMerge pull request #7327 from jitendrapurohit/CRM-13678
Kurund Jalmi [Mon, 30 Nov 2015 10:34:12 +0000 (16:04 +0530)]
Merge pull request #7327 from jitendrapurohit/CRM-13678

CRM-13678 - Make tabset hook generic

8 years agominor fix
jitendrapurohit [Mon, 30 Nov 2015 09:58:16 +0000 (15:28 +0530)]
minor fix

8 years agoCRM-17636 fix for items not being recorded correctly (modified_date, invoice_id,...
eileenmcnaughton [Mon, 30 Nov 2015 05:40:50 +0000 (05:40 +0000)]
CRM-17636 fix for items not being recorded correctly (modified_date, invoice_id, is_email_receipt. Partial fix on contribution_status_id - covers setting to pending but not yet updating to In Progress

8 years agoundo tabset changes for Contact Summary page
jitendrapurohit [Mon, 30 Nov 2015 06:11:33 +0000 (11:41 +0530)]
undo tabset changes for Contact Summary page

8 years agoCRM-17636 tests for information on renewal form being recorded correctly
eileenmcnaughton [Mon, 30 Nov 2015 05:38:57 +0000 (05:38 +0000)]
CRM-17636 tests for information on renewal form being recorded correctly

This does not cover all the incorrect data - some items that are not yet passing are commented out

8 years agoCRM-14272 - Fix inherited membership relationship date handling
Coleman Watts [Sun, 29 Nov 2015 22:44:31 +0000 (17:44 -0500)]
CRM-14272 - Fix inherited membership relationship date handling

8 years agoConvert to old array syntax for the sake of jenkins
Coleman Watts [Mon, 30 Nov 2015 03:15:35 +0000 (22:15 -0500)]
Convert to old array syntax for the sake of jenkins

8 years agoCRM-17635 add comment about recur receipt
eileenmcnaugton [Mon, 30 Nov 2015 02:56:57 +0000 (15:56 +1300)]
CRM-17635 add comment about recur receipt

8 years agoCRM-17635 show option to email for autorenew memberships
eileenmcnaugton [Mon, 30 Nov 2015 01:42:03 +0000 (14:42 +1300)]
CRM-17635 show option to email for autorenew memberships

8 years agoUpdate docblocks
Coleman Watts [Mon, 30 Nov 2015 02:13:57 +0000 (21:13 -0500)]
Update docblocks

8 years agoD8 - Fix url function
Coleman Watts [Mon, 30 Nov 2015 00:12:32 +0000 (19:12 -0500)]
D8 - Fix url function

8 years agoMerge pull request #7333 from kcristiano/CRM-14987
colemanw [Sun, 29 Nov 2015 23:27:38 +0000 (18:27 -0500)]
Merge pull request #7333 from kcristiano/CRM-14987

CRM-14987 add commented out option for CIVICRM_CMSDIR

8 years agoCRM-14987 add commented out option for CIVICRM_CMSDIR
Kevin Cristiano [Sun, 29 Nov 2015 23:20:20 +0000 (18:20 -0500)]
CRM-14987 add commented out option for CIVICRM_CMSDIR

----------------------------------------
* CRM-14987: WordPress cmsRootPath can incorrectly return unrelated CMS install
  https://issues.civicrm.org/jira/browse/CRM-14987

8 years agoMerge pull request #7324 from kcristiano/CRM16408
colemanw [Sun, 29 Nov 2015 19:26:37 +0000 (14:26 -0500)]
Merge pull request #7324 from kcristiano/CRM16408

CRM-16408 add back  block for all non-wp CMS.  Correction PR 6807

8 years agoMerge pull request #7331 from colemanw/css
colemanw [Sun, 29 Nov 2015 18:58:43 +0000 (13:58 -0500)]
Merge pull request #7331 from colemanw/css

CRM-17634 - Remove unused css

8 years agoCRM-17634 - Remove unused icon
Coleman Watts [Sun, 29 Nov 2015 18:56:02 +0000 (13:56 -0500)]
CRM-17634 - Remove unused icon

8 years agoMerge pull request #7318 from JKingsnorth/CRM-17626
colemanw [Sun, 29 Nov 2015 15:52:40 +0000 (10:52 -0500)]
Merge pull request #7318 from JKingsnorth/CRM-17626

CRM-17626 Move BULK_MAIL_INSERT_COUNT

8 years agoRemove unused Gcc files
Coleman Watts [Sun, 29 Nov 2015 15:34:01 +0000 (10:34 -0500)]
Remove unused Gcc files

8 years agoCRM-17634 - Remove unused css
Coleman Watts [Sun, 29 Nov 2015 15:27:09 +0000 (10:27 -0500)]
CRM-17634 - Remove unused css

8 years agoMerge pull request #7328 from rohankatkar/WEBTESTS_FIXES_MASTER
Kurund Jalmi [Sat, 28 Nov 2015 05:44:50 +0000 (11:14 +0530)]
Merge pull request #7328 from rohankatkar/WEBTESTS_FIXES_MASTER

Webtests

8 years agoMerge pull request #7330 from colemanw/classApi
colemanw [Sat, 28 Nov 2015 03:00:29 +0000 (22:00 -0500)]
Merge pull request #7330 from colemanw/classApi

Update class.api to send params as json

8 years agoMinor cleanup
Coleman Watts [Sat, 28 Nov 2015 02:53:07 +0000 (21:53 -0500)]
Minor cleanup

8 years agoRemove unused function
Coleman Watts [Sat, 28 Nov 2015 02:09:44 +0000 (21:09 -0500)]
Remove unused function

8 years agoUpdate class.api to send params as json
Coleman Watts [Fri, 27 Nov 2015 19:12:25 +0000 (14:12 -0500)]
Update class.api to send params as json

8 years agoMerge pull request #7297 from jitendrapurohit/selfservice
Dave Greenberg [Fri, 27 Nov 2015 17:47:11 +0000 (09:47 -0800)]
Merge pull request #7297 from jitendrapurohit/selfservice

CRM-16761 -- Self service view, update and cancel for CiviEvent

8 years agoMerge pull request #7329 from lcdservices/CRM-17524
colemanw [Fri, 27 Nov 2015 16:00:15 +0000 (11:00 -0500)]
Merge pull request #7329 from lcdservices/CRM-17524

CRM-17524 additional fix to joomla user record display

8 years agoCRM-17524 additional fix to joomla user record display
Brian Shaughnessy [Fri, 27 Nov 2015 15:47:44 +0000 (10:47 -0500)]
CRM-17524 additional fix to joomla user record display

8 years agoWebtests
Web Access [Fri, 27 Nov 2015 13:18:56 +0000 (18:48 +0530)]
Webtests

8 years agostyle fixes
jitendrapurohit [Fri, 27 Nov 2015 11:47:55 +0000 (17:17 +0530)]
style fixes

8 years agoformat fixes
monishdeb [Fri, 27 Nov 2015 11:37:12 +0000 (17:07 +0530)]
format fixes