civicrm-core.git
14 months agoReplace email smarty var with token
Eileen McNaughton [Sun, 24 Sep 2023 20:59:47 +0000 (09:59 +1300)]
Replace email smarty var with token

This replaces the variable email with the appropriate smarty token

I spent some time tracking back the various contact ID & email refs
but concluded this value would always be the participant email, with
is assigned as contact to the tokens.

14 months agoMerge pull request #27619 from larssandergreen/Delete-unused-smarty-blocks
Eileen McNaughton [Sun, 24 Sep 2023 20:51:02 +0000 (09:51 +1300)]
Merge pull request #27619 from larssandergreen/Delete-unused-smarty-blocks

Delete unused Smarty block serialize

14 months agoDelete block.serialize.php
larssandergreen [Sun, 24 Sep 2023 18:51:37 +0000 (12:51 -0600)]
Delete block.serialize.php

14 months agoMerge pull request #27620 from larssandergreen/Fix-coding-error-in-#27604
colemanw [Sun, 24 Sep 2023 18:50:01 +0000 (14:50 -0400)]
Merge pull request #27620 from larssandergreen/Fix-coding-error-in-#27604

dev/core#4146 Fix coding error in #27604

14 months agoMerge pull request #27622 from larssandergreen/Fix-broken-help-for-edit-pledge
colemanw [Sun, 24 Sep 2023 18:49:10 +0000 (14:49 -0400)]
Merge pull request #27622 from larssandergreen/Fix-broken-help-for-edit-pledge

Fix broken help for edit pledge

14 months agoFix broken help for edit pledge
larssandergreen [Sun, 24 Sep 2023 17:14:13 +0000 (11:14 -0600)]
Fix broken help for edit pledge

14 months agoFix coding error in #27604
larssandergreen [Sun, 24 Sep 2023 16:31:06 +0000 (10:31 -0600)]
Fix coding error in #27604

14 months agoMerge pull request #27609 from eileenmcnaughton/no_req
colemanw [Sun, 24 Sep 2023 16:18:58 +0000 (12:18 -0400)]
Merge pull request #27609 from eileenmcnaughton/no_req

Stop passing unused parameter

14 months agoMerge pull request #27606 from eileenmcnaughton/online_pending
colemanw [Sun, 24 Sep 2023 15:17:14 +0000 (11:17 -0400)]
Merge pull request #27606 from eileenmcnaughton/online_pending

Remove always-same parameter from function signature

14 months agoMerge pull request #27587 from eileenmcnaughton/smarty_mod
colemanw [Sun, 24 Sep 2023 15:10:26 +0000 (11:10 -0400)]
Merge pull request #27587 from eileenmcnaughton/smarty_mod

dev/core##4146 Add instance of smarty modifier to prevent errors when running smarty 3

14 months agoMerge pull request #27614 from eileenmcnaughton/role_token
colemanw [Sun, 24 Sep 2023 10:17:54 +0000 (06:17 -0400)]
Merge pull request #27614 from eileenmcnaughton/role_token

Fix a couple more places to use tokens participant role

14 months agoFix a couple more places to use tokens
Eileen McNaughton [Thu, 21 Sep 2023 19:03:12 +0000 (07:03 +1200)]
Fix a couple more places to use tokens

I could make no sense of the whole default role ID thing

I removed it

14 months agoMerge pull request #27598 from eileenmcnaughton/offline
colemanw [Sun, 24 Sep 2023 02:14:43 +0000 (22:14 -0400)]
Merge pull request #27598 from eileenmcnaughton/offline

[php8] Swap out some tpl variables for tokens in offline receipt template

14 months agoMerge pull request #27605 from eileenmcnaughton/part_trait
colemanw [Sun, 24 Sep 2023 01:35:13 +0000 (21:35 -0400)]
Merge pull request #27605 from eileenmcnaughton/part_trait

Flatten array

14 months agoMerge pull request #27604 from larssandergreen/Fix-Smarty-3-broken-help
Eileen McNaughton [Sat, 23 Sep 2023 23:33:02 +0000 (12:33 +1300)]
Merge pull request #27604 from larssandergreen/Fix-Smarty-3-broken-help

dev/core##4146 Fix Smarty 3 broken help

14 months agoMerge pull request #27607 from braders/dead-code-checkSQLConstraint
colemanw [Sat, 23 Sep 2023 22:37:28 +0000 (18:37 -0400)]
Merge pull request #27607 from braders/dead-code-checkSQLConstraint

Remove dead code - checkSQLConstraint functions

14 months agoStop passing unused parameter
Eileen McNaughton [Sat, 23 Sep 2023 21:45:59 +0000 (10:45 +1300)]
Stop passing unused parameter

14 months agoSwap out some tpl variables for tokens
Eileen McNaughton [Sat, 23 Sep 2023 10:06:38 +0000 (22:06 +1200)]
Swap out some tpl variables for tokens

These ones are all pretty routine / been done in other templates

14 months agoRemove dead code - checkSQLConstraint functions
Bradley Taylor [Sat, 23 Sep 2023 21:14:27 +0000 (22:14 +0100)]
Remove dead code - checkSQLConstraint functions

14 months agoRemove always-same parameter from function signature
Eileen McNaughton [Sat, 23 Sep 2023 21:11:31 +0000 (10:11 +1300)]
Remove always-same parameter from function signature

This function is only ever called with the component event. Removing that parameter makes is clearer
what (how little) it is doing

14 months agoFlatten array
Eileen McNaughton [Sat, 23 Sep 2023 20:52:51 +0000 (09:52 +1300)]
Flatten array

This array is being built up with an unnecessary layer

14 months agoMerge pull request #27601 from eileenmcnaughton/admin
colemanw [Sat, 23 Sep 2023 20:28:12 +0000 (16:28 -0400)]
Merge pull request #27601 from eileenmcnaughton/admin

Require all fields in signature, as always passed

14 months agoMerge pull request #27603 from braders/dedupemerge-null
colemanw [Sat, 23 Sep 2023 20:17:41 +0000 (16:17 -0400)]
Merge pull request #27603 from braders/dedupemerge-null

[NFC] Proper syntax for null in DedupeMerge

14 months agoMerge pull request #27585 from eileenmcnaughton/smarty_compat
colemanw [Sat, 23 Sep 2023 18:19:16 +0000 (14:19 -0400)]
Merge pull request #27585 from eileenmcnaughton/smarty_compat

dev/core##4146 Add Smarty3 Compatibility helper

14 months agoMerge pull request #27588 from eileenmcnaughton/smarty_package
colemanw [Sat, 23 Sep 2023 18:11:52 +0000 (14:11 -0400)]
Merge pull request #27588 from eileenmcnaughton/smarty_package

dev/core##4146 Remove our override of Smartyv2 fetch function

14 months agoPass in title htxt id instead of assigning so it works in Smarty 3
larssandergreen [Sat, 23 Sep 2023 17:49:06 +0000 (11:49 -0600)]
Pass in title htxt id instead of assigning so it works in Smarty 3

14 months agoMerge pull request #27597 from eileenmcnaughton/fix_loop
colemanw [Sat, 23 Sep 2023 17:48:07 +0000 (13:48 -0400)]
Merge pull request #27597 from eileenmcnaughton/fix_loop

Remove undeclared properties `_contributorEmail`, `_toDoNotEmail` from participant form

14 months agoMerge pull request #27602 from eileenmcnaughton/text_receipts
colemanw [Sat, 23 Sep 2023 17:33:45 +0000 (13:33 -0400)]
Merge pull request #27602 from eileenmcnaughton/text_receipts

Simplify formatting in text versions of workflow messages

14 months ago[NFC] Proper syntax for null in DedupeMerge
Bradley Taylor [Sat, 23 Sep 2023 17:06:21 +0000 (18:06 +0100)]
[NFC] Proper syntax for null in DedupeMerge

14 months agoSimplify formatting in text versions of workflow messages
Eileen McNaughton [Sat, 23 Sep 2023 12:34:59 +0000 (00:34 +1200)]
Simplify formatting in text versions of workflow messages

14 months agoSimplify a couple of lines of code
Eileen McNaughton [Sat, 23 Sep 2023 12:01:25 +0000 (00:01 +1200)]
Simplify a couple of lines of code

14 months agoRequire all fields in signature, as always passed
Eileen McNaughton [Sat, 23 Sep 2023 11:55:05 +0000 (23:55 +1200)]
Require all fields in signature, as always passed

14 months agoMerge pull request #27599 from braders/error-policy-properties
Eileen McNaughton [Sat, 23 Sep 2023 11:34:58 +0000 (23:34 +1200)]
Merge pull request #27599 from braders/error-policy-properties

[REF][PHP8.2] Declare properties in CRM_Queue_ErrorPolicy

14 months ago[REF][PHP8.2] Declare properties in CRM_Queue_ErrorPolicy
Bradley Taylor [Sat, 23 Sep 2023 10:38:11 +0000 (11:38 +0100)]
[REF][PHP8.2] Declare properties in CRM_Queue_ErrorPolicy

14 months agoRemove undeclared properties contributorEmai, toDoNotEmail from participant form
Eileen McNaughton [Sat, 23 Sep 2023 08:40:17 +0000 (20:40 +1200)]
Remove undeclared properties contributorEmai, toDoNotEmail from participant form

We can use getContactValue to look them up in a cached way as appropriate

14 months agoMerge pull request #27547 from larssandergreen/More-Smarty-3+-prep
Eileen McNaughton [Sat, 23 Sep 2023 04:22:59 +0000 (16:22 +1200)]
Merge pull request #27547 from larssandergreen/More-Smarty-3+-prep

dev/core##4146 [NFC] More Smarty 3+ prep, mostly quoting strings and removing backticks

14 months agoFix Administer Custom Field Groups in AdminUI for Smarty 3
larssandergreen [Sat, 23 Sep 2023 03:37:39 +0000 (21:37 -0600)]
Fix Administer Custom Field Groups in AdminUI for Smarty 3

14 months agoMerge pull request #27590 from eileenmcnaughton/template_again
Eileen McNaughton [Sat, 23 Sep 2023 03:26:02 +0000 (15:26 +1200)]
Merge pull request #27590 from eileenmcnaughton/template_again

Fix those pesky field notices ...again

14 months agoSmarty backticks fixes, etc
larssandergreen [Sat, 23 Sep 2023 03:11:29 +0000 (21:11 -0600)]
Smarty backticks fixes, etc

14 months agoMerge pull request #27589 from eileenmcnaughton/help_fix
Eileen McNaughton [Sat, 23 Sep 2023 03:00:30 +0000 (15:00 +1200)]
Merge pull request #27589 from eileenmcnaughton/help_fix

Stop accessng _tpl_vars in smarty from property

14 months agoFix those pesky field notices ...again
Eileen McNaughton [Sat, 23 Sep 2023 02:12:10 +0000 (14:12 +1200)]
Fix those pesky field notices ...again

14 months agoStop accessng _tpl_vars in smarty from property
Eileen McNaughton [Sat, 23 Sep 2023 02:02:50 +0000 (14:02 +1200)]
Stop accessng _tpl_vars in smarty from property

it's bad practice & it hard fails in smartyv3

14 months agoRemove our override of Smartyv2 fetch function
Eileen McNaughton [Sat, 23 Sep 2023 01:50:58 +0000 (13:50 +1200)]
Remove our override of Smartyv2 fetch function

14 months agoAdd Smarty3 Compatibility helper
Eileen McNaughton [Sat, 23 Sep 2023 00:51:30 +0000 (12:51 +1200)]
Add Smarty3 Compatibility helper

14 months agoAdd instance of smarty modifier to prevent errors when running smarty 3
Eileen McNaughton [Sat, 23 Sep 2023 01:30:23 +0000 (13:30 +1200)]
Add instance of smarty modifier to prevent errors when running smarty 3

14 months agoMerge pull request #27526 from eileenmcnaughton/hook
Tim Otten [Sat, 23 Sep 2023 00:20:20 +0000 (17:20 -0700)]
Merge pull request #27526 from eileenmcnaughton/hook

(dev/core#4490) Queues - Add setting and hook to pause/resume background-queues

14 months agoMerge pull request #27584 from colemanw/smartyEval
Eileen McNaughton [Fri, 22 Sep 2023 23:47:34 +0000 (11:47 +1200)]
Merge pull request #27584 from colemanw/smartyEval

dev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty

14 months agoMerge pull request #27578 from eileenmcnaughton/offline_e
Eileen McNaughton [Fri, 22 Sep 2023 23:32:54 +0000 (11:32 +1200)]
Merge pull request #27578 from eileenmcnaughton/offline_e

Fix undefined property on fromEmails for Participant fee

14 months agodev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty
colemanw [Fri, 22 Sep 2023 23:13:20 +0000 (19:13 -0400)]
dev/core#4618 - Update APIv3 explorer to not encourage php-eval in smarty

14 months agoMerge pull request #27553 from colemanw/afformPhp
Tim Otten [Fri, 22 Sep 2023 23:07:55 +0000 (16:07 -0700)]
Merge pull request #27553 from colemanw/afformPhp

dev/core#2396 - Read afform defn from .aff.php files

14 months agoFix undefined property on fromEmails for Participant fee
Eileen McNaughton [Fri, 22 Sep 2023 21:43:36 +0000 (09:43 +1200)]
Fix undefined property on fromEmails for Participant fee

14 months agoMerge pull request #27580 from civicrm/5.66
Seamus Lee [Fri, 22 Sep 2023 22:14:26 +0000 (08:14 +1000)]
Merge pull request #27580 from civicrm/5.66

5.66

14 months agoThe Battle of the Synonyms was put on-hold.
Tim Otten [Fri, 22 Sep 2023 21:43:47 +0000 (14:43 -0700)]
The Battle of the Synonyms was put on-hold.

With the recent update, it fires a hook, and the hook-data describes the
queue-status as "deferred".

But the setting which drives it is called "queue_suspended".

Which word is better?  On reflection...  neither!

In CiviMail, there's some existing functionality where you can "pause" a
mail-blast.  And it's basically the same thing: we keep the queue-data, but
we tell the workers to temporarily refrain from execution.  And that's fine.
"Pausing" sounds less scary...

14 months agoMerge pull request #27574 from demeritcowboy/sixhundred
Eileen McNaughton [Fri, 22 Sep 2023 21:51:09 +0000 (09:51 +1200)]
Merge pull request #27574 from demeritcowboy/sixhundred

[NFC] Partial backport of 0c1d533c to avoid random test fails

14 months agoMerge pull request #27573 from alifrumin/5.66rn
Eileen McNaughton [Fri, 22 Sep 2023 21:50:37 +0000 (09:50 +1200)]
Merge pull request #27573 from alifrumin/5.66rn

[NFC] 5.66 release notes

14 months agoQueue::isActive() - Use the latest value of the setting
Tim Otten [Fri, 22 Sep 2023 21:40:55 +0000 (14:40 -0700)]
Queue::isActive() - Use the latest value of the setting

14 months agoMerge pull request #27530 from eileenmcnaughton/misc
demeritcowboy [Fri, 22 Sep 2023 20:58:15 +0000 (16:58 -0400)]
Merge pull request #27530 from eileenmcnaughton/misc

php8.x Fix notice from adding esm_loader to wrong settings form

14 months agoMerge pull request #27576 from colemanw/enter
colemanw [Fri, 22 Sep 2023 20:09:38 +0000 (16:09 -0400)]
Merge pull request #27576 from colemanw/enter

SearchKit - Save In-place edit when pressing enter

14 months agoExt - Convert *.aff.json files to *.aff.php
colemanw [Fri, 22 Sep 2023 13:47:58 +0000 (09:47 -0400)]
Ext - Convert *.aff.json files to *.aff.php

Used a bunch of regexes to convert file formats
The new format allows titles, labels, etc to be translatable.

14 months agoMerge pull request #27563 from eileenmcnaughton/pro
colemanw [Fri, 22 Sep 2023 19:53:38 +0000 (15:53 -0400)]
Merge pull request #27563 from eileenmcnaughton/pro

Remove unreachable code

14 months agoSearchKit - Save In-place edit when pressing enter
colemanw [Fri, 22 Sep 2023 19:31:45 +0000 (15:31 -0400)]
SearchKit - Save In-place edit when pressing enter

14 months agoavoid random test fails
demeritcowboy [Fri, 22 Sep 2023 17:41:41 +0000 (13:41 -0400)]
avoid random test fails

14 months agoMerge pull request #27572 from larssandergreen/Delete-unneeded-test-file
demeritcowboy [Fri, 22 Sep 2023 17:39:23 +0000 (13:39 -0400)]
Merge pull request #27572 from larssandergreen/Delete-unneeded-test-file

Remove unintentionally added test file

14 months ago[NFC] 5.66 release notes
Alice Frumin [Tue, 19 Sep 2023 15:26:57 +0000 (11:26 -0400)]
[NFC] 5.66 release notes

14 months agoRemove unintentionally added test file
larssandergreen [Fri, 22 Sep 2023 15:23:37 +0000 (09:23 -0600)]
Remove unintentionally added test file

14 months agoAfform - Read afform defn from .aff.php files as well as .aff.json
colemanw [Thu, 21 Sep 2023 23:16:46 +0000 (19:16 -0400)]
Afform - Read afform defn from .aff.php files as well as .aff.json

By switching the file format, defn fields like `title` and `description` can be wrapped in ts().
This is intended for developers and extensions authors. They can generate these php files by calling `Afform.get`
with the api explorer, and copying the result (minus the "layout" field).
FormBuilder still saves files locally in `aff.json` format.
Overriding a packaged `.aff.php` form with a local `aff.json` works fine.

14 months agoMerge pull request #27571 from civicrm/5.66
demeritcowboy [Fri, 22 Sep 2023 13:10:23 +0000 (09:10 -0400)]
Merge pull request #27571 from civicrm/5.66

5.66

14 months agoMerge pull request #27567 from eileenmcnaughton/action
demeritcowboy [Fri, 22 Sep 2023 12:36:33 +0000 (08:36 -0400)]
Merge pull request #27567 from eileenmcnaughton/action

Loosen action typing - doing nothing is doing something

14 months agoMerge pull request #27560 from eileenmcnaughton/event_type
colemanw [Fri, 22 Sep 2023 12:26:31 +0000 (08:26 -0400)]
Merge pull request #27560 from eileenmcnaughton/event_type

Stop using undefined properties to specify custom data extends values

14 months agoMerge pull request #27566 from eileenmcnaughton/price
demeritcowboy [Fri, 22 Sep 2023 12:26:03 +0000 (08:26 -0400)]
Merge pull request #27566 from eileenmcnaughton/price

Fix weight values on PriceSet page

14 months agoMerge pull request #27316 from lemniscus/oauth-session-token
colemanw [Fri, 22 Sep 2023 12:04:23 +0000 (08:04 -0400)]
Merge pull request #27316 from lemniscus/oauth-session-token

Implement OAuthSessionToken

14 months agoMerge pull request #27570 from jensschuppe/financialItemEntityTableCampaign
colemanw [Fri, 22 Sep 2023 12:00:19 +0000 (08:00 -0400)]
Merge pull request #27570 from jensschuppe/financialItemEntityTableCampaign

Allow `civicrm_campaign` as `entity_table` for `FinancialItem` API entity

14 months agoMerge pull request #27568 from eileenmcnaughton/petition
colemanw [Fri, 22 Sep 2023 11:58:58 +0000 (07:58 -0400)]
Merge pull request #27568 from eileenmcnaughton/petition

Fix notice on 'new petition' page

14 months agoAllow `civicrm_campaign` as `entity_table` for `FinancialItem` API entity
Jens Schuppe [Fri, 22 Sep 2023 09:39:15 +0000 (11:39 +0200)]
Allow `civicrm_campaign` as `entity_table` for `FinancialItem` API entity

14 months agoFix notice on 'new petition' page
Eileen McNaughton [Fri, 22 Sep 2023 08:11:06 +0000 (20:11 +1200)]
Fix notice on 'new petition' page

14 months agoLoosen action typing - doing nothing is doing something
Eileen McNaughton [Fri, 22 Sep 2023 07:57:17 +0000 (19:57 +1200)]
Loosen action typing - doing nothing is doing something

14 months agoFix weight values on PriceSet page
Eileen McNaughton [Fri, 22 Sep 2023 07:34:26 +0000 (19:34 +1200)]
Fix weight values on PriceSet page

14 months agoUse subsystem prefix on new setting
Tim Otten [Fri, 22 Sep 2023 04:41:15 +0000 (21:41 -0700)]
Use subsystem prefix on new setting

14 months agoRemove unreachable code
Eileen McNaughton [Fri, 22 Sep 2023 04:03:57 +0000 (16:03 +1200)]
Remove unreachable code

The ContributionRecur::add function throws an error if there
is a problem - it doesn't return an error

14 months agoupdate function signature to match that in parent class (recently changed)
Noah Miller [Fri, 22 Sep 2023 04:03:43 +0000 (00:03 -0400)]
update function signature to match that in parent class (recently changed)

14 months agoreplace deleteAll with a delete action, no "where" required
Noah Miller [Fri, 22 Sep 2023 03:40:36 +0000 (23:40 -0400)]
replace deleteAll with a delete action, no "where" required

14 months agomake cardinal more reliable; add a little more info to getFields
Noah Miller [Fri, 22 Sep 2023 03:39:19 +0000 (23:39 -0400)]
make cardinal more reliable; add a little more info to getFields

make cardinal more reliable; add a little more info to getFields

14 months agoimprove PHPDocs
Noah Miller [Fri, 22 Sep 2023 02:46:10 +0000 (22:46 -0400)]
improve PHPDocs

14 months agouse getEntityName instead of constant
Noah Miller [Fri, 22 Sep 2023 02:44:46 +0000 (22:44 -0400)]
use getEntityName instead of constant

14 months agoPHPDoc for OAuthSessionToken class
highfalutin [Fri, 22 Sep 2023 01:41:52 +0000 (18:41 -0700)]
PHPDoc for OAuthSessionToken class

Co-authored-by: colemanw <coleman@civicrm.org>
14 months agominor improvements, and add a provider for manual testing
Noah Miller [Wed, 6 Sep 2023 19:38:09 +0000 (15:38 -0400)]
minor improvements, and add a provider for manual testing

14 months agoimplement OAuthSessionToken, with tests
Noah Miller [Tue, 5 Sep 2023 17:55:15 +0000 (13:55 -0400)]
implement OAuthSessionToken, with tests

14 months agoMerge pull request #27558 from colemanw/noPaths
Eileen McNaughton [Fri, 22 Sep 2023 03:31:25 +0000 (15:31 +1200)]
Merge pull request #27558 from colemanw/noPaths

APIv4 - Remove function that doesn't do anything, add some type hints

14 months agoStop using undefined properties to specify custom data extends values
Eileen McNaughton [Fri, 22 Sep 2023 02:21:36 +0000 (14:21 +1200)]
Stop using undefined properties to specify custom data extends values

14 months agoMerge pull request #27552 from eileenmcnaughton/custom_field_trait
colemanw [Fri, 22 Sep 2023 02:05:07 +0000 (22:05 -0400)]
Merge pull request #27552 from eileenmcnaughton/custom_field_trait

Fix assigning of customGroup data to be more re-usable & use undefined properties less

14 months agoAPIv4 - Remove function that doesn't do anything, add some type hints
colemanw [Fri, 22 Sep 2023 01:58:29 +0000 (21:58 -0400)]
APIv4 - Remove function that doesn't do anything, add some type hints

14 months agoMerge pull request #27495 from eileenmcnaughton/action_notice
colemanw [Fri, 22 Sep 2023 00:57:26 +0000 (20:57 -0400)]
Merge pull request #27495 from eileenmcnaughton/action_notice

Cast _action to an int

14 months agoMerge pull request #27555 from larssandergreen/Fix-{php}-in-hlp-test
colemanw [Fri, 22 Sep 2023 00:55:53 +0000 (20:55 -0400)]
Merge pull request #27555 from larssandergreen/Fix-{php}-in-hlp-test

Remove {php} in hlp test

14 months agoMerge pull request #27554 from demeritcowboy/quick-safe
Eileen McNaughton [Fri, 22 Sep 2023 00:27:04 +0000 (12:27 +1200)]
Merge pull request #27554 from demeritcowboy/quick-safe

dev/core#4616 - Fix js syntax error on contribution page / nonfunctioning honoree toggle

14 months agoFix assigning of customGroup data to be more re-usable
Eileen McNaughton [Thu, 21 Sep 2023 22:05:49 +0000 (10:05 +1200)]
Fix assigning of customGroup data to be more re-usable

14 months agoRemove {php} in hlp test
larssandergreen [Thu, 21 Sep 2023 23:53:29 +0000 (17:53 -0600)]
Remove {php} in hlp test

14 months agoMerge pull request #27535 from eileenmcnaughton/custom
colemanw [Thu, 21 Sep 2023 23:34:27 +0000 (19:34 -0400)]
Merge pull request #27535 from eileenmcnaughton/custom

Simplify CustomField::displayValue to expect an ID & have deprecated handling for anything else

14 months agoMerge pull request #27532 from eileenmcnaughton/verify_1
colemanw [Thu, 21 Sep 2023 23:32:53 +0000 (19:32 -0400)]
Merge pull request #27532 from eileenmcnaughton/verify_1

Pass `NULL` instead of a value where function requires a parameter but does not use it

14 months agoMerge pull request #27474 from eileenmcnaughton/billing_field
colemanw [Thu, 21 Sep 2023 23:31:54 +0000 (19:31 -0400)]
Merge pull request #27474 from eileenmcnaughton/billing_field

php8.x Remove never-used undeclared property

14 months agoMerge pull request #27429 from eileenmcnaughton/ref
colemanw [Thu, 21 Sep 2023 23:31:11 +0000 (19:31 -0400)]
Merge pull request #27429 from eileenmcnaughton/ref

Fix unnecessary pass-by-ref, minor code improvements