demeritcowboy [Tue, 17 Nov 2020 14:55:52 +0000 (09:55 -0500)]
oo-ify permissions page links
Eileen McNaughton [Thu, 19 Nov 2020 06:59:04 +0000 (19:59 +1300)]
Merge pull request #18993 from giant-rabbit/153-fix-paypal-redirect
dev/financial#153 Fix redirect to PayPal
Tim Otten [Thu, 19 Nov 2020 04:41:41 +0000 (20:41 -0800)]
Merge pull request #18988 from seamuslee001/dev_core_2197
dev/core#2197 Deploy monaco-editor using composer.json / composer dow…
Peter Haight [Thu, 19 Nov 2020 02:45:06 +0000 (18:45 -0800)]
Fix redirect to PayPal
If you put in double slashes in the path part of the PayPal URL and then
PayPal asks you to do their captcha, they have some sort of bug where
they do the wrong redirect after the captcha to https://cgi-bin/webscr.
Issue #153
Seamus Lee [Wed, 18 Nov 2020 08:53:49 +0000 (19:53 +1100)]
dev/core#2197 Deploy monaco-editor using composer.json / composer downloads method
Remove setup.sh as no longer needed and npm related package files
Eileen McNaughton [Wed, 18 Nov 2020 23:36:40 +0000 (12:36 +1300)]
Merge pull request #18991 from demeritcowboy/serialize-notice
dev/core#2196 - serialize E_NOTICE when saving custom field
Eileen McNaughton [Wed, 18 Nov 2020 22:33:58 +0000 (11:33 +1300)]
Merge pull request #18989 from totten/master-afform-label
afform - Get default field `<label>` from `label` instead of `title`
Seamus Lee [Wed, 18 Nov 2020 21:02:59 +0000 (08:02 +1100)]
Merge pull request #18981 from mattwire/extensionsuitweak
Extensionsuitweak
Tim Otten [Wed, 18 Nov 2020 01:29:56 +0000 (17:29 -0800)]
afform - Get default field `<label>` from `label` instead of `title`
Tim Otten [Wed, 18 Nov 2020 01:29:36 +0000 (17:29 -0800)]
gitignore - Whitelist ext/afform
demeritcowboy [Wed, 18 Nov 2020 00:50:23 +0000 (19:50 -0500)]
fix serialize E_NOTICE
colemanw [Wed, 18 Nov 2020 13:25:51 +0000 (08:25 -0500)]
Merge pull request #18990 from totten/master-afform-gui-url
afform/gui - Fix rendering of the "Form Settings"
Tim Otten [Wed, 18 Nov 2020 10:18:34 +0000 (02:18 -0800)]
afform/gui - Fix rendering of the "Form Settings"
The `<textarea/>` tag is misinterpreted, causing the subsequent fields to disappear.
Eileen McNaughton [Tue, 17 Nov 2020 20:47:27 +0000 (09:47 +1300)]
Merge pull request #18985 from demeritcowboy/create-table-logging
dev/core#2190 - Remove unused lines, replace CRM_Utils_Array::value
demeritcowboy [Mon, 16 Nov 2020 22:36:15 +0000 (17:36 -0500)]
don't assume tablespec exists
Seamus Lee [Tue, 17 Nov 2020 00:39:08 +0000 (11:39 +1100)]
Merge pull request #18979 from eileenmcnaughton/trans
Remove return value on transitionComponents
Matthew Wire [Mon, 16 Nov 2020 21:11:41 +0000 (21:11 +0000)]
Tweak information displayed by extensions list so it's aimed more at the end-user rather than the developer
colemanw [Mon, 16 Nov 2020 20:27:26 +0000 (15:27 -0500)]
Merge pull request #18971 from colemanw/angularDashboard
Rewrite jquery.dashboard.js as Angular app
Coleman Watts [Fri, 13 Nov 2020 18:23:41 +0000 (13:23 -0500)]
Rewrite jquery.dashboard.js as Angular app
New home dashboard written with Angular + APIv4.
Functionality is mostly unchanged.
The motivation for this is to support afforms embedded within dashboard dashlets.
Eileen McNaughton [Mon, 16 Nov 2020 11:41:48 +0000 (00:41 +1300)]
Merge pull request #18950 from MegaphoneJon/event-44
event#44: Don't allow self-service cancelling after an event when 'hours to cancel' is zero
eileen [Mon, 16 Nov 2020 08:02:21 +0000 (21:02 +1300)]
Remove return value on transitionComponents
We no longer use the result from this function so this removes most of the code that calculates the updateResult value.
There are still instances coming back from the cancel & fail functions that I will remove as a follow up
Seamus Lee [Mon, 16 Nov 2020 06:06:52 +0000 (17:06 +1100)]
Merge pull request #18964 from eileenmcnaughton/trans
dev/core#2155 Remove obscure broken handling for onlinePendingContribution
Eileen McNaughton [Mon, 16 Nov 2020 06:01:11 +0000 (19:01 +1300)]
Merge pull request #18960 from seamuslee001/utf8mb4_install
dev/core#339 Install CiviCRM tables using utf8mb4
Eileen McNaughton [Mon, 16 Nov 2020 03:20:16 +0000 (16:20 +1300)]
Merge pull request #18977 from civicrm/5.32
5.32 to master
Eileen McNaughton [Mon, 16 Nov 2020 03:16:51 +0000 (16:16 +1300)]
Merge pull request #18976 from colemanw/searchParams
Search ext: use crmRouteBinder to expose params for new searches to url
Coleman Watts [Mon, 16 Nov 2020 00:00:58 +0000 (19:00 -0500)]
Search ext: use crmRouteBinder to expose params for new searches as url arguments
Seamus Lee [Sun, 15 Nov 2020 23:28:01 +0000 (10:28 +1100)]
Merge pull request #18975 from colemanw/fixAfformDep
Fix undeclared afform requirement of ngRoute
Seamus Lee [Sun, 15 Nov 2020 23:21:42 +0000 (10:21 +1100)]
Merge pull request #18974 from civicrm/5.32
5.32
Coleman Watts [Sun, 15 Nov 2020 19:59:29 +0000 (14:59 -0500)]
Fix undeclared afform requirement of ngRoute
Seamus Lee [Sun, 15 Nov 2020 19:25:59 +0000 (06:25 +1100)]
Merge pull request #18967 from seamuslee001/dev_core_2178
dev/core#2178 Fix regression on adding contacts to a newly created group
colemanw [Sun, 15 Nov 2020 17:59:22 +0000 (12:59 -0500)]
Merge pull request #18970 from MegaphoneJon/core-2188
fix default 'is searchable' to prevent breaking advanced search
Seamus Lee [Thu, 12 Nov 2020 01:00:13 +0000 (12:00 +1100)]
dev/core#339 Install CiviCRM tables using utf8mb4
Update sample custom value tables as appropriate as well
Fix conflict between test setting ROW_FORMAT being compressed and the ROW_FORMAT of the original table being DYNAMIC
Jon Goldberg [Fri, 13 Nov 2020 22:19:08 +0000 (17:19 -0500)]
fix default 'is searchable' to prevent breaking advanced search
Seamus Lee [Fri, 13 Nov 2020 04:48:12 +0000 (15:48 +1100)]
Merge pull request #18748 from eileenmcnaughton/log
dev/core#2120 Do not attempt to obsolete primary key on log tables
Seamus Lee [Fri, 13 Nov 2020 04:03:12 +0000 (15:03 +1100)]
dev/core#2178 Fix regression on adding contacts to a newly created group
Eileen McNaughton [Fri, 13 Nov 2020 03:18:41 +0000 (16:18 +1300)]
Merge pull request #18965 from MegaphoneJon/mailing-80
Don't break clickthrough URLs when there's leading whitespace
Seamus Lee [Fri, 13 Nov 2020 00:46:40 +0000 (11:46 +1100)]
Merge pull request #18966 from demeritcowboy/nl-nl-default
[NFC] Follow-on to 18963 to add example setting in civicrm.settings template for setting CMS inheritance for nl_BE
Seamus Lee [Fri, 13 Nov 2020 00:26:01 +0000 (11:26 +1100)]
Merge pull request #18962 from colemanw/dashboardPerms
API - Finer-grained permisions for the dashboard & dashlet entities
demeritcowboy [Thu, 12 Nov 2020 23:22:20 +0000 (18:22 -0500)]
example setting
Eileen McNaughton [Thu, 12 Nov 2020 22:31:47 +0000 (11:31 +1300)]
Merge pull request #18963 from samuelsov/nli18n
Add a way to choose between nl_NL and nl_BE
Coleman Watts [Thu, 12 Nov 2020 15:23:53 +0000 (10:23 -0500)]
API - Finer-grained permisions for the dashboard & dashlet entities
This allows contacts without "administer CiviCRM" permission to access these api entities.
Permissions are restricted to contacts they have access to, and write permissions are
limited to a contact only editing their own dashboard.
Jon Goldberg [Thu, 12 Nov 2020 21:56:44 +0000 (16:56 -0500)]
Don't break clickthrough URLs when there's leading whitespace
eileen [Thu, 12 Nov 2020 20:50:20 +0000 (09:50 +1300)]
dev/core#2155 Remove obscure broken handling for onlinePendingContribution
Per https://lab.civicrm.org/dev/core/-/issues/2155 there is some obscure functionality for
completing a pending contribution under some cases. My testing suggests it is long-term broken.
See GL for more
Samuel Vanhove [Thu, 12 Nov 2020 16:39:47 +0000 (11:39 -0500)]
Add a way to choose between nl_NL and nl_BE
Matthew Wire [Thu, 12 Nov 2020 12:01:14 +0000 (12:01 +0000)]
Merge pull request #18961 from eileenmcnaughton/msg
dev/core#2158 Remove detail about updating related components when editing a contribution status
eileen [Thu, 12 Nov 2020 02:49:31 +0000 (15:49 +1300)]
dev/core#2158 Remove detail about updating related components when editing a contribution status
Note that with this merged it's also possible to remove a lot of code from transitionComponents
Eileen McNaughton [Thu, 12 Nov 2020 00:11:01 +0000 (13:11 +1300)]
Merge pull request #18952 from eileenmcnaughton/aip
Standardise more params in completeOrder
Seamus Lee [Wed, 11 Nov 2020 23:15:01 +0000 (10:15 +1100)]
Merge pull request #18912 from yashodha/dev_2153
(dev/core#2153) BUG: when changing a custom group option value CiviCR…
eileen [Tue, 10 Nov 2020 03:06:04 +0000 (16:06 +1300)]
Standardise more params in completeOrder
This moves the loading of the following params from the first contribution from Authorize.net to
completeOrder
- amount_level
- address_id
In addition campaign_id is moved, however, this is only in it is not an
input param or derived from the recur record
Eileen McNaughton [Wed, 11 Nov 2020 22:25:12 +0000 (11:25 +1300)]
Merge pull request #18956 from civicrm/5.32
5.32
Seamus Lee [Wed, 11 Nov 2020 20:02:48 +0000 (07:02 +1100)]
Merge pull request #18958 from alifrumin/5.32rn
[NFC ] 5.32 Release Notes - first pass
Alice Frumin [Mon, 9 Nov 2020 20:34:58 +0000 (14:34 -0600)]
5.32 release notes
Seamus Lee [Wed, 11 Nov 2020 03:57:09 +0000 (14:57 +1100)]
Merge pull request #18955 from totten/5.32-oauth-return
dev/core#2141 - Tighten up new page `civicrm/oauth-client/return`
Tim Otten [Tue, 10 Nov 2020 22:25:21 +0000 (14:25 -0800)]
dev/core#2141 - Tighten up new page `civicrm/oauth-client/return`
Overview
--------
The route `civicrm/oauth-client/return` is added in 5.32 as the main "Redirect URL".
In normal usage, the page shouldn't be visible to a user (because the
developer should define some alternative UI) -- but one might see it (a)
during development, (b) if there's an error, or (c) if a clever user mucks
about.
Improvements:
* Error handling
* Present error messages more nicely
* Record errors in the log
* Report more info via hook_oauthReturnError
* Other UI
* Redact token details (dependent upon permission `manage OAuth client secrets`)
* Set a more sensibile page title
* Make output blobs conditional and collapsible
Seamus Lee [Tue, 10 Nov 2020 20:46:48 +0000 (07:46 +1100)]
Merge pull request #18948 from aydun/core#2172
core#2172 - Fix 'Find Respondents' in CiviCampaigns
Seamus Lee [Tue, 10 Nov 2020 10:13:35 +0000 (21:13 +1100)]
Merge pull request #18953 from civicrm/5.32
5.32
Seamus Lee [Tue, 10 Nov 2020 06:53:25 +0000 (17:53 +1100)]
Merge pull request #18951 from totten/5.32-ms-imap
dev/mail#79 - Fix MS Exchange/IMAP. Use OpenID Connect.
Tim Otten [Tue, 10 Nov 2020 00:47:50 +0000 (16:47 -0800)]
dev/mail#79 - Use OpenID Connect with MS Exchange
At time of writing, there appears to be a problem in Microsoft's services:
if you request both `User.Read` and `IMAP.AccessAsUser.All`, then the token
does not actually work for IMAP access.
However, it is does work to combine `openid` and `IMAP.AccessAsUser.All`.
This patch revises the MS Exchange definition to get resource-owner details
via OpenID Connect's `id_token`.
Tim Otten [Tue, 10 Nov 2020 00:43:39 +0000 (16:43 -0800)]
dev/mail#79 - Add option to get resource-owner via OpenID Connect
At time of writing, there appears to be a problem in Microsoft's services:
if you request both `User.Read` and `IMAP.AccessAsUser.All`, then the token
does not actually work for IMAP access.
However, it is does work to combine `openid` and `IMAP.AccessAsUser.All`.
This patch to CiviGenericProvider makes it easier to get resource-owner
details via OpenID Connect's `id_token`.
Seamus Lee [Tue, 10 Nov 2020 00:25:51 +0000 (11:25 +1100)]
Merge pull request #18949 from colemanw/legacyAutocomplete
APIv3 - Fix legacy handling for html_type Autocomplete-Select
Jon Goldberg [Mon, 9 Nov 2020 23:14:46 +0000 (18:14 -0500)]
event#44: Don't allow self-service cancelling after an event when 'hours to cancel' is zero
Coleman Watts [Mon, 9 Nov 2020 21:44:49 +0000 (16:44 -0500)]
Fix legacy handling for html_type Autocomplete-Select
Legacy handling was returning "Autocomplete-Multi-Select" which was never a real html_type.
Aidan Saunders [Mon, 9 Nov 2020 21:35:08 +0000 (21:35 +0000)]
Fix SQL
Matthew Wire [Mon, 9 Nov 2020 14:38:46 +0000 (14:38 +0000)]
Merge pull request #18946 from eileenmcnaughton/if
Remove always true if
Matthew Wire [Mon, 9 Nov 2020 14:31:14 +0000 (14:31 +0000)]
Merge pull request #18947 from eileenmcnaughton/pps
dev/financial#148 dev/financial#148 Copy contents of validateDate onto paypalIPN
Seamus Lee [Mon, 9 Nov 2020 09:29:37 +0000 (20:29 +1100)]
Merge pull request #18819 from eileenmcnaughton/import
Minor code cleanup - dedupe isNull checks
eileen [Sun, 8 Nov 2020 23:56:52 +0000 (12:56 +1300)]
dev/financial#148 Copy contents of validateDate onnto paypalIPN
This code isn't really that shared & it can be simplified by NOT sharing it
eileen [Sun, 8 Nov 2020 23:46:54 +0000 (12:46 +1300)]
Remove always true if
By the time the code reaches this point contributionParams['contribution_recur_id']
must be set. We can confirm this by the fact the call to getTemplateContribution
requires id to be passed in and uses it in a lookup. Also the
code just before repeatTransaction ensures it is called
Matthew Wire [Sun, 8 Nov 2020 14:46:55 +0000 (14:46 +0000)]
Merge pull request #18934 from eileenmcnaughton/aip
Remove always-true if
Matthew Wire [Sun, 8 Nov 2020 14:46:14 +0000 (14:46 +0000)]
Merge pull request #18935 from eileenmcnaughton/pps
[REF] Minor variable cleanup
Matthew Wire [Sun, 8 Nov 2020 14:45:48 +0000 (14:45 +0000)]
Merge pull request #18936 from eileenmcnaughton/ppp
[Ref] Use variables directly
Seamus Lee [Sat, 7 Nov 2020 23:02:09 +0000 (10:02 +1100)]
Merge pull request #18944 from civicrm/5.32
5.32
Seamus Lee [Sat, 7 Nov 2020 19:41:22 +0000 (06:41 +1100)]
Merge pull request #18945 from agh1/5.32.0-releasenotes-fixedinitial
5.32.0 release notes initial run
Andrew Hunt [Sat, 7 Nov 2020 15:38:35 +0000 (10:38 -0500)]
5.32.0 release notes: added boilerplate
Andrew Hunt [Sat, 7 Nov 2020 15:35:43 +0000 (10:35 -0500)]
5.32.0 release notes: raw from script
Tim Otten [Sat, 7 Nov 2020 06:25:15 +0000 (22:25 -0800)]
Merge pull request #18943 from totten/5.32-token-inspect
dev/core#2141 - Multiple revisions to new screen for inspecting OAuth tokens
Seamus Lee [Sat, 7 Nov 2020 02:00:12 +0000 (13:00 +1100)]
Merge pull request #18942 from civicrm/5.32
5.32
Tim Otten [Thu, 5 Nov 2020 08:01:09 +0000 (00:01 -0800)]
dev/core#2141 - Multiple revisions to new screen for inspecting OAuth tokens
Overview
--------
5.32 adds `oauth-client`, which includes a screen for inspecting OAuth
tokens. This is intended to facilitate debugging.
Before
------
* The screen works for inspecting one token. It offers a button to inspect other tokens, but it doesn't work.
* The screen only shows the `access_token` (and its JWT variant)
After
-----
* The malfunctioning button isn't needed. Remove it.
* The screen shows a full record of the token details. This should make it even more useful for debuggin.
Seamus Lee [Fri, 6 Nov 2020 22:23:46 +0000 (09:23 +1100)]
Merge pull request #18940 from seamuslee001/5.32
[REF] Update composer patches to 1.7.0 to support composer 2.x
Seamus Lee [Fri, 6 Nov 2020 20:18:03 +0000 (07:18 +1100)]
[REF] Update composer patches to 1.7.0 to support composer 2.x
CiviCRM [Fri, 6 Nov 2020 06:35:30 +0000 (06:35 +0000)]
Set version to 5.33.alpha1
CiviCRM [Fri, 6 Nov 2020 06:28:28 +0000 (06:28 +0000)]
Set version to 5.32.beta1
Eileen McNaughton [Fri, 6 Nov 2020 02:47:57 +0000 (15:47 +1300)]
Merge pull request #18868 from sunilpawar/logging_date
get log date from tables available in query with data instead of last table
Eileen McNaughton [Fri, 6 Nov 2020 02:35:01 +0000 (15:35 +1300)]
Merge pull request #18851 from ixiam/dev_issue#2142
Adds performance improvement when browsing the report logs
Eileen McNaughton [Fri, 6 Nov 2020 02:10:27 +0000 (15:10 +1300)]
Merge pull request #18913 from tvartom/master
Make civicrm-setup work with a unix-socket for database connection
colemanw [Fri, 6 Nov 2020 00:50:49 +0000 (19:50 -0500)]
Merge pull request #18932 from colemanw/schemaHandler
Schema handler fixes
eileen [Fri, 6 Nov 2020 00:06:44 +0000 (13:06 +1300)]
[Ref] Use variables directly
eileen [Thu, 5 Nov 2020 23:58:07 +0000 (12:58 +1300)]
[REF] Minor variable cleanup
This continues the process of using the variables we have loaded within the IPN
rather than those that were loaded onto objects FROM the ones loaded in this IPN
eileen [Thu, 5 Nov 2020 23:47:15 +0000 (12:47 +1300)]
Remove always-true if
AuthorizeNet ipn is only called from
CRM_Core_Payment_AuthorizeNet::handlePaymentNotification and the deprecated
AuthorizeNetIPN file in extern
(and tests)
No parameter is ever passed to the function so component is always
'contribute' & hence we can stop checking it & remove the IF that checks it
Seamus Lee [Thu, 5 Nov 2020 22:46:44 +0000 (09:46 +1100)]
Merge pull request #18931 from seamuslee001/master
5.31
Seamus Lee [Thu, 5 Nov 2020 22:45:31 +0000 (09:45 +1100)]
Merge in 5.31
Eileen McNaughton [Thu, 5 Nov 2020 22:40:19 +0000 (11:40 +1300)]
Merge pull request #18925 from totten/5.31-revert-titlereq
dev/translation#58 - Fix regression. Partially revert schema for civicrm_group.title
Coleman Watts [Thu, 5 Nov 2020 22:36:52 +0000 (17:36 -0500)]
CustomField - simplify tableName lookup during bulkSave and fix bug
This cleans up the tableName lookup to use the method used throughout this class.
The extra optimization (local caching in the $tables variable) was actually less efficient
because CRM_Core_DAO::getFieldValue caches its results, and is used elsewhere so the value
is likely to already be cached.
The bug is that the same table name was repeatedly being passed into $logging->fixSchemaDifferencesFor().
Coleman Watts [Thu, 5 Nov 2020 22:31:35 +0000 (17:31 -0500)]
SchemaHandler - Remove unused/deprecated function
Matthew Wire [Thu, 5 Nov 2020 21:53:29 +0000 (21:53 +0000)]
Merge pull request #18930 from MegaphoneJon/financial-156
closes financial/#156: Set contribution status to refunded even if cancelled_payment_id is set
Jon Goldberg [Thu, 5 Nov 2020 19:24:38 +0000 (14:24 -0500)]
closes financial/#156: Set contribution status to refunded even if cancelled_payment_id is set
colemanw [Thu, 5 Nov 2020 18:07:29 +0000 (13:07 -0500)]
Merge pull request #18928 from demeritcowboy/left-right-up-down
dev/core#2167 - Fulltext search drupal block has button on wrong side
colemanw [Thu, 5 Nov 2020 18:07:13 +0000 (13:07 -0500)]
Merge pull request #18927 from demeritcowboy/del-mail
dev/core#2166 - E_NOTICE when deleting mail account
demeritcowboy [Thu, 5 Nov 2020 15:12:36 +0000 (10:12 -0500)]
button placement on fulltext search drupal block
demeritcowboy [Thu, 5 Nov 2020 14:43:34 +0000 (09:43 -0500)]
avoid notice / skip validation when deleting