Tim Otten [Thu, 22 Jun 2023 23:36:31 +0000 (16:36 -0700)]
MessageTemplate - Be more forgiving about order of loading explicit message-template content
While rejuggling the order of operations in `renderTemplateRaw()`, this
helped some tests (like `testRenderDefaultTemplate()`) pass.
Tim Otten [Thu, 22 Jun 2023 23:30:04 +0000 (16:30 -0700)]
WorkflowMessage - Add getWorkflowName() and getGroupName()
Tim Otten [Thu, 22 Jun 2023 22:00:58 +0000 (15:00 -0700)]
(NFC) Add test-group for "message templates" (msgtpl)
Seamus Lee [Fri, 23 Jun 2023 00:20:24 +0000 (10:20 +1000)]
Merge pull request #26600 from eileenmcnaughton/anet
[AuthorizeNetIPN] Use API for failure updates
Eileen McNaughton [Thu, 22 Jun 2023 23:59:45 +0000 (16:59 -0700)]
Merge pull request #26611 from eileenmcnaughton/custom_search
dev/core#4056 Move customSearch smart group sql generation to legacycustomsearches extension
Eileen McNaughton [Thu, 22 Jun 2023 23:23:39 +0000 (16:23 -0700)]
Move customSearch smart group sql generation to legacycustomsearches extension
Seamus Lee [Thu, 22 Jun 2023 22:03:50 +0000 (08:03 +1000)]
Merge pull request #26609 from colemanw/updateWeights
ACL - Ensure all priorities are unique
colemanw [Thu, 22 Jun 2023 21:04:27 +0000 (14:04 -0700)]
ACL - Ensure all priorities are unique
Eileen McNaughton [Thu, 22 Jun 2023 20:53:56 +0000 (13:53 -0700)]
Merge pull request #26608 from colemanw/managedMatch
Specify 'match' in mgd.php files
colemanw [Thu, 22 Jun 2023 20:05:46 +0000 (13:05 -0700)]
Specify 'match' in mgd.php files
colemanw [Thu, 22 Jun 2023 19:33:23 +0000 (15:33 -0400)]
Merge pull request #26592 from seamuslee001/acl_rule_weight
Add "priority" column to ACLs and support ACL rule precedence
demeritcowboy [Thu, 22 Jun 2023 19:17:55 +0000 (15:17 -0400)]
Merge pull request #26591 from colemanw/caseActivityHook
[REF] CiviCase - Move more activity logic into case BAO via hook
Seamus Lee [Thu, 22 Jun 2023 17:15:01 +0000 (03:15 +1000)]
Refactor to add deny and weighting aspects into the loadPermittedIDs function as per Coleman
Eileen McNaughton [Thu, 22 Jun 2023 03:23:48 +0000 (20:23 -0700)]
Use API for failure updates
This
- switches to use the api rather than DAO save (calls hooks)
- adds a cancel_reason - cos why not & the field was added since the IPN was written
- specifies the authorize_net log. This puts it in a different log file and allows
listeners if sites want. Feels like better practice
Seamus Lee [Wed, 21 Jun 2023 22:57:20 +0000 (08:57 +1000)]
Add weight column to ACLs and support weighted ACL rules
Add in upgrade step
Rename field to be priority and add in upgrade guards as per Coleman
Updates as per discussion with coleman
Seamus Lee [Thu, 22 Jun 2023 16:42:15 +0000 (02:42 +1000)]
Merge pull request #26602 from eileenmcnaughton/tax_ex
Switch to token for tax_exclusive_amount in offline receipt
Seamus Lee [Thu, 22 Jun 2023 16:24:34 +0000 (02:24 +1000)]
Merge pull request #26599 from eileenmcnaughton/offline_madness
Fix e-notices in contribution_offline_receipt text by removing always-empty field
Eileen McNaughton [Thu, 22 Jun 2023 16:10:56 +0000 (09:10 -0700)]
Switch to token for tax_exclusive_amount in offline receipt
This is less susceptible to notices, works in preview and follows our
patter of using tokens where possible
colemanw [Thu, 22 Jun 2023 15:50:22 +0000 (11:50 -0400)]
Merge pull request #26598 from colemanw/checkboxFix
dev/core#4387 - CRM_Core_Form - Fix params passed to checkbox
Seamus Lee [Thu, 22 Jun 2023 15:49:31 +0000 (01:49 +1000)]
Merge pull request #26597 from eileenmcnaughton/anet_unused
Remove unused functions from `AuthorizeNetIPN`
Seamus Lee [Thu, 22 Jun 2023 03:13:09 +0000 (13:13 +1000)]
Merge pull request #26589 from eileenmcnaughton/anet
Simplify use of contribution - we are only looking at status
colemanw [Thu, 22 Jun 2023 03:09:50 +0000 (20:09 -0700)]
dev/core#4387 - CRM_Core_Form - Fix params passed to checkbox
Eileen McNaughton [Thu, 22 Jun 2023 03:09:49 +0000 (20:09 -0700)]
Fix e-notices in contribution_offline_receipt text by removing always-empty field
On looking to fix this enotice through the form it turned out the
contribution form does not have a field for this - so the formValues
will never hold receipt_text.
Hence this PR removes it from the template.
Other forms do seem to have this & I will separately add userText or similar to the model
Eileen McNaughton [Thu, 22 Jun 2023 01:15:52 +0000 (18:15 -0700)]
Remove unused functions from AuthorizeNetIPN
demeritcowboy [Thu, 22 Jun 2023 00:20:00 +0000 (20:20 -0400)]
Merge pull request #26593 from colemanw/civiimportFix2
CiviImport - String fix
colemanw [Wed, 21 Jun 2023 23:50:18 +0000 (16:50 -0700)]
CiviImport - String fix
demeritcowboy [Wed, 21 Jun 2023 22:44:27 +0000 (18:44 -0400)]
Merge pull request #26590 from colemanw/civiimportFix
CiviImport - Fix table description
Eileen McNaughton [Wed, 21 Jun 2023 22:14:28 +0000 (15:14 -0700)]
Simplify use of contribution - we are only looking at status
colemanw [Wed, 21 Jun 2023 22:18:35 +0000 (15:18 -0700)]
CiviCase - Move more activity logic into case BAO via hook
colemanw [Wed, 21 Jun 2023 22:13:55 +0000 (15:13 -0700)]
CiviImport - Fix table description
Seamus Lee [Wed, 21 Jun 2023 21:33:37 +0000 (07:33 +1000)]
Merge pull request #26587 from eileenmcnaughton/anet
Move sending of email to recur function
colemanw [Wed, 21 Jun 2023 21:16:15 +0000 (17:16 -0400)]
Merge pull request #26588 from demeritcowboy/why
Why?
demeritcowboy [Wed, 21 Jun 2023 19:01:26 +0000 (15:01 -0400)]
why?
Eileen McNaughton [Wed, 21 Jun 2023 16:32:10 +0000 (09:32 -0700)]
Move sending of email to recur function
Seamus Lee [Wed, 21 Jun 2023 16:08:29 +0000 (02:08 +1000)]
Merge pull request #26586 from eileenmcnaughton/anet
Extract getContributionRecur, clean up input input...
Eileen McNaughton [Wed, 21 Jun 2023 15:23:49 +0000 (08:23 -0700)]
Extract getContributionRecur, clean up input input...
Tim Otten [Wed, 21 Jun 2023 14:53:39 +0000 (07:53 -0700)]
Merge pull request #26583 from colemanw/setops2
APIv4 - Improve UNION field handling & add test coverage
colemanw [Wed, 21 Jun 2023 14:53:15 +0000 (10:53 -0400)]
Merge pull request #26581 from totten/master-rbac-fbac-desc
Form Builder - Clarify "Security" options
demeritcowboy [Wed, 21 Jun 2023 12:36:21 +0000 (08:36 -0400)]
Merge pull request #25271 from eightiesguy/allow-multiple-free-html-fields
Allows multiple Free Text fields to be added to form layout
demeritcowboy [Wed, 21 Jun 2023 12:16:19 +0000 (08:16 -0400)]
Merge pull request #26523 from larssandergreen/Don't-trigger-GroupContact-hook-when-adding-already-added-contacts-
Prevent erroneous GroupContact hooks for Contact already in group
demeritcowboy [Wed, 21 Jun 2023 12:09:51 +0000 (08:09 -0400)]
add code comment
Yashodha Chaku [Wed, 21 Jun 2023 04:24:04 +0000 (09:54 +0530)]
Merge pull request #26584 from mikeybeck/fix-membership-detail-report
Add self to contributors
colemanw [Wed, 21 Jun 2023 04:14:03 +0000 (00:14 -0400)]
Merge pull request #26582 from eileenmcnaughton/anet
Remove ids Variable that is dumb
colemanw [Tue, 20 Jun 2023 21:33:57 +0000 (17:33 -0400)]
APIv4 - Improve UNION field handling & add test coverage
Mike Beck [Wed, 21 Jun 2023 03:46:21 +0000 (15:46 +1200)]
Add self to contributors
Eileen McNaughton [Wed, 21 Jun 2023 01:06:43 +0000 (18:06 -0700)]
Remove ids Variable
Seamus Lee [Wed, 21 Jun 2023 01:03:25 +0000 (11:03 +1000)]
Merge pull request #26562 from eileenmcnaughton/anet
Stop passing around object, just to get the id in Anet.ipn
Eileen McNaughton [Wed, 21 Jun 2023 00:56:56 +0000 (12:56 +1200)]
Merge pull request #26557 from eileenmcnaughton/repeat3
Call repeatTransation not completeOrder from repeatTransaction API
Tim Otten [Wed, 21 Jun 2023 00:45:51 +0000 (17:45 -0700)]
Merge pull request #26432 from demeritcowboy/recur-entity
[PHP8] Fix warnings on activity and event management forms
Eileen McNaughton [Sat, 17 Jun 2023 23:41:29 +0000 (11:41 +1200)]
Call repeatTransation not completeOrder from repeatTransaction API
Eileen McNaughton [Wed, 21 Jun 2023 00:01:18 +0000 (12:01 +1200)]
Merge pull request #26556 from eileenmcnaughton/repeat_2
Duplicate the few lines of shared code between `completeOrder` into `repeatTransaction`
Eileen McNaughton [Wed, 21 Jun 2023 00:00:58 +0000 (12:00 +1200)]
Merge pull request #26570 from eileenmcnaughton/event_test_add_pay
Cleanup AdditionalPaymentTest to use event trait
Seamus Lee [Tue, 20 Jun 2023 23:38:36 +0000 (09:38 +1000)]
Merge pull request #26573 from eileenmcnaughton/event_preview
Enhance examples to cover additional participants
Eileen McNaughton [Sat, 17 Jun 2023 23:30:35 +0000 (11:30 +1200)]
Duplicate the few lines of actual shared code into repeatTransaction form repeateOrder
Seamus Lee [Tue, 20 Jun 2023 23:28:47 +0000 (09:28 +1000)]
Merge pull request #26555 from eileenmcnaughton/repeat
Move code to complete `repeatTransation` into that function
Eileen McNaughton [Mon, 19 Jun 2023 01:44:17 +0000 (13:44 +1200)]
Cleanup AdditionalPaymentTest to use event trait
Fix additional payment test to use Event test trait
Tim Otten [Tue, 20 Jun 2023 22:47:21 +0000 (15:47 -0700)]
Merge pull request #26391 from colemanw/apiRoutePermissions
APIv4 - Remove gatekeeper permission check for AJAX endpoint (with tests)
Tim Otten [Tue, 20 Jun 2023 18:32:12 +0000 (11:32 -0700)]
Form Builder - Clarify "Security" options
Follow-up to
54354d0430b2331bd8c80f1b5c868b2c668624f1, which was a small thing thrown into the bigger #24832
Before
------
* Originally, "Security" options were labeled as "Role-Based" (RBAC) and "Form-Based" (FBAC)
* This is confusing, because it packs a subtle distinction into two phrases which are slightly jargony.
* Currently, "Security" options are labeled as "Enforce Permissions" (RBAC) and "Open Access" (FBAC)
* This is confusing, because "Open Access" wrongly suggests that the access is, well, open. (It's
actually dependent on the overall configuration.)
After
-----
* Security is "User-Based" or "Form-Based"
* There is also a longer description.
colemanw [Tue, 20 Jun 2023 18:26:49 +0000 (14:26 -0400)]
Merge pull request #26521 from larssandergreen/Show-manually-added-smart-groups-on-Contact-Edit
Show manually added Smart Groups on Contact edit
colemanw [Tue, 20 Jun 2023 18:07:36 +0000 (14:07 -0400)]
Merge pull request #26543 from eileenmcnaughton/event_test
Fix Invoice test to user EventTestTrait, require less in order API
colemanw [Tue, 20 Jun 2023 18:06:05 +0000 (14:06 -0400)]
Merge pull request #26549 from aydun/left_right
Add LEFT, RIGHT and SUBSTRING SQL functions
colemanw [Tue, 20 Jun 2023 18:04:17 +0000 (14:04 -0400)]
Merge pull request #26565 from mlutfy/fixTs2023
Misc ts fixes
colemanw [Tue, 20 Jun 2023 18:02:40 +0000 (14:02 -0400)]
Merge pull request #26571 from eileenmcnaughton/var_gone
Remove unused line item variable from signature
Tim Otten [Tue, 20 Jun 2023 06:19:47 +0000 (23:19 -0700)]
Merge pull request #26444 from VangelisP/dev_issue#4308
Converts the CryptoExceptions into session messages.
Eileen McNaughton [Tue, 20 Jun 2023 00:10:01 +0000 (12:10 +1200)]
Merge pull request #26578 from eileenmcnaughton/lars_pay
Don't show pay_later processor on additional live Payment
Eileen McNaughton [Mon, 19 Jun 2023 23:17:04 +0000 (11:17 +1200)]
Merge pull request #26577 from demeritcowboy/acl-deny
dev/core#4383 - Crash for lesser-permissioned users
Eileen McNaughton [Mon, 19 Jun 2023 22:57:25 +0000 (10:57 +1200)]
Don't show pay_later processor on additional live Paymen
demeritcowboy [Mon, 19 Jun 2023 22:45:35 +0000 (18:45 -0400)]
crash for lesser-permissioned users
Yashodha Chaku [Mon, 19 Jun 2023 15:31:34 +0000 (21:01 +0530)]
Merge pull request #26575 from eileenmcnaughton/event_tokens_
Expose a few more event fields as tokens
demeritcowboy [Mon, 19 Jun 2023 13:20:40 +0000 (09:20 -0400)]
Merge pull request #26559 from eileenmcnaughton/paypal
Superficial clean up in test class
demeritcowboy [Mon, 19 Jun 2023 13:14:43 +0000 (09:14 -0400)]
Merge pull request #26558 from larssandergreen/Lifetime-membership-change
Fix lifetime membership with end date error message
demeritcowboy [Mon, 19 Jun 2023 13:12:59 +0000 (09:12 -0400)]
Merge pull request #26554 from braders/dev-core-4048
dev/core#4048 Fatal error when changing membership type on membership with no contributions
Mathieu Lutfy [Sun, 18 Jun 2023 19:29:13 +0000 (15:29 -0400)]
Misc ts fixes
Eileen McNaughton [Mon, 19 Jun 2023 01:25:27 +0000 (13:25 +1200)]
Enhance examples to cover additional participants
Eileen McNaughton [Mon, 19 Jun 2023 10:58:18 +0000 (22:58 +1200)]
Expose a few more event fields as tokens
They are used in the message templates
Aidan Saunders [Mon, 19 Jun 2023 09:09:44 +0000 (10:09 +0100)]
Merge pull request #26553 from colemanw/sqlFunctionFix
APIv4 - Fix passing '0' as a function argument
Aidan Saunders [Fri, 16 Jun 2023 14:39:14 +0000 (15:39 +0100)]
Add LEFT, RIGHT & SUBSTRING SQL functions, with a test
Seamus Lee [Mon, 19 Jun 2023 04:51:49 +0000 (14:51 +1000)]
Merge pull request #26572 from civicrm/5.63
5.63
Seamus Lee [Mon, 19 Jun 2023 03:17:53 +0000 (13:17 +1000)]
Merge pull request #26569 from eileenmcnaughton/event_preview
Fix broken event message template preview
Seamus Lee [Mon, 19 Jun 2023 03:17:11 +0000 (13:17 +1000)]
Merge pull request #26568 from eileenmcnaughton/event_test_
Remove duplicate test
Eileen McNaughton [Mon, 19 Jun 2023 03:06:02 +0000 (15:06 +1200)]
Remove remaining places where unused variable is passed
Eileen McNaughton [Mon, 19 Jun 2023 03:01:22 +0000 (15:01 +1200)]
Stop passing removed parameter from ChangeFeeSelectionTest
Eileen McNaughton [Mon, 19 Jun 2023 02:56:33 +0000 (14:56 +1200)]
Remove unused line item variable from signature
Seamus Lee [Mon, 19 Jun 2023 01:55:04 +0000 (11:55 +1000)]
Merge pull request #26041 from seamuslee001/negative_acls
Permit ACL rules that negate (deny) access
Eileen McNaughton [Mon, 19 Jun 2023 00:57:23 +0000 (12:57 +1200)]
Fix broken event message template preview
This is outside most live use cases but it currently fails on an api
error due to a mismatch between example data & expectations. It should be fixed in
the rc but it might not make sense to back port (or determine breakage further back)
Eileen McNaughton [Mon, 19 Jun 2023 00:48:14 +0000 (12:48 +1200)]
Remove duplicate test
Eileen McNaughton [Mon, 19 Jun 2023 00:35:32 +0000 (12:35 +1200)]
Merge pull request #26564 from mlutfy/uplang6
extensions/uplang#6 Fix menu description translations on the Administration Console
Eileen McNaughton [Mon, 19 Jun 2023 00:34:47 +0000 (12:34 +1200)]
Merge pull request #26566 from mikeybeck/fix-membership-detail-report
Remove 'Payment Amount (most recent)' column from membership report
colemanw [Mon, 19 Jun 2023 00:28:44 +0000 (20:28 -0400)]
Fix capitalization in ACL form
Seamus Lee [Mon, 19 Jun 2023 00:14:33 +0000 (10:14 +1000)]
Add unit test of negative ACL rules
Seamus Lee [Tue, 11 Apr 2023 01:18:41 +0000 (11:18 +1000)]
[WIP] Permit ACL rules that negate (deny)
Further fixes
Expose the deny field on the ACL form and fix current test failures
Update lanague as per Coleman
Mike Beck [Sun, 18 Jun 2023 21:23:50 +0000 (09:23 +1200)]
Remove 'Payment Amount (most recent)' column from membership report
Mathieu Lutfy [Sun, 18 Jun 2023 17:56:01 +0000 (13:56 -0400)]
extensions/uplang#6 Fix translation of menu descriptions displayed on the Administration Console
Vangelis Pantazis [Sun, 18 Jun 2023 07:44:26 +0000 (10:44 +0300)]
Catches exception errors before rendering the form
Eileen McNaughton [Sun, 18 Jun 2023 03:47:39 +0000 (15:47 +1200)]
Stop passing around object, just to get the id in ANtet.ipn
Eileen McNaughton [Sat, 17 Jun 2023 23:50:19 +0000 (11:50 +1200)]
Superficial clean up in test class
colemanw [Sat, 17 Jun 2023 23:53:35 +0000 (19:53 -0400)]
Merge pull request #26540 from eileenmcnaughton/event_part_test
Fix participantTest class to call createEventPaid
larssandergreen [Sat, 17 Jun 2023 23:41:05 +0000 (17:41 -0600)]
Fix lifetime membership with end date warning
Eileen McNaughton [Sat, 17 Jun 2023 23:21:50 +0000 (11:21 +1200)]
Move code to complete repeatTransation into that function
Bradley Taylor [Sat, 17 Jun 2023 15:57:25 +0000 (16:57 +0100)]
dev/core#4048 Fatal error when changing membership type on membership with no contributions