Eileen McNaughton [Fri, 28 Jul 2023 04:54:34 +0000 (16:54 +1200)]
Stop setting quickConfig for form that doesn't care
Eileen McNaughton [Fri, 28 Jul 2023 04:49:22 +0000 (16:49 +1200)]
Use isQuickConfig to determine isQuickConfig
Eileen McNaughton [Thu, 27 Jul 2023 23:56:10 +0000 (11:56 +1200)]
Merge pull request #26949 from eileenmcnaughton/dummy
Update ContributionMainTest to use full form flow
Eileen McNaughton [Thu, 27 Jul 2023 23:14:02 +0000 (11:14 +1200)]
Update ContributionMainTest to use full form flow
This updates the test to use postProcess and to check is_recur is passed to the
preApprove function rather than proxy that check by checking if is_recur
is set in the _params property (which is not used again after the preApprove
Seamus Lee [Thu, 27 Jul 2023 22:24:01 +0000 (18:24 -0400)]
Merge pull request #26945 from civicrm/5.64
5.64
Seamus Lee [Thu, 27 Jul 2023 22:23:48 +0000 (18:23 -0400)]
Merge pull request #26947 from eileenmcnaughton/report
[PHP8.2] Remove undeclared property
Eileen McNaughton [Thu, 27 Jul 2023 21:46:19 +0000 (09:46 +1200)]
[PHP8.2] Remove undeclared property
It appears to be copy & paste cos it is set but never used
Aidan Saunders [Thu, 27 Jul 2023 21:06:00 +0000 (22:06 +0100)]
Merge pull request #26944 from colemanw/fixSkArithmetic
Fix dev/core#4455 broken SK arithmetic display
colemanw [Thu, 27 Jul 2023 19:36:35 +0000 (15:36 -0400)]
Fix dev/core#4455 broken SK arithmetic display
demeritcowboy [Thu, 27 Jul 2023 13:40:49 +0000 (09:40 -0400)]
Merge pull request #26236 from ufundo/400-not-500-errors-for-bad-requests
dev/core#4298 - respond with 400 not 500 errors if wrong params passed to CiviMail urls
Seamus Lee [Thu, 27 Jul 2023 12:48:36 +0000 (08:48 -0400)]
Merge pull request #26941 from civicrm/5.64
5.64
Yashodha Chaku [Thu, 27 Jul 2023 05:44:34 +0000 (11:14 +0530)]
Merge pull request #26939 from demeritcowboy/upg-parent-id
dev/core#4451 - fix dangerous delete cascade
demeritcowboy [Thu, 27 Jul 2023 03:24:07 +0000 (23:24 -0400)]
Merge pull request #26938 from demeritcowboy/neverseen-ts
Remove ts for message that should never be seen by normal people
demeritcowboy [Thu, 27 Jul 2023 02:54:37 +0000 (22:54 -0400)]
fix dangerous delete cascade
demeritcowboy [Thu, 27 Jul 2023 01:40:41 +0000 (21:40 -0400)]
this message should never be seen by normal people
demeritcowboy [Thu, 27 Jul 2023 01:33:05 +0000 (21:33 -0400)]
Merge pull request #26935 from larssandergreen/Fix-upgrade-templates-message
dev/core#4445 Only show templates upgrade message when templates have changed
Seamus Lee [Thu, 27 Jul 2023 01:24:17 +0000 (21:24 -0400)]
Merge pull request #26937 from totten/master-retune
ClassScanner - Re-skip `_Form` classes
Tim Otten [Thu, 27 Jul 2023 00:42:45 +0000 (17:42 -0700)]
ClassScanner - Re-skip `_Form` classes
Follow-up to #26936. The prior commit was good in that it stopped scanning `CRM_Core_QuickForm_*` classes. But it also
turned-on unnecessary scanning of `CRM_*_Form_*`. Flip that back.
At time of writing, this represents ~500 unnecessary reads (e.g. scanning 1000 files vs 1500 files).
Seamus Lee [Thu, 27 Jul 2023 00:27:58 +0000 (20:27 -0400)]
Merge pull request #26936 from larssandergreen/Don't-scan-QuickForm-classes
Don't scan QuickForm classes
larssandergreen [Wed, 26 Jul 2023 23:19:17 +0000 (17:19 -0600)]
Don't scan QuickForm classes
Seamus Lee [Wed, 26 Jul 2023 22:55:23 +0000 (18:55 -0400)]
Merge pull request #26932 from demeritcowboy/slow3
dev/core#4449 - Avoid slow status checks
larssandergreen [Wed, 26 Jul 2023 21:04:01 +0000 (15:04 -0600)]
Only show templates upgrade message when templates have changed
colemanw [Wed, 26 Jul 2023 16:54:15 +0000 (09:54 -0700)]
Merge pull request #26929 from aydun/adminui_price_paths
Change Price paths
colemanw [Wed, 26 Jul 2023 16:27:27 +0000 (09:27 -0700)]
Merge pull request #26925 from aydun/adminui_aclentity
AdminUI: convert 'Assign Users to Roles' ACL configuration page
Mathieu Lu [Wed, 26 Jul 2023 15:27:34 +0000 (11:27 -0400)]
Merge pull request #26934 from mlutfy/standaloneAdmin
Standalone civi-setup: grant more permissions to anon, use ts
Yashodha Chaku [Wed, 26 Jul 2023 15:00:32 +0000 (20:30 +0530)]
Merge pull request #26930 from mlutfy/hookCopyOriginal
hook_civicrm_copy: Pass the original id when available
Aidan Saunders [Mon, 24 Jul 2023 17:09:48 +0000 (18:09 +0100)]
AdminUI: convert "Assign Users to Roles" ACL page to SearchKit/FormBuilder
demeritcowboy [Wed, 26 Jul 2023 14:10:59 +0000 (10:10 -0400)]
Merge pull request #26897 from mlutfy/financial216
dev/financial#216 Financial Batch: remove the Create/Edit activities
Aidan Saunders [Tue, 25 Jul 2023 16:27:58 +0000 (17:27 +0100)]
Price metadata changes for SearchKit
Aidan Saunders [Tue, 25 Jul 2023 16:12:25 +0000 (17:12 +0100)]
Add /edit paths for Price Sets, Price Fields and Price Field Values
Mathieu Lu [Wed, 26 Jul 2023 14:05:49 +0000 (10:05 -0400)]
Standalone civi-setup: grant more permissions to anon, use ts
demeritcowboy [Tue, 25 Jul 2023 23:15:47 +0000 (19:15 -0400)]
avoid slow status checks
demeritcowboy [Tue, 25 Jul 2023 22:24:19 +0000 (18:24 -0400)]
Merge pull request #26912 from eileenmcnaughton/subscribe
Minor cleanup in test class
Tim Otten [Tue, 25 Jul 2023 19:58:33 +0000 (12:58 -0700)]
Merge pull request #26923 from colemanw/actionMappingService2
Autoload ActionMappings by enabling global class scanning (Variant 2)
Mathieu Lu [Tue, 25 Jul 2023 19:34:08 +0000 (15:34 -0400)]
hook_civicrm_copy: Pass the original id when available
Mathieu Lutfy [Fri, 21 Jul 2023 17:21:50 +0000 (13:21 -0400)]
dev/financial#216 Financial Batch: remove the Create/Edit activities
demeritcowboy [Tue, 25 Jul 2023 16:37:11 +0000 (12:37 -0400)]
Merge pull request #26928 from civicrm/5.64
5.64
colemanw [Tue, 25 Jul 2023 15:29:41 +0000 (08:29 -0700)]
Merge pull request #26927 from eileenmcnaughton/import_url
Fix Import Template path to be dynamic, depending on the entity
colemanw [Mon, 24 Jul 2023 17:38:51 +0000 (13:38 -0400)]
Autoload ActionMappings by enabling global class scanning
This adds the `AutoSubscriber` base class which is a little simpler to
implement than its cousin `AutoService` when all you need to do is
subscribe to events.
demeritcowboy [Tue, 25 Jul 2023 13:01:14 +0000 (09:01 -0400)]
Merge pull request #26902 from seamuslee001/dev_core_4429
dev/core#4429 Fix checking to see if a price option is able to be useā¦
demeritcowboy [Tue, 25 Jul 2023 12:51:55 +0000 (08:51 -0400)]
Merge pull request #26917 from eileenmcnaughton/test_fix
Minor improvement in test set up function
Seamus Lee [Tue, 25 Jul 2023 07:41:10 +0000 (03:41 -0400)]
Merge pull request #24683 from larssandergreen/check-if-employer-matches-employer-value-in-profile
Check if profile contact employer name matches existing contact employer name when saving profile
Eileen McNaughton [Tue, 25 Jul 2023 04:18:51 +0000 (16:18 +1200)]
Fix Import Template path to be dynamic, depending on the entity
Seamus Lee [Tue, 25 Jul 2023 01:59:39 +0000 (21:59 -0400)]
Merge pull request #26889 from demeritcowboy/slow
Status check - Use guzzle instead to avoid slowness reading zero-length file
Eileen McNaughton [Tue, 25 Jul 2023 01:53:06 +0000 (13:53 +1200)]
Merge pull request #26926 from eileenmcnaughton/import_part
Fix multi-value custom fields on participant import
Jon Goldberg [Tue, 4 Apr 2023 16:59:31 +0000 (12:59 -0400)]
Fix multi-value custom fields on participant import
Eileen McNaughton [Mon, 24 Jul 2023 05:51:48 +0000 (17:51 +1200)]
Minor improvement in test set up function
Eileen McNaughton [Mon, 24 Jul 2023 19:35:33 +0000 (07:35 +1200)]
Merge pull request #26924 from larssandergreen/Update-tests-to-ignore-packaged-saved-searches
Update tests to ignore packaged saved searches
Aidan Saunders [Mon, 24 Jul 2023 17:08:14 +0000 (18:08 +0100)]
setup.sh
Aidan Saunders [Mon, 24 Jul 2023 17:07:07 +0000 (18:07 +0100)]
Change path for acl entityrole form
Aidan Saunders [Mon, 24 Jul 2023 19:24:16 +0000 (20:24 +0100)]
Merge pull request #26921 from aydun/add_browse
Add '<browse>' links matching those in AdminUI
larssandergreen [Mon, 24 Jul 2023 18:22:30 +0000 (12:22 -0600)]
Update tests to ignore packaged saved searches
Aidan Saunders [Mon, 24 Jul 2023 15:09:06 +0000 (16:09 +0100)]
Add '<browse>' links matching those in AdminUI
demeritcowboy [Mon, 24 Jul 2023 15:21:38 +0000 (11:21 -0400)]
Merge pull request #26919 from aydun/searchui_findcontacts
SearchUI:Move 'Find Contacts' upgrader steps from AdminUI to SearchUI
Aidan Saunders [Mon, 24 Jul 2023 13:21:56 +0000 (14:21 +0100)]
Move 'Find Contacts' upgrader steps from AdminUI to SearchUI
Yashodha Chaku [Mon, 24 Jul 2023 13:53:39 +0000 (19:23 +0530)]
Merge pull request #26918 from colemanw/arrayValueAssignments
REF - Split variable assignments out of conditionals
Aidan Saunders [Mon, 24 Jul 2023 11:53:06 +0000 (12:53 +0100)]
Merge pull request #26896 from colemanw/mappingMetadata
AdminUI - Add Administer Scheduled Reminders page
colemanw [Mon, 24 Jul 2023 11:18:01 +0000 (04:18 -0700)]
Merge pull request #26825 from colemanw/dialogHeight
Reduce initial height of crm-popup dialog
colemanw [Mon, 24 Jul 2023 10:29:21 +0000 (06:29 -0400)]
REF - Split variable assignments out of conditionals
colemanw [Mon, 24 Jul 2023 10:16:45 +0000 (03:16 -0700)]
Merge pull request #26914 from eileenmcnaughton/mem_amount
Remove old broken code
Tim Otten [Mon, 24 Jul 2023 08:11:56 +0000 (01:11 -0700)]
Merge pull request #26772 from seamuslee001/fix_unit_test_failure_wp_url
(dev/core#4433) Fix unit test failure on WordPress by specifying --entry=backend
Seamus Lee [Mon, 24 Jul 2023 07:39:30 +0000 (03:39 -0400)]
Merge pull request #26916 from eileenmcnaughton/line
[PHP8.2] Remove undefined property in favour of calc-as-needed
Eileen McNaughton [Mon, 24 Jul 2023 05:10:01 +0000 (17:10 +1200)]
[PHP8.2] Remove undefined property in favour of calc-as-needed
This appears to be one of those cases where they wanted to
'save the code the effort' of calculating twice - but
it is a trivial calculation balanced
against the confusion of setting an undefined
property in one place to use later
Eileen McNaughton [Mon, 24 Jul 2023 04:09:30 +0000 (16:09 +1200)]
Remove old broken code
colemanw [Mon, 24 Jul 2023 02:38:04 +0000 (19:38 -0700)]
Merge pull request #26904 from larssandergreen/css-fix-for-delete-button
Remove gap before delete button on contact
colemanw [Mon, 24 Jul 2023 02:35:09 +0000 (19:35 -0700)]
Merge pull request #26908 from eileenmcnaughton/member
Follow on cleanup - remove unused assign
colemanw [Mon, 24 Jul 2023 02:33:53 +0000 (19:33 -0700)]
Merge pull request #26909 from eileenmcnaughton/member_2
Stop setting undeclared property in previously shared code
colemanw [Mon, 24 Jul 2023 02:32:18 +0000 (19:32 -0700)]
Merge pull request #26891 from colemanw/missingEntity2
Managed - Log errors instead of throwing exceptions unless in debug mode
Seamus Lee [Mon, 24 Jul 2023 02:25:06 +0000 (22:25 -0400)]
Merge pull request #26907 from eileenmcnaughton/notice_pay
dev/core#4435 Fix e-notice with Manual processor
Eileen McNaughton [Mon, 24 Jul 2023 01:24:50 +0000 (13:24 +1200)]
Minor cleanup in test class
- reduce duplicate failure tests
- use local variables where possible
- return hints
- preferred capitialization of api entities
- start to remove callAPISuccessAndDocument
Tim Otten [Mon, 24 Jul 2023 00:56:18 +0000 (17:56 -0700)]
ManagedEntityTest - Look for the error... in a place where it will actually be...
Tim Otten [Mon, 24 Jul 2023 00:43:19 +0000 (17:43 -0700)]
Merge pull request #26910 from eileenmcnaughton/setting
dev/core#1926 Add docs link to civicrm.settings.php.template
Eileen McNaughton [Sun, 23 Jul 2023 23:51:20 +0000 (11:51 +1200)]
dev/core#1926 Add docs link to civicrm.settings.php.template
Eileen McNaughton [Sun, 23 Jul 2023 23:38:54 +0000 (11:38 +1200)]
Stop setting undeclared property in previously shared code
Eileen McNaughton [Sun, 23 Jul 2023 23:29:24 +0000 (11:29 +1200)]
Follow on cleanup - remove unused assign
Seamus Lee [Sat, 22 Jul 2023 23:37:36 +0000 (09:37 +1000)]
dev/core#4429 Fix checking to see if a price option is able to be used for CiviMember or CiviEvent
Eileen McNaughton [Sun, 23 Jul 2023 23:24:19 +0000 (11:24 +1200)]
Merge pull request #25458 from MegaphoneJon/lifetime-membership-fix-2
fix lifetime membership calc in contribution pages
Eileen McNaughton [Sun, 23 Jul 2023 23:14:36 +0000 (11:14 +1200)]
Fix e-notice with Manual processor
Eileen McNaughton [Sun, 23 Jul 2023 22:52:34 +0000 (10:52 +1200)]
Merge pull request #26906 from civicrm/5.64
5.64 to master
Eileen McNaughton [Sun, 23 Jul 2023 22:49:27 +0000 (10:49 +1200)]
Merge pull request #26893 from demeritcowboy/mistaken-identity
dev/core#4441 - Incorrect error "There might be a data problem, contribution id could not be loaded from the line item"
larssandergreen [Sun, 23 Jul 2023 18:41:07 +0000 (12:41 -0600)]
Remove gap before delete button on contact
demeritcowboy [Sun, 23 Jul 2023 16:20:31 +0000 (12:20 -0400)]
Merge pull request #26900 from totten/master-relurl
Fix relative URL generation when using alternate HTTP port
demeritcowboy [Sun, 23 Jul 2023 14:49:26 +0000 (10:49 -0400)]
Merge pull request #26890 from larssandergreen/Label-Page-Formats-follow-up
Link between Label Page Formats and Address Settings
larssandergreen [Sun, 23 Jul 2023 14:17:29 +0000 (08:17 -0600)]
Link between Label Page Formats and Address Settings
colemanw [Sat, 22 Jul 2023 06:10:16 +0000 (23:10 -0700)]
Merge pull request #26899 from colemanw/utilsArrayFixes
[REF] Fix CRM_Utils_Array calls that return potentially incorrect value types
colemanw [Sat, 22 Jul 2023 03:32:02 +0000 (20:32 -0700)]
(REF) Replace CRM_Utils_Array in more complex cases
colemanw [Sat, 22 Jul 2023 03:29:49 +0000 (20:29 -0700)]
CRM_Utils_String::munge() - Change test
colemanw [Sat, 22 Jul 2023 03:27:35 +0000 (20:27 -0700)]
(REF) Replace CRM_Utils_Array in context of date-time function calls
colemanw [Sat, 22 Jul 2023 03:24:36 +0000 (20:24 -0700)]
(REF) Replace CRM_Utils_Array in context of conditional expressions
colemanw [Sat, 22 Jul 2023 03:20:25 +0000 (20:20 -0700)]
(REF) Replace CRM_Utils_Array in context of string-building (HTML/SQL/URL/etc)
colemanw [Sat, 22 Jul 2023 03:10:47 +0000 (20:10 -0700)]
(REF) Replace CRM_Utils_Array having default ''
colemanw [Sat, 22 Jul 2023 03:08:59 +0000 (20:08 -0700)]
(REF) Replace CRM_Utils_Array in context of munge()
colemanw [Sat, 22 Jul 2023 03:03:47 +0000 (20:03 -0700)]
(REF) Replace CRM_Utils_Array in context of is_numeric()
colemanw [Sat, 22 Jul 2023 02:57:06 +0000 (19:57 -0700)]
(REF) Replace CRM_Utils_Array with equivalent `?? NULL`
Tim Otten [Sat, 22 Jul 2023 01:18:27 +0000 (18:18 -0700)]
Fix relative URL generation when using alternate HTTP port
Tim Otten [Sat, 22 Jul 2023 00:17:01 +0000 (17:17 -0700)]
(REF) Extract method CRM_Utils_Url::toRelative()
Aidan Saunders [Fri, 21 Jul 2023 20:26:02 +0000 (21:26 +0100)]
Merge pull request #26898 from colemanw/noBrowse
Remove 'browse' link that shouldn't be there
colemanw [Fri, 21 Jul 2023 17:25:02 +0000 (13:25 -0400)]
AdminUI - Add Administer Scheduled Reminders page
colemanw [Fri, 21 Jul 2023 17:15:17 +0000 (13:15 -0400)]
ActionSchedule - Add dynamic pseudoconstants and other metadata
colemanw [Fri, 21 Jul 2023 17:33:03 +0000 (13:33 -0400)]
Remove 'browse' link that shouldn't be there