Rich Lott / Artful Robot [Wed, 6 Sep 2023 08:58:15 +0000 (09:58 +0100)]
Move cache_fill_took to float/double; only update when there's a good value
Rich Lott / Artful Robot [Sun, 3 Sep 2023 07:14:53 +0000 (08:14 +0100)]
Change xml added and upgrader from 5.65 to 5.66
Rich Lott / Artful Robot [Fri, 1 Sep 2023 08:50:19 +0000 (09:50 +0100)]
Move to using CRM_Utils_Constant for CIVICRM_SLOW_SMART_GROUP_SECONDS
Rich Lott / Artful Robot [Fri, 1 Sep 2023 08:44:40 +0000 (09:44 +0100)]
Add xml, DAO and Upgrader task for smart group profiler
Rich Lott / Artful Robot [Fri, 1 Sep 2023 07:21:56 +0000 (08:21 +0100)]
Remove smart group profiling during populateTemporaryTableWithContactsInGroups
Rich Lott / Artful Robot [Fri, 1 Sep 2023 07:09:50 +0000 (08:09 +0100)]
Expose 5s 'slow' query to optional constant
Rich Lott / Artful Robot [Thu, 31 Aug 2023 17:15:22 +0000 (18:15 +0100)]
Minor nfc tweak to smart group profile code
Rich Lott / Artful Robot [Thu, 31 Aug 2023 17:08:52 +0000 (18:08 +0100)]
Add simple smart group profiler
Tim Otten [Sat, 16 Sep 2023 05:54:21 +0000 (22:54 -0700)]
Merge pull request #27430 from colemanw/bunnyDance
Resurrect Bunny Dance
colemanw [Sat, 16 Sep 2023 01:34:40 +0000 (21:34 -0400)]
Merge pull request #27303 from eileenmcnaughton/mailing_const
Remove unused/ unnecessary table name variables
colemanw [Sat, 16 Sep 2023 01:26:14 +0000 (21:26 -0400)]
Merge pull request #27417 from colemanw/searchKitSpreasheetPerformance
SearchKit - Improve performance of downloading spreadsheet
colemanw [Fri, 15 Sep 2023 21:32:22 +0000 (17:32 -0400)]
CRM_Case_ManagedEntities - Fix bugs caused by double-caching
The list of case types was being cached twice, once by CRM_Core_Pseudoconstant
and yet again in CRM_Case_XMLRepository::$allCaseTypes.
This made getting a fresh list of case types unnecessarily difficult.
demeritcowboy [Fri, 15 Sep 2023 23:16:35 +0000 (19:16 -0400)]
Merge pull request #27454 from civicrm/5.66
5.66
demeritcowboy [Fri, 15 Sep 2023 23:07:31 +0000 (19:07 -0400)]
Merge pull request #27452 from eileenmcnaughton/weight
Add weights on profile fields page (notices
demeritcowboy [Fri, 15 Sep 2023 23:06:52 +0000 (19:06 -0400)]
Merge pull request #27451 from eileenmcnaughton/email_comments
Add code comments re the cleanup I didn't do
demeritcowboy [Fri, 15 Sep 2023 22:41:54 +0000 (18:41 -0400)]
Merge pull request #27450 from demeritcowboy/weight566
backport of 27448
colemanw [Fri, 15 Sep 2023 22:24:29 +0000 (18:24 -0400)]
Merge pull request #27391 from eileenmcnaughton/user_email
Fix undefined properties on back-office pledge form
Eileen McNaughton [Fri, 15 Sep 2023 22:21:55 +0000 (10:21 +1200)]
Merge pull request #27435 from eileenmcnaughton/uf_profile_prefix
8.x Fix all instances of call Profile template to specify the prefix
Eileen McNaughton [Fri, 15 Sep 2023 22:14:44 +0000 (10:14 +1200)]
Add weights on profile fields page
ie https://dmaster.localhost:32353/civicrm/admin/uf/group/field?reset=1&action=browse&gid=1
Eileen McNaughton [Fri, 15 Sep 2023 22:07:33 +0000 (10:07 +1200)]
Add code comments re the cleanup I didn't do
I want the code to be stable in 5.66 for a few releases, absent any bugs so
commenting the further cleanup for 'one day'
demeritcowboy [Fri, 15 Sep 2023 13:39:17 +0000 (09:39 -0400)]
fix order
Eileen McNaughton [Fri, 15 Sep 2023 02:26:39 +0000 (14:26 +1200)]
Fix all instances of call Profile template to specify the prefix
demeritcowboy [Fri, 15 Sep 2023 21:36:41 +0000 (17:36 -0400)]
Merge pull request #27449 from braders/php8-CustomValueTest
[REF][PHP8.2] Remove dynamic property use in api_v3_CustomValueTest
Bradley Taylor [Fri, 15 Sep 2023 20:31:04 +0000 (21:31 +0100)]
[REF][PHP8.2] Remove dynamic property use in api_v3_CustomValueTest
demeritcowboy [Fri, 15 Sep 2023 18:25:19 +0000 (14:25 -0400)]
Merge pull request #27447 from demeritcowboy/block-local
Fix e_warning in smarty `{localize}`
colemanw [Fri, 15 Sep 2023 16:40:59 +0000 (12:40 -0400)]
Merge pull request #27425 from eileenmcnaughton/transfer
Remove some unused undeclared properties on SelfSvcTransfer form
colemanw [Fri, 15 Sep 2023 16:39:53 +0000 (12:39 -0400)]
Merge pull request #27424 from eileenmcnaughton/properties
Suppress rather than declare exception
demeritcowboy [Fri, 15 Sep 2023 16:36:21 +0000 (12:36 -0400)]
Merge pull request #27448 from demeritcowboy/contributionpageweight
fix ordering of contribution page links
colemanw [Fri, 15 Sep 2023 13:36:11 +0000 (09:36 -0400)]
CiviCase - Optimize managed reconcile
colemanw [Fri, 15 Sep 2023 01:10:44 +0000 (21:10 -0400)]
CiviCase - Prevent recursion when reconciling managed activity/relationship types & fix test
The createManagedRelationshipTypes and createManagedActivityTypes functions always use 'civicrm'
as the module name, so this reconciliation can target just that module to prevent recursion.
The ManagedCaseTypeTest was failing due to caching/timing issues.
Try this...
demeritcowboy [Fri, 15 Sep 2023 14:01:11 +0000 (10:01 -0400)]
Merge pull request #27434 from eileenmcnaughton/uf_array
8.x Fix a couple of notices when rendering profiles
colemanw [Fri, 15 Sep 2023 13:47:38 +0000 (09:47 -0400)]
Merge pull request #27431 from eileenmcnaughton/delete_participant
Fix notices when deleting participants
demeritcowboy [Fri, 15 Sep 2023 13:42:04 +0000 (09:42 -0400)]
Merge pull request #27444 from eileenmcnaughton/super
Superficial cleanup on Event Confirm - null object
demeritcowboy [Fri, 15 Sep 2023 13:39:17 +0000 (09:39 -0400)]
fix order
demeritcowboy [Fri, 15 Sep 2023 13:07:04 +0000 (09:07 -0400)]
Merge pull request #27442 from eileenmcnaughton/all
Remove unused variable from function signature
demeritcowboy [Fri, 15 Sep 2023 12:51:37 +0000 (08:51 -0400)]
e_warning
demeritcowboy [Fri, 15 Sep 2023 12:39:51 +0000 (08:39 -0400)]
Merge pull request #27445 from civicrm/5.66
5.66
demeritcowboy [Fri, 15 Sep 2023 12:12:55 +0000 (08:12 -0400)]
Merge pull request #27433 from eileenmcnaughton/help_pre
8.x Profiles Remove e-notices by removing never assigned help_pre, help_post
colemanw [Fri, 15 Sep 2023 12:09:31 +0000 (08:09 -0400)]
Merge pull request #27443 from eileenmcnaughton/part_
Fix variable leakage in online event receipt
colemanw [Fri, 15 Sep 2023 12:05:21 +0000 (08:05 -0400)]
Merge pull request #27407 from colemanw/contactNoteTab
SearchKit - Improve metadata, joins and links
demeritcowboy [Fri, 15 Sep 2023 11:49:07 +0000 (07:49 -0400)]
Merge pull request #27428 from eileenmcnaughton/custom_weight
Fix missing weights on Custom data screen (notices)
Herb [Thu, 7 Jul 2022 14:38:31 +0000 (10:38 -0400)]
Update BunnyDance.mgd.php
Eileen McNaughton [Fri, 15 Sep 2023 06:56:27 +0000 (18:56 +1200)]
Superficial cleanup on Event Confirm
str_starts_with is in our polyfill as @colemanw pointed out
Eileen McNaughton [Fri, 15 Sep 2023 05:07:42 +0000 (17:07 +1200)]
Fix variable leakage in online event receipt
colemanw [Fri, 15 Sep 2023 05:31:34 +0000 (01:31 -0400)]
Merge pull request #27438 from eileenmcnaughton/assign
Fix some variables to always assign
colemanw [Fri, 15 Sep 2023 05:24:03 +0000 (01:24 -0400)]
Merge pull request #27437 from eileenmcnaughton/no_1028
Remove references to invalid action
colemanw [Fri, 15 Sep 2023 05:07:54 +0000 (01:07 -0400)]
Merge pull request #27439 from eileenmcnaughton/captca
Remove broken recaptcha from profile preview
colemanw [Fri, 15 Sep 2023 04:52:59 +0000 (00:52 -0400)]
Merge pull request #27441 from eileenmcnaughton/test_set
Remove isset from template within unit tests
Eileen McNaughton [Wed, 6 Sep 2023 20:40:31 +0000 (08:40 +1200)]
Move scenario set up to trait
Eileen McNaughton [Fri, 15 Sep 2023 03:56:42 +0000 (15:56 +1200)]
Remove unused variable from function signature
Eileen McNaughton [Fri, 15 Sep 2023 03:48:17 +0000 (15:48 +1200)]
Remove isset from template within unit tests
Eileen McNaughton [Fri, 15 Sep 2023 03:40:16 +0000 (15:40 +1200)]
Merge pull request #27440 from civicrm/5.66
5.66 to master
Eileen McNaughton [Fri, 15 Sep 2023 03:29:00 +0000 (15:29 +1200)]
Remove broken recaptcha from profile preview
The reCaptcha variable is never assigned to profile preview - resulting
in it never rendering (but rendering notices). This code has been broken
for a while without someone noticing - remove
Eileen McNaughton [Fri, 15 Sep 2023 03:25:52 +0000 (15:25 +1200)]
Merge pull request #27436 from eileenmcnaughton/dep
Add deprecation notice to code that seems to be superceded
Eileen McNaughton [Fri, 15 Sep 2023 03:24:49 +0000 (15:24 +1200)]
Fix some variables to always assign
Eileen McNaughton [Fri, 15 Sep 2023 01:34:10 +0000 (13:34 +1200)]
Fix notices when deleting participants
Eileen McNaughton [Fri, 15 Sep 2023 03:05:24 +0000 (15:05 +1200)]
Remove outdated code comment
Eileen McNaughton [Fri, 15 Sep 2023 03:01:56 +0000 (15:01 +1200)]
Remove references to invalid action
All these references refer to comparing action to 1028. The comments make is clear that
they are looking for 'preview' mode - but preview mode is 1024. The checks are all
does-not-equal. So, they would have always been true for a very long time.
Copy & paste is dead long live copy & paste
colemanw [Fri, 15 Sep 2023 02:46:05 +0000 (22:46 -0400)]
Merge pull request #27432 from eileenmcnaughton/profile_weight
Add weights on profile links (remove notices)
Eileen McNaughton [Fri, 15 Sep 2023 02:37:54 +0000 (14:37 +1200)]
Add deprecation notice to code that seems to be superceded
Eileen McNaughton [Fri, 15 Sep 2023 02:16:53 +0000 (14:16 +1200)]
Fix a couple of notices when rendering profiles
colemanw [Fri, 15 Sep 2023 02:21:38 +0000 (22:21 -0400)]
Merge pull request #26042 from seamuslee001/ref_html_entities
[REF][PHP8.2] Fix deprecated usage of mb_convert_encoding with HTML-E…
Eileen McNaughton [Fri, 15 Sep 2023 02:07:25 +0000 (14:07 +1200)]
Remove e-notices by removing never assigned help_pre, help_post
Eileen McNaughton [Fri, 15 Sep 2023 01:56:13 +0000 (13:56 +1200)]
Add weights on profile links (remove notices)
Eileen McNaughton [Fri, 15 Sep 2023 00:48:57 +0000 (12:48 +1200)]
Merge pull request #27427 from eileenmcnaughton/notice_it
Fix another EventInfo notice
Eileen McNaughton [Mon, 11 Sep 2023 23:49:10 +0000 (11:49 +1200)]
Use local variable instead of undefined property for formType
Eileen McNaughton [Fri, 15 Sep 2023 00:01:13 +0000 (12:01 +1200)]
Fix EmailMode
Eileen McNaughton [Thu, 14 Sep 2023 23:59:40 +0000 (11:59 +1200)]
Fix customData Include notice
Eileen McNaughton [Thu, 14 Sep 2023 23:54:44 +0000 (11:54 +1200)]
Fix missing weights on Custom data screen (notices)
Eileen McNaughton [Thu, 14 Sep 2023 23:42:32 +0000 (11:42 +1200)]
Add getEventID() - this is part of an effort to ensure consistency
All event & participant forms should have public api functions for
getParticipantID() and getEventID() (participant ID
not so relevant here
Eileen McNaughton [Thu, 14 Sep 2023 23:43:26 +0000 (11:43 +1200)]
Merge pull request #27426 from eileenmcnaughton/pcp
Fix php notices in php dashboard code
Eileen McNaughton [Thu, 14 Sep 2023 23:37:05 +0000 (11:37 +1200)]
Remove unused variable
Seamus Lee [Mon, 10 Apr 2023 02:41:24 +0000 (12:41 +1000)]
[REF][PHP8.2] Fix deprecated usage of mb_convert_encoding with HTML-Entities
Eileen McNaughton [Thu, 14 Sep 2023 23:32:48 +0000 (11:32 +1200)]
Fix another EventInfo notice
Eileen McNaughton [Thu, 14 Sep 2023 23:15:39 +0000 (11:15 +1200)]
Merge pull request #27423 from eileenmcnaughton/notice_it
Fix notice on phone_ext
Eileen McNaughton [Thu, 14 Sep 2023 23:12:57 +0000 (11:12 +1200)]
Fix php notices in php dashboard code
Eileen McNaughton [Thu, 14 Sep 2023 22:51:00 +0000 (10:51 +1200)]
Always define participant ID
Eileen McNaughton [Thu, 14 Sep 2023 22:50:32 +0000 (10:50 +1200)]
Remove remaining undefined properties
Eileen McNaughton [Thu, 14 Sep 2023 22:40:06 +0000 (10:40 +1200)]
Use form helper rather than undefined property to validate checksum user
Eileen McNaughton [Thu, 14 Sep 2023 22:36:03 +0000 (10:36 +1200)]
Remove some unused undeclared properties on SelfSvcTransfer form
Eileen McNaughton [Thu, 14 Sep 2023 22:18:48 +0000 (10:18 +1200)]
Suppress rather than declare exception
This function can throw an exception but the circumstances are such an obscure site
misconfiguration error (ie the date values are not defined) that I don't think it
makes sense to communicate up to calling functions that they should possibly handle it
Eileen McNaughton [Thu, 14 Sep 2023 21:52:06 +0000 (09:52 +1200)]
Fix notice on phone_ext
Kurund Jalmi [Thu, 14 Sep 2023 16:16:00 +0000 (17:16 +0100)]
Merge pull request #27294 from colemanw/afformDataType
Afform - Fix getting and setting boolean/numeric types
colemanw [Thu, 14 Sep 2023 13:34:27 +0000 (09:34 -0400)]
AdminUi - Switch to new toolbar setting for search displays
colemanw [Thu, 14 Sep 2023 13:33:30 +0000 (09:33 -0400)]
CiviGrant - Switch to new toolbar searchKit display setting for summary tab
colemanw [Thu, 14 Sep 2023 12:22:16 +0000 (08:22 -0400)]
SearchKit - Toolbar buttons for search displays
This expands on the concept of the "Add New" button at the top of some displays,
to allow a variety of buttons in a row (aka toolbar).
Before: addButton was pretty simple, only one allowed
After: Toolbar buttons can evaluate tokens, check permissions and conditional rules
colemanw [Wed, 13 Sep 2023 16:48:59 +0000 (12:48 -0400)]
SearchKit - Fix invalid orderBy params
colemanw [Tue, 12 Sep 2023 20:49:17 +0000 (16:49 -0400)]
Afform - Allow weight to be set for contact summary blocks/tabs
Adds test cover for weight and also tab names from
a68ee65
Sets CiviGrant tab to its original weight (from when it was a component)
Yashodha Chaku [Thu, 14 Sep 2023 06:55:21 +0000 (12:25 +0530)]
Merge pull request #27366 from eileenmcnaughton/CRM
Remove always true if for required role_id field, add test for value
Seamus Lee [Thu, 14 Sep 2023 00:55:30 +0000 (10:55 +1000)]
Merge pull request #27421 from demeritcowboy/desc
Revert just merged 27412
demeritcowboy [Thu, 14 Sep 2023 00:37:11 +0000 (20:37 -0400)]
Revert "Fix notice on Membership Component Settings page"
This reverts commit
e3f43b1ab5af0d3cf1063ee45805b3c6b66b6c4c.
Seamus Lee [Thu, 14 Sep 2023 00:09:50 +0000 (10:09 +1000)]
Merge pull request #27412 from eileenmcnaughton/admin_notice
Fix notice on Membership Component Settings page
demeritcowboy [Wed, 13 Sep 2023 21:02:25 +0000 (17:02 -0400)]
Merge pull request #27419 from eileenmcnaughton/no_push
Remove legacy error handling
demeritcowboy [Wed, 13 Sep 2023 21:01:44 +0000 (17:01 -0400)]
Merge pull request #27420 from larssandergreen/follow-up-to-add-comment-on-custom-field-move
(NFC) Add comment for IS NOT NULL in moving custom fields
colemanw [Wed, 13 Sep 2023 20:57:54 +0000 (16:57 -0400)]
Merge pull request #27418 from demeritcowboy/reg
regen
larssandergreen [Wed, 13 Sep 2023 20:23:42 +0000 (14:23 -0600)]
Add comment for IS NOT NULL in moving custom fields
Eileen McNaughton [Wed, 13 Sep 2023 19:43:27 +0000 (07:43 +1200)]
Remove legacy error handling
Our practice now is to throw exceptions - this results in a hard
fatal within apiv4 usage
demeritcowboy [Wed, 13 Sep 2023 19:38:40 +0000 (15:38 -0400)]
Merge pull request #27413 from larssandergreen/Don't-copy-nulls-when-moving-custom-fields
dev/core#4568 Don't copy nulls when moving custom fields
demeritcowboy [Wed, 13 Sep 2023 19:24:52 +0000 (15:24 -0400)]
regen
demeritcowboy [Wed, 13 Sep 2023 19:15:06 +0000 (15:15 -0400)]
Merge pull request #27400 from eileenmcnaughton/legacy
dev/core#4112 stop installing legacycustomsearches on new installs