Eileen McNaughton [Tue, 9 Oct 2018 07:02:12 +0000 (08:02 +0100)]
Merge pull request #12908 from xurizaemon/GL425-warning_on_redirectToSSL
GL-425: Log a message if CiviCRM thinks SSL is not enabled
Eileen McNaughton [Tue, 9 Oct 2018 05:30:48 +0000 (06:30 +0100)]
Merge pull request #12907 from civicrm/5.7
5.7
Chris Burgess [Tue, 9 Oct 2018 05:16:24 +0000 (18:16 +1300)]
GL-425: Log a message if CiviCRM thinks SSL is not enabled
The enableSSL setting doesn't reliably detect the presence of SSL (especially
when behind SSL terminating proxies). This log message will allow people
affected by this behaviour to more readily debug it, because CiviCRM
will give them a clue to work with.
See https://lab.civicrm.org/dev/core/issues/425
Seamus Lee [Mon, 8 Oct 2018 23:48:44 +0000 (10:48 +1100)]
Merge pull request #12896 from seamuslee001/dev_core_421
dev/core#421 Fix issue where creating user driven message templates w…
Seamus Lee [Fri, 5 Oct 2018 02:31:38 +0000 (12:31 +1000)]
dev/core#421 Fix issue where creating user driven message templates was requireing the ssystem workflow message template permission as well
Wrap permission checking in the check_permissions param
Move Permission checking to BAO level from API
Allow for the fact that edit message templates permission should still be able to work on both sets of templates without the granular permissions. Also reduce duplication of code abit
Seamus Lee [Mon, 8 Oct 2018 20:59:53 +0000 (07:59 +1100)]
Merge pull request #12905 from totten/master-gitignore
Add `ext/` folder to .gitignore
Eileen McNaughton [Mon, 8 Oct 2018 16:44:19 +0000 (17:44 +0100)]
Merge pull request #12731 from eileenmcnaughton/setting_form
Setting form - start to sync preferences with Setting, using trait
eileen [Sun, 26 Aug 2018 23:34:00 +0000 (11:34 +1200)]
Make checkboxes save
Tim Otten [Mon, 8 Oct 2018 12:59:50 +0000 (13:59 +0100)]
Add `ext/` folder to .gitignore
This folder is populated in various build processes (civibuild's
`drupal-demo`, `wp-demo`, etc; as well as `distmaker`), and sometimes
I like to use it for personal things. Moreover, there is no committed
content inside here.
Eileen McNaughton [Mon, 8 Oct 2018 11:46:44 +0000 (12:46 +0100)]
Merge pull request #12902 from seamuslee001/towards_500
Move towards allowing sending 500 http errors back by switching civiE…
Seamus Lee [Mon, 8 Oct 2018 10:33:08 +0000 (21:33 +1100)]
Move towards allowing sending 500 http errors back by switching civiExit(1) to be just civiExit()
Seamus Lee [Mon, 8 Oct 2018 07:59:25 +0000 (18:59 +1100)]
Merge pull request #12898 from kenwest/dev_core_423
dev/core#423 MySQL 5.7 complains about 4.7.19 upgrade script
Eileen McNaughton [Sun, 7 Oct 2018 22:01:43 +0000 (23:01 +0100)]
Merge pull request #12829 from eileenmcnaughton/validate
Add validate api action for ContributionPage.submit
Eileen McNaughton [Sun, 7 Oct 2018 20:58:48 +0000 (21:58 +0100)]
Merge pull request #12900 from eileenmcnaughton/recur_tidy
[NFC] Minor cleanup, return preferred parameter
Tim Otten [Sun, 7 Oct 2018 15:07:04 +0000 (16:07 +0100)]
Merge pull request #12869 from dereklewis123/CW-892
Added missing field name in custom-field deletion dialog
eileen [Mon, 17 Sep 2018 02:58:42 +0000 (14:58 +1200)]
Add validate api action for ContributionPage.submit
eileen [Sun, 26 Aug 2018 22:39:51 +0000 (10:39 +1200)]
Move setting defaults to form
eileen [Sun, 26 Aug 2018 22:29:34 +0000 (10:29 +1200)]
Allow Preferences form to work from settings
eileen [Sun, 7 Oct 2018 10:54:25 +0000 (11:54 +0100)]
[NFC] Minor cleanup, return preferred parameter
The result parameter is the same as $recurring (save()) returns $this. But
it's more correct to return $recurring than result as
a) it's defined as a Contribute_BAO_ContributionRecur object which is correct.
b) it's the object passed through hooks
Eileen McNaughton [Sun, 7 Oct 2018 10:44:08 +0000 (11:44 +0100)]
Merge pull request #12899 from eileenmcnaughton/recur_tpl
Recur tpl
eileen [Sun, 7 Oct 2018 09:23:26 +0000 (10:23 +0100)]
Extract rows section of recur template to separate tpl, for readability
Eileen McNaughton [Sun, 7 Oct 2018 08:07:19 +0000 (09:07 +0100)]
Merge pull request #12821 from mattwire/updatesubscription_fix
Show recurring contribution links based on payment processor capabilities
Monish Deb [Sat, 6 Oct 2018 17:56:59 +0000 (23:26 +0530)]
Merge pull request #12875 from jitendrapurohit/core-411
dev/core#411 - Default currency shown on View participant and contrib…
Eileen McNaughton [Sat, 6 Oct 2018 17:49:11 +0000 (18:49 +0100)]
Merge pull request #12893 from samuelsov/NFC-datatables-style
(NFC) Make datatables in Activities Relationship tab adjust to screen size
Eileen McNaughton [Sat, 6 Oct 2018 15:14:13 +0000 (16:14 +0100)]
Merge pull request #12868 from mattwire/updatesubscription_datepicker
Switch UpdateSubscription to use datepicker
Eileen McNaughton [Sat, 6 Oct 2018 10:06:10 +0000 (11:06 +0100)]
Merge pull request #12897 from jmcclelland/issue422
ensure search on survey results works properly
Ken West [Sat, 6 Oct 2018 08:25:12 +0000 (18:25 +1000)]
MySQL 5.7 may bork when comparing datetime columns to '0000-00-00 00:00:00' so cast the column to a CHAR(20) when comparing
Jamie McClelland [Fri, 5 Oct 2018 20:55:51 +0000 (16:55 -0400)]
ensure search on survey results works properly
https://lab.civicrm.org/dev/core/issues/422
Monish Deb [Fri, 5 Oct 2018 20:38:25 +0000 (02:08 +0530)]
Merge pull request #12884 from colemanw/Remove
Remove crm.admin.js
Eileen McNaughton [Fri, 5 Oct 2018 13:41:57 +0000 (14:41 +0100)]
Merge pull request #12892 from yashodha/report-fixes
CRM-21677 - report clean up
Seamus Lee [Fri, 5 Oct 2018 02:32:15 +0000 (12:32 +1000)]
Merge pull request #12895 from civicrm/5.7
5.7
Tim Otten [Wed, 3 Oct 2018 21:39:59 +0000 (17:39 -0400)]
Merge pull request #12894 from seamuslee001/5.7
5.7
Tim Otten [Wed, 3 Oct 2018 14:55:02 +0000 (10:55 -0400)]
Update 5.6.0.md
Tim Otten [Wed, 3 Oct 2018 14:53:04 +0000 (10:53 -0400)]
Update 5.6.0.md
eileen [Sun, 23 Sep 2018 01:42:01 +0000 (13:42 +1200)]
Fix missing amount in soft credit mode
Andrew Hunt [Thu, 27 Sep 2018 20:53:46 +0000 (16:53 -0400)]
5.6.0 release notes: reorganize sections and fix up contributors
Alice Frumin [Thu, 27 Sep 2018 20:22:23 +0000 (16:22 -0400)]
5.6.0 release notes: bulk of edits
Andrew Hunt [Thu, 13 Sep 2018 16:18:48 +0000 (12:18 -0400)]
5.6.0 release notes: added boilerplate
Andrew Hunt [Thu, 13 Sep 2018 16:15:54 +0000 (12:15 -0400)]
5.6.0 release notes: raw from script
CiviCRM [Wed, 3 Oct 2018 18:28:56 +0000 (18:28 +0000)]
Set version to 5.8.alpha1
CiviCRM [Wed, 3 Oct 2018 18:24:33 +0000 (18:24 +0000)]
Set version to 5.7.beta1
Samuel Vanhove [Wed, 3 Oct 2018 15:45:26 +0000 (11:45 -0400)]
(NFC) Make datatables in Activities and Relationship tab adjust to the screen size
yashodha [Wed, 3 Oct 2018 14:16:56 +0000 (19:46 +0530)]
CRM-21677 - report clean up
Eileen McNaughton [Wed, 3 Oct 2018 00:25:43 +0000 (13:25 +1300)]
Merge pull request #12885 from yashodha/report-fixes
CRM-21677 - report clean up
Seamus Lee [Mon, 1 Oct 2018 21:39:59 +0000 (07:39 +1000)]
Merge pull request #12882 from colemanw/extpage
Fix invalid markup on extension page - remove dots from ids & classes
yashodha [Mon, 1 Oct 2018 11:19:33 +0000 (16:49 +0530)]
CRM-21677 - report clean up
Coleman Watts [Mon, 1 Oct 2018 01:36:14 +0000 (21:36 -0400)]
Remove crm.admin.js
Coleman Watts [Sat, 29 Sep 2018 19:29:30 +0000 (15:29 -0400)]
Fix invalid markup on extension page - remove dots from ids & classes
Tim Otten [Sat, 29 Sep 2018 00:56:18 +0000 (20:56 -0400)]
Merge pull request #12876 from colemanw/Don't
Don't mess up fragment links in nav menu
Seamus Lee [Fri, 28 Sep 2018 11:35:32 +0000 (21:35 +1000)]
Merge pull request #12879 from totten/master-contact-settings
(DX) Civi::contactSettings - Add a facade for working with the logged-in user's settings
Seamus Lee [Fri, 28 Sep 2018 05:01:27 +0000 (15:01 +1000)]
Merge pull request #12878 from colemanw/menu-icons
Add icons to top-level navigation menu
Seamus Lee [Fri, 28 Sep 2018 04:59:47 +0000 (14:59 +1000)]
Merge pull request #12877 from colemanw/MailingComponentDAO
Regenerate MailingComponent DAO file to reflect recent changes
Kevin Cristiano [Fri, 28 Sep 2018 02:13:58 +0000 (22:13 -0400)]
Regenerate sql for Add icons to top-level navigation menu (#7)
Eileen McNaughton [Fri, 28 Sep 2018 01:16:06 +0000 (13:16 +1200)]
Merge pull request #12790 from alifrumin/core362
dev/core#362 fix search functionality of contact reference fields in On Behalf Profiles
Eileen McNaughton [Fri, 28 Sep 2018 01:14:23 +0000 (13:14 +1200)]
Merge pull request #12874 from seamuslee001/lab_core_410
dev/core#410 Ensure that Email related fields in Scheduled Reminders …
Coleman Watts [Fri, 28 Sep 2018 00:35:55 +0000 (20:35 -0400)]
Update activity_tab_filter setting code to use new fascade
Eileen McNaughton [Thu, 27 Sep 2018 23:01:31 +0000 (11:01 +1200)]
Merge pull request #12867 from mattwire/entityformajaxcustomdatafreeze
Freeze custom data elements when viewing an entity
Tim Otten [Thu, 27 Sep 2018 21:05:06 +0000 (17:05 -0400)]
(DX) Civi::contactSettings - Add a facade for working with the logged-in user's settings
Before
------
To read/write a setting for the logged-in user, you need a snippet like this:
```php
$cid = CRM_Core_Session::getLoggedInContactID();
$myFilter = Civi::service('settings_manager')
->getBagByContact(NULL, $cid)
->get('activity_tab_filter');
```
After
-----
To read/write a setting for the logged-in user, you can use a snippet like this:
```php
$myFilter = Civi::contactSettings()->get('activity_tab_filter');
```
Technical Details
-----------------
* A convenience function like this is liable to be used in lazy circumstances where
the developer is unlikely to check their conditions carefully. Therefore, the
errors are reported as exceptions so that mistakes are easiliy revealed.
* This is technically a small contract change to `SettingsManager::getBagByContact()`
because it now interprets `$contactId===NULL` as meaning "the logged-in user".
However, I don't think NULL was a sensible value before, and this interface
isn't widely known/used.
Coleman Watts [Thu, 27 Sep 2018 20:05:39 +0000 (16:05 -0400)]
Regenerate MailingComponent DAO file to reflect recent changes
Coleman Watts [Thu, 27 Sep 2018 19:52:36 +0000 (15:52 -0400)]
Fix bad menu name
Coleman Watts [Thu, 27 Sep 2018 19:45:52 +0000 (15:45 -0400)]
Add icons to nav menu
Alice Frumin [Thu, 6 Sep 2018 18:08:45 +0000 (14:08 -0400)]
dev/core#362 fixing contact reference fields on On Behalf Profiles search and select functionality
Coleman Watts [Thu, 27 Sep 2018 19:03:47 +0000 (15:03 -0400)]
Don't mess up fragment links in nav menu
Jitendra Purohit [Thu, 27 Sep 2018 07:12:29 +0000 (12:42 +0530)]
dev/core#411 - Default currency shown on View participant and contribution page if payment is made with different currency
Seamus Lee [Thu, 27 Sep 2018 05:35:10 +0000 (15:35 +1000)]
dev/core#410 Ensure that Email related fields in Scheduled Reminders are not required when creating an SMS reminder and ensure that SMS Text Message field is required when creating an SMS reminder
Seamus Lee [Wed, 26 Sep 2018 09:34:55 +0000 (19:34 +1000)]
Merge pull request #12871 from civicrm/5.6
Merge 5.6 to master
Matthew Wire (MJW Consulting) [Tue, 25 Sep 2018 10:41:30 +0000 (11:41 +0100)]
Freeze custom data elements when viewing an entity
colemanw [Tue, 25 Sep 2018 15:32:21 +0000 (11:32 -0400)]
Merge pull request #12855 from colemanw/dev/core#391
dev/core#391 - Fix saving tags in profile
Coleman Watts [Fri, 21 Sep 2018 17:48:35 +0000 (13:48 -0400)]
dev/core#391 - Fix saving tags in profile
dl617 [Tue, 25 Sep 2018 11:14:41 +0000 (12:14 +0100)]
Added missing field name in custom-field deletion dialog
Matthew Wire (MJW Consulting) [Tue, 25 Sep 2018 10:52:28 +0000 (11:52 +0100)]
Switch UpdateSubscription to use datepicker and add metadata for all date fields in ContributionRecur
Eileen McNaughton [Tue, 25 Sep 2018 02:37:14 +0000 (14:37 +1200)]
Merge pull request #12865 from civicrm/5.6
5.6
Eileen McNaughton [Tue, 25 Sep 2018 00:28:02 +0000 (12:28 +1200)]
Merge pull request #12833 from mattwire/relationshipform_fix
dev/399 Fix saving of relationship permissions when relationship is b_a on form
Eileen McNaughton [Tue, 25 Sep 2018 00:27:17 +0000 (12:27 +1200)]
Merge pull request #12728 from pradpnayak/MailingComponent
Renamed Mailing Component entity
Eileen McNaughton [Mon, 24 Sep 2018 20:35:47 +0000 (08:35 +1200)]
Merge pull request #12863 from civicrm/5.6
5.6 to master
colemanw [Mon, 24 Sep 2018 19:35:42 +0000 (15:35 -0400)]
Merge pull request #12672 from eileenmcnaughton/fix_location_export_labels
Export code improvement
Coleman Watts [Mon, 24 Sep 2018 17:48:26 +0000 (13:48 -0400)]
Rename MailingComponent BAO
Coleman Watts [Mon, 24 Sep 2018 13:42:00 +0000 (09:42 -0400)]
Further fix to permission fields on relationship form
colemanw [Mon, 24 Sep 2018 12:46:14 +0000 (08:46 -0400)]
Merge pull request #12861 from eileenmcnaughton/locked
Fix typo in 5.5 upgrade script
eileen [Sun, 23 Sep 2018 08:04:51 +0000 (20:04 +1200)]
Fix typo in 5.5 upgrade script
Eileen McNaughton [Sun, 23 Sep 2018 22:05:46 +0000 (10:05 +1200)]
Merge pull request #12847 from mmyriam/patch-1
Add span to amount label in Confirm.tpl
colemanw [Sun, 23 Sep 2018 16:12:25 +0000 (12:12 -0400)]
Merge pull request #12858 from eileenmcnaughton/this
Fix typo
eileen [Sun, 23 Sep 2018 00:03:50 +0000 (12:03 +1200)]
Fix typo
https://lab.civicrm.org/dev/core/issues/402
Seamus Lee [Sat, 22 Sep 2018 20:34:12 +0000 (06:34 +1000)]
Merge pull request #12856 from seamuslee001/dev_core_281
dev/core#281 Fix invoice number in message template
Eileen McNaughton [Sat, 22 Sep 2018 01:28:15 +0000 (13:28 +1200)]
Merge pull request #12800 from mattwire/relationshiptab_format
Improve display of relationships tab
Eileen McNaughton [Sat, 22 Sep 2018 01:25:44 +0000 (13:25 +1200)]
Merge pull request #12854 from mattwire/cc_contribution_clears_email2
When submitting a standalone credit card contribution the contact email address should not be deleted
yashodha [Thu, 26 Jul 2018 07:13:25 +0000 (12:43 +0530)]
dev/core#281 Fix invoice number in message template
shift upgrade to 5.7.alpha1 and Get passing unit tests where template didn't exist before 4.6.alpha1
Seamus Lee [Fri, 21 Sep 2018 22:05:55 +0000 (08:05 +1000)]
Merge pull request #12773 from eileenmcnaughton/perf_conts
Use cached function for financialAccount retrieval.
Matthew Wire (MJW Consulting) [Fri, 21 Sep 2018 11:50:58 +0000 (12:50 +0100)]
Remove redundant code to get email address which we've already retrieved
Matthew Wire (MJW Consulting) [Fri, 21 Sep 2018 11:44:21 +0000 (12:44 +0100)]
When submitting a standalone credit card contribution the contact email address should not be deleted
colemanw [Fri, 21 Sep 2018 02:21:50 +0000 (22:21 -0400)]
Merge pull request #12853 from seamuslee001/nfc_case_dashboad
NFC Fix overindenting in caseDashboard template
Seamus Lee [Fri, 21 Sep 2018 02:20:06 +0000 (12:20 +1000)]
NFC Fix overindenting in caseDashboard template
Eileen McNaughton [Fri, 21 Sep 2018 02:15:29 +0000 (14:15 +1200)]
Merge pull request #12849 from seamuslee001/case_dashboard_indent_fix
(NFC) Fix indenting of Case DashBoard.tpl
colemanw [Fri, 21 Sep 2018 01:38:50 +0000 (21:38 -0400)]
Merge pull request #12748 from compucorp/370-no-new-tasks-and-documents-get-added-to-workflow
dev/core#370: No new tasks and documents get added to workflow
Seamus Lee [Fri, 21 Sep 2018 00:13:10 +0000 (10:13 +1000)]
Merge pull request #12846 from eileenmcnaughton/activitytest
[NFC] Add unit test to cover component ACLs.
Eileen McNaughton [Thu, 20 Sep 2018 22:50:47 +0000 (10:50 +1200)]
Merge pull request #12852 from eileenmcnaughton/master
5.6 to Master
eileen [Thu, 20 Sep 2018 22:48:29 +0000 (10:48 +1200)]
Merge branch '5.6' of https://github.com/civicrm/civicrm-core
Change-Id: I2dd0a9d8f83fe13b7f731db0b959a67e3dd0ae9f
Eileen McNaughton [Thu, 20 Sep 2018 22:42:04 +0000 (10:42 +1200)]
Merge pull request #12844 from totten/5.6-asg-opt-group
(dev/core#107) Fix regression which prevents editing CiviCase configuration
Seamus Lee [Thu, 20 Sep 2018 22:12:24 +0000 (08:12 +1000)]
Merge pull request #12850 from civicrm/5.6
5.6
Seamus Lee [Thu, 20 Sep 2018 22:11:55 +0000 (08:11 +1000)]
Merge pull request #12845 from eileenmcnaughton/activity56
Partial revert of pull/12559