eileen [Tue, 2 Jan 2024 01:50:08 +0000 (14:50 +1300)]
Deprecate passing in month
eileen [Tue, 2 Jan 2024 01:36:54 +0000 (14:36 +1300)]
Remove pass-by-reference
We have removed a bunch of these (added for php4.x support) with no
issues - it's only where there is inheritance we have
hit issues
Eileen McNaughton [Mon, 1 Jan 2024 20:55:58 +0000 (09:55 +1300)]
Merge pull request #28821 from eileenmcnaughton/add
Fix error due to merges co-inciding
eileen [Mon, 1 Jan 2024 20:52:45 +0000 (09:52 +1300)]
Fix error due to merges co-inciding
Eileen McNaughton [Mon, 1 Jan 2024 04:51:26 +0000 (17:51 +1300)]
Merge pull request #28808 from colemanw/canAggregate
SearchKit - Allow aggregate functions to be used without GroupBy
Eileen McNaughton [Mon, 1 Jan 2024 03:15:06 +0000 (16:15 +1300)]
Merge pull request #28818 from civicrm/5.69
Merge forward (5.69-rc to master)
Tim Otten [Mon, 1 Jan 2024 02:08:50 +0000 (20:08 -0600)]
Merge pull request #28718 from eileenmcnaughton/2_term
dev/core#3810 dev/core#3339 Fix handling of auto renew memberships where frequency_interval > 1
Eileen McNaughton [Mon, 1 Jan 2024 01:22:48 +0000 (14:22 +1300)]
Merge pull request #28811 from colemanw/searchDisplayRemoveColFix
SearchKit - Fix wrong column being removed from displays
Eileen McNaughton [Mon, 1 Jan 2024 00:29:42 +0000 (13:29 +1300)]
Merge pull request #28812 from colemanw/removeContactTypeField
APIv4 - Hide 'contact_type' from Individual,Organization,Household getFields
Eileen McNaughton [Sun, 31 Dec 2023 23:59:14 +0000 (12:59 +1300)]
Merge pull request #28783 from braders/php8-last-participant
[REF][PHP8.2] Declare _lastParticipant property
Eileen McNaughton [Sun, 31 Dec 2023 23:58:53 +0000 (12:58 +1300)]
Merge pull request #28815 from braders/event-additional-particiapant-properties
[REF][PHP8.2] Declare missing properties on CRM_Event_Form_Registration_AdditionalParticipant
colemanw [Sun, 31 Dec 2023 13:48:52 +0000 (08:48 -0500)]
Merge pull request #28775 from seamuslee001/dev_core_4841
dev/core#4841 Ensure that APIv4 have same default values which ensureā¦
Seamus Lee [Sun, 31 Dec 2023 05:37:57 +0000 (16:37 +1100)]
Merge pull request #28816 from braders/php8-discounts
[REF][PHP8.2] Cleanup discounts property in eventcart ext
Seamus Lee [Fri, 22 Dec 2023 00:50:49 +0000 (11:50 +1100)]
dev/core#4841 Ensure that APIv4 have same default values which ensures that all required selects are filled out when creating new bulk mailing from Search Kit
Update as per coleman and fix Test fails
Fix calls to defaultComponent to fix test fails
colemanw [Sat, 30 Dec 2023 22:45:43 +0000 (17:45 -0500)]
Merge pull request #28730 from eileenmcnaughton/recur_cancel_api_2
Stop bypassing hooks on ContributionRecur.cancel
Bradley Taylor [Sat, 30 Dec 2023 20:16:42 +0000 (20:16 +0000)]
[REF][PHP8.2] Cleanup discounts property in eventcart ext
Bradley Taylor [Sat, 30 Dec 2023 18:17:50 +0000 (18:17 +0000)]
[REF][PHP8.2] Declare missing properties on CRM_Event_Form_Registration_AdditionalParticipant
colemanw [Sat, 30 Dec 2023 15:58:44 +0000 (09:58 -0600)]
APIv4 - Remove 'contact_type' from Individual,Organization,Household
This field is irrelevant to these pseudo-entities and shouldn't need to be used at all.
Before: Creating a new SearchKit search for Individual includes Contact Type in the default columns.
After: Now it doesn't, and the field is completely hidden for all but the Contact entity.
colemanw [Sat, 30 Dec 2023 16:16:44 +0000 (10:16 -0600)]
Merge pull request #28799 from eileenmcnaughton/date_consolidate
Consolidate import date handling
colemanw [Sat, 30 Dec 2023 16:11:25 +0000 (10:11 -0600)]
Merge pull request #28753 from eileenmcnaughton/search_settings
Clean up search settings page, update group cache text
colemanw [Sat, 30 Dec 2023 16:05:29 +0000 (10:05 -0600)]
Merge pull request #28748 from eileenmcnaughton/dep
Bubble up deprecation if getVar used to get a deprecated property
colemanw [Sat, 30 Dec 2023 03:06:37 +0000 (21:06 -0600)]
Merge pull request #28814 from MegaphoneJon/anonymous-acl-cache
Don't try to insert 0 as a user_id to ACL contact cache
demeritcowboy [Fri, 29 Dec 2023 23:05:54 +0000 (18:05 -0500)]
Merge pull request #28813 from colemanw/deletePhantomJsPolyfill
Remove unused phantomjs-polyfill package
colemanw [Fri, 29 Dec 2023 21:00:05 +0000 (15:00 -0600)]
Remove unused phantomjs-polyfill package
As of
23051b6 we no longer use PhantomJS so this package should not be needed.
Jon Goldberg [Fri, 29 Dec 2023 21:05:49 +0000 (16:05 -0500)]
Don't try to insert 0 as a user_id to ACL contact cache
colemanw [Fri, 29 Dec 2023 20:24:32 +0000 (14:24 -0600)]
SearchKit - Fix wrong column being removed from displays
Fixes recent regression from
4099cd6 causing the wrong column to be removed from a display.
To reproduce: Create a search display, go back to the main search criteria and delete a column,
then tab back to the display. The deleted column should have been removed but instead the wrong
one is still there.
Yashodha Chaku [Fri, 29 Dec 2023 17:22:46 +0000 (22:52 +0530)]
Merge pull request #28776 from eileenmcnaughton/submit
Remove api annotation from getSubmittableFields()
Eileen McNaughton [Fri, 29 Dec 2023 03:44:16 +0000 (16:44 +1300)]
Merge pull request #28809 from civicrm/5.69
5.69 to master
Eileen McNaughton [Fri, 29 Dec 2023 03:43:50 +0000 (16:43 +1300)]
Merge pull request #28807 from alifrumin/5.69rn
[NFC] 5.69 Release Notes first pass
colemanw [Fri, 29 Dec 2023 03:19:52 +0000 (21:19 -0600)]
SearchKit - Allow aggregate functions to be used without GroupBy
Fixes https://lab.civicrm.org/dev/core/-/issues/2415
demeritcowboy [Fri, 29 Dec 2023 00:28:13 +0000 (19:28 -0500)]
Merge pull request #28804 from eileenmcnaughton/regen
Update regen for event message template
Alice Frumin [Tue, 12 Dec 2023 19:33:06 +0000 (14:33 -0500)]
[NFC] 5.69 release notes first pass
demeritcowboy [Thu, 28 Dec 2023 18:49:24 +0000 (13:49 -0500)]
Merge pull request #28803 from eileenmcnaughton/notice
E-notice fix in membership workflow examples
demeritcowboy [Thu, 28 Dec 2023 18:48:23 +0000 (13:48 -0500)]
Merge pull request #28798 from eileenmcnaughton/date_test
NFC Superficial cleanup in test class
demeritcowboy [Thu, 28 Dec 2023 18:46:29 +0000 (13:46 -0500)]
Merge pull request #28805 from eileenmcnaughton/code_notes
[NFC] Add todos to the invoice code
Eileen McNaughton [Wed, 13 Dec 2023 05:17:40 +0000 (18:17 +1300)]
Add todos to the invoice code
This helps clarify that most of this code is slated for removal
in order to make the forms non-form-dependent
Eileen McNaughton [Thu, 28 Dec 2023 05:15:42 +0000 (18:15 +1300)]
Update regen for event message template
Eileen McNaughton [Thu, 28 Dec 2023 03:43:33 +0000 (16:43 +1300)]
Merge pull request #28801 from eileenmcnaughton/fork/mapping-edit-button-fix
Fix edit button for 'Import/Export Mapping'
eileen [Thu, 28 Dec 2023 03:13:32 +0000 (16:13 +1300)]
E-notice fix in membership workflow examples
19ATF72 [Wed, 6 Dec 2023 00:05:16 +0000 (16:05 -0800)]
Fix edit button for 'Import/Export Mapping'
eileen [Thu, 28 Dec 2023 01:01:56 +0000 (14:01 +1300)]
Consolidate import date handling
eileen [Thu, 28 Dec 2023 00:02:57 +0000 (13:02 +1300)]
NFC Superficial cleanup in test class
demeritcowboy [Wed, 27 Dec 2023 23:11:19 +0000 (18:11 -0500)]
Merge pull request #28797 from eileenmcnaughton/nfc
[NFC] Superficial cleanup
eileen [Wed, 27 Dec 2023 21:13:35 +0000 (10:13 +1300)]
[NFC] Superficial cleanup
Yashodha Chaku [Wed, 27 Dec 2023 08:36:25 +0000 (14:06 +0530)]
Merge pull request #28788 from eileenmcnaughton/assign
Fix codeGen assign to do what it says on the box
colemanw [Wed, 27 Dec 2023 00:42:33 +0000 (19:42 -0500)]
Merge pull request #28738 from mlutfy/maxSpin
menubar spin: stop after 10 seconds
colemanw [Wed, 27 Dec 2023 00:40:57 +0000 (19:40 -0500)]
Merge pull request #28794 from demeritcowboy/del
update deleted files list
demeritcowboy [Tue, 26 Dec 2023 16:06:53 +0000 (11:06 -0500)]
deleted files list
demeritcowboy [Tue, 26 Dec 2023 16:52:27 +0000 (11:52 -0500)]
Merge pull request #28793 from civicrm/5.69
5.69
demeritcowboy [Tue, 26 Dec 2023 16:03:41 +0000 (11:03 -0500)]
Merge pull request #28781 from vingle/5.69-ux-regressions
Fixes two small accordion UX regressions
demeritcowboy [Tue, 26 Dec 2023 15:58:57 +0000 (10:58 -0500)]
Merge pull request #28673 from bb/migrate-snappy-to-composer
Migrate Snappy to composer
Eileen McNaughton [Tue, 26 Dec 2023 00:09:45 +0000 (13:09 +1300)]
Merge pull request #28792 from civicrm/5.69
5.69 to master
Eileen McNaughton [Tue, 26 Dec 2023 00:08:42 +0000 (13:08 +1300)]
Merge pull request #28791 from eileenmcnaughton/569
Fix typo in smarty compatibility class
colemanw [Mon, 25 Dec 2023 00:30:57 +0000 (19:30 -0500)]
Merge pull request #28782 from mlutfy/extList
Manage Extensions: hide the type/module column
Mathieu Lu [Fri, 22 Dec 2023 19:45:47 +0000 (14:45 -0500)]
Manage Extensions: hide the type/module column
Eileen McNaughton [Sun, 24 Dec 2023 04:21:14 +0000 (17:21 +1300)]
Fix typo in smarty compatibility class
demeritcowboy [Sun, 24 Dec 2023 03:18:55 +0000 (22:18 -0500)]
Merge pull request #28790 from eileenmcnaughton/str_contains
Remove str_contains from civicrm.settings template
colemanw [Sun, 24 Dec 2023 00:41:05 +0000 (19:41 -0500)]
Merge pull request #28787 from eileenmcnaughton/get_template_vars
Standardise `getTemplateVars()`
Eileen McNaughton [Sat, 23 Dec 2023 23:44:27 +0000 (12:44 +1300)]
Remove str_contains from civicrm.settings template
Eileen McNaughton [Sat, 23 Dec 2023 21:07:22 +0000 (10:07 +1300)]
Fix codeGen assign to do what it says on the box
Eileen McNaughton [Sat, 23 Dec 2023 20:55:43 +0000 (09:55 +1300)]
Standardise getTemplateVars()
Eileen McNaughton [Sat, 23 Dec 2023 00:58:55 +0000 (13:58 +1300)]
Merge pull request #28785 from MegaphoneJon/delete-grant-false-error
remove incorrect message that grant could not be deleted
Jon Goldberg [Fri, 22 Dec 2023 23:15:52 +0000 (18:15 -0500)]
remove incorrect message that grant could not be deleted
colemanw [Fri, 22 Dec 2023 21:54:45 +0000 (16:54 -0500)]
Merge pull request #28780 from eileenmcnaughton/mut
Compiance with php8 & Marvel9
Bradley Taylor [Fri, 22 Dec 2023 20:26:05 +0000 (20:26 +0000)]
[REF][PHP8.2] Declare _lastParticipant property
Eileen McNaughton [Fri, 22 Dec 2023 10:33:27 +0000 (23:33 +1300)]
Compiance with php8 & Marvel9
colemanw [Fri, 22 Dec 2023 16:11:01 +0000 (11:11 -0500)]
Merge pull request #28771 from eileenmcnaughton/blt_cms
Remove checks to bltID in cms classes
colemanw [Fri, 22 Dec 2023 16:06:18 +0000 (11:06 -0500)]
Merge pull request #28770 from eileenmcnaughton/blt
Stop referring to `_bltID` in AbstractEditPayment
Nicol [Fri, 22 Dec 2023 13:07:48 +0000 (14:07 +0100)]
Adds support for fieldset
In this commit: https://github.com/civicrm/civicrm-core/commit/
1602ec3e104de40e7bd785496f0cde323fe870ed the `display: none` was narrowed to only target divs with the class '.collapsed'. This excluded a few examples of fieldsets being used (as identified in ThemeTest, Accordion 4 - https://lab.civicrm.org/extensions/themetest/-/blob/main/ang/themetest/snippets/accordion4.html)
Nicol [Fri, 22 Dec 2023 12:58:07 +0000 (13:58 +0100)]
Keeps search criteria fieldset closed when results found
Fixes search regression introduced in #28421 and identified in #28661.
demeritcowboy [Fri, 22 Dec 2023 03:24:56 +0000 (22:24 -0500)]
Merge pull request #28760 from eileenmcnaughton/case_dec
Declare caseId, caseIds as public properties
colemanw [Fri, 22 Dec 2023 02:53:08 +0000 (21:53 -0500)]
Merge pull request #28773 from eileenmcnaughton/cart_82
[PHP8.2] Fix test fails on event cart
Eileen McNaughton [Fri, 22 Dec 2023 01:57:44 +0000 (14:57 +1300)]
Remove api annotation from getSubmittableFields()
This should either be public or api-supported. Perhaps it should be public/api but
at least for now I will resolve by removing the annotation
Eileen McNaughton [Thu, 21 Dec 2023 23:38:15 +0000 (12:38 +1300)]
[PHP8.2] Fix test fails on event cart
Eileen McNaughton [Thu, 21 Dec 2023 23:20:17 +0000 (12:20 +1300)]
Stop referring to _bltID in AbstractEditPayment
Eileen McNaughton [Thu, 21 Dec 2023 23:28:12 +0000 (12:28 +1300)]
Merge pull request #28758 from braders/php8-smsCommonTest
[REF][PHP8.2] Use correct form object to ensure properties exist
Eileen McNaughton [Thu, 21 Dec 2023 23:27:49 +0000 (12:27 +1300)]
Remove checks to bltID in cms classes
Eileen McNaughton [Thu, 21 Dec 2023 22:40:53 +0000 (11:40 +1300)]
Merge pull request #28768 from eileenmcnaughton/dep_test
Remove deprecated test-only function
Bradley Taylor [Thu, 21 Dec 2023 19:53:45 +0000 (19:53 +0000)]
[REF][PHP8.2] Use correct form object to ensure properties exist
Eileen McNaughton [Thu, 21 Dec 2023 22:33:49 +0000 (11:33 +1300)]
Merge pull request #28764 from eileenmcnaughton/cart_form
Use local variables for the billing location type ID in event cart code
Eileen McNaughton [Thu, 21 Dec 2023 22:25:21 +0000 (11:25 +1300)]
Merge pull request #28759 from braders/cancel-url
[REF] Tidy up use of _cancelURL property
Eileen McNaughton [Thu, 21 Dec 2023 22:16:06 +0000 (11:16 +1300)]
Merge pull request #28767 from eileenmcnaughton/abstract
Remove bltID as a parameter from getPaymentProcessorReadyAddressParams
Eileen McNaughton [Thu, 21 Dec 2023 22:15:43 +0000 (11:15 +1300)]
Merge pull request #28456 from braders/php82-option
[REF][PHP8.2] Resolve dynamic property usage in CRM_Price_Form_Option
Eileen McNaughton [Thu, 21 Dec 2023 22:07:12 +0000 (11:07 +1300)]
Merge pull request #28739 from MegaphoneJon/contact-fields-to-remove
Unit test for fix to illegal offset error when grouping by contact in SK
Eileen McNaughton [Thu, 21 Dec 2023 22:06:45 +0000 (11:06 +1300)]
Merge pull request #28765 from eileenmcnaughton/map
Fix a few more places that pass bltID to mapParams
Eileen McNaughton [Thu, 21 Dec 2023 21:59:36 +0000 (10:59 +1300)]
Merge pull request #28761 from eileenmcnaughton/cart
Stop setting `_bltID` on the `UpdateBilling` form
Eileen McNaughton [Thu, 21 Dec 2023 21:57:55 +0000 (10:57 +1300)]
Merge pull request #28763 from eileenmcnaughton/payment_form
Use lookup not form property for BillingID in payment form class
Eileen McNaughton [Thu, 21 Dec 2023 21:15:40 +0000 (10:15 +1300)]
Merge pull request #28755 from braders/local-var-taggroup
[REF][PHP8.2] Local variable for tagGroup
Eileen McNaughton [Thu, 21 Dec 2023 21:13:20 +0000 (10:13 +1300)]
Remove deprecated test-only function
Eileen McNaughton [Thu, 21 Dec 2023 20:58:05 +0000 (09:58 +1300)]
Remove bltID as a parameter from getPaymentProcessorReadyAddressParams
Eileen McNaughton [Thu, 21 Dec 2023 20:53:36 +0000 (09:53 +1300)]
Fix a few more places that pass bltID to mapParams
Eileen McNaughton [Thu, 21 Dec 2023 20:44:58 +0000 (09:44 +1300)]
Stop using bltID in event cart class
Eileen McNaughton [Thu, 21 Dec 2023 20:42:26 +0000 (09:42 +1300)]
Use lookup not form property for BillingID in payment form class
colemanw [Thu, 21 Dec 2023 20:27:00 +0000 (15:27 -0500)]
Merge pull request #28740 from colemanw/searchKitDisplayPresentation
dev/user-interface#49 - Improve SearchKit admin display presentation
Benjamin Bock [Sun, 17 Dec 2023 16:03:39 +0000 (17:03 +0100)]
Migrate Snappy to composer
Eileen McNaughton [Thu, 21 Dec 2023 20:21:25 +0000 (09:21 +1300)]
Stop setting bltID on the UpdateBilling for
demeritcowboy [Thu, 21 Dec 2023 20:17:07 +0000 (15:17 -0500)]
Merge pull request #28273 from bb/master
Add weasyprint pdf generation as alternative to wkhtmltopdf
Jon Goldberg [Wed, 20 Dec 2023 20:03:13 +0000 (15:03 -0500)]
SearchKit - Unit test for illegal offset error when grouping by contact
Eileen McNaughton [Thu, 21 Dec 2023 20:09:56 +0000 (09:09 +1300)]
Declare caseId, caseIds as public properties
Bradley Taylor [Thu, 21 Dec 2023 20:07:56 +0000 (20:07 +0000)]
[REF] Tidy up use of _cancelURL property