Seamus Lee [Mon, 17 May 2021 08:39:26 +0000 (18:39 +1000)]
Merge pull request #20320 from eileenmcnaughton/managed
Add unit test for #20144
Seamus Lee [Mon, 17 May 2021 08:00:10 +0000 (18:00 +1000)]
Merge pull request #19840 from MikeyMJCO/patch-7
Explicitly throw an error/status bounce on Edit/New if no types.
Seamus Lee [Tue, 11 May 2021 23:56:09 +0000 (09:56 +1000)]
[REF] Make use of recently added default pager size setting in Reports
Update code as per feedback from Dave D
Eileen McNaughton [Mon, 17 May 2021 06:56:40 +0000 (18:56 +1200)]
Add unit test for #20144
Eileen McNaughton [Mon, 17 May 2021 05:09:57 +0000 (17:09 +1200)]
[REF] Add getter for contributionID
Eileen McNaughton [Mon, 17 May 2021 05:19:29 +0000 (17:19 +1200)]
Remove extraneous debug
We added this a while back when we were getting reports of an error that
we couldn't track down. We never got feedback of these lines appearing in the
logs and the error appears to be otherwise solved so
I think the debug adds more confusion & has not proven helpful
Seamus Lee [Mon, 17 May 2021 04:48:41 +0000 (14:48 +1000)]
Merge pull request #20316 from eileenmcnaughton/ppp
[REF] Switch to using getContributionRecurID function, remove now unused param
Seamus Lee [Mon, 17 May 2021 04:46:48 +0000 (14:46 +1000)]
Merge pull request #20281 from colemanw/afformDragDrop
Afform drag n drop fixes
Seamus Lee [Mon, 17 May 2021 04:33:56 +0000 (14:33 +1000)]
Merge pull request #20317 from eileenmcnaughton/pp
[REF] Fully remove ids variable from paypal std
Eileen McNaughton [Mon, 17 May 2021 03:54:37 +0000 (15:54 +1200)]
Merge pull request #20302 from totten/master-extver-ui
(dev/release#17) Extension UI - Show developmental icon for alpha/beta-stage extensions
Eileen McNaughton [Mon, 17 May 2021 02:54:12 +0000 (14:54 +1200)]
Merge pull request #20310 from eileenmcnaughton/group_lock
Cleanup tracking on group.load
Eileen McNaughton [Mon, 17 May 2021 02:27:48 +0000 (14:27 +1200)]
Merge pull request #20081 from totten/master-authx-defaults
authx - Accept API keys by default
Eileen McNaughton [Mon, 17 May 2021 02:27:30 +0000 (14:27 +1200)]
Merge pull request #20229 from pradpnayak/usercreate
Activate user when no activation is required
eileen [Mon, 3 May 2021 05:18:12 +0000 (17:18 +1200)]
Fix self-service recurring link on dashboard
This picks up on two of the issues that were blocking on
https://github.com/civicrm/civicrm-core/pull/18787 and
https://github.com/civicrm/civicrm-core/pull/18196
(but does not solve all of them). It
1) adds the basis for unit test cover and
2) separates the function for retrieving links
for self-service from back office user.
I think there is still some jumbling together of these concepts but
as long as we are careful to extend the tests as we extend the logic...
This fixes what I suspect is an oldish regression whereby the cancel link
for paypal std users was wrong
Eileen McNaughton [Mon, 17 May 2021 02:15:16 +0000 (14:15 +1200)]
Merge pull request #20214 from ixiam/dev#issue_2584
Separates the default language for contacts from the site language
eileen [Mon, 3 May 2021 04:18:06 +0000 (16:18 +1200)]
Improve unit test on rendered urls
Coleman Watts [Tue, 11 May 2021 16:34:05 +0000 (12:34 -0400)]
APIv4 - Use bulk method for saving custom fields
Renames the prototype bulkSave => writeRecords to follow the convention now in APIv4 and CRM_Core_DAO
Coleman Watts [Tue, 11 May 2021 16:22:48 +0000 (12:22 -0400)]
APIv4 - Default to saving and deleting DAO records in bulk
This adds new writeRecords() and deleteRecords() methods
to CRM_Core_DAO which can be overridden by DAOs who wish to optimize.
Eileen McNaughton [Mon, 17 May 2021 02:04:40 +0000 (14:04 +1200)]
[REF] Fully remove ids variable from paypal std
The ids variable is no longer used - bye
Coleman Watts [Mon, 17 May 2021 01:54:55 +0000 (21:54 -0400)]
Extension page markup tweaks
Eileen McNaughton [Sun, 16 May 2021 02:01:49 +0000 (14:01 +1200)]
Duplicate & deprecate processMembership
Function only called from one place + tests. Duplicate to where it is
called & deprecated as it seems civimobile may be using this
(in an unsupported way but we shouldn't actively break it since we are aware of that)
Eileen McNaughton [Mon, 17 May 2021 01:49:24 +0000 (13:49 +1200)]
[REF] Switch to using getContributionRecurID function, remove now unused param
This is a follow up to https://github.com/civicrm/civicrm-core/pull/20294
- getContributionRecurID now always has the id so we don't need to pass it around
in the ids array
Eileen McNaughton [Sat, 15 May 2021 01:27:08 +0000 (13:27 +1200)]
Cleanup tracking on group.load
1) deprecate force parameter
2) ditch the static & let the db lookups speak for themselves
The force paramter seems to mostly be about the static & probably only exists to support tests.
The static doesn't make sense now because either they group needs loading or it doesn't.
The fact the process might have tried and succeeded or failed before doesn't need
to be recorded in the static
Cleanup up progress tracking in Group::load
Fix test to do things in a logical order so contacts exist when the group is created
demeritcowboy [Sun, 16 May 2021 15:23:55 +0000 (11:23 -0400)]
Merge pull request #20314 from mattwire/contactdetailacl
Switch to non deprecated buildPermissionClause() for contact detail report
Matthew Wire [Sun, 16 May 2021 14:04:47 +0000 (15:04 +0100)]
Merge pull request #20209 from eileenmcnaughton/qfail
Do not error on view contribution recur if not displaying contributions
Matthew Wire [Sun, 16 May 2021 14:03:51 +0000 (15:03 +0100)]
Merge pull request #20300 from eileenmcnaughton/pp
dev/core#2593 stop calling loadRelatedObjects / fix for bug
Matthew Wire [Sun, 16 May 2021 14:00:35 +0000 (15:00 +0100)]
Merge pull request #20294 from eileenmcnaughton/ppp
[REF] Provide standardised methods to get recurring contribution id & object
Matthew Wire [Sun, 16 May 2021 13:53:00 +0000 (14:53 +0100)]
Merge pull request #20211 from eileenmcnaughton/reorg
[REF] Reverse if statement
Matthew Wire [Sun, 16 May 2021 13:35:30 +0000 (14:35 +0100)]
Merge pull request #20205 from eileenmcnaughton/dep_pend
Remove deprecation of order-must-be-pending
Matthew Wire [Sun, 16 May 2021 13:30:18 +0000 (14:30 +0100)]
Switch to non deprecated buildPermissionClause() for contact detail report
Vangelis Pantazis [Sun, 16 May 2021 08:04:40 +0000 (09:04 +0100)]
Separates the default language for contacts from the site language
Seamus Lee [Sun, 16 May 2021 01:04:23 +0000 (11:04 +1000)]
Merge pull request #20312 from seamuslee001/improve_sample_data_trxn_id_payment_procesor_link
Improve Sample data by ensuring all Credit Card Contributions have a …
demeritcowboy [Sat, 15 May 2021 23:10:27 +0000 (19:10 -0400)]
Merge pull request #20304 from eileenmcnaughton/mem_move2
Remove never-passed parameter from now unshared function
Seamus Lee [Sat, 15 May 2021 22:45:32 +0000 (08:45 +1000)]
Improve Sample data by ensuring all Credit Card Contributions have a transaction id and tha they are shown to be linked to the test payment processor
Seamus Lee [Sat, 15 May 2021 21:46:15 +0000 (07:46 +1000)]
Merge pull request #20311 from demeritcowboy/dummy
dev/core#2614 - Sample payment processor is the wrong id in the generated sample data for demos
demeritcowboy [Sat, 15 May 2021 19:27:00 +0000 (15:27 -0400)]
the id keeps changing so look it up by name
demeritcowboy [Sat, 15 May 2021 16:03:30 +0000 (12:03 -0400)]
Merge pull request #20082 from mattwire/paypalwarning
Add warning when url_site is not specified for paypal (it won't work if not set)
demeritcowboy [Sat, 15 May 2021 02:04:39 +0000 (22:04 -0400)]
Merge pull request #20139 from eileenmcnaughton/home_url
Remove defunct default return property
Jamie McClelland [Fri, 14 May 2021 19:01:38 +0000 (15:01 -0400)]
get county fields populated via api call
Ensure that county fields are properly populated when
calling the Profile.getfields api.
Coleman Watts [Fri, 14 May 2021 15:52:09 +0000 (11:52 -0400)]
SearchKit - Rename crmSearchActions module to crmSearchTasks & add hook_civicrm_searchKitTasks().
Aidan Saunders [Fri, 14 May 2021 14:37:00 +0000 (15:37 +0100)]
Add defaults for APIv4 Case
- default Case Creator = current user
- default Case start date = now
Seamus Lee [Fri, 14 May 2021 10:16:09 +0000 (20:16 +1000)]
Merge pull request #20216 from colemanw/afformEntityRef
Afform Gui - Add support for entityRef fields
Eileen McNaughton [Fri, 14 May 2021 06:10:52 +0000 (18:10 +1200)]
[REF] Remove unused parameters
This takes out some parameters that are never passed in & stops returning things that are unused
Eileen McNaughton [Fri, 14 May 2021 06:17:29 +0000 (18:17 +1200)]
Remove never-passed parameter from now unshared parameter
Eileen McNaughton [Fri, 14 May 2021 05:58:15 +0000 (17:58 +1200)]
dev/core#2593 stop calling loadRelatedObjects
We are no longer using ids after this function so we don't need to
call that function to load them.
In addition this extacts getContribution & reflects the fact the contact_id
is only being used to warn if the contribution is not a match (in
the debug log)
Eileen McNaughton [Fri, 14 May 2021 05:50:45 +0000 (17:50 +1200)]
Merge pull request #20299 from eileenmcnaughton/pp
Remove now-unused ids parameter from signature
Tim Otten [Fri, 14 May 2021 04:57:36 +0000 (21:57 -0700)]
(dev/release#17) Extension UI - Show developmental icon for alpha/beta-stage extensions
Extensions are published with two fields, `<version>` (e.g. `1.1`) and `<develStage>` (e.g. `alpha`).
Confusingly, the two fields sometimes convey redundant information - but not always. A few cases:
* For example, sometimes a `<version>` as `1.0-alpha1`, `1.2.beta2`, or `2.3dev`. This would make sense if the
developer does formal tagging/releasing for developmental versions. (In this case, you don't really need the
icon - because the version-number tells you.)
* Other times, you might have a `<version>` which simply says `1.0` or `2.0` -- and then supplemental
information where the `<develStage>` says `alpha` or `beta`. This could make sense if the developmental
version is being continuously updated without formal tags/releases.
* Under dev/release#17, we have another case -- where the core-extensions have version#s which match the
core version# (because they are released together), but the devel-stage of the extension is only
alpha/beta (because the extension is still evolving/optional/not-fully-supported).
Before: The "Development Stage" is entirely obscure.
After: There's an icon in the table to signal the development stage.
Tim Otten [Fri, 14 May 2021 04:52:42 +0000 (21:52 -0700)]
(REF) Extensions - Remove dead code
To see that this code is unused, simply grep the entire source-tree for `upgradable`
and `upgradeVersion`. There is nothing that would plausible set these fields.
I think this is left-over from an older UX. When there's an upgrade available in this UX, it shows
an alert box under the "Description".
Tim Otten [Fri, 14 May 2021 05:18:52 +0000 (22:18 -0700)]
(dev/release#17) ext/*/info.xml - Update versions to match core version
Tim Otten [Fri, 14 May 2021 02:41:32 +0000 (19:41 -0700)]
(NFC) ext/*/info.xml - Normalize whitespace
Tim Otten [Fri, 14 May 2021 02:53:59 +0000 (19:53 -0700)]
(dev/release#17) For new versions, auto-update ext/{$CORE_EXT}/info.xml
Tim Otten [Fri, 14 May 2021 02:53:45 +0000 (19:53 -0700)]
(REF, dev/release#17) Move list of core-exts to separate file
Eileen McNaughton [Fri, 14 May 2021 03:43:50 +0000 (15:43 +1200)]
[REF] Add getters for contribution id & contact id
Eileen McNaughton [Fri, 14 May 2021 00:22:49 +0000 (12:22 +1200)]
[REF] Provide standardised methods to get recurring contribution id & object
This adds methods to get the recurring contribution id & object that work from the paypal
express and from the paypal pro flows. In the paypal express flow it is
retrieved from a known value (and this flow is only ever hit for recurrings
as evidenced by the existing getsingle) and then set on the class. For paypal pro
it is optional and will be in the cheap-to-access POST array if relevant
Eileen McNaughton [Fri, 14 May 2021 03:39:26 +0000 (15:39 +1200)]
Remove now-unused ids parameter from signature
Eileen McNaughton [Fri, 14 May 2021 03:35:11 +0000 (15:35 +1200)]
Merge pull request #20293 from eileenmcnaughton/pp
[REF] Use function to getContributionRecurID
Eileen McNaughton [Fri, 14 May 2021 02:57:25 +0000 (14:57 +1200)]
Merge pull request #20295 from eileenmcnaughton/mem_move
[REF] Duplicate processMembership preliminary to cleanup
Eileen McNaughton [Thu, 13 May 2021 23:42:29 +0000 (11:42 +1200)]
[REF] Use function to getContributionRecurID
We are simply fetching it from the POST so it's cheap to fetch & we can stop passing it around
once we are using a function, not a variable. This also changes the debug logging slightly
to pass the values more correctly to log->debug().
Eileen McNaughton [Fri, 14 May 2021 01:17:51 +0000 (13:17 +1200)]
[REF] Duplicate processMembership preliminary to cleanup
This used to be shared by 3 places. We've copied & cleaned up one. This duplicates to the
second once I've done some cleaning up I'll deprecate this & also duplicate to the 3rd
demeritcowboy [Fri, 14 May 2021 00:30:08 +0000 (20:30 -0400)]
Merge pull request #20287 from mattwire/contactreportaclduplicates
Switch to non deprecated buildPermissionClause() for contact summary report
Seamus Lee [Thu, 13 May 2021 23:03:46 +0000 (09:03 +1000)]
Merge pull request #20288 from demeritcowboy/fintypeaccount
[NFC/TEST] - Add unit test enforcing automatic chaining for financial type/account creation via api
Seamus Lee [Thu, 13 May 2021 23:02:57 +0000 (09:02 +1000)]
Merge pull request #20290 from civicrm/5.38
5.38
Seamus Lee [Thu, 13 May 2021 22:31:26 +0000 (08:31 +1000)]
Merge pull request #20246 from eileenmcnaughton/ft
dev/core#2593 [REF] Fix function signature to actually-used variables
Matthew Wire [Thu, 13 May 2021 19:31:55 +0000 (20:31 +0100)]
Switch to non deprecated buildPermissionClause() for contact summary report
Seamus Lee [Thu, 13 May 2021 21:07:41 +0000 (07:07 +1000)]
Merge pull request #20289 from seamuslee001/5.38
5.37.{1|2} release notes
Tim Otten [Thu, 13 May 2021 01:33:27 +0000 (18:33 -0700)]
Add release-notes/5.37.2.md
Tim Otten [Tue, 11 May 2021 22:02:14 +0000 (15:02 -0700)]
fixup release-notes/5.37.1.md
Tim Otten [Tue, 11 May 2021 21:32:40 +0000 (14:32 -0700)]
Add release-notes/5.37.1.md
Seamus Lee [Thu, 13 May 2021 21:03:30 +0000 (07:03 +1000)]
Merge pull request #20286 from agh1/5.38.0-releasenotes-initial
5.38.0 release notes initial run
demeritcowboy [Thu, 13 May 2021 20:22:57 +0000 (16:22 -0400)]
add test enforcing automatic chaining for financial type/account create
Andrew Hunt [Thu, 13 May 2021 19:05:13 +0000 (15:05 -0400)]
5.38.0 release notes: added boilerplate
Andrew Hunt [Thu, 13 May 2021 19:00:30 +0000 (15:00 -0400)]
5.38.0 release notes: raw from script
Coleman Watts [Wed, 12 May 2021 23:43:59 +0000 (19:43 -0400)]
Afform GUI - Scroll fieldset into view when selecting entity
Coleman Watts [Wed, 12 May 2021 18:19:03 +0000 (14:19 -0400)]
Afform - improve drag-n-drop UI
Fixes a number of issues with drag-n-drop on the Afform GUI palette & canvas.
Forces panels to take up full vertical space so palette never scrolls offscreen.
Compresses tabs above palette to save space.
Coleman Watts [Thu, 13 May 2021 16:40:23 +0000 (12:40 -0400)]
Fix CKEditor5 link editing in modal dialog
Fixes https://lab.civicrm.org/extensions/ckeditor5/-/issues/4
Monish Deb [Thu, 13 May 2021 15:20:00 +0000 (20:50 +0530)]
Merge pull request #20077 from eileenmcnaughton/mem_order
Use order api when creating a recurring membership from the Membershi…
demeritcowboy [Thu, 13 May 2021 13:18:03 +0000 (09:18 -0400)]
Merge pull request #20259 from agileware/CIVICRM-1734
Change the help text for Message Templates and Scheduled Reminders to include link to CiviCRM Token Documentation page
Coleman Watts [Tue, 4 May 2021 20:58:51 +0000 (16:58 -0400)]
Afform Gui - Add support for entityRef fields
Adds a widget for EntityRef and allows it to be changed to Number (for entering ID)
or Select (for choosing another entity on a form).
Seamus Lee [Thu, 13 May 2021 10:00:09 +0000 (20:00 +1000)]
Merge pull request #20284 from civicrm/5.38
5.38
Seamus Lee [Thu, 13 May 2021 08:28:05 +0000 (18:28 +1000)]
Merge pull request #20264 from colemanw/afformJoinSaveFix
Afform - Fix saving joined entities (email, address, phone, etc)
Seamus Lee [Thu, 13 May 2021 08:26:27 +0000 (18:26 +1000)]
Merge pull request #20283 from colemanw/afformEnabledEntities
Afform - hide disabled contact types & entities from disabled components/extensions
Coleman Watts [Thu, 13 May 2021 04:07:01 +0000 (00:07 -0400)]
Afform - hide disabled contact types & entities from disabled components/extensions
Seamus Lee [Thu, 13 May 2021 00:22:13 +0000 (10:22 +1000)]
Merge pull request #20280 from civicrm/5.38
5.38
Coleman Watts [Mon, 10 May 2021 15:18:16 +0000 (11:18 -0400)]
Afform - Fix saving joined entities (email, address, phone, etc)
Seamus Lee [Thu, 13 May 2021 00:03:41 +0000 (10:03 +1000)]
Merge pull request #20276 from demeritcowboy/help-pre
Typo when retrieving help_pre textarea attributes for price field
Eileen McNaughton [Wed, 12 May 2021 23:57:37 +0000 (11:57 +1200)]
Merge pull request #20208 from seamuslee001/move_acl_test_trait
[REF] Move ACLPermission Trait into Civi Folder so that it can be acc…
Seamus Lee [Wed, 12 May 2021 22:52:43 +0000 (08:52 +1000)]
Merge pull request #20277 from eileenmcnaughton/538
Fix money formatting opps
Aidan Saunders [Wed, 12 May 2021 19:46:46 +0000 (20:46 +0100)]
Give the custom css file a 'name' to make it easier to manipulate in
hook_civicrm_alterBundle()
Eileen McNaughton [Wed, 12 May 2021 19:40:30 +0000 (07:40 +1200)]
Merge pull request #20275 from demeritcowboy/big-c
dev/core#2606 - Typo in rowCount variable in pager
Eileen McNaughton [Wed, 12 May 2021 19:34:44 +0000 (07:34 +1200)]
Fix money formatting opps
As Matt points out we regressed this when adding 2 decimal places
https://github.com/civicrm/civicrm-core/commit/
78b338e07464becd1555a2c7d2d04ac0e4e9180c#diff-3d2a990f0b1960f0b3e6671c645e18033883e6d1eaf535b8d19d085b67dde00bR1171
demeritcowboy [Wed, 12 May 2021 14:18:00 +0000 (10:18 -0400)]
letter needs to be bigger
demeritcowboy [Wed, 12 May 2021 14:14:51 +0000 (10:14 -0400)]
ancient latin
Eileen McNaughton [Wed, 12 May 2021 04:51:27 +0000 (16:51 +1200)]
Merge pull request #20270 from demeritcowboy/relative
dev/core#2590 - Remove unused function CRM_Utils_File::relativeDirectory
Seamus Lee [Wed, 12 May 2021 03:26:50 +0000 (13:26 +1000)]
Merge pull request #20263 from colemanw/afformDragFix
Afform - Drag & drop fixes
Eileen McNaughton [Wed, 12 May 2021 03:17:36 +0000 (15:17 +1200)]
Merge pull request #20271 from totten/5.38ormaster-perm-cleanup
(REF) dev/core#2601 - Cleanup stale parameter
Eileen McNaughton [Wed, 12 May 2021 03:16:44 +0000 (15:16 +1200)]
Merge pull request #20258 from eileenmcnaughton/tear
[NFC] Test - Improve tearDown cleanup of domain contacts
Eileen McNaughton [Tue, 11 May 2021 06:14:20 +0000 (18:14 +1200)]
Improve tearDown cleanup of domain contacts
Fixes to ensure the domain contacts from addresses are re-instated
Seamus Lee [Tue, 11 May 2021 23:08:01 +0000 (09:08 +1000)]
Merge pull request #18969 from seamuslee001/dev_core_2187
dev/core#2187 Allow sites to customise the default number of rows ret…
Tim Otten [Tue, 11 May 2021 21:52:46 +0000 (14:52 -0700)]
(REF) dev/core#2601 - Cleanup stale parameter
Overview
--------
This cleans up a parameter that became unused/unnecessary in #20256.
History
-------
This revision is a little bouncy. Instead of before/after, here's a history:
* `<= v5.36`: `getAllModulePermissions($descriptions = FALSE)`
* `= v5.37.0`: `getAllModulePermissions($descriptions = FALSE, &$permissions)`
* `>= v.37.1`: `getAllModulePermissions($descriptions = FALSE)`
I grepped `universe` to confirm that no other repos were using the intermediate signature.
Seamus Lee [Fri, 13 Nov 2020 21:31:08 +0000 (08:31 +1100)]
dev/core#2187 Allow sites to customsie the default number of rows returned from QuickForm Searches