civicrm-core.git
12 months agoMerge pull request #28454 from colemanw/searchKitMenuHide
Rich Lott [Sun, 3 Dec 2023 18:37:09 +0000 (18:37 +0000)]
Merge pull request #28454 from colemanw/searchKitMenuHide

SearchKit - Hide empty menus

12 months agoMerge pull request #28435 from eileenmcnaughton/notice_new_member
Matthew Wire [Sun, 3 Dec 2023 18:36:00 +0000 (18:36 +0000)]
Merge pull request #28435 from eileenmcnaughton/notice_new_member

Fix notices on view membership

12 months agoMerge pull request #28430 from vingle/a11y-accordions
Matthew Wire [Sun, 3 Dec 2023 18:35:40 +0000 (18:35 +0000)]
Merge pull request #28430 from vingle/a11y-accordions

Applies accessible accordion to contact dashboard, replaces old accordion pattern

12 months agoMerge pull request #28440 from artfulrobot/artfulrobot-standalone-user-timestamps
Rich Lott [Sun, 3 Dec 2023 18:34:17 +0000 (18:34 +0000)]
Merge pull request #28440 from artfulrobot/artfulrobot-standalone-user-timestamps

standalone: implement User fields when_last_accessed and when_updated

12 months agoSearchKit - Hide empty menus
colemanw [Sun, 3 Dec 2023 18:32:19 +0000 (18:32 +0000)]
SearchKit - Hide empty menus

12 months agoMerge pull request #28418 from vingle/a11y-accordions-2
Matthew Wire [Sun, 3 Dec 2023 18:28:56 +0000 (18:28 +0000)]
Merge pull request #28418 from vingle/a11y-accordions-2

Applies accessible accordion to Advanced Search

12 months agoMerge pull request #28443 from ufundo/asset-builder-test
Matthew Wire [Sun, 3 Dec 2023 18:27:46 +0000 (18:27 +0000)]
Merge pull request #28443 from ufundo/asset-builder-test

Asset builder test

12 months agoMerge pull request #28427 from ufundo/standalone-bootstrap-script
colemanw [Sun, 3 Dec 2023 18:26:09 +0000 (18:26 +0000)]
Merge pull request #28427 from ufundo/standalone-bootstrap-script

Standalone - bootstrap script fixes

12 months agoMerge pull request #28446 from braders/php8-task-delete
colemanw [Sun, 3 Dec 2023 18:25:01 +0000 (18:25 +0000)]
Merge pull request #28446 from braders/php8-task-delete

[REF][PHP8.2] Declare properties in CRM_Contact_Form_Task_Delete

12 months agoMerge pull request #28447 from wmortada/standalone-admin-role
Rich Lott [Sun, 3 Dec 2023 17:59:25 +0000 (17:59 +0000)]
Merge pull request #28447 from wmortada/standalone-admin-role

Standalone - give admin role super permission

12 months agoMerge pull request #28405 from eileenmcnaughton/payment_send
demeritcowboy [Sun, 3 Dec 2023 17:38:39 +0000 (12:38 -0500)]
Merge pull request #28405 from eileenmcnaughton/payment_send

Update Payment or receipt notification template

12 months ago[REF][PHP8.2] Declare properties in CRM_Contact_Form_Task_Delete
Bradley Taylor [Sun, 3 Dec 2023 17:13:15 +0000 (17:13 +0000)]
[REF][PHP8.2] Declare properties in CRM_Contact_Form_Task_Delete

12 months agoStandalone - give admin role super permission
William Mortada [Sun, 3 Dec 2023 17:11:03 +0000 (17:11 +0000)]
Standalone - give admin role super permission

12 months agotestUrl: pass all the params needed to build crm-l10n.js
benjamin [Sun, 3 Dec 2023 16:11:51 +0000 (16:11 +0000)]
testUrl: pass all the params needed to build crm-l10n.js

12 months agodedicated function get l10n js asset build params
benjamin [Sun, 3 Dec 2023 16:10:40 +0000 (16:10 +0000)]
dedicated function get l10n js asset build params

12 months agoMerge pull request #28434 from eileenmcnaughton/notice_add_member
colemanw [Sun, 3 Dec 2023 15:50:22 +0000 (15:50 +0000)]
Merge pull request #28434 from eileenmcnaughton/notice_add_member

Fix notices on new membership

12 months agoMerge pull request #28439 from greenpeace-cee/fix-get-user-id-from-username
colemanw [Sun, 3 Dec 2023 15:45:16 +0000 (15:45 +0000)]
Merge pull request #28439 from greenpeace-cee/fix-get-user-id-from-username

dev/core#2998 - Fix standalone throwing exception when fetching unkno…

12 months agoMerge pull request #28428 from colemanw/cacheWrapper
Tim Otten [Sun, 3 Dec 2023 14:17:00 +0000 (14:17 +0000)]
Merge pull request #28428 from colemanw/cacheWrapper

Add CRM_Utils_CacheWrapper to all caches

12 months agostandalone: implement User fields when_last_accessed and when_updated
Rich Lott / Artful Robot [Sun, 3 Dec 2023 13:15:47 +0000 (13:15 +0000)]
standalone: implement User fields when_last_accessed and when_updated
When last accessed tracks when the logged in user last
made a PHP request to the site, limited to one update per minute.

When updated tracks when a user record was updated.

12 months agodev/core#2998 - Fix standalone throwing exception when fetching unknown user
Patrick Figel [Sun, 3 Dec 2023 11:27:41 +0000 (11:27 +0000)]
dev/core#2998 - Fix standalone throwing exception when fetching unknown user

This fixes an issue where getUserIDFromUsername() was throwing an exception
when fetching unknown users, rather than return NULL.

12 months agoMerge pull request #28422 from colemanw/userRoleCache
colemanw [Sun, 3 Dec 2023 08:35:19 +0000 (08:35 +0000)]
Merge pull request #28422 from colemanw/userRoleCache

Standalone - Flush cache when saving user role

12 months agoAdd CRM_Utils_CacheWrapper to all caches
colemanw [Sat, 2 Dec 2023 19:08:46 +0000 (19:08 +0000)]
Add CRM_Utils_CacheWrapper to all caches

This wraps all caches and dispatches a 'civi.cache.clear' event when deleting items from the cache.

12 months agoMerge pull request #28404 from eileenmcnaughton/version
demeritcowboy [Sun, 3 Dec 2023 04:18:01 +0000 (23:18 -0500)]
Merge pull request #28404 from eileenmcnaughton/version

Stop forcing apiVersion to 3 in setUp

12 months agoStop forcing apiVersion to 3 in setUp
Eileen McNaughton [Sat, 2 Dec 2023 04:33:47 +0000 (17:33 +1300)]
Stop forcing apiVersion to 3 in setUp

It should be possible to override it at a class level...

12 months agoremoves defunct comment
Nicol [Sun, 3 Dec 2023 01:18:19 +0000 (01:18 +0000)]
removes defunct comment

12 months agoMerge branch 'civicrm:master' into a11y-accordions-2
Nicol [Sun, 3 Dec 2023 01:15:26 +0000 (01:15 +0000)]
Merge branch 'civicrm:master' into a11y-accordions-2

12 months agoFix notices on view membership
Eileen McNaughton [Sat, 2 Dec 2023 23:15:51 +0000 (12:15 +1300)]
Fix notices on view membership

12 months agoFix notices on event section of payment or refund notification
Eileen McNaughton [Sat, 2 Dec 2023 05:31:24 +0000 (18:31 +1300)]
Fix notices on event section of payment or refund notification

12 months agoAdd support for financial trxn tokens
Eileen McNaughton [Sat, 2 Dec 2023 06:31:00 +0000 (19:31 +1300)]
Add support for financial trxn tokens

12 months agoRemove text version of payment_or_refund notification
Eileen McNaughton [Sat, 2 Dec 2023 20:21:30 +0000 (09:21 +1300)]
Remove text version of payment_or_refund notification

12 months agoMerge pull request #28432 from braders/php8-household-summary
demeritcowboy [Sat, 2 Dec 2023 23:28:49 +0000 (18:28 -0500)]
Merge pull request #28432 from braders/php8-household-summary

[REF][PHP8.2] Declare properties in HouseholdSummary report

12 months agoFix notices on new membership
Eileen McNaughton [Sat, 2 Dec 2023 23:27:28 +0000 (12:27 +1300)]
Fix notices on new membership

12 months agostandalone bootstrap script fixes
benjamin [Sat, 2 Dec 2023 18:29:37 +0000 (18:29 +0000)]
standalone bootstrap script fixes

12 months ago[REF][PHP8.2] Declare properties in HouseholdSummary report
Bradley Taylor [Sat, 2 Dec 2023 20:42:46 +0000 (20:42 +0000)]
[REF][PHP8.2] Declare properties in HouseholdSummary report

12 months agoMerge pull request #28426 from wmortada/standalone-edit-role
Eileen McNaughton [Sat, 2 Dec 2023 20:10:15 +0000 (09:10 +1300)]
Merge pull request #28426 from wmortada/standalone-edit-role

Standalone - set default value to active when adding new user role

12 months agoUpdate CustomDataView.tpl
Nicol [Sat, 2 Dec 2023 19:22:21 +0000 (19:22 +0000)]
Update CustomDataView.tpl

Makes the contact dashboard accordions for custom fields accessible using the <details><summary> pattern.

12 months agoMerge branch 'civicrm:master' into a11y-accordions-2
Nicol [Sat, 2 Dec 2023 18:47:03 +0000 (18:47 +0000)]
Merge branch 'civicrm:master' into a11y-accordions-2

12 months agoMerge pull request #28424 from artfulrobot/artfulrobot-fix-login-standalone
Rich Lott [Sat, 2 Dec 2023 18:14:03 +0000 (18:14 +0000)]
Merge pull request #28424 from artfulrobot/artfulrobot-fix-login-standalone

Fix confusing login screen on standalone + pretty up

12 months agoStandalone - set default value to active
William Mortada [Sat, 2 Dec 2023 18:07:24 +0000 (18:07 +0000)]
Standalone - set default value to active

12 months agoStandalone - Flush cache when saving user role
colemanw [Sat, 2 Dec 2023 16:44:30 +0000 (16:44 +0000)]
Standalone - Flush cache when saving user role

12 months agoMerge pull request #28410 from totten/master-sa-extrest
Rich Lott [Sat, 2 Dec 2023 17:39:09 +0000 (17:39 +0000)]
Merge pull request #28410 from totten/master-sa-extrest

LegacyRestTest - No need to test `extern/rest.php` on `Standalone`

12 months agoMerge pull request #28408 from totten/master-sa-locdat
Rich Lott [Sat, 2 Dec 2023 17:35:17 +0000 (17:35 +0000)]
Merge pull request #28408 from totten/master-sa-locdat

LocalizedDataTest - Fix for standalone

12 months agoMerge pull request #28416 from braders/php8-activity-page-tab
demeritcowboy [Sat, 2 Dec 2023 17:31:54 +0000 (12:31 -0500)]
Merge pull request #28416 from braders/php8-activity-page-tab

[REF][PHP8.2] Declare properties in CRM_Activity_Page_Tab

12 months agoFix annoying whitespace to left of menu in standalone
Rich Lott / Artful Robot [Sat, 2 Dec 2023 17:19:12 +0000 (17:19 +0000)]
Fix annoying whitespace to left of menu in standalone

12 months agoMerge pull request #28417 from braders/unused-job-property
demeritcowboy [Sat, 2 Dec 2023 17:12:48 +0000 (12:12 -0500)]
Merge pull request #28417 from braders/unused-job-property

[REF][PHP8.2] Remove unused dynamic property

12 months agoPretty up the forgotted password screen in standaloen
Rich Lott / Artful Robot [Sat, 2 Dec 2023 16:44:33 +0000 (16:44 +0000)]
Pretty up the forgotted password screen in standaloen

12 months agoMerge pull request #28415 from vingle/a11y-accordions
colemanw [Sat, 2 Dec 2023 16:53:08 +0000 (16:53 +0000)]
Merge pull request #28415 from vingle/a11y-accordions

Adds an accessible accordion, applies to news-feed dashlet

12 months agoMerge pull request #28393 from eileenmcnaughton/suffix
colemanw [Sat, 2 Dec 2023 16:49:34 +0000 (16:49 +0000)]
Merge pull request #28393 from eileenmcnaughton/suffix

Add suffix to sort name

12 months agoMerge pull request #28413 from jaapjansma/staff_role_and_permissions
Mathieu Lu [Sat, 2 Dec 2023 16:21:18 +0000 (11:21 -0500)]
Merge pull request #28413 from jaapjansma/staff_role_and_permissions

dev/core#4466: added Standalone role and permissions for staff

12 months agoUpdate Advanced.tpl
Nicol [Sat, 2 Dec 2023 16:06:15 +0000 (16:06 +0000)]
Update Advanced.tpl

12 months agoRedirect to /civicrm when /civicrm/login accessed and already logged in
Rich Lott / Artful Robot [Sat, 2 Dec 2023 15:54:38 +0000 (15:54 +0000)]
Redirect to /civicrm when /civicrm/login accessed and already logged in

12 months agoUpdate AdvancedCriteria.tpl
Nicol [Sat, 2 Dec 2023 15:47:47 +0000 (15:47 +0000)]
Update AdvancedCriteria.tpl

Makes the advanced search page more accessible.

12 months agoMerge pull request #28407 from greenpeace-cee/fix-standalone-jwt-cookie-test
Mathieu Lu [Sat, 2 Dec 2023 15:34:27 +0000 (10:34 -0500)]
Merge pull request #28407 from greenpeace-cee/fix-standalone-jwt-cookie-test

dev/core#2998 - Fix JWT cookie test in standalone

12 months agoMerge branch 'civicrm:master' into a11y-accordions
Nicol [Sat, 2 Dec 2023 15:33:05 +0000 (15:33 +0000)]
Merge branch 'civicrm:master' into a11y-accordions

12 months agoMerge pull request #28411 from artfulrobot/artfulrobot-standalone-extern-test
Tim Otten [Sat, 2 Dec 2023 15:29:09 +0000 (15:29 +0000)]
Merge pull request #28411 from artfulrobot/artfulrobot-standalone-extern-test

"Fix" test fail E2E_Extern_WidgetTest::testWidget by skipping it

12 months agodev/core#4466: added role and permissions for staff
Jaap Jansma [Sat, 2 Dec 2023 15:10:21 +0000 (16:10 +0100)]
dev/core#4466: added role and permissions for staff

12 months ago[REF][PHP8.2] Remove unused dynamic property
Bradley Taylor [Sat, 2 Dec 2023 14:33:25 +0000 (14:33 +0000)]
[REF][PHP8.2] Remove unused dynamic property

12 months ago[REF][PHP8.2] Declare properties in CRM_Activity_Page_Tab
Bradley Taylor [Sat, 2 Dec 2023 14:25:16 +0000 (14:25 +0000)]
[REF][PHP8.2] Declare properties in CRM_Activity_Page_Tab

12 months agoUpdate Blog.tpl
Nicol [Sat, 2 Dec 2023 13:58:20 +0000 (13:58 +0000)]
Update Blog.tpl

Removed unnecessary conditional/open

12 months agoMerge pull request #28412 from wmortada/standalone-roles
Rich Lott [Sat, 2 Dec 2023 13:08:57 +0000 (13:08 +0000)]
Merge pull request #28412 from wmortada/standalone-roles

Standalone - Add button to add user role

Merging as it works and is a good improvement! Thanks @wmortada

12 months agoUpdate Common.js
Nicol [Sat, 2 Dec 2023 13:05:02 +0000 (13:05 +0000)]
Update Common.js

Stop the accordion js from targetting <details><summary>

12 months agoStandalone - Add button to add user role
William Mortada [Sat, 2 Dec 2023 12:44:42 +0000 (12:44 +0000)]
Standalone - Add button to add user role

12 months ago"Fix" test fail E2E_Extern_WidgetTest::testWidget by skipping it
Rich Lott / Artful Robot [Sat, 2 Dec 2023 12:47:10 +0000 (12:47 +0000)]
"Fix" test fail E2E_Extern_WidgetTest::testWidget by skipping it

Drupal8+ does not support the extern widgets, so we do the same for standalone.

As agreed with @totten

12 months agoLegacyRestTest - No need to test `extern/rest.php` on `Standalone`
Tim Otten [Sat, 2 Dec 2023 12:45:18 +0000 (12:45 +0000)]
LegacyRestTest - No need to test `extern/rest.php` on `Standalone`

12 months agoUpdate civicrm.css
Nicol [Sat, 2 Dec 2023 12:38:22 +0000 (12:38 +0000)]
Update civicrm.css

Updates CSS to remove expand/collapse icons from accordions using <details><summary> to avoid duplicated expand icon issue.

12 months agoLocalizedDataTest - Fix for standalone
Tim Otten [Sat, 2 Dec 2023 12:35:59 +0000 (12:35 +0000)]
LocalizedDataTest - Fix for standalone

12 months agoUpdate Blog.tpl
Nicol [Sat, 2 Dec 2023 12:34:39 +0000 (12:34 +0000)]
Update Blog.tpl

Uses <details><summary> to make accordions accessible.

12 months agoUpdate Blog.tpl
Nicol [Sat, 2 Dec 2023 12:32:05 +0000 (12:32 +0000)]
Update Blog.tpl

12 months agoMerge pull request #27292 from artfulrobot/artfulrobot-standalone-lcMessages
Mathieu Lu [Sat, 2 Dec 2023 12:20:50 +0000 (07:20 -0500)]
Merge pull request #27292 from artfulrobot/artfulrobot-standalone-lcMessages

dev/core#4425 Standalone: fix lcMessages not sticking; slightly lazy sessions

12 months agodev/core#2998 - Fix JWT cookie test in standalone
Patrick Figel [Sat, 2 Dec 2023 11:54:28 +0000 (11:54 +0000)]
dev/core#2998 - Fix JWT cookie test in standalone

This fixes a test failure in JwtCredsTest with standalone due to session
cookies being sent.

12 months agoMerge pull request #28402 from eileenmcnaughton/part_id
Eileen McNaughton [Sat, 2 Dec 2023 03:08:41 +0000 (16:08 +1300)]
Merge pull request #28402 from eileenmcnaughton/part_id

Add getParticipantID() to register

12 months agoAdd getParticipantID() to register
Eileen McNaughton [Sat, 2 Dec 2023 03:06:26 +0000 (16:06 +1300)]
Add getParticipantID() to register

12 months agoMerge pull request #28394 from eileenmcnaughton/member_template
demeritcowboy [Fri, 1 Dec 2023 23:57:47 +0000 (18:57 -0500)]
Merge pull request #28394 from eileenmcnaughton/member_template

Fix online membership receipt to be form-independent

12 months agoFix online membership receipt to be form-independent
Eileen McNaughton [Fri, 1 Dec 2023 06:11:49 +0000 (19:11 +1300)]
Fix online membership receipt to be form-independent

12 months agoMerge pull request #28400 from eileenmcnaughton/exist
Eileen McNaughton [Fri, 1 Dec 2023 23:15:01 +0000 (12:15 +1300)]
Merge pull request #28400 from eileenmcnaughton/exist

Fix type error (new in master)

12 months agoFix type error (new in master
Eileen McNaughton [Fri, 1 Dec 2023 22:20:53 +0000 (11:20 +1300)]
Fix type error (new in master

12 months agoMerge pull request #28392 from eileenmcnaughton/freeze
demeritcowboy [Fri, 1 Dec 2023 21:39:50 +0000 (16:39 -0500)]
Merge pull request #28392 from eileenmcnaughton/freeze

Fix for intermittent test fail on checksum time

12 months agoAdd suffix to sort name
Eileen McNaughton [Fri, 1 Dec 2023 03:37:12 +0000 (16:37 +1300)]
Add suffix to sort name

Revives https://github.com/civicrm/civicrm-core/pull/27114

12 months agoMerge pull request #28397 from braders/filegetcontents-properties
Eileen McNaughton [Fri, 1 Dec 2023 20:11:52 +0000 (09:11 +1300)]
Merge pull request #28397 from braders/filegetcontents-properties

[NFC] Pass correct param types to file_get_contents

12 months ago[NFC] Pass correct param types to file_get_contents
Bradley Taylor [Fri, 1 Dec 2023 18:56:15 +0000 (18:56 +0000)]
[NFC] Pass correct param types to file_get_contents

12 months agoMerge pull request #27777 from eileenmcnaughton/section_totals
demeritcowboy [Fri, 1 Dec 2023 14:30:12 +0000 (09:30 -0500)]
Merge pull request #27777 from eileenmcnaughton/section_totals

Smarty3 Mark sectionTotals smarty function deprecated

12 months agoMerge pull request #24699 from colemanw/afformConditional
colemanw [Fri, 1 Dec 2023 09:26:45 +0000 (09:26 +0000)]
Merge pull request #24699 from colemanw/afformConditional

Afform: Support conditional logic

12 months agoMerge pull request #28389 from eileenmcnaughton/membership_type_form
colemanw [Fri, 1 Dec 2023 09:14:15 +0000 (09:14 +0000)]
Merge pull request #28389 from eileenmcnaughton/membership_type_form

Use getSubmittedValues() rather than ad-hoc money 'cleaning' on membershipType form

12 months agoMerge pull request #28391 from eileenmcnaughton/sort_fix
Seamus Lee [Fri, 1 Dec 2023 06:23:22 +0000 (17:23 +1100)]
Merge pull request #28391 from eileenmcnaughton/sort_fix

[REF] Use Token Processor to generate sort name and display name for individuals

12 months ago[REF] Use Token Processor to generate sort name and display name for individuals
Seamus Lee [Thu, 2 Feb 2023 00:42:21 +0000 (11:42 +1100)]
[REF] Use Token Processor to generate sort name and display name for individuals

Fix handling for when certain things should only show if there tokens filled out

Handle for when the nameFormat is null (import tests)

12 months agoMerge pull request #27934 from MegaphoneJon/uncached-ext-dir-issue
Eileen McNaughton [Fri, 1 Dec 2023 03:30:43 +0000 (16:30 +1300)]
Merge pull request #27934 from MegaphoneJon/uncached-ext-dir-issue

set extension browser timeout to minimum of 10 seconds.

12 months agoMerge pull request #28390 from sebalis/contributors_civiservice
Eileen McNaughton [Fri, 1 Dec 2023 02:43:01 +0000 (15:43 +1300)]
Merge pull request #28390 from sebalis/contributors_civiservice

contributor_key.yml: add civiservice.de to four users, remove one duplicate

12 months agoFix for intermittent test fail on checksum time
Eileen McNaughton [Fri, 1 Dec 2023 02:39:15 +0000 (15:39 +1300)]
Fix for intermittent test fail on checksum time

12 months agoadd civiservice.de to four users, remove one duplicate
sebalis [Fri, 1 Dec 2023 01:16:06 +0000 (02:16 +0100)]
add civiservice.de to four users, remove one duplicate

12 months agoset extension browser timeout to minimum of 10 seconds.
Jon Goldberg [Wed, 25 Oct 2023 18:09:14 +0000 (14:09 -0400)]
set extension browser timeout to minimum of 10 seconds.

12 months agoUse getSubmittedValues() rather than ad-hoc money 'cleaning'
Eileen McNaughton [Fri, 1 Dec 2023 00:31:08 +0000 (13:31 +1300)]
Use getSubmittedValues() rather than ad-hoc money 'cleaning'

12 months agoMerge pull request #28384 from eileenmcnaughton/activity_type
Eileen McNaughton [Fri, 1 Dec 2023 00:19:11 +0000 (13:19 +1300)]
Merge pull request #28384 from eileenmcnaughton/activity_type

Remove some calls to deprecated function

12 months agoMerge pull request #28385 from eileenmcnaughton/member_required
Seamus Lee [Thu, 30 Nov 2023 22:38:07 +0000 (09:38 +1100)]
Merge pull request #28385 from eileenmcnaughton/member_required

Superficial cleanup

12 months agoRemove some calls to deprecated function
Eileen McNaughton [Thu, 30 Nov 2023 20:34:01 +0000 (09:34 +1300)]
Remove some calls to deprecated function

https://github.com/civicrm/civicrm-core/pull/23880 is
thoroughly stale so I'm closing it - but just thought I'd rescue a couple of changes

These are in the barely maintained legacycustomsearches so of marginal risk &
marginal benefit but since I looked maybe no-one else has to ever again...

12 months agoMerge pull request #28356 from eileenmcnaughton/membership_renew_notice
colemanw [Thu, 30 Nov 2023 21:41:17 +0000 (16:41 -0500)]
Merge pull request #28356 from eileenmcnaughton/membership_renew_notice

Fix notice, caching, master-only-regression- showing inactive fields on membership config

12 months agoMerge pull request #28364 from eileenmcnaughton/confirm_notice
colemanw [Thu, 30 Nov 2023 21:40:59 +0000 (16:40 -0500)]
Merge pull request #28364 from eileenmcnaughton/confirm_notice

Fix a whole lot of conditional assignments on confirm & thank you pages

12 months agoMerge pull request #28370 from eileenmcnaughton/payment_fields
colemanw [Thu, 30 Nov 2023 21:40:04 +0000 (16:40 -0500)]
Merge pull request #28370 from eileenmcnaughton/payment_fields

Fix notices on credit_card & bank number on Confirm & ThankYou

12 months agoSuperficial cleanup
Eileen McNaughton [Thu, 30 Nov 2023 21:18:25 +0000 (10:18 +1300)]
Superficial cleanup

Removes some unused variables & other minor cleanups

12 months agoMerge pull request #28383 from MegaphoneJon/activity-filter-case-speedup
Eileen McNaughton [Thu, 30 Nov 2023 20:08:06 +0000 (09:08 +1300)]
Merge pull request #28383 from MegaphoneJon/activity-filter-case-speedup

Activity case filter speedup

12 months agoMerge pull request #28382 from demeritcowboy/strstart
Eileen McNaughton [Thu, 30 Nov 2023 20:06:20 +0000 (09:06 +1300)]
Merge pull request #28382 from demeritcowboy/strstart

fix error on confirm page when using on-behalf-of