Eileen McNaughton [Tue, 16 May 2023 00:42:58 +0000 (12:42 +1200)]
Only call transitionComponents when transitioning pending/pay later to completed
Rather than early return when called in error, don't call it
Matthew Wire [Mon, 15 May 2023 12:37:53 +0000 (13:37 +0100)]
Merge pull request #26221 from eileenmcnaughton/part_public
Make some internal functions protected
Matthew Wire [Mon, 15 May 2023 12:35:40 +0000 (13:35 +0100)]
Merge pull request #26220 from eileenmcnaughton/crazy_test_4
Fix Participant tests to use full form flow
Yashodha Chaku [Mon, 15 May 2023 06:39:36 +0000 (12:09 +0530)]
Merge pull request #26222 from eileenmcnaughton/extract
Remove unreachable validation
Eileen McNaughton [Mon, 15 May 2023 03:53:09 +0000 (15:53 +1200)]
Add getParticipantID to avoid non-php8-friendly path check
This particular fail is due to the path being empy in the test environment - But
it's wrong to check it as it is a crufty check for whether
the search task is being used
Eileen McNaughton [Mon, 15 May 2023 04:09:45 +0000 (16:09 +1200)]
Remove unreachable validation
Some time ago we fixed it such that only Pending and Completed statuses are in
the drop box for contribution_status_id. This fragment of code handles an edge case
that is no longer reachable - ie when the value is Failed and some other confusing stuff
is true
Eileen McNaughton [Mon, 15 May 2023 00:47:19 +0000 (12:47 +1200)]
Fix Participant tests to use full form flow
This doesn't get all of them but fixes a bunch
Eileen McNaughton [Sun, 14 May 2023 23:28:31 +0000 (11:28 +1200)]
Improve fromEmail address handling
We don't need to validate the from Email address in the postProcess as the
form submit validation expects it to be a supplied value.
Fixing this makes testing easier
Eileen McNaughton [Mon, 15 May 2023 00:42:38 +0000 (12:42 +1200)]
Improve test consistency on capitalisation
Eileen McNaughton [Mon, 15 May 2023 01:28:37 +0000 (13:28 +1200)]
Merge pull request #26217 from eileenmcnaughton/crazy_test
Minor cleanup on function
Eileen McNaughton [Mon, 15 May 2023 01:14:56 +0000 (13:14 +1200)]
Make some internal functions protected
I did a universe search to be sure but these 'belong' to the form
Eileen McNaughton [Sun, 14 May 2023 23:07:16 +0000 (11:07 +1200)]
Minor cleanup on function
The primary goal here was to check that it ALWAYS returns an array. It does,
so I added a type hint.
I also confirmed that
- it is not called from universe
- it is not called with no primaryParticipantID
- it is not called with excludeCancel set for false
so I did some deprecating.
Lastly there was code to handle there being no cancelStatus -
assigning a variable cancelID of 0 as a fallback. But, it
was not being used - so I fixed it to cast-to-int.
demeritcowboy [Sat, 13 May 2023 18:41:46 +0000 (14:41 -0400)]
Merge pull request #26213 from dontub/AbstractAction-drop-throws-phpdoc
AbstractAction: Drop `@throws` from phpdoc of `__construct()` because it's not thrown
Dominic Tubach [Sat, 13 May 2023 17:18:38 +0000 (19:18 +0200)]
AbstractAction: Drop `@throws` from phpdoc of `__construct()` because it's not thrown
Eileen McNaughton [Sat, 13 May 2023 03:14:17 +0000 (15:14 +1200)]
Merge pull request #26210 from civicrm/5.62
5.62
Matthew Wire [Fri, 12 May 2023 21:49:33 +0000 (22:49 +0100)]
Merge pull request #26205 from eileenmcnaughton/event_backoffice
Further separate register task from participant form
Matthew Wire [Fri, 12 May 2023 21:49:01 +0000 (22:49 +0100)]
Merge pull request #26209 from larssandergreen/Don't-show-send-confirmation-description-if-registering-multiple
Don't show send broken confirmation description if registering multiple contacts
larssandergreen [Fri, 12 May 2023 21:08:40 +0000 (15:08 -0600)]
Don't show send confirmation description if registering multiple
Matthew Wire [Fri, 12 May 2023 18:01:54 +0000 (19:01 +0100)]
Merge pull request #26206 from eileenmcnaughton/event_mail
Extract sendEmail function
Yashodha Chaku [Fri, 12 May 2023 12:22:35 +0000 (17:52 +0530)]
Merge pull request #26172 from eileenmcnaughton/562_import
dev/core#4227 Fix import to not blank birth_date etc on update
Yashodha Chaku [Fri, 12 May 2023 12:20:00 +0000 (17:50 +0530)]
Merge pull request #26204 from eileenmcnaughton/deprecated
Add missing deprecated tag
Tim Otten [Fri, 12 May 2023 07:54:26 +0000 (00:54 -0700)]
Merge pull request #26036 from colemanw/componentExtensions
dev/core#3961 Create stub extensions for all components
Eileen McNaughton [Fri, 12 May 2023 05:02:32 +0000 (17:02 +1200)]
Extract sendEmail function
This is a straight forward extraction
There is test cover
Eileen McNaughton [Fri, 12 May 2023 04:40:22 +0000 (16:40 +1200)]
Further separate register task from participant form
Coleman Watts [Thu, 27 Apr 2023 21:01:57 +0000 (17:01 -0400)]
Component Extensions - Fix upgrade and test errors
Coleman Watts [Thu, 27 Apr 2023 00:26:49 +0000 (20:26 -0400)]
Component/Extensions - Remove unnecessary cache clearing and prevent recursion
Ensure the cached settings are updated _before_ post_change hooks are called for settings.
All the cache clears being performed by on_change hooks were redundant with what happens when
extensions are enabled/disabled so I removed it.
Also moved the extension install hook to use postInstall which should be more stable, and
added checks in onToggleComponents to prevent recursion.
Coleman Watts [Tue, 11 Apr 2023 01:31:59 +0000 (21:31 -0400)]
Add test for component-extension lifecycle
Coleman Watts [Mon, 10 Apr 2023 16:01:32 +0000 (12:01 -0400)]
Sync enable/disable status of component extensions with core components
Eileen McNaughton [Thu, 11 May 2023 23:44:08 +0000 (11:44 +1200)]
Remove missing deprecated tag
Eileen McNaughton [Thu, 11 May 2023 23:36:02 +0000 (11:36 +1200)]
Merge pull request #26203 from eileenmcnaughton/reg_vars
Remove unused constants
Eileen McNaughton [Thu, 11 May 2023 22:55:29 +0000 (10:55 +1200)]
Remove unused constant
Seamus Lee [Thu, 11 May 2023 21:33:53 +0000 (07:33 +1000)]
Merge pull request #26202 from pradpnayak/extcleanup
flexmailer remove cruft code
demeritcowboy [Thu, 11 May 2023 20:30:25 +0000 (16:30 -0400)]
Merge pull request #26201 from civicrm/5.62
5.62
Pradeep Nayak [Thu, 11 May 2023 18:11:34 +0000 (19:11 +0100)]
flexmailer remove cruft code
demeritcowboy [Thu, 11 May 2023 18:11:29 +0000 (14:11 -0400)]
Merge pull request #26199 from pradpnayak/fatalerror
Regression: Fatal error when importing membership
Pradeep Nayak [Thu, 11 May 2023 17:22:58 +0000 (18:22 +0100)]
Fixed fatal error when importing membership
Coleman Watts [Sun, 9 Apr 2023 03:09:12 +0000 (23:09 -0400)]
Add stub extensions for all components
Eileen McNaughton [Thu, 11 May 2023 06:34:34 +0000 (18:34 +1200)]
Merge pull request #26195 from totten/master-esm
dev/core#4279 - Add support for ECMAScript Modules (ESM, part 1)
Eileen McNaughton [Thu, 11 May 2023 03:56:52 +0000 (15:56 +1200)]
Fix capitalization in comments
Eileen McNaughton [Thu, 11 May 2023 02:45:15 +0000 (14:45 +1200)]
add more esms
Tim Otten [Thu, 11 May 2023 02:05:10 +0000 (19:05 -0700)]
(NFC) Emphasize abbreviation "ESM"
colemanw [Thu, 11 May 2023 01:44:04 +0000 (21:44 -0400)]
Merge pull request #26192 from MegaphoneJon/entity-ref-joins
proper EntityRef joins
Seamus Lee [Thu, 11 May 2023 00:16:59 +0000 (10:16 +1000)]
Merge pull request #26194 from larssandergreen/Ttile-case-all-of-Support-menu
Title case Register Your Site in support menu
larssandergreen [Wed, 10 May 2023 23:39:27 +0000 (17:39 -0600)]
Title case Register Your Site in support menu
Tim Otten [Fri, 5 May 2023 07:42:37 +0000 (00:42 -0700)]
Resources - Define helper methods `addModule()`, `addModuleFile()`, `addModuleUrl()`
Tim Otten [Fri, 5 May 2023 05:36:08 +0000 (22:36 -0700)]
CRM_Core_Region::add() - Allow JS resources to be flaged as ES5 modules (`esm=>TRUE`)
Jon Goldberg [Wed, 10 May 2023 18:55:30 +0000 (14:55 -0400)]
proper EntityRef joins
demeritcowboy [Wed, 10 May 2023 20:00:05 +0000 (16:00 -0400)]
Merge pull request #26191 from larssandergreen/Uncheck-is_email_receipt-when-hidden-on-New-Contribution
Uncheck is_email_receipt when hidden on New Contribution
larssandergreen [Wed, 10 May 2023 15:50:06 +0000 (09:50 -0600)]
Uncheck is_email_receipt when hidden
Eileen McNaughton [Wed, 10 May 2023 04:21:41 +0000 (16:21 +1200)]
Merge pull request #26184 from reflexive-communications/crmMailingAB-error
crmMailingAB/services: catch exception, report error and rethrow
Eileen McNaughton [Tue, 9 May 2023 22:36:42 +0000 (10:36 +1200)]
Merge pull request #26178 from stesi561/drupalconfig
Fix config is null on hooks
Eileen McNaughton [Tue, 9 May 2023 22:20:49 +0000 (10:20 +1200)]
Merge pull request #26189 from larssandergreen/Prevent-self-service-cancellation-when-prohibited-by-using-back-office-url
Prevent prohibited self service cancellation by using is_backoffice=1 in URL
Eileen McNaughton [Tue, 9 May 2023 22:12:43 +0000 (10:12 +1200)]
Merge pull request #26188 from larssandergreen/Fix-authorization-failed-on-self-service-participant-transfer
Fix authorization failed on self-service participant transfer
Eileen McNaughton [Tue, 9 May 2023 21:55:19 +0000 (09:55 +1200)]
Merge pull request #26187 from larssandergreen/Preserve-participant-status-when-transfering
Preserve participant status when transferring
larssandergreen [Tue, 9 May 2023 21:33:34 +0000 (15:33 -0600)]
Prevent unauthorized self-service participant update via URL
larssandergreen [Tue, 9 May 2023 20:57:29 +0000 (14:57 -0600)]
Fix authorization failed on self-service participant transfer
larssandergreen [Tue, 9 May 2023 20:40:52 +0000 (14:40 -0600)]
Preserve participant status on transfer
demeritcowboy [Tue, 9 May 2023 15:30:41 +0000 (11:30 -0400)]
Merge pull request #26181 from mattwire/confirmeventmsg
Show/hide billing name/address on event confirm based on if they're set instead of a magical collection of booleans
Sandor Semsey [Tue, 9 May 2023 15:26:47 +0000 (17:26 +0200)]
crmMailingAB/services: catch exception, report error and rethrow
Matthew Wire [Tue, 9 May 2023 13:06:25 +0000 (14:06 +0100)]
Merge pull request #26123 from colemanw/afformValidate
Afform - Ensure checkboxes and radios are validated client-side
Matthew Wire [Tue, 9 May 2023 12:49:47 +0000 (13:49 +0100)]
Show/hide billing name/address on event confirm based on if they're set instead of a magical collection of booleans
Yashodha Chaku [Tue, 9 May 2023 08:09:57 +0000 (13:39 +0530)]
Merge pull request #26167 from larssandergreen/imrpove-footer-and-support-menu
dev/core#3920 Improve footer and support menu
Luke Stewart [Tue, 9 May 2023 01:22:15 +0000 (13:22 +1200)]
Fix config is null on hooks
Eileen McNaughton [Tue, 9 May 2023 00:25:18 +0000 (12:25 +1200)]
Merge pull request #25563 from seamuslee001/dev_core_4123
dev/core#4123 Support contribution recur tokens when accessing from a…
Seamus Lee [Mon, 8 May 2023 23:49:30 +0000 (09:49 +1000)]
Merge pull request #26078 from mattwire/contribclean
REF: Small cleanup on contribution receipt code
Eileen McNaughton [Mon, 8 May 2023 23:37:54 +0000 (11:37 +1200)]
Merge pull request #26177 from asmac-org/master
Added composerjk to contributor-key.yml
Jeff Kellem [Mon, 8 May 2023 23:32:16 +0000 (16:32 -0700)]
Added composerjk to contributor-key.yml
Seamus Lee [Sun, 12 Feb 2023 23:20:33 +0000 (10:20 +1100)]
dev/core#4123 Support contribution recur tokens when accessing from a contribution or membership
Use getRelatedTokens function name instead and also fix tests
Hide some unnecessary tokens and fix tests
Seamus Lee [Mon, 8 May 2023 22:23:48 +0000 (08:23 +1000)]
Merge pull request #26173 from seamuslee001/regen_5_23
Regenerate civicrm generated after #25987 and membership xml
Seamus Lee [Mon, 8 May 2023 21:40:00 +0000 (07:40 +1000)]
Update Unit tests to handle for change in label
Eileen McNaughton [Mon, 8 May 2023 21:22:26 +0000 (09:22 +1200)]
Merge pull request #26143 from totten/master-runtime-no-magic
(REF) CRM_Core_Config - Simplify dependencies between MagicMerge and Runtime
Tim Otten [Mon, 8 May 2023 20:29:31 +0000 (13:29 -0700)]
Merge pull request #26170 from eileenmcnaughton/562_member
Fix regression whereby membership does not submit
demeritcowboy [Mon, 8 May 2023 15:42:49 +0000 (11:42 -0400)]
Merge pull request #26171 from eileenmcnaughton/honor
Notice fix on isHonor on contribution page
demeritcowboy [Mon, 8 May 2023 15:32:55 +0000 (11:32 -0400)]
Merge pull request #26168 from eileenmcnaughton/report_escape
Stop escaping tableHeader in secure smarty mode
demeritcowboy [Mon, 8 May 2023 15:32:22 +0000 (11:32 -0400)]
Merge pull request #26169 from eileenmcnaughton/562
E-notice fix on pay-later payment processor
Matthew Wire [Wed, 19 Apr 2023 13:20:05 +0000 (14:20 +0100)]
Small cleanup on contribution receipt code
Eileen McNaughton [Mon, 8 May 2023 08:03:50 +0000 (20:03 +1200)]
CiviDiscount fix - pass correct component
Seamus Lee [Mon, 8 May 2023 06:45:11 +0000 (16:45 +1000)]
Regnerate civicrm generated and membership xml
Eileen McNaughton [Mon, 8 May 2023 05:37:57 +0000 (17:37 +1200)]
dev/core#4227 Fix import to not blank birth_date etc on update
Eileen McNaughton [Mon, 8 May 2023 05:15:18 +0000 (17:15 +1200)]
Merge pull request #25987 from agileware/CIVICRM-2119
😵 Disambiguate "Source" field by showing the context of the source, ie. Membership, Participant, Contribution, Contact etc.
Eileen McNaughton [Mon, 8 May 2023 04:46:31 +0000 (16:46 +1200)]
Always assign footer_text
Eileen McNaughton [Mon, 8 May 2023 04:40:16 +0000 (16:40 +1200)]
Notice fix on isHonor
Eileen McNaughton [Mon, 8 May 2023 04:27:08 +0000 (16:27 +1200)]
Re-instate the renewal message
Eileen McNaughton [Mon, 8 May 2023 03:45:13 +0000 (15:45 +1200)]
Fix regression whereby membership does not submit
Seamus Lee [Mon, 8 May 2023 03:10:06 +0000 (13:10 +1000)]
Merge pull request #26044 from totten/jwt_generation_alt
Authx - Add APIv4 support for creating and validating credentials
Eileen McNaughton [Mon, 8 May 2023 02:03:34 +0000 (14:03 +1200)]
E-notice fix on pay-later payment processor
Eileen McNaughton [Mon, 8 May 2023 01:53:15 +0000 (13:53 +1200)]
Stop escaping tableHeader in secure smarty mode
demeritcowboy [Sun, 7 May 2023 22:49:11 +0000 (18:49 -0400)]
Merge pull request #26165 from larssandergreen/php-warning-for-add-to-group
Fix PHP8 warnings for AddToGroup
larssandergreen [Sun, 7 May 2023 20:43:04 +0000 (14:43 -0600)]
improve footer and support menu
larssandergreen [Sun, 7 May 2023 03:19:51 +0000 (21:19 -0600)]
fix php8 warnings for AddToGroup
demeritcowboy [Sat, 6 May 2023 23:09:10 +0000 (19:09 -0400)]
Merge pull request #26116 from larssandergreen/refund-form-improvements
Add default payment method for additional payment or refund
Tim Otten [Sat, 6 May 2023 01:28:27 +0000 (18:28 -0700)]
Merge pull request #26129 from colemanw/api4JoinFix
APIv4 - Simplify bridge joins
demeritcowboy [Fri, 5 May 2023 22:23:10 +0000 (18:23 -0400)]
Merge pull request #26162 from civicrm/5.62
5.62
demeritcowboy [Fri, 5 May 2023 21:10:51 +0000 (17:10 -0400)]
Merge pull request #26159 from demeritcowboy/drupal-cache
Upgrade message for drupal9 sites to advise to clear drupal cache
demeritcowboy [Fri, 5 May 2023 20:15:48 +0000 (16:15 -0400)]
upgrade message
Tim Otten [Fri, 5 May 2023 19:55:41 +0000 (12:55 -0700)]
Merge pull request #26157 from eileenmcnaughton/test_fix
mixin/scan-classes - Don't scan extension-tests automatically
Eileen McNaughton [Thu, 4 May 2023 02:00:36 +0000 (14:00 +1200)]
scan-classes - Only scan live code. Skip test folder (which can interfere with phpunit runner).
demeritcowboy [Fri, 5 May 2023 15:50:48 +0000 (11:50 -0400)]
Merge pull request #26103 from larssandergreen/don't-show-admin-only-price-fields-on-event-preview
dev/core#4103 Don't show admin only price fields on Registration or Contribution page previews
Eileen McNaughton [Thu, 4 May 2023 22:09:28 +0000 (10:09 +1200)]
Merge pull request #26158 from MegaphoneJon/fill-fix-2
fixes #4278 - Import fill on email/phone respects location type
Seamus Lee [Thu, 4 May 2023 22:00:09 +0000 (08:00 +1000)]
Merge pull request #26133 from eileenmcnaughton/report_stat
Use purify rather than escape to preserve currency