colemanw [Wed, 1 Mar 2023 00:22:38 +0000 (19:22 -0500)]
Merge pull request #25695 from eileenmcnaughton/CRM/Block
Pull over a few more deprecations + blockDelete deprecation
Eileen McNaughton [Tue, 28 Feb 2023 23:48:27 +0000 (12:48 +1300)]
Pull over a few more deprecations + blockDelete deprecation
Eileen McNaughton [Tue, 28 Feb 2023 23:45:38 +0000 (12:45 +1300)]
Merge pull request #25693 from eileenmcnaughton/CRM/Block
Address portions of deprecated code replacement
Eileen McNaughton [Tue, 28 Feb 2023 22:31:22 +0000 (11:31 +1300)]
Address portions of deprecated code replacement
colemanw [Tue, 28 Feb 2023 22:07:48 +0000 (17:07 -0500)]
Merge pull request #25691 from eileenmcnaughton/dep_mailing
Deprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 21:49:55 +0000 (10:49 +1300)]
Merge pull request #25690 from eileenmcnaughton/dep_test
Deprecations for delete on ACL entities
Eileen McNaughton [Tue, 28 Feb 2023 21:01:23 +0000 (10:01 +1300)]
Deprecations for Mailing::delete functions
Eileen McNaughton [Tue, 28 Feb 2023 20:51:03 +0000 (09:51 +1300)]
Deprecations for delete on ACL entities
Seamus Lee [Tue, 28 Feb 2023 20:10:29 +0000 (07:10 +1100)]
Merge pull request #25688 from eileenmcnaughton/dep_test
Remove deprecated functions from tests
Eileen McNaughton [Tue, 28 Feb 2023 18:48:22 +0000 (07:48 +1300)]
Remove deprecated functions from tests
Eileen McNaughton [Tue, 28 Feb 2023 06:02:16 +0000 (19:02 +1300)]
Merge pull request #25686 from eileenmcnaughton/dep_2020_address
Remove 2020-deprecated handling of `legacyAddressCreate`
Yashodha Chaku [Tue, 28 Feb 2023 03:16:00 +0000 (08:46 +0530)]
Merge pull request #25685 from eileenmcnaughton/dep_2020
Remove function noisily deprecated when the world was young (2020)
Yashodha Chaku [Tue, 28 Feb 2023 03:14:00 +0000 (08:44 +0530)]
Merge pull request #25684 from eileenmcnaughton/address_delete
Remove deprecated function call
Eileen McNaughton [Tue, 28 Feb 2023 02:28:15 +0000 (15:28 +1300)]
Merge pull request #25646 from colemanw/fixSearchDisplayFilter
Afform - Filter autocomplete fields belonging to a search display
Eileen McNaughton [Tue, 28 Feb 2023 02:24:31 +0000 (15:24 +1300)]
Remove 2020-deprecated handline of legacyAddressCreate
Eileen McNaughton [Tue, 28 Feb 2023 02:01:49 +0000 (15:01 +1300)]
Remove function noisily deprecated when the world was young (2020)
demeritcowboy [Tue, 28 Feb 2023 01:53:40 +0000 (20:53 -0500)]
Merge pull request #25669 from eileenmcnaughton/smarty-syntax
dev/core#4146 Remove (old) Smarty-forward incompatible syntax from Address.tpl
demeritcowboy [Tue, 28 Feb 2023 01:34:09 +0000 (20:34 -0500)]
Merge pull request #25683 from eileenmcnaughton/logging_dep
Add gentle deprecation to `debug_log_message`
demeritcowboy [Tue, 28 Feb 2023 01:25:34 +0000 (20:25 -0500)]
Merge pull request #25682 from eileenmcnaughton/log_smarty
Log Smarty debug to it's own channel
demeritcowboy [Tue, 28 Feb 2023 01:05:03 +0000 (20:05 -0500)]
Merge pull request #25680 from eileenmcnaughton/smarty-bank
Smarty notice fix on bank_account_number
Eileen McNaughton [Tue, 28 Feb 2023 00:54:38 +0000 (13:54 +1300)]
Remove deprecated function call
Eileen McNaughton [Tue, 28 Feb 2023 00:50:13 +0000 (13:50 +1300)]
Merge pull request #25678 from eileenmcnaughton/logging-ref
Remove unnecessary pass-by-reference
Eileen McNaughton [Tue, 28 Feb 2023 00:47:52 +0000 (13:47 +1300)]
Add gentle deprecation to debug_log_message
colemanw [Tue, 28 Feb 2023 00:47:11 +0000 (19:47 -0500)]
Merge pull request #25679 from eileenmcnaughton/deprecated_mem_type
Remove code deprecated in 2018
Eileen McNaughton [Tue, 28 Feb 2023 00:36:47 +0000 (13:36 +1300)]
Log Smarty debug to it's own channel
I just wrote the docs on the right way to log using this example
https://docs.civicrm.org/dev/en/latest/framework/logging/
- so we should make it the same. I tested locally
& this results in the smarty debugging going to a separate file (good).
I personally think we should send all the IPN files off to their
own channel but am loath to be pro-active on changing that
Eileen McNaughton [Mon, 27 Feb 2023 23:48:33 +0000 (12:48 +1300)]
Smarty notice fix on bank_account_number
Eileen McNaughton [Mon, 27 Feb 2023 23:23:23 +0000 (12:23 +1300)]
Also remove CRM_Utils_Array call
Eileen McNaughton [Mon, 27 Feb 2023 23:19:50 +0000 (12:19 +1300)]
Remove code deprecated in 2018
Eileen McNaughton [Mon, 27 Feb 2023 23:04:19 +0000 (12:04 +1300)]
Make function private
Eileen McNaughton [Mon, 27 Feb 2023 23:01:52 +0000 (12:01 +1300)]
Remove unnecessary pass-by-reference
demeritcowboy [Mon, 27 Feb 2023 21:44:16 +0000 (16:44 -0500)]
Merge pull request #25675 from eileenmcnaughton/notice_location
Remove empty on location - it should always be set now
Eileen McNaughton [Mon, 27 Feb 2023 19:56:51 +0000 (08:56 +1300)]
Remove empty on location - it should always be set now
See https://github.com/civicrm/civicrm-core/pull/25668
colemanw [Mon, 27 Feb 2023 15:34:25 +0000 (10:34 -0500)]
Merge pull request #25618 from mattwire/caserelationship
Afform: Allow selecting case for relationship
demeritcowboy [Mon, 27 Feb 2023 13:47:30 +0000 (08:47 -0500)]
Merge pull request #25668 from eileenmcnaughton/notice_location
Fix e-notice pattern around location not defined in formButtons.tpl
demeritcowboy [Mon, 27 Feb 2023 13:44:36 +0000 (08:44 -0500)]
Merge pull request #25309 from MegaphoneJon/flexmailer-return-path
closes core#4070 - respect default return path
demeritcowboy [Mon, 27 Feb 2023 13:40:03 +0000 (08:40 -0500)]
Merge pull request #25585 from herbdool/core-4127-4
dev/core#4127 move cms user parameters to userSystem
Seamus Lee [Mon, 27 Feb 2023 03:58:11 +0000 (14:58 +1100)]
Merge pull request #25671 from colemanw/viewSql
SearchKit - Clarify how to view SQL output
Coleman Watts [Mon, 27 Feb 2023 02:16:27 +0000 (21:16 -0500)]
SearchKit - Clarify how to view SQL output
Seamus Lee [Sun, 26 Feb 2023 21:24:29 +0000 (08:24 +1100)]
Merge pull request #25670 from eileenmcnaughton/cust_it
Remove unused variables
Eileen McNaughton [Tue, 7 Feb 2023 01:58:54 +0000 (14:58 +1300)]
Remove unused variables
colemanw [Sun, 26 Feb 2023 02:42:48 +0000 (21:42 -0500)]
Merge pull request #25466 from eileenmcnaughton/sep
Remove unused property - not used since import code refactor `_lineCount`
colemanw [Sun, 26 Feb 2023 02:41:42 +0000 (21:41 -0500)]
Merge pull request #25237 from eileenmcnaughton/mem_receipt
Remove conditional assignment around `is_deductible`
colemanw [Sun, 26 Feb 2023 02:40:17 +0000 (21:40 -0500)]
Merge pull request #25621 from eileenmcnaughton/event_test_cleanup
Event test cleanup, fix test to use submitted form values, rather than require a lot of contorting
colemanw [Sun, 26 Feb 2023 02:39:39 +0000 (21:39 -0500)]
Merge pull request #25270 from eileenmcnaughton/separate
Extend testing for ContributionConfirm & consolidate `isSeparateMembershipPayment`
Tim Otten [Sat, 25 Feb 2023 04:46:58 +0000 (20:46 -0800)]
Merge pull request #25667 from eileenmcnaughton/mixin
Fix mixin to use `addTemplateDir`
Eileen McNaughton [Fri, 24 Feb 2023 22:54:41 +0000 (11:54 +1300)]
Remove (old) Smarty-forward incompatible syntax from Address.tpl
Eileen McNaughton [Fri, 24 Feb 2023 21:19:08 +0000 (10:19 +1300)]
Fix e-notice pattern around location not defined in formButtons.tpl
Eileen McNaughton [Fri, 24 Feb 2023 07:36:50 +0000 (20:36 +1300)]
Fix mixin
demeritcowboy [Fri, 24 Feb 2023 19:02:25 +0000 (14:02 -0500)]
Merge pull request #25662 from eileenmcnaughton/token_dep
Add noisy deprecation to deprecated function, after universe search
Herb v/d Dool [Wed, 15 Feb 2023 16:07:14 +0000 (11:07 -0500)]
dev/core#4127 move cms user parameters to userSystem
Seamus Lee [Fri, 24 Feb 2023 09:37:18 +0000 (20:37 +1100)]
Merge pull request #25665 from totten/master-nfc-url
(NFC) crmURL - Add examples and whitespace. Crosslink docs.
Tim Otten [Fri, 24 Feb 2023 08:14:12 +0000 (00:14 -0800)]
Merge pull request #25664 from eileenmcnaughton/tpl_fix
Remove forward incompatible syntax from template
Tim Otten [Fri, 24 Feb 2023 07:43:10 +0000 (23:43 -0800)]
crmURL - Add examples and whitespace. Crosslink docs.
Tim Otten [Fri, 24 Feb 2023 06:59:23 +0000 (22:59 -0800)]
Merge pull request #25661 from eileenmcnaughton/smarty-url
Add `crmUrl function` to smarty in the standard way
Eileen McNaughton [Fri, 24 Feb 2023 06:13:54 +0000 (19:13 +1300)]
Merge pull request #25663 from eileenmcnaughton/civix
run `civix update` on `recaptcha`, `legacyCustomSearches`, `financialacls`
Eileen McNaughton [Fri, 24 Feb 2023 05:45:11 +0000 (18:45 +1300)]
Remove forward incompatible syntax from template
Eileen McNaughton [Fri, 24 Feb 2023 04:40:44 +0000 (17:40 +1300)]
Civix upgrade on financialAcls
Eileen McNaughton [Fri, 24 Feb 2023 04:34:55 +0000 (17:34 +1300)]
Civix update on legacyCustomSearches
Eileen McNaughton [Fri, 24 Feb 2023 04:33:14 +0000 (17:33 +1300)]
Civix update on Recaptcha
Eileen McNaughton [Fri, 24 Feb 2023 04:30:10 +0000 (17:30 +1300)]
Merge pull request #25659 from totten/master-ext-up
ext/* - General update to civix v23.02.0
Eileen McNaughton [Tue, 17 Jan 2023 03:58:13 +0000 (16:58 +1300)]
Add crmUrl function in the standard way
Even during Smarty2 this method of registering functions was being phased out
for putting the file in the folder
Eileen McNaughton [Fri, 24 Feb 2023 02:39:59 +0000 (15:39 +1300)]
Add noisy deprecation to deprecated function, after universe search
Eileen McNaughton [Fri, 24 Feb 2023 02:32:57 +0000 (15:32 +1300)]
Merge pull request #25653 from totten/master-htxt
Smarty - {htxt} blocks should not be evaluated unless needed
Eileen McNaughton [Fri, 24 Feb 2023 02:32:34 +0000 (15:32 +1300)]
Merge pull request #25655 from MegaphoneJon/sub-history-date
HTML definition for subscription history date
Eileen McNaughton [Fri, 24 Feb 2023 02:30:11 +0000 (15:30 +1300)]
Merge pull request #25660 from civicrm/5.59
5.59
Seamus Lee [Fri, 24 Feb 2023 01:45:10 +0000 (12:45 +1100)]
Merge pull request #25658 from demeritcowboy/contact-params
Use correct var for joomla synchronizeUFMatch
Tim Otten [Thu, 23 Feb 2023 22:03:13 +0000 (14:03 -0800)]
Smarty - {htxt} blocks should not be evaluated unless needed
Tim Otten [Fri, 24 Feb 2023 00:54:29 +0000 (16:54 -0800)]
ext/civigrant - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:48:41 +0000 (16:48 -0800)]
ext/search_kit - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:47:58 +0000 (16:47 -0800)]
ext/sequentialcreditnotes - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:47:05 +0000 (16:47 -0800)]
ext/oauth_client - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:46:25 +0000 (16:46 -0800)]
ext/message_admin - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:45:22 +0000 (16:45 -0800)]
ext/ckeditor4 - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:44:58 +0000 (16:44 -0800)]
ext/civiimport - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:44:22 +0000 (16:44 -0800)]
ext/civicrm_admin_ui - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:43:30 +0000 (16:43 -0800)]
ext/flexmailer - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:42:37 +0000 (16:42 -0800)]
ext/greenwich - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:41:58 +0000 (16:41 -0800)]
ext/afform/admin - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:41:25 +0000 (16:41 -0800)]
ext/afform/core - Update to civix v23.02.0
Tim Otten [Fri, 24 Feb 2023 00:40:50 +0000 (16:40 -0800)]
ext/authx - Update to civix v23.02.0
demeritcowboy [Fri, 24 Feb 2023 00:26:13 +0000 (19:26 -0500)]
use correct var
Seamus Lee [Fri, 24 Feb 2023 00:08:27 +0000 (11:08 +1100)]
Merge pull request #25656 from eileenmcnaughton/notice_lang
Notice fix on preferred_language, when null
Eileen McNaughton [Thu, 23 Feb 2023 23:23:30 +0000 (12:23 +1300)]
Merge pull request #25654 from eileenmcnaughton/hacky
Remove legacy handling of locks for discontinued mysql/mariaDB versions
Eileen McNaughton [Thu, 23 Feb 2023 23:23:08 +0000 (12:23 +1300)]
Merge pull request #25650 from reflexive-communications/event-registration-activity-target
Event registration activity target
Eileen McNaughton [Thu, 23 Feb 2023 23:06:38 +0000 (12:06 +1300)]
Notice fix on preferred_language, when null
Eileen McNaughton [Thu, 23 Feb 2023 22:57:09 +0000 (11:57 +1300)]
Merge pull request #25652 from eileenmcnaughton/body
Php8.x compatibility - do not try to count NULL
Jon Goldberg [Thu, 23 Feb 2023 22:31:50 +0000 (17:31 -0500)]
HTML definition for subscription history date
Eileen McNaughton [Thu, 23 Feb 2023 22:29:53 +0000 (11:29 +1300)]
Remove legacy handling of locks for discontinued mysql/mariaDB versions
Eileen McNaughton [Thu, 23 Feb 2023 22:07:54 +0000 (11:07 +1300)]
Merge pull request #25651 from totten/mbtruncate
Smarty - Fix warnings about 'mb_truncate' modifier
Eileen McNaughton [Thu, 23 Feb 2023 21:50:14 +0000 (10:50 +1300)]
Php8.x compatibility - do not try to count NULL
Eileen McNaughton [Thu, 23 Feb 2023 21:16:10 +0000 (10:16 +1300)]
Merge pull request #25649 from demeritcowboy/case-search
dev/core#4126 - Fix force-url parameters on case dashboard
Tim Otten [Thu, 23 Feb 2023 21:11:52 +0000 (13:11 -0800)]
mb_truncate - Save 0.00000001s
If it's null, then we don't really have to call `$strlen()` or evaluate the `>` operation.
Tim Otten [Thu, 23 Feb 2023 20:43:30 +0000 (12:43 -0800)]
Smarty - Fix warnings about 'mb_truncate' modifier
Steps to reproduce
------------------
* Use PHP 8.1 and D7 with a default logging policy (eg "All Messages" or "Errors and Warnings")
* Use "Search > Find Contacts"
* On the listing page, observe a bunch of warnings
Before
------
~25 warnings, including ~10 related to modifier.mb_truncate.php
After
-----
~10 warnings, none involving `mb_truncate`
Sandor Semsey [Thu, 23 Feb 2023 14:12:22 +0000 (15:12 +0100)]
CRM_Activity_BAO_Activity::addActivity() remove duplicate target_contact_id
Sandor Semsey [Thu, 23 Feb 2023 12:48:08 +0000 (13:48 +0100)]
pass participant contact_id as target_contact_id when creating event registration activity
demeritcowboy [Thu, 23 Feb 2023 15:06:15 +0000 (10:06 -0500)]
fix force-url parameters
Eileen McNaughton [Thu, 23 Feb 2023 04:17:27 +0000 (17:17 +1300)]
Merge pull request #23782 from totten/master-finperm
Allow (some) permissions with colons
Seamus Lee [Thu, 23 Feb 2023 03:34:01 +0000 (14:34 +1100)]
Merge pull request #25248 from eileenmcnaughton/add_template
Update Smarty addTemplateDir function signature to future smarty
Eileen McNaughton [Thu, 23 Feb 2023 01:46:34 +0000 (14:46 +1300)]
Merge pull request #25629 from yashodha/dev-4106
(dev/core#4106) Add filter on pledge payment in contribution report t…
Eileen McNaughton [Thu, 23 Feb 2023 01:31:34 +0000 (14:31 +1300)]
Merge pull request #25648 from eileenmcnaughton/cheaper_failure
Reduce processing load in test `assertAPIFailure`