demeritcowboy [Mon, 15 Jun 2020 14:32:39 +0000 (10:32 -0400)]
replace function that doesn't cache properly with the one it ends up calling which does cache properly
Seamus Lee [Mon, 15 Jun 2020 00:34:50 +0000 (10:34 +1000)]
Merge pull request #17614 from demeritcowboy/xmlproc-acttypes-more
dev/core#1433 - Replace call to CRM_Case_XMLProcessor::allActivityTypes() that doesn't cache properly
demeritcowboy [Sun, 14 Jun 2020 21:45:10 +0000 (17:45 -0400)]
replace call to function that doesn't cache properly
Eileen McNaughton [Sun, 14 Jun 2020 20:34:32 +0000 (08:34 +1200)]
Merge pull request #17613 from civicrm/5.27
5.27 to master
Matthew Wire [Sun, 14 Jun 2020 20:32:57 +0000 (21:32 +0100)]
Merge pull request #17607 from eileenmcnaughton/pi
Fix payment instrument bug by using correct payment instrument
Seamus Lee [Sun, 14 Jun 2020 05:06:16 +0000 (15:06 +1000)]
Merge pull request #17600 from seamuslee001/null_array_access
[REF] Fix issue with using array access tools on NULL values
Seamus Lee [Sat, 13 Jun 2020 07:20:59 +0000 (17:20 +1000)]
[REF] Fix issue with using array access tools on NULL values
Seamus Lee [Sun, 14 Jun 2020 03:58:53 +0000 (13:58 +1000)]
Merge pull request #17604 from seamuslee001/incorrect_array_key_exist_group
[REF] Replace incorrect usage of array_key_exists with property_exist…
Seamus Lee [Sun, 14 Jun 2020 03:58:38 +0000 (13:58 +1000)]
Merge pull request #17605 from eileenmcnaughton/membertest
[NFC] Add assertions to existing test to lock in current behaviour
Seamus Lee [Sun, 14 Jun 2020 03:53:38 +0000 (13:53 +1000)]
Merge pull request #17606 from seamuslee001/php74_mock
[NFC] Update mocking to use getMockBuilder instead instead of createMock
eileen [Sun, 14 Jun 2020 02:36:46 +0000 (14:36 +1200)]
Fix payment instrument bug by using correct payment instrument
Per https://github.com/civicrm/civicrm-core/pull/17589 it is necessary that we do NOT pass the wrong payment_instrument_id
to the payment processor. BUT we have to provide accurate defaults for manual payments. This is a narrower fix than
- back office membership form
- back office participant form
- back office contribution form
and in all cases the Manual processor still loaded correctly. I don't feel I can say this is the last fix in this
area but it stands alone as a sensible fix to do and also one that should address the immediate issue.
Note there is some weirdness in a second function in EventFees - that function should GO IMHO - but I have not yet reached it in
UI testing to confirm if other changes need to be made.
Seamus Lee [Sun, 14 Jun 2020 02:22:23 +0000 (12:22 +1000)]
[NFC] Update mocking to use getMockBuilder instead instead of createMock
eileen [Sun, 14 Jun 2020 01:57:07 +0000 (13:57 +1200)]
[NFC] Add assertions to existing test to lock in current behaviour
Per standard tdd refactoring I'm adding tests before I alter the code that is tested. Note that the code
has quite a bit I think can go
Seamus Lee [Sun, 14 Jun 2020 01:43:25 +0000 (11:43 +1000)]
[REF] Replace incorrect usage of array_key_exists with property_exists in Group BAO Class
Seamus Lee [Sun, 14 Jun 2020 01:11:01 +0000 (11:11 +1000)]
Merge pull request #17596 from eileenmcnaughton/deprecation
dev/financial#131 Give deprecation notice if the payment processor returns an error
Seamus Lee [Sun, 14 Jun 2020 01:10:23 +0000 (11:10 +1000)]
Merge pull request #17597 from eileenmcnaughton/dopayment
dev/financial#131 Remove last places where Core Processors return error object
Seamus Lee [Sun, 14 Jun 2020 00:54:11 +0000 (10:54 +1000)]
Merge pull request #17564 from eileenmcnaughton/renewd
[REF] Add test for renewing old expired membership via form
Eileen McNaughton [Sun, 14 Jun 2020 00:53:50 +0000 (12:53 +1200)]
Merge pull request #17598 from seamuslee001/php74_packages
[REF] Update packages to work with PHP7.4
Eileen McNaughton [Sun, 14 Jun 2020 00:42:31 +0000 (12:42 +1200)]
Merge pull request #17601 from seamuslee001/array_key_exists_fix
[REF] Fix another couple of uses of array_key_exists when the variabl…
Eileen McNaughton [Sun, 14 Jun 2020 00:42:02 +0000 (12:42 +1200)]
Merge pull request #17599 from seamuslee001/array_key_offsets
[REF] Fix some additional issues where curly braces were being used t…
Seamus Lee [Sat, 13 Jun 2020 22:48:54 +0000 (08:48 +1000)]
Merge pull request #17603 from mattwire/cleanuprecurtpl
NFC Formatting cleanup on contribution/recur templates
Seamus Lee [Sat, 13 Jun 2020 07:20:40 +0000 (17:20 +1000)]
[REF] Update packages to work with PHP7.4
Update to use latest master zetacomponents/mail as php74 fix has been incoporated
Update to tagged release of zetacomponents
Seamus Lee [Sat, 13 Jun 2020 22:33:32 +0000 (08:33 +1000)]
Merge pull request #16918 from mattwire/smartyerrorevent
Add smarty error event
Matthew Wire [Sat, 13 Jun 2020 12:05:35 +0000 (13:05 +0100)]
Formatting cleanup on contribution/recur templates
Seamus Lee [Sat, 13 Jun 2020 07:22:21 +0000 (17:22 +1000)]
[REF] Fix another couple of uses of array_key_exists when the variable being checked is an object
Seamus Lee [Sat, 13 Jun 2020 07:20:47 +0000 (17:20 +1000)]
[REF] Fix some additional issues where curly braces were being used to access string or array offsets
Seamus Lee [Sat, 13 Jun 2020 04:43:28 +0000 (14:43 +1000)]
Merge pull request #17551 from eileenmcnaughton/guzzle
dev/core#1803 Update guzzlehttp, psr7, psrlog, cxn-pc
eileen [Sat, 13 Jun 2020 02:28:47 +0000 (14:28 +1200)]
dev/financial#131 Remove last places where Core Processors return error object
eileen [Sat, 13 Jun 2020 01:18:11 +0000 (13:18 +1200)]
dev/financial#131 Give deprecation notice if the payment processor returns an error
This notice will show up on dev sites & should highlight the expectation that processors throw errors
Seamus Lee [Sat, 13 Jun 2020 00:06:54 +0000 (10:06 +1000)]
Merge pull request #17522 from seamuslee001/remove_deprecated_methods
[REF] Remove deprecated methods of booting drupal container and getti…
Seamus Lee [Sat, 13 Jun 2020 00:02:38 +0000 (10:02 +1000)]
Merge pull request #17593 from seamuslee001/fix_requirements_version
Fix retrieving MySQL version for checking as part of install requirem…
Seamus Lee [Fri, 12 Jun 2020 23:58:29 +0000 (09:58 +1000)]
Merge pull request #17592 from eileenmcnaughton/junc
dev/financial#131 Remove legacy error handling from Paypal code.
Seamus Lee [Fri, 12 Jun 2020 22:26:22 +0000 (08:26 +1000)]
Fix retrieving MySQL version for checking as part of install requirements
eileen [Fri, 12 Jun 2020 22:21:57 +0000 (10:21 +1200)]
dev/financial#131 Remove legacy error handling from Paypal code.
https://lab.civicrm.org/dev/financial/-/issues/131
Seamus Lee [Fri, 12 Jun 2020 22:24:48 +0000 (08:24 +1000)]
Merge pull request #17579 from colemanw/menubarSep
Update has_separator field in civicrm_navigation
Seamus Lee [Fri, 12 Jun 2020 22:20:30 +0000 (08:20 +1000)]
Merge pull request #17585 from eileenmcnaughton/anetup
[Ref] Convert Authorize.net to use Guzzle for update subscription class, add test
Mathieu Lu [Fri, 12 Jun 2020 13:07:51 +0000 (09:07 -0400)]
Merge pull request #17487 from eileenmcnaughton/date
[Ref] Mark unused date functions as deprecated
Seamus Lee [Fri, 12 Jun 2020 11:06:15 +0000 (21:06 +1000)]
Merge pull request #17144 from lcdservices/dev-core-1716
dev/core#1716 add customPre hook
Seamus Lee [Fri, 12 Jun 2020 11:04:04 +0000 (21:04 +1000)]
Merge pull request #17563 from eileenmcnaughton/pending
Remove unreachable lines
Matthew Wire [Fri, 12 Jun 2020 09:32:51 +0000 (10:32 +0100)]
Merge pull request #17581 from mlutfy/EventInfoCleanup
EventInfo template cleanup
Matthew Wire [Fri, 12 Jun 2020 09:31:38 +0000 (10:31 +0100)]
Merge pull request #17321 from artfulrobot/artfulrobot-identify-request-key
Allow HEAD requests to generate a form key
Seamus Lee [Fri, 12 Jun 2020 09:29:14 +0000 (19:29 +1000)]
Merge pull request #17587 from civicrm/5.27
5.27
Seamus Lee [Fri, 12 Jun 2020 05:08:53 +0000 (15:08 +1000)]
Merge pull request #17586 from seamuslee001/wip_56_test_fixes
[REF] Fix unit test failures on MySQL 5.6 due to Custom Field table being created without Dynamic Row Format
Seamus Lee [Fri, 12 Jun 2020 03:17:48 +0000 (13:17 +1000)]
Fix unit test failures on MySQL 5.6 due to Custom Field table being created without Dynamic Row Format
eileen [Thu, 11 Jun 2020 23:50:33 +0000 (11:50 +1200)]
[Ref] Convert Authorize.net to use Guzzle for update subscription, change subscription, add test
This is part of the effort to expand our testing & standardise core processors
Seamus Lee [Fri, 12 Jun 2020 01:14:29 +0000 (11:14 +1000)]
Merge pull request #17583 from civicrm/5.27
5.27
Eileen McNaughton [Fri, 12 Jun 2020 00:28:53 +0000 (12:28 +1200)]
Merge pull request #17584 from eileenmcnaughton/process
Fix fatal error regression in master
eileen [Thu, 11 Jun 2020 23:17:06 +0000 (11:17 +1200)]
Fix fatal error regression in master
Fatal from this line due to pass by reference
https://github.com/civicrm/civicrm-core/pull/16514/files#diff-a8611c9a226a40b585001082b38467b0R207
Seamus Lee [Thu, 11 Jun 2020 22:45:20 +0000 (08:45 +1000)]
Merge pull request #17582 from colemanw/upgrade
Fix duplicate upgrade function
Seamus Lee [Thu, 11 Jun 2020 22:45:03 +0000 (08:45 +1000)]
Merge pull request #17577 from seamuslee001/deprecated_checks_money_value_format
Add in deprecation notice and status check for a money value format co…
Seamus Lee [Thu, 11 Jun 2020 22:06:43 +0000 (08:06 +1000)]
Merge pull request #17567 from eileenmcnaughton/dupe_speed
Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact table
Seamus Lee [Thu, 11 Jun 2020 02:59:31 +0000 (12:59 +1000)]
Add in depreation notice and status check for a money value format configuration other than the default
Update to include issue link
Update to use CRM_Core_Error::deprecated function and mention deprecation notice on settings page
Seamus Lee [Thu, 11 Jun 2020 21:38:10 +0000 (07:38 +1000)]
Merge pull request #17565 from eileenmcnaughton/processor
dev/financial#131 Fix Elavon processor to throw exceptions
Coleman Watts [Thu, 11 Jun 2020 21:38:04 +0000 (17:38 -0400)]
Fix duplicate upgrade function
Eileen McNaughton [Thu, 11 Jun 2020 21:26:25 +0000 (09:26 +1200)]
Merge pull request #17531 from colemanw/customIcon
Add icons to multi-valued custom groups and display on contact tab
Eileen McNaughton [Thu, 11 Jun 2020 21:25:29 +0000 (09:25 +1200)]
Merge pull request #17576 from colemanw/emptyLeaf
APIv4 - Skip empty leaves in WHERE clause
Mathieu Lutfy [Thu, 11 Jun 2020 20:00:06 +0000 (16:00 -0400)]
EventInfo template cleanup.
colemanw [Thu, 11 Jun 2020 17:34:50 +0000 (13:34 -0400)]
Merge pull request #17578 from yashodha/dev_1787
(dev/core#1787) Regression : File fields export results in DB error
Coleman Watts [Thu, 11 Jun 2020 15:55:05 +0000 (11:55 -0400)]
Update has_separator field in civicrm_navigation
This field was incorrectly marked as a boolean;
it's actually an int with an option list.
yashodha [Thu, 11 Jun 2020 14:09:19 +0000 (19:39 +0530)]
(dev/core#1787) Regression : File fields export results in DB error
Seamus Lee [Thu, 11 Jun 2020 06:46:27 +0000 (16:46 +1000)]
Merge pull request #17573 from seamuslee001/incorrect_use_array_key_exists
[REF] Replace incorrect usages of array_key_exists when the variable …
Seamus Lee [Wed, 10 Jun 2020 22:39:44 +0000 (08:39 +1000)]
[REF] Replace incorrect usages of array_key_exists when the variable is not an array with property_exists and also fix the parameter order for an implode statement
Seamus Lee [Thu, 11 Jun 2020 03:05:52 +0000 (13:05 +1000)]
Merge pull request #15796 from seamuslee001/dev_core_183_requirements
dev/core#183 Use CRM_Utils_SQL_TempTable for generating temp table na…
Coleman Watts [Thu, 11 Jun 2020 00:41:51 +0000 (20:41 -0400)]
APIv4 - Skip empty leaves in WHERE clause
Fixes an annoying problem with search builder
where the api gives a sql error while building your where clause.
The solution is to skip empty leaves, treating them as WIP.
Seamus Lee [Thu, 11 Jun 2020 00:29:28 +0000 (10:29 +1000)]
Merge pull request #17574 from seamuslee001/string_offsets_curly
[REF] Using {} to access string or array offsets has been deprecated …
Seamus Lee [Thu, 11 Jun 2020 00:26:52 +0000 (10:26 +1000)]
Merge pull request #17440 from eileenmcnaughton/log_summ
dev/core#1749 Fix missing parameter in link to logging detail
Eileen McNaughton [Thu, 11 Jun 2020 00:18:34 +0000 (12:18 +1200)]
Merge pull request #15422 from artfulrobot/queue-parallel
Include a new SqlParallel queue type that enables multiple queue runners to process in parallel
Seamus Lee [Wed, 10 Jun 2020 23:55:52 +0000 (09:55 +1000)]
Merge pull request #17575 from seamuslee001/php74_deprecations
[REF] Using ternary operation without nesting is deprecated and also …
Seamus Lee [Wed, 10 Jun 2020 22:46:07 +0000 (08:46 +1000)]
Merge pull request #17570 from seamuslee001/conact_type_populated
[REF] Add in upgrade step to populate missing contact_type.name field
Seamus Lee [Wed, 10 Jun 2020 22:45:53 +0000 (08:45 +1000)]
[REF] Using ternary operation without nesting is deprecated and also using methods and properly instanciate the CiviCase Info object in test
Seamus Lee [Wed, 10 Jun 2020 22:40:26 +0000 (08:40 +1000)]
[REF] Using {} to access string or array offsets has been deprecated in PHP7.4
Seamus Lee [Wed, 10 Jun 2020 11:07:08 +0000 (21:07 +1000)]
[REF] Add in upgrade step to populate missing contact_type.name field
Make changes to the other columns
Seamus Lee [Wed, 10 Jun 2020 21:05:34 +0000 (07:05 +1000)]
Merge pull request #17571 from jitendrapurohit/core-1809
dev/core#1809 - Add start/end adjustment columns to membership status…
Jitendra Purohit [Wed, 10 Jun 2020 11:58:35 +0000 (17:28 +0530)]
dev/core#1809 - Add start/end adjustment columns to membership status page
Seamus Lee [Wed, 10 Jun 2020 05:43:13 +0000 (15:43 +1000)]
Merge pull request #17548 from eileenmcnaughton/contacttype
Set ContactType.name as required in the schema.
Eileen McNaughton [Wed, 10 Jun 2020 03:25:29 +0000 (15:25 +1200)]
Merge pull request #17566 from eileenmcnaughton/dupe1
[NFC] Minor code cleanup
eileen [Mon, 8 Jun 2020 04:50:49 +0000 (16:50 +1200)]
Set ContactType.name as required in the schema.
I came across this weird WHERE clause & I'm pretty sure it's compensating for a mistake in the schema
I also set what I think are sensible defaults on is_reserved & is_active
eileen [Wed, 10 Jun 2020 01:32:15 +0000 (13:32 +1200)]
dev/financial#131 Fix Elavon processor to throw exceptions
In line with our goal of modelling 'good behaviour' in core processors
eileen [Wed, 10 Jun 2020 02:30:36 +0000 (14:30 +1200)]
Dedupe performance - hard-remove financial_item from list of dymnamic refs to contact tablge
eileen [Wed, 10 Jun 2020 02:00:01 +0000 (14:00 +1200)]
[NFC] Minor code cleanup
eileen [Fri, 5 Jun 2020 11:35:40 +0000 (23:35 +1200)]
[REF] Add test for renewing old expired membership via form
This also removes few lines that the test shows are not needed
eileen [Tue, 9 Jun 2020 19:50:31 +0000 (07:50 +1200)]
Remove unreachable lines
Seamus Lee [Tue, 9 Jun 2020 12:03:12 +0000 (22:03 +1000)]
Merge pull request #17525 from mattwire/baseipnremovebillingid
Remove deprecated billingID from baseIPN
Seamus Lee [Tue, 9 Jun 2020 12:02:59 +0000 (22:02 +1000)]
Merge pull request #17556 from eileenmcnaughton/renewline
[Ref] Remove never reachable lines.
Matthew Wire [Sat, 6 Jun 2020 14:30:11 +0000 (15:30 +0100)]
Remove deprecated billingID from baseIPN
Seamus Lee [Tue, 9 Jun 2020 03:34:05 +0000 (13:34 +1000)]
Merge pull request #17559 from eileenmcnaughton/realex
dev/financial#131 Fix Realex processor to correctly throw an exception
Seamus Lee [Tue, 9 Jun 2020 01:30:41 +0000 (11:30 +1000)]
Merge pull request #17557 from ngo360/master
dev/core#1801 Fix hardcoded activity priority by label
eileen [Tue, 9 Jun 2020 01:16:55 +0000 (13:16 +1200)]
dev/financial#131 Fix Realex processor to correctly throw an exception
Seamus Lee [Tue, 9 Jun 2020 00:29:18 +0000 (10:29 +1000)]
Merge pull request #17515 from seamuslee001/replace_legacy_rebuild_module_data
[REF] Replace the deprecated system_rebuild_module_data function with…
Seamus Lee [Mon, 8 Jun 2020 23:22:21 +0000 (09:22 +1000)]
Merge pull request #17555 from seamuslee001/dev_core_560_deprecated_function_warning
dev/core#560 Add in deprecated function warning now that fatal is dep…
marcineqpol [Mon, 8 Jun 2020 22:26:13 +0000 (00:26 +0200)]
dev/core#1801 Fix hardcoded activity priority
Seamus Lee [Mon, 8 Jun 2020 22:18:36 +0000 (08:18 +1000)]
Merge pull request #17450 from mattwire/activitydefaults
dev/core#1782 Set activity_date_time and created_date to default to current_timestamp
eileen [Fri, 5 Jun 2020 05:40:09 +0000 (17:40 +1200)]
[Ref] Remove never reachable lines.
There is an early return on so updateStatusId can never be true
Seamus Lee [Mon, 8 Jun 2020 21:52:42 +0000 (07:52 +1000)]
Merge pull request #17501 from eileenmcnaughton/guzzle3
[Ref] Convert Authorize.net doDirectPayment to use guzzle & add test
Eileen McNaughton [Mon, 8 Jun 2020 21:48:27 +0000 (09:48 +1200)]
Merge pull request #17554 from alifrumin/entryFoundFlag
Fix "Undefined variable: entryFound" notice on Bookkeeping report
Eileen McNaughton [Mon, 8 Jun 2020 21:45:57 +0000 (09:45 +1200)]
Merge pull request #17506 from mattwire/propertybagremovewarning
Payment Propertybag remove warning
Seamus Lee [Mon, 8 Jun 2020 21:21:00 +0000 (07:21 +1000)]
dev/core#560 Add in deprecated function warning now that fatal is deprecated
Seamus Lee [Fri, 5 Jun 2020 23:11:13 +0000 (09:11 +1000)]
[REF] Replace the deprecated system_rebuild_module_data function with equivilant extension.list.module service function calls to be Drupal 9 compatiable
Eileen McNaughton [Mon, 8 Jun 2020 20:41:18 +0000 (08:41 +1200)]
Merge pull request #17552 from mattwire/deprecatedfunctionwarning
Support passing old method name into deprecatedFunctionWarning
Alice Frumin [Mon, 8 Jun 2020 20:04:32 +0000 (16:04 -0400)]
set flag