civicrm-core.git
2 years agoMerge pull request #27199 from colemanw/fixSkTotals
colemanw [Sun, 3 Sep 2023 18:52:19 +0000 (14:52 -0400)]
Merge pull request #27199 from colemanw/fixSkTotals

SearchKit - Fix broken totals row and query output

2 years agoSearchKit - Fix broken totals row and query output
colemanw [Tue, 29 Aug 2023 18:54:25 +0000 (14:54 -0400)]
SearchKit - Fix broken totals row and query output

This regressed in ef1cbd

2 years agoMerge pull request #27237 from seamuslee001/dev_core_4537
Seamus Lee [Fri, 1 Sep 2023 06:14:23 +0000 (02:14 -0400)]
Merge pull request #27237 from seamuslee001/dev_core_4537

dev/core#4537 Ensure that Event Registration email works when CiviCon…

2 years agodev/core#4537 Ensure that Event Registration email works when CiviContribute componen...
Seamus Lee [Thu, 31 Aug 2023 22:53:14 +0000 (08:53 +1000)]
dev/core#4537 Ensure that Event Registration email works when CiviContribute component is disabled and add unit test

Shift to using action object provider and rename function to remove Component

2 years agoMerge pull request #27243 from alifrumin/5.65rn
Eileen McNaughton [Fri, 1 Sep 2023 04:12:57 +0000 (16:12 +1200)]
Merge pull request #27243 from alifrumin/5.65rn

[NFC] 5.65 Release Notes

2 years ago[NFC] release notes 5.65
Alice Frumin [Mon, 28 Aug 2023 20:38:08 +0000 (16:38 -0400)]
[NFC] release notes 5.65

2 years agoMerge pull request #27221 from seamuslee001/dev_core_4538
Eileen McNaughton [Thu, 31 Aug 2023 05:17:33 +0000 (17:17 +1200)]
Merge pull request #27221 from seamuslee001/dev_core_4538

dev/core#4538 Move the setting of session status into the if check wi…

2 years agodev/core#4538 Move the setting of session status into the if check within the Partici...
Seamus Lee [Thu, 31 Aug 2023 03:43:44 +0000 (13:43 +1000)]
dev/core#4538 Move the setting of session status into the if check within the Participant payment to ensure status is not set if it is a free event

2 years agoMerge pull request #27170 from agh1/5.65.0-releasenotes-initial
Seamus Lee [Sun, 27 Aug 2023 23:21:47 +0000 (19:21 -0400)]
Merge pull request #27170 from agh1/5.65.0-releasenotes-initial

5.65.0 release notes initial run

2 years ago5.65.0 release notes: added boilerplate
Andie Hunt [Fri, 25 Aug 2023 15:51:17 +0000 (11:51 -0400)]
5.65.0 release notes: added boilerplate

2 years ago5.65.0 release notes: raw from script
Andie Hunt [Fri, 25 Aug 2023 15:40:12 +0000 (11:40 -0400)]
5.65.0 release notes: raw from script

2 years agoMerge pull request #27130 from colemanw/emailType
Eileen McNaughton [Fri, 25 Aug 2023 03:58:10 +0000 (15:58 +1200)]
Merge pull request #27130 from colemanw/emailType

dev/core#4530 - Change email fields to text in search mode

2 years agoSearchKit - Use correct action for getFields for in-place edit
colemanw [Wed, 23 Aug 2023 22:25:55 +0000 (18:25 -0400)]
SearchKit - Use correct action for getFields for in-place edit

Adds some caching to that function since it's called for every row

2 years agodev/core#4530 - Change email fields to text in search mode
colemanw [Wed, 23 Aug 2023 20:39:27 +0000 (16:39 -0400)]
dev/core#4530 - Change email fields to text in search mode

2 years agoMerge pull request #27129 from larssandergreen/Fix-adding-onclick-for-other_amount...
colemanw [Thu, 24 Aug 2023 21:07:58 +0000 (17:07 -0400)]
Merge pull request #27129 from larssandergreen/Fix-adding-onclick-for-other_amount-in-pricesets

Fix adding onclick for other_amount in pricesets

2 years agoMerge pull request #27136 from colemanw/revertSurvey
Seamus Lee [Thu, 24 Aug 2023 20:28:41 +0000 (16:28 -0400)]
Merge pull request #27136 from colemanw/revertSurvey

Revert "Add apiv4 Survey entity" (already exists in civi_campaign ext)

2 years agoMerge pull request #27134 from totten/5.65-aff-hook
Seamus Lee [Thu, 24 Aug 2023 20:28:02 +0000 (16:28 -0400)]
Merge pull request #27134 from totten/5.65-aff-hook

(dev/core#4531) Afform Mail Tokens - Fix rendering for localized/individual email

2 years agoMerge pull request #27132 from larssandergreen/Fix-checkbox-regressions-for-import...
demeritcowboy [Thu, 24 Aug 2023 19:50:50 +0000 (15:50 -0400)]
Merge pull request #27132 from larssandergreen/Fix-checkbox-regressions-for-import-and-new-message-template

Fix checkbox JS regression for import data selection and email new te…

2 years agoFix petition test
colemanw [Thu, 24 Aug 2023 16:09:33 +0000 (12:09 -0400)]
Fix petition test

2 years agoRevert "Add apiv4 Survey entity" (already exists in the civi_campaign extension)
colemanw [Thu, 24 Aug 2023 12:49:36 +0000 (08:49 -0400)]
Revert "Add apiv4 Survey entity" (already exists in the civi_campaign extension)

This reverts commit 92eea77386417a5d29538320d06d99e94bc2b2c2.

2 years ago(dev/core#4531) Afform Mail Tokens - Fix rendering for localized/individual email
Tim Otten [Thu, 24 Aug 2023 07:48:10 +0000 (00:48 -0700)]
(dev/core#4531) Afform Mail Tokens - Fix rendering for localized/individual email

While sending the localized email, some UF's may reboot the container
mid-execution. This change ensures that the listeners will be re-registered.

It also makes the code prettier.

2 years agoFix checkbox JS regression for import data selection and email new template
larssandergreen [Thu, 24 Aug 2023 03:59:02 +0000 (21:59 -0600)]
Fix checkbox JS regression for import data selection and email new template

2 years agoMerge pull request #27123 from colemanw/searchKitKey
Eileen McNaughton [Thu, 24 Aug 2023 02:48:31 +0000 (14:48 +1200)]
Merge pull request #27123 from colemanw/searchKitKey

dev/core#4519 SearchKit - Fix tasks when ID column is not present

2 years agoFix adding onclick for other_amount in pricesets
larssandergreen [Wed, 23 Aug 2023 18:23:36 +0000 (12:23 -0600)]
Fix adding onclick for other_amount in pricesets

2 years agoMerge pull request #27120 from larssandergreen/Fix-membership-price-set
Seamus Lee [Tue, 22 Aug 2023 23:21:34 +0000 (19:21 -0400)]
Merge pull request #27120 from larssandergreen/Fix-membership-price-set

dev/core#4523: Fix membership price sets selection regression on Contribution Pages

2 years agoSearchKit - Fix tasks when ID field is not selected
colemanw [Tue, 22 Aug 2023 20:15:55 +0000 (16:15 -0400)]
SearchKit - Fix tasks when ID field is not selected

2 years agoFix membership price sets regression
larssandergreen [Tue, 22 Aug 2023 18:12:38 +0000 (12:12 -0600)]
Fix membership price sets regression

2 years agoMerge pull request #27088 from seamuslee001/dev_core_4472
Eileen McNaughton [Fri, 18 Aug 2023 00:41:08 +0000 (12:41 +1200)]
Merge pull request #27088 from seamuslee001/dev_core_4472

dev/core#4472 Drop Index that is not actually needed only recently ad…

2 years agodev/core#4472 Drop Index that is not actually needed only recently added for priority...
Seamus Lee [Thu, 17 Aug 2023 21:52:21 +0000 (07:52 +1000)]
dev/core#4472 Drop Index that is not actually needed only recently added for priority column on civicrm_acl table

2 years agoMerge pull request #27083 from seamuslee001/followup_price_set_extends
Seamus Lee [Thu, 17 Aug 2023 22:28:58 +0000 (18:28 -0400)]
Merge pull request #27083 from seamuslee001/followup_price_set_extends

Follow up to ensure we are excluding quick config price sets as per t…

2 years agoFollow up to ensure we are excluding quick config price sets as per the previous...
Seamus Lee [Thu, 17 Aug 2023 21:25:10 +0000 (07:25 +1000)]
Follow up to ensure we are excluding quick config price sets as per the previous function

2 years agoMerge pull request #27080 from seamuslee001/amount_tab_extends_fix
Eileen McNaughton [Thu, 17 Aug 2023 21:19:28 +0000 (09:19 +1200)]
Merge pull request #27080 from seamuslee001/amount_tab_extends_fix

[REF] Fix poor checking of extends field as per PR #27079 but this ti…

2 years agoMerge pull request #27079 from briennekordis/price_set_extends_api
Seamus Lee [Thu, 17 Aug 2023 21:18:37 +0000 (17:18 -0400)]
Merge pull request #27079 from briennekordis/price_set_extends_api

Use APIv4 to check if a PriceSet extends CiviMember (lab.civicrm issue 4486)

2 years agoMerge pull request #27071 from seamuslee001/dev_core_4498
Seamus Lee [Thu, 17 Aug 2023 21:12:30 +0000 (17:12 -0400)]
Merge pull request #27071 from seamuslee001/dev_core_4498

dev/core#4498 Ensure that users without administer civicrm permission…

2 years ago[REF] Fix poor checking of extends field as per PR #27079 but this time on the Amount...
Seamus Lee [Wed, 16 Aug 2023 22:52:34 +0000 (08:52 +1000)]
[REF] Fix poor checking of extends field as per PR #27079 but this time on the Amounts tab of the contribution page config

2 years agomembership price fix with API from 5.65
brienne [Wed, 16 Aug 2023 21:23:38 +0000 (17:23 -0400)]
membership price fix with API from 5.65

2 years agoMerge pull request #27075 from totten/5.65-null-comp
Mathieu Lu [Wed, 16 Aug 2023 14:16:16 +0000 (10:16 -0400)]
Merge pull request #27075 from totten/5.65-null-comp

FiveSixtyTwo - Fix upgrade for domains with default value of `enable_components`

2 years agoFiveSixtyTwo - Fix upgrade for domains with default value of `enable_components`
Tim Otten [Wed, 16 Aug 2023 02:19:23 +0000 (19:19 -0700)]
FiveSixtyTwo - Fix upgrade for domains with default value of `enable_components`

2 years agoMerge pull request #27066 from eileenmcnaughton/565
demeritcowboy [Tue, 15 Aug 2023 11:59:56 +0000 (07:59 -0400)]
Merge pull request #27066 from eileenmcnaughton/565

dev/core#4494 Fix e-notice by removing unused variables

2 years agodev/core#4498 Ensure that users without administer civicrm permission can use the...
Seamus Lee [Mon, 14 Aug 2023 21:46:28 +0000 (07:46 +1000)]
dev/core#4498 Ensure that users without administer civicrm permission can use the Mailing Autocomplete

2 years agodev/core#4494 Fix e-notice by removing unused variables
Eileen McNaughton [Sun, 13 Aug 2023 22:53:28 +0000 (10:53 +1200)]
dev/core#4494 Fix e-notice by removing unused variables

2 years agoMerge pull request #27057 from larssandergreen/Fix-event-fee-help
colemanw [Sat, 12 Aug 2023 14:58:30 +0000 (10:58 -0400)]
Merge pull request #27057 from larssandergreen/Fix-event-fee-help

Fix event fee help

2 years agoFix event fee help
larssandergreen [Sat, 12 Aug 2023 04:47:54 +0000 (22:47 -0600)]
Fix event fee help

2 years agoMerge pull request #27043 from seamuslee001/dev_core_4492
colemanw [Fri, 11 Aug 2023 00:03:33 +0000 (20:03 -0400)]
Merge pull request #27043 from seamuslee001/dev_core_4492

dev/core#4492 Ensure that when determining if tokens should be show c…

2 years agodev/core#4492 Ensure that when determining if tokens should be show check if the...
Seamus Lee [Thu, 10 Aug 2023 22:58:24 +0000 (08:58 +1000)]
dev/core#4492 Ensure that when determining if tokens should be show check if the Entity is in list of Avaliable Entities

2 years agoMerge pull request #27033 from colemanw/fixSkEditable
colemanw [Thu, 10 Aug 2023 19:52:32 +0000 (15:52 -0400)]
Merge pull request #27033 from colemanw/fixSkEditable

Fix dev/core#4483 SearchKit crash when in-place-editing a field in a joined entity

2 years agoFix dev/core#4483
colemanw [Thu, 10 Aug 2023 00:51:32 +0000 (20:51 -0400)]
Fix dev/core#4483

2 years agoMerge pull request #26969 from demeritcowboy/view-only-merge-hook
Eileen McNaughton [Mon, 7 Aug 2023 20:05:23 +0000 (08:05 +1200)]
Merge pull request #26969 from demeritcowboy/view-only-merge-hook

dev/core#4481 - View-only custom fields should be merged during merges

2 years agoMerge pull request #27018 from larssandergreen/Fix-MailSettings-add-path
Aidan Saunders [Mon, 7 Aug 2023 11:15:04 +0000 (12:15 +0100)]
Merge pull request #27018 from larssandergreen/Fix-MailSettings-add-path

dev/core#4480 Fix MailSettings add path

2 years agoFix MailSettings add path
larssandergreen [Mon, 7 Aug 2023 05:49:20 +0000 (23:49 -0600)]
Fix MailSettings add path

2 years agoMerge pull request #27010 from demeritcowboy/fintype
Eileen McNaughton [Mon, 7 Aug 2023 00:15:09 +0000 (12:15 +1200)]
Merge pull request #27010 from demeritcowboy/fintype

dev/core#4473 - Add/edit financial type screen broken

2 years agofix broken add/edit form
demeritcowboy [Sat, 5 Aug 2023 13:05:58 +0000 (09:05 -0400)]
fix broken add/edit form

2 years agoMerge pull request #27007 from colemanw/fixLink
colemanw [Fri, 4 Aug 2023 13:14:15 +0000 (09:14 -0400)]
Merge pull request #27007 from colemanw/fixLink

Fix dev/core#4461 missing links causing SK to return no results

2 years agoview-only custom fields should be merged
demeritcowboy [Sat, 29 Jul 2023 15:15:49 +0000 (11:15 -0400)]
view-only custom fields should be merged

2 years agoRevert "hide view only custom fields on merge screen"
demeritcowboy [Sat, 29 Jul 2023 14:56:23 +0000 (10:56 -0400)]
Revert "hide view only custom fields on merge screen"

revert 3b9d4007540d19d58c1fed209e88a01fd5084026.

2 years agoadd real-world example test
demeritcowboy [Fri, 21 Jul 2023 03:34:09 +0000 (23:34 -0400)]
add real-world example test

2 years agoFix dev/core#4461 missing links causing SK to return no results
colemanw [Fri, 4 Aug 2023 12:39:00 +0000 (08:39 -0400)]
Fix dev/core#4461 missing links causing SK to return no results

2 years agoSet version to 5.65.beta1
CiviCRM [Thu, 3 Aug 2023 22:06:24 +0000 (22:06 +0000)]
Set version to 5.65.beta1

2 years agoMerge pull request #26303 from larssandergreen/Allow-multiple-registrations-from...
Eileen McNaughton [Thu, 3 Aug 2023 22:05:53 +0000 (10:05 +1200)]
Merge pull request #26303 from larssandergreen/Allow-multiple-registrations-from-search-actions

Allow multiple registrations from search actions

2 years agoMerge pull request #26957 from eileenmcnaughton/price_field
Seamus Lee [Thu, 3 Aug 2023 21:56:59 +0000 (17:56 -0400)]
Merge pull request #26957 from eileenmcnaughton/price_field

Notice fixes on CiviEvent Component settings form

2 years agoMerge pull request #26999 from totten/master-snapshot-b
Tim Otten [Thu, 3 Aug 2023 21:18:48 +0000 (14:18 -0700)]
Merge pull request #26999 from totten/master-snapshot-b

5.65.alpha1 - Define pre-upgrade snapshots (Option B)

2 years agoMerge pull request #26996 from colemanw/adminTitle
Eileen McNaughton [Thu, 3 Aug 2023 20:53:14 +0000 (08:53 +1200)]
Merge pull request #26996 from colemanw/adminTitle

[REF] CRM_Admin_Form - Use metadata instead of boilerplate to set page title

2 years ago5.65.alpha1.mysql.tpl - Add pre-upgrade snapshots for existing upgrade-steps
Tim Otten [Thu, 3 Aug 2023 08:34:29 +0000 (01:34 -0700)]
5.65.alpha1.mysql.tpl - Add pre-upgrade snapshots for existing upgrade-steps

2 years agoSmarty SQL - Add helper {crmUpgradeSnapshot}
Tim Otten [Thu, 3 Aug 2023 08:47:39 +0000 (01:47 -0700)]
Smarty SQL - Add helper {crmUpgradeSnapshot}

2 years agoCRM_Upgrade_Snapshot - Add helper `createSingleTask()`
Tim Otten [Thu, 3 Aug 2023 08:29:09 +0000 (01:29 -0700)]
CRM_Upgrade_Snapshot - Add helper `createSingleTask()`

This is an alternative to `createTasks()`. It's suitable for the kinds of small/mid-sized
queries that appear in `*.mysql.tpl` files.

2 years agoUpgrader - Supply $upgradeRev for Smarty TPLs
Tim Otten [Thu, 3 Aug 2023 07:38:39 +0000 (00:38 -0700)]
Upgrader - Supply $upgradeRev for Smarty TPLs

2 years agoCRM_Admin_Form - Use metadata instead of boilerplate to set page title
colemanw [Thu, 3 Aug 2023 03:35:32 +0000 (23:35 -0400)]
CRM_Admin_Form - Use metadata instead of boilerplate to set page title

2 years agoMerge pull request #26854 from colemanw/searchKitLinkPerformance
Eileen McNaughton [Wed, 2 Aug 2023 22:45:35 +0000 (10:45 +1200)]
Merge pull request #26854 from colemanw/searchKitLinkPerformance

SearchKit - Improve performance of checking link permissions

2 years agoMerge pull request #26992 from civicrm/5.64
Seamus Lee [Wed, 2 Aug 2023 22:18:51 +0000 (18:18 -0400)]
Merge pull request #26992 from civicrm/5.64

5.64

2 years agoMerge pull request #26840 from colemanw/autocompleteById
Eileen McNaughton [Wed, 2 Aug 2023 22:13:57 +0000 (10:13 +1200)]
Merge pull request #26840 from colemanw/autocompleteById

Api4 Autocomplete - Search by exact id match more effieciently

2 years agoMerge pull request #26990 from larssandergreen/Fix-price-field-url-regression
Seamus Lee [Wed, 2 Aug 2023 21:53:33 +0000 (17:53 -0400)]
Merge pull request #26990 from larssandergreen/Fix-price-field-url-regression

dev/core#4469 - Fix price set field path regression

2 years agoMerge pull request #26991 from agh1/5.64.0-releasenotes-final
Seamus Lee [Wed, 2 Aug 2023 21:51:45 +0000 (17:51 -0400)]
Merge pull request #26991 from agh1/5.64.0-releasenotes-final

5.64.0 release notes late changes

2 years agoMerge branch '5.64'
Seamus Lee [Wed, 2 Aug 2023 21:49:40 +0000 (07:49 +1000)]
Merge branch '5.64'

2 years agoUpdate 5.63.2.md
Tim Otten [Wed, 26 Jul 2023 07:21:53 +0000 (00:21 -0700)]
Update 5.63.2.md

2 years agoAdd release-notes/5.63.2.md
Tim Otten [Wed, 26 Jul 2023 06:45:42 +0000 (23:45 -0700)]
Add release-notes/5.63.2.md

2 years agoAdd release-notes/5.63.1.md
Tim Otten [Fri, 7 Jul 2023 18:45:16 +0000 (11:45 -0700)]
Add release-notes/5.63.1.md

2 years agoAdd release-notes/5.62.1.md
Tim Otten [Fri, 16 Jun 2023 05:10:13 +0000 (22:10 -0700)]
Add release-notes/5.62.1.md

2 years agoAdd release-notes/5.61.4.md
Tim Otten [Wed, 24 May 2023 06:38:56 +0000 (23:38 -0700)]
Add release-notes/5.61.4.md

2 years agoAdd release-notes/5.61.3.md
Tim Otten [Sat, 20 May 2023 00:44:11 +0000 (17:44 -0700)]
Add release-notes/5.61.3.md

2 years agoAdd release-notes/5.61.2.md
Tim Otten [Mon, 8 May 2023 23:10:10 +0000 (16:10 -0700)]
Add release-notes/5.61.2.md

2 years agoMerge pull request #26989 from demeritcowboy/regen
Seamus Lee [Wed, 2 Aug 2023 21:43:30 +0000 (17:43 -0400)]
Merge pull request #26989 from demeritcowboy/regen

civicrm_generated is out of date in 5.64

2 years agoAdd release-notes/5.61.1.md
Tim Otten [Fri, 5 May 2023 20:49:51 +0000 (13:49 -0700)]
Add release-notes/5.61.1.md

2 years agoAdd release-notes/5.59.4.md
Tim Otten [Mon, 27 Mar 2023 20:35:57 +0000 (13:35 -0700)]
Add release-notes/5.59.4.md

2 years agoAdd release-notes/5.59.3.md
Tim Otten [Thu, 16 Mar 2023 00:23:52 +0000 (17:23 -0700)]
Add release-notes/5.59.3.md

2 years agoAdd release-notes/5.59.2.md
Tim Otten [Sat, 11 Mar 2023 00:29:22 +0000 (16:29 -0800)]
Add release-notes/5.59.2.md

2 years agoAdd release-notes/5.59.1.md
Tim Otten [Sat, 4 Mar 2023 03:42:11 +0000 (19:42 -0800)]
Add release-notes/5.59.1.md

2 years agoUpdate 5.58.1.md
Tim Otten [Wed, 15 Feb 2023 23:58:14 +0000 (15:58 -0800)]
Update 5.58.1.md

2 years agoAdd release-notes/5.58.1.md
Tim Otten [Wed, 15 Feb 2023 21:54:30 +0000 (13:54 -0800)]
Add release-notes/5.58.1.md

2 years ago5.64.0 release notes: added late changes
Andie Hunt [Wed, 2 Aug 2023 21:40:02 +0000 (17:40 -0400)]
5.64.0 release notes: added late changes

2 years agoFix price set field path regression
larssandergreen [Wed, 2 Aug 2023 21:24:44 +0000 (15:24 -0600)]
Fix price set field path regression

2 years agoMerge pull request #26986 from mattwire/paymentvarsref
demeritcowboy [Wed, 2 Aug 2023 20:58:25 +0000 (16:58 -0400)]
Merge pull request #26986 from mattwire/paymentvarsref

REF: Rename variables to make it easier to understand what the code is doing

2 years agoregen
demeritcowboy [Wed, 2 Aug 2023 20:55:10 +0000 (16:55 -0400)]
regen

2 years agopopulate another frontend_title
demeritcowboy [Wed, 2 Aug 2023 20:49:32 +0000 (16:49 -0400)]
populate another frontend_title

2 years agoMerge pull request #26975 from eileenmcnaughton/re-used
demeritcowboy [Wed, 2 Aug 2023 20:29:28 +0000 (16:29 -0400)]
Merge pull request #26975 from eileenmcnaughton/re-used

E-notice fix (smarty)

2 years agoMerge pull request #26984 from colemanw/daoFixeyUppey
demeritcowboy [Wed, 2 Aug 2023 20:17:17 +0000 (16:17 -0400)]
Merge pull request #26984 from colemanw/daoFixeyUppey

DAO - Normalize null values in the writeRecord function to avoid subtle bugs

2 years agoRename variables to make it easier to understand what the code is doing
Matthew Wire [Wed, 2 Aug 2023 19:14:20 +0000 (20:14 +0100)]
Rename variables to make it easier to understand what the code is doing

2 years agoMerge pull request #26950 from eileenmcnaughton/deprecate
colemanw [Wed, 2 Aug 2023 17:01:13 +0000 (13:01 -0400)]
Merge pull request #26950 from eileenmcnaughton/deprecate

Deprecate probably never true condition

2 years agoE-notice fix (smarty)
Eileen McNaughton [Mon, 31 Jul 2023 23:10:12 +0000 (11:10 +1200)]
E-notice fix (smarty)

2 years agoFix test set up
Eileen McNaughton [Fri, 28 Jul 2023 02:22:01 +0000 (14:22 +1200)]
Fix test set up

2 years agoDeprecate probably never true condition
Eileen McNaughton [Thu, 27 Jul 2023 23:27:53 +0000 (11:27 +1200)]
Deprecate probably never true condition

If we can clarify that price set is ALWAYS set it will simplify stuff
- comments suggest that the exception has been weird test config