Tim Otten [Wed, 3 Mar 2021 03:19:08 +0000 (19:19 -0800)]
Merge pull request #19703 from colemanw/afformStandalone
Afform - Remove ngRoute from afformStandalone page
Eileen McNaughton [Tue, 2 Mar 2021 21:49:49 +0000 (10:49 +1300)]
Merge pull request #19684 from totten/master-authors
info.xml - Allow multiple `<author>`s
Eileen McNaughton [Tue, 2 Mar 2021 20:31:36 +0000 (09:31 +1300)]
Merge pull request #19712 from eileenmcnaughton/merge
5.35 to master
eileen [Tue, 2 Mar 2021 20:18:02 +0000 (09:18 +1300)]
Merge branch '5.35' of https://github.com/civicrm/civicrm-core into merge
Coleman Watts [Tue, 2 Mar 2021 13:52:43 +0000 (08:52 -0500)]
Afform - use search params instead of route params
Coleman Watts [Mon, 1 Mar 2021 18:54:30 +0000 (13:54 -0500)]
Afform - Remove ngRoute from afformStandalone page
Afforms are meant to work as standalone directives so routing on the standalone page was meaningless
colemanw [Tue, 2 Mar 2021 13:43:48 +0000 (08:43 -0500)]
Merge pull request #19694 from eileenmcnaughton/dash
dev/core#2426 Fix regression whereby the dashboard crashes (permission related)
Eileen McNaughton [Tue, 2 Mar 2021 11:00:21 +0000 (00:00 +1300)]
Merge pull request #19683 from colemanw/searchDisplayFixes
Search display fixes
eileen [Sun, 28 Feb 2021 22:34:11 +0000 (11:34 +1300)]
dev/core#2426 Fix regression whereby the dashboard crashes for contacts unable to view their own contact record.
As noted in the code comments this was not my preferred technical fix but I do lean
towards using this in the rc & reconsidering the other approaches in master.
Also, in master I got a different error that I think related to new work
Seamus Lee [Tue, 2 Mar 2021 08:54:25 +0000 (19:54 +1100)]
Merge pull request #19708 from J0WI/patch-1
Fix migrateUtf8mb4 for special database names
Eileen McNaughton [Tue, 2 Mar 2021 07:27:16 +0000 (20:27 +1300)]
Merge pull request #19675 from demeritcowboy/casedashlets
dev/core#1400 - Put dashlets back to only showing open cases by default
Coleman Watts [Wed, 10 Feb 2021 01:21:57 +0000 (20:21 -0500)]
Fix angular error when user is not logged in.
J0WI [Tue, 2 Mar 2021 00:30:51 +0000 (00:30 +0000)]
Fix migrateUtf8mb4 for special database names
Eileen McNaughton [Tue, 2 Mar 2021 00:14:34 +0000 (13:14 +1300)]
Merge pull request #19702 from seamuslee001/domain_petition_emails
[NFC] Add in unit test to prove that domain tokens are able to be inc…
Eileen McNaughton [Tue, 2 Mar 2021 00:12:47 +0000 (13:12 +1300)]
Merge pull request #19706 from civicrm/5.35
5.35
Seamus Lee [Mon, 1 Mar 2021 21:57:34 +0000 (08:57 +1100)]
Merge pull request #19705 from seamuslee001/update_schema_handler_test
[NFC] Update Schema Handler to use the standard create table syntax o…
colemanw [Mon, 1 Mar 2021 21:01:07 +0000 (16:01 -0500)]
Merge pull request #19704 from colemanw/removeDeprecatedAngularJs
Angular - Remove deprecated js file
Seamus Lee [Mon, 1 Mar 2021 20:27:32 +0000 (07:27 +1100)]
[NFC] Update Schema Handler to use the standard create table syntax of using ROW_FORMAT=dynamic
Seamus Lee [Mon, 1 Mar 2021 10:34:09 +0000 (21:34 +1100)]
[NFC] Add in unit test to prove that domain tokens are able to be incldued in peition emails
colemanw [Mon, 1 Mar 2021 19:40:05 +0000 (14:40 -0500)]
Merge pull request #19698 from eileenmcnaughton/custom
dev/core#2423 Fix quasi-regression around serialized custom fields
Coleman Watts [Mon, 1 Mar 2021 19:27:53 +0000 (14:27 -0500)]
Angular - Remove deprecated js file
Eileen McNaughton [Mon, 1 Mar 2021 08:31:36 +0000 (21:31 +1300)]
Merge pull request #19701 from civicrm/5.35
5.35
eileen [Mon, 1 Mar 2021 06:21:34 +0000 (19:21 +1300)]
Bring back some madness
eileen [Mon, 1 Mar 2021 03:18:48 +0000 (16:18 +1300)]
dev/core#2423 Fix quasi-regression around serialized custom fields
https://lab.civicrm.org/dev/core/-/issues/2423
Seamus Lee [Mon, 1 Mar 2021 06:10:35 +0000 (17:10 +1100)]
Merge pull request #19692 from demeritcowboy/case-custom-money-5.35
dev/core#2394 - Don't crash when saving custom case fields of type money
Eileen McNaughton [Mon, 1 Mar 2021 05:22:26 +0000 (18:22 +1300)]
Merge pull request #19699 from colemanw/controlField
APIv4 - Rename 'controlField' property to 'control_field'
Seamus Lee [Mon, 1 Mar 2021 04:36:31 +0000 (15:36 +1100)]
Merge pull request #19695 from civicrm/5.35
5.35
Coleman Watts [Mon, 1 Mar 2021 03:53:11 +0000 (22:53 -0500)]
APIv4 - Rename 'controlField' property to 'control_field' for consistency
By convention, all keys returned from the api should be lowercase.
colemanw [Mon, 1 Mar 2021 02:27:02 +0000 (21:27 -0500)]
Merge pull request #19690 from colemanw/api3Operators
APIv3 - Improve array-based apis to support sorting and operators
Seamus Lee [Mon, 1 Mar 2021 02:24:10 +0000 (13:24 +1100)]
Merge pull request #19680 from eileenmcnaughton/money
dev/financial#166 Fix for inconsistency around currency symbol
Eileen McNaughton [Mon, 1 Mar 2021 02:15:44 +0000 (15:15 +1300)]
Merge pull request #19696 from eileenmcnaughton/user
dev/core#2427 Fix user creation regression
Eileen McNaughton [Mon, 1 Mar 2021 01:56:53 +0000 (14:56 +1300)]
Merge pull request #19629 from MegaphoneJon/core-2386
core#2386 - metadata-driven chain-select fields
Coleman Watts [Sun, 28 Feb 2021 04:18:41 +0000 (23:18 -0500)]
APIv3 - Improve array-based apis to support sorting and multiple operators
This backports some APIv4 code to v3, for the purpose of supporting
entityRef widgets for Afform.
colemanw [Mon, 1 Mar 2021 01:06:27 +0000 (20:06 -0500)]
Merge pull request #19668 from eileenmcnaughton/empty_rows
dev/core#2420 Add text to report template saying no results found if that is the case
eileen [Mon, 1 Mar 2021 00:42:51 +0000 (13:42 +1300)]
dev/core#2427 Fix user creation regression
colemanw [Mon, 1 Mar 2021 00:42:15 +0000 (19:42 -0500)]
Merge pull request #19693 from eileenmcnaughton/if
[REF] clean up if
eileen [Fri, 26 Feb 2021 05:05:14 +0000 (18:05 +1300)]
dev/financial#166 Fix for inconsistency around currency symbol
From https://lab.civicrm.org/dev/financial/-/issues/166 we learn that the existing code
(tested via testFormatLocaleNumericRoundedByCurrency) is not consistent across
all platforms. I think this may be
colemanw [Mon, 1 Mar 2021 00:01:55 +0000 (19:01 -0500)]
Merge pull request #19685 from eileenmcnaughton/535
dev/core:2394 Fix for number formatting regression
Eileen McNaughton [Sun, 28 Feb 2021 23:34:57 +0000 (12:34 +1300)]
Merge pull request #19689 from demeritcowboy/my-cases-listtype
dev/core#1207 - My Cases dashlet shouldn't crash for users with only my cases access
eileen [Sun, 28 Feb 2021 20:22:33 +0000 (09:22 +1300)]
[REF] clean up if
This just makes 2 lines simpler. The issue is that if checks the same thing
twice - presumably the if empty check got added for the e-notice but
the other was not removed
demeritcowboy [Sun, 28 Feb 2021 15:02:48 +0000 (10:02 -0500)]
don't crash when saving custom fields of type money
Tim Otten [Sun, 28 Feb 2021 04:23:39 +0000 (20:23 -0800)]
Merge pull request #19688 from demeritcowboy/lottery-win
Fix for missing function CodeGen_Util::removeDir
demeritcowboy [Sun, 28 Feb 2021 03:15:47 +0000 (22:15 -0500)]
don't crash for users with only my cases access
Tim Otten [Fri, 26 Feb 2021 21:51:05 +0000 (13:51 -0800)]
dev/core#2418 - info.xml - Show full author list
Tim Otten [Fri, 26 Feb 2021 21:50:06 +0000 (13:50 -0800)]
dev/core#2418 - info.xml - Parse `<authors>` tag
demeritcowboy [Sat, 27 Feb 2021 17:22:34 +0000 (12:22 -0500)]
missing function
Eileen McNaughton [Sat, 27 Feb 2021 04:40:45 +0000 (17:40 +1300)]
Merge pull request #19686 from colemanw/searchKitClearSelection
SearchKit - Fix clearing selection behavior
Coleman Watts [Sat, 27 Feb 2021 01:50:57 +0000 (20:50 -0500)]
SearchKit - Fix clearing selection behavior
The variables `allRowsSelected` and `selectedRows` were sometimes getting out-of-sync.
This adds a function to help ensure they both get updated at the same time when the selection needs to be cleared.
Eileen McNaughton [Sat, 27 Feb 2021 01:10:31 +0000 (14:10 +1300)]
Merge pull request #19674 from demeritcowboy/caseclosed
dev/core#1400 - Failing test showing that My Cases users can't view their own closed cases
eileen [Fri, 26 Feb 2021 23:50:23 +0000 (12:50 +1300)]
dev/core:2394 Fix for number formatting regression
This function has been picking up the formatting for the locale
meaning that the currency separator replacement is already done and
is swapped back by formatLocaleNumericRoundedByPrecision
Doing it via brickmoney is better than our custom
separator replacement - but we need a quick fix for the rc
Seamus Lee [Fri, 26 Feb 2021 22:13:32 +0000 (09:13 +1100)]
Merge pull request #19682 from colemanw/dashlet-spacing
Reduce wasted space in civicrm dashboard margins
Coleman Watts [Fri, 26 Feb 2021 21:14:26 +0000 (16:14 -0500)]
SearchKit - Fix js error when adding label to buttons/links in List display
Coleman Watts [Fri, 26 Feb 2021 21:10:39 +0000 (16:10 -0500)]
SearchKit - More compact display column editing
Coleman Watts [Fri, 26 Feb 2021 20:50:17 +0000 (15:50 -0500)]
SearchKit - Add numbers to links when > 1 of the same entity
Eileen McNaughton [Fri, 26 Feb 2021 19:57:52 +0000 (08:57 +1300)]
Merge pull request #19666 from kainuk/dev_core_1400
dev/core#1400 Users with 'view own cases' permission can't open resolved cases
Eileen McNaughton [Fri, 26 Feb 2021 19:57:01 +0000 (08:57 +1300)]
Merge pull request #19673 from colemanw/searchKitLinks
SearchKit - Add links/menus/buttons to search displays
colemanw [Fri, 26 Feb 2021 19:03:51 +0000 (14:03 -0500)]
Reduce wasted space in civicrm dashboard margins
This removes the extra margins to the top and sides of the home dashboard page, only placing margins between the dashlets.
Matthew Wire [Fri, 26 Feb 2021 10:37:48 +0000 (10:37 +0000)]
Merge pull request #19641 from eileenmcnaughton/no_part
[REF] Load participant id within completeOrder rather than passing it in
Matthew Wire [Fri, 26 Feb 2021 10:36:13 +0000 (10:36 +0000)]
Merge pull request #19658 from eileenmcnaughton/member
[REF] Move code that relates to receipts when paying by credit card out of the shared function
Eileen McNaughton [Fri, 26 Feb 2021 05:38:29 +0000 (18:38 +1300)]
Merge pull request #19677 from totten/master-joomla-syncuser
Joomla::synchronizeUsers - Fix notice due to old style reference
Eileen McNaughton [Fri, 26 Feb 2021 04:51:37 +0000 (17:51 +1300)]
Merge pull request #19679 from civicrm/5.35
5.35 to master
Eileen McNaughton [Fri, 26 Feb 2021 04:50:54 +0000 (17:50 +1300)]
Merge pull request #19678 from totten/master-guzzle-url
GuzzleMiddleware::url() - Distinguish frontend and backend routes
Tim Otten [Wed, 17 Feb 2021 02:50:24 +0000 (18:50 -0800)]
GuzzleMiddleware::url() - Distinguish frontend and backend routes
Before: The `route://` scheme assumed backend access.
After: The `frontend://` and `backend://` schemes are unambiguous.
The `route://` scheme will make a best-guess by determining
if the menu item has `is_public`.
Coleman Watts [Thu, 25 Feb 2021 22:07:37 +0000 (17:07 -0500)]
SearchKit - Add links/menus/buttons to search displays
Tim Otten [Sat, 20 Feb 2021 01:18:16 +0000 (17:18 -0800)]
Joomla::synchronizeUsers - Fix notice due to old style reference
This fixes a PHP notice when synchronizing all users/contacts:
PHP Notice: Only variables should be assigned by reference in ...CRM/Utils/System/Joomla.php:855
eileen [Thu, 25 Feb 2021 00:47:45 +0000 (13:47 +1300)]
Add test to report template saying no results found if that is the case
Note this is done to create minimum white space change. I actuallY
think the criteria around charts should be in the tpl that
makes the decision to include Table.tpl rather than in Table.tpl
and this would become {if }{/else}{ts}No results found{/ts}{/if}
I can do that as a follow up if agreed
demeritcowboy [Thu, 25 Feb 2021 22:36:43 +0000 (17:36 -0500)]
put dashlets back to only showing open cases by default
demeritcowboy [Thu, 25 Feb 2021 22:32:24 +0000 (17:32 -0500)]
test showing non-admins can't see closed cases
colemanw [Thu, 25 Feb 2021 21:43:47 +0000 (16:43 -0500)]
Merge pull request #19672 from colemanw/contentEditableUI
Afform - move contentEditable directive into crmUI library for reusability
Seamus Lee [Thu, 25 Feb 2021 20:22:43 +0000 (07:22 +1100)]
Merge pull request #19662 from colemanw/searchDisplayRewrite
SearchKit - cleanup display configuration and add "rewrite" feature
Eileen McNaughton [Thu, 25 Feb 2021 19:31:55 +0000 (08:31 +1300)]
Merge pull request #19671 from jaapjansma/dev_2424
Fixes dev/core#2424 navigation items order
Coleman Watts [Thu, 25 Feb 2021 15:50:49 +0000 (10:50 -0500)]
Afform - move contentEditable directive into crmUI library for reusability
Jaap Jansma [Thu, 25 Feb 2021 14:02:34 +0000 (15:02 +0100)]
Fixes dev/core#2424 navigation items order
colemanw [Thu, 25 Feb 2021 13:13:20 +0000 (08:13 -0500)]
Merge pull request #19670 from eileenmcnaughton/aff
Switch afform back to '=' to unbreak deduper
eileen [Thu, 25 Feb 2021 07:03:25 +0000 (20:03 +1300)]
Switch afform back to '=' to unbreak deduper
https://github.com/eileenmcnaughton/deduper/pull/9
Seamus Lee [Thu, 25 Feb 2021 04:07:25 +0000 (15:07 +1100)]
Merge pull request #19669 from eileenmcnaughton/cont_status
Metadata: Add html:label for Contribution Status ID
eileen [Thu, 25 Feb 2021 02:15:28 +0000 (15:15 +1300)]
Metadata: Add html:label for Contribution Status ID
Seamus Lee [Thu, 25 Feb 2021 00:32:23 +0000 (11:32 +1100)]
Merge pull request #19667 from eileenmcnaughton/recurse
Fix master-only regression
eileen [Wed, 24 Feb 2021 21:30:18 +0000 (10:30 +1300)]
Fix master-only regression
It seems the tests ran before the test that covered this
was merged giving a false positive
See https://github.com/civicrm/civicrm-core/pull/19478#issuecomment-
785388559 for rationale
Seamus Lee [Wed, 24 Feb 2021 21:25:20 +0000 (08:25 +1100)]
Merge pull request #19638 from colemanw/entityRefId
EntityRef - Search by id when an integer is entered
colemanw [Wed, 24 Feb 2021 15:26:06 +0000 (10:26 -0500)]
Merge pull request #19664 from demeritcowboy/case-rel-minor-cleanup2
[NFC] minor cleanup in testCaseCreateWithResolvedStatus
colemanw [Wed, 24 Feb 2021 15:25:11 +0000 (10:25 -0500)]
Merge pull request #19663 from demeritcowboy/case-rel-minor-cleanup
Minor cleanup - ChangeCaseStatus
colemanw [Wed, 24 Feb 2021 13:46:47 +0000 (08:46 -0500)]
Merge pull request #19665 from seamuslee001/date_search_select
Afform: Only permit Date fields to be made into a select list if it i…
Coleman Watts [Wed, 24 Feb 2021 13:36:43 +0000 (08:36 -0500)]
EntityRef - Fix merging api params when searching by id
Klaas Eikelboom [Wed, 24 Feb 2021 09:50:36 +0000 (10:50 +0100)]
dev/core#1400 Users with 'view own cases' permission can't open resolved cases
Seamus Lee [Wed, 24 Feb 2021 09:40:09 +0000 (20:40 +1100)]
Afform: Only permit Date fields to be made into a select list if it is a search form
Seamus Lee [Wed, 24 Feb 2021 09:19:07 +0000 (20:19 +1100)]
Merge pull request #19632 from colemanw/afformDateRange
Afform - Support date range filters for search displays
demeritcowboy [Wed, 24 Feb 2021 04:24:30 +0000 (23:24 -0500)]
minor cleanup
demeritcowboy [Wed, 24 Feb 2021 04:18:07 +0000 (23:18 -0500)]
minor cleanup
Coleman Watts [Wed, 24 Feb 2021 01:38:39 +0000 (20:38 -0500)]
SearchKit - add option to rewrite field output in displays
colemanw [Tue, 23 Feb 2021 22:24:10 +0000 (17:24 -0500)]
Merge pull request #19478 from eileenmcnaughton/ref
[REF] do not needlessly pass as reference, enforce valid param
Eileen McNaughton [Tue, 23 Feb 2021 21:16:49 +0000 (10:16 +1300)]
Merge pull request #19610 from ahed-compucorp/dev/core#2372
dev/core#2372 Enable submitOnce for some forms
Eileen McNaughton [Tue, 23 Feb 2021 19:50:17 +0000 (08:50 +1300)]
Merge pull request #19661 from civicrm/5.35
5.35 to master
Eileen McNaughton [Tue, 23 Feb 2021 19:49:47 +0000 (08:49 +1300)]
Merge pull request #19659 from demeritcowboy/revert-18782
revert 18782
Eileen McNaughton [Tue, 23 Feb 2021 19:41:59 +0000 (08:41 +1300)]
Merge pull request #19655 from mlutfy/tr32fix
dev/translation#32 Contribution ThankYou: partial fix for recurring units
Coleman Watts [Tue, 23 Feb 2021 13:31:38 +0000 (08:31 -0500)]
SearchKit - More efficient use of space when configuring display fields
Coleman Watts [Mon, 22 Feb 2021 19:39:06 +0000 (14:39 -0500)]
SearchKit - Move common displayAdmin fields into shared templates
colemanw [Tue, 23 Feb 2021 18:41:55 +0000 (13:41 -0500)]
Merge pull request #19643 from colemanw/searchKitButtons
SearchKit - Don't save on enter key
Mathieu Lutfy [Mon, 22 Feb 2021 21:37:31 +0000 (16:37 -0500)]
dev/translation#32 Contribution ThankYou: partial fix for recurring units
demeritcowboy [Tue, 23 Feb 2021 12:11:59 +0000 (07:11 -0500)]
revert 18782