civicrm-core.git
21 months agoMerge pull request #25547 from eileenmcnaughton/559
Tim Otten [Wed, 15 Feb 2023 04:30:57 +0000 (20:30 -0800)]
Merge pull request #25547 from eileenmcnaughton/559

dev/core#4080 Fix wrong pdf format selection for invoice, when configured

21 months agoMerge pull request #25548 from eileenmcnaughton/559_token
Tim Otten [Wed, 15 Feb 2023 02:00:20 +0000 (18:00 -0800)]
Merge pull request #25548 from eileenmcnaughton/559_token

(dev/core#4109) Fix tokens like `{contact.email_primary.email}`

21 months agoMerge pull request #25555 from seamuslee001/dev_core_4116
Eileen McNaughton [Tue, 14 Feb 2023 03:16:53 +0000 (16:16 +1300)]
Merge pull request #25555 from seamuslee001/dev_core_4116

dev/core#4116 Add in rebuilding log table schema when modifying schema

21 months agodev/core#4116 Add in rebuilding log table schema when modifying schema
Seamus Lee [Sat, 11 Feb 2023 05:14:19 +0000 (16:14 +1100)]
dev/core#4116 Add in rebuilding log table schema when modifying schema

Only rebuild if logging is enabled

21 months agodev/core#4109 Fix advertised tokens to work
Eileen McNaughton [Fri, 10 Feb 2023 03:36:58 +0000 (16:36 +1300)]
dev/core#4109 Fix advertised tokens to work

21 months agodev/core#4080 Fix wrong pdf format selection for invoice, when configured
Eileen McNaughton [Fri, 10 Feb 2023 01:44:32 +0000 (14:44 +1300)]
dev/core#4080 Fix wrong pdf format selection for invoice, when configured

To replicate this I

1) created a new pdf format at civicrm/admin/pdfFormats?reset=1 with a top margin
of about 6 metres
2) edited the invoice MessageTemplate to use this pdf format
3) enabled invoicing
4) generated a pdf from the user dashboard
5) lots of white space.....
6) reset the invoice MessageTemplate not to have a selected pdf
7) it looked ... normal

21 months agoMerge pull request #25534 from totten/5.59-test-tz
demeritcowboy [Thu, 9 Feb 2023 00:41:35 +0000 (19:41 -0500)]
Merge pull request #25534 from totten/5.59-test-tz

CiviTestListener - Headless tests should initialize timezone

21 months agoCiviTestListener - Headless tests should have initialized timezone
Tim Otten [Wed, 8 Feb 2023 22:47:51 +0000 (14:47 -0800)]
CiviTestListener - Headless tests should have initialized timezone

Before
------

* `CiviUnitTestCase` calls `setMySQLTimeZone()`
* Headless tests (which are initialized via `CiviTestListener`) do not call `setMySQLTimeZone()`
* If you have a test like 5.57's flavor of `QueueTest`, then the tests pass or fail depending on happenstance of server timezone configuration.

After
-----

* `CiviUnitTestCase` and `CiviTestListener` both call `setMySQLTimeZone()`
* If you have a test like 5.57's flavor of `QueueTest`, then the tests pass more consistently.

Comments
--------

This branch should work cleanly as PR for `5.59` (rc) or `master`.  I'd
rather like to use this in `5.57-esr` (so that tests run more cleanly).
So maybe `5.59` is the better target (but it doesn't strictly have to be).

21 months agoMerge pull request #25525 from seamuslee001/group_filter_acl
Yashodha Chaku [Wed, 8 Feb 2023 11:13:40 +0000 (16:43 +0530)]
Merge pull request #25525 from seamuslee001/group_filter_acl

dev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering by a group as unneded for reports

21 months agodev/core#4068 Expand test coverage to include the contact summary report which is...
Seamus Lee [Wed, 8 Feb 2023 03:26:56 +0000 (14:26 +1100)]
dev/core#4068 Expand test coverage to include the contact summary report which is a non optimised report template

21 months agodev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering...
Seamus Lee [Wed, 8 Feb 2023 02:40:19 +0000 (13:40 +1100)]
dev/core#4068 Prevent adding in addSelectWhereClause for civicrm_group when filtering by a group as unneded for reports

Add in failing test to demonstrate issue with Group add SelectWhereClause on reports

21 months agoMerge pull request #25523 from demeritcowboy/dompdf-559
demeritcowboy [Wed, 8 Feb 2023 03:33:48 +0000 (22:33 -0500)]
Merge pull request #25523 from demeritcowboy/dompdf-559

Backport 25520

21 months agoBump dompdf/dompdf from 2.0.2 to 2.0.3
dependabot[bot] [Tue, 7 Feb 2023 23:51:27 +0000 (23:51 +0000)]
Bump dompdf/dompdf from 2.0.2 to 2.0.3

Dependabot couldn't find the original pull request head commit, 889dfb1c9efc4cba2f79ab4088c30fe6774c0835.

21 months agoMerge pull request #25498 from seamuslee001/5.59
demeritcowboy [Thu, 2 Feb 2023 04:52:08 +0000 (23:52 -0500)]
Merge pull request #25498 from seamuslee001/5.59

[REF] Use Civi::statics in CRM_Utils_File instead of php static

21 months ago[REF] Use Civi::statics in CRM_Utils_File instead of php static
Seamus Lee [Thu, 2 Feb 2023 01:41:08 +0000 (12:41 +1100)]
[REF] Use Civi::statics in CRM_Utils_File instead of php static

21 months agoSet version to 5.59.beta1
CiviCRM [Thu, 2 Feb 2023 01:40:41 +0000 (01:40 +0000)]
Set version to 5.59.beta1

21 months agoMerge branch '5.58'
Seamus Lee [Thu, 2 Feb 2023 01:14:16 +0000 (12:14 +1100)]
Merge branch '5.58'

21 months agoMerge pull request #25497 from totten/5.58-bump0
Tim Otten [Thu, 2 Feb 2023 00:56:03 +0000 (16:56 -0800)]
Merge pull request #25497 from totten/5.58-bump0

5.58.0 - Set version. Last-minute notes.

21 months agoUpdate 5.58.0.md
Tim Otten [Thu, 2 Feb 2023 00:52:16 +0000 (16:52 -0800)]
Update 5.58.0.md

21 months agoSet version to 5.58.0
Tim Otten [Thu, 2 Feb 2023 00:53:01 +0000 (16:53 -0800)]
Set version to 5.58.0

21 months agoMerge pull request #25490 from colemanw/dynamicCustom
Tim Otten [Thu, 2 Feb 2023 00:35:07 +0000 (16:35 -0800)]
Merge pull request #25490 from colemanw/dynamicCustom

Fix APIv4 autocompletes for dynamic entities

21 months agoMerge pull request #25485 from colemanw/contributionAutocomplete
Tim Otten [Thu, 2 Feb 2023 00:32:17 +0000 (16:32 -0800)]
Merge pull request #25485 from colemanw/contributionAutocomplete

Fix dev/core#4104 - APIv4 autocomplete for contributions

21 months agoMerge pull request #25367 from totten/5.58-check-tz
Tim Otten [Thu, 2 Feb 2023 00:26:10 +0000 (16:26 -0800)]
Merge pull request #25367 from totten/5.58-check-tz

System Status - Add check to ensure that MySQL timezones are operational

21 months agoMerge pull request #25494 from agh1/5.58.0-releasenotes-final
Tim Otten [Thu, 2 Feb 2023 00:06:34 +0000 (16:06 -0800)]
Merge pull request #25494 from agh1/5.58.0-releasenotes-final

5.58.0 release notes final

21 months ago5.58.0 release notes: added late changes
Andie Hunt [Wed, 1 Feb 2023 23:01:50 +0000 (18:01 -0500)]
5.58.0 release notes: added late changes

21 months agoAdd release-notes/5.57.3.md
Tim Otten [Tue, 31 Jan 2023 04:16:24 +0000 (20:16 -0800)]
Add release-notes/5.57.3.md

21 months agoAdd release-notes/5.57.2.md
Tim Otten [Thu, 26 Jan 2023 06:09:56 +0000 (22:09 -0800)]
Add release-notes/5.57.2.md

21 months agoAdd release-notes/5.57.2.md
Tim Otten [Thu, 26 Jan 2023 01:42:49 +0000 (17:42 -0800)]
Add release-notes/5.57.2.md

21 months agoAdd release-notes/5.57.1.md
Tim Otten [Thu, 12 Jan 2023 06:21:12 +0000 (22:21 -0800)]
Add release-notes/5.57.1.md

21 months agoAdd release-notes/5.56.2.md
Tim Otten [Wed, 4 Jan 2023 00:08:48 +0000 (16:08 -0800)]
Add release-notes/5.56.2.md

21 months agoAdd release-notes/5.56.1.md
Tim Otten [Wed, 21 Dec 2022 03:45:22 +0000 (19:45 -0800)]
Add release-notes/5.56.1.md

21 months agoAdd release-notes/5.55.2.md
Tim Otten [Fri, 18 Nov 2022 00:10:10 +0000 (16:10 -0800)]
Add release-notes/5.55.2.md

21 months agoUpdate 5.55.1.md
Tim Otten [Tue, 8 Nov 2022 06:11:11 +0000 (22:11 -0800)]
Update 5.55.1.md

21 months agoAdd release-notes/5.55.1.md
Tim Otten [Tue, 8 Nov 2022 06:02:28 +0000 (22:02 -0800)]
Add release-notes/5.55.1.md

21 months agoFix dev/core#4104 - APIv4 autocomplete for contributions
Coleman Watts [Wed, 1 Feb 2023 02:48:16 +0000 (21:48 -0500)]
Fix dev/core#4104 - APIv4 autocomplete for contributions

21 months agoMerge pull request #25492 from seamuslee001/5.58
Seamus Lee [Wed, 1 Feb 2023 22:22:31 +0000 (09:22 +1100)]
Merge pull request #25492 from seamuslee001/5.58

[REF] Update DOMPDF to be 2.0.2 and associated packages

21 months agoMerge pull request #25489 from braders/dynamic-property-ContributionPageTranslationTest
Seamus Lee [Wed, 1 Feb 2023 21:39:41 +0000 (08:39 +1100)]
Merge pull request #25489 from braders/dynamic-property-ContributionPageTranslationTest

[REF][PHP8.2] Remove dynamic property in CRM_Contribute_Form_ContributionPageTranslationTest

21 months agoMerge pull request #25491 from braders/membership-test-cleanup
Seamus Lee [Wed, 1 Feb 2023 21:39:05 +0000 (08:39 +1100)]
Merge pull request #25491 from braders/membership-test-cleanup

[REF][PHP8.2] Declare properties on CRM_Member_Import_Parser_MembershipTest

21 months ago[REF] Update DOMPDF to be 2.0.2 and associated packages
Seamus Lee [Wed, 1 Feb 2023 21:37:34 +0000 (08:37 +1100)]
[REF] Update DOMPDF to be 2.0.2 and associated packages

21 months ago[REF][PHP8.2] Declare properties on CRM_Member_Import_Parser_MembershipTest
Bradley Taylor [Wed, 1 Feb 2023 19:53:03 +0000 (19:53 +0000)]
[REF][PHP8.2] Declare properties on CRM_Member_Import_Parser_MembershipTest

21 months agoMerge pull request #25406 from braders/dynamic-properties-contactsearchtest
Tim Otten [Wed, 1 Feb 2023 20:20:13 +0000 (12:20 -0800)]
Merge pull request #25406 from braders/dynamic-properties-contactsearchtest

[REF][PHP8.2] Refactor CRM_Contact_BAO_ContactType_ContactSearchTest to not use dynamic properties

21 months ago[REF][PHP8.2] Remove dynamic property in CRM_Contribute_Form_ContributionPageTranslat...
Bradley Taylor [Wed, 1 Feb 2023 19:19:41 +0000 (19:19 +0000)]
[REF][PHP8.2] Remove dynamic property in CRM_Contribute_Form_ContributionPageTranslationTest

21 months agoFix APIv4 autocompletes for dynamic entities
Coleman Watts [Wed, 1 Feb 2023 18:40:27 +0000 (13:40 -0500)]
Fix APIv4 autocompletes for dynamic entities

Ensures APIv4 autocompletes work with dynamic entities like Multi-Record custom groups & the ECK extension

21 months agoMerge pull request #25488 from totten/master-headless-return
Seamus Lee [Wed, 1 Feb 2023 06:44:19 +0000 (17:44 +1100)]
Merge pull request #25488 from totten/master-headless-return

(REF) CRM_Upgrade_Headless - The pre-up and post-up msgs should have same formatting

21 months agoCRM_Upgrade_Headless - The pre-up and post-up msgs should have same formatting
Tim Otten [Wed, 1 Feb 2023 06:00:39 +0000 (22:00 -0800)]
CRM_Upgrade_Headless - The pre-up and post-up msgs should have same formatting

21 months agoMerge pull request #25414 from seamuslee001/headless_pre_upgrade
Tim Otten [Wed, 1 Feb 2023 05:43:43 +0000 (21:43 -0800)]
Merge pull request #25414 from seamuslee001/headless_pre_upgrade

[REF] Add in function to retrieve Pre Upgrade messages in headless

21 months agoMerge pull request #25484 from civicrm/5.58
demeritcowboy [Wed, 1 Feb 2023 01:53:26 +0000 (20:53 -0500)]
Merge pull request #25484 from civicrm/5.58

5.58

21 months agoMerge pull request #25478 from braders/dynamic-properties-contact-test
demeritcowboy [Wed, 1 Feb 2023 01:53:16 +0000 (20:53 -0500)]
Merge pull request #25478 from braders/dynamic-properties-contact-test

[REF][PHP8.2] Declare properties in CRM_Contact_BAO_ContactType_ContactTest

21 months agoMerge pull request #25482 from mattwire/25232search
demeritcowboy [Wed, 1 Feb 2023 00:58:03 +0000 (19:58 -0500)]
Merge pull request #25482 from mattwire/25232search

Fix internal server error when calling GetSearchTasks

21 months agoMerge pull request #25481 from demeritcowboy/dot
Tim Otten [Tue, 31 Jan 2023 23:17:26 +0000 (15:17 -0800)]
Merge pull request #25481 from demeritcowboy/dot

Fix typo in upgrade message

21 months agoMerge pull request #25483 from civicrm/5.58
Tim Otten [Tue, 31 Jan 2023 23:17:03 +0000 (15:17 -0800)]
Merge pull request #25483 from civicrm/5.58

5.58

21 months agoMerge pull request #25477 from christianwach/userdata
Tim Otten [Tue, 31 Jan 2023 22:54:20 +0000 (14:54 -0800)]
Merge pull request #25477 from christianwach/userdata

Prevent PHP warnings when no WordPress user is found

22 months agoMerge pull request #25455 from braders/dynmaic-properties-entrytest
Seamus Lee [Tue, 31 Jan 2023 21:18:13 +0000 (08:18 +1100)]
Merge pull request #25455 from braders/dynmaic-properties-entrytest

[REF][PHP8.2] Tidy up CRM_Batch_Form_EntryTest

22 months agoMerge pull request #25480 from demeritcowboy/err
Eileen McNaughton [Tue, 31 Jan 2023 21:14:42 +0000 (10:14 +1300)]
Merge pull request #25480 from demeritcowboy/err

Fix exception type in upgrade snapshot

22 months agoFix internal server error when calling GetSearchTasks
Matthew Wire [Tue, 31 Jan 2023 21:03:19 +0000 (21:03 +0000)]
Fix internal server error when calling GetSearchTasks

22 months agoMerge pull request #25479 from braders/CustomValueContactTypeTest-tidy
Eileen McNaughton [Tue, 31 Jan 2023 20:45:34 +0000 (09:45 +1300)]
Merge pull request #25479 from braders/CustomValueContactTypeTest-tidy

[REF][PHP8.2] Tidy, and PHP8.2 compatiability for api_v3_CustomValueContactTypeTest

22 months agoMerge pull request #25456 from MegaphoneJon/lifetime-membership-fix-1
Eileen McNaughton [Tue, 31 Jan 2023 20:43:50 +0000 (09:43 +1300)]
Merge pull request #25456 from MegaphoneJon/lifetime-membership-fix-1

simplify calculation of lifetime memberships in CRM_Price_BAO_PriceSet

22 months agotypo
demeritcowboy [Tue, 31 Jan 2023 20:20:38 +0000 (15:20 -0500)]
typo

22 months agofix exception type
demeritcowboy [Tue, 31 Jan 2023 20:15:49 +0000 (15:15 -0500)]
fix exception type

22 months ago[REF][PHP8.2] Tidy, and PHP8.2 compatiability for api_v3_CustomValueContactTypeTest
Bradley Taylor [Tue, 31 Jan 2023 19:38:39 +0000 (19:38 +0000)]
[REF][PHP8.2] Tidy, and PHP8.2 compatiability for api_v3_CustomValueContactTypeTest

22 months agoMerge pull request #25427 from eileenmcnaughton/notice_import
Matthew Wire [Tue, 31 Jan 2023 19:27:51 +0000 (19:27 +0000)]
Merge pull request #25427 from eileenmcnaughton/notice_import

Regression fix - fieldSeparator lost in 5.58 import screens

22 months ago[REF][PHP8.2] Declare properties in CRM_Contact_BAO_ContactType_ContactTest
Bradley Taylor [Tue, 31 Jan 2023 19:11:47 +0000 (19:11 +0000)]
[REF][PHP8.2] Declare properties in CRM_Contact_BAO_ContactType_ContactTest

22 months ago[REF][PHP8.2] Tidy up CRM_Batch_Form_EntryTest
Bradley Taylor [Sun, 29 Jan 2023 11:28:00 +0000 (11:28 +0000)]
[REF][PHP8.2] Tidy up CRM_Batch_Form_EntryTest

22 months agoMerge pull request #25420 from eileenmcnaughton/snap
colemanw [Tue, 31 Jan 2023 18:23:28 +0000 (13:23 -0500)]
Merge pull request #25420 from eileenmcnaughton/snap

Fix slow queries in snapshot process

22 months agoMerge pull request #25473 from eileenmcnaughton/email
colemanw [Tue, 31 Jan 2023 18:23:00 +0000 (13:23 -0500)]
Merge pull request #25473 from eileenmcnaughton/email

dev/core#4096 Rename Primary Email to Is Primary

22 months agoMerge pull request #25433 from eileenmcnaughton/sk_admin
colemanw [Tue, 31 Jan 2023 15:37:09 +0000 (10:37 -0500)]
Merge pull request #25433 from eileenmcnaughton/sk_admin

Do not crash the whole SearchKit UI if one entity fails

22 months agosimplify calculation of lifetime memberships in CRM_Price_BAO_PriceSet
Jon Goldberg [Sun, 29 Jan 2023 22:00:35 +0000 (17:00 -0500)]
simplify calculation of lifetime memberships in CRM_Price_BAO_PriceSet

22 months agoPrevent PHP warnings when no WordPress user is found
Christian Wach [Tue, 31 Jan 2023 10:39:32 +0000 (10:39 +0000)]
Prevent PHP warnings when no WordPress user is found

22 months agoMerge pull request #25475 from dontub/update-contributor-key
Yashodha Chaku [Tue, 31 Jan 2023 08:30:05 +0000 (14:00 +0530)]
Merge pull request #25475 from dontub/update-contributor-key

Add dontub to contributor-key.yml

22 months agoAdd dontub to contributor-key.yml
Dominic Tubach [Tue, 31 Jan 2023 08:18:31 +0000 (09:18 +0100)]
Add dontub to contributor-key.yml

22 months agodev/core#4096 Rename Primary Email to Is Primary
Eileen McNaughton [Tue, 31 Jan 2023 04:15:46 +0000 (17:15 +1300)]
dev/core#4096 Rename Primary Email to Is Primary

This field caused us problems because people mistook it
for .... the primary email field.... Renaming per agreement
on gitlab

22 months ago(NFC) CRM/Upgrade/Snapshot.php - Work-around for bug in linter
Tim Otten [Tue, 31 Jan 2023 02:36:09 +0000 (18:36 -0800)]
(NFC) CRM/Upgrade/Snapshot.php - Work-around for bug in linter

The linter for `@return` has a bug; it expects to see a `return`
and doesn't recognize the `yield` notation (which is radically new,
having been added in PHP 5.5 circa 2013).

22 months agoMerge pull request #25418 from eileenmcnaughton/imap
Mathieu Lu [Tue, 31 Jan 2023 02:28:20 +0000 (21:28 -0500)]
Merge pull request #25418 from eileenmcnaughton/imap

Increase timeout on imap

22 months agoMerge pull request #25460 from eileenmcnaughton/558
Tim Otten [Tue, 31 Jan 2023 01:51:09 +0000 (17:51 -0800)]
Merge pull request #25460 from eileenmcnaughton/558

dev/core#4063 fix lack of count info on soft credit listing

22 months agoMerge pull request #25468 from civicrm/5.58
Eileen McNaughton [Tue, 31 Jan 2023 01:10:12 +0000 (14:10 +1300)]
Merge pull request #25468 from civicrm/5.58

5.58 to master

22 months agoMerge pull request #25467 from demeritcowboy/resubscribe
Eileen McNaughton [Tue, 31 Jan 2023 01:08:23 +0000 (14:08 +1300)]
Merge pull request #25467 from demeritcowboy/resubscribe

Some renames missing from #24982

22 months agoearlier rename missing this one
demeritcowboy [Tue, 31 Jan 2023 01:03:49 +0000 (20:03 -0500)]
earlier rename missing this one

22 months agoMerge pull request #25334 from eileenmcnaughton/string_exception
demeritcowboy [Tue, 31 Jan 2023 00:32:49 +0000 (19:32 -0500)]
Merge pull request #25334 from eileenmcnaughton/string_exception

Ensure useful exception thrown for all Smarty errors from user strings

22 months agoAdd preUpgrade message
Eileen McNaughton [Mon, 30 Jan 2023 01:04:26 +0000 (14:04 +1300)]
Add preUpgrade message

22 months agoMerge pull request #25463 from demeritcowboy/profile-null
Seamus Lee [Mon, 30 Jan 2023 21:19:56 +0000 (08:19 +1100)]
Merge pull request #25463 from demeritcowboy/profile-null

php8 - don't pass null to htmlspecialchars on profile admin page

22 months agoEnsure useful exception thrown for all Smarty errors from user strings
Eileen McNaughton [Thu, 12 Jan 2023 04:42:00 +0000 (17:42 +1300)]
Ensure useful exception thrown for all Smarty errors from user strings

22 months agoMerge pull request #25462 from demeritcowboy/number
Eileen McNaughton [Mon, 30 Jan 2023 20:54:06 +0000 (09:54 +1300)]
Merge pull request #25462 from demeritcowboy/number

dev/core#4097 - Add deprecation notice as per comments at #25448

22 months agoMerge pull request #25453 from eileenmcnaughton/notice_no_display
demeritcowboy [Mon, 30 Jan 2023 18:11:25 +0000 (13:11 -0500)]
Merge pull request #25453 from eileenmcnaughton/notice_no_display

Smarty notice fix - check array key exists before querying

22 months agodon't pass null to htmlspecialchars
demeritcowboy [Mon, 30 Jan 2023 17:44:38 +0000 (12:44 -0500)]
don't pass null to htmlspecialchars

22 months agoMerge pull request #25323 from herbdool/core-4074
demeritcowboy [Mon, 30 Jan 2023 15:56:07 +0000 (10:56 -0500)]
Merge pull request #25323 from herbdool/core-4074

(dev/core#4074) Make CRM_Core_BAO_CMSUser CMS agnostic

22 months agoadd deprecation notice
demeritcowboy [Mon, 30 Jan 2023 13:12:38 +0000 (08:12 -0500)]
add deprecation notice

22 months agoMerge pull request #25448 from redcuillin/stringfix_formatLocaleNumeric
demeritcowboy [Mon, 30 Jan 2023 13:09:13 +0000 (08:09 -0500)]
Merge pull request #25448 from redcuillin/stringfix_formatLocaleNumeric

dev/core#4097 Fix empty string $amount error

22 months agoMerge pull request #25452 from eileenmcnaughton/notice
Yashodha Chaku [Mon, 30 Jan 2023 09:13:21 +0000 (14:43 +0530)]
Merge pull request #25452 from eileenmcnaughton/notice

Report tpl enotices fix

22 months agodev/core#4063 fix lack of count info on soft credit listing
Eileen McNaughton [Mon, 30 Jan 2023 04:41:16 +0000 (17:41 +1300)]
dev/core#4063 fix lack of count info on soft credit listing

https://lab.civicrm.org/dev/core/-/issues/4063

22 months agoMerge pull request #25459 from eileenmcnaughton/is_test
Seamus Lee [Mon, 30 Jan 2023 01:13:04 +0000 (12:13 +1100)]
Merge pull request #25459 from eileenmcnaughton/is_test

Fix some more smarty assignments to assign even when FALSE

22 months agoFix some more smarty assignments to assign even when FALSE
Eileen McNaughton [Sun, 29 Jan 2023 23:29:22 +0000 (12:29 +1300)]
Fix some more smarty assignments to assign even when FALSE

22 months agoAnother array_key_exists check for notice purposes
Eileen McNaughton [Sun, 29 Jan 2023 00:26:34 +0000 (13:26 +1300)]
Another array_key_exists check for notice purposes

22 months agoMerge pull request #25451 from eileenmcnaughton/num
demeritcowboy [Sun, 29 Jan 2023 00:24:55 +0000 (19:24 -0500)]
Merge pull request #25451 from eileenmcnaughton/num

Do not attempt to format custom value of empty string

22 months agoSmarty notice fix - check array key exists before querying
Eileen McNaughton [Sun, 29 Jan 2023 00:19:46 +0000 (13:19 +1300)]
Smarty notice fix - check array key exists before querying

22 months agoReport tpl enotice fix
Eileen McNaughton [Sun, 29 Jan 2023 00:09:22 +0000 (13:09 +1300)]
Report tpl enotice fix

22 months agoDo not attempt to format custom value of empty string
Eileen McNaughton [Sat, 28 Jan 2023 23:35:19 +0000 (12:35 +1300)]
Do not attempt to format custom value of empty string

22 months agoMerge pull request #25450 from braders/tidyup-detail-test
Seamus Lee [Sat, 28 Jan 2023 22:12:37 +0000 (09:12 +1100)]
Merge pull request #25450 from braders/tidyup-detail-test

[REF][PHP8.2] Tidy up of CRM_Report_Form_Member_DetailTest

22 months agoMerge pull request #25447 from braders/properties-hooktest
Seamus Lee [Sat, 28 Jan 2023 22:11:55 +0000 (09:11 +1100)]
Merge pull request #25447 from braders/properties-hooktest

[REF][PHP8.2] Declare missing property on CRM_Utils_HookTest

22 months ago[REF][PHP8.2] Tidy up of CRM_Report_Form_Member_DetailTest
Bradley Taylor [Sat, 28 Jan 2023 20:28:37 +0000 (20:28 +0000)]
[REF][PHP8.2] Tidy up of CRM_Report_Form_Member_DetailTest

22 months ago[REF][PHP8.2] Declare missing property on CRM_Utils_HookTest
Bradley Taylor [Fri, 27 Jan 2023 20:49:41 +0000 (20:49 +0000)]
[REF][PHP8.2] Declare missing property on CRM_Utils_HookTest