Mathieu Lu [Wed, 15 Dec 2021 12:30:14 +0000 (07:30 -0500)]
Merge pull request #22256 from eileenmcnaughton/order
Do not default-escape weight field on order
Eileen McNaughton [Wed, 15 Dec 2021 09:05:15 +0000 (22:05 +1300)]
Do not default-escape weight field on order
Seamus Lee [Wed, 15 Dec 2021 06:19:19 +0000 (17:19 +1100)]
Merge pull request #22253 from eileenmcnaughton/rel5
[REF] Minor parameter simplification
demeritcowboy [Wed, 15 Dec 2021 03:53:39 +0000 (22:53 -0500)]
Merge pull request #22251 from eileenmcnaughton/rel3
[NFC] Test cleanup
Eileen McNaughton [Wed, 15 Dec 2021 01:52:58 +0000 (14:52 +1300)]
[REF] Minor parameter simplification
The only value in this array used in the function is 'custom' which should be an array. I think it woul
d only ever be an array or NULL (which would then be an array with this change) but I left
a deprecation notice in case. Pass-by-ref isn't needed
Eileen McNaughton [Wed, 15 Dec 2021 03:06:11 +0000 (16:06 +1300)]
Merge pull request #22249 from eileenmcnaughton/rel
[NFC] Minor cleanup in test class
Eileen McNaughton [Wed, 15 Dec 2021 02:37:41 +0000 (15:37 +1300)]
Merge pull request #22252 from eileenmcnaughton/escapeit
Move require_once for smarty modifier due to order issues
Eileen McNaughton [Tue, 14 Dec 2021 21:13:37 +0000 (10:13 +1300)]
[NFC] Test cleanup
This biggest part of this is relying on the tearDown to do the cleanup more. This is the right
way because if the test fails the cleanup won't happen if it is in the test itsef
colemanw [Tue, 14 Dec 2021 22:10:31 +0000 (17:10 -0500)]
Merge pull request #22243 from demeritcowboy/quickfix-reportedby
dev/core#2825 - Make source contact required for activities on the form
Eileen McNaughton [Tue, 14 Dec 2021 21:27:15 +0000 (10:27 +1300)]
Move require_once for smarty modifier due to order issues
Eileen McNaughton [Tue, 14 Dec 2021 21:07:20 +0000 (10:07 +1300)]
[NFC] Minor cleanup in test class
demeritcowboy [Tue, 14 Dec 2021 21:07:01 +0000 (16:07 -0500)]
Merge pull request #22248 from MattTrim1/patch-1
Contributor key: Add Matt Trim
demeritcowboy [Tue, 14 Dec 2021 21:06:53 +0000 (16:06 -0500)]
Merge pull request #22244 from MattTrim1/flip-default-display-custom-group-options
dev/core#2977 - For custom group creation, flip the default display settings
MattTrim1 [Tue, 14 Dec 2021 19:21:11 +0000 (19:21 +0000)]
Contributor key: Add Matt Trim
demeritcowboy [Tue, 14 Dec 2021 19:18:08 +0000 (14:18 -0500)]
Merge pull request #22246 from mattwire/money0.5
Update Brick/Money to 0.5.3
Matthew Wire [Tue, 14 Dec 2021 11:03:41 +0000 (11:03 +0000)]
Update brick/money to 0.5.3
Matt Trim [Mon, 13 Dec 2021 23:29:41 +0000 (23:29 +0000)]
For custom group creation, flip the default display settings
demeritcowboy [Mon, 13 Dec 2021 19:56:24 +0000 (14:56 -0500)]
make source contact required
Yashodha Chaku [Mon, 13 Dec 2021 05:41:46 +0000 (11:11 +0530)]
Merge pull request #22240 from colemanw/nirodaonline-master
Contact/BAO/Query.php: fix searching for whitespace
Tim Otten [Sat, 11 Dec 2021 22:37:10 +0000 (14:37 -0800)]
Merge pull request #22213 from colemanw/afformApi4
[REF] Afform - Use APIv4 for managed dashboard
nirodaonline [Fri, 12 Nov 2021 15:55:17 +0000 (16:55 +0100)]
Contact/BAO/Query.php: fix searching for whitespace
Condition was never true
Add Unit test for space wildcard replacement on sort_name
fix failing test
Tim Otten [Sat, 11 Dec 2021 04:29:43 +0000 (20:29 -0800)]
Merge pull request #22096 from yashodha/dev-2962
(dev/core#2962) get contact id for the mailing along with display nam…
Tim Otten [Sat, 11 Dec 2021 04:21:29 +0000 (20:21 -0800)]
Merge pull request #22225 from colemanw/upgradeTemplateFix
Simplify autogenerated boilerplate upgrader class
Tim Otten [Sat, 11 Dec 2021 02:51:28 +0000 (18:51 -0800)]
Merge pull request #22238 from colemanw/upgradeVerBump
Upgrade - Bump minimum upgradable version to 4.6.12
Tim Otten [Fri, 10 Dec 2021 08:39:14 +0000 (00:39 -0800)]
(NFC) CRM_Upgrade_Incremental_Base - Expand docblocks. More references.
Coleman Watts [Fri, 10 Dec 2021 14:28:06 +0000 (09:28 -0500)]
Remove unnecessary legacy version check
Now that the minimum upgradable version is > 4.6, this check is not needed.
demeritcowboy [Fri, 10 Dec 2021 14:18:48 +0000 (09:18 -0500)]
Merge pull request #22186 from eileenmcnaughton/smarty12
Smarty variables] Another isset bites the dust
Coleman Watts [Fri, 10 Dec 2021 14:14:39 +0000 (09:14 -0500)]
Bump minimum upgradable version to 4.6.12
colemanw [Fri, 10 Dec 2021 14:03:19 +0000 (09:03 -0500)]
Merge pull request #22237 from totten/master-verifydb
(REF) CRM/Upgrade - Remove unused entrypoint `verifyPreDBstate()`
Tim Otten [Fri, 10 Dec 2021 08:49:55 +0000 (00:49 -0800)]
(REF) CRM/Upgrade - Remove unused entrypoint `verifyPreDBstate()`
Overview
--------
In olden times, upgraders sometimes implemented the method `verifyPreDBstate()`. However, this appears to be unused.
Additionally, it's not clear (from the documentation) how you would use it (if you wanted to).
So... simplify the code....
Before
------
Function exists. But it does nothing. Because no subclasses implement it.
After
-----
Function does not exist. It still does nothing.
Coleman Watts [Wed, 8 Dec 2021 14:22:27 +0000 (09:22 -0500)]
Simplify autogenerated boilerplate upgrader class and clarify comments
demeritcowboy [Fri, 10 Dec 2021 00:12:48 +0000 (19:12 -0500)]
Merge pull request #22187 from eileenmcnaughton/smarty13
Smarty variables] Remove isset from batch form
Eileen McNaughton [Tue, 30 Nov 2021 21:48:44 +0000 (10:48 +1300)]
Remove isset from batch form
Affects url civicrm/financial/financialbatches?reset=1&batchStatus=1
Mathieu Lu [Thu, 9 Dec 2021 21:47:27 +0000 (16:47 -0500)]
Merge pull request #22234 from colemanw/afformDateRange
Afform - Set date-range defaults
Eileen McNaughton [Thu, 9 Dec 2021 21:45:59 +0000 (10:45 +1300)]
Merge pull request #22232 from civicrm/5.45
5.45
Mathieu Lu [Thu, 9 Dec 2021 21:40:47 +0000 (16:40 -0500)]
Merge pull request #22226 from colemanw/deleteBoilerplate
NFC - Delete boilerplate comments and empty functions from upgrade classes
colemanw [Thu, 9 Dec 2021 21:09:38 +0000 (16:09 -0500)]
Merge pull request #22193 from eileenmcnaughton/smarty18
[Smarty variables] remove isset from merge screen
Tim Otten [Thu, 9 Dec 2021 21:02:58 +0000 (13:02 -0800)]
Merge pull request #22231 from colemanw/apiDisabledComponent
dev/core#2984 - Clarify API error when component is disabled
colemanw [Thu, 9 Dec 2021 19:24:25 +0000 (14:24 -0500)]
Merge pull request #22203 from colemanw/revertContactDeletePermission
Revert "Add permission metadata to contact is_deleted field"
Coleman Watts [Thu, 9 Dec 2021 17:34:57 +0000 (12:34 -0500)]
APIv4 - Fix datePicker defaults
Ensures datepickers can select more than the current year (start and end date years were defaulting to 0)
Fixes dev/report#84
demeritcowboy [Thu, 9 Dec 2021 16:24:36 +0000 (11:24 -0500)]
Merge pull request #22214 from yashodha/dev-2979
(dev/core#2979) remove the limit of 15 max values for multiple values…
yashodha [Mon, 6 Dec 2021 07:37:07 +0000 (13:07 +0530)]
change the limit
demeritcowboy [Thu, 9 Dec 2021 03:21:26 +0000 (22:21 -0500)]
Merge pull request #22194 from eileenmcnaughton/smarty19
[Smarty variables] Fix overzealous escaping with smarty default escaping
demeritcowboy [Thu, 9 Dec 2021 03:21:08 +0000 (22:21 -0500)]
Merge pull request #22195 from eileenmcnaughton/smarty20
[Smarty variables] Remove issets relating to auto_renew
Seamus Lee [Thu, 9 Dec 2021 01:42:22 +0000 (12:42 +1100)]
Merge pull request #22230 from agh1/5.45.0-releasenotes-initial
5.45.0 release notes initial run
Coleman Watts [Thu, 9 Dec 2021 00:47:38 +0000 (19:47 -0500)]
Fixes dev/core#2984 - Give clear error message when entity's component is disabled
Previously, using an API from a disabled component would fail in unexpected ways
with cryptic error messages. Now it's clearly not allowed.
Andie Hunt [Wed, 8 Dec 2021 22:16:53 +0000 (17:16 -0500)]
5.45.0 release notes: added boilerplate
Andie Hunt [Wed, 8 Dec 2021 22:11:18 +0000 (17:11 -0500)]
Contributor key: add Chris Garaffa
Andie Hunt [Wed, 8 Dec 2021 22:03:23 +0000 (17:03 -0500)]
5.45.0 release notes: raw from script
colemanw [Wed, 8 Dec 2021 18:28:35 +0000 (13:28 -0500)]
Merge pull request #22192 from eileenmcnaughton/smarty17
[Smarty variables] Remove issets from payment processor form
colemanw [Wed, 8 Dec 2021 18:27:39 +0000 (13:27 -0500)]
Merge pull request #22217 from demeritcowboy/repeat-deprecated
dev/core#2982 - Deprecated warnings for money formatting in Repeat Contributions CiviReport
colemanw [Wed, 8 Dec 2021 16:04:13 +0000 (11:04 -0500)]
Merge pull request #22224 from colemanw/boilerplateFix
NFC - Cleanup messy boilerplate
Coleman Watts [Wed, 8 Dec 2021 14:49:15 +0000 (09:49 -0500)]
NFC - Delete boilerplate comments and empty functions from upgrade classes
Coleman Watts [Wed, 8 Dec 2021 13:44:07 +0000 (08:44 -0500)]
NFC - Cleanup messy boilerplate
Matthew Wire [Wed, 8 Dec 2021 12:07:28 +0000 (12:07 +0000)]
Merge pull request #18158 from mattwire/createProfileContact
Initial refactor of createProfileContact groups
Seamus Lee [Wed, 8 Dec 2021 08:57:40 +0000 (19:57 +1100)]
Merge pull request #22222 from civicrm/5.45
5.45
Seamus Lee [Wed, 8 Dec 2021 02:27:44 +0000 (13:27 +1100)]
Merge pull request #22221 from seamuslee001/nfc_fix_system_test_mysql8
[NFC] Update System Uft8mb4 check to handle for the fact that MySQL8 …
Seamus Lee [Wed, 8 Dec 2021 01:00:25 +0000 (12:00 +1100)]
Merge pull request #22220 from seamuslee001/drupal9_get_version
[REF] Add in getVersion override for Drupal 8/9 to support cv testing…
Seamus Lee [Wed, 8 Dec 2021 00:31:11 +0000 (11:31 +1100)]
Merge pull request #22201 from colemanw/exportPseudoconstantFix
APIv4 Export - Fix logic for exporting pseudoconstant syntax
Seamus Lee [Wed, 8 Dec 2021 00:14:33 +0000 (11:14 +1100)]
[NFC] Update System Uft8mb4 check to handle for the fact that MySQL8 outputs utf8mb3 when the charset has been set to utf8 as utf8mb3 is the underlyling charset for utf8
Seamus Lee [Tue, 7 Dec 2021 23:27:09 +0000 (10:27 +1100)]
[REF] Add in getVersion override for Drupal 8/9 to support cv testing and also cv vars:show picking up the right CMS version
CiviCRM [Tue, 7 Dec 2021 21:48:15 +0000 (21:48 +0000)]
Set version to 5.46.alpha1
CiviCRM [Tue, 7 Dec 2021 21:27:23 +0000 (21:27 +0000)]
Set version to 5.45.beta1
colemanw [Tue, 7 Dec 2021 18:59:41 +0000 (13:59 -0500)]
Merge pull request #22199 from totten/master-mix-dec-all
civix#175 - Switch core extensions to mixins (ang-php, menu-xml, theme-php, case-xml, mgd-php)
demeritcowboy [Tue, 7 Dec 2021 18:49:07 +0000 (13:49 -0500)]
Merge pull request #22219 from demeritcowboy/selenium-webtests
[NFC] Remove Selenium WebTest code from CiviMailUtils
demeritcowboy [Tue, 7 Dec 2021 12:41:02 +0000 (07:41 -0500)]
Merge pull request #22218 from colemanw/fixCanAggregate
SearchKit - Fix undefined variable for searches of Afforms etc.
demeritcowboy [Sun, 21 Nov 2021 03:33:09 +0000 (22:33 -0500)]
remove selenium webtest code
Tim Otten [Tue, 7 Dec 2021 03:58:14 +0000 (19:58 -0800)]
mixin/case-xml - Enable CiviCase during testing
colemanw [Tue, 7 Dec 2021 02:21:37 +0000 (21:21 -0500)]
Merge pull request #22189 from eileenmcnaughton/smarty14
[Smarty variables] Consistently assign isAdmin at php layer
Seamus Lee [Tue, 7 Dec 2021 01:06:37 +0000 (12:06 +1100)]
Merge pull request #22205 from totten/master-hook-conform
APIv4 ConformanceTest - Demonstrate entity APIs which fail to emit `hook_civicrm_post(delete)`
demeritcowboy [Tue, 7 Dec 2021 00:57:48 +0000 (19:57 -0500)]
deprecated money-formatting of non-numeric
Tim Otten [Fri, 3 Dec 2021 07:01:27 +0000 (23:01 -0800)]
(REF) MixinLoader - Convert static to local property
Tim Otten [Fri, 3 Dec 2021 06:43:56 +0000 (22:43 -0800)]
(REF) Mixins - Promote `MixinLoader` to tracked service-object
Tim Otten [Fri, 3 Dec 2021 06:38:02 +0000 (22:38 -0800)]
(REF) Mixins - Move `applyMixins()` logic into `MixinLoader`
Tim Otten [Fri, 3 Dec 2021 06:30:50 +0000 (22:30 -0800)]
(REF) Mixins - Move more aspects of scanning from MixinLoader to MixinScanner
Tim Otten [Fri, 3 Dec 2021 04:50:05 +0000 (20:50 -0800)]
(REF) Mixins - Split apart class-loader and mixin-loader
Tim Otten [Thu, 2 Dec 2021 21:38:23 +0000 (13:38 -0800)]
ext/**.civix.php - Remove _civix_glob(). Not used anymore.
Tim Otten [Thu, 2 Dec 2021 21:35:35 +0000 (13:35 -0800)]
ext/**.civix.php - Remove _civix_find_files(). Not used anymore.
Tim Otten [Thu, 2 Dec 2021 21:30:21 +0000 (13:30 -0800)]
mixin/mgd-php - Remove unused boilerplate
Tim Otten [Thu, 2 Dec 2021 21:24:59 +0000 (13:24 -0800)]
mixin/mgd-php - Convert live `*.mgd.php` from `hook_managed` to `<mixin>`
Tim Otten [Tue, 30 Nov 2021 22:26:58 +0000 (14:26 -0800)]
mixin/mgd-php - Import
Tim Otten [Thu, 2 Dec 2021 21:17:14 +0000 (13:17 -0800)]
mixin/ang-php - Convert live Angular modules from `hook_angularModules` to `<mixin>`
Tim Otten [Wed, 1 Dec 2021 02:54:36 +0000 (18:54 -0800)]
mixin/menu-xml - Remove unused boilerplate
Tim Otten [Wed, 1 Dec 2021 02:47:05 +0000 (18:47 -0800)]
mixin/menu-xml - Convert live menu-items from `hook_xmlMenu` to `<mixin>`
Tim Otten [Tue, 30 Nov 2021 22:26:34 +0000 (14:26 -0800)]
mixin/menu-xml - Import
Tim Otten [Wed, 1 Dec 2021 02:39:49 +0000 (18:39 -0800)]
mixin/case-xml - Remove unused boilerplate
Tim Otten [Tue, 30 Nov 2021 22:26:23 +0000 (14:26 -0800)]
mixin/case-xml - Import
Tim Otten [Wed, 1 Dec 2021 02:30:38 +0000 (18:30 -0800)]
mixin/theme-php - Remove unused boilerplate
Tim Otten [Tue, 30 Nov 2021 22:26:50 +0000 (14:26 -0800)]
mixin/theme-php - Import
Tim Otten [Wed, 1 Dec 2021 01:00:25 +0000 (17:00 -0800)]
mixin/ang-php - Remove unused boilerplate
Tim Otten [Wed, 1 Dec 2021 00:53:40 +0000 (16:53 -0800)]
mixin/ang-php - Convert live Angular modules from `hook_angularModules` to `<mixin>`
Tim Otten [Tue, 30 Nov 2021 22:26:11 +0000 (14:26 -0800)]
mixin/ang-php - Import
Tim Otten [Mon, 6 Dec 2021 23:08:36 +0000 (15:08 -0800)]
Merge pull request #22207 from colemanw/baoDeleteHooks
[REF] - Switch BAOs to use standard delete function which calls hooks
Seamus Lee [Mon, 6 Dec 2021 22:38:38 +0000 (09:38 +1100)]
Merge pull request #22191 from eileenmcnaughton/smarty16
Smarty variables] Remove isset from a.net
demeritcowboy [Mon, 6 Dec 2021 19:26:31 +0000 (14:26 -0500)]
Merge pull request #22190 from eileenmcnaughton/smarty15
[Smarty variables] remove isset from Mail accounts
demeritcowboy [Mon, 6 Dec 2021 17:34:08 +0000 (12:34 -0500)]
Merge pull request #22181 from eileenmcnaughton/smarty8
[Smarty variables] Remove another isset - user dashboard
Yashodha Chaku [Mon, 6 Dec 2021 16:06:52 +0000 (21:36 +0530)]
Merge pull request #22216 from demeritcowboy/th-br
dev/core#2982 - Remove literal `<br/>` tag in header for Repeat Contributions CiviReport
demeritcowboy [Mon, 6 Dec 2021 15:25:11 +0000 (10:25 -0500)]
Merge pull request #22177 from eileenmcnaughton/smarty5
Smarty variables] Remove isset from relationship tab
demeritcowboy [Mon, 6 Dec 2021 14:16:46 +0000 (09:16 -0500)]
remove br tag in header
demeritcowboy [Mon, 6 Dec 2021 13:58:07 +0000 (08:58 -0500)]
Merge pull request #22215 from totten/master-mixin-xdebug
(NFC) tools/mixin/bin/test-all - Work-around segfault in CI