civicrm-core.git
4 years agoMerge pull request #17331 from colemanw/briefName
Tim Otten [Sat, 16 May 2020 02:54:25 +0000 (19:54 -0700)]
Merge pull request #17331 from colemanw/briefName

[REF] CRM_Core_DAO_AllCoreTables::getBriefName to accept BAO name

4 years agoMerge pull request #17335 from demeritcowboy/missing-semicolon
Seamus Lee [Sat, 16 May 2020 01:20:30 +0000 (11:20 +1000)]
Merge pull request #17335 from demeritcowboy/missing-semicolon

[REF] Missing semicolon on smtp settings page, code cleanup in file-on-case, add test

4 years agomissing semicolon, other cleanup, add test
demeritcowboy [Fri, 15 May 2020 21:47:42 +0000 (17:47 -0400)]
missing semicolon, other cleanup, add test

4 years agoMerge pull request #17291 from mfb/tracking-default
Seamus Lee [Fri, 15 May 2020 22:42:13 +0000 (08:42 +1000)]
Merge pull request #17291 from mfb/tracking-default

Allow click-through and open tracking to be enabled/disabled by default

4 years agoFix CRM_Core_DAO_AllCoreTables::getBriefName to accept BAO name
Coleman Watts [Fri, 15 May 2020 15:04:04 +0000 (11:04 -0400)]
Fix CRM_Core_DAO_AllCoreTables::getBriefName to accept BAO name

This function was overly strict about not accepting BAO names, prompting end-users of the function
to do their own ad-hoc conversions before using it.

4 years agoMerge pull request #17323 from JKingsnorth/patch-14
Matthew Wire [Fri, 15 May 2020 14:23:50 +0000 (15:23 +0100)]
Merge pull request #17323 from JKingsnorth/patch-14

dev/core#1762 Don't log subscription_history

4 years agoMerge pull request #17296 from agh1/fa-accordions
Matthew Wire [Fri, 15 May 2020 14:22:50 +0000 (15:22 +0100)]
Merge pull request #17296 from agh1/fa-accordions

Accordion open-close with Font Awesome icons

4 years agoMerge pull request #17327 from demeritcowboy/poland-lower-case
Seamus Lee [Fri, 15 May 2020 06:36:57 +0000 (16:36 +1000)]
Merge pull request #17327 from demeritcowboy/poland-lower-case

[NFC] Add comment regarding lower case for Polish states

4 years agoMerge pull request #17329 from civicrm/5.26
Seamus Lee [Fri, 15 May 2020 06:36:26 +0000 (16:36 +1000)]
Merge pull request #17329 from civicrm/5.26

5.26

4 years agoMerge pull request #17261 from seamuslee001/dev_core_1681
Seamus Lee [Fri, 15 May 2020 01:28:11 +0000 (11:28 +1000)]
Merge pull request #17261 from seamuslee001/dev_core_1681

dev/core#1681 Add in deprecation notice for Systems using MySQL versions before 5.7 and require 5.5 for install

4 years agoMerge pull request #17277 from mattwire/fatalerrorhandler
Seamus Lee [Fri, 15 May 2020 01:16:00 +0000 (11:16 +1000)]
Merge pull request #17277 from mattwire/fatalerrorhandler

Trigger fatalErrorHandler for PEAR errors and for logs with severity ERROR or higher

4 years agoMerge pull request #17307 from agh1/privacy-flag-conditional
Seamus Lee [Fri, 15 May 2020 01:10:09 +0000 (11:10 +1000)]
Merge pull request #17307 from agh1/privacy-flag-conditional

Comm prefs: add condition param for {privacyFlag}

4 years agoMerge pull request #17310 from agh1/autorenew-active-icon
Seamus Lee [Fri, 15 May 2020 01:09:01 +0000 (11:09 +1000)]
Merge pull request #17310 from agh1/autorenew-active-icon

Member tab: auto-renew status was hidden from screen readers

4 years agoMerge pull request #17326 from demeritcowboy/ts-params
colemanw [Fri, 15 May 2020 00:47:31 +0000 (20:47 -0400)]
Merge pull request #17326 from demeritcowboy/ts-params

Remove unneeded parameters in {ts} on membership form

4 years agoMerge pull request #17320 from totten/master-url-type
Seamus Lee [Thu, 14 May 2020 23:55:38 +0000 (09:55 +1000)]
Merge pull request #17320 from totten/master-url-type

(NFC) CRM_Utils_Url - Fix declared type

4 years agoprevent someone thinking this is wrong
demeritcowboy [Thu, 14 May 2020 23:24:09 +0000 (19:24 -0400)]
prevent someone thinking this is wrong

4 years agounneeded parameters
demeritcowboy [Thu, 14 May 2020 22:23:52 +0000 (18:23 -0400)]
unneeded parameters

4 years agoMerge pull request #17322 from eileenmcnaughton/ids
Tim Otten [Thu, 14 May 2020 20:46:59 +0000 (13:46 -0700)]
Merge pull request #17322 from eileenmcnaughton/ids

(NFC) Remove some cvs docblock help

4 years agoMerge pull request #16992 from colemanw/customSerialize
colemanw [Thu, 14 May 2020 20:08:26 +0000 (16:08 -0400)]
Merge pull request #16992 from colemanw/customSerialize

Add serialize column to civicrm_custom_field, remove "Multi-Select" html type

4 years agoMerge pull request #17314 from jitendrapurohit/dev-1758
Matthew Wire [Thu, 14 May 2020 11:22:40 +0000 (12:22 +0100)]
Merge pull request #17314 from jitendrapurohit/dev-1758

dev/core#1758 - Fix check number and trxn id values on record payment…

4 years agoMerge pull request #17285 from agh1/no-rendered-icons-in-data-source
Matthew Wire [Thu, 14 May 2020 11:15:12 +0000 (12:15 +0100)]
Merge pull request #17285 from agh1/no-rendered-icons-in-data-source

No rendered icons in data source

4 years agoMerge pull request #17303 from agh1/no-icon-crmbutton
Matthew Wire [Thu, 14 May 2020 11:13:41 +0000 (12:13 +0100)]
Merge pull request #17303 from agh1/no-icon-crmbutton

crmButton: support icon=0 for no icon

4 years agodev/core#1762 Don't log subscription_history
John Kingsnorth [Thu, 14 May 2020 08:27:55 +0000 (09:27 +0100)]
dev/core#1762 Don't log subscription_history

4 years agoRemove some cvs docblock help
eileen [Thu, 14 May 2020 06:37:00 +0000 (18:37 +1200)]
Remove some cvs docblock help

The $ pattern turns out to be cvs support. We agreed the whole block should only
stay if it adds extra info

4 years ago(NFC) CRM_Utils_Url - Fix declared type
Tim Otten [Thu, 14 May 2020 06:34:27 +0000 (23:34 -0700)]
(NFC) CRM_Utils_Url - Fix declared type

Before
------

References a non-existent type `\GuzzleHttp\Psr7\UriInterface`.

After
-----

References an existent type `\Psr\Http\Message\UriInterface`.

4 years agoMerge pull request #17306 from colemanw/priceFieldValue
Seamus Lee [Thu, 14 May 2020 00:45:16 +0000 (10:45 +1000)]
Merge pull request #17306 from colemanw/priceFieldValue

Cleanup PriceFieldValue BAO

4 years agoSet minimum install MySQL version to be 5.5 and a recommended minimum of 5.7
Seamus Lee [Fri, 8 May 2020 03:58:41 +0000 (13:58 +1000)]
Set minimum install MySQL version to be 5.5 and a recommended minimum of 5.7

Fix to use min install version

4 years agoAdd in deprecation notice for MySQL/MariaDB versions below 5.7
Seamus Lee [Fri, 8 May 2020 03:44:39 +0000 (13:44 +1000)]
Add in deprecation notice for MySQL/MariaDB versions below 5.7

4 years agoMerge pull request #17078 from herbdool/ui-18
Eileen McNaughton [Thu, 14 May 2020 00:16:53 +0000 (12:16 +1200)]
Merge pull request #17078 from herbdool/ui-18

Ui 18

4 years agoMerge pull request #17116 from lcdservices/dev-core-1721
Eileen McNaughton [Thu, 14 May 2020 00:12:47 +0000 (12:12 +1200)]
Merge pull request #17116 from lcdservices/dev-core-1721

dev/core#1721 send email to case follow-up activity assignees

4 years agoFix setting profile defaults
Coleman Watts [Mon, 11 May 2020 14:51:53 +0000 (10:51 -0400)]
Fix setting profile defaults

4 years agoFix dedupe merger handling of serialized custom fields
Coleman Watts [Fri, 17 Apr 2020 00:34:58 +0000 (20:34 -0400)]
Fix dedupe merger handling of serialized custom fields

4 years agoUpdate contact import parser to validate serialized custom fields
Coleman Watts [Fri, 17 Apr 2020 00:05:20 +0000 (20:05 -0400)]
Update contact import parser to validate serialized custom fields

4 years agoCustom Field serialization test fixes
Coleman Watts [Thu, 16 Apr 2020 21:56:37 +0000 (17:56 -0400)]
Custom Field serialization test fixes

4 years agoCleanup references to custom field html_type
Coleman Watts [Tue, 7 Apr 2020 14:57:11 +0000 (10:57 -0400)]
Cleanup references to custom field html_type

4 years agoUpdate CustomField form with 'serialize' option
Coleman Watts [Mon, 6 Apr 2020 01:23:50 +0000 (21:23 -0400)]
Update CustomField form with 'serialize' option

4 years agoEliminate Multi-Select field types
Coleman Watts [Sun, 5 Apr 2020 21:06:27 +0000 (17:06 -0400)]
Eliminate Multi-Select field types

4 years agoAPIv4 - Update custom field spec for serialize column
Coleman Watts [Fri, 3 Apr 2020 23:31:46 +0000 (19:31 -0400)]
APIv4 - Update custom field spec for serialize column

4 years agoRely on serialize property when checking if custom field is multivalued
Coleman Watts [Fri, 3 Apr 2020 01:06:06 +0000 (21:06 -0400)]
Rely on serialize property when checking if custom field is multivalued

4 years agoAPIv3 - Legacy handling for old way of naming serialized fields
Coleman Watts [Fri, 3 Apr 2020 00:37:05 +0000 (20:37 -0400)]
APIv3 - Legacy handling for old way of naming serialized fields

4 years agoAdd serialize column to civicrm_custom_field
Coleman Watts [Thu, 2 Apr 2020 21:37:59 +0000 (17:37 -0400)]
Add serialize column to civicrm_custom_field

4 years agoMerge pull request #17311 from KarinG/clarify_amount
Seamus Lee [Wed, 13 May 2020 22:36:53 +0000 (08:36 +1000)]
Merge pull request #17311 from KarinG/clarify_amount

Clarify definition of amount field in civicrm_contribution_recur table.

4 years agoMerge pull request #17313 from civicrm/5.26
Seamus Lee [Wed, 13 May 2020 22:35:54 +0000 (08:35 +1000)]
Merge pull request #17313 from civicrm/5.26

5.26

4 years agoCommon.js Icons should be aria-hidden
Andrew Hunt [Wed, 13 May 2020 18:20:34 +0000 (14:20 -0400)]
Common.js Icons should be aria-hidden

4 years agoMerge pull request #17316 from agh1/ab-test-flask-icon
colemanw [Wed, 13 May 2020 17:14:44 +0000 (13:14 -0400)]
Merge pull request #17316 from agh1/ab-test-flask-icon

A/B test: icon should be Erlenmeyer flask, not bar chart

4 years agoA/B test: icon should be Erlenmeyer flask, not bar chart
Andrew Hunt [Wed, 13 May 2020 15:55:51 +0000 (11:55 -0400)]
A/B test: icon should be Erlenmeyer flask, not bar chart

4 years agodev/core#1758 - Fix check number and trxn id values on record payment form
Jitendra Purohit [Wed, 13 May 2020 12:52:39 +0000 (18:22 +0530)]
dev/core#1758 - Fix check number and trxn id values on record payment form

4 years agoMerge pull request #17265 from MegaphoneJon/mime-error-rc
Seamus Lee [Wed, 13 May 2020 08:42:20 +0000 (18:42 +1000)]
Merge pull request #17265 from MegaphoneJon/mime-error-rc

[regression] Fix error on no MIME type

4 years agoMerge pull request #17309 from colemanw/MailingAB
Seamus Lee [Wed, 13 May 2020 08:38:06 +0000 (18:38 +1000)]
Merge pull request #17309 from colemanw/MailingAB

[REF] Cleanup MailingAB BAO

4 years agoClarify definition of amount field in civicrm_contribution_recur table.
KarinG [Tue, 12 May 2020 23:02:22 +0000 (17:02 -0600)]
Clarify definition of amount field in civicrm_contribution_recur table.

4 years agoMerge pull request #17293 from agh1/sr-wrenches
colemanw [Tue, 12 May 2020 22:15:03 +0000 (18:15 -0400)]
Merge pull request #17293 from agh1/sr-wrenches

Screen reader text for wrenches

4 years agoMerge pull request #17294 from agh1/sr-rel-perms
colemanw [Tue, 12 May 2020 22:08:37 +0000 (18:08 -0400)]
Merge pull request #17294 from agh1/sr-rel-perms

sr-only text for relationship permissions

4 years agoMember tab: auto-renew status was aria-hidden
Andrew Hunt [Tue, 12 May 2020 19:45:13 +0000 (15:45 -0400)]
Member tab: auto-renew status was aria-hidden

4 years agoCleanup MailingAB BAO
Coleman Watts [Tue, 12 May 2020 17:32:48 +0000 (13:32 -0400)]
Cleanup MailingAB BAO

- Use writeRecord function instead of boilerplate.
- Use api defaults for domain_id instead of setting in BAO:
  - APIv3 default domain is set via _civicrm_api3_mailing_a_b_create_spec() function.
  - APIv4 FieldDomainIdSpecProvider will set it automatically based on the required property in the schema.

4 years agoCRM.utils.formatIcon: updated function name and made condition optional
Andrew Hunt [Tue, 12 May 2020 18:35:26 +0000 (14:35 -0400)]
CRM.utils.formatIcon: updated function name and made condition optional

4 years agoComm prefs: add condition param for {privacyFlag}
Andrew Hunt [Tue, 12 May 2020 16:33:48 +0000 (12:33 -0400)]
Comm prefs: add condition param for {privacyFlag}

4 years agoCleanup PriceFieldValue BAO
Coleman Watts [Tue, 12 May 2020 15:56:56 +0000 (11:56 -0400)]
Cleanup PriceFieldValue BAO

- Use writeRecord() helper function
- Remove $ids param from add()
- Make sense of previously unused $priceFieldID variable

4 years agocrmButton: support icon=0 for no icon
Andrew Hunt [Tue, 12 May 2020 15:20:07 +0000 (11:20 -0400)]
crmButton: support icon=0 for no icon

4 years agoUpdate CRM/Core/Form/Renderer.php
Andrew Hunt [Tue, 12 May 2020 13:58:48 +0000 (09:58 -0400)]
Update CRM/Core/Form/Renderer.php

Adopting @colemanw's suggestion since it's more of a concern that the label be blank than undefined.

Co-authored-by: colemanw <coleman@civicrm.org>
4 years agoMerge pull request #17301 from eileenmcnaughton/recur
colemanw [Tue, 12 May 2020 13:37:21 +0000 (09:37 -0400)]
Merge pull request #17301 from eileenmcnaughton/recur

dev/core#1728 Ensure that custom fields that extend specified financi…

4 years agoMerge pull request #17302 from eileenmcnaughton/mem
colemanw [Tue, 12 May 2020 13:36:36 +0000 (09:36 -0400)]
Merge pull request #17302 from eileenmcnaughton/mem

[REF] Minor tidy up

4 years agoMerge pull request #17246 from agh1/review-contrib
colemanw [Tue, 12 May 2020 12:51:10 +0000 (08:51 -0400)]
Merge pull request #17246 from agh1/review-contrib

Proceeding to confirmation page should be a "next" button not a check

4 years ago[REF] Minor tidy up
eileen [Tue, 12 May 2020 07:30:04 +0000 (19:30 +1200)]
[REF] Minor tidy up

Removes a few old constructs like the value() function

4 years agoAlternate to #17156
eileen [Tue, 12 May 2020 07:11:37 +0000 (19:11 +1200)]
Alternate to #17156

4 years agoMerge pull request #17299 from eileenmcnaughton/recur
Seamus Lee [Tue, 12 May 2020 05:44:24 +0000 (15:44 +1000)]
Merge pull request #17299 from eileenmcnaughton/recur

Add ContributionRecur crud api

4 years agoMerge pull request #17295 from agh1/fa-more
colemanw [Tue, 12 May 2020 02:46:33 +0000 (22:46 -0400)]
Merge pull request #17295 from agh1/fa-more

Replaced more> icon with Font Awesome

4 years agoAdd ContributionRecur crud api
eileen [Tue, 12 May 2020 01:58:53 +0000 (13:58 +1200)]
Add ContributionRecur crud api

4 years agoEvent aggregate custom search: Remove archaic form patterns
Andrew Hunt [Sat, 9 May 2020 04:16:13 +0000 (00:16 -0400)]
Event aggregate custom search: Remove archaic form patterns

4 years agoGet rid of unused CRM_Core_ShowHideBlocks::links()
Andrew Hunt [Sat, 9 May 2020 03:54:02 +0000 (23:54 -0400)]
Get rid of unused CRM_Core_ShowHideBlocks::links()

4 years agoReplaced collapse/expand icon with Font Awesome
Andrew Hunt [Sat, 9 May 2020 02:09:51 +0000 (22:09 -0400)]
Replaced collapse/expand icon with Font Awesome

4 years agoMerge pull request #17289 from agh1/icon-title-escape
colemanw [Tue, 12 May 2020 00:00:29 +0000 (20:00 -0400)]
Merge pull request #17289 from agh1/icon-title-escape

Icon helper: replace quotes in html title.

4 years agoCiviCase activities: remove sole instance of crm-accordion-inner
Andrew Hunt [Sat, 9 May 2020 01:45:17 +0000 (21:45 -0400)]
CiviCase activities: remove sole instance of crm-accordion-inner

4 years agoReplaced more> icon with Font Awesome
Andrew Hunt [Sat, 9 May 2020 02:58:41 +0000 (22:58 -0400)]
Replaced more> icon with Font Awesome

4 years agosr-only text for relationship permissions
Andrew Hunt [Sat, 9 May 2020 00:07:56 +0000 (20:07 -0400)]
sr-only text for relationship permissions

4 years agosr-only text for wrenches
Andrew Hunt [Fri, 8 May 2020 23:15:48 +0000 (19:15 -0400)]
sr-only text for wrenches

4 years agoProceeding to confirmation page should be a "next" button not a check
Andrew Hunt [Mon, 11 May 2020 23:03:20 +0000 (19:03 -0400)]
Proceeding to confirmation page should be a "next" button not a check

4 years agoAllow click-through and open tracking to be enabled/disabled by default
mark burdett [Mon, 11 May 2020 22:55:21 +0000 (15:55 -0700)]
Allow click-through and open tracking to be enabled/disabled by default

4 years agoMerge pull request #17273 from mattwire/phpnoticeisoverride
Yashodha Chaku [Mon, 11 May 2020 15:21:21 +0000 (20:51 +0530)]
Merge pull request #17273 from mattwire/phpnoticeisoverride

Fix PHP notice when is_override is not set

4 years agoMerge pull request #16967 from wmortada/wp#46-2
Matthew Wire [Mon, 11 May 2020 14:38:31 +0000 (15:38 +0100)]
Merge pull request #16967 from wmortada/wp#46-2

dev/wp#46 - Fix overlarge select2 elements in WordPress 5.3+

4 years agoCRM.utils.formatConditionalIcon: Escape html characters in alt text
Andrew Hunt [Mon, 11 May 2020 14:07:13 +0000 (10:07 -0400)]
CRM.utils.formatConditionalIcon: Escape html characters in alt text

4 years agoSend `is_default` data as boolean, not rendered icon; add js icon helper
Andrew Hunt [Fri, 8 May 2020 19:40:46 +0000 (15:40 -0400)]
Send `is_default` data as boolean, not rendered icon; add js icon helper

4 years agoIcon helper: replace quotes in html title.
Andrew Hunt [Mon, 11 May 2020 13:40:25 +0000 (09:40 -0400)]
Icon helper: replace quotes in html title.

4 years agoMerge pull request #17284 from agh1/admin-console-only
Matthew Wire [Mon, 11 May 2020 09:39:27 +0000 (10:39 +0100)]
Merge pull request #17284 from agh1/admin-console-only

Simplify admin console and remove superfluous icons

4 years agoFix PHP notice when is_override is not set
Matthew Wire [Sun, 10 May 2020 10:44:01 +0000 (11:44 +0100)]
Fix PHP notice when is_override is not set

4 years agoMerge pull request #17283 from agh1/stop-icon-png
Matthew Wire [Mon, 11 May 2020 09:22:03 +0000 (10:22 +0100)]
Merge pull request #17283 from agh1/stop-icon-png

Replace stop-icon.png with fa-ban over a relevant icon for privacy

4 years agoMerge pull request #17286 from seamuslee001/contribution_id_search_metadata
Matthew Wire [Mon, 11 May 2020 09:21:48 +0000 (10:21 +0100)]
Merge pull request #17286 from seamuslee001/contribution_id_search_metadata

[REF] Add contribution_id field to search using metadata instead of h…

4 years agoMerge pull request #17280 from agh1/copy-png
Matthew Wire [Mon, 11 May 2020 09:21:03 +0000 (10:21 +0100)]
Merge pull request #17280 from agh1/copy-png

Replace all instances of copy.png with font awesome

4 years agoMerge pull request #17279 from agh1/check-gif
Matthew Wire [Mon, 11 May 2020 09:20:42 +0000 (10:20 +0100)]
Merge pull request #17279 from agh1/check-gif

Remove most uses of check.gif

4 years ago[REF] Add contribution_id field to search using metadata instead of hard codeded...
Seamus Lee [Sun, 10 May 2020 22:18:10 +0000 (08:18 +1000)]
[REF] Add contribution_id field to search using metadata instead of hard codeded quickform html

4 years agoMerge pull request #17275 from mattwire/mailingbackend
Seamus Lee [Sun, 10 May 2020 21:12:23 +0000 (07:12 +1000)]
Merge pull request #17275 from mattwire/mailingbackend

NFC Change hardcoded ID to constant

4 years agoMerge pull request #17281 from agh1/geotag-16-png
colemanw [Sun, 10 May 2020 20:17:53 +0000 (16:17 -0400)]
Merge pull request #17281 from agh1/geotag-16-png

Replace geotag_16.png with fa-map-marker

4 years agoAdmin console: remove superfluous code and don't hard-code sections
Andrew Hunt [Sat, 9 May 2020 03:37:50 +0000 (23:37 -0400)]
Admin console: remove superfluous code and don't hard-code sections

4 years agoAdmin console: remove old version and icons
Andrew Hunt [Thu, 7 May 2020 20:25:17 +0000 (16:25 -0400)]
Admin console: remove old version and icons

4 years agoAdmin console: produced much simpler version
Andrew Hunt [Thu, 7 May 2020 14:48:12 +0000 (10:48 -0400)]
Admin console: produced much simpler version

4 years agoReplace stop-icon.png with fa-ban over a relevant icon for privacy
Andrew Hunt [Thu, 7 May 2020 19:27:32 +0000 (15:27 -0400)]
Replace stop-icon.png with fa-ban over a relevant icon for privacy

4 years agoReplace geotag_16.png with fa-map-marker
Andrew Hunt [Thu, 7 May 2020 17:36:20 +0000 (13:36 -0400)]
Replace geotag_16.png with fa-map-marker

4 years agoReplace all instances of copy.png with font awesome
Andrew Hunt [Thu, 7 May 2020 17:29:27 +0000 (13:29 -0400)]
Replace all instances of copy.png with font awesome

4 years agoReplace all instances of check.gif appearing in listings
Andrew Hunt [Thu, 7 May 2020 16:51:42 +0000 (12:51 -0400)]
Replace all instances of check.gif appearing in listings

4 years agoCiviMail compose: replace check.gif with Font Awesome icons
Andrew Hunt [Thu, 7 May 2020 15:46:15 +0000 (11:46 -0400)]
CiviMail compose: replace check.gif with Font Awesome icons

4 years agoTrigger fatalErrorHandler for PEAR errors and for logs with severity ERROR or higher
Matthew Wire [Sun, 10 May 2020 11:03:25 +0000 (12:03 +0100)]
Trigger fatalErrorHandler for PEAR errors and for logs with severity ERROR or higher