civicrm-core.git
2 years agoMerge pull request #26676 from colemanw/getquickGoodbye
demeritcowboy [Sat, 2 Sep 2023 13:30:59 +0000 (09:30 -0400)]
Merge pull request #26676 from colemanw/getquickGoodbye

Switch menubar search to use APIv4 & delete deprecated v3 'getquick' action

2 years agoMerge pull request #27257 from colemanw/entityLookup
Eileen McNaughton [Sat, 2 Sep 2023 05:02:30 +0000 (17:02 +1200)]
Merge pull request #27257 from colemanw/entityLookup

Add API-based EntityLookupTrait

2 years agoMerge pull request #27256 from eileenmcnaughton/party
Eileen McNaughton [Sat, 2 Sep 2023 04:56:00 +0000 (16:56 +1200)]
Merge pull request #27256 from eileenmcnaughton/party

Further fix forms to full form flow

2 years agoAdd API-based EntityLookupTrait
colemanw [Sat, 2 Sep 2023 03:27:23 +0000 (23:27 -0400)]
Add API-based EntityLookupTrait

2 years agoFurther fix forms to full form flow
Eileen McNaughton [Sat, 2 Sep 2023 00:09:57 +0000 (12:09 +1200)]
Further fix forms to full form flow

2 years agoMerge pull request #27231 from eileenmcnaughton/weight_fin
Eileen McNaughton [Sat, 2 Sep 2023 02:49:16 +0000 (14:49 +1200)]
Merge pull request #27231 from eileenmcnaughton/weight_fin

Add weights to membership type links

2 years agoAdd weights to membership type links
Eileen McNaughton [Thu, 31 Aug 2023 11:36:41 +0000 (23:36 +1200)]
Add weights to membership type links

This includes moving the permissioning of those links to the financialacls extension
(since there was already an affected test in that extension too).

2 years agoMerge pull request #26841 from colemanw/customAutocompleteUpdate
colemanw [Fri, 1 Sep 2023 21:01:39 +0000 (17:01 -0400)]
Merge pull request #26841 from colemanw/customAutocompleteUpdate

dev/core#3049 - Update autocomplete custom fields to use APIv4

2 years agoMerge pull request #27253 from colemanw/editableEntity
colemanw [Fri, 1 Sep 2023 18:44:57 +0000 (14:44 -0400)]
Merge pull request #27253 from colemanw/editableEntity

SearchKit - Fix autocomplete filters on in-place-edit fields

2 years agoSearchKit - Fix autocomplete filters on in-place-edit fields
colemanw [Fri, 1 Sep 2023 17:43:19 +0000 (13:43 -0400)]
SearchKit - Fix autocomplete filters on in-place-edit fields

2 years agoMerge pull request #26993 from eileenmcnaughton/upgrade
colemanw [Fri, 1 Sep 2023 16:45:23 +0000 (12:45 -0400)]
Merge pull request #26993 from eileenmcnaughton/upgrade

Ensure tax_amount is not null

2 years agoMerge pull request #27249 from yashodha/report_improvement
colemanw [Fri, 1 Sep 2023 16:43:42 +0000 (12:43 -0400)]
Merge pull request #27249 from yashodha/report_improvement

Add sorting options on Membership Details report

2 years agodev/core#3049 - Permit custom autocomplete fields on public profile forms
colemanw [Fri, 1 Sep 2023 16:34:56 +0000 (12:34 -0400)]
dev/core#3049 - Permit custom autocomplete fields on public profile forms

2 years agoMerge pull request #27250 from eileenmcnaughton/party
colemanw [Fri, 1 Sep 2023 16:35:57 +0000 (12:35 -0400)]
Merge pull request #27250 from eileenmcnaughton/party

Fix forms to call full form flow

2 years agodev/core#3049 - Update autocomplete custom fields to use APIv4
colemanw [Sat, 15 Jul 2023 17:26:38 +0000 (13:26 -0400)]
dev/core#3049 - Update autocomplete custom fields to use APIv4

2 years agoAdd sorting options on Membership Details report
yashodha [Fri, 1 Sep 2023 06:57:32 +0000 (12:27 +0530)]
Add sorting options on Membership Details report

2 years agoMerge pull request #27226 from eileenmcnaughton/mutli
colemanw [Fri, 1 Sep 2023 12:36:55 +0000 (08:36 -0400)]
Merge pull request #27226 from eileenmcnaughton/mutli

dev/core#444 Default to blank for required multi-lingual fields

2 years agoFix forms to call full form flow
Eileen McNaughton [Fri, 1 Sep 2023 08:12:40 +0000 (20:12 +1200)]
Fix forms to call full form flow

2 years agoMerge pull request #27248 from seamuslee001/master
Seamus Lee [Fri, 1 Sep 2023 06:45:37 +0000 (02:45 -0400)]
Merge pull request #27248 from seamuslee001/master

5.65

2 years agoMerge branch '5.65'
Seamus Lee [Fri, 1 Sep 2023 06:16:52 +0000 (16:16 +1000)]
Merge branch '5.65'

2 years agoMerge pull request #27237 from seamuslee001/dev_core_4537
Seamus Lee [Fri, 1 Sep 2023 06:14:23 +0000 (02:14 -0400)]
Merge pull request #27237 from seamuslee001/dev_core_4537

dev/core#4537 Ensure that Event Registration email works when CiviCon…

2 years agoMerge pull request #27245 from eileenmcnaughton/party
Seamus Lee [Fri, 1 Sep 2023 06:00:07 +0000 (02:00 -0400)]
Merge pull request #27245 from eileenmcnaughton/party

Participant Form Test fixes

2 years agodev/core#4537 Ensure that Event Registration email works when CiviContribute componen...
Seamus Lee [Thu, 31 Aug 2023 22:53:14 +0000 (08:53 +1000)]
dev/core#4537 Ensure that Event Registration email works when CiviContribute component is disabled and add unit test

Shift to using action object provider and rename function to remove Component

2 years agoParticipant Form Test fixes
Eileen McNaughton [Fri, 1 Sep 2023 03:35:30 +0000 (15:35 +1200)]
Participant Form Test fixes

2 years agoMerge pull request #27243 from alifrumin/5.65rn
Eileen McNaughton [Fri, 1 Sep 2023 04:12:57 +0000 (16:12 +1200)]
Merge pull request #27243 from alifrumin/5.65rn

[NFC] 5.65 Release Notes

2 years ago[NFC] release notes 5.65
Alice Frumin [Mon, 28 Aug 2023 20:38:08 +0000 (16:38 -0400)]
[NFC] release notes 5.65

2 years agoMerge pull request #27238 from eileenmcnaughton/test_clean
Eileen McNaughton [Fri, 1 Sep 2023 02:23:40 +0000 (14:23 +1200)]
Merge pull request #27238 from eileenmcnaughton/test_clean

Superficial clean up in test class

2 years agodev/core#444 Default to blank for required multi-lingual fields
Eileen McNaughton [Thu, 31 Aug 2023 08:41:13 +0000 (20:41 +1200)]
dev/core#444 Default to blank for required multi-lingual fields

2 years agoMerge pull request #27236 from colemanw/textOptions
Eileen McNaughton [Fri, 1 Sep 2023 01:50:31 +0000 (13:50 +1200)]
Merge pull request #27236 from colemanw/textOptions

APIv4 - Add missing input type options

2 years agoMerge pull request #27228 from pradpnayak/dateFormattingIssue
Eileen McNaughton [Fri, 1 Sep 2023 01:49:54 +0000 (13:49 +1200)]
Merge pull request #27228 from pradpnayak/dateFormattingIssue

PHP8 date range not rendered correctly

2 years agoMerge pull request #27239 from totten/phpstorm-adaptive-path
Eileen McNaughton [Fri, 1 Sep 2023 01:48:58 +0000 (13:48 +1200)]
Merge pull request #27239 from totten/phpstorm-adaptive-path

phpstorm - Prefer to store generated hints in source-tree

2 years agoSuperficial clean up in test class
Eileen McNaughton [Fri, 1 Sep 2023 00:25:35 +0000 (12:25 +1200)]
Superficial clean up in test class

2 years agophpstorm - Allow manual override of data folder
Tim Otten [Fri, 1 Sep 2023 01:04:58 +0000 (18:04 -0700)]
phpstorm - Allow manual override of data folder

2 years agogitignore - Ignore dynamically generated ".phpstorm.meta.php"
Tim Otten [Fri, 1 Sep 2023 00:23:20 +0000 (17:23 -0700)]
gitignore - Ignore dynamically generated ".phpstorm.meta.php"

2 years agophpstorm - Prefer self-same folder for output, but fallback to [civicrm.files]
Tim Otten [Fri, 1 Sep 2023 00:19:40 +0000 (17:19 -0700)]
phpstorm - Prefer self-same folder for output, but fallback to [civicrm.files]

2 years agoAPIv4 - Add missing input type options
colemanw [Fri, 1 Sep 2023 00:05:16 +0000 (20:05 -0400)]
APIv4 - Add missing input type options

2 years agophpstorm - Move static rules into the dynamic folder
Tim Otten [Fri, 1 Sep 2023 00:02:20 +0000 (17:02 -0700)]
phpstorm - Move static rules into the dynamic folder

2 years agophpstorm - Regen code
Tim Otten [Thu, 31 Aug 2023 23:47:06 +0000 (16:47 -0700)]
phpstorm - Regen code

A couple symbols were stale after prior edit to 'info.xml'

2 years agoRemove deprecated v3 Contact.getquick api
colemanw [Tue, 27 Jun 2023 04:42:38 +0000 (00:42 -0400)]
Remove deprecated v3 Contact.getquick api

2 years agoSwitch menubar quicksearch to use APIv4 autocomplete
colemanw [Tue, 27 Jun 2023 04:19:23 +0000 (00:19 -0400)]
Switch menubar quicksearch to use APIv4 autocomplete

2 years agoMerge pull request #27224 from eileenmcnaughton/arb
Seamus Lee [Thu, 31 Aug 2023 22:06:52 +0000 (18:06 -0400)]
Merge pull request #27224 from eileenmcnaughton/arb

Remove isset from Arb.xml

2 years agoMerge pull request #27230 from eileenmcnaughton/weight_m
Eileen McNaughton [Thu, 31 Aug 2023 21:57:45 +0000 (09:57 +1200)]
Merge pull request #27230 from eileenmcnaughton/weight_m

Add weights to MemberSelectorSearch

2 years agoAdd weights to MemberSelectorSearch
Eileen McNaughton [Thu, 31 Aug 2023 09:10:15 +0000 (21:10 +1200)]
Add weights to MemberSelectorSearch

2 years agoMerge pull request #27225 from eileenmcnaughton/search_form
Eileen McNaughton [Thu, 31 Aug 2023 12:15:30 +0000 (00:15 +1200)]
Merge pull request #27225 from eileenmcnaughton/search_form

Cleanup signature for test function `getFormObject`

2 years agoMerge pull request #27229 from eileenmcnaughton/weigh
Eileen McNaughton [Thu, 31 Aug 2023 11:55:52 +0000 (23:55 +1200)]
Merge pull request #27229 from eileenmcnaughton/weigh

Add weights to MessageTemplate links

2 years agoMerge pull request #27118 from yashodha/dev-4522
Eileen McNaughton [Thu, 31 Aug 2023 11:32:22 +0000 (23:32 +1200)]
Merge pull request #27118 from yashodha/dev-4522

(dev/core#4522) Membership Detail improvements - add sorting for Memb…

2 years agoCleanup signature for test function getFormObject
Eileen McNaughton [Thu, 31 Aug 2023 07:41:01 +0000 (19:41 +1200)]
Cleanup signature for test function getFormObject

I want to make form test functions available outside core (to wean some extensions off calling methods on the
forms that we no longer call from core. They were copy & paste from when we did). Also, I want to have some nicer form
functions.

I think getFormObject is OK-ish but I don't like the parameters that are there to support
search tests, so I am trying to split that out to allow signature change on the main function

2 years agoAdd weights to MessageTemplate links
Eileen McNaughton [Thu, 31 Aug 2023 05:56:23 +0000 (17:56 +1200)]
Add weights to MessageTemplate links

2 years agoMake tax_amount required, default 0
Eileen McNaughton [Wed, 30 Aug 2023 23:03:17 +0000 (11:03 +1200)]
Make tax_amount required, default 0

2 years agoRemove not-set-check in test, should always be set
Eileen McNaughton [Wed, 30 Aug 2023 22:49:28 +0000 (10:49 +1200)]
Remove not-set-check in test, should always be set

2 years agoFind where we are not setting tax_amount
Eileen McNaughton [Fri, 28 Jul 2023 02:28:05 +0000 (14:28 +1200)]
Find where we are not setting tax_amount

2 years agoMerge pull request #27227 from eileenmcnaughton/weigh
colemanw [Thu, 31 Aug 2023 10:44:32 +0000 (06:44 -0400)]
Merge pull request #27227 from eileenmcnaughton/weigh

Fix Contribution_Tab links to have weight, improve test

2 years agoPHP8 date range not rendered correctly
Pradeep Nayak [Thu, 31 Aug 2023 09:13:35 +0000 (10:13 +0100)]
PHP8 date range not rendered correctly

2 years agoMerge pull request #27217 from eileenmcnaughton/create_test
Eileen McNaughton [Thu, 31 Aug 2023 09:02:49 +0000 (21:02 +1200)]
Merge pull request #27217 from eileenmcnaughton/create_test

Switch tests to use createTestEntity for payment processor

2 years agoFix Contribution_Tab links to have weight, improve test
Eileen McNaughton [Thu, 31 Aug 2023 06:07:40 +0000 (18:07 +1200)]
Fix Contribution_Tab links to have weight, improve test

2 years agoSwitch tests to use createTestEntity for payment processor
Eileen McNaughton [Thu, 31 Aug 2023 00:55:48 +0000 (12:55 +1200)]
Switch tests to use createTestEntity for payment processor

2 years agoRemove isset from Arb.xml
Eileen McNaughton [Thu, 31 Aug 2023 06:13:49 +0000 (18:13 +1200)]
Remove isset from Arb.xml

The variable has already been checked so it must already be 'assigned enough'

2 years agoMerge pull request #27222 from civicrm/5.65
Eileen McNaughton [Thu, 31 Aug 2023 05:43:15 +0000 (17:43 +1200)]
Merge pull request #27222 from civicrm/5.65

5.65 to master

2 years agoMerge pull request #27220 from eileenmcnaughton/detail_report
Eileen McNaughton [Thu, 31 Aug 2023 05:19:35 +0000 (17:19 +1200)]
Merge pull request #27220 from eileenmcnaughton/detail_report

Fix undeclared properties in crufty old report

2 years agoMerge pull request #27221 from seamuslee001/dev_core_4538
Eileen McNaughton [Thu, 31 Aug 2023 05:17:33 +0000 (17:17 +1200)]
Merge pull request #27221 from seamuslee001/dev_core_4538

dev/core#4538 Move the setting of session status into the if check wi…

2 years agoMerge pull request #27219 from eileenmcnaughton/last_decade
Eileen McNaughton [Thu, 31 Aug 2023 05:16:42 +0000 (17:16 +1200)]
Merge pull request #27219 from eileenmcnaughton/last_decade

Remove decade-only typo

2 years agoFix undeclared properties in crufty old report
Eileen McNaughton [Thu, 31 Aug 2023 03:34:00 +0000 (15:34 +1200)]
Fix undeclared properties in crufty old report

This report doesn't really interact with anything else so I just added private properties

I also removed some deprecated function calls.

2 years agodev/core#4538 Move the setting of session status into the if check within the Partici...
Seamus Lee [Thu, 31 Aug 2023 03:43:44 +0000 (13:43 +1000)]
dev/core#4538 Move the setting of session status into the if check within the Participant payment to ensure status is not set if it is a free event

2 years agoMerge pull request #27216 from eileenmcnaughton/weight2
Seamus Lee [Thu, 31 Aug 2023 03:33:57 +0000 (23:33 -0400)]
Merge pull request #27216 from eileenmcnaughton/weight2

Add weight to a few more links

2 years agoRemove decade-only typo
Eileen McNaughton [Thu, 31 Aug 2023 03:17:24 +0000 (15:17 +1200)]
Remove decade-only typo

This is an undefined property. Nothing accesses the mis-typed version....

2 years agoMerge pull request #27214 from eileenmcnaughton/block
colemanw [Thu, 31 Aug 2023 03:14:23 +0000 (23:14 -0400)]
Merge pull request #27214 from eileenmcnaughton/block

Remove some copy & paste code

2 years agoSet weights in phpLinks
Eileen McNaughton [Thu, 31 Aug 2023 00:31:24 +0000 (12:31 +1200)]
Set weights in phpLinks

2 years agoMerge pull request #27218 from larssandergreen/remove-html2text-from-security-checks...
Eileen McNaughton [Thu, 31 Aug 2023 02:00:00 +0000 (14:00 +1200)]
Merge pull request #27218 from larssandergreen/remove-html2text-from-security-checks-as-package-is-gone

Remove Html2text security check, package deleted

2 years agoRemove Html2text security check, package deleted
larssandergreen [Thu, 31 Aug 2023 00:55:37 +0000 (18:55 -0600)]
Remove Html2text security check, package deleted

2 years agoAdd weight to batch links
Eileen McNaughton [Thu, 31 Aug 2023 00:26:07 +0000 (12:26 +1200)]
Add weight to batch links

2 years agoMerge pull request #27200 from seamuslee001/case_remove_client
Seamus Lee [Wed, 30 Aug 2023 23:42:20 +0000 (19:42 -0400)]
Merge pull request #27200 from seamuslee001/case_remove_client

Be able to remove clients from a case from the manage case view

2 years agoMerge pull request #27215 from eileenmcnaughton/block2
Eileen McNaughton [Wed, 30 Aug 2023 23:05:12 +0000 (11:05 +1200)]
Merge pull request #27215 from eileenmcnaughton/block2

Replace another badly named undeclared property

2 years ago[REF] Be able to remove clients from the case from manage case view
Seamus Lee [Fri, 28 Oct 2022 03:31:23 +0000 (14:31 +1100)]
[REF] Be able to remove clients from the case from manage case view

Modify to allow any other than the currently viewed contact to be removed from a case and create activity when it is removed

Remove restriction on link showing and convert to popup link

Only show x if there is more than 2 clients

Only Add in new activity type if CiviCase is enabled

2 years agoMerge pull request #27196 from colemanw/afformTabNames
Eileen McNaughton [Wed, 30 Aug 2023 22:47:23 +0000 (10:47 +1200)]
Merge pull request #27196 from colemanw/afformTabNames

Afform - make summary tab names less weird

2 years agoReplace another badly named undeclared property
Eileen McNaughton [Wed, 30 Aug 2023 22:15:15 +0000 (10:15 +1200)]
Replace another badly named undeclared property

2 years agoMerge pull request #27213 from eileenmcnaughton/location_1
Eileen McNaughton [Wed, 30 Aug 2023 22:13:01 +0000 (10:13 +1200)]
Merge pull request #27213 from eileenmcnaughton/location_1

Move no-longer-shared function back to it's form

2 years agoRemove some copy & past code
Eileen McNaughton [Wed, 30 Aug 2023 22:11:01 +0000 (10:11 +1200)]
Remove some copy & past code

2 years agoAdd notice
Eileen McNaughton [Wed, 30 Aug 2023 21:03:19 +0000 (09:03 +1200)]
Add notice

2 years agoCopy locationBuildForm function back to only class that calls it
Eileen McNaughton [Wed, 30 Aug 2023 20:59:57 +0000 (08:59 +1200)]
Copy locationBuildForm function back to only class that calls it

2 years agoMove no-longer-shared function back to it's form
Eileen McNaughton [Wed, 30 Aug 2023 20:51:29 +0000 (08:51 +1200)]
Move no-longer-shared function back to it's form

2 years agoMerge pull request #27212 from eileenmcnaughton/location
Eileen McNaughton [Wed, 30 Aug 2023 21:44:16 +0000 (09:44 +1200)]
Merge pull request #27212 from eileenmcnaughton/location

Fix notices, php errors on event location tab

2 years agoMerge pull request #27210 from MegaphoneJon/sort-groups
Eileen McNaughton [Wed, 30 Aug 2023 21:10:01 +0000 (09:10 +1200)]
Merge pull request #27210 from MegaphoneJon/sort-groups

fix sort groups on PHP8

2 years agoStop calling -do-nothing pre-process
Eileen McNaughton [Wed, 30 Aug 2023 20:44:00 +0000 (08:44 +1200)]
Stop calling -do-nothing pre-process

2 years agoRemove unused constant
Eileen McNaughton [Wed, 30 Aug 2023 20:36:21 +0000 (08:36 +1200)]
Remove unused constant

2 years agofix sort groups on PHP8
Jon Goldberg [Wed, 30 Aug 2023 18:57:39 +0000 (14:57 -0400)]
fix sort groups on PHP8

2 years agoMerge pull request #27209 from colemanw/greetingNotices
Eileen McNaughton [Wed, 30 Aug 2023 19:09:36 +0000 (07:09 +1200)]
Merge pull request #27209 from colemanw/greetingNotices

ContactSummary - Fix smarty notices in communication preferences section

2 years agoMerge pull request #27208 from eileenmcnaughton/stop_testing_the_test
colemanw [Wed, 30 Aug 2023 18:32:23 +0000 (14:32 -0400)]
Merge pull request #27208 from eileenmcnaughton/stop_testing_the_test

Remove old tests that only test test functions

2 years agoContactSummary - Fix smarty notices in communication preferences section
colemanw [Wed, 30 Aug 2023 16:09:13 +0000 (12:09 -0400)]
ContactSummary - Fix smarty notices in communication preferences section

2 years agoMerge pull request #27194 from larssandergreen/SMS-error-message
Mathieu Lu [Wed, 30 Aug 2023 14:52:23 +0000 (10:52 -0400)]
Merge pull request #27194 from larssandergreen/SMS-error-message

Update SMS cannot send message to specify that a mobile phone number is required

2 years agoAfform - Fix setting tab contact type
colemanw [Wed, 30 Aug 2023 13:54:19 +0000 (09:54 -0400)]
Afform - Fix setting tab contact type

2 years agoAfform - make summary tab names less weird
colemanw [Tue, 29 Aug 2023 15:46:28 +0000 (11:46 -0400)]
Afform - make summary tab names less weird

2 years agoMerge pull request #27205 from eileenmcnaughton/test_easy
demeritcowboy [Wed, 30 Aug 2023 12:48:30 +0000 (08:48 -0400)]
Merge pull request #27205 from eileenmcnaughton/test_easy

Simplify test

2 years agoMerge pull request #27207 from eileenmcnaughton/multi
Eileen McNaughton [Wed, 30 Aug 2023 05:34:47 +0000 (17:34 +1200)]
Merge pull request #27207 from eileenmcnaughton/multi

Move smarty assign to be always assigned (notices)

2 years agoRemove old tests that only test test functions
Eileen McNaughton [Wed, 30 Aug 2023 04:55:39 +0000 (16:55 +1200)]
Remove old tests that only test test functions

These tests are calling the test functions to create & delete contacts- but these are not 'real'
functions - ideally we wouldn't even call them in tests. We have lots of cover for the
actual functions - so just removing

2 years agoMerge pull request #27206 from eileenmcnaughton/delete_test
Seamus Lee [Wed, 30 Aug 2023 04:45:27 +0000 (00:45 -0400)]
Merge pull request #27206 from eileenmcnaughton/delete_test

Remove never called testCleanUp function

2 years agoMove smarty assign to be always assigned (notices)
Eileen McNaughton [Wed, 30 Aug 2023 04:40:38 +0000 (16:40 +1200)]
Move smarty assign to be always assigned (notices)

2 years agoRemove never called testCleanUp function
Eileen McNaughton [Wed, 30 Aug 2023 03:28:46 +0000 (15:28 +1200)]
Remove never called testCleanUp function

deleteTestObjects is not called, except by itself, which is not called. Without
that function there is no need to 'register' the test entities either...

2 years agoSimplify test
Eileen McNaughton [Wed, 30 Aug 2023 02:01:24 +0000 (14:01 +1200)]
Simplify test

2 years agoMerge pull request #27138 from artfulrobot/artfulrobot-improve-initialization-crash...
Tim Otten [Tue, 29 Aug 2023 23:17:24 +0000 (16:17 -0700)]
Merge pull request #27138 from artfulrobot/artfulrobot-improve-initialization-crash-message

Improve initialization crash message

2 years agoMerge pull request #27198 from larssandergreen/Fix-membership-renewal-leap-year-bug
Eileen McNaughton [Tue, 29 Aug 2023 18:59:29 +0000 (06:59 +1200)]
Merge pull request #27198 from larssandergreen/Fix-membership-renewal-leap-year-bug

dev/core#4541 Fix membership leap year bug that causes test failure