Eileen McNaughton [Fri, 18 Mar 2022 00:34:21 +0000 (13:34 +1300)]
[REF] Deprecate BAO_Contact::retrieve
This removes 2 calls to BAO_Contact::retrieve and marks it as deprecated.
It is a surprisingly complex function and all the calls to it only use parts of what it
does - in general just having the code 'do the thing' is better.
In this case it turns out there is no need for the contact objects. There is
also some pretty funky handling for the location keys in the next section
so making it clearer what is in them should make it possible to simplify that....
colemanw [Thu, 17 Mar 2022 21:52:51 +0000 (17:52 -0400)]
Merge pull request #22960 from totten/master-out-of-curiosity
What if we stopped publishing Drupal 6 releases in 2022?
Eileen McNaughton [Thu, 17 Mar 2022 21:04:19 +0000 (10:04 +1300)]
Merge pull request #22887 from colemanw/afformLayout
Afform - compose layouts with multiple SearchKit displays
demeritcowboy [Thu, 17 Mar 2022 18:18:13 +0000 (14:18 -0400)]
Merge pull request #22962 from tschuettler/patch-12
[NFC] - Compatibility for PHP-7.4/PHP-8
tschuettler [Thu, 17 Mar 2022 16:14:41 +0000 (17:14 +0100)]
[NFC] - Compatibility for PHP-7.4/PHP-8
There are a few more leftovers under vendor and packages: `find . -name "*.php" -exec php -l {} \; | grep -v "No"`. Not sure how to deal with that.
demeritcowboy [Thu, 17 Mar 2022 13:51:20 +0000 (09:51 -0400)]
Merge pull request #22928 from artfulrobot/artfulrobot-title-double-html-encoding
Fix double encoding of document title on Contact view form
Seamus Lee [Thu, 17 Mar 2022 09:54:37 +0000 (20:54 +1100)]
Merge pull request #22961 from civicrm/5.48
5.48
Seamus Lee [Thu, 17 Mar 2022 09:53:17 +0000 (20:53 +1100)]
Fix issues picked up by stylechecker
Tim Otten [Thu, 17 Mar 2022 05:36:29 +0000 (22:36 -0700)]
What if we stopped publishing Drupal 6 releases in 2022?
demeritcowboy [Thu, 17 Mar 2022 00:45:46 +0000 (20:45 -0400)]
Merge pull request #22956 from eileenmcnaughton/notice4
Notice fixes in advanced search
Seamus Lee [Tue, 1 Mar 2022 03:32:28 +0000 (14:32 +1100)]
security/core#112 Fix viewing contributions when user doesn't have acess to civicontribute or edit contributions permissions
Seamus Lee [Thu, 3 Mar 2022 06:23:19 +0000 (17:23 +1100)]
security/core#113 Apply patch from Mathieu to fix SQLI in participant import
Seamus Lee [Wed, 16 Mar 2022 19:58:23 +0000 (06:58 +1100)]
Upgrade CKEditor to 4.18
Tim Otten [Wed, 16 Mar 2022 09:27:19 +0000 (02:27 -0700)]
(security/core#111) Refine prose/naming
Seamus Lee [Wed, 16 Mar 2022 08:33:54 +0000 (01:33 -0700)]
security/core#111 Add in Status check for if Anonymous Users have edit contributions and or access CiviContribute Permissions
CiviCRM [Wed, 16 Mar 2022 08:30:48 +0000 (01:30 -0700)]
CRM_Core_Permission - Allow checking of anon-perms by authenticated-users
Each CRM_Core_Permission_* adapter allows you to check the permissions on
behalf of some other user. However, if that "other user" is "anonymous",
then they are prone to mishandling.
Tim Otten [Wed, 16 Mar 2022 03:37:33 +0000 (20:37 -0700)]
E2E Tests - Add coverage for variations on `Permission::check($perm,$cid)`
Tim Otten [Wed, 16 Mar 2022 05:33:29 +0000 (22:33 -0700)]
composer.json - Update jquery UI 1.13.0 => 1.13.1
Eileen McNaughton [Wed, 16 Mar 2022 21:59:56 +0000 (10:59 +1300)]
Notice fixes in advanced search
demeritcowboy [Wed, 16 Mar 2022 16:01:39 +0000 (12:01 -0400)]
Merge pull request #22953 from civicrm/5.48
5.48
Monish Deb [Wed, 16 Mar 2022 06:11:25 +0000 (11:41 +0530)]
Merge pull request #22950 from colemanw/refBoolColumns
REF - Split upgrade SQL into multiple tasks
Eileen McNaughton [Wed, 16 Mar 2022 01:54:44 +0000 (14:54 +1300)]
Merge pull request #22952 from totten/master-install-sk
Search Kit - Auto-enable during normal installation
Tim Otten [Tue, 15 Mar 2022 22:04:40 +0000 (15:04 -0700)]
(NFC) DefaultExtensions.civi-setup.php - Cleanup boilerplate
Seamus Lee [Tue, 15 Mar 2022 21:24:48 +0000 (08:24 +1100)]
Merge pull request #22948 from pradpnayak/fixfatalerror3
Return array for setdefaults
Tim Otten [Tue, 15 Mar 2022 20:44:36 +0000 (13:44 -0700)]
Search Kit - Auto-enable during normal installation
Coleman Watts [Thu, 10 Mar 2022 01:41:33 +0000 (20:41 -0500)]
Afform Gui - Use af-gui-menu for efficiency
Coleman Watts [Fri, 4 Mar 2022 20:39:08 +0000 (15:39 -0500)]
Afform - Enable multiple search displays in a search form layout
Allows dashboard-like layouts to be composed
Coleman Watts [Fri, 4 Mar 2022 03:39:19 +0000 (22:39 -0500)]
Afform - Refactor toward multiple search displays on an afform
Coleman Watts [Tue, 15 Mar 2022 17:20:36 +0000 (13:20 -0400)]
REF - Split upgrade SQL into multiple tasks
Splits up potentially long-running upgrade SQL which alters table columns to be NOT NULL.
Eileen McNaughton [Tue, 15 Mar 2022 19:15:23 +0000 (08:15 +1300)]
Merge pull request #21473 from mattwire/contributionrecurtplupdate
dev/financial#6 Update the recurring contribution when we edit the template contribution
Monish Deb [Tue, 15 Mar 2022 14:04:56 +0000 (19:34 +0530)]
Merge pull request #22825 from MegaphoneJon/membership-41
get membership type ID and number of terms from price_x fields
Pradeep Nayak [Tue, 15 Mar 2022 11:08:51 +0000 (11:08 +0000)]
Return array for setdefaults
Monish Deb [Tue, 15 Mar 2022 05:11:51 +0000 (10:41 +0530)]
Merge pull request #22925 from colemanw/booleanFields
Schema - Fix boolean fields in civicrm_event and civicrm_contribution
Eileen McNaughton [Mon, 14 Mar 2022 22:28:50 +0000 (11:28 +1300)]
Merge pull request #21470 from mattwire/templatecontributioncreate
dev/financial#6 Fix creating of template contribution when it has custom data
demeritcowboy [Mon, 14 Mar 2022 22:13:23 +0000 (18:13 -0400)]
Merge pull request #22945 from civicrm/5.48
5.48
Eileen McNaughton [Mon, 14 Mar 2022 21:28:46 +0000 (10:28 +1300)]
Merge pull request #22906 from colemanw/searchKitCheckBoxes
SearchKit - Improve checkbox UX for bulk actions
demeritcowboy [Mon, 14 Mar 2022 18:12:06 +0000 (14:12 -0400)]
Merge pull request #22944 from colemanw/SoftDeleteActionTrait
[REF] Rename SoftDeleteEntity -> SoftDeleteActionTrait
Coleman Watts [Mon, 14 Mar 2022 15:18:25 +0000 (11:18 -0400)]
Rename SoftDeleteEntity -> SoftDeleteActionTrait
The trait is used by actions, not by entities.
colemanw [Mon, 14 Mar 2022 12:16:51 +0000 (08:16 -0400)]
Merge pull request #22804 from braders/core-2198-dedupe-rules-ui
Core#2918 Implement new UI for configuring dedupe rule usage.
colemanw [Mon, 14 Mar 2022 12:11:26 +0000 (08:11 -0400)]
Merge pull request #22832 from jmcclelland/ufexport
Enable APIv4 export action on UFGroup and UFField.
colemanw [Mon, 14 Mar 2022 12:04:26 +0000 (08:04 -0400)]
Merge pull request #22943 from ixiam/dev#contactquery_sg
Optimise isCustomDateField
Vangelis Pantazis [Mon, 14 Mar 2022 09:16:38 +0000 (09:16 +0000)]
Optimise isCustomDateField
colemanw [Sun, 13 Mar 2022 20:46:11 +0000 (16:46 -0400)]
Merge pull request #22934 from adriano66/dev/core#2524
Dev/core#2524 Fix seriazliation parameter exception in APIv3
adriano66 [Thu, 16 Dec 2021 22:03:16 +0000 (23:03 +0100)]
dev/core#2524 - Fix missing serialization defaults
This fixes the "'0' is not a valid option for field serialize" exception
in APIv3 as 0 is a valid, default value set in the DB
This allows passing whole custom field data as a parameter
to the custom field update method without getting an exception
Co-authored-by: colemanw <coleman@civicrm.org>
demeritcowboy [Sun, 13 Mar 2022 18:45:30 +0000 (14:45 -0400)]
Merge pull request #22939 from demeritcowboy/log-sql
During upgrade log that it ran the sql when there is just a sql file and no corresponding task
demeritcowboy [Sun, 13 Mar 2022 18:45:17 +0000 (14:45 -0400)]
Merge pull request #22935 from civicrm/5.48
5.48
demeritcowboy [Sun, 13 Mar 2022 17:04:51 +0000 (13:04 -0400)]
Merge pull request #22933 from colemanw/fixQueryHook
Fix backward-compatability for new method in CRM_Contact_BAO_Query_Hook
demeritcowboy [Sun, 13 Mar 2022 16:09:35 +0000 (12:09 -0400)]
log that it ran the sql there is just a sql file and no corresponding task
colemanw [Sun, 13 Mar 2022 15:41:04 +0000 (11:41 -0400)]
Merge pull request #22932 from eileenmcnaughton/upit
dev/core#3112 Clear caches to avoid error on upgrade
Coleman Watts [Sun, 13 Mar 2022 06:26:10 +0000 (01:26 -0500)]
Fix backward-compatability for new method in CRM_Contact_BAO_Query_Hook
The method getDefaultReturnProperties was just added to CRM_Contact_BAO_Query_Hook,
but some extensions do not yet implement it, and also do not extend that class so
cannot inherit the default method.
This adds a guard around calling the new method to avoid crashes.
demeritcowboy [Sun, 13 Mar 2022 13:55:05 +0000 (09:55 -0400)]
Merge pull request #22929 from colemanw/afformELementFix
Afform Gui - Fix selecting html element of text box
Eileen McNaughton [Sun, 13 Mar 2022 05:10:43 +0000 (18:10 +1300)]
dev/core#3112 Clear caches to avoid error on upgrade
There may be a better place for this - but at least here is is clear to the api call that
can fail without it .... if the metadata cache is populated from an earlier version the
table_name key may not exist & hence the api call fails with no table_name
in the from clause
Coleman Watts [Thu, 10 Mar 2022 01:42:09 +0000 (20:42 -0500)]
Afform Gui - Fix selecting html element of text box
Jon Goldberg [Wed, 23 Feb 2022 22:04:50 +0000 (17:04 -0500)]
get membership type ID and number of terms from price_x fields
Rich Lott / Artful Robot [Fri, 11 Mar 2022 09:30:40 +0000 (09:30 +0000)]
Fix double encoding of document title on Contact view form
Eileen McNaughton [Thu, 10 Mar 2022 22:58:33 +0000 (11:58 +1300)]
Merge pull request #22927 from colemanw/pagerSize
SearchKit - Fix page size size
Coleman Watts [Thu, 10 Mar 2022 21:23:01 +0000 (16:23 -0500)]
SearchKit - Fix page size size
Coleman Watts [Thu, 10 Mar 2022 16:26:47 +0000 (11:26 -0500)]
Schema - Fix boolean fields in civicrm_event and civicrm_contribution tables
This fixes 2 tables to ensure boolean fields always have a default value and are always NOT NULL.
colemanw [Thu, 10 Mar 2022 13:17:51 +0000 (08:17 -0500)]
Merge pull request #22808 from colemanw/searchKitMailingTask
SearchKit - Add CiviMail integration
demeritcowboy [Thu, 10 Mar 2022 04:31:14 +0000 (23:31 -0500)]
Merge pull request #22923 from civicrm/5.48
5.48
Eileen McNaughton [Thu, 10 Mar 2022 01:59:33 +0000 (14:59 +1300)]
Merge pull request #22921 from totten/5.48-yml
(NFC) contributor-key.yml - Fix syntax error
Tim Otten [Wed, 9 Mar 2022 23:26:50 +0000 (15:26 -0800)]
contributor-key.yml - Fix syntax error
Matthew Wire [Wed, 9 Mar 2022 22:01:09 +0000 (22:01 +0000)]
Merge pull request #21467 from sunilpawar/dev_2833
dev/core#2833 Fix Contact Type change on Backend Membership Credit Ca…
Matthew Wire [Wed, 9 Mar 2022 21:58:48 +0000 (21:58 +0000)]
Merge pull request #21945 from masetto/profile-data-attribute
Add page id and template type as data attributes in contribution templates
Matthew Wire [Wed, 9 Mar 2022 21:56:17 +0000 (21:56 +0000)]
Merge pull request #22483 from eileenmcnaughton/token1
Fully deprecate `getTokenDetails`
Matthew Wire [Wed, 9 Mar 2022 21:55:35 +0000 (21:55 +0000)]
Merge pull request #22463 from eileenmcnaughton/label
Split mailing label formatting out from main format
Matthew Wire [Wed, 9 Mar 2022 21:54:39 +0000 (21:54 +0000)]
Merge pull request #22316 from braders/core-3003-preserve-tab-between-pageloads
Preserve selected tab when navigating between pages.
Matthew Wire [Wed, 9 Mar 2022 21:53:44 +0000 (21:53 +0000)]
Merge pull request #22291 from eileenmcnaughton/amount_block
[REF] Extract & stdise AmountBlockIsActive
Matthew Wire [Wed, 9 Mar 2022 21:51:50 +0000 (21:51 +0000)]
Merge pull request #22255 from MegaphoneJon/membership-14-2021
Calculate lifetime memberships more accurately
Matthew Wire [Wed, 9 Mar 2022 21:47:36 +0000 (21:47 +0000)]
Merge pull request #22886 from demeritcowboy/contributionview-notice3
Simplify fix for smarty/php notice on contributionview
Matthew Wire [Wed, 9 Mar 2022 21:46:28 +0000 (21:46 +0000)]
Merge pull request #22802 from braders/feature/eventinfo-currency
Remove use of overrideDefaultCurrency method from eventInfo page.
Matthew Wire [Wed, 9 Mar 2022 21:44:49 +0000 (21:44 +0000)]
Merge pull request #22920 from civicrm/5.48
5.48
Matthew Wire [Wed, 9 Mar 2022 21:44:01 +0000 (21:44 +0000)]
Merge pull request #22898 from MegaphoneJon/timezone-check-condition
Don't perform event timezone check if CiviEvent is disabled
Tim Otten [Wed, 9 Mar 2022 21:38:44 +0000 (13:38 -0800)]
Merge pull request #22917 from demeritcowboy/reregen
regenerate civicrm_generated
Matthew Wire [Wed, 9 Mar 2022 21:38:35 +0000 (21:38 +0000)]
Merge pull request #22680 from mattwire/paymentstatushelpers
Add paymentstatus helpers for doPayment and separate return params
Jon Goldberg [Mon, 7 Mar 2022 15:39:07 +0000 (10:39 -0500)]
Don't perform event timezone check if CiviEvent is disabled
demeritcowboy [Wed, 9 Mar 2022 20:09:59 +0000 (15:09 -0500)]
Merge pull request #22916 from spalmstr/Issue_3085
dev/core#3085 - Checkbox fields on profile admin page can't be unchecked
Coleman Watts [Tue, 8 Mar 2022 19:38:07 +0000 (14:38 -0500)]
Remove unnecessary shared variable
Coleman Watts [Mon, 7 Mar 2022 19:30:51 +0000 (14:30 -0500)]
SearchKit - Add menu for selecting all/page/none
Coleman Watts [Mon, 7 Mar 2022 07:31:20 +0000 (02:31 -0500)]
SearchKit - Allow searching by range
demeritcowboy [Wed, 9 Mar 2022 18:56:28 +0000 (18:56 +0000)]
regenerate civicrm_generated
demeritcowboy [Wed, 9 Mar 2022 18:52:35 +0000 (13:52 -0500)]
Merge pull request #22914 from civicrm/5.48
5.48
colemanw [Wed, 9 Mar 2022 18:42:52 +0000 (13:42 -0500)]
Merge pull request #22882 from mattwire/api4saveempty
Allow API4 match to match an empty value
Stephen Palmstrom [Wed, 9 Mar 2022 18:07:18 +0000 (18:07 +0000)]
Issue 3085
colemanw [Wed, 9 Mar 2022 16:28:49 +0000 (11:28 -0500)]
Merge pull request #22913 from colemanw/civiGrantTypes2
CiviGrant - Don't auto-create any grant types
Matthew Wire [Tue, 8 Mar 2022 19:18:11 +0000 (19:18 +0000)]
Add test for matching on empty string with API4 save
Coleman Watts [Tue, 8 Mar 2022 13:51:41 +0000 (08:51 -0500)]
CiviGrant - Don't auto-create any grant types
colemanw [Wed, 9 Mar 2022 13:41:06 +0000 (08:41 -0500)]
Merge pull request #22911 from colemanw/grant-reports2
dev/core#3100 - Remove grant leftovers from core xml. Remove empty grant reports menu
demeritcowboy [Wed, 9 Mar 2022 13:40:22 +0000 (08:40 -0500)]
Merge pull request #22830 from kurund/entityRef-enhancements
dev/core#3082 enhance EntityRef to show create new link when contact listing is fil…
Yashodha Chaku [Wed, 9 Mar 2022 03:37:00 +0000 (09:07 +0530)]
Merge pull request #22912 from eileenmcnaughton/group
Add action links for group.
Eileen McNaughton [Wed, 9 Mar 2022 01:39:06 +0000 (14:39 +1300)]
Add links for group
Note the view goes to view group members - I didn't see anything more appropriate
Coleman Watts [Wed, 9 Mar 2022 01:36:42 +0000 (20:36 -0500)]
Regenerate sql
demeritcowboy [Sat, 5 Mar 2022 23:38:35 +0000 (18:38 -0500)]
empty grant reports menu
Coleman Watts [Tue, 8 Mar 2022 22:37:39 +0000 (17:37 -0500)]
Remove unused grant reports from upgrader
demeritcowboy [Wed, 9 Mar 2022 00:13:53 +0000 (19:13 -0500)]
Merge pull request #22910 from civicrm/5.48
5.48
Tim Otten [Tue, 8 Mar 2022 22:39:33 +0000 (14:39 -0800)]
Merge pull request #22909 from eileenmcnaughton/relview
Add created & modified dates to "View Relationship" screen
Tim Otten [Tue, 8 Mar 2022 22:38:02 +0000 (14:38 -0800)]
Merge pull request #22908 from MegaphoneJon/core-3106
(dev/core#3106) Raise max# of editable websites (5 => 25)
Seamus Lee [Tue, 8 Mar 2022 21:59:22 +0000 (08:59 +1100)]
Merge pull request #22870 from eileenmcnaughton/line
Only acl line items based on contribution
Seamus Lee [Tue, 8 Mar 2022 21:59:07 +0000 (08:59 +1100)]
Merge pull request #22907 from eileenmcnaughton/rel
[NFC] Superficial cleanup
Eileen McNaughton [Tue, 8 Mar 2022 20:45:03 +0000 (09:45 +1300)]
Add created & modified dates to relationhsip view