civicrm-core.git
3 years agoAbility to change pdf filename before downloading
Debarshi Bhaumik [Wed, 4 Aug 2021 05:59:59 +0000 (06:59 +0100)]
Ability to change pdf filename before downloading

3 years agoMerge pull request #21004 from seamuslee001/teardownftsquery
Seamus Lee [Wed, 4 Aug 2021 03:23:20 +0000 (13:23 +1000)]
Merge pull request #21004 from seamuslee001/teardownftsquery

[NFC] Do a proper tear down of fts in QueryFormatterTest

3 years ago[NFC] Do a proper tear down of fts in QueryFormatterTest
Seamus Lee [Wed, 4 Aug 2021 01:05:13 +0000 (11:05 +1000)]
[NFC] Do a proper tear down of fts in QueryFormatterTest

3 years ago[NFC] Do a proper tear down of fts in QueryFormatterTest
Seamus Lee [Wed, 4 Aug 2021 00:58:48 +0000 (10:58 +1000)]
[NFC] Do a proper tear down of fts in QueryFormatterTest

3 years agoMerge pull request #21002 from demeritcowboy/smarty-managecase
Seamus Lee [Tue, 3 Aug 2021 04:39:45 +0000 (14:39 +1000)]
Merge pull request #21002 from demeritcowboy/smarty-managecase

Smarty warnings on Manage Case

3 years agosmarty warnings
demeritcowboy [Tue, 3 Aug 2021 02:51:04 +0000 (22:51 -0400)]
smarty warnings

3 years agoMerge pull request #20998 from eileenmcnaughton/id
Seamus Lee [Mon, 2 Aug 2021 22:56:42 +0000 (08:56 +1000)]
Merge pull request #20998 from eileenmcnaughton/id

Rename legacy token for contribution id to match sched reminder tokens

3 years agoRename legacy token for contribution id to match sched reminder tokens
Eileen McNaughton [Mon, 2 Aug 2021 20:54:49 +0000 (08:54 +1200)]
Rename legacy token for contribution id to match sched reminder tokens

In this case it turns out

1) the token being advertised by scheduled reminders is more correct ('id')
2) the legacy method resolves either 'id' or 'contribution_id' and
3) changing the advertised token from 'contribution.contribution_id' to contribution.id
does not cause contribution_id to stop working

So in summary - the advertised token was working in 'send letter' but not
in scheduled reminders. And changing which is advertised doesn't stop
the other from working in send letter

3 years agoMerge pull request #20994 from demeritcowboy/upgrade-message-2
Eileen McNaughton [Mon, 2 Aug 2021 19:25:43 +0000 (07:25 +1200)]
Merge pull request #20994 from demeritcowboy/upgrade-message-2

Fix upgrade message when nothing was changed

3 years agofix empty message
demeritcowboy [Mon, 2 Aug 2021 16:02:38 +0000 (12:02 -0400)]
fix empty message

3 years agoMerge pull request #20993 from kainuk/vcard_notice
demeritcowboy [Mon, 2 Aug 2021 15:28:13 +0000 (11:28 -0400)]
Merge pull request #20993 from kainuk/vcard_notice

Do not generate a notice when a vcard is downloaded with a non-primary email or non-primary phone number

3 years agoMerge pull request #20958 from mlutfy/myCaseLabels
demeritcowboy [Mon, 2 Aug 2021 14:57:52 +0000 (10:57 -0400)]
Merge pull request #20958 from mlutfy/myCaseLabels

Case Dashboard: fix labels on my/all radio buttons, and simplify label text

3 years agoDo not generate a notice when a vcard is downloaded
Klaas Eikelboom [Mon, 2 Aug 2021 13:18:56 +0000 (15:18 +0200)]
Do not generate a notice when a vcard is downloaded

3 years agoMerge pull request #20921 from eileenmcnaughton/cleanup3
Eileen McNaughton [Mon, 2 Aug 2021 08:45:05 +0000 (20:45 +1200)]
Merge pull request #20921 from eileenmcnaughton/cleanup3

Fix for failure (fatal error and silent failure) to clean up full text indices

3 years agoMerge pull request #20978 from eileenmcnaughton/act_up
Eileen McNaughton [Mon, 2 Aug 2021 07:15:37 +0000 (19:15 +1200)]
Merge pull request #20978 from eileenmcnaughton/act_up

Add upgrade routine to remove old action schedule token

3 years agoFix for failure to cleanup full text indices
Eileen McNaughton [Wed, 21 Jul 2021 07:28:14 +0000 (19:28 +1200)]
Fix for failure to cleanup full text indices

3 years agoAdd upgrade routine to remove old action schedule token
Eileen McNaughton [Fri, 30 Jul 2021 08:22:34 +0000 (20:22 +1200)]
Add upgrade routine to remove old action schedule token

This adds a routing to swap out the action schedule tokens on upgrade.

Given the token is completely invisible in the UI it's unlikely it is in use anywhere but
rather than just remove it from Contribute_Tokens this adds the upgrade
routine to remove this token, and others

3 years agoMerge pull request #20947 from colemanw/sqlFunctions
Eileen McNaughton [Mon, 2 Aug 2021 00:46:46 +0000 (12:46 +1200)]
Merge pull request #20947 from colemanw/sqlFunctions

dev/core#2704 SearchKit - Add support for SQL functions

3 years agoMerge pull request #20986 from demeritcowboy/upgrade-message-formatting
Eileen McNaughton [Sun, 1 Aug 2021 21:44:06 +0000 (09:44 +1200)]
Merge pull request #20986 from demeritcowboy/upgrade-message-formatting

Upgrade message is scrunched up next to the previous sentence

3 years agoMerge pull request #20988 from colemanw/fixCaseExport
Matthew Wire [Sun, 1 Aug 2021 11:44:59 +0000 (12:44 +0100)]
Merge pull request #20988 from colemanw/fixCaseExport

Move/rename case export files for consistency

3 years agoMove/rename case export files for consistency
Coleman Watts [Sun, 1 Aug 2021 05:21:25 +0000 (01:21 -0400)]
Move/rename case export files for consistency

3 years agoMerge pull request #20944 from eileenmcnaughton/tiles
Matthew Wire [Sat, 31 Jul 2021 17:20:57 +0000 (18:20 +0100)]
Merge pull request #20944 from eileenmcnaughton/tiles

Test, enotice fixes, handling for permissions key for Member_Tasks

3 years agoMerge pull request #20909 from eileenmcnaughton/index
Matthew Wire [Sat, 31 Jul 2021 17:15:22 +0000 (18:15 +0100)]
Merge pull request #20909 from eileenmcnaughton/index

Improve cleanup on indexer test

3 years agoMerge pull request #20969 from eileenmcnaughton/mem
Matthew Wire [Sat, 31 Jul 2021 17:14:14 +0000 (18:14 +0100)]
Merge pull request #20969 from eileenmcnaughton/mem

[REF] minor fix - move last of processing before receipting

3 years agoMerge pull request #20971 from eileenmcnaughton/inv2
Matthew Wire [Sat, 31 Jul 2021 17:13:36 +0000 (18:13 +0100)]
Merge pull request #20971 from eileenmcnaughton/inv2

dev/core#2719 [REF] Remove legacy reference to contribution_invoice_settings

3 years agoMerge pull request #20977 from eileenmcnaughton/status_name
Matthew Wire [Sat, 31 Jul 2021 17:13:03 +0000 (18:13 +0100)]
Merge pull request #20977 from eileenmcnaughton/status_name

Update label on payment instrument

3 years agoMerge pull request #20979 from mlutfy/memberTaxes
Matthew Wire [Sat, 31 Jul 2021 17:12:39 +0000 (18:12 +0100)]
Merge pull request #20979 from mlutfy/memberTaxes

New membership: fix tax amount translation

3 years agoMerge pull request #20951 from eileenmcnaughton/act
Matthew Wire [Sat, 31 Jul 2021 17:10:00 +0000 (18:10 +0100)]
Merge pull request #20951 from eileenmcnaughton/act

Activity tasks - don't add invalid tasks

3 years agomessage is scrunched up next to the previous sentence
demeritcowboy [Sat, 31 Jul 2021 16:21:03 +0000 (12:21 -0400)]
message is scrunched up next to the previous sentence

3 years agoHide REPLACE sql function from SearchKit
Coleman Watts [Sat, 31 Jul 2021 02:00:45 +0000 (22:00 -0400)]
Hide REPLACE sql function from SearchKit

Either way this describes the 3 params, but the new way is better understood by SearchKit,
which to-date cannot handle more than one param.

3 years agoMerge pull request #20872 from eileenmcnaughton/fprocessor
colemanw [Sat, 31 Jul 2021 01:06:00 +0000 (21:06 -0400)]
Merge pull request #20872 from eileenmcnaughton/fprocessor

dev/core#2715 [REF] Start the process of moving financial processing to own class

3 years agoMerge pull request #20905 from eileenmcnaughton/utf8
demeritcowboy [Sat, 31 Jul 2021 00:37:17 +0000 (20:37 -0400)]
Merge pull request #20905 from eileenmcnaughton/utf8

Fix databaseSupportsUTF8MB4

3 years agoMerge pull request #20980 from demeritcowboy/upgrade-enotice
Eileen McNaughton [Fri, 30 Jul 2021 22:50:14 +0000 (10:50 +1200)]
Merge pull request #20980 from demeritcowboy/upgrade-enotice

PHP E_NOTICE during upgrade

3 years agophp notice
demeritcowboy [Fri, 30 Jul 2021 17:04:40 +0000 (13:04 -0400)]
php notice

3 years agoMerge pull request #20096 from larssandergreen/copy-template_type-when-cloning-mailing
demeritcowboy [Fri, 30 Jul 2021 15:52:30 +0000 (11:52 -0400)]
Merge pull request #20096 from larssandergreen/copy-template_type-when-cloning-mailing

Make final mailing from A/B test same template type and options as A/B so it can be copied

3 years agoNew membership: fix tax amount translation
Mathieu Lutfy [Fri, 30 Jul 2021 14:41:30 +0000 (10:41 -0400)]
New membership: fix tax amount translation

3 years agoMerge pull request #20952 from eileenmcnaughton/cs
demeritcowboy [Fri, 30 Jul 2021 14:38:03 +0000 (10:38 -0400)]
Merge pull request #20952 from eileenmcnaughton/cs

dev/core#2721 Move custom search framework to a core extension

3 years agoMerge pull request #20974 from erawat/core#2762
demeritcowboy [Fri, 30 Jul 2021 14:35:47 +0000 (10:35 -0400)]
Merge pull request #20974 from erawat/core#2762

dev/core#2726 - Set ssl option when using DSN with SSL

3 years agoUpdate label on payment instrument
Eileen McNaughton [Fri, 30 Jul 2021 07:54:15 +0000 (19:54 +1200)]
Update label on payment instrument

3 years agodev/core#2721 Move custom search framework to a core extension
Eileen McNaughton [Mon, 26 Jul 2021 00:29:07 +0000 (12:29 +1200)]
dev/core#2721 Move custom search framework to a core extension

Put back the handling for custom in StateMachine_Search

Update civicrm_generated.mysql

Move the rest of the menu over

3 years agoMerge pull request #20961 from eileenmcnaughton/status_name
Tim Otten [Fri, 30 Jul 2021 05:19:11 +0000 (22:19 -0700)]
Merge pull request #20961 from eileenmcnaughton/status_name

dev/core#2650 Add support for names & labels for token pseudoconstants

3 years agoSearchKit - Use dataType from functions as well as fields
Coleman Watts [Thu, 29 Jul 2021 04:25:06 +0000 (00:25 -0400)]
SearchKit - Use dataType from functions as well as fields

3 years agoMerge pull request #20973 from demeritcowboy/test-20858
Seamus Lee [Thu, 29 Jul 2021 21:56:56 +0000 (07:56 +1000)]
Merge pull request #20973 from demeritcowboy/test-20858

Unit test for invalidateChecksum hook

3 years agodev/core#2726 - Set ssl option when using DSN with SSL
Erawat Chamanont [Thu, 29 Jul 2021 20:25:40 +0000 (21:25 +0100)]
dev/core#2726 - Set ssl option when using DSN with SSL

3 years agoMerge pull request #20858 from mattwire/checksumhook
demeritcowboy [Thu, 29 Jul 2021 16:12:10 +0000 (12:12 -0400)]
Merge pull request #20858 from mattwire/checksumhook

Add hook for validating checksum

3 years agotest for invalidateChecksum hook
demeritcowboy [Thu, 29 Jul 2021 16:11:20 +0000 (12:11 -0400)]
test for invalidateChecksum hook

3 years agoAdd hook for invalidating checksum
Matthew Wire [Thu, 15 Jul 2021 11:26:50 +0000 (12:26 +0100)]
Add hook for invalidating checksum

3 years agodev/core#2719 [REF] Remove legacy reference to contribution_invoice_settings
Eileen McNaughton [Thu, 29 Jul 2021 09:41:55 +0000 (21:41 +1200)]
dev/core#2719 [REF] Remove legacy reference to contribution_invoice_settings

3 years agoSearchKit - support additional functions
Coleman Watts [Sun, 25 Jul 2021 06:23:57 +0000 (02:23 -0400)]
SearchKit - support additional functions

3 years agoSearchKit - add support for non-aggregate functions
Coleman Watts [Sun, 25 Jul 2021 00:22:06 +0000 (20:22 -0400)]
SearchKit - add support for non-aggregate functions

3 years agoMerge pull request #20862 from eileenmcnaughton/leg_setting
Mathieu Lu [Thu, 29 Jul 2021 00:23:04 +0000 (20:23 -0400)]
Merge pull request #20862 from eileenmcnaughton/leg_setting

dev/core#2719 [REF] Remove some legacy references to contribution_invoice_settings

3 years agoMerge pull request #20967 from colemanw/nf
demeritcowboy [Wed, 28 Jul 2021 23:02:56 +0000 (19:02 -0400)]
Merge pull request #20967 from colemanw/nf

NFC - Reformat JSON file whitespace in Afform mock ext

3 years agoMerge pull request #20968 from colemanw/fixDeprecatedJoin
Eileen McNaughton [Wed, 28 Jul 2021 22:39:33 +0000 (10:39 +1200)]
Merge pull request #20968 from colemanw/fixDeprecatedJoin

SearchKit - fix deprecated join

3 years agoSearchKit - Use primary_key metadata instead of hard-coded string "id"
Coleman Watts [Fri, 23 Jul 2021 17:01:41 +0000 (13:01 -0400)]
SearchKit - Use primary_key metadata instead of hard-coded string "id"

3 years agoAPIv4 - Improve metadata about SQL functions, including translated labels
Coleman Watts [Fri, 23 Jul 2021 02:37:50 +0000 (22:37 -0400)]
APIv4 - Improve metadata about SQL functions, including translated labels

This splits the concept of prefix/suffix into prefix, flag_before and flag_after,
Since a prefix like ORDER BY is not the same as a flag like DISTINCT.
Lays the groundwork for exposing more info about SQL functiont to a UI like SearchKIt.

3 years agoREF - Use function rather than static variable to return SQLFunction params
Coleman Watts [Thu, 22 Jul 2021 22:37:51 +0000 (18:37 -0400)]
REF - Use function rather than static variable to return SQLFunction params

3 years ago[REF] minor fix - move last of processing before receipting
Eileen McNaughton [Wed, 28 Jul 2021 20:29:14 +0000 (08:29 +1200)]
[REF] minor fix - move last of processing before receipting

The moved items are in the middle of a long chunk that just deals with receipting  & message setting

3 years agoSearchKit - fix deprecated join
Coleman Watts [Wed, 28 Jul 2021 19:04:10 +0000 (15:04 -0400)]
SearchKit - fix deprecated join

Fixes dev/core#2689

3 years agoNFC - Reformat JSON file whitespace in Afform mock ext
Coleman Watts [Wed, 28 Jul 2021 19:00:39 +0000 (15:00 -0400)]
NFC - Reformat JSON file whitespace in Afform mock ext

3 years agoMerge pull request #20962 from eileenmcnaughton/float
colemanw [Wed, 28 Jul 2021 18:49:24 +0000 (14:49 -0400)]
Merge pull request #20962 from eileenmcnaughton/float

Cast to float when setting overrideTotalAmount - regression in master

3 years agoMerge pull request #20885 from eileenmcnaughton/param_replace
Mathieu Lu [Wed, 28 Jul 2021 18:22:04 +0000 (14:22 -0400)]
Merge pull request #20885 from eileenmcnaughton/param_replace

Invoice template: Add function to update message tokens during upgrade

3 years agoMerge pull request #20927 from alifrumin/priceplaceholder
Mathieu Lu [Wed, 28 Jul 2021 17:55:07 +0000 (13:55 -0400)]
Merge pull request #20927 from alifrumin/priceplaceholder

Improve accessibility for price fields of the type select by adding the price field label to the placeholder.

3 years agoMerge pull request #20837 from colemanw/customACLs
colemanw [Wed, 28 Jul 2021 17:25:18 +0000 (13:25 -0400)]
Merge pull request #20837 from colemanw/customACLs

 Distinguish custom field VIEW from EDIT permissions

3 years agoMerge pull request #20941 from eileenmcnaughton/ord
Monish Deb [Wed, 28 Jul 2021 12:15:42 +0000 (17:45 +0530)]
Merge pull request #20941 from eileenmcnaughton/ord

Fix Payment.create to update financial_item.status_id

3 years agoMerge pull request #20919 from JMAConsulting/issue_2710
Eileen McNaughton [Wed, 28 Jul 2021 08:38:51 +0000 (20:38 +1200)]
Merge pull request #20919 from JMAConsulting/issue_2710

dev/core#2710 Cannot disable contact type/sub-type

3 years agodev/core#2710 Cannot disable contact type/sub-type
Monish Deb [Wed, 28 Jul 2021 03:40:18 +0000 (09:10 +0530)]
dev/core#2710 Cannot disable contact type/sub-type

3 years agoCaching fixes
Eileen McNaughton [Tue, 27 Jul 2021 22:57:30 +0000 (10:57 +1200)]
Caching fixes

3 years agodev/core#2650 Add support for names & labels for token pseudoconstants
Eileen McNaughton [Tue, 27 Jul 2021 07:40:13 +0000 (19:40 +1200)]
dev/core#2650 Add support for names & labels for token pseudoconstants

This is per https://lab.civicrm.org/dev/core/-/issues/2650 -
it
- ensures that the 4 existing functions that deal with tokens handle tokens for the
name and label for the (only) field that has had this treatment so far -contribution_status_id

Hence both CRM_Core_SelecetValues::contributionTokens and CRM_Contribute_Tokens->tokenNames
are tested to ensure they both return the same keys and labels for
{contribution.contribution_status_id}
{contribution.contribution_status_id:name}
{contribution.contribution_status_id:label}

And both rendering CRM_Contribute_Tokens via scheduled reminders and
using CRM_Contribute_BAO_Contribution::replaceContributionTokens are tested to ensure
they render them the same.

In the context of this PR no existing tokens are altered or removed & there is
only addition. However, the next step would be to remove the following token
from  {contribution.status}. Since there is no UI availability
of this token it is likely unused - but that step would entail an upgrade
script to remove it from the saved scheduled reminders.

With those parts in place it should be possible to reconcile the remaining tokens,
lock that parity in with tests and move on to exposing the contribution tokens
to message templates.

It would be nice to fully remove CRM_Contribute_BAO_Contribution::replaceContributionTokens
or make it a wrapper for  - however, I fear that might be quite
challenging due to the way it's used with group bys & some pretty intense hackery.

3 years agoFix Payment.create to update financial_item.status_id
Eileen McNaughton [Fri, 23 Jul 2021 23:24:46 +0000 (11:24 +1200)]
Fix Payment.create to update financial_item.status_id

When I try to switch to the order->create flow for membership forms it turns
out we are leaving the financial_item.status_id as 'unpaid' when adding a payment.

No one has noticed because this field is kinda unused - but it needs to work
to pass tests

3 years agoFix order api to set price field value for default price set
Eileen McNaughton [Tue, 27 Jul 2021 23:37:00 +0000 (11:37 +1200)]
Fix order api to set price field value for default price set

This makes it such that when using the default price set for contributions it not only
fills the default price field id. I originally had this in the code but I pulled it out
because the line item test failed. However, I'm seeing cases where not
having a price_field_value_id fails to add tax and I think the issue with the line item
test is that it is, incorrecly, trying to add 2 line items on the price field in
the default price set - which is not actually the expectation on the default price set

I do, separately, wonder if we need the unique id for price_field_id + contribution_id
+ price_field_value_id - but out of scope on this

3 years agoMerge pull request #20964 from eileenmcnaughton/cast
Eileen McNaughton [Wed, 28 Jul 2021 00:58:49 +0000 (12:58 +1200)]
Merge pull request #20964 from eileenmcnaughton/cast

[REF] [Super trivial] -tighten up some casting

3 years ago[REF] [Super trivial] -tighten up some casting
Eileen McNaughton [Tue, 27 Jul 2021 23:11:21 +0000 (11:11 +1200)]
[REF] [Super trivial] -tighten up some casting

3 years agoMerge pull request #20308 from masetto/master
demeritcowboy [Tue, 27 Jul 2021 18:16:25 +0000 (14:16 -0400)]
Merge pull request #20308 from masetto/master

Fix unit translation for recurring contributions

3 years agofixed unit translation for recurring contributions
Samuele Masetto [Fri, 14 May 2021 17:33:34 +0000 (19:33 +0200)]
fixed unit translation for recurring contributions

small fix

 double "every" and `p` tag fixed, removed final `else`

3 years agoMerge pull request #20482 from MegaphoneJon/translation-69
demeritcowboy [Tue, 27 Jul 2021 13:36:03 +0000 (09:36 -0400)]
Merge pull request #20482 from MegaphoneJon/translation-69

fix missing 'on behalf of' and honoree labels in multilingual

3 years agoAdd function to update message tokens during upgrade
Eileen McNaughton [Fri, 16 Jul 2021 22:08:49 +0000 (10:08 +1200)]
Add function to update message tokens during upgrade

In conjunction with https://github.com/civicrm/civicrm-core/pull/20867

3 years agoCast to float when setting overrideTotalAmount
Eileen McNaughton [Tue, 27 Jul 2021 08:51:10 +0000 (20:51 +1200)]
Cast to float when setting overrideTotalAmount

This is a regression in master whereby submitting a new contribution and leaving total_amount empty
causes a fatal before it can get to the validation error - back office contribution form

3 years agoMerge pull request #20957 from demeritcowboy/smarty-tags
Eileen McNaughton [Tue, 27 Jul 2021 05:14:02 +0000 (17:14 +1200)]
Merge pull request #20957 from demeritcowboy/smarty-tags

Smarty notices for New Activity / New Case for tags for attachments

3 years agoMerge pull request #20955 from eileenmcnaughton/sql3
Seamus Lee [Tue, 27 Jul 2021 02:12:06 +0000 (12:12 +1000)]
Merge pull request #20955 from eileenmcnaughton/sql3

dev/core#2721 [Ref] simplify passed parameters

3 years agoMerge pull request #20956 from eileenmcnaughton/valid_fix
Seamus Lee [Tue, 27 Jul 2021 02:08:58 +0000 (12:08 +1000)]
Merge pull request #20956 from eileenmcnaughton/valid_fix

Fix test to use valid financials

3 years agoMerge pull request #20954 from eileenmcnaughton/sql2
Seamus Lee [Tue, 27 Jul 2021 02:08:28 +0000 (12:08 +1000)]
Merge pull request #20954 from eileenmcnaughton/sql2

dev/core#2721 [REF] Further divide savedSearchParam loading into the sql functions

3 years agoMerge pull request #20960 from civicrm/5.40
Seamus Lee [Tue, 27 Jul 2021 00:49:19 +0000 (10:49 +1000)]
Merge pull request #20960 from civicrm/5.40

5.40

3 years agoMerge pull request #20959 from alifrumin/rn5.40
Seamus Lee [Mon, 26 Jul 2021 22:10:23 +0000 (08:10 +1000)]
Merge pull request #20959 from alifrumin/rn5.40

[NFC] Release notes for 5.40

3 years agoMerge pull request #20685 from jaapjansma/dev_financials_6_contactsummary_3
Matthew Wire [Mon, 26 Jul 2021 21:01:43 +0000 (22:01 +0100)]
Merge pull request #20685 from jaapjansma/dev_financials_6_contactsummary_3

 dev/financial#6: Button for create/view template contribution on contact summary

3 years agoImprove accessibility for price fields of the type select by adding the field label...
Alice Frumin [Wed, 21 Jul 2021 15:03:12 +0000 (11:03 -0400)]
Improve accessibility for price fields of the type select by adding the field label to the placeholder text

3 years ago[NFC] 5.40: first stab at release notes
Alice Frumin [Thu, 15 Jul 2021 21:40:26 +0000 (17:40 -0400)]
[NFC] 5.40: first stab at release notes

3 years agoMerge pull request #20918 from eileenmcnaughton/cust2
demeritcowboy [Mon, 26 Jul 2021 19:16:23 +0000 (15:16 -0400)]
Merge pull request #20918 from eileenmcnaughton/cust2

dev/core#2709 Enable logging for custom data tables with non-standard names

3 years agoCase Dashboard: fix labels on my/all radio buttons, and simplify label text
Mathieu Lutfy [Mon, 26 Jul 2021 19:13:45 +0000 (15:13 -0400)]
Case Dashboard: fix labels on my/all radio buttons, and simplify label text

3 years agosmarty notices
demeritcowboy [Mon, 26 Jul 2021 15:14:02 +0000 (11:14 -0400)]
smarty notices

3 years agodev/financial#6 exclude template contributions from the contact summary and add a...
Jaap Jansma [Wed, 30 Jun 2021 11:04:08 +0000 (13:04 +0200)]
dev/financial#6 exclude template contributions from the contact summary and add a button to view them to the recurring contributions tab

dev/financial#6 exclude template contributions from the contact summary and add a button to view them to the recurring contributions tab

dev/financial#6 exclude template contributions from the contact summary and add a button to view them to the recurring contributions tab

dev/financial#6 exclude template contributions from the contact summary and add a button to view them to the recurring contributions tab

3 years agoMerge pull request #20867 from eileenmcnaughton/display_name
Mathieu Lu [Mon, 26 Jul 2021 12:56:26 +0000 (08:56 -0400)]
Merge pull request #20867 from eileenmcnaughton/display_name

Swap {$displayName} smarty for {contact.display_name} token

3 years agoMerge pull request #20939 from eileenmcnaughton/num_term
Seamus Lee [Mon, 26 Jul 2021 10:19:47 +0000 (20:19 +1000)]
Merge pull request #20939 from eileenmcnaughton/num_term

[Test] Add cover for setting num_terms to 2

3 years agoAdditional opt ins & outs on validateFinancials
Eileen McNaughton [Mon, 26 Jul 2021 05:28:06 +0000 (17:28 +1200)]
Additional opt ins & outs on validateFinancials

Ideally we opt in the class & opt out specific tests as an interim. Moving
towards opt in everything & opt out specific tests

3 years ago[Test] Opt a couple more classes into validateFinancials
Eileen McNaughton [Mon, 26 Jul 2021 05:26:00 +0000 (17:26 +1200)]
[Test] Opt a couple more classes into validateFinancials

3 years agoFix test to use valid financials
Eileen McNaughton [Mon, 26 Jul 2021 05:07:34 +0000 (17:07 +1200)]
Fix test to use valid financials

3 years agoMerge pull request #20948 from demeritcowboy/smarty-repdet
Eileen McNaughton [Mon, 26 Jul 2021 04:48:06 +0000 (16:48 +1200)]
Merge pull request #20948 from demeritcowboy/smarty-repdet

Smarty notices on logging detail report

3 years ago[Ref] simplify passed parameters
Eileen McNaughton [Mon, 26 Jul 2021 04:30:19 +0000 (16:30 +1200)]
[Ref] simplify passed parameters

I think if we want to make this some sort of hook or listener we don't really
want to pass out 'add select' and 'exclude clause' when they are just group id
with a bit of string. It seems cleaner to specify the sql within the function

3 years ago[REF] Further divide savedSearchParam loading into the sql functions
Eileen McNaughton [Mon, 26 Jul 2021 02:10:46 +0000 (14:10 +1200)]
[REF] Further divide savedSearchParam loading into the sql functions

3 years ago[REF] start unravelling the way we retrieve the saved search
Eileen McNaughton [Mon, 26 Jul 2021 01:56:41 +0000 (13:56 +1200)]
[REF] start unravelling the way we retrieve the saved search

We have 3 types of saved searches
- search kit
- legacy core searches
- legacy custom searches

The only information these 3 need to load is the savedSearch details and
the group ID (to add in the add & exclude). The wrangling of the params should
happen in the getSql functions - which we can think about being in a listener once
they have standard inputs & outputs. However, to get to that point
we want to standardise those inputs & outputs. This removes
only point of randomness - ie savedSearch has a consistent value & the wrangling
of what is in it is pushed closer to the relevant functions

3 years agoActivity tasks - don't add invalid tasks
Eileen McNaughton [Sun, 25 Jul 2021 22:04:35 +0000 (10:04 +1200)]
Activity tasks - don't add invalid tasks

Instead of 'handling the task code building invalid tasks - #20945' - this proposes to only attempt
to add a page if it is for a valid task. This keeps the grouchiness in the generic controller
to warn us of other mistakes.

This code is pretty fugly! However, it really is just called internally within this class.